Chris Plummer
74be2d9ef6
8286983: rename jdb -trackvthreads and debug agent enumeratevthreads options and clarify "Preview Feature" nature of these options
...
Reviewed-by: amenkov, lmesnik, alanb
2022-06-07 19:07:34 +00:00
Daniel D. Daugherty
e2cfe2e14a
8231491: JDI tc02x004 failed again due to wrong # of breakpoints
...
Reviewed-by: cjplummer
2022-06-03 22:17:16 +00:00
Alexey Ivanov
e0d361cea9
8284191: Replace usages of 'a the' in hotspot and java.base
...
Reviewed-by: lancea, wetmore, naoto, iris, kevinw, xuelei
2022-05-24 11:25:13 +00:00
Leonid Mesnik
7704eb1866
8284980: Test vmTestbase/nsk/stress/except/except010.java times out with -Xcomp -XX:+DeoptimizeALot
...
Reviewed-by: dcubed
2022-05-10 19:02:47 +00:00
Daniel D. Daugherty
61450bb061
8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
...
Reviewed-by: lmesnik
2022-05-09 22:03:55 +00:00
Alan Bateman
9583e3657e
8284161: Implementation of Virtual Threads (Preview)
...
Co-authored-by: Ron Pressler <rpressler@openjdk.org>
Co-authored-by: Alan Bateman <alanb@openjdk.org>
Co-authored-by: Erik Österlund <eosterlund@openjdk.org>
Co-authored-by: Andrew Haley <aph@openjdk.org>
Co-authored-by: Rickard Bäckman <rbackman@openjdk.org>
Co-authored-by: Markus Grönlund <mgronlun@openjdk.org>
Co-authored-by: Leonid Mesnik <lmesnik@openjdk.org>
Co-authored-by: Serguei Spitsyn <sspitsyn@openjdk.org>
Co-authored-by: Chris Plummer <cjplummer@openjdk.org>
Co-authored-by: Coleen Phillimore <coleenp@openjdk.org>
Co-authored-by: Robbin Ehn <rehn@openjdk.org>
Co-authored-by: Stefan Karlsson <stefank@openjdk.org>
Co-authored-by: Thomas Schatzl <tschatzl@openjdk.org>
Co-authored-by: Sergey Kuksenko <skuksenko@openjdk.org>
Reviewed-by: lancea, eosterlund, rehn, sspitsyn, stefank, tschatzl, dfuchs, lmesnik, dcubed, kevinw, amenkov, dlong, mchung, psandoz, bpb, coleenp, smarks, egahlin, mseledtsov, coffeys, darcy
2022-05-07 08:06:16 +00:00
Alex Menkov
1bba64070e
8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing
...
Reviewed-by: sspitsyn, cjplummer
2022-05-05 19:41:41 +00:00
Chris Plummer
5c0934931b
8285032: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected"
...
Reviewed-by: sspitsyn, amenkov
2022-04-27 20:38:18 +00:00
Andrey Turbanov
48c7549806
8284853: Fix various 'expected' typo
...
Reviewed-by: bpb, ihse
2022-04-14 18:05:49 +00:00
Feilong Jiang
de9596c290
8284495: [testbug] Adapt nsk tests to the RISC-V platform
...
Reviewed-by: lmesnik, cjplummer
2022-04-08 00:58:53 +00:00
Chris Plummer
f9f439a19d
8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
...
Reviewed-by: lmesnik, amenkov, sspitsyn
2022-03-29 18:37:27 +00:00
Andrey Turbanov
dc5a65ab37
8283426: Fix 'exeption' typo
...
Reviewed-by: xuelei, iris, dholmes, wetmore, aivanov
2022-03-24 19:52:16 +00:00
Daniel D. Daugherty
bb7ee5a04a
8282314: nsk/jvmti/SuspendThread/suspendthrd003 may leak memory
...
Reviewed-by: dholmes, cjplummer, amenkov, lmesnik, mseledtsov
2022-03-10 19:13:55 +00:00
Chris Plummer
ff76620487
8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default
...
Reviewed-by: kevinw, amenkov
2022-03-09 19:42:47 +00:00
Matteo Baccan
ccad39237a
8282657: Code cleanup: removing double semicolons at the end of lines
...
Reviewed-by: lancea, rriggs, ihse, prr, iris, wetmore, darcy, dholmes
2022-03-07 21:33:40 +00:00
Alex Menkov
f12200cd11
8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
...
Reviewed-by: kevinw, cjplummer
2022-03-02 10:54:25 +00:00
Evgeny Astigeevich
afd065b368
8278415: [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE"
...
Reviewed-by: phh
2021-12-10 18:27:36 +00:00
Serguei Spitsyn
3893f4f70b
8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state
...
Reviewed-by: amenkov, lmesnik
2021-12-08 22:32:00 +00:00
Tim Prinzing
652b5f8546
8276674: Malformed Javadoc inline tags in JDK source
...
Reviewed-by: jjg, rriggs, prappo, bchristi
2021-12-02 20:47:29 +00:00
Liam Miller-Cushon
27299eaa98
8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found"
...
Reviewed-by: dholmes, cjplummer, sspitsyn
2021-11-30 01:34:52 +00:00
Leonid Mesnik
96fe1d0d4d
8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
...
Reviewed-by: sspitsyn, dholmes
2021-11-24 20:11:18 +00:00
Leonid Mesnik
7cb56a230d
8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416
...
Reviewed-by: cjplummer, mchung
2021-11-23 19:27:50 +00:00
Harold Seigel
9f2f46ee45
8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows
...
Reviewed-by: coleenp
2021-11-17 14:25:17 +00:00
Jakob Cornell
c7f070f5f1
8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output"
...
Reviewed-by: cjplummer, iklam
2021-11-03 18:18:16 +00:00
Jakob Cornell
fe6a202087
8271356: Modify jdb to treat an empty command as a repeat of the previous command
...
Reviewed-by: cjplummer, iklam
2021-10-29 17:50:19 +00:00
Harold Seigel
7ca053de21
8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
...
Reviewed-by: dholmes, lmesnik
2021-10-26 12:37:54 +00:00
Coleen Phillimore
cd07b3cab0
8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
...
Reviewed-by: hseigel
2021-10-21 11:46:24 +00:00
Patricio Chilano Mateo
9573022978
8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
...
Reviewed-by: dholmes, cjplummer, sspitsyn
2021-09-30 16:02:14 +00:00
Leonid Mesnik
a72c8aa6ad
8273921: Refactor NSK/JDI tests to create thread using factory
...
Reviewed-by: cjplummer, sspitsyn, amenkov
2021-09-21 23:36:16 +00:00
Alex Menkov
5fde4b64e2
8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
...
Reviewed-by: cjplummer, sspitsyn
2021-09-20 20:17:57 +00:00
Alex Menkov
8c022e2c17
8270434: JDI+UT: Unexpected event in JDI tests
...
Reviewed-by: sspitsyn, kevinw
2021-09-16 23:45:08 +00:00
Aleksey Shipilev
5ca26cbddb
8273433: Enable parallelism in vmTestbase_nsk_sysdict tests
...
Reviewed-by: mseledtsov, dholmes
2021-09-09 13:41:46 +00:00
Alex Menkov
18a731a3e4
8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
...
Reviewed-by: sspitsyn, kevinw
2021-08-31 22:43:12 +00:00
Alex Menkov
b62e742045
8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use"
...
Reviewed-by: sspitsyn, cjplummer
2021-08-10 19:13:18 +00:00
Emmanuel Bourg
d09b028407
8271396: Spelling errors
...
Reviewed-by: tschatzl, chegar, iris, psadhukhan, cjplummer
2021-07-29 16:03:31 +00:00
David Holmes
fde183130b
8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup
...
Reviewed-by: stuefe, iignatyev
2021-07-27 02:49:34 +00:00
Leonid Mesnik
3cadc36060
8270336: [TESTBUG] Fix initialization in NonbranchyTree
...
Reviewed-by: kbarrett, tschatzl
2021-07-22 18:17:09 +00:00
Jesper Wilhelmsson
ee526a2ea8
Merge
2021-06-30 01:19:39 +00:00
Chris Plummer
401cb0ad55
8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
...
Reviewed-by: rkennke, amenkov, sspitsyn, sgehwolf
2021-06-29 18:41:19 +00:00
Jesper Wilhelmsson
a29953d805
Merge
2021-06-27 23:51:05 +00:00
Alex Menkov
1404e4bf44
8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433
...
Reviewed-by: kevinw, dcubed
2021-06-25 22:10:48 +00:00
Alex Menkov
51d915979c
8236212: CompiledMethodLoad and CompiledMethodUnload events can be posted in START phase
...
Reviewed-by: sspitsyn, cjplummer
2021-06-24 00:29:36 +00:00
Daniel D. Daugherty
f677163b8a
8266130: convert Thread-SMR stress tests from counter based to time based
...
Reviewed-by: cjplummer, dholmes
2021-06-10 13:09:26 +00:00
Serguei Spitsyn
dd1cbadc82
8268285: vmTestbase/nsk/jvmti/GetThreadState/thrstat002 failed with "Wrong thread "thr1" (...) state after SuspendThread"
...
Reviewed-by: lmesnik, amenkov, dholmes
2021-06-10 06:03:19 +00:00
Alex Menkov
b568e87947
8237388: serviceability/dcmd/framework/VMVersionTest.java fails with connection refused error.
...
Reviewed-by: cjplummer, sspitsyn
2021-06-08 17:05:22 +00:00
David Holmes
dc19baca33
8268094: Some vmTestbase/nsk tests fail after ACC_STRICT/strictfp changes
...
Reviewed-by: vlivanov, rehn
2021-06-02 12:23:56 +00:00
Alex Menkov
9713152eae
8262092: vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java SIGSEGV in memmove_ssse3
...
Reviewed-by: lmesnik, sspitsyn
2021-05-10 22:48:01 +00:00
Alex Menkov
0ca86da0e3
8266002: vmTestbase/nsk/jvmti/ClassPrepare/classprep001 should skip events for unexpected classes
...
Reviewed-by: cjplummer, sspitsyn
2021-05-06 18:38:11 +00:00
Alex Menkov
2a5e0dd360
8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"
...
Reviewed-by: cjplummer, lmesnik, sspitsyn
2021-03-25 19:47:35 +00:00
Anton Kozlov
dbc9e4b50c
8253795: Implementation of JEP 391: macOS/AArch64 Port
...
8253816: Support macOS W^X
8253817: Support macOS Aarch64 ABI in Interpreter
8253818: Support macOS Aarch64 ABI for compiled wrappers
8253819: Implement os/cpu for macOS/AArch64
8253839: Update tests and JDK code for macOS/Aarch64
8254941: Implement Serviceability Agent for macOS/AArch64
8255776: Change build system for macOS/AArch64
8262903: [macos_aarch64] Thread::current() called on detached thread
Co-authored-by: Vladimir Kempik <vkempik@openjdk.org>
Co-authored-by: Bernhard Urban-Forster <burban@openjdk.org>
Co-authored-by: Ludovic Henry <luhenry@openjdk.org>
Co-authored-by: Monica Beckwith <mbeckwit@openjdk.org>
Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry
2021-03-25 18:10:18 +00:00
Leonid Mesnik
f62b1008ed
8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices
...
Reviewed-by: amenkov, kevinw
2021-03-22 17:56:54 +00:00
Alex Menkov
6737135b14
8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
...
Reviewed-by: lmesnik, cjplummer
2021-03-19 20:13:05 +00:00
Alex Menkov
57fc8e9b35
8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
...
Reviewed-by: cjplummer, sspitsyn
2021-03-19 20:11:32 +00:00
Coleen Phillimore
e34f766b7e
8252723: Run stack016.java also with C2-only
...
Reviewed-by: mseledtsov, iklam
2021-03-18 20:00:55 +00:00
Igor Ignatyev
a7aba2b61c
8263549: 8263412 can cause jtreg testlibrary split
...
Reviewed-by: iklam, dcubed
2021-03-13 14:51:53 +00:00
Harold Seigel
b38d5be887
8261340: Fix 'deprecated' warnings in the vmTestbase/nsk tests
...
Reviewed-by: lfoltan, sspitsyn
2021-02-09 13:16:26 +00:00
Harold Seigel
db0ca2b9d4
8261161: Clean up warnings in hotspot/jtreg/vmTestbase tests
...
Reviewed-by: lfoltan, coleenp
2021-02-08 13:19:40 +00:00
Leonid Mesnik
f5ca8385ab
8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier
...
Reviewed-by: sspitsyn, coleenp
2021-01-29 20:49:40 +00:00
Igor Veresov
1519632597
8251462: Simplify compilation policy
...
Reviewed-by: cjplummer, kvn
2021-01-28 20:51:12 +00:00
Leonid Mesnik
d7d34dd964
8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect
...
Reviewed-by: iignatyev, sspitsyn, cjplummer
2021-01-15 19:33:23 +00:00
Hao Sun
4ea88512dd
8257928: Test image build failure with clang-10 due to -Wmisleading-indentation
...
Reviewed-by: amenkov, cjplummer
2020-12-23 01:32:05 +00:00
Per Liden
79f1dfb8d3
8255987: JDI tests fail with com.sun.jdi.ObjectCollectedException
...
Reviewed-by: dholmes, cjplummer
2020-12-09 07:46:04 +00:00
Leonid Mesnik
3e89981d98
8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout
...
Reviewed-by: sspitsyn, dcubed
2020-12-02 20:16:28 +00:00
Coleen Phillimore
cfb50a9cb7
8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64
...
Reviewed-by: stuefe, sspitsyn, dholmes
2020-12-02 13:40:26 +00:00
Stefan Johansson
9de283b891
8257505: nsk/share/test/StressOptions stressTime is scaled in getter but not when printed
...
Reviewed-by: kbarrett, dholmes
2020-12-02 08:53:54 +00:00
Alex Menkov
2a1e9be6c2
8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"
...
Reviewed-by: cjplummer, sspitsyn
2020-11-24 17:49:55 +00:00
Guoxiong Li
5fedb69e66
8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
...
Reviewed-by: cjplummer, sspitsyn
2020-11-20 07:02:48 +00:00
Coleen Phillimore
ba721f5f2f
8212879: Make JVMTI TagMap table concurrent
...
Co-authored-by: Kim Barrett <kbarrett@openjdk.org>
Co-authored-by: Coleen Phillimore <coleenp@openjdk.org>
Reviewed-by: stefank, ihse, zgu, eosterlund, sspitsyn, kbarrett
2020-11-19 14:30:02 +00:00
Robbin Ehn
c5fe2c1fcb
8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8"
...
Reviewed-by: pchilanomate, dcubed, dholmes, sspitsyn
2020-11-16 13:06:45 +00:00
Stefan Karlsson
6a69e304dd
8256337: ap01t001.cpp, 67: Received unexpected number of ObjectFree events: 7
...
Reviewed-by: coleenp, sspitsyn
2020-11-16 07:58:40 +00:00
Alex Menkov
a9dff9420a
8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
...
Reviewed-by: sspitsyn, cjplummer
2020-11-06 21:57:43 +00:00
Alex Menkov
b9186bebc3
6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")
...
Reviewed-by: sspitsyn, cjplummer
2020-10-21 23:40:48 +00:00
Markus Grönlund
e10b53853a
8243962: Various JVM TI tests time out using JFR on Windows
...
Reviewed-by: sspitsyn, cjplummer
2020-10-19 09:18:40 +00:00
Stefan Karlsson
672f56695e
8254874: ZGC: JNIHandleBlock verification failure in stack watermark processing
...
Reviewed-by: tschatzl, cjplummer, sspitsyn, pliden
2020-10-19 07:22:29 +00:00
Alex Menkov
cd33abb136
8249623: test @ignore-d due to 7013634 should be returned back to execution
...
Reviewed-by: cjplummer, sspitsyn
2020-10-14 17:49:42 +00:00
Vladimir Kempik
c7f0064062
8253899: Make IsClassUnloadingEnabled signature match specification
...
Reviewed-by: sspitsyn, dholmes
2020-10-12 13:16:28 +00:00
Igor Ignatyev
55c282bb34
8253878: clean up nsk/share/jvmti/ArgumentHandler
...
Reviewed-by: cjplummer
2020-09-30 23:34:06 +00:00
Igor Ignatyev
ca0e014e60
8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
...
Reviewed-by: cjplummer, sspitsyn
2020-09-30 21:37:12 +00:00
Igor Ignatyev
4b16f8ab94
8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
...
Reviewed-by: cjplummer
2020-09-30 20:03:20 +00:00
Igor Ignatyev
8f7c9a7b18
8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi
...
Reviewed-by: cjplummer, sspitsyn
2020-09-30 16:18:27 +00:00
Igor Ignatyev
1eca634736
8252000: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdb
...
Reviewed-by: shade, cjplummer, sspitsyn
2020-09-30 03:03:53 +00:00
Igor Ignatyev
a55cde4d6b
8252002: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdwp
...
Reviewed-by: cjplummer, sspitsyn
2020-09-30 02:43:10 +00:00
Igor Ignatyev
9ac162e896
8251999: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/aod
...
Reviewed-by: shade, sspitsyn
2020-09-24 16:32:05 +00:00
Harold Seigel
ce93cbce77
8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
...
Reviewed-by: dcubed
2020-09-16 18:58:06 +00:00
Igor Ignatyev
5f76deb2e0
8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor
...
Reviewed-by: dholmes
2020-09-06 16:17:30 +00:00
Igor Ignatyev
15af276157
8252004: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/sysdict
...
Reviewed-by: dcubed, gziemski
2020-09-04 10:36:05 -07:00
Harold Seigel
f3597c4a54
8252249: nsk/stress/stack/stack016.java fails with "Error: TEST_BUG: trickyRecursion() must throw an error anyway!"
...
Run test separately with both -Xint and -Xcomp to ensure thread stacks are similarly sized.
Reviewed-by: dholmes, coleenp
2020-09-02 13:50:39 +00:00
Igor Ignatyev
ca3374253c
8252402: rewrite vmTestbase/nsk/jvmti/Allocate/alloc001 shell test to Java
...
Reviewed-by: amenkov
2020-09-01 17:29:34 -07:00
Igor Ignatyev
4fe6a3da68
8252532: use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")
...
Reviewed-by: dholmes, sspitsyn
2020-09-01 17:23:00 -07:00
Igor Ignatyev
00452d32f5
8252477: nsk/share/ArgumentParser should expect that jtreg "splits" an argument
...
Reviewed-by: sspitsyn, dholmes
2020-08-27 19:37:51 -07:00
Nick Gasson
7856c1a311
8252108: Modify nsk/stress/stack tests to check page size
...
Reviewed-by: hseigel, stuefe
2020-08-26 11:28:10 +08:00
Igor Ignatyev
b2da6e1a90
8252005: narrow disabling of allowSmartActionArgs in vmTestbase
...
Reviewed-by: sspitsyn
2020-08-20 11:12:00 -07:00
Harold Seigel
93c00472eb
8251490: [TESTBUG] The Java thread stack size specified is too small for nsk/stress/stack. Specify at least 448k
...
Increase the -Xss stack size for some tests, mark other tests as not runnable on AArch64.
Reviewed-by: gziemski, lfoltan
2020-08-19 19:40:46 +00:00
Igor Ignatyev
b37b1a391a
8251126: nsk.share.GoldChecker should read golden file from ${test.src}
...
Reviewed-by: dholmes
2020-08-05 16:39:38 -07:00
Leonid Mesnik
13946835b5
8244537: JDI tests fail due to "ERROR: Exception : nsk.share.jdi.JDITestRuntimeException: JDITestRuntimeException : ** event IS NOT a breakpoint **"
...
Reviewed-by: sspitsyn, amenkov
2020-08-05 10:48:55 -07:00
Igor Ignatyev
0019679c69
8251190: nsk jdi tests failing "TestBug: Exception during config file parsing: java.io.FileNotFoundException"
...
Reviewed-by: dholmes, sspitsyn
2020-08-05 08:57:21 -07:00
Harold Seigel
c200b4f1cb
8139875: [TESTBUG] Improve nsk/stress/stack/* tests
...
Use -Xss200k to limit the stack size, avoid running with -Xcomp, and, in one test, reduce iterations.
Reviewed-by: dholmes, lfoltan
2020-08-05 13:27:43 +00:00
Igor Ignatyev
61ebb6adb7
8249030: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_jdi tests
...
Reviewed-by: dholmes, sspitsyn
2020-08-04 20:05:47 -07:00
Jie Fu
30c8811d11
8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits
...
Reviewed-by: dholmes, cjplummer, sspitsyn
2020-08-05 10:54:18 +08:00
Yasumasa Suenaga
39616b4d7c
8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization
...
Reviewed-by: cjplummer, dholmes
2020-08-04 15:28:27 +09:00
Harold Seigel
99ae9558fe
8250562: Clean up weird comment in vmTestbase class Terminator.java
...
Delete the weird comment.
Reviewed-by: lfoltan
2020-07-28 20:14:01 +00:00
Daniil Titov
277ec3d260
8216324: GetClassMethods is confused by the presence of default methods in super interfaces
...
Reviewed-by: sspitsyn, amenkov
2020-07-27 11:34:19 -07:00
Harold Seigel
9b73fb125d
8250557: Rename vmTestbase/nsk shared timeout handler package to Terminator.java
...
Rename the class and fix the tests that use it.
Reviewed-by: dcubed
2020-07-24 18:44:27 +00:00
Mikael Vidstedt
1f5e21a16e
Merge
2020-07-15 21:24:39 -07:00
Igor Ignatyev
e07ad838b5
8249040: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_jdb tests
...
Reviewed-by: dholmes
2020-07-15 11:34:34 -07:00
Igor Ignatyev
b27e717c56
8249034: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_jvmti tests
...
Reviewed-by: sspitsyn
2020-07-15 11:33:43 -07:00
Igor Ignatyev
1b5391264a
8249039: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_aod tests
...
Reviewed-by: dholmes, sspitsyn
2020-07-15 11:31:35 -07:00
Mikael Vidstedt
1982432db4
Merge
2020-07-14 23:29:45 -07:00
Leonid Mesnik
590de670a9
8242891: vmTestbase/nsk/jvmti/ test should be fixed to fail early if JVMTI function return error
...
Reviewed-by: sspitsyn, cjplummer
2020-07-14 14:31:14 -07:00
Igor Ignatyev
6d201dbba6
8249036: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_stress tests
...
Reviewed-by: kvn
2020-07-14 11:24:39 -07:00
Igor Ignatyev
919eb12b14
8249032: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_sysdict tests
...
Reviewed-by: dholmes
2020-07-14 11:16:00 -07:00
Igor Ignatyev
6c95a87157
8249035: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_jdwp tests
...
Reviewed-by: dholmes
2020-07-14 11:10:40 -07:00
Igor Ignatyev
ba1db57dde
8249028: clean up FileInstaller $test.src $cwd in vmTestbase_nsk_monitoring tests
...
Reviewed-by: dholmes
2020-07-14 11:09:34 -07:00
Igor Ignatyev
5899ef11fb
8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly
...
Reviewed-by: tschatzl
2020-07-02 11:38:00 -07:00
Igor Ignatyev
72ae322022
8208207: Test nsk/stress/jni/gclocker/gcl001 fails after co-location
...
Reviewed-by: tschatzl
2020-07-02 08:05:00 -07:00
Fairoz Matte
b9ce3b435e
8243451: nsk.share.jdi.Debugee.isJFR_active() is incorrect and corresponsing logic seems to be broken
...
Fix check isJFR_active()
Reviewed-by: sspitsyn, lmesnik
2020-06-11 08:23:09 +00:00
Igor Ignatyev
dc91b06661
8244614: cleanup keywords used/available in hotspot testbase
...
Reviewed-by: coleenp, mseledtsov
2020-06-08 21:27:22 -07:00
Jesper Wilhelmsson
c782d0e486
Merge
2020-07-07 23:42:50 +02:00
Jesper Wilhelmsson
6b8bf62a75
Merge
2020-07-03 00:14:21 +02:00
Daniel D. Daugherty
7d54e71d38
8246493: JDI stress/serial/mixed002 needs to use WhiteBox.deflateIdleMonitors support
...
Reviewed-by: cjplummer, sspitsyn
2020-06-30 15:24:01 -04:00
Leonid Mesnik
bac2e7fcad
8242328: Update mentions of ThreadMBean to ThreadMXBean
...
Reviewed-by: dholmes, iignatyev, sspitsyn
2020-06-12 14:33:55 -07:00
Leonid Mesnik
6341f8c077
8244965: Incorrect error message in vmTestbase/nsk/jdi/VirtualMachine/suspend/suspend001/TestDescription.java
...
Reviewed-by: dholmes
2020-06-11 14:03:00 -07:00
Mikael Vidstedt
071bd521bc
8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports
...
Reviewed-by: alanb, bchristi, dcubed, dfuchs, eosterlund, erikj, glaubitz, ihse, iignatyev, jjiang, kbarrett, ksrini, kvn, naoto, prr, rriggs, serb, sspitsyn, stefank, tschatzl, valeriep, weijun, weijun
2020-05-20 17:33:37 -07:00
Stefan Karlsson
81597d9f8f
8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts
...
Reviewed-by: dholmes, cjplummer
2020-05-04 21:20:39 +02:00
Leonid Mesnik
df182ea6e0
8244133: Refactor nsk/jdi tests to reduce code duplication in settingBreakpoint communication
...
Reviewed-by: cjplummer, sspitsyn
2020-05-04 11:40:09 -07:00
Alan Bateman
c7b1b1bb74
8244284: Two tests in test/hotspot/jtreg/vmTestbase fail with --illegal-access=deny
...
Reviewed-by: iignatyev
2020-05-04 12:45:12 +01:00
Igor Ignatyev
eb6ef3c24d
8243436: use reproducible random in :vmTestbase_nsk_monitoring
...
Reviewed-by: sspitsyn, cjplummer
2020-05-01 16:23:06 -07:00
Igor Ignatyev
d29e5b72f0
8243435: use reproducible random in :vmTestbase_nsk_jvmti
...
Reviewed-by: sspitsyn, cjplummer
2020-05-01 16:22:20 -07:00
Igor Ignatyev
56fcd54843
8243437: use reproducible random in :vmTestbase_nsk_jdi
...
Reviewed-by: sspitsyn, cjplummer
2020-05-01 16:21:20 -07:00
Igor Ignatyev
eaf3306e44
8243433: use reproducible random in :vmTestbase_nsk_sysdict
...
Reviewed-by: dholmes
2020-05-01 09:20:48 -07:00
Igor Ignatyev
0264b050f6
8243429: use reproducible random in :vmTestbase_nsk_stress
...
Reviewed-by: epavlova, dholmes
2020-05-01 09:19:55 -07:00
Serguei Spitsyn
0783dd69a5
8241807: JDWP needs update for hidden classes
...
Introduce test coverage for hidden class events
Reviewed-by: lmesnik, amenkov
2020-04-29 06:33:10 +00:00
Igor Ignatyev
6ff66db553
8242314: use reproducible random in vmTestbase shared code
...
Reviewed-by: kbarrett, lmesnik
2020-04-28 20:49:28 -07:00
Igor Ignatyev
70e632d5ec
8243935: remove copying of s.h.WB$WhiteBoxPermission in hotspot tests
...
Reviewed-by: dholmes, stefank
2020-04-28 19:57:02 -07:00
Serguei Spitsyn
e507405f5c
8241214: Test debugging of hidden classes using jdb
...
Add test and enable jdb support for hidden classes
Reviewed-by: cjplummer, amenkov, mchung, lmesnik
2020-04-23 07:46:18 +00:00
Igor Ignatyev
15464b36c3
8242471: remove "temporarily" restrictions of nsk/jdi/Argument/value/value004
...
Reviewed-by: amenkov, cjplummer
2020-04-13 12:30:07 -07:00
Leonid Mesnik
3a6249d0c7
8242295: Change ThreadMBean in vmTestbase/nsk/monitoring to ThreadMXBean
...
Reviewed-by: iignatyev
2020-04-08 13:14:19 -07:00
Leonid Mesnik
a76f0f78ad
8241456: ThreadRunner shouldn't use Wicket for threads starting synchronization
...
Reviewed-by: dholmes, iignatyev
2020-04-02 17:30:21 -07:00
Leonid Mesnik
e7204cbc52
8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible
...
Reviewed-by: iignatyev, sspitsyn
2020-03-20 00:24:08 -07:00
Stefan Karlsson
c8e7590899
8237111: LingeredApp should be started with getTestJavaOpts
...
Reviewed-by: cjplummer, dholmes
2020-01-24 10:31:45 +01:00
Mikael Vidstedt
3318314c7c
8237589: Fix copyright header formatting
...
Reviewed-by: jjg, serb, iris, jwilhelm
2020-01-21 14:23:01 -08:00
Leonid Mesnik
dc0cc5520c
8235530: Removed duplicated threadByName methods in nsk/jdi tests
...
Reviewed-by: dholmes, sspitsyn
2019-12-09 13:02:07 -08:00
Coleen Phillimore
d1d57d9446
8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators
...
Call extension ClassUnload event as a deferred event from the ServiceThread and remove unsafe arguments
Reviewed-by: sspitsyn, dholmes
2019-12-02 09:02:17 -05:00
Serguei Spitsyn
5df8729406
8221372: Test vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java times out
...
Update test to get rid of unneeded MethodEntry/MethodExit events
Reviewed-by: amenkov, cjplummer
2019-11-26 02:32:32 +00:00
Serguei Spitsyn
0a1737ca97
8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method
...
Add necessary check to GetLocalInstance implementation
Reviewed-by: amenkov, cjplummer
2019-11-22 10:07:21 +00:00
Leo Korinth
1fc67ab002
8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector
...
Reviewed-by: kbarrett, tschatzl, erikj, coleenp, dholmes
2019-11-13 11:37:29 +01:00
Jan Lahoda
29852ecd80
8232684: Make switch expressions final
...
Reviewed-by: alanb, mcimadamore, kvn
2019-11-12 06:32:13 +00:00
Per Lidén
a8c4e6786d
8231552: ZGC: Refine address space reservation
...
Reviewed-by: eosterlund, stefank
2019-10-24 17:24:58 +02:00
Claes Redestad
574263a884
8232613: Move Object.registerNatives into HotSpot
...
Reviewed-by: dholmes, adinn, coleenp, lfoltan, mchung
2019-10-24 09:57:29 +02:00
David Holmes
f3df804e24
8231289: Disentangle JvmtiRawMonitor from ObjectMonitor and clean it up
...
Reviewed-by: sspitsyn, dcubed, coleenp
2019-10-07 18:44:53 -04:00
Leonid Mesnik
2cb764b24b
8231768: Remove duplicate if/else in vmTestbase/nsk/share/jdi/Binder.java
...
Reviewed-by: sspitsyn, phh, cjplummer
2019-10-03 08:50:10 -07:00
Per Lidén
990ec34714
8231296: ZGC: vmTestbase/nsk/jvmti/Allocate/alloc001/ fails
...
Reviewed-by: sspitsyn, dcubed, iignatyev
2019-10-01 12:27:14 +02:00
Doug Lea
8c647801fc
8231036: vmTestbase monitoring tests fail after JSR 166 refresh
...
Reviewed-by: martin, dholmes
2019-09-27 12:20:14 -07:00
Per Lidén
cf5af650de
8231294: ZGC: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted002 fails
...
Reviewed-by: shade, dholmes
2019-09-26 13:56:58 +02:00
Paul Hohensee
1bce27d402
8231209: [REDO] ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread
...
Add com.sun.management.getCurrentThreadAllocatedBytes, implement getThreadAllocatedBytes(long) independent of getThreadAllocatedBytes(long[])
Reviewed-by: mchung, dholmes, sspitsyn
2019-09-25 15:22:33 -07:00
Ivan Gerasimov
9898fc1382
8230303: JDB hangs when running monitor command
...
Reviewed-by: sspitsyn
2019-09-10 09:08:52 -07:00
David Holmes
8b42387ea6
8227563: jvmti/scenarios/contention/TC05/tc05t001 fails due to "ERROR: tc05t001.cpp, 278: (waitedThreadCpuTime - waitThreadCpuTime) < (EXPECTED_ACCURACY * 1000000)"
...
Reviewed-by: amenkov, cjplummer, sspitsyn
2019-09-05 18:39:22 -04:00
Jean Christophe Beyler
b036071125
8229036: Remove the testing against NSK_TRUE from tests
...
Remove the testing against NSK_TRUE from tests
Reviewed-by: sspitsyn, cjplummer
2019-08-08 04:29:56 -07:00
Jean Christophe Beyler
76b7c9a0ce
8228998: Remove the testing against NSK_FALSE from tests
...
Remove the testing against NSK_FALSE from tests
Reviewed-by: cjplummer, sspitsyn
2019-08-02 11:24:59 -07:00
Nils Eliasson
019b9891d7
8226536: Catch OOM from deopt that fails rematerializing objects
...
Reviewed-by: vlivanov, thartmann
2019-07-10 18:48:05 +02:00
Matthias Baesken
4dececb589
8226943: compile error in libfollowref003.cpp with XCode 10.2 on macosx
...
Reviewed-by: sspitsyn
2019-06-28 13:16:11 +02:00
Serguei Spitsyn
ff1f2fad6e
8226917: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails on jvmti->InterruptThread (JVMTI_ERROR_THREAD_NOT_ALIVE)
...
Fix one more sync issue in the test
Reviewed-by: dcubed, gadams, amenkov
2019-06-28 16:06:44 -07:00
Serguei Spitsyn
8cf8442085
8226595: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java still fails due to wrong number of MonitorContendedEntered events
...
Fix one more sync issue in the test
Reviewed-by: dcubed, amenkov
2019-06-22 14:35:57 -07:00
Serguei Spitsyn
fc6de2505d
8224555: vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001/TestDescription.java failed
...
Improve synchronization in the test
Reviewed-by: dcubed, amenkov
2019-06-21 18:20:49 -07:00
Coleen Phillimore
3ba752295e
8226394: [TESTBUG] vmTestbase/metaspace/flags/maxMetaspaceSize/TestDescription.java fails with java.lang.NoClassDefFoundError
...
Don't use printStackTrace to verify OOM type.
Reviewed-by: lfoltan, dholmes
2019-06-21 09:53:12 -04:00
Serguei Spitsyn
fc6b87472c
8223736: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails due to wrong number of MonitorContendedEntered events
...
Fix the synchronization issue in the test
Reviewed-by: cjplummer, dcubed, amenkov
2019-06-20 23:12:12 -07:00
Igor Ignatyev
2329e64f2b
8208236: [TESTBUG] vmTestbase/nsk/stress/stack tests fail by timeout
...
Reviewed-by: dholmes
2019-06-12 21:17:26 -07:00
Daniil Titov
2f1b1de1e8
8222828: vmTestbase/nsk/jdi/BScenarios/multithrd/tc02x004/TestDescription.java failed
...
Reviewed-by: cjplummer, gadams, jcbeyler
2019-06-10 09:41:09 -07:00
Daniil Titov
f198fdd639
8206074: nsk/jdi/EventRequestManager/createStepRequest/crstepreq001/TestDescription.java is timing out
...
Reviewed-by: cjplummer, gadams
2019-06-06 18:57:28 -07:00
Coleen Phillimore
f855474b0d
8222468: [TESTBUG] vmTestbase/metaspace/flags/maxMetaspaceSize/TestDescription.java fails with java.lang.NoClassDefFoundError
...
Preload StackTraceElement$HashedModules in test.
Reviewed-by: lmesnik, dholmes
2019-06-04 10:29:42 -04:00
Serguei Spitsyn
110ead8bea
8223718: Checks in check_slot_type_no_lvt() should be always executed
...
Call check_slot_type_no_lvt() even if the LVT is present
Reviewed-by: kvn, gadams, amenkov
2019-05-30 15:55:16 -07:00
Alex Menkov
e18cecafb9
8184770: JDWP support for IPv6
...
Reviewed-by: sspitsyn, chegar
2019-05-15 11:06:33 -07:00
Jean Christophe Beyler
68ae1e7965
8223044: Add back exception checking in tests
...
Add exception checking to previously modified tests
Reviewed-by: sspitsyn, cjplummer
2019-05-07 07:43:41 -07:00
Daniil Titov
5a264ba9db
8222667: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter002/TestDescription.java failed with "event IS NOT a breakpoint"
...
Reviewed-by: gadams, sspitsyn, jcbeyler, cjplummer
2019-05-06 09:58:14 -07:00
Jean Christophe Beyler
95b5fba3d7
8223146: [TESTBUG] new test vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/ fails on Windows
...
Keep it simple and handle INT32_MIN separately
Reviewed-by: dholmes, sspitsyn
2019-04-30 20:26:16 -07:00
Daniil Titov
b505fd128d
8222749: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "eventSet1.size() != 3 :: 2"
...
Reviewed-by: sspitsyn, jcbeyler
2019-04-30 08:45:19 -07:00
Jean Christophe Beyler
131bdfdff3
8222935: Fix ExceptionCheckingJniEnv system
...
Added missing tests and fixed the code
Reviewed-by: cjplummer, sspitsyn, amenkov
2019-04-24 19:51:38 -07:00
Jean Christophe Beyler
fd3378a73e
8213501: Deploy ExceptionJniWrapper for a few tests
...
Add more tests to be using the wrapper
Reviewed-by: phh, amenkov, sspitsyn, dholmes, cjplummer
2019-04-23 08:11:38 -07:00
Gary Adams
eab5f23c59
8222741: jdi/EventQueue/remove/remove004 fails due to VMDisconnectedException
...
Reviewed-by: cjplummer, jcbeyler
2019-04-22 07:13:18 -04:00
Daniil Titov
32848d8166
8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails
...
Reviewed-by: sspitsyn, jcbeyler, amenkov
2019-04-10 21:21:31 +00:00
Daniil Titov
6d77c76cf2
8218727: vmTestbase/nsk/jvmti/scenarios/events/EM04/em04t001/TestDescription.java crash in native library
...
Reviewed-by: sspitsyn, gadams
2019-03-28 04:26:36 +00:00
Gary Adams
c986cef7ba
8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes
...
Reviewed-by: cjplummer, dholmes, lmesnik
2019-03-26 07:24:26 -04:00
Daniil Titov
57bf6a1800
8217827: [Graal] Some vmTestbase/nsk/jvmti/ResourceExhausted tests failing
...
Reviewed-by: cjplummer, jcbeyler, dholmes
2019-03-26 04:19:39 +00:00
Nick Gasson
1925ff3540
8220451: jdi/EventQueue/remove/remove004 failed due to "ERROR: thread2 is not alive"
...
8220456: jdi/EventQueue/remove_l/remove_l004 failed due to "TIMEOUT while waiting for event"
Reviewed-by: sspitsyn, dcubed, gadams
2019-03-22 03:04:09 +00:00
Daniil Titov
ed5a2f1e06
8218401: WRONG_PHASE: vmTestbase/nsk/jvmti test crash
...
Reviewed-by: sspitsyn, jcbeyler
2019-03-21 19:56:31 +00:00
Daniil Titov
a148e026a9
8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed
...
Reviewed-by: dlong, sspitsyn, jcbeyler
2019-03-14 16:28:31 -07:00
Chris Plummer
6fd9b75e55
8220352: Crash with assert(external_guard || result != __null) failed: Invalid JNI handle
...
Don't delete globalrefs that might still be referenced
Reviewed-by: gadams, jcbeyler, sspitsyn
2019-03-13 19:42:23 -07:00
Gary Adams
f9d6d1d8f2
8013728: nsk/jdi/BScenarios/hotswap/tc10x001 Unrecognized Windows Sockets error: 0: recv failed
...
Reviewed-by: cjplummer, amenkov
2019-03-12 07:17:03 -04:00
Daniil Titov
02d0800300
8218464: vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001/TestDescription.java failed
...
Reviewed-by: sspitsyn, gadams
2019-03-06 09:30:05 -08:00
Daniil Titov
ac7f4635e1
8218167: nsk/jvmti/scenarios/sampling/SP02/sp02t003 fails
...
Reviewed-by: dlong, cjplummer
2019-03-05 13:41:35 -08:00
Gary Adams
cf086be753
4903717: nsk/jdi/ThreadReference/isSuspended/issuspended002 failing
...
Reviewed-by: amenkov, sspitsyn
2019-03-04 08:45:05 -05:00
Daniil Titov
ba84c4bc0c
8207367: 10 vmTestbase/nsk/jdi tests timed out when running with jtreg
...
Reviewed-by: sspitsyn, cjplummer
2019-02-28 13:12:26 -08:00
Igor Ignatyev
b88c7ac223
8219158: use 'test.root' property instead of traversing test-src path
...
Reviewed-by: dholmes
2019-02-22 11:07:18 -08:00
Gary Adams
4aac63bb93
8219388: Misleading log message "issuspended002a debuggee launched"
...
Reviewed-by: cjplummer, phh
2019-02-21 05:06:41 -05:00
Chris Plummer
c296f4ae0d
8218947: jdb threads command should print threadID in decimal, not hex
...
Print objectIDs in decimal.
Reviewed-by: sspitsyn, dholmes, jcbeyler
2019-02-19 12:05:43 -08:00
Gary Adams
8c4106ff56
8219002: Some comments and error messages refer to VMDisconnectException
...
Reviewed-by: cjplummer, sspitsyn
2019-02-15 05:32:36 -05:00
Gary Adams
9bc10ee9bf
8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out
...
Reviewed-by: cjplummer, sspitsyn
2019-02-11 07:19:32 -05:00
Daniil Titov
76ffbcde98
8205654: serviceability/dcmd/framework/HelpTest.java timed out
...
Reviewed-by: sspitsyn, dholmes
2019-02-08 09:41:45 -08:00
Jean Christophe Beyler
6029814c30
8212824: Remove unnecessary spaces before/after comparison in vmTestbase
...
Remove extra spaces around comparisons
Reviewed-by: phh, amenkov
2019-01-14 15:40:22 -08:00
David Holmes
cb960e9a30
8217618: JVM TI SuspendThread doesn't suspend the current thread before returning
...
Reviewed-by: dcubed, sspitsyn, dlong
2019-01-27 20:48:27 -05:00