Commit Graph

1416 Commits

Author SHA1 Message Date
Dan Smith
fe46aeabb0 8047407: Add test for JDK-8037385
Reviewed-by: mcimadamore
2014-06-20 11:42:16 -06:00
Dan Smith
06b8a7ac80 8034147: javac crashes with a NullPointerException during bounds checking
Types.supertype should return Type.noType rather than null

Reviewed-by: vromero, mcimadamore
2014-06-20 10:56:31 -06:00
Vicente Romero
d7c001dd04 8042759: Lambda returning implicitly-typed lambdas considered pertinent to applicability
Reviewed-by: mcimadamore
2014-06-19 23:52:33 +01:00
Jan Lahoda
9d852a54ef 8041648: do while loop that misses ending semicolon has wrong end position
Ensure the end positions are meaningful even if statement's semicolon is missing.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-06-19 22:06:29 +02:00
Vicente Romero
5b199f3cb8 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
2014-06-19 15:39:37 +01:00
Sonali Goel
17f9ae5713 8046071: update three javadoc tests for empty <p> tag
Reviewed-by: jjg, ksrini
2014-06-18 14:58:16 -07:00
Jan Lahoda
e6b9e34ebe 8046916: Type parameter annotations don't work with multiple type parameters
When reading type variable's annotations out of the owner's type annotations, use the type variable's index in owner to exclude annotations belonging to other type variables.

Reviewed-by: jfranck, emc
2014-06-18 10:44:16 +02:00
Vicente Romero
e4773094de 8036953: Fix timing of varargs access check, per JDK-8016205
Reviewed-by: mcimadamore, dlsmith
2014-06-17 17:33:01 +01:00
Paul Govereau
f2e2245e7b 8038975: Access control in enhanced for
Reviewed-by: vromero, jlahoda
2014-06-17 11:11:59 -04:00
Jonathan Gibbons
2613fffb87 8046369: sjavac should not use javac internal API for starting javac
Reviewed-by: jfranck, alundblad, ohrstrom
2014-06-16 11:30:31 -07:00
Andreas Lundblad
77fa3101ec 8042830: A recently added Xprefer test fails on Windows
Test now accepts both / and \ as file separator.

Reviewed-by: mcimadamore
2014-06-12 14:29:09 +02:00
Kumar Srinivasan
b18841ffa0 8042829: [javadoc] index-file output is not sorted correctly
8043062: JDK 9 platform and compiler upgrade failed on Solaris-sparcv9 with Javadoc.gmk:360: recipe for target docs/api/index.html

Reviewed-by: erikj, jjg
2014-05-22 12:16:53 -07:00
Eric McCorkle
29e8b83b48 8043484: DPrinter does not compile
Make DPrinter compile

Reviewed-by: jjg
2014-06-12 11:32:23 -04:00
Paul Govereau
577b60e711 8027886: javac allows illegal receiver parameters
8029042: Receiver parameter not supported on local class constructor

Reviewed-by: jfranck, jlahoda
2014-06-11 12:49:10 -04:00
Dan Smith
3ea78c679c 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
Capture intersection supertypes before comparing their members

Reviewed-by: vromero
2014-06-10 15:25:01 -06:00
Dan Smith
6e1ae5955e 8037385: constant pool errors with -target 1.7 and static default methods
Add error check for static interface methods invoked from -source 7

Reviewed-by: vromero, mcimadamore
2014-06-10 12:41:39 -06:00
Maurizio Cimadamore
dab523a752 8043725: javac fails with StackOverflowException
Loose type comparison test should be protected against infinite recursion with fbounds

Reviewed-by: vromero
2014-06-09 12:54:02 +01:00
Jan Lahoda
d71f75ae86 8033414: javac Plugin to receive notification (before and) after the compilation
Introducing TaskEvent.Kind.COMPILATION, sending this event before and after compilation.

Co-authored-by: Joel Borggren-Franck <joel.franck@oracle.com>
Reviewed-by: jjg, jfranck
2014-06-09 10:17:16 +02:00
Jonathan Gibbons
15853aca13 7026941: 199: path options ignored when reusing filemanager across tasks
Reviewed-by: jlahoda, jfranck
2014-06-08 15:02:34 -07:00
Andrei Eremeev
8aa391d4c9 8042451: Write tests for all possible kinds of type annotation
Add new tests for type annotations to improve case coverage

Reviewed-by: jjg, emc, abuckley
2014-06-06 16:08:46 -04:00
Eric McCorkle
8ff3cbd414 8027262: Determine location for type annotations earlier in compiler pipeline
8027261: Single codepath for attaching annotations to symbols
8027258: Permit a single source annotation to generate multiple bytecode annotations
8027182: Incorrect annotation attributes for type annotations on constructor type parameters
8044010: TypeAnnotation attribute is not generated for repeatable annotation in type argument
8044009: TypeAnnotation attribute is not generated for repeatable annotation in nested types
8043974: TypeAnnotation attribute is not generated for repeatable annotation in lambda
8043669: Few of the ANNOT tests in JCK9 test suite fail with an AssertionError for exception_index
8042060: Type parameter annotations don't work with multiple type parameters
8037348: RuntimeInvisibleAnnotations should not be generated for type annotation on anonymous innerclass creation

Initial rearchitecting of type annotations frontend pipeline

Reviewed-by: jjg, jfranck, mcimadamore, jlahoda, wmdietl
2014-06-06 16:00:59 -04:00
Jonathan Gibbons
a9bd96c90c 8046067: test/tools/javac/api/6410643/T6410643.java is broken
Reviewed-by: darcy, ksrini
2014-06-05 13:22:37 -07:00
Sonali Goel
887f81a738 8044072: Group 2: create .out files for OverrideChecks tests in tools/javac dir
Reviewed-by: jjg
2014-06-05 10:57:10 -07:00
Sonali Goel
d15c9840ed 8044064: Group 1: create .out files for cast and capture negative tests in tools/javac dir
Reviewed-by: jjg
2014-06-05 10:44:38 -07:00
Maurizio Cimadamore
cd68d10b6f 8043893: Inference doesn't report error on incompatible upper bounds
Failure on type-equality check during incorporation doesn't trigger inference error

Reviewed-by: vromero
2014-06-05 12:21:38 +01:00
Vicente Romero
09250abb84 8041713: Type inference of non-existent method references crashes the compiler
Reviewed-by: mcimadamore
2014-06-04 20:01:13 +01:00
Vicente Romero
45c3929ecb 8044487: Fix for 8042785 causes regression tests to fail with java.lang.VerifyError
Reviewed-by: jjg, ksrini
2014-06-02 22:36:40 +01:00
Vicente Romero
8447e4cf46 8042785: javac, bridge methods are not getting the flags from the original method
Reviewed-by: jjg, jlahoda
2014-05-30 18:21:05 +01:00
Jan Lahoda
2f910049e8 8031967: For some sources compiler compiles for ever
Avoid creating DeferredTypes for method calls with method calls as receivers if the site can be determined reliably

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, vromero
2014-05-30 12:54:16 +02:00
Vicente Romero
92e2e96714 8037937: javac: AssertionError during LVT generation, wrong variable ranges
Reviewed-by: mcimadamore
2014-05-29 15:28:01 +01:00
Stephane Epardaud
e0f4450825 8037934: Javac generates invalid signatures for local types
Reviewed-by: vromero, rfield
2014-05-28 21:47:30 +01:00
Dan Smith
2b4c40d39b 8044050: Move misplaced inference tests to test/tools/javac/generics/inference
Reviewed-by: vromero
2014-05-27 16:39:05 -06:00
Paul Govereau
0b1c40b161 8042741: Java 8 compiler throws NullPointerException depending location in source file
Reviewed-by: vromero, jlahoda
2014-05-27 22:26:53 +01:00
Paul Govereau
649331e00f 8041704: wrong error message when mixing lambda expression and inner class
Reviewed-by: vromero
2014-05-27 18:57:44 +01:00
Sonali Goel
378c3fe62f 8043336: Missing bug id in test/tools/javac/lambda/TargetType23.java
Reviewed-by: jjg, vromero, dlsmith
2014-05-22 15:42:10 -07:00
Paul Govereau
c212c43f70 8015927: Class reference duplicates in constant pool
Reviewed-by: jjg
2014-05-16 17:08:42 -04:00
Jonathan Gibbons
31e6340f54 8041422: Split javac ClassReader into ClassReader+ClassFinder
Reviewed-by: jfranck
2014-05-18 19:59:10 -07:00
Jan Lahoda
911a9fcf97 8043186: javac test langtools/tools/javac/util/StringUtilsTest.java fails
The result of String.toLowerCase.indexOf does not always point at the start of the given string in the non-lowercased text.

Reviewed-by: jjg, bpatel
2014-05-16 10:52:07 +02:00
Andrey Nazarov
23759a15dd 8042771: Missing bug id in test/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java
Reviewed-by: jjg
2014-05-12 17:09:26 +01:00
Dan Smith
5efa462340 8042882: Support verbosity options in langtools testing
8032441: langtools/test/Makefile breaks when JT_JAVA set to a JDK 9 build

Reviewed-by: mduigou
2014-05-13 15:34:13 -06:00
Dan Smith
9798cbad4c 8034223: Most-specific should not have any special treatment for boxed vs. unboxed types
Rewrite most-specific logic to conform to JLS 8 15.12.2.5

Reviewed-by: vromero
2014-05-13 15:29:09 -06:00
Jonathan Gibbons
3b2a17f08f 8042886: Test langtools/test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java fails on Windows
Reviewed-by: darcy
2014-05-09 18:50:12 -07:00
Vicente Romero
9cf78d324c 8028503: javac, for method references a primitive type can be added as a bound
Reviewed-by: jjg, dlsmith
2014-05-10 01:24:35 +01:00
Vicente Romero
c374047d36 8037379: fix for JDK-8029569 doesn't cover all possible cases
Reviewed-by: jjg
2014-05-10 00:46:47 +01:00
Jonathan Gibbons
caa2209663 8038730: Clean up the way JavadocTester is invoked, and checks for errors
Reviewed-by: ksrini, sogoel, bpatel
2014-05-09 15:37:12 -07:00
Dan Smith
f799e8d6fc 8042656: Inference produces spurious error for intersection type bounds check
Fix subtyping for intersections involving capture variables

Reviewed-by: vromero
2014-05-09 14:56:59 -06:00
Eric McCorkle
1ad5b0eee1 8040327: Eliminate AnnotatedType
Replace AnnotatedType with type annotations being stored in the Type class as metadata

Reviewed-by: jjg, jfranck, wmdietl, jlahoda
2014-05-09 09:28:47 -04:00
Jonathan Gibbons
47876fcddb 8042839: XPreferTest fails on Windows
Reviewed-by: vromero
2014-05-09 08:52:57 -07:00
Kumar Srinivasan
1f1c8d7506 8042601: Javadoc sort fails
Reviewed-by: jjg
2014-05-08 08:23:44 -07:00
Jan Lahoda
5b6afc8503 8041663: Sensitive dependence on location of nested interface
Adding a method among ambiguous candidates only if it is more specific than some of the existing candidates.

Reviewed-by: dlsmith, vromero
2014-05-09 12:55:58 +02:00
Jan Lahoda
23ba7e22d2 8040822: Duplicated notifications can be sent to TaskListener
The analyze finished event must only be sent on the first call to JavaCompiler.flow for a given class.

Reviewed-by: jjg
2014-05-09 09:36:35 +02:00
Andreas Lundblad
b2d433dcfc 8028196: Javac allows timestamps inside rt.jar to affect compilation when using -sourcepath
Added -XXuserPathsFirst to allow user classes to take precedence over boot classes

Reviewed-by: jjg
2014-05-07 17:29:42 +02:00
Fredrik Öhrström
ad489d2ce3 8042441: sjavac does not track dependencies
Add support for tracking fully qualified references.

Reviewed-by: jjg
2014-05-08 00:22:31 +02:00
Fredrik Öhrström
cb6df44f8e 8042699: sjavac does not track dependencies
Using / in some places and . in other places break package comparisons. The fix standardizes on dots.

Reviewed-by: jjg
2014-05-07 23:55:41 +02:00
Andrey Nazarov
2c6668c63d 8040129: Implement classfile tests for SourceFile attribute
Reviewed-by: shurailine, jjg
2014-05-07 14:22:14 -07:00
Dan Smith
282ee77f73 8033718: Inference ignores capture variable as upper bound
Split Types.lowerBound into two methods; fix bugs in inference handling of capture variables.

Reviewed-by: vromero
2014-05-06 15:46:09 -06:00
Jonathan Gibbons
7e2e9759d5 8042358: some tests have placeholder bugid 1234567
Reviewed-by: mduigou
2014-05-02 16:41:10 -07:00
Paul Govereau
6ec0c32eff 8033437: javac, inconsistent generic types behaviour when compiling together vs. separate
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: jjg
2014-05-02 22:35:23 +01:00
Vicente Romero
71a85db2be 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
Reviewed-by: dlsmith, jjg
2014-05-01 20:36:11 +01:00
Robert Field
89be14bfe5 8029852: Bad code generated (VerifyError) when lambda instantiates enclosing local class and has captured variables
8029725: Lambda reference to containing local class causes javac infinite recursion

Reviewed-by: vromero, jlahoda, dlsmith
2014-04-30 23:02:14 -07:00
Robert Field
e8adfd1234 8036942: javac generates incorrect exception table for multi-catch statements inside a lambda
Union type info lost and also union type is not processed by TreeMaker.Type -- address by using existing tree, thus by-passing such issues.

Reviewed-by: vromero, jlahoda
2014-04-30 18:19:23 -07:00
Andrey Nazarov
230b553e37 8040097: Implement classfile tests for LocalVariableTable and LocalVariableTypeTable attribute
Reviewed-by: jjg, shurailine, emc
2014-04-30 13:48:37 -07:00
Paul Govereau
f77173467d 8030046: javac incorrectly handles absolute paths in manifest classpath
Reviewed-by: jjg, vromero
2014-04-21 17:57:47 -04:00
Kumar Srinivasan
296a39b117 8039410: [javadoc] fix class-use items to be deterministic and index ordering
Reviewed-by: jjg
2014-04-18 08:35:59 -07:00
Vicente Romero
0996901f29 8029102: Enhance compiler warnings for Lambda
Reviewed-by: briangoetz, jjg, jlahoda, ahgross
2014-04-28 14:48:51 +01:00
Paul Govereau
218ce31908 8039026: Definitely unassigned field can be accessed
Reviewed-by: vromero, jlahoda
2014-04-25 22:00:58 +01:00
Jonathan Gibbons
6c24c7e153 8040904: Ensure javadoc tests do not overwrite results within tests
Reviewed-by: ksrini
2014-04-25 13:08:41 -07:00
Jan Lahoda
6b335c8d1a 8039250: Test tools/javac/classfiles/InnerClasses/SyntheticClasses.java fails
The test should only analyze classfiles.

Reviewed-by: vromero
2014-04-23 11:28:09 +02:00
Jonathan Gibbons
3acf463dc4 8040903: Clean up use of BUG_ID in javadoc tests
Reviewed-by: ksrini
2014-04-22 17:57:40 -07:00
Jonathan Gibbons
187dbd343c 8041253: Avoid redundant synonyms of NO_TEST
Reviewed-by: ksrini
2014-04-22 17:41:11 -07:00
Paul Govereau
9783b65028 8034245: Refactor TopLevel tree node
Added JCPackageDecl to JCTree to store package-level information.

Reviewed-by: jjg, jlahoda
2014-04-22 17:07:54 -04:00
Paul Govereau
b349726850 8038023: Compiler crash ClassCastException
Add additional checks on results of ClassReader.readPool

Reviewed-by: vromero
2014-04-22 19:52:15 +01:00
Andreas Lundblad
06f651942c 8035063: Option handling in sjavac needs to be rewritten
Option handling code rewritten. Exclusion / inclusion patterns changed from package to directories.

Reviewed-by: jjg, jfranck
2014-04-22 16:51:10 +02:00
Vicente Romero
a50db59b59 8029718: Should always use lambda body structure to disambiguate overload resolution
Reviewed-by: dlsmith, jjg, jlahoda
2014-04-21 22:51:49 +01:00
Jonathan Gibbons
04e1109b69 8041150: Avoid silly use of static methods in JavadocTester
Reviewed-by: ksrini
2014-04-18 17:25:43 -07:00
Jonathan Gibbons
a2d155dfa9 8040908: javadoc test TestDocEncoding should use -notimestamp
Reviewed-by: ksrini
2014-04-18 17:23:36 -07:00
Vicente Romero
a310cda727 8029002: javac should take multiple upper bounds into account in incorporation
Reviewed-by: dlsmith, jjg
2014-04-18 17:50:30 +01:00
Jan Lahoda
e505238d2a 8038788: javac behaves incorrectly for annotations after method type parameters in some cases
Reviewed-by: jjg, emc
2014-04-18 11:53:34 +02:00
Kumar Srinivasan
9b4ae823ef 8038976: javadoc requires a trailing / for links where java 7's javadoc didn't
Reviewed-by: jjg
2014-04-16 19:21:59 -07:00
Kumar Srinivasan
7a7a57bb88 8037484: [javadoc] fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-04-16 18:15:48 -07:00
Kumar Srinivasan
7a4a5803fc 8039251: Test tools/javadoc/6964914/TestStdDoclet.java fails
Reviewed-by: jjg
2014-04-16 18:36:43 -07:00
Neil Toda
81730320bd 8031649: Clean up javadoc tests
Reviewed-by: jjg
2014-04-16 16:17:09 -07:00
Robert Field
360461f136 8038420: Lambda returning post-increment generates wrong code
Reviewed-by: vromero, jlahoda
2014-04-15 15:55:24 -07:00
Robert Field
300fbf0889 8037935: Javac -- final local String var referenced in binary/unary op in lambda produces code that does not verify
Remove over-zealous Attr optimization breaking lambdas

Reviewed-by: jjg, vromero
2014-04-15 15:52:52 -07:00
Bhavesh Patel
4ff2c3b94a 8026736: Enhance Javadoc pages
Reviewed-by: jjg
2014-01-13 14:50:51 -08:00
Jan Lahoda
69c52bd73b 8039079: Test tools/javac/processing/environment/round/TestElementsAnnotatedWith.java fails
Ensuring the test passes in both samevm and othervm modes.

Reviewed-by: darcy
2014-04-15 18:58:47 +02:00
Paul Govereau
c654c5a23e 8015499: javac, Gen is generating extra checkcast instructions in some corner cases
Reviewed-by: vromero, jjg
2014-04-09 17:41:27 +01:00
Jan Lahoda
5905e8f494 8039466: Tests failing in langtools repository
Fixing tests broken by JDK-8038455.

Reviewed-by: jjg
2014-04-08 23:33:50 +02:00
Jan Lahoda
e5c8101894 8038455: Use single Context for all rounds of annotation processing
One set of javac services, as well as created ClassSymbols, is reused for all rounds of processing now.

Reviewed-by: jjg, jfranck, darcy, vromero
2014-04-08 14:06:11 +02:00
Paul Govereau
8e6660eb56 8023945: javac wrongly allows a subclass of an anonymous class
Reviewed-by: jjg
2014-04-04 19:13:53 -04:00
Bhavesh Patel
d642f92759 8032066: Serialized form has broken links to non private inner classes of package private
Reviewed-by: jjg
2014-04-01 23:58:04 -07:00
Paul Govereau
e231918e58 8034933: Update documentation for Types.directSupertypes to clarify behavior
Reviewed-by: darcy
2014-04-01 23:52:10 -07:00
Ivan Gerasimov
befb7157c9 8034044: Class.getModifiers() returns "static" for anonymous classes
Javac sets ACC_STATIC bit for anonymous classes which contradicts the JLS

Reviewed-by: jfranck
2014-04-02 10:05:16 +04:00
Alexander Zuev
d9d9742c75 8031425: Two langtools/javac tests fail by timeout on Windows
Reviewed-by: jjg, vromero
2014-04-01 10:00:43 -07:00
Jan Lahoda
e339370175 8035890: jdk8 javac -source 7 compiles test case it should not
Ensuring source level checks are performed in two additional cases related to type annotations, adding specialized error message for annotations after method type parameters.

Reviewed-by: jfranck, jjg
2014-03-31 21:27:25 +02:00
Bhavesh Patel
e08ccd0e48 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present
Reviewed-by: ksrini
2014-03-29 11:06:33 -07:00
Jonathan Gibbons
77ad0945a6 8035104: reorder class file attributes in javap listing
Reviewed-by: ksrini
2014-03-26 17:50:33 -07:00
Alexander Zuev
3eb793cd06 8035956: javac, incomplete error message
Reviewed-by: vromero
2014-03-26 10:47:30 -07:00
Joel Borggrén-Franck
24400e1745 8038080: annotation processors don't visit declaration parameter annotations
Co-authored-by: Liam Miller-Cushon <cushon@google.com>
Reviewed-by: darcy
2014-03-26 12:18:11 +01:00
Bhavesh Patel
da71a6dd96 8031625: javadoc problems referencing inner class constructors
Reviewed-by: jjg
2014-03-25 22:07:55 -07:00