Commit Graph

2298 Commits

Author SHA1 Message Date
Jan Lahoda
a57e6e77d2 8067747: javac throws exception during compilation when annotation processing is enabled
Enforcing Filer rules regarding initial inputs, to avoid downstream problems.

Reviewed-by: darcy, jjg
2017-01-26 14:11:38 +01:00
Robert Field
01b7f9ed5e 8171343: jshell tool: missing options: --help-extra --show-version
Reviewed-by: jlahoda
2017-01-25 10:43:41 -08:00
Robert Field
8fd1027a6b 8173232: JShell tests: ReplaceTest takes too long
8173234: JShell tests: remove from ProblemList jdk/jshell/ToolFormatTest.java
8173204: JShell tests: ProblemList jdk/jshell/UserJdiUserRemoteTest.java

Reviewed-by: jlahoda
2017-01-25 10:22:06 -08:00
Denis Istomin
80280a2207 8041793: javap misses newline after printing AnnotationDefault
Reviewed-by: jjg
2017-01-24 17:36:41 -08:00
Denis Istomin
31b1a86ec6 8051768: Inconsistent output for Visible and InvisibleParameterAnnotations
Reviewed-by: jjg
2017-01-24 16:18:24 -08:00
Srikanth Adayapalam
4141792982 8171322: AssertionError in TypeSymbol.getAnnotationTypeMetadata
Reviewed-by: vromero
2017-01-23 10:28:52 +05:30
Jonathan Gibbons
ce3452952c Merge 2017-01-20 18:24:50 -08:00
Jonathan Gibbons
784f56bcc7 8173141: tools/javac/classreader/FileSystemClosedTest.java fails on Windows
Reviewed-by: ksrini
2017-01-20 18:23:34 -08:00
Robert Field
bba1175418 8173073: jshell tool: blank lines removed from multi-line snippets
Reviewed-by: jlahoda
2017-01-20 11:05:48 -08:00
Jan Lahoda
721001933d 8173117: Compilation significantly slower after JDK-8169197
Only using recovery search when an error is inevitable.

Reviewed-by: jjg, mcimadamore
2017-01-20 15:32:07 +01:00
Jan Lahoda
3e7e4c275b 8172809: Error compiling javafx modules after fix for JDK-8169197
Properly stripping broken requires from ModuleSymbols.

Reviewed-by: jjg, mcimadamore
2017-01-20 15:32:03 +01:00
Jan Lahoda
b6e7bcbc6a 8171177: Compiler should issue a warning for incubating modules that are resolved
Javac needs to follow ModuleResolution.DO_NOT_RESOLVE_BY_DEFAULT and ModuleResolution.WARN_INCUBATING

Reviewed-by: jjg
2017-01-20 13:20:42 +01:00
Jan Lahoda
ec3981561d 8171098: NPE when --add-modules java.corba is used
Block annotations queue until enter is done, to avoid flushing annotations during module resolution.

Reviewed-by: jjg
2017-01-20 09:26:49 +01:00
Jonathan Gibbons
04405c6abc 8147414: java.nio.file.ClosedFileSystemException in javadoc
Reviewed-by: vromero
2017-01-19 19:14:51 -08:00
Jonathan Gibbons
16d379dad4 8165102: incorrect message from javac
Reviewed-by: vromero
2017-01-19 15:12:59 -08:00
Kumar Srinivasan
8045fb0059 8169608: Compiler Tree API's Doctrees.getDocTreePath needs to accept a PackageElement
8157611: field visiblePackages is null for the unnamed module producing NPE when accessed

Reviewed-by: jjg, jlahoda
2017-01-19 13:16:19 -08:00
Robert Field
362b794a82 8171130: jshell tool: /edit adds empty statement to brace terminated snippet
8173007: JShell Tests: ToolFormatTest takes too long

Reviewed-by: jlahoda
2017-01-19 11:17:11 -08:00
Robert Field
99e3bceb60 8172179: jshell tool: builtin startup settings should be by reference not content
Reviewed-by: jlahoda
2017-01-19 11:12:02 -08:00
Henry Jen
9e40eebc93 Merge 2017-01-19 07:02:34 -08:00
Joe Darcy
5fe31c310c 8172910: Use default methods as appropriate for language model visitors
Reviewed-by: jjg
2017-01-18 19:39:06 -08:00
Andrey Nazarov
408d7e99f7 8170250: update/improve testing of classfile module attribute
Reviewed-by: jjg, jlahoda
2017-01-18 21:09:19 +03:00
Chris Hegarty
a0dee349e1 8171380: Remove all exports from jdk.jlink
Reviewed-by: alanb, mchung, sundar
2017-01-18 09:35:23 +00:00
Jan Lahoda
53792b463e 8172262: packages missing from docs build
Do not return packages without members from Elements.getPackageElement(String), to avoid ambiguities among such packages in multiple modules.

Reviewed-by: jjg
2017-01-17 07:41:04 +01:00
Srikanth Adayapalam
f1eb002e95 8171993: AssertionError when compiling method reference with generic code and varargs
Reviewed-by: mcimadamore
2017-01-17 09:17:10 +05:30
Robert Field
cde454bda3 8172678: JShell Tests: Disable CompletionSuggestionTest.testBrokenClassFile2()
Reviewed-by: jlahoda
2017-01-13 18:29:21 -08:00
Jonathan Gibbons
ee0491d210 8172474: javac should enable doclint checking for HTML 5
Reviewed-by: jlahoda
2017-01-13 15:48:12 -08:00
Vicente Romero
5fc51d4ecd 8171528: Crash in Annotate with duplicate package-info declarations
Reviewed-by: jjg
2017-01-12 15:59:28 -08:00
Jan Lahoda
abddf32a62 8172668: NPE in jdk.compiler/com.sun.tools.javac.comp.TypeEnter$ImportsPhase.importNamed(
Guarding against noType returned from ErrorType.getOriginalType.

Reviewed-by: mcimadamore
2017-01-12 15:37:46 +01:00
Vicente Romero
a9a05f2aff 8171325: NPE in Check.clearLocalClassNameIndexes
Reviewed-by: mcimadamore
2017-01-11 10:29:24 -08:00
Jan Lahoda
c2d9172419 8169197: Improve error reporting for compiling against unexported package
When a type cannot be found, look into other modules, search for possible viable types, and report them conveniently to the user.

Reviewed-by: mcimadamore, jjg
2017-01-11 10:59:57 +01:00
Vicente Romero
6c4a689750 8171332: NPE in MembersPhase.finishClass
Reviewed-by: mcimadamore
2017-01-10 11:31:59 -08:00
Jan Lahoda
fd12ea2d58 8171385: jshell tool: unresponsive to ctrl-C in input wait on Windows
Ensuring stop is sent using the proper channel depending on the current state of the StopDetectingInputStream.

Reviewed-by: rfield
2017-01-10 10:17:47 +01:00
Robert Field
cea33151ed 8171981: JShell: Fails compilation: new Object().getClass().getSuperclass()
Reviewed-by: mcimadamore
2017-01-09 18:04:16 -08:00
Robert Field
f9b57bfbed 8172255: JShell API: ExecutionControl/LoaderDelegate: Remove unused/unimplemented setClassPath
Reviewed-by: jlahoda
2017-01-09 13:50:45 -08:00
Robert Field
6f796f5684 8165405: jshell tool: /classpath is inconsistent
8172103: JShell: crash in TaskFactory$WrapSourceHandler.diag

Reviewed-by: jlahoda
2017-01-06 10:31:25 -08:00
Jan Lahoda
4ec30a933a 8172158: Annotation processor not run with -source <= 8
Avoiding use of module prefix to map annotations to processors when running without modules.

Reviewed-by: darcy, jjg
2017-01-06 14:16:45 +01:00
Jonathan Gibbons
61175156de 8172311: MostSpecific09.java and PotentiallyAmbiguousWarningTest.java failing across platforms
Reviewed-by: vromero
2017-01-05 15:39:57 -08:00
Vicente Romero
cedf0baa46 8026699: test test/tools/javac/lambda/T8024947/PotentiallyAmbiguousWarningTest.java has an extra @compile attribute that should be removed
Reviewed-by: mcimadamore
2017-01-05 11:20:56 -08:00
Bernard Blaser
37f7ab915c 8148100: Convert lambda most specific positive tests to check runtime behavior
Reviewed-by: mcimadamore
2017-01-05 11:16:39 -08:00
Joe Darcy
42a9464947 8172220: Mark UserInputTest.java as intermittently failing and problem list it
Reviewed-by: jlahoda
2017-01-05 11:02:35 -08:00
Liam Miller-Cushon
d3f27dfe9c 8065800: javac, fix diagnostic position for statement-bodied lambdas
Reviewed-by: mcimadamore
2017-01-05 10:04:40 -08:00
Jonathan Gibbons
6fa9fb405d 8172260: remove tests from ProblemList
Reviewed-by: rfield
2017-01-04 18:33:20 -08:00
Jonathan Gibbons
3cfe5aae72 8171977: Add support for latest messages from 'tidy'
Reviewed-by: darcy
2017-01-04 16:08:27 -08:00
Mandy Chung
920965dad2 8172212: jdeps --require and --check should detect the specified module in the image
Reviewed-by: psandoz, lancea
2017-01-03 17:53:34 -08:00
Dan Smith
342a27ab58 8144066: StackOverflowException when computing glb
Reviewed-by: mcimadamore
2017-01-03 16:27:54 -07:00
Maurizio Cimadamore
4ff56b008f 8169091: Method reference T::methodName for generic type T does not compile any more
MethodReferenceLookupHelper should use original site to perform unbound subtype check

Reviewed-by: vromero
2017-01-03 11:33:18 +00:00
Liam Miller-Cushon
a84bef19f0 8171132: Improve class reading of invalid or out-of-range ConstantValue attributes
Reviewed-by: mcimadamore
2016-12-21 15:40:08 -08:00
Robert Field
6c52320ccc 8172102: jshell tool: remove print method forwarding to System.out from default startup
Reviewed-by: briangoetz
2017-01-02 18:31:30 -08:00
Robert Field
72b502fa4f 8171892: JShell: incorrect printing of multidemensional arrays
8171387: jshell tool: message inconsistencies

Reviewed-by: sundar, dlsmith
2016-12-23 11:17:50 -08:00
Robert Field
f7067671f6 8168615: JShell API: jdk.jshell.spi should be a pluggable ServiceLoader SPI
Reviewed-by: jlahoda
2016-12-21 20:14:39 -08:00
Erik Joelsson
053cdb4fa5 8170741: Enable uploading of built artifacts through Jib
Reviewed-by: ihse
2016-12-14 16:32:07 +01:00
Robert Field
ea579f7bec 8170162: jshell tool: no mechanism to programmatically launch
8170044: jshell tool: jshell missing from javax.tools.ToolProvider

Reviewed-by: jjg
2016-12-20 13:42:13 -08:00
Jonathan Gibbons
23c1a004ec 8171413: jdk/javadoc/doclet/testModules/TestModules.java failed due to some subtests failed
Reviewed-by: bpatel
2016-12-20 06:06:01 -08:00
Jonathan Gibbons
71b65b06e4 8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
Reviewed-by: mcimadamore
2016-12-20 05:50:39 -08:00
Mandy Chung
cc3b86f64c 8171418: Remove jdeps internal --include-system-modules option
Reviewed-by: dfuchs, lancea
2016-12-19 12:30:39 -08:00
Jonathan Gibbons
bf8ce3692c 8171255: Javac generates Deprecated class file attribute for @deprecated javadoc tag on module declaration
Reviewed-by: mcimadamore, anazarov
2016-12-19 11:15:01 -08:00
Jonathan Gibbons
347e8689f2 8171451: update langtools problem lists for failing tests
Reviewed-by: darcy
2016-12-19 11:07:44 -08:00
Vicente Romero
b29a67ae55 8169005: tools/javac/T8132562/ClassPathWithDoubleQuotesTest.java fails after fix to JDK-8132562
Reviewed-by: jjg
2016-12-17 16:57:14 -05:00
Bhavesh Patel
4a4e893915 8160196: Module summary page should display information based on "api" or "detail" mode
Reviewed-by: jjg, ksrini
2016-12-16 09:07:57 -08:00
Andrey Nazarov
bf8e595590 8170549: Improve testing of annotations on modules
Reviewed-by: jjg, jlahoda
2016-12-16 18:40:23 +03:00
Jan Lahoda
5a0691c4e4 8171355: Implement Elements.getOrigin
Adding implementation for javax.lang.model.util.Elements.getOrigin

Reviewed-by: darcy, jjg
2016-12-16 12:08:46 +01:00
Jan Lahoda
e62a384eb3 8133896: Update javax.lang.model APIs
Reviewed-by: darcy, jjg
2016-12-16 12:02:30 +01:00
Alan Bateman
574ac0add6 Merge 2016-12-16 08:17:55 +00:00
Alan Bateman
2381943e61 8170987: Module system implementation refresh (12/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Srikanth Adayapalam <srikanth.adayapalam@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Reviewed-by: mcimadamore
2016-12-16 05:47:58 +00:00
Jonathan Gibbons
e4748a6d4c 8170708: javap -m <module> cannot read a module-info.class
Reviewed-by: jlahoda
2016-12-14 18:30:56 -08:00
Dan Smith
3999672b7a 8075793: Source incompatibility for inference using -source 7
In pre-8 sources, avoid capture variables as inference bounds, consistent with old javac behavior

Reviewed-by: vromero, mcimadamore
2016-12-14 17:56:11 -07:00
Bhavesh Patel
88d8618e30 8162674: change javadoc output text and style emitted by for-removal deprecations
Reviewed-by: jjg
2016-12-13 12:25:58 -08:00
Jan Lahoda
d3892cc3b4 8072988: Update javax.annotation.processing for modules
Support for generating files in multi-module mode.

Co-authored-by: Joe Darcy <joe.darcy@oracle.com>
Reviewed-by: darcy, jjg
2016-12-13 10:49:28 +01:00
Jan Lahoda
5f63bc3ff0 8171005: Fix JavaFileManager.getLocationForModule(Location location, JavaFileObject fo, String pkgName) to work with location == CLASS_OUTPUT
JavaFileManager operations that allow module-oriented locations should also allow output locations.

Reviewed-by: jjg
2016-12-13 10:48:18 +01:00
Bernard Blaser
bc1ae385d3 8147527: Wrong code generated for postfix unary operators
Avoiding use of duplicated tree nodes when these may be changed in place.

Reviewed-by: mcimadamore, jlahoda
2016-12-12 13:27:39 +01:00
Jonathan Gibbons
e9ddc68f70 8170251: Add javax.tools.Tool.name()
Reviewed-by: darcy, mchung
2016-12-09 16:24:50 -08:00
Liam Miller-Cushon
7aff5df624 8170667: ClassReader assigns method parameters from MethodParameters incorrectly when long/double parameters are present
MethodParameters attribute does not skip a slot for long/double.

Reviewed-by: vromero, jlahoda
2016-12-09 18:06:48 +01:00
Jonathan Gibbons
7987d2876a 8170953: CheckResourceKeys tests should declare the resource package to be open
Reviewed-by: mchung
2016-12-08 16:52:38 -08:00
Bhavesh Patel
b5d8b0b991 8168688: javadoc top left frame should display all modules while in module mode
Reviewed-by: jjg
2016-12-08 12:46:59 -08:00
Bhavesh Patel
5ef4598ec8 8139101: javadoc emits "specified by" clause when class has a method that matches a static interface method
Reviewed-by: jjg, ksrini
2016-12-05 15:08:24 -08:00
Maurizio Cimadamore
04f289629a 8170410: inference: javac doesn't implement 18.2.5 correctly
Javac does not generate constraints of the kind 'throws alpha' as described in the spec

Reviewed-by: vromero, dlsmith
2016-12-05 19:00:56 +00:00
Jan Lahoda
ae8ace7912 8165564: langtools\test\jdk\jshell\CommandCompletionTest.java fails on some windows
Ignoring non-existent default FileSystem roots.

Reviewed-by: rfield
2016-12-05 19:42:42 +01:00
Jonathan Gibbons
ffcb66f113 8162712: StandardJavaFileManager.getModuleLocation() can't find a module
Reviewed-by: jlahoda
2016-12-02 14:15:43 -08:00
Robert Field
411ce3da8c 8169828: jdk/jshell/ExternalEditorTest.java testStatementMush() fails frequently on all platform
8170015: jshell tool: /help output looks terrible on a 100 column wide terminal
8170368: jshell tool: post setting not properly applied, line-ends not prefixed correctly

Reviewed-by: jlahoda
2016-12-02 10:17:03 -08:00
Jan Lahoda
88a7279627 8166628: Compiling with annotation processing, access error in specific situation
Ensure member classes inside anonymous classes have a correct owner.

Reviewed-by: mcimadamore
2016-12-02 14:39:00 +01:00
Erik Joelsson
128369a6fe 8168607: langtools/test/Makefile should set -retain:fail,error by default
Reviewed-by: tbell, ihse
2016-12-01 15:10:32 +01:00
Alan Bateman
01a366e6dd Merge 2016-12-01 11:16:45 +00:00
Alan Bateman
22e233b2e9 8169069: Module system implementation refresh (11/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Bhavesh Patel <bhavesh.x.patel@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Reviewed-by: mcimadamore, jjg, mchung, anazarov
2016-12-01 09:02:42 +00:00
Erik Joelsson
40f3d9e0f7 8166737: default langtools make test settings result in no ouput
Reviewed-by: tbell
2016-11-29 11:51:01 +01:00
Kumar Srinivasan
f4c9d73b3e 8164316: Refine the Doclet APIs
Reviewed-by: jjg
2016-11-24 20:48:52 -08:00
Erik Joelsson
54244b5e6d 8170279: Langtools test/Makefile ignores failed tests
Reviewed-by: alanb, tbell, mchung
2016-11-24 11:44:37 +01:00
Felix Yang
c5cbc99fd1 8170249: Problem list 2 jdk/jshell tests
Reviewed-by: darcy
2016-11-22 20:27:42 -08:00
Robert Field
85eded3562 8169519: JShell: Handle start-up failures and hangs gracefully
8166581: JShell: locks forever if -R options is wrong
8169234: JShell: hangs on startup on some computers caused by hostname

Reviewed-by: jlahoda
2016-11-22 19:24:02 -08:00
Jonathan Gibbons
f39acf60a5 Merge 2016-11-22 16:31:03 -08:00
Jonathan Gibbons
2d7092c7ac 8155765: javax.tools.ToolProvider::getSystemToolClassLoader returns app class loader even if no tool is available
Reviewed-by: mchung
2016-11-22 16:29:24 -08:00
Jonathan Gibbons
6e31f6440f 8164590: javac --inherit-runtime-environment fails with "cannot find modules: ALL-DEFAULT"
Reviewed-by: mchung
2016-11-22 15:57:32 -08:00
Frank Yuan
fe1b93aeab 8170170: Problem list ExternalEditorTest.java on all platforms
Reviewed-by: darcy
2016-11-22 07:04:43 -08:00
Robert Field
dda0e054d5 8114842: JShell: SourceCodeAnalysis splits code with array initialiazer incorrectly
Reviewed-by: jlahoda
2016-11-21 12:28:56 -08:00
Joe Darcy
8e8834a9e9 8170110: Problem list ExternalEditorTest.java
Reviewed-by: ksrini
2016-11-21 07:13:21 -08:00
Robert Field
f9eb02a066 8153402: jshell tool: completion provider for /help
8169818: jshell tool: completion provider for /vars /methods /types gives -history

Reviewed-by: jlahoda
2016-11-18 09:41:51 -08:00
Bhavesh Patel
e80463356c 8147890: Javadoc search does not work with Enums
Reviewed-by: jjg, ksrini
2016-11-16 17:22:08 -08:00
Jonathan Gibbons
c7374cd58f 8163190: Clarify JavaFileManager use of \"module location\"
Reviewed-by: jlahoda
2016-11-16 12:12:02 -08:00
Jonathan Gibbons
f742ef0ed0 8169676: boolean result of Option.process is often ignored
Reviewed-by: ksrini, jlahoda
2016-11-16 11:53:24 -08:00
Robert Field
f3e88eb313 8143006: jshell tool: /edit doesn't process each line as same as inputs for jshell
8163816: JShell tests: jdk/jshell/ExternalEditorTest.java -- unexpected results EditorTestBase.testEditClass1() and .testEditMethod1()

Reviewed-by: jlahoda
2016-11-16 10:45:23 -08:00
Jan Lahoda
da7b11ca15 8169561: jshell tool: double shift-tab on variable crashes tool
Avoid crashe for unknown HTML tags; avoid crash for non-existing documentation; fix signature for JShell variables

Reviewed-by: rfield
2016-11-16 17:48:43 +01:00