Commit Graph

1271 Commits

Author SHA1 Message Date
Brian Goetz
b03e5fc290 8015322: Javac template test framework
Putback of the javac template test framework from the Lambda repository

Reviewed-by: jjg
2013-09-09 17:11:55 -04:00
Eric McCorkle
5b76a0d216 8022322: Reject default and static methods in annotation
Causes javac to reject static and default method declarations inside an annotation

Reviewed-by: jjg
2013-09-09 16:26:55 -04:00
Vicente Romero
1704a9454c 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests
Reviewed-by: jjg, jfranck
2013-09-09 16:32:08 +01:00
Andreas Lundblad
5df75e001d 8022260: Rename javac.code.Annotations to javac.code.SymbolMetadata
Reviewed-by: jfranck, jjg
2013-09-09 09:58:20 +02:00
Vicente Romero
a3b1359af5 8024398: javac, compiler crashes with try with empty body
Reviewed-by: jjg
2013-09-08 11:54:21 +01:00
Jonathan Gibbons
f607953eb8 8024434: problem running javadoc tests in samevm mode on Windows
Reviewed-by: darcy
2013-09-06 15:31:59 -07:00
Chris Hegarty
0983a5be41 Merge 2013-09-06 10:05:08 +01:00
Vicente Romero
26758f0ffd 8024039: javac, previous solution for JDK-8022186 was incorrect
Reviewed-by: jjg
2013-09-06 09:53:24 +01:00
Bhavesh Patel
9c6d420370 8023608: method grouping tabs folding issue
Reviewed-by: jjg
2013-09-05 16:35:47 -07:00
Jonathan Gibbons
7da0f59aec 8024288: javadoc generated-by comment should always be present
Reviewed-by: bpatel
2013-09-04 14:44:05 -07:00
Maurizio Cimadamore
4cc7a55aab 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
Reviewed-by: jjg, vromero
2013-09-04 00:01:05 +01:00
Vicente Romero
cab6b226ff 8023545: Misleading error message when using diamond operator with private constructor
Reviewed-by: jjg
2013-09-03 23:41:37 +01:00
Maurizio Cimadamore
06caeea3d6 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
Reviewed-by: jjg, vromero
2013-09-03 23:31:33 +01:00
Vicente Romero
46d7a993ad 8022162: Incorrect signature determination for certain inner class generics
Reviewed-by: jjg
2013-09-02 22:44:06 +01:00
Maurizio Cimadamore
0382c78ff1 8016177: structural most specific and stuckness
Reviewed-by: jjg, vromero
2013-09-02 22:38:36 +01:00
Evgeniya Stepanova
4337286502 8015663: Need to supply tests to provide javadoc for profiles support code coverage
Reviewed-by: jjg
2013-08-30 17:36:47 -07:00
Bhavesh Patel
b8f8cab5f4 8022738: doclet should only generate functional interface text if source >= 8
Reviewed-by: jjg
2013-08-30 16:38:54 -07:00
Bhavesh Patel
5793c3a33c 8015882: Javadoc prints NPE when using Taglet
Reviewed-by: jjg
2013-08-30 16:16:28 -07:00
Bhavesh Patel
2b93265564 7198273: RFE : Javadoc Accessibility : Hyperlinks should contain text or an image with alt text
Reviewed-by: jjg
2013-08-30 15:59:33 -07:00
Jonathan Gibbons
3dd18b5d8c 8024093: Two *.rej files checked in to langtools/test directory
Reviewed-by: mchung
2013-08-30 15:14:51 -07:00
Jonathan Gibbons
4449fa0c56 8023700: Use non breaking space in various labels
Reviewed-by: bpatel
2013-08-30 11:48:36 -07:00
Chris Hegarty
bed1164562 Merge 2013-08-30 10:17:10 +01:00
Jonathan Gibbons
445a49ecb6 8023522: tools/javac/tree/TypeAnnotationsPretty.java test cases with @TA newline fail on windows only
Reviewed-by: darcy
2013-08-29 11:57:52 -07:00
Jonathan Gibbons
c56513ee82 8010310: [javadoc] Error processing sources with -private
Reviewed-by: vromero, mcimadamore
2013-08-28 15:40:33 -07:00
Henry Jen
8873ff4e48 8014566: Remove @ignore tags from MethodReference66 and InInterface when 8013875 is fixed
Reviewed-by: briangoetz, jjg
2013-08-28 10:17:23 -07:00
Bhavesh Patel
856570998b 7052170: javadoc -charset option generates wrong meta tag
Reviewed-by: jjg
2013-08-27 11:41:39 -07:00
Werner Dietl
d99f710f70 8023768: Use the unannotatedType in cyclicity checks
Reviewed-by: jjg
2013-08-26 15:55:46 -07:00
Jonathan Gibbons
041cadb78d 8023701: Fix badly named test
Reviewed-by: bpatel
2013-08-26 11:48:37 -07:00
Jonathan Gibbons
32a617d198 8022173: Relax some warnings in doclint
Reviewed-by: darcy
2013-08-22 12:41:20 -07:00
Eric McCorkle
0d3a9fcd89 8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables
Corrected an error in a previous patch that caused captured locals to be added to the beginning, not the end of a parameter list.

Reviewed-by: jjg, mcimadamore, ksrini, abuckley
2013-08-22 12:47:46 -04:00
Vicente Romero
c65abc95df 8023112: javac should not use lazy constant evaluation approach for method references
Reviewed-by: jjg, mcimadamore
2013-08-22 13:12:43 +01:00
Vicente Romero
7b989a82fd 8022316: Generic throws, overriding and method reference
Reviewed-by: jjg, mcimadamore
2013-08-22 10:22:44 +01:00
Eric McCorkle
febfa82cfb 8023520: Add missing test for JDK-7118412
The test for JDK-7118412 was dropped from the changeset in a merging accident.

Reviewed-by: jjg
2013-08-21 20:41:42 -04:00
Jonathan Gibbons
64412dad17 8022287: javac.sym.Profiles uses a static Map when it should not
Reviewed-by: ksrini
2013-08-21 17:26:22 -07:00
Werner Dietl
1dc32a077e 8023515: import type-annotations updates
Reviewed-by: jjg
2013-08-21 16:13:50 -07:00
Kumar Srinivasan
c9f3cedbfa 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8
Reviewed-by: jjg
2013-08-20 14:15:45 -07:00
Joe Darcy
557cb9c6b1 8011043: Warn about use of 1.5 and earlier source and target values
Reviewed-by: jjg
2013-08-20 12:15:19 -07:00
Joel Borggrén-Franck
07d44a6520 8019243: AnnotationTypeMismatchException instead of MirroredTypeException
Reviewed-by: jjg
2013-08-20 17:21:47 +02:00
Alexander Zuev
7947e49ae3 7182350: Regression in wording of unchecked warning message
Reviewed-by: mcimadamore, jjg
2013-08-20 17:34:06 +04:00
Kumar Srinivasan
7870f1a6dc 7071377: Exception when javac -processor is given a class name with invalid postfix
Reviewed-by: jjg, vromero
2013-08-19 07:47:10 -07:00
Erik Joelsson
99a38df3ab 8023146: Sjavac test failes in langtools nightly
Reviewed-by: mcimadamore, jfranck
2013-08-16 16:00:12 +02:00
Jan Lahoda
d992a67102 8022508: javac crashes if the generics arity of a base class is wrong
Reviewed-by: mcimadamore, vromero
2013-08-15 22:36:08 +02:00
Chris Hegarty
42ebef739f Merge 2013-08-15 21:34:46 +01:00
Jan Lahoda
59e0637339 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
Producing individual errors for uncaught undeclared exceptions inside lambda expressions, rather than one error for the whole lambda

Reviewed-by: mcimadamore
2013-08-15 22:33:43 +02:00
Vicente Romero
746be81338 8022053: javac generates unverifiable initializer for nested subclass of local class
Reviewed-by: jjg, mcimadamore
2013-08-16 10:32:42 +01:00
Erik Joelsson
fd4983b254 8015145: Smartjavac needs more flexibility with linking to sources
Reviewed-by: jjg, ohrstrom
2013-08-15 17:24:35 +02:00
Bhavesh Patel
0c6e63367d 8016921: Change the profiles table on overview-summary.html page to a list
Reviewed-by: jjg
2013-08-14 21:44:51 -07:00
Jonathan Gibbons
43991d588a 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages
Reviewed-by: bpatel
2013-08-14 16:41:01 -07:00
Kumar Srinivasan
ce4eb93249 8007517: DefaultMethodRegressionTests.java fail in TL
Reviewed-by: jjg, vromero
2013-08-14 07:07:55 -07:00
Vicente Romero
d36ef0edd0 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\"
Reviewed-by: mcimadamore
2013-08-14 10:53:37 +01:00
Maurizio Cimadamore
58d92c516a 8021567: Javac doesn't report \"java: reference to method is ambiguous\" any more
Javac incorrectly forgets about constant folding results within lambdas

Reviewed-by: jjg, vromero
2013-08-12 17:28:31 +01:00
Maurizio Cimadamore
4e85a5ae43 6537020: JCK tests: a compile-time error should be given in case of ambiguously imported fields (types, methods)
Hiding check does not support interface multiple inheritance

Reviewed-by: jjg
2013-08-12 17:25:07 +01:00
Vicente Romero
190f9337b1 6983297: methods missing from NewArrayTree
Reviewed-by: jjg
2013-08-10 16:29:26 +01:00
Vicente Romero
22652f5354 8022622: javac, two tests are failing with compile time error after class Collector was modified
Reviewed-by: mcimadamore
2013-08-10 16:26:50 +01:00
Vicente Romero
cee3c2853b 8009640: -profile <compact> does not work when -bootclasspath specified
Reviewed-by: jjg
2013-08-10 13:27:38 +01:00
Kumar Srinivasan
35e27fd594 8022161: javac Null Pointer Exception in Enter.visitTopLevel
Reviewed-by: jjg, vromero, jlahoda
2013-08-09 15:01:33 -07:00
Chris Hegarty
bea82c70dc Merge 2013-08-09 14:44:53 +01:00
Vicente Romero
cecb5cc0ea 8019486: javac, generates erroneous LVT for a test case with lambda code
Reviewed-by: mcimadamore
2013-08-08 11:49:16 +01:00
Bhavesh Patel
a8090b5024 4749567: stddoclet: Add CSS style for setting header/footer to be italic
Reviewed-by: jjg
2013-08-07 16:09:31 -07:00
Bhavesh Patel
69a3c42db7 7198274: RFE : Javadoc Accessibility : Use CSS styles rather than <strong> or <i> tags
Reviewed-by: jjg
2013-08-07 15:00:24 -07:00
Vicente Romero
0fb4cd9d38 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations
Reviewed-by: jjg, jfranck
2013-08-07 10:41:20 +01:00
Joel Borggrén-Franck
70ac5c3a48 8009367: Wrong kind of name used in comparison in javax.lang.model code for repeatable annotations
Reviewed-by: jjg, darcy
2013-08-07 01:32:39 +02:00
Vicente Romero
5f5b303d7e 8022186: javac generates dead code if a try with an empty body has a finalizer
Reviewed-by: jjg
2013-08-06 15:08:49 +01:00
Kumar Srinivasan
da7f38703d 8014826: c.s.t.javac.tree.Pretty.visitNewArray() prints duplicate dimension markers
Reviewed-by: jjg, vromero
2013-07-31 08:37:34 -07:00
Vicente Romero
5540c7cbe1 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6
Reviewed-by: jjg
2013-07-31 10:52:01 +01:00
Jan Lahoda
0847cbc403 8021338: Diamond finder may mark a required type argument as unnecessary
Reviewed-by: mcimadamore
2013-07-28 10:17:45 +02:00
Jan Lahoda
21ab6d5558 8020689: Missing LineNumberTable entries in compiled class files
Reviewed-by: ksrini, mcimadamore
2013-07-28 10:17:45 +02:00
Lana Steuck
f5da332e66 Merge 2013-07-26 14:08:37 -07:00
Chris Hegarty
3ec24e3419 Merge 2013-07-25 19:06:03 +01:00
Maurizio Cimadamore
da6bbaf42b 8020843: javac crashes on accessibility check with method reference with typevar receiver
Method reference overload check doesn't walk through type-variable receivers

Reviewed-by: jjg
2013-07-25 14:51:40 +01:00
Maurizio Cimadamore
663170c654 8016081: field initialized with lambda in annotation types doesn't compile
Check for annotation attributes should skip over synthetic methods

Reviewed-by: jjg
2013-07-25 14:49:16 +01:00
Maurizio Cimadamore
67362236e8 8020804: javac crashes when speculative attribution infers intersection type with array component
Assertion is causing javac to crash because of lack of support for arrays in intersection types

Reviewed-by: jjg
2013-07-25 14:47:43 +01:00
Joel Borggrén-Franck
2030148ec2 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType
Reviewed-by: jjg
2013-07-25 11:02:27 +02:00
Jonathan Gibbons
0c5c756933 8020556: doclint does not check type variables for @throws
Reviewed-by: mcimadamore
2013-07-24 17:35:42 -07:00
Bhavesh Patel
dd0661e5ad 8016675: Make Javadoc pages more robust
Reviewed-by: jlaskey, ksrini
2013-07-24 15:18:33 -07:00
Eric McCorkle
be2ea6f949 8016880: 42 tests in annot102* fail with compile-time errors
Fixes error in type equality when bounds of type variables have annotations.

Reviewed-by: jjg, mcimadamore
2013-07-23 20:42:54 -04:00
Jonathan Gibbons
2a95b6ac74 8021215: javac gives incorrect doclint warnings on normal package statements
Reviewed-by: darcy
2013-07-23 16:06:11 -07:00
Lana Steuck
524a340ac9 Merge 2013-07-22 17:39:45 -07:00
Kumar Srinivasan
c6c6fe7b5e 8017216: javac doesn't fill in end position for some errors of type not found
8019421: Javac doesn't fill in end position for some annotation related errors
8019422: Javac doesn't fill in end position for uninitialized variable errors

Reviewed-by: jjg, mcimadamore
2013-07-19 07:22:53 -07:00
Jonathan Gibbons
c42bcf4526 8020664: doclint gives incorrect warnings on normal package statements
Reviewed-by: mcimadamore
2013-07-17 19:16:12 -07:00
Jonathan Gibbons
772640d4e8 8020313: doclint doesn't reset HTML anchors correctly
Reviewed-by: mcimadamore
2013-07-17 19:12:03 -07:00
Jonathan Gibbons
89197f0946 8014636: TestLiteralCodeInPre fails on windows
Reviewed-by: ksrini
2013-07-17 18:18:45 -07:00
Maurizio Cimadamore
70e005a7eb 8013638: Few policy tests are failing in Lambda nightly
BridgeHarness test is leaving files open

Reviewed-by: ksrini
2013-07-17 19:28:40 +01:00
Lana Steuck
be00b8110f Merge 2013-07-17 10:40:53 -07:00
Jan Lahoda
35af8eccde 8020586: Warning produced for an incorrect file
Always using DeferredLintHandler.immediateHandler when processing import classes

Reviewed-by: mcimadamore
2013-07-17 15:08:58 +02:00
Maurizio Cimadamore
a2a579a4bd 8019942: Graph inference: avoid redundant computation during bound incorporation
Bound incorporation should not perform same operation multiple times

Reviewed-by: jjg
2013-07-17 14:21:12 +01:00
Maurizio Cimadamore
717a989214 8019340: varargs-related warnings are meaningless on signature-polymorphic methods such as MethodHandle.invokeExact
Disable certain varargs warnings when compiling polymorphic signature calls

Reviewed-by: jjg
2013-07-17 14:19:25 +01:00
Maurizio Cimadamore
73953320cc 8020149: Graph inference: wrong logic for picking best variable to solve
Replace logic for selecting best inference leaf in the graph during an unsticking round

Reviewed-by: jjg
2013-07-17 14:19:02 +01:00
Maurizio Cimadamore
8850329bc1 8016640: compiler hangs if the generics arity of a base class is wrong
Check.checkCompatibleConcretes hang when javac creates synthetic supertypes for 269 model API

Reviewed-by: jjg
2013-07-17 14:16:25 +01:00
Maurizio Cimadamore
defbb67771 7041019: Bogus type-variable substitution with array types with dependencies on accessibility check
Call to upperBound() when performing type-variable substitution on element type leads to unsoundness

Reviewed-by: jjg
2013-07-17 14:14:49 +01:00
Maurizio Cimadamore
732e49f6dc 8020286: Wrong diagnostic after compaction
Compact diagnostic shows the least relevant method in the list

Reviewed-by: jjg
2013-07-17 14:14:32 +01:00
Maurizio Cimadamore
eb4e8153b3 8020147: Spurious errors when compiling nested stuck lambdas
Scope of deferred types is not copied correctly; postAttr analyzer should not run on stuck expressions

Reviewed-by: jjg
2013-07-17 14:13:15 +01:00
Maurizio Cimadamore
e92a56fade 8012238: Nested method capture and inference
8008200: java/lang/Class/asSubclass/BasicUnit.java fails to compile

Inference support should be more flexible w.r.t. nested method calls returning captured types

Reviewed-by: jjg, vromero
2013-07-17 14:11:41 +01:00
Maurizio Cimadamore
99b0413d48 8016175: Add bottom-up type-checking support for unambiguous method references
Type-checking of non-overloaded method references should be independent from target-type

Reviewed-by: jjg, vromero
2013-07-17 14:09:46 +01:00
Maurizio Cimadamore
941752ea25 8012242: Lambda compatibility and checked exceptions
Inference variables in 'throws' clause with no constraints should be inferred as RuntimeException

Reviewed-by: jjg, vromero
2013-07-17 14:04:01 +01:00
Jonathan Gibbons
9dd2fe90d4 8020278: NPE in javadoc
Reviewed-by: mcimadamore, vromero
2013-07-12 13:11:12 -07:00
Maurizio Cimadamore
617386d568 8013404: Unclear spec for target typing with conditional operator (?:)
Fix previously ignored test

Reviewed-by: jjg, vromero
2013-07-11 15:37:02 +01:00
Robert Field
d3d1da337a 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
8020010: Move lambda bridge creation from metafactory and VM to compiler

Langtools/javac component of the bridge support and MethodType vs. MethodHandle changes.

Reviewed-by: jjg, vromero, briangoetz, forax
2013-07-11 14:07:39 +01:00
Kumar Srinivasan
424ac16db0 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken
Reviewed-by: jjg
2013-07-09 14:54:20 -07:00
Maurizio Cimadamore
7229f89614 8019824: very long error messages on inference error
Inference error messages shows several spurious captured variables generated during an inference loop

Reviewed-by: jjg, vromero
2013-07-05 11:05:02 +01:00
Maurizio Cimadamore
4442f43ea3 8016702: use of ternary operator in lambda expression gives incorrect results
Constant types erroneously creep in during inference

Reviewed-by: jjg, vromero
2013-07-05 11:04:22 +01:00
Maurizio Cimadamore
28b5759093 8016059: Cannot compile following lambda
8016060: Lambda isn't compiled with return statement

Spurious error triggered during unnecessary recovery round

Reviewed-by: jjg, vromero
2013-07-05 11:03:04 +01:00
Maurizio Cimadamore
86f630b63e 8019480: Javac crashes when method is called on a type-variable receiver from lambda expression
Logic for shortcircuiting speculative attribution doesn't handle type-variable receivers

Reviewed-by: jjg, vromero
2013-07-05 11:02:17 +01:00
Maurizio Cimadamore
7e6f7dcca5 8017618: NullPointerException in RichDiagnosticFormatter for bad input program
RDF crashes when diagnostic contains type 'void'

Reviewed-by: jjg, vromero
2013-07-05 11:00:19 +01:00
Vicente Romero
684d5ec76d 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
Reviewed-by: mcimadamore
2013-07-04 10:41:08 +01:00
Vicente Romero
8277af52ee 8009924: some langtools tools do not accept -cp as an alias for -classpath
Reviewed-by: jjg
2013-07-04 10:35:33 +01:00
Vicente Romero
ea2c99f5bb 6326693: variable x might already have been assigned, when assignment is in catch block
Reviewed-by: mcimadamore
2013-07-02 22:49:40 +01:00
Kumar Srinivasan
bab861035d 8019460: tests in changeset do not have @bug tag
Reviewed-by: darcy
2013-07-01 16:36:08 -07:00
Joe Darcy
547a050fe1 7162089: Add support for repeating annotations to javax.annotation.processing
Reviewed-by: abuckley, jjg, jfranck
2013-07-01 11:58:45 -07:00
Maurizio Cimadamore
1c13f5e4cb 7034798: Ambiguity error for abstract method call is too eager
Javac should wait and see if ambiguous methods can be reconciled at the end of an overload resolution round

Reviewed-by: jjg, vromero
2013-07-01 14:57:03 +01:00
Lana Steuck
c5e36903f7 Merge 2013-06-28 19:47:54 -07:00
Eric McCorkle
95e39e6039 8016760: Failure of regression test langtools/tools/javac/T6725036.java
Marking the failing test @ignore; the proposed change for 8015666 addresses the underlying issue

Reviewed-by: jjg
2013-06-28 06:54:58 -04:00
Eric McCorkle
9b1ec513d5 8013357: javac accepts erroneous binary comparison operations
Javac does not report type errors on illegal Object == primitive comparisons

Reviewed-by: abuckley, mcimadamore
2013-06-27 17:45:56 -04:00
Jan Valenta
97f7bab3c7 8015720: since tag isn't copied while generating JavaFX documentation
Reviewed-by: jjg
2013-06-27 17:47:18 +02:00
Vicente Romero
a87b5d942d 7008643: inlined finally clauses confuse debuggers
Reviewed-by: jjg
2013-06-27 16:06:56 +01:00
Vicente Romero
4e49cb5fc5 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
Reviewed-by: jjg
2013-06-27 16:04:05 +01:00
Eric McCorkle
a2c99b7e5c 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters
The compiler does not account fr extra parameters due to inner this parameters

Reviewed-by: jjg
2013-06-27 00:37:13 -04:00
Bhavesh Patel
b2c41f305e 8013738: Two javadoc tests have bug 0000000
Reviewed-by: jjg
2013-06-26 20:45:47 -07:00
Bhavesh Patel
9a773a649c 8014017: extra space in javadoc class heading
Reviewed-by: jjg
2013-06-26 20:42:43 -07:00
Bhavesh Patel
561009c4ac 8007338: Method grouping tab line-folding
Reviewed-by: jjg
2013-06-26 20:38:21 -07:00
Matherey Nunez
eedcd5d290 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values
Reviewed-by: jjg, darcy
2013-06-26 18:03:58 -07:00
David Katleman
ed14278b82 8016684: JDK8 b94 source with GPL header errors
Reviewed-by: tbell, darcy
2013-06-26 11:26:33 -07:00
Kumar Srinivasan
3ab53b61f0 8016908: TEST_BUG: removing non-ascii characters causes tests to fail
Reviewed-by: jjg, vromero
2013-06-26 09:54:46 -07:00
Alexander Zuev
fd80bae5c5 8006973: jtreg test fails: test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java
Reviewed-by: ksrini
2013-06-25 20:08:52 +04:00
Eric McCorkle
17f5808828 8012722: Single comma in array initializer should parse
Annotations of the form @Foo({,}) should parse

Reviewed-by: jjg
2013-06-24 22:03:57 -04:00
Chris Hegarty
700804c6f2 8017045: anti-delta fix for 8013789
Reviewed-by: alanb
2013-06-19 11:48:05 +01:00
Chris Hegarty
9c098465a5 Merge 2013-06-18 09:36:46 +01:00
Maurizio Cimadamore
1839512a15 8013789: Compiler should emit bridges in interfaces
Paired with 8015402: Lambda metafactory should not attempt to determine bridge methods

Reviewed-by: vromero
2013-06-17 20:29:31 -07:00
Chris Hegarty
be5d596030 Merge 2013-06-17 11:27:46 +01:00
Vicente Romero
5d4b6cd0d0 8008023: Get rid of utf8 chars in two tests
Reviewed-by: jjg
2013-06-14 18:01:52 +01:00
Vicente Romero
3596018eb7 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error
Reviewed-by: jjg
2013-06-11 09:59:34 +01:00
Chris Hegarty
d758772ec0 Merge 2013-06-11 09:25:57 +01:00
Maurizio Cimadamore
80407ef47d 8013576: Add stat support to LambdaToMethod
LambdaToMethod should emit info to help diagnose/test lambda metafactory problems

Reviewed-by: jjg, vromero
2013-06-10 15:57:32 +01:00
Vicente Romero
7258bbbfde 7113519: test/tools/javac/VersionOpt.java passes on windows
Reviewed-by: jjg
2013-06-10 15:18:47 +01:00
Chris Hegarty
8bb77f2674 Merge 2013-06-10 09:52:54 +01:00
Bhavesh Patel
3f6b61d75e 8015997: Additional improvement in Javadoc framing
Reviewed-by: jjg
2013-06-07 16:12:04 -07:00
Maurizio Cimadamore
dc899fbbed Merge 2013-06-06 15:38:42 +01:00
Maurizio Cimadamore
459b2cba93 8015648: Duplicate variable in lambda causes javac crash
Missing flag in synthetic lambda blog is causing duplicates symbol to go undetected

Reviewed-by: jjg, vromero
2013-06-06 15:37:23 +01:00
Maurizio Cimadamore
abaf1a5c51 8015432: javac crashes with stack overflow when method called recursively from nested generic call
Check.checkMethod should only be called after inference has completed

Reviewed-by: jjg, vromero
2013-06-06 15:35:05 +01:00
Maurizio Cimadamore
07baf8072a 8008627: Compiler mishandles three-way return-type-substitutability
Compiler should not enforce an order in how ambiguous methods should be resolved

Reviewed-by: jjg, vromero
2013-06-06 15:33:40 +01:00
Maurizio Cimadamore
4cb585609d 7139681: Enhanced for loop: local variable scope inconsistent with JLS
For-each loop variable is incorrectly visible from the for-each expression

Reviewed-by: jjg, vromero
2013-06-06 15:32:41 +01:00
Maurizio Cimadamore
884ad14bdf 6360970: javac erroneously accept ambiguous field reference
Clash between ambiguous fields in superinterface and unambiguous field in subinterface is erroneously marked as unambiguous

Reviewed-by: jjg, vromero
2013-06-06 15:30:14 +01:00
Eric McCorkle
c58691dc6f 8015701: MethodParameters are not filled in for synthetic captured local variables
Synthetic parameters for captured local variables in an anonymous inner class are not added to MethodParameters attributes

Reviewed-by: mcimadamore
2013-06-06 08:48:23 -04:00
Alexander Zuev
63c141c512 7186887: Test T6567415.java can fail on a slow machine
Reviewed-by: jjg, ksrini
2013-06-05 16:58:10 +04:00
Jonathan Gibbons
bdfb93ee25 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
Reviewed-by: mcimadamore, jfranck
2013-06-04 14:17:50 -07:00
Vicente Romero
aeb1c4b67e 7165659: javac incorrectly sets strictfp access flag on inner-classes
Reviewed-by: jjg, mcimadamore
2013-06-04 13:21:41 +01:00
Maurizio Cimadamore
5d6029baac 8015505: Spurious inference error when return type of generic method requires unchecked conversion to target
Use check context compatibility during 15.12.2.8 check (only when JDK 8 inference is enabled)

Reviewed-by: jjg
2013-06-04 11:34:31 +01:00
Maurizio Cimadamore
1c6a680e66 8008160: Five lambda TargetType tests have @ignore
Remove @ignore flags from tests that now pass

Reviewed-by: jjg
2013-06-04 11:31:12 +01:00
Maurizio Cimadamore
f0112464e0 7116676: RichDiagnosticFormatter throws NPE when formatMessage is called directly
Fix NPE in RichDiagnosticFormatter.formatMessage

Reviewed-by: jjg
2013-06-04 11:30:51 +01:00
Jonathan Gibbons
a282ed3923 8007687: javadoc -X does not include -Xdoclint
Reviewed-by: darcy
2013-06-03 17:24:47 -07:00
Jonathan Gibbons
a850ba134d 8006615: [doclint] move remaining messages into resource bundle
Reviewed-by: mcimadamore, vromero
2013-06-03 17:09:26 -07:00
Lana Steuck
8c25e96e5a Merge 2013-06-03 16:56:54 -07:00
Jonathan Gibbons
c594d824a4 8013405: DocLint should support <LI value="value">
Reviewed-by: ksrini
2013-06-03 16:22:27 -07:00
Lana Steuck
ba0fc64a03 Merge 2013-06-03 16:10:18 -07:00
Vicente Romero
7ab7587227 6695379: Copy method annotations and parameter annotations to synthetic bridge methods
Reviewed-by: mcimadamore
2013-06-01 22:09:18 +01:00
Vicente Romero
0ace868fe4 8010737: javac, known parameter's names should be copied to automatically generated constructors for inner classes
Reviewed-by: mcimadamore
2013-06-01 21:57:56 +01:00
Chris Hegarty
2252b22e09 Merge 2013-05-31 10:28:30 +01:00
Vicente Romero
06d1d22eb5 7179353: try-with-resources fails to compile with generic exception parameters
Reviewed-by: mcimadamore
2013-05-31 10:04:59 +01:00
David Katleman
b08f6026b4 8015525: JDK8 b91 source with GPL header errors
Reviewed-by: dholmes, lancea
2013-05-29 10:16:32 -07:00
Vicente Romero
33f5aae0ff 7053059: VerifyError with double Assignment using a Generic Member of a Superclass
Reviewed-by: mcimadamore
2013-05-29 10:56:29 +01:00
Vicente Romero
e58031ceba 6970173: Debug pointer at bad position
Reviewed-by: mcimadamore
2013-05-28 12:46:10 +01:00
Maurizio Cimadamore
d176f2abdf 8014494: javac crashes when varargs element of a method reference is inferred from the context
Varargs element is not refreshed after type-inference

Reviewed-by: jjg, vromero
2013-05-24 15:27:27 +01:00
Maurizio Cimadamore
9d588c1a23 8014649: Regression: bug in Resolve.resolveOperator
Missing curly braces causes Resolve.findMethod to be called spuriously

Reviewed-by: jjg, vromero
2013-05-24 15:27:12 +01:00
Maurizio Cimadamore
372fabc476 8014643: Parser regression in JDK 8 when compiling super.x
Fixed latent bug in JavacParser.analyzeParens()

Reviewed-by: jjg, vromero
2013-05-24 15:26:57 +01:00
Chris Hegarty
6bfa9213b2 Merge 2013-05-23 12:50:40 +01:00
Vicente Romero
5b545ba465 7164114: Two jtreg tests are not run due to no file extension on the test files
Reviewed-by: mcimadamore
2013-05-21 14:33:09 +01:00
Vicente Romero
6a02cd46e0 8005207: test has 2 @bug tags
Reviewed-by: mcimadamore
2013-05-21 13:50:56 +01:00
Vicente Romero
a24da77752 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir
Reviewed-by: mcimadamore
2013-05-21 12:17:18 +01:00
Joel Borggrén-Franck
4a4457b237 8013180: Qualified type reference with annotations in throws list crashes compiler
Reviewed-by: jjg
2013-05-21 12:00:29 +02:00
Robert Field
495e78ce52 8010006: NPE in javac with interface super in lambda
Reviewed-by: mcimadamore
2013-05-15 06:53:01 -07:00
Maurizio Cimadamore
4b1aa379e5 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
Bad warnings and position for lambda inferred parameter types

Reviewed-by: jjg, vromero
2013-05-15 14:03:09 +01:00
Maurizio Cimadamore
fc9e870275 8012685: Spurious raw types warning when using unbound method references
Spurious raw type warning when unbound method reference qualifier parameter types are inferred from target

Reviewed-by: jjg, vromero
2013-05-15 14:02:37 +01:00
Maurizio Cimadamore
ec458693f7 8012003: Method diagnostics resolution need to be simplified in some cases
Unfold method resolution diagnostics when they mention errors in poly expressions

Reviewed-by: jjg, vromero
2013-05-15 14:00:31 +01:00
Jonathan Gibbons
df6136dc9a 8014323: Add VariableTree.getNameExpression
Reviewed-by: darcy
2013-05-14 21:08:40 -07:00
Sonali Goel
20c8d5925c 8013163: Convert 4 tools multicatch tests to jtreg format
Reviewed-by: jjg
2013-05-14 18:02:48 -07:00
Werner Dietl
54582cab82 8013852: update reference impl for type-annotations
Co-authored-by: Steve Sides <steve.sides@oracle.com>
Co-authored-by: Joel Borggren-Franck <joel.franck@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Reviewed-by: jjg
2013-05-14 15:04:06 -07:00
Robert Field
c51505263f 8012556: Implement lambda methods on interfaces as static
8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface

Lambdas occurring in static contexts or those not needing instance information should be generated into static methods.  This has long been the case for classes.  However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods.  For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'.  MethodHandles now support static methods on interfaces.  This changeset allows lambda methods to be generated as static interface methods.  An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used.  This test and another test that already exposed this bug have been marked with @ignore.

Reviewed-by: mcimadamore
2013-05-14 11:11:09 -07:00
Jonathan Gibbons
997db01200 8012308: Remove TagletOutput in favor of direct use of Content
Reviewed-by: darcy
2013-05-14 10:14:57 -07:00
Jonathan Gibbons
2a88c7b71d 8012311: Cleanup names and duplicatre code in TagletManager
Reviewed-by: darcy
2013-05-14 10:14:56 -07:00
Jonathan Gibbons
3cbf2d13c3 8012295: Cleanup JavaFX features in standard doclet
Reviewed-by: darcy
2013-05-14 10:14:56 -07:00
Jonathan Gibbons
1631e19242 8012176: reduce use of TagletOutputImpl.toString
Reviewed-by: darcy
2013-05-14 10:14:54 -07:00
Jonathan Gibbons
147bdb8230 8012175: Convert TagletOutputImpl to use ContentBuilder instead of StringBuilder
Reviewed-by: darcy
2013-05-14 10:14:54 -07:00
Jonathan Gibbons
0ac80e7f93 8011288: Erratic/inconsistent indentation of signatures
Reviewed-by: darcy
2013-05-14 10:14:53 -07:00
Jonathan Gibbons
f961eafe35 8011642: Remove LinkOutput in favor of direct use of Content
Reviewed-by: bpatel, darcy
2013-05-14 10:14:52 -07:00
Jan Lahoda
921bd43131 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees
Co-authored-by: Dusan Balek <dbalek@netbeans.org>
Reviewed-by: jjg
2013-05-10 15:15:50 +02:00
Jonathan Gibbons
c037757e7b 8014363: javac test class ToolTester handles classpath incorrectly
Reviewed-by: ksrini
2013-05-12 18:18:54 -07:00
Alan Bateman
d4858d53df 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1
Reviewed-by: mchung
2013-05-10 16:10:20 +01:00
Joel Borggrén-Franck
d5eeeb875b 8013485: javac can't handle annotations with a <clinit> from a previous compilation unit
Reviewed-by: mcimadamore
2013-05-08 14:10:53 +02:00
Chris Hegarty
6dc03dadce Merge 2013-05-08 10:28:35 +01:00
Jonathan Gibbons
5b3642b5ce 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar
Reviewed-by: vromero, mcimadamore
2013-05-07 14:27:30 -07:00
Robert Field
136b4bc9b2 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails
Reviewed-by: mcimadamore
2013-05-07 06:39:34 -07:00
Jan Lahoda
57d8a7fc0f 8009724: Enhance the DocTree API with DocTreePath
Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respectively

Co-authored-by: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Reviewed-by: jjg
2013-05-06 16:22:45 +02:00
Jonathan Gibbons
4b44fd7622 8008768: Using {@inheritDoc} in simple tag defined via -tag fails
Co-authored-by: Mike Duigou <mike.duigou@oracle.com>
Reviewed-by: jjg, mduigou
2013-05-03 17:44:38 -07:00
Jonathan Gibbons
cb5ef8cc5c 8000407: remove @GenerateNativeHeader
Reviewed-by: vromero, darcy
2013-05-03 15:08:47 -07:00
Jonathan Gibbons
ce05f1c8ec 8002387: Improve rendered HTML formatting for {@code}
Reviewed-by: ksrini
2013-05-03 10:17:12 -07:00
Jonathan Gibbons
155bd74411 8012728: Normalize @ignore comments on langtools tests
Reviewed-by: vromero, mcimadamore
2013-05-03 09:56:56 -07:00
Bhavesh Patel
64831179a9 8012375: Improve Javadoc framing
Reviewed-by: mduigou, jlaskey
2013-05-03 08:52:33 -07:00
Robert Field
0ab1bb68cc 8011591: BootstrapMethodError when capturing constructor ref to local classes
Reviewed-by: mcimadamore
2013-05-01 08:46:04 -07:00
Vicente Romero
625f8df5f5 8012723: strictfp interface misses strictfp modifer on default method
Reviewed-by: mcimadamore
2013-04-26 10:04:01 +01:00
Jonathan Gibbons
2c4b48dced 8013256: javac test failing after Lambda changes to java.util.List
Reviewed-by: mduigou
2013-04-25 17:45:36 -07:00
Chris Hegarty
f748062d6b Merge 2013-04-24 11:03:32 +01:00
Lana Steuck
cdf9c2dc11 Merge 2013-04-23 15:09:12 -07:00
Joel Borggrén-Franck
16bec05e63 8011027: Type parameter annotations not passed through to javax.lang.model
Reviewed-by: jjg, darcy
2013-04-22 10:24:19 +02:00
Lana Steuck
0285880f3d Merge 2013-04-17 21:50:43 -07:00
Jan Lahoda
77b43bacfd 8008174: DocTree API should provide start and end positions for tree nodes
Adding DocSourcePositions to allow access to DocTree starting/ending position

Co-authored-by: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Reviewed-by: jjg, darcy
2013-04-17 15:54:24 +02:00
Vicente Romero
0e9ad4439a 8011181: javac, empty UTF8 entry generated for inner class
Reviewed-by: jjg
2013-04-17 11:11:33 +01:00
David Katleman
bae256e87f Merge 2013-04-16 15:00:49 -07:00
Maurizio Cimadamore
8b680bdde2 8011392: Missing checkcast when casting to intersection type
Javac should emit a checkcast for each additional target type specified in an intersection type cast

Reviewed-by: jjg
2013-04-15 14:17:30 +01:00
Maurizio Cimadamore
8f2d47cf79 8011028: lang/INFR/infr001/infr00101md/infr00101md.java fails to compile after switch to JDK8-b82
Fix bug in Types.removeWildcards

Reviewed-by: jjg
2013-04-15 14:16:05 +01:00
Maurizio Cimadamore
e59fd44a73 8011376: Spurious checked exception errors in nested method call
Fallback attribution logic doesn't work properly when lambda throws checked exceptions

Reviewed-by: jjg
2013-04-15 14:15:07 +01:00
Maurizio Cimadamore
2b94dbb504 8011377: Javac crashes when multiple lambdas are defined in an array
Wrong attribution environment used by DeferredAttr

Reviewed-by: jjg
2013-04-15 14:12:17 +01:00
Maurizio Cimadamore
efc501257b 8011383: Symbol.getModifiers omits ACC_ABSTRACT from interface with default methods
Fixup for default method modifiers erroneously applies to class-level modifiers

Reviewed-by: jjg
2013-04-15 14:11:29 +01:00
Bhavesh Patel
56d97d6507 8009686: Generated javadoc documentation should be able to display type annotation on an array
Reviewed-by: jjg
2013-04-13 18:48:29 -07:00
Maurizio Cimadamore
3044b19d21 8010659: Javac Crashes while building OpenJFX
Reviewed-by: jjg
2013-04-13 12:25:44 +01:00
David Katleman
9261edec97 8012048: JDK8 b85 source with GPL header errors
Reviewed-by: iris, mduigou, jjg
2013-04-12 15:22:47 -07:00
Joel Borggrén-Franck
6f2f8b14be 7015104: use new subtype of TypeSymbol for type parameters
Reviewed-by: jjg, mcimadamore
2013-04-12 12:05:04 +02:00
Vicente Romero
cde5be4904 8011432: javac, compiler regression iterable + captured type
Reviewed-by: mcimadamore
2013-04-10 12:31:02 +01:00
Bhavesh Patel
b82442a565 8005091: javadoc should be able to return the receiver type
Reviewed-by: jjg
2013-04-09 14:18:22 -07:00
Maurizio Cimadamore
da9dd76b20 8010822: Intersection type cast for functional expressions does not follow spec EDR
Remove support for marker interfaces; redefine intersection type casts to be order-independent

Reviewed-by: jjg
2013-04-08 15:59:29 +01:00
Maurizio Cimadamore
ea55015155 8009131: Overload: javac should discard methods that lead to errors in lambdas with implicit parameter types
Lambdas that have errors in their bodies should make enclosing overload resolution fail

Reviewed-by: jjg
2013-04-08 15:57:10 +01:00
Maurizio Cimadamore
b4b6e4f82e 8010404: Lambda debugging: redundant LineNumberTable entry for lambda capture
Ignore indy entries in LineNumberTable

Reviewed-by: jjg
2013-04-08 15:53:08 +01:00
Maurizio Cimadamore
08df98aa3c 8010823: DefaultMethodTest.testReflectCall fails with new lambda VM
Fix lambda test

Reviewed-by: jjg
2013-04-08 15:52:05 +01:00
Joe Darcy
3aabe92c92 8011052: Add DEFAULT to javax.lang.model.Modifier
Reviewed-by: abuckley, jjg
2013-04-03 12:27:12 -07:00
Vicente Romero
a19d0728ba 4965689: class literal code wastes a byte
Reviewed-by: jjg
2013-04-02 10:51:16 +01:00
Jonathan Gibbons
18f48ab46b 8010511: Tests are creating files in /tmp
Reviewed-by: darcy
2013-03-28 10:58:45 -07:00
Jonathan Gibbons
84a50dc114 8006346: doclint should make allowance for headers generated by standard doclet
Reviewed-by: mcimadamore
2013-03-28 10:49:39 -07:00
Joe Darcy
d54accaf5c 7080464: langtools regression test failures when assertions are enabled
Reviewed-by: jjg
2013-03-22 10:08:46 -07:00
Maurizio Cimadamore
7ee4846b45 8010387: Javac crashes when diagnostic mentions anonymous inner class' type variables
Rich formatter doesn't preprocess supertypes of an anonymous inner class

Reviewed-by: jjg
2013-03-22 12:44:48 +00:00
Maurizio Cimadamore
2b66afe14d 8010303: Graph inference: missing incorporation step causes spurious inference error
Multiple equality constraints on inference vars are not used to generate new inference constraints

Reviewed-by: jjg
2013-03-22 12:43:09 +00:00
Maurizio Cimadamore
710a687c15 8009820: AssertionError when compiling java code with two identical static imports
Speculative attribution is carried out twice with same method symbol in case of static imports

Reviewed-by: jjg
2013-03-22 12:41:13 +00:00
Maurizio Cimadamore
cec722fe8f 8010101: Intersection type cast issues redundant unchecked warning
Code for checking intersection type cast is incorrectly swapping operands, leading to spurious warnings

Reviewed-by: jjg
2013-03-22 12:39:34 +00:00
Maurizio Cimadamore
2454c8c5ae 8009649: Lambda back-end should generate invokespecial for method handles referring to private instance methods
Private lambda methods should be accessed through invokespecial

Reviewed-by: jjg
2013-03-22 12:38:12 +00:00
Jonathan Gibbons
d4e9a74af5 8010317: DocLint incorrectly reports some <pre> tags as empty
Reviewed-by: darcy
2013-03-19 19:16:59 -07:00
Joe Darcy
479d5c83b0 8010179: Remove transitional target values from javac
Reviewed-by: jjg, mcimadamore
2013-03-19 13:10:40 -07:00
Peter Jensen
1e91824535 8005220: RFE to write javap tests for repeating annotations
Reviewed-by: jjg
2013-03-18 08:46:09 -07:00
Matherey Nunez
cd78ad2c8a 8007767: TargetAnnoCombo.java need to be updated to add a new test mode
Reviewed-by: jjg, strarup
2013-03-15 13:39:04 +01:00
Vicente Romero
a7e53ae56d 5053846: javac: MethodRef entries are duplicated in the constant pool
Reviewed-by: mcimadamore
2013-03-15 09:02:26 +00:00
Robert Field
46e9ef69a7 8010010: NPE generating serializedLambdaName for nested lambda
Reviewed-by: mcimadamore
2013-03-14 22:54:17 -07:00
Mandy Chung
857b7efb96 8005428: Update jdeps to read the same profile information as by javac
Reviewed-by: alanb
2013-03-14 10:33:31 -07:00
Vicente Romero
4ef6ef5d0f 8008582: jtreg failures after conversion of shell tests to Java
Reviewed-by: jjg
2013-03-14 08:30:16 +00:00
Bhavesh Patel
82210b98a8 8009684: Default top left frame should be "All Packages" in the generated javadoc documentation
Reviewed-by: jjg
2013-03-13 14:47:15 -07:00
Joel Borggrén-Franck
09e3f06ae6 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
Reviewed-by: jjg
2013-03-13 22:03:09 +01:00
Joel Borggrén-Franck
4de6d2c42c 7196531: Duplicate error messages on repeating annotations
Reviewed-by: jjg
2013-03-12 17:39:34 +01:00
Maurizio Cimadamore
22e2c128a2 8009545: Graph inference: dependencies between inference variables should be set during incorporation
Move all transitivity checks into the incorporation round

Reviewed-by: jjg
2013-03-12 16:02:43 +00:00
Maurizio Cimadamore
69ee819808 8008540: Constructor reference to non-reifiable array should be rejected
8008539: Spurious error when constructor reference mention an interface type
8008538: Constructor reference accepts wildcard parameterized types

Overhaul of Check.checkConstructorRefType

Reviewed-by: jjg
2013-03-12 16:02:13 +00:00
Joel Borggrén-Franck
c3e43ab7d5 8005205: tests missing bugid for repeating annotation change
Reviewed-by: jjg, ssides
2013-03-12 11:16:30 +01:00
Robert Field
41447ec765 8009742: Bad lambda name for lambda in a static initializer or ctor
Reviewed-by: mcimadamore
2013-03-11 10:02:55 -07:00
Vicente Romero
475c6f42ad 6181889: Empty try/finally results in bytecodes being generated
Reviewed-by: mcimadamore
2013-03-11 15:35:13 +00:00
Robert Field
867e1720c2 8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization
Reviewed-by: mcimadamore
2013-03-07 08:26:13 -08:00
Vicente Romero
b04bec8156 8009170: Regression: javac generates redundant bytecode in assignop involving arrays
Reviewed-by: mcimadamore
2013-03-07 10:12:13 +00:00