Commit Graph

259 Commits

Author SHA1 Message Date
Kumar Srinivasan
b320d61bdb 8175055: Errors reported by Arguments.validate should (probably) be fatal
Reviewed-by: jjg
2017-02-25 18:02:06 -08:00
Alexandre Iline
0defcd0141 8151220: Extend sample API to use modules
Reviewed-by: ksrini
2017-02-21 15:38:07 -08:00
Vicente Romero
a82c165dd5 8174805: JavacTrees should use Types.skipTypeVars() to get the upper bound of type variables
Reviewed-by: jjg, ksrini
2017-02-16 14:47:39 -08:00
Jonathan Gibbons
103bce2074 8175047: javadoc should support --help-extra as a synonym for -X
Reviewed-by: ksrini
2017-02-15 18:30:31 -08:00
Kumar Srinivasan
bb1db91db4 8174839: javadoc crashes with a method which does not override a super
Reviewed-by: jjg
2017-02-15 14:25:50 -08:00
Jonathan Gibbons
6873ceb82c 8173596: JavaCompiler.CompilationTask should support addModules
Reviewed-by: ksrini, jlahoda
2017-02-15 14:12:29 -08:00
Bhavesh Patel
8dfb222edf 8151743: Header can still disappear behind the navbar
Reviewed-by: jjg, ksrini
2017-02-15 11:55:16 -08:00
Kumar Srinivasan
dfa7ec7ad8 8173804: javadoc throws UnsupportedOperationException: should not happen
Reviewed-by: jjg
2017-02-15 11:23:52 -08:00
Kumar Srinivasan
388550d1a4 8174715: Javadoc fails on JDK 7 and JDK 8 sources with StringIndexOutOfBoundsException
Reviewed-by: jjg
2017-02-15 09:50:26 -08:00
Robert Field
cd867f35bd 8174862: JShell tests: new JDK-8174797 testInvalidClassPath fails on Windows
Reviewed-by: jlahoda
2017-02-13 17:04:26 -08:00
Robert Field
9691449f5f 8174797: jshell tool: invalid module path crashes tool
8174796: jshell tool: regression: user home (tilde) not translated

Reviewed-by: jlahoda
2017-02-13 08:50:26 -08:00
Jan Lahoda
4c9c591399 8174245: Javadoc is not working for some methods
Parsing source file as if they were part of their corresponding modules.

Reviewed-by: rfield
2017-02-13 11:57:56 +01:00
Alan Bateman
3460214b07 Merge 2017-02-10 12:28:35 +00:00
Alan Bateman
d6fbe2b113 8173393: Module system implementation refresh (2/2017)
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Reviewed-by: mcimadamore, mchung, alanb
2017-02-10 09:06:10 +00:00
Robert Field
6d73f9fae9 8174262: Error message misspelling: "instanciated"
Reviewed-by: jjg
2017-02-09 18:58:36 -08:00
Michel Trudeau
a55e3cd16b 8168965: search items are not listed in any sensible order
Reviewed-by: jjg, ksrini
2017-02-09 08:01:19 -08:00
Robert Field
52f0f390a8 8173916: jshell tool: /methods signature confusing/non-standard format
8174028: jshell tool: /method /type failed declaration listed (without indication)
8174041: jshell tool: --startup PRINTING references undeclared Locale class

Reviewed-by: jlahoda
2017-02-08 13:35:42 -08:00
Robert Field
4593304c07 8173845: JShell API: not patch compatible
Reviewed-by: jlahoda
2017-02-08 10:43:16 -08:00
Kumar Srinivasan
f24113bdb2 8173302: Move the Description up on module and package index page
Reviewed-by: bpatel, jjg
2017-02-07 13:45:29 -08:00
Robert Field
c42d389e2d 8173807: JShell: control characters should be escaped in String values
Reviewed-by: jlahoda
2017-02-06 09:25:31 -08:00
Robert Field
43593d5bf5 8173848: JShell: less-than causes: reached end of file while parsing
Reviewed-by: jlahoda
2017-02-06 09:00:02 -08:00
Bhavesh Patel
0c3069371e 8173707: Javadoc generated pages should default to no-frames view
Reviewed-by: jjg, ksrini
2017-02-02 14:55:23 -08:00
Jonathan Gibbons
d084a21c15 8172528: problem generating JavaFX docs
Reviewed-by: ksrini
2017-02-01 20:14:52 -08:00
Bhavesh Patel
3a1a49f453 8169813: The index pages are sorted in a confusing manner
Reviewed-by: jjg, ksrini
2017-02-01 15:16:49 -08:00
Kumar Srinivasan
c39d6e6a04 8048628: javadoc strips HTML incorrectly; causes invalid generated HTML files
Reviewed-by: jjg
2017-01-27 10:08:36 -08:00
Robert Field
88d92662cd 8173577: JShell tests: Some testng tests check nothing
Reviewed-by: jlahoda
2017-02-01 09:10:07 -08:00
Bhavesh Patel
737a10a2e7 8173419: Javadoc fix 8166175 results in test failures
Reviewed-by: jjg, ksrini
2017-01-26 16:53:56 -08:00
Bhavesh Patel
30c9249c9d 8166175: javadoc search doesn't work on local doc bundles
Reviewed-by: jjg, ksrini
2017-01-26 13:01:12 -08:00
Robert Field
01b7f9ed5e 8171343: jshell tool: missing options: --help-extra --show-version
Reviewed-by: jlahoda
2017-01-25 10:43:41 -08:00
Robert Field
8fd1027a6b 8173232: JShell tests: ReplaceTest takes too long
8173234: JShell tests: remove from ProblemList jdk/jshell/ToolFormatTest.java
8173204: JShell tests: ProblemList jdk/jshell/UserJdiUserRemoteTest.java

Reviewed-by: jlahoda
2017-01-25 10:22:06 -08:00
Robert Field
bba1175418 8173073: jshell tool: blank lines removed from multi-line snippets
Reviewed-by: jlahoda
2017-01-20 11:05:48 -08:00
Kumar Srinivasan
8045fb0059 8169608: Compiler Tree API's Doctrees.getDocTreePath needs to accept a PackageElement
8157611: field visiblePackages is null for the unnamed module producing NPE when accessed

Reviewed-by: jjg, jlahoda
2017-01-19 13:16:19 -08:00
Robert Field
362b794a82 8171130: jshell tool: /edit adds empty statement to brace terminated snippet
8173007: JShell Tests: ToolFormatTest takes too long

Reviewed-by: jlahoda
2017-01-19 11:17:11 -08:00
Robert Field
99e3bceb60 8172179: jshell tool: builtin startup settings should be by reference not content
Reviewed-by: jlahoda
2017-01-19 11:12:02 -08:00
Jonathan Gibbons
c2ee320e61 8138725: Add options for Javadoc generation
Reviewed-by: ksrini, bpatel, ahgross
2016-07-12 14:41:14 -07:00
Robert Field
cde454bda3 8172678: JShell Tests: Disable CompletionSuggestionTest.testBrokenClassFile2()
Reviewed-by: jlahoda
2017-01-13 18:29:21 -08:00
Jan Lahoda
fd12ea2d58 8171385: jshell tool: unresponsive to ctrl-C in input wait on Windows
Ensuring stop is sent using the proper channel depending on the current state of the StopDetectingInputStream.

Reviewed-by: rfield
2017-01-10 10:17:47 +01:00
Robert Field
cea33151ed 8171981: JShell: Fails compilation: new Object().getClass().getSuperclass()
Reviewed-by: mcimadamore
2017-01-09 18:04:16 -08:00
Robert Field
f9b57bfbed 8172255: JShell API: ExecutionControl/LoaderDelegate: Remove unused/unimplemented setClassPath
Reviewed-by: jlahoda
2017-01-09 13:50:45 -08:00
Robert Field
6f796f5684 8165405: jshell tool: /classpath is inconsistent
8172103: JShell: crash in TaskFactory$WrapSourceHandler.diag

Reviewed-by: jlahoda
2017-01-06 10:31:25 -08:00
Joe Darcy
42a9464947 8172220: Mark UserInputTest.java as intermittently failing and problem list it
Reviewed-by: jlahoda
2017-01-05 11:02:35 -08:00
Robert Field
6c52320ccc 8172102: jshell tool: remove print method forwarding to System.out from default startup
Reviewed-by: briangoetz
2017-01-02 18:31:30 -08:00
Robert Field
72b502fa4f 8171892: JShell: incorrect printing of multidemensional arrays
8171387: jshell tool: message inconsistencies

Reviewed-by: sundar, dlsmith
2016-12-23 11:17:50 -08:00
Robert Field
f7067671f6 8168615: JShell API: jdk.jshell.spi should be a pluggable ServiceLoader SPI
Reviewed-by: jlahoda
2016-12-21 20:14:39 -08:00
Robert Field
ea579f7bec 8170162: jshell tool: no mechanism to programmatically launch
8170044: jshell tool: jshell missing from javax.tools.ToolProvider

Reviewed-by: jjg
2016-12-20 13:42:13 -08:00
Jonathan Gibbons
23c1a004ec 8171413: jdk/javadoc/doclet/testModules/TestModules.java failed due to some subtests failed
Reviewed-by: bpatel
2016-12-20 06:06:01 -08:00
Bhavesh Patel
4a4e893915 8160196: Module summary page should display information based on "api" or "detail" mode
Reviewed-by: jjg, ksrini
2016-12-16 09:07:57 -08:00
Alan Bateman
574ac0add6 Merge 2016-12-16 08:17:55 +00:00
Alan Bateman
2381943e61 8170987: Module system implementation refresh (12/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Srikanth Adayapalam <srikanth.adayapalam@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Reviewed-by: mcimadamore
2016-12-16 05:47:58 +00:00
Bhavesh Patel
88d8618e30 8162674: change javadoc output text and style emitted by for-removal deprecations
Reviewed-by: jjg
2016-12-13 12:25:58 -08:00
Jonathan Gibbons
e9ddc68f70 8170251: Add javax.tools.Tool.name()
Reviewed-by: darcy, mchung
2016-12-09 16:24:50 -08:00
Jonathan Gibbons
7987d2876a 8170953: CheckResourceKeys tests should declare the resource package to be open
Reviewed-by: mchung
2016-12-08 16:52:38 -08:00
Bhavesh Patel
b5d8b0b991 8168688: javadoc top left frame should display all modules while in module mode
Reviewed-by: jjg
2016-12-08 12:46:59 -08:00
Bhavesh Patel
5ef4598ec8 8139101: javadoc emits "specified by" clause when class has a method that matches a static interface method
Reviewed-by: jjg, ksrini
2016-12-05 15:08:24 -08:00
Jan Lahoda
ae8ace7912 8165564: langtools\test\jdk\jshell\CommandCompletionTest.java fails on some windows
Ignoring non-existent default FileSystem roots.

Reviewed-by: rfield
2016-12-05 19:42:42 +01:00
Robert Field
411ce3da8c 8169828: jdk/jshell/ExternalEditorTest.java testStatementMush() fails frequently on all platform
8170015: jshell tool: /help output looks terrible on a 100 column wide terminal
8170368: jshell tool: post setting not properly applied, line-ends not prefixed correctly

Reviewed-by: jlahoda
2016-12-02 10:17:03 -08:00
Alan Bateman
01a366e6dd Merge 2016-12-01 11:16:45 +00:00
Alan Bateman
22e233b2e9 8169069: Module system implementation refresh (11/2016)
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Bhavesh Patel <bhavesh.x.patel@oracle.com>
Co-authored-by: Andrey Nazarov <andrey.x.nazarov@oracle.com>
Reviewed-by: mcimadamore, jjg, mchung, anazarov
2016-12-01 09:02:42 +00:00
Kumar Srinivasan
f4c9d73b3e 8164316: Refine the Doclet APIs
Reviewed-by: jjg
2016-11-24 20:48:52 -08:00
Robert Field
85eded3562 8169519: JShell: Handle start-up failures and hangs gracefully
8166581: JShell: locks forever if -R options is wrong
8169234: JShell: hangs on startup on some computers caused by hostname

Reviewed-by: jlahoda
2016-11-22 19:24:02 -08:00
Jonathan Gibbons
6e31f6440f 8164590: javac --inherit-runtime-environment fails with "cannot find modules: ALL-DEFAULT"
Reviewed-by: mchung
2016-11-22 15:57:32 -08:00
Robert Field
dda0e054d5 8114842: JShell: SourceCodeAnalysis splits code with array initialiazer incorrectly
Reviewed-by: jlahoda
2016-11-21 12:28:56 -08:00
Robert Field
f9eb02a066 8153402: jshell tool: completion provider for /help
8169818: jshell tool: completion provider for /vars /methods /types gives -history

Reviewed-by: jlahoda
2016-11-18 09:41:51 -08:00
Bhavesh Patel
e80463356c 8147890: Javadoc search does not work with Enums
Reviewed-by: jjg, ksrini
2016-11-16 17:22:08 -08:00
Jonathan Gibbons
f742ef0ed0 8169676: boolean result of Option.process is often ignored
Reviewed-by: ksrini, jlahoda
2016-11-16 11:53:24 -08:00
Robert Field
f3e88eb313 8143006: jshell tool: /edit doesn't process each line as same as inputs for jshell
8163816: JShell tests: jdk/jshell/ExternalEditorTest.java -- unexpected results EditorTestBase.testEditClass1() and .testEditMethod1()

Reviewed-by: jlahoda
2016-11-16 10:45:23 -08:00
Jan Lahoda
da7b11ca15 8169561: jshell tool: double shift-tab on variable crashes tool
Avoid crashe for unknown HTML tags; avoid crash for non-existing documentation; fix signature for JShell variables

Reviewed-by: rfield
2016-11-16 17:48:43 +01:00
Kumar Srinivasan
9b43eda24c 8167967: javadoc should identify the ordinal value of enum constants
Reviewed-by: jjg
2016-11-14 16:33:48 -08:00
Kumar Srinivasan
acae42fd30 8166379: IAE while invoking javadoc with --patch-module
Reviewed-by: jjg
2016-11-08 12:56:17 -08:00
Robert Field
907f7c2d7e 8161983: JShell API: Clean-up following 8160127 et. al
Reviewed-by: jlahoda
2016-11-06 22:50:46 -08:00
Robert Field
d292468c51 8129559: JShell: compilation fails if class, method or field is annotated and has modifiers
8080354: JShell: Runtime visible annotations cannot be retrieved

Reviewed-by: jlahoda
2016-11-04 14:47:25 -07:00
Robert Field
836024d6f9 8161969: jshell tool: /var value is not truncated per feedback setting
8166637: jshell tool: confusing truncation of long result values
8154513: JShell tool: welcome message should match feedback mode
8167552: jshell tool: Typo in jshell command '/? /reload' description

Reviewed-by: jlahoda
2016-11-03 09:12:02 -07:00
Robert Field
02e5b77101 8167636: jshell tool: Edit Pad should be in its own module
Reviewed-by: jlahoda
2016-11-02 16:29:50 -07:00
Jan Lahoda
5d215e5425 8131019: jshell tool: access javadoc from tool
Adding internal support to resolve {@inheritDoc} and format javadoc to plain text for use by jdk.jshell and jdk.scripting.nashorn.shell, enhancing Shift-<tab> documentation in JShell with ability to show javadoc.

Reviewed-by: jjg, rfield
2016-11-02 07:38:37 +01:00
Robert Field
70d8f3c7b4 8167643: JShell: silently ignore access modifiers (as semantically irrelevant)
Reviewed-by: jlahoda
2016-10-27 17:11:16 -07:00
Robert Field
ac9d25d027 8166649: jshell tool: missing --add-modules and --module-path
8167462: jshell tool: /help /reload is wrong about re-executing commands

Reviewed-by: jlahoda
2016-10-24 19:59:35 -07:00
Robert Field
5be06e9de2 8167637: jshell tool: /edit should use EDITOR setting
8167640: jshell tool: external editor temp file should be *.java

Reviewed-by: jlahoda
2016-10-24 17:06:10 -07:00
Robert Field
f601bcb76e 8163840: jshell tool: provide way to display configuration settings
Reviewed-by: jlahoda
2016-10-20 12:53:11 -07:00
Kumar Srinivasan
647a1f019f 8168368: Add missing bug id for JDK-8167383
Reviewed-by: bpatel
2016-10-19 16:58:09 -07:00
Kumar Srinivasan
7ef07fcf9a 8167383: Javadoc does not handle packages correctly when used with module option
Reviewed-by: bpatel, jjg
2016-10-19 14:51:20 -07:00
Bhavesh Patel
af3d6a8409 8151921: Improved page resolution
Reviewed-by: jjg, ksrini, ahgross
2016-07-14 13:35:35 -07:00
Jan Lahoda
7ac8bf6c75 8167461: jshell tool: Scanner#next() hangs tool
PipeInputStream.read(byte[]...) should only read available bytes; properly resending exceptions for snippet's System.in and properly closing it; more reliable way to cancel user input while waiting in System.in.

Reviewed-by: rfield
2016-10-18 16:00:32 +02:00
Shinya Yoshida
e3b0b0192b 8145263: JShell: Fix the format of SourceCodeAnalysis#documentation
Reviewed-by: rfield, jlahoda
2016-10-17 23:23:11 +09:00
Bhavesh Patel
1b3ae71f98 8141636: Javadoc search should support camelCase search
Reviewed-by: jjg
2016-10-13 10:48:09 -07:00
Robert Field
8b2ace697c 8167128: JShell: /drop of statement gives confusing output
Reviewed-by: jlahoda
2016-10-10 18:41:12 -07:00
Bhavesh Patel
0ce6fba428 4649116: Add option to include full package description at top, before interface table
Reviewed-by: jjg
2016-10-10 15:17:02 -07:00
Kumar Srinivasan
f4df89b00c 8165991: Fix DocTreeFactory newDocCommentTree
8154349: New doclet incorrectly shows entire text body for JavaFX properties in summary section

Reviewed-by: jjg
2016-10-10 11:21:00 -07:00
Kumar Srinivasan
6f16c4713d 8151102: Cleanup javadoc exception handling
Reviewed-by: jjg
2016-10-10 06:47:47 -07:00
Shinya Yoshida
a53b8b8a5d 8167343: JShell: Completeness analysis infers an incomplete declaration as COMPLETE_WITH_SEMI, which is a first line of Allman style
Reviewed-by: rfield
2016-10-11 00:28:49 +09:00
Jonathan Gibbons
6fef223c3f 8159855: Create an SPI for tools
Reviewed-by: mchung
2016-10-07 16:49:39 -07:00
Jonathan Gibbons
799f344fcc 8166144: New javadoc options don't conform to JEP 293 (GNU style options)
Reviewed-by: ksrini, bpatel
2016-09-30 13:15:22 -07:00
Shinya Yoshida
20a821ae7c 8166744: JShell: java.lang.IndexOutOfBoundsException for legal history access
Reviewed-by: rfield, jlahoda
2016-09-29 17:36:22 +09:00
Shinya Yoshida
b9ad123afa 8154714: jshell tool: add exports support
Reviewed-by: jlahoda, rfield
2016-09-28 16:36:10 +09:00
Andrey Nazarov
4c6cbab8ba 8166127: Develop new tests to cover javadoc module options which are passed to underlying javac
Reviewed-by: jjg, ksrini
2016-09-23 09:57:24 -07:00
Robert Field
1e18e0dc9f 8166400: JShell: friendlier representation of array values
Reviewed-by: sundar, jlahoda
2016-09-21 23:46:06 -07:00
Bhavesh Patel
ed209e2a48 8162363: Tables in javadoc documentation missing row headers
Reviewed-by: jjg
2016-09-21 18:18:50 -07:00
Jan Lahoda
835354dfa6 8131025: JShell: crash on tab-complete reference to bad class file
Catching CompletionFailure when iterating through Scope.

Reviewed-by: rfield
2016-09-08 15:48:28 +02:00
Robert Field
426f1d9d47 8080352: jshell tool: Error message for using "package" should be more descriptive than "Failed"
Reviewed-by: jlahoda
2016-09-07 12:15:22 -07:00
Robert Field
4017bf5f7a 8165211: JShell: Fix completion analysis problems
Reviewed-by: jlahoda
2016-09-01 13:21:52 -07:00
Jan Lahoda
8302f64ee6 8164952: JShell tests: jdk/jshell/CompletionSuggestionTest.testUncompletedDeclaration(): failure
Avoiding conflict between the CompletionSuggestionTest.testUncompletedDeclaration test and ClassPathTest

Reviewed-by: rfield
2016-09-01 21:25:33 +02:00