1558 Commits

Author SHA1 Message Date
Eric McCorkle
b343919526 8038263: Refactor annotation handling after actualEnterAnnotations
Move all repeating annotations code into Annotate, rework annotations pipeline into a more completer-like design, eliminate a cast from enterAnnotations/enterTypeAnnotations

Reviewed-by: jjg, jfranck
2014-04-03 20:28:23 -04:00
Paul Govereau
c654c5a23e 8015499: javac, Gen is generating extra checkcast instructions in some corner cases
Reviewed-by: vromero, jjg
2014-04-09 17:41:27 +01:00
Jan Lahoda
e5c8101894 8038455: Use single Context for all rounds of annotation processing
One set of javac services, as well as created ClassSymbols, is reused for all rounds of processing now.

Reviewed-by: jjg, jfranck, darcy, vromero
2014-04-08 14:06:11 +02:00
Paul Govereau
8e6660eb56 8023945: javac wrongly allows a subclass of an anonymous class
Reviewed-by: jjg
2014-04-04 19:13:53 -04:00
Kumar Srinivasan
73d4a30ede 8039231: [javadoc] test failure caused by javax.crypto fix
Reviewed-by: jjg
2014-04-04 18:36:16 -07:00
Kumar Srinivasan
def40f4158 8037881: javax.crypto is not listed in the compact* profiles javadoc
Reviewed-by: jjg
2014-04-03 12:04:58 -07:00
Bhavesh Patel
d642f92759 8032066: Serialized form has broken links to non private inner classes of package private
Reviewed-by: jjg
2014-04-01 23:58:04 -07:00
Paul Govereau
e231918e58 8034933: Update documentation for Types.directSupertypes to clarify behavior
Reviewed-by: darcy
2014-04-01 23:52:10 -07:00
Ivan Gerasimov
befb7157c9 8034044: Class.getModifiers() returns "static" for anonymous classes
Javac sets ACC_STATIC bit for anonymous classes which contradicts the JLS

Reviewed-by: jfranck
2014-04-02 10:05:16 +04:00
Jan Lahoda
e339370175 8035890: jdk8 javac -source 7 compiles test case it should not
Ensuring source level checks are performed in two additional cases related to type annotations, adding specialized error message for annotations after method type parameters.

Reviewed-by: jfranck, jjg
2014-03-31 21:27:25 +02:00
Bhavesh Patel
e08ccd0e48 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present
Reviewed-by: ksrini
2014-03-29 11:06:33 -07:00
Eric McCorkle
fb9c998b1d 8035768: Move TypeAnnotationPosition from Attribute.Compound to Attribute.TypeCompound
Move position field into Compound, making Compound into a kind of "proto-annotation", representing the situation before we know what an Annotation's kink is

Reviewed-by: jjg
2014-03-27 18:41:28 -04:00
Jonathan Gibbons
77ad0945a6 8035104: reorder class file attributes in javap listing
Reviewed-by: ksrini
2014-03-26 17:50:33 -07:00
Alexander Zuev
3eb793cd06 8035956: javac, incomplete error message
Reviewed-by: vromero
2014-03-26 10:47:30 -07:00
Joel Borggrén-Franck
24400e1745 8038080: annotation processors don't visit declaration parameter annotations
Co-authored-by: Liam Miller-Cushon <cushon@google.com>
Reviewed-by: darcy
2014-03-26 12:18:11 +01:00
Bhavesh Patel
da71a6dd96 8031625: javadoc problems referencing inner class constructors
Reviewed-by: jjg
2014-03-25 22:07:55 -07:00
Alexander Zuev
908ea8bebd 7118295: javac does not explicitly close -Xstdout file
Reviewed-by: ksrini, jjg
2014-03-20 15:13:26 +04:00
Paul Govereau
019025c61f 8025505: Constant folding deficiency
Provide constant folding of equality tests involving constant and null.

Reviewed-by: jjg
2014-03-19 17:39:28 -04:00
Paul Govereau
e0bc15202b 6898851: Compiling against this corrupt class file causes a stacktrace from javac
Added check for index out-of-bounds erros in ClassReader

Reviewed-by: jjg
2014-03-19 11:34:27 -04:00
Paul Govereau
03c0b0a11e 8036007: javac crashes when encountering an unresolvable interface
Reviewed-by: vromero, jlahoda
2014-03-18 22:12:46 +00:00
Eric McCorkle
53e3990b7c 8037420: Silent failures in Annotate.actualEnterTypeAnnotations
Remove two silent failures

Reviewed-by: jjg
2014-03-14 15:35:13 -04:00
Vicente Romero
2564e82ad1 8034924: Incorrect inheritance of inaccessible static method
Reviewed-by: jjg, jlahoda
2014-03-13 20:13:43 +00:00
Vicente Romero
73e0ab9b7f 8034127: javac provide debug oriented toString() methods to InferenceContext and UndetVar
Reviewed-by: jjg
2014-03-13 17:36:51 +00:00
Joe Darcy
07cc98bb1a 8037120: Fix doclint warnings in javax.lang.model exception types
Reviewed-by: jjg
2014-03-11 17:52:45 -07:00
Jan Lahoda
16962804f3 8034854: outer_class_info_index of synthetic class is not zero
Auxiliary synthetic anonymous classes should not have an outer class specified in the InnerClasses attribute.

Reviewed-by: vromero, jjg, abuckley
2014-03-07 13:35:56 +01:00
Paul Govereau
af27057b26 8034091: There is no records in LineNumberTable attribute for ternary operator ?: splitted to several lines
Reviewed-by: jjg
2014-03-06 13:50:12 -05:00
Neil Toda
735e586b5f 8035878: javadoc tool documentation should be using {@code ..} specifier
Reviewed-by: jjg
2014-03-03 15:24:31 -08:00
Neil Toda
72641e4e7f 8035877: javadoc classes are missing @return and @param tags
Reviewed-by: jjg
2014-03-03 15:10:01 -08:00
Neil Toda
1f9569d235 8035875: remove deprecated html <font> tags from javadoc package-info.java file
Reviewed-by: jjg
2014-03-03 15:03:17 -08:00
Eric McCorkle
6b9060ac8f 8036142: Remove redundant call to annotateTypeLater with null Symbol
AnnotateTypeLater (formerly typeAnnotate) with null as the symbol was a way to force attribution of type annotations, but this is now obsolete and problematic, and a silent noop condition

Reviewed-by: jjg
2014-03-03 16:17:32 -05:00
Jan Lahoda
74250736aa 8031383: Error recovery in JavacParser could be improved
Improving error recovery in JavacParser by avoiding artificial nextToken in JavacParser.reportSyntaxError.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg, jfranck
2014-02-28 20:25:24 +01:00
Vicente Romero
c5ab176b3e 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
Reviewed-by: jjg
2014-02-28 18:27:14 +00:00
Per Bothner
25c2444601 8033287: Reduce the size of the endPosTable
Co-authored-by: Charlie Turner <chturne@gmail.com>
Reviewed-by: jjg
2014-02-27 13:57:57 -08:00
Eric McCorkle
816bfaa7bc 8035766: Execute TypeAnnotate visitor at queue flush time
Moved execution of TypeAnnotate visitor into Worker for type annotations

Reviewed-by: jjg
2014-02-27 00:29:22 -05:00
Paul Govereau
dd0e29f8b7 6533516: Warning needed for file with future time stamps
Reviewed-by: jjg, vromero
2014-02-26 18:05:02 -08:00
Paul Govereau
f6250d7784 8034048: javac crash with method references plus lambda plus var args
Reviewed-by: jjg, vromero
2014-02-26 15:38:55 -08:00
Eric McCorkle
38cc470411 8035758: Move annotation codepaths from MemberEnter.java to Annotate.java
Cosmetic code cleanup patch, moving code to the file where it ought to reside.

Reviewed-by: vromero
2014-02-25 14:06:48 -05:00
Vicente Romero
c7af5cd60b 8034143: javac, subclasses of Infer.IncorporationStep should implement the accepts() method
Reviewed-by: jjg
2014-02-22 17:42:10 +00:00
Yuri Nesterenko
98b44a020b 6457406: javadoc doesn't handle <a href='http://...'> properly in producing index pages
Reviewed-by: jjg, bpatel, ksrini
2014-02-21 15:14:09 +04:00
Jan Lahoda
facc03d9f4 6411385: Trees.getPath does not work for constructors
Enhancing TestTrees test to ensure proper function of Trees.getPath/getTree, fixing cases where getTree did not work properly.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-02-21 10:35:19 +01:00
Jonathan Gibbons
31ca5c712a 8035364: An extra space in the comments of constant pool entries
Reviewed-by: ksrini
2014-02-19 15:05:19 -08:00
Kumar Srinivasan
f643b8cab0 8031545: [javac] refactor and cleanup JNIWriter.java
Reviewed-by: jjg
2014-02-15 16:37:19 -08:00
Kumar Srinivasan
c7480b6513 8029145: javadoc fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-02-14 17:28:07 -08:00
Andreas Lundblad
8daec20c86 8030714: The steps attribute, flow and desugar are unnecessary for implicit classes when compiling with -implicit:none
When compiling with -implicit:none, attribute, flow and desugar is skipped for better performance.

Reviewed-by: jfranck, jlahoda
2014-02-13 14:58:10 +01:00
Jan Lahoda
e20546fe2a 8033961: Formatting of -Xlint: command line help
Improving formatting of command line help for -Xlint, including a short description of each lint.

Reviewed-by: jjg
2014-02-13 13:38:48 +01:00
Dan Smith
55801d06ff 4910483: Javadoc renders the string ".*\\.pdf" as ".\*\.pdf"
Adjust timing of printing "\\" in the comment scanner

Reviewed-by: jjg
2014-02-12 12:31:30 -07:00
Jonathan Gibbons
4e86ae9988 8033930: Unnecessary new line after the StackMapTable
8033913: Incorrect indentation of StackMapTable entries

Reviewed-by: ksrini
2014-02-10 11:52:52 -08:00
Jan Lahoda
c0d767f6f1 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
When the overrides deprecated method warning is being reported, need to do that in the lint context of the method.

Reviewed-by: vromero
2014-02-07 21:43:33 +01:00
Jonathan Gibbons
29f985089a 8033581: Incorrect comment aligment
8033798: javap output has unnecessary trailing whitespace
8033726: StackMapTable does not unindent properly

Reviewed-by: ksrini
2014-02-06 18:54:13 -08:00
Christine Lu
67d15f03e0 8032526: fix the accessibility, html, syntax errors and warnings reported by doclint report in langtools
Reviewed-by: jjg
2014-02-06 16:39:19 -08:00