71 Commits

Author SHA1 Message Date
Kelly O'Hair
fd65dbfc50 6982137: Rebranding pass 2 - missed copyright changes
Reviewed-by: mbykov
2010-09-09 16:29:40 -07:00
Maurizio Cimadamore
634d001c64 6977800: Regression: invalid resolution of supertype for local class
Resolution of superclass/superinterfaces in extends/implements clause skips local classes

Reviewed-by: jjg
2010-08-19 11:54:25 +01:00
Maurizio Cimadamore
71962ebfb0 6886247: regression: javac crashes with an assertion error in Attr.java
Capture conversion does not work on nested types

Reviewed-by: jjg
2010-08-19 11:50:50 +01:00
Maurizio Cimadamore
2801325742 6369605: Unconstrained type variables fails to include bounds
Unconstrained type-variables with recursive bounds are not inferred properly

Reviewed-by: jjg
2010-08-16 14:58:10 +01:00
Maurizio Cimadamore
541f7a7a41 6938454: Unable to determine generic type in program that compiles under Java 6
A redundant dubtyping check causes spurious inference failure

Reviewed-by: jjg
2010-07-29 15:56:25 +01:00
Jonathan Gibbons
ccd014ed3f 6971882: Remove -XDstdout from javac test
Reviewed-by: darcy
2010-07-26 14:18:45 -07:00
Jonathan Gibbons
29ceaebc37 6968497: localized text appears in raw diagnostic
Reviewed-by: darcy
2010-07-12 16:37:46 -07:00
Jonathan Gibbons
0dd9ef9b43 6944312: Potential rebranding issues in openjdk/langtools repository sources
Reviewed-by: darcy
2010-06-10 16:08:01 -07:00
Lana Steuck
2592bab72c Merge 2010-05-28 12:41:48 -07:00
Kelly O'Hair
bd4f4be9d7 6943119: Rebrand source copyright notices
Reviewed-by: darcy
2010-05-25 15:54:51 -07:00
Maurizio Cimadamore
836fb6fe52 6951833: latest diamond implementation generates spurious raw type warnings
Raw warning checks should be disabled in the presence of a diamond AST node

Reviewed-by: jjg
2010-05-19 16:43:30 +01:00
Maurizio Cimadamore
cd66a7b462 6946618: sqe test fails: javac/generics/NewOnTypeParm in pit jdk7 b91 in all platforms
Bad cast to ClassType in the new diamond implementation fails if the target type of the instance creation expression is a type-variable

Reviewed-by: jjg
2010-05-19 16:42:37 +01:00
Maurizio Cimadamore
1bc9b6324e 6880344: Recursive type parameters do not compile
Issue in type-variable substitution causes valid code to be rejected

Reviewed-by: jjg
2010-05-19 16:41:57 +01:00
Maurizio Cimadamore
d3fa7f79ad 6939620: Switch to 'complex' diamond inference scheme
Implement new inference scheme for diamond operator that takes into account type of actual arguments supplied to constructor

Reviewed-by: jjg, darcy
2010-04-14 12:31:55 +01:00
Maurizio Cimadamore
965595d38b 6939618: Revert 'simple' diamond implementation
Backout changeset for 6840638

Reviewed-by: jjg
2010-04-14 12:23:29 +01:00
Jonathan Gibbons
2ed0d63583 6933914: fix missing newlines
Reviewed-by: ohair
2010-03-10 16:23:18 -08:00
Jonathan Gibbons
953e026858 6931126: jtreg tests not Windows friendly
Reviewed-by: darcy
2010-03-03 19:34:34 -08:00
Jonathan Gibbons
87efbd8787 6931127: strange test class files
Reviewed-by: darcy
2010-03-02 16:43:29 -08:00
Jonathan Gibbons
305d4bc5fc 6919889: assorted position errors in compiler syntax trees
Reviewed-by: darcy
2010-01-29 16:06:51 -08:00
Xiomara Jayasena
dbe66b7524 6884624: Update copyright year
Update copyright for files that have been modified in 2009 through Septermber

Reviewed-by: tbell, ohair
2009-09-22 14:06:29 -07:00
Maurizio Cimadamore
1de40db76d 6650759: Inference of formal type parameter (unused in formal parameters) is not performed
Propagate inference constraints from 15.12.2.7 to 15.12.2.8

Reviewed-by: jjg
2009-09-01 14:53:39 +01:00
Jonathan Gibbons
af2f2e8d36 6875336: some tests should use /nodynamiccopyright/
Reviewed-by: darcy
2009-08-27 11:08:27 -07:00
Maurizio Cimadamore
e5ce4a752b 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
Diamond operator implementation (simple approach)

Reviewed-by: jjg
2009-08-27 13:40:48 +01:00
Maurizio Cimadamore
d8292cad05 6569404: Cannot instantiate an inner class of a type variable
Javac is too strict in rejecting member selction from a type-var

Reviewed-by: jjg
2009-08-11 01:14:06 +01:00
Maurizio Cimadamore
b097f12a5d 6869075: regression: javac crashes when compiling compound string assignment with generics
Javac should not add syntehtic cast to the LHS of an assignment expression

Reviewed-by: jjg
2009-08-11 01:13:42 +01:00
Maurizio Cimadamore
dd76763423 6846972: cannot access member of raw type when erasure change overriding into overloading
Fix of 6400189 caused a nasty problem in method resolution

Reviewed-by: jjg
2009-07-15 10:25:01 +01:00
Maurizio Cimadamore
3b51e6ae0d 6638712: Inference with wildcard types causes selection of inapplicable method
Added global sanity check in order to make sure that return type inference does not violate bounds constraints

Reviewed-by: jjg
2009-06-16 10:46:37 +01:00
Maurizio Cimadamore
fda3d758e3 6835428: regression: return-type inference rejects valid code
Redundant subtyping test during type-inference ends up in rejecting legal code

Reviewed-by: jjg
2009-06-16 10:46:16 +01:00
Jonathan Gibbons
6fb18b568c 6802102: unignore @ignored tests where possible
Reviewed-by: mcimadamore
2009-05-28 09:49:56 -07:00
Joe Darcy
05ea258bbb 6843761: Update langtools tests to remove unncessary -source and -target options
Reviewed-by: jjg
2009-05-27 22:34:43 -07:00
Maurizio Cimadamore
8321605121 6182950: methods clash algorithm should not depend on return type
Fixed code that checks for duplicate method declarations

Reviewed-by: jjg
2009-03-25 10:28:36 +00:00
Tim Bell
e005d5df51 Merge 2009-03-09 23:53:41 -07:00
Xiomara Jayasena
56fcf6c052 6814575: Update copyright year
Update copyright for files that have been modified in 2009, up to 03/09

Reviewed-by: katleman, tbell, ohair
2009-03-09 13:29:06 -07:00
Maurizio Cimadamore
5ff31e060f 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
Fixed algorithm for checking cycles in typevar declarations

Reviewed-by: jjg
2009-03-05 17:24:40 +00:00
Maurizio Cimadamore
198f2427b4 6769027: Source line should be displayed immediately after the first diagnostic line
Added support for customizing diagnostic output via API/command line flags

Reviewed-by: jjg
2009-02-13 11:57:33 +00:00
Maurizio Cimadamore
4021098c46 6729401: Compiler error when using F-bounded generics with free type variables
Javac applies wrong substitution to recursive type-variable bounds

Reviewed-by: jjg
2009-01-29 12:19:14 +00:00
Maurizio Cimadamore
552a7a0e19 6315770: javac inference allows creation of strange types: Integer & Runnable
Javac does not apply glb correctly as per JLS3 15.12.2.8

Reviewed-by: jjg
2009-01-29 12:17:57 +00:00
Tim Bell
1b49bea0ad 6797871: Fix for 6797463 did not remove the jtreg tests, and it should have
Reviewed-by: jjg
2009-01-26 15:14:46 -08:00
Maurizio Cimadamore
19b769a375 6557199: Fails to reject bad override of generic method
Javac does not correctly implement JLS3 8.4.5

Reviewed-by: jjg
2009-01-20 17:49:49 +00:00
Mark Mahieu
9dff8d691f 6723444: javac fails to substitute type variables into a constructor's throws clause
Added constructor's actual type info to NewClass AST node

Reviewed-by: jjg
2009-01-13 13:28:42 +00:00
Maurizio Cimadamore
f6cd370370 6665356: Cast not allowed when both qualifying type and inner class are parameterized
Fixed parser and cats conversion in order to allow cast between generic inner classes

Reviewed-by: jjg
2009-01-13 13:28:20 +00:00
Maurizio Cimadamore
71eb016652 6776289: Regression: javac7 doesnt resolve method calls properly
Superclass' private methods shouldn't be considered during method resolution

Reviewed-by: jjg
2008-11-26 11:07:07 +00:00
Maurizio Cimadamore
a21aaaa7dc 6762569: Javac crashes with AssertionError in Types.containedBy
Types.containedBy should be more liberal with UndetVars

Reviewed-by: jjg
2008-10-24 12:46:51 +01:00
Maurizio Cimadamore
418461fae2 6758789: Some method resolution diagnostic should be improved
Recent work on diagnostics left out some resolution corner cases

Reviewed-by: jjg
2008-10-24 12:46:34 +01:00
Maurizio Cimadamore
3a7c0b423c 6680106: StackOverFlowError for Cyclic inheritance in TypeParameters with ArrayType Bounds
Javac ends up in an infinite loop while attributing mutually referring array type-parameter bounds

Reviewed-by: jjg
2008-10-24 12:45:47 +01:00
Maurizio Cimadamore
5a17e28602 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
Validator.visitTypeApply should substitute all formal typevars with actual parameters

Reviewed-by: jjg
2008-10-23 18:29:11 +01:00
Maurizio Cimadamore
b2ffad7180 6487370: javac incorrectly gives ambiguity warning with override-equivalent abstract inherited methods
Javac should not compare erased return types when checking for ambiguity errors during overload resolution

Reviewed-by: jjg
2008-10-23 18:00:05 +01:00
Maurizio Cimadamore
90e6379916 6711619: javac doesn't allow access to protected members in intersection types
Accordingly to new accessibility rules all members of intersection types (but private ones) should be accessible

Reviewed-by: jjg
2008-10-23 17:59:43 +01:00
Maurizio Cimadamore
be7b82ffe4 6732484: Bound error on wildcard code
Check.checkExtends should cope with captured type-variables

Reviewed-by: jjg
2008-10-23 17:59:16 +01:00
Maurizio Cimadamore
9315b88d67 6751514: Unary post-increment with type variables crash javac during lowering
Lower.abstractRval should take into account parenthesized expressions

Reviewed-by: jjg
2008-10-09 15:56:20 +01:00