jdk-24/test/hotspot/gtest/utilities/test_align.cpp
Casper Norrbin 494806286f 8318127: align_up has potential overflow
Reviewed-by: kbarrett, dlong
2024-11-27 12:27:31 +00:00

229 lines
7.9 KiB
C++

/*
* Copyright (c) 2017, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
#include "precompiled.hpp"
#include "utilities/align.hpp"
#include "utilities/checkedCast.hpp"
#include "utilities/formatBuffer.hpp"
#include "utilities/globalDefinitions.hpp"
#include "unittest.hpp"
#include <limits>
// A few arbitrarily chosen values to test the align functions on.
static constexpr uint64_t values[] = {1, 3, 10, 345, 1023, 1024, 1025, 23909034, INT_MAX, uint64_t(-1) / 2, uint64_t(-1) / 2 + 100, ~(uint64_t(1) << 62)};
template <typename T>
static constexpr T max_alignment() {
T max = std::numeric_limits<T>::max();
return max ^ (max >> 1);
}
#define log(...) SCOPED_TRACE(err_msg(__VA_ARGS__).buffer())
struct StaticTestAlignmentsResult {
uint64_t _value;
uint64_t _alignment;
int _status; // 0: success, > 0 indicates which failure case
constexpr StaticTestAlignmentsResult(uint64_t value, uint64_t alignment, int status) :
_value(value), _alignment(alignment), _status(status) {}
};
// Structure copied from test_alignments runtime test (below).
template<typename T, typename A>
static constexpr StaticTestAlignmentsResult
static_test_alignments_aux(A alignment) {
using Result = StaticTestAlignmentsResult;
for ( ; alignment > 0; alignment >>= 1) {
for (size_t i = 0; i < ARRAY_SIZE(values); ++i) {
// Test align up
uint64_t up = align_up(values[i], alignment);
if (0 < up && up < uint64_t(std::numeric_limits<T>::max())) {
T value = T(values[i]);
if (align_up(uint64_t(value), alignment) != up) {
return Result(values[i], alignment, 1);
} else if (align_up(value, alignment) < value) {
return Result(values[i], alignment, 2);
}
}
// Test align down
uint64_t down = align_down(values[i], alignment);
if (down <= uint64_t(std::numeric_limits<T>::max())) {
T value = T(values[i]);
if (uint64_t(align_down(value, alignment)) != down) {
return Result(values[i], alignment, 3);
} else if (align_down(value, alignment) > value) {
return Result(values[i], alignment, 4);
}
}
// Test is aligned
bool is = is_aligned(values[i], alignment);
if (values[i] <= uint64_t(std::numeric_limits<T>::max())) {
T value = T(values[i]);
if (is_aligned(value, alignment) != is) {
return Result(values[i], alignment, 5);
}
}
}
}
return Result(T(), A(), 0);
}
template<typename T, typename A>
static void static_test_alignments() {
constexpr StaticTestAlignmentsResult result
= static_test_alignments_aux<T>(max_alignment<A>());
EXPECT_EQ(0, result._status)
<< "value = " << result._value
<< ", alignment = " << result._alignment
<< ", status = " << result._status;
}
template <typename T, typename A>
static void test_alignments() {
log("### Test: %c" SIZE_FORMAT " " UINT64_FORMAT " : %c" SIZE_FORMAT " " UINT64_FORMAT " ###\n",
std::numeric_limits<T>::is_signed ? 's' : 'u', sizeof(T), (uint64_t)std::numeric_limits<T>::max(),
std::numeric_limits<A>::is_signed ? 's' : 'u', sizeof(A), (uint64_t)std::numeric_limits<A>::max());
// Test all possible alignment values that fit in type A.
for (A alignment = max_alignment<A>(); alignment > 0; alignment >>= 1) {
log("=== Alignment: " UINT64_FORMAT " ===\n", (uint64_t)alignment);
for (size_t i = 0; i < ARRAY_SIZE(values); i++) {
log("--- Value: " UINT64_FORMAT "\n", values[i]);
// Test align up
const uint64_t up = align_up(values[i], alignment);
if (0 < up && up <= (uint64_t)std::numeric_limits<T>::max()) {
log("Testing align_up: alignment: " UINT64_FORMAT_X " value: " UINT64_FORMAT_X " expected: " UINT64_FORMAT_X "\n", (uint64_t)alignment, values[i], up);
T value = T(values[i]);
// Check against uint64_t version
ASSERT_EQ(align_up((uint64_t)value, alignment), up);
// Sanity check
ASSERT_GE(align_up(value, alignment), value);
}
// Test align down
const uint64_t down = align_down(values[i], alignment);
if (down <= (uint64_t)std::numeric_limits<T>::max()) {
log("Testing align_down: alignment: " UINT64_FORMAT_X " value: " UINT64_FORMAT_X " expected: " UINT64_FORMAT_X "\n", (uint64_t)alignment, values[i], down);
T value = T(values[i]);
// Check against uint64_t version
ASSERT_EQ((uint64_t)align_down(value, alignment), down);
// Sanity check
ASSERT_LE(align_down(value, alignment), value);
}
// Test is aligned
const bool is = is_aligned(values[i], alignment);
if (values[i] <= (uint64_t)std::numeric_limits<T>::max()) {
log("Testing is_aligned: alignment: " UINT64_FORMAT_X " value: " UINT64_FORMAT_X " expected: %s\n", (uint64_t)alignment, values[i], is ? "true" : "false");
T value = T(values[i]);
// Check against uint64_t version
ASSERT_EQ(is_aligned(value, alignment), is);
}
}
}
static_test_alignments<T, A>();
}
TEST(Align, alignments) {
// Test the alignment functions with different type combinations.
test_alignments<int64_t, uint8_t>();
test_alignments<int64_t, uint16_t>();
test_alignments<int64_t, uint32_t>();
test_alignments<int64_t, int8_t>();
test_alignments<int64_t, int16_t>();
test_alignments<int64_t, int32_t>();
test_alignments<int64_t, int64_t>();
test_alignments<uint32_t, uint8_t>();
test_alignments<uint32_t, uint16_t>();
test_alignments<uint32_t, uint32_t>();
test_alignments<uint32_t, int8_t>();
test_alignments<uint32_t, int16_t>();
test_alignments<uint32_t, int32_t>();
test_alignments<int32_t, uint8_t>();
test_alignments<int32_t, uint16_t>();
test_alignments<int32_t, int8_t>();
test_alignments<int32_t, int16_t>();
test_alignments<int32_t, int32_t>();
test_alignments<uint16_t, uint8_t>();
test_alignments<uint16_t, uint16_t>();
test_alignments<uint16_t, int8_t>();
test_alignments<uint16_t, int16_t>();
test_alignments<int16_t, uint8_t>();
test_alignments<int16_t, int8_t>();
test_alignments<int16_t, int16_t>();
test_alignments<uint8_t, int8_t>();
test_alignments<uint8_t, uint8_t>();
test_alignments<int8_t, int8_t>();
}
#ifdef ASSERT
template <typename T, typename A>
static void test_fail_alignment() {
A alignment = max_alignment<A>();
T value = align_down(std::numeric_limits<T>::max(), alignment) + 1;
// Aligning up would overflow, as there is not enough room for alignment
T aligned = align_up(value, alignment);
}
TEST_VM_ASSERT(Align, fail_alignments_same_size) {
test_fail_alignment<uint64_t, uint64_t>();
}
TEST_VM_ASSERT(Align, fail_alignments_unsigned_signed) {
test_fail_alignment<uint32_t, int32_t>();
}
TEST_VM_ASSERT(Align, fail_alignments_signed_unsigned) {
test_fail_alignment<int64_t, int32_t>();
}
TEST_VM_ASSERT(Align, fail_alignments_small_large) {
test_fail_alignment<uint8_t, uint64_t>();
}
TEST_VM_ASSERT(Align, fail_alignments_large_small) {
test_fail_alignment<uint64_t, uint8_t>();
}
#endif // ASSERT