jdk-24/jdk/test/java/util/logging/ParentLoggersTest.java
Daniel Fuchs 33dbc2d51c 8023168: Cleanup LogManager class initialization and LogManager/LoggerContext relationship
8021003: java/util/logging/Logger/getGlobal/TestGetGlobalConcurrent.java fails intermittently
8019945: test/java/util/logging/LogManagerInstanceTest.java failing intermittently

This fix untangles the class initialization of Logger and LogManager, and also cleans up the relationship between LogManager, LoggerContext, and Logger, which were at the root cause of some intermittent test failures.

Reviewed-by: mchung, martin, plevart
2013-09-09 13:59:51 +02:00

189 lines
7.0 KiB
Java

/*
* Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 6498300
*
* @summary regression: parent loggers are not properly registered
* @author ss45998
*
* @build ParentLoggersTest
* @run main ParentLoggersTest
*/
/*
* There are several original tests which were failed when
* this regression was introduced. This is an extra test
* to ensure that the parent loggers with the defined
* .level property are implicitly registered.
*/
import java.util.*;
import java.io.*;
import java.util.logging.*;
public class ParentLoggersTest {
static final LogManager logMgr = LogManager.getLogManager();
static final PrintStream out = System.out;
static final boolean PASSED = true;
static final boolean FAILED = false;
static final String MSG_PASSED = "ParentLoggersTest: passed";
static final String MSG_FAILED = "ParentLoggersTest: failed";
/* Properties */
static final String TST_SRC_PROP = "test.src";
static final String CFG_FILE_PROP = "java.util.logging.config.file";
static final String LM_PROP_FNAME = "ParentLoggersTest.props";
/* Logger names */
static final String PARENT_NAME_1 = "myParentLogger";
static final String PARENT_NAME_2 = "abc.xyz.foo";
static final String LOGGER_NAME_1 = PARENT_NAME_1 + ".myLogger";
static final String LOGGER_NAME_2 = PARENT_NAME_2 + ".myBar.myLogger";
static final List<String> initialLoggerNames = new ArrayList<String>();
public static void main(String args[]) throws Exception {
// cache the initial set of loggers before this test begins
// to add any loggers
Enumeration<String> e = logMgr.getLoggerNames();
List<String> defaultLoggers = getDefaultLoggerNames();
while (e.hasMoreElements()) {
String logger = e.nextElement();
if (!defaultLoggers.contains(logger)) {
initialLoggerNames.add(logger);
}
};
String tstSrc = System.getProperty(TST_SRC_PROP);
File fname = new File(tstSrc, LM_PROP_FNAME);
String prop = fname.getCanonicalPath();
System.setProperty(CFG_FILE_PROP, prop);
logMgr.readConfiguration();
System.out.println();
if (checkLoggers() == PASSED) {
System.out.println(MSG_PASSED);
} else {
System.out.println(MSG_FAILED);
throw new Exception(MSG_FAILED);
}
}
public static List<String> getDefaultLoggerNames() {
List<String> expectedLoggerNames = new ArrayList<String>();
// LogManager always creates two loggers:
expectedLoggerNames.add(""); // root logger: ""
expectedLoggerNames.add("global"); // global logger: "global"
return expectedLoggerNames;
}
/* Check: getLoggerNames() must return correct names
* for registered loggers and their parents.
* Returns boolean values: PASSED or FAILED
*/
public static boolean checkLoggers() {
String failMsg = "# checkLoggers: getLoggerNames() returned unexpected loggers";
Vector<String> expectedLoggerNames = new Vector<String>(getDefaultLoggerNames());
// Create the logger LOGGER_NAME_1
Logger.getLogger(LOGGER_NAME_1);
expectedLoggerNames.addElement(PARENT_NAME_1);
expectedLoggerNames.addElement(LOGGER_NAME_1);
// Create the logger LOGGER_NAME_2
Logger.getLogger(LOGGER_NAME_2);
expectedLoggerNames.addElement(PARENT_NAME_2);
expectedLoggerNames.addElement(LOGGER_NAME_2);
Enumeration<String> returnedLoggersEnum = logMgr.getLoggerNames();
Vector<String> returnedLoggerNames = new Vector<String>(0);
while (returnedLoggersEnum.hasMoreElements()) {
String logger = returnedLoggersEnum.nextElement();
if (!initialLoggerNames.contains(logger)) {
// filter out the loggers that have been added before this test runs
returnedLoggerNames.addElement(logger);
}
};
return checkNames(expectedLoggerNames, returnedLoggerNames, failMsg);
}
// Returns boolean values: PASSED or FAILED
private static boolean checkNames(Vector<String> expNames,
Vector<String> retNames,
String failMsg) {
boolean status = PASSED;
if (expNames.size() != retNames.size()) {
status = FAILED;
} else {
boolean checked[] = new boolean[retNames.size()];
for (int i = 0; i < expNames.size(); i++) {
int j = 0;
for (; j < retNames.size(); j++) {
if (!checked[j] &&
expNames.elementAt(i).equals(retNames.elementAt(j))) {
checked[j] = true;
break;
}
}
if (j >= retNames.size()) {
status = FAILED;
break;
}
}
}
if (!status) {
printFailMsg(expNames, retNames, failMsg);
}
return status;
}
private static void printFailMsg(Vector<String> expNames,
Vector<String> retNames,
String failMsg) {
out.println();
out.println(failMsg);
if (expNames.size() == 0) {
out.println("# there are NO expected logger names");
} else {
out.println("# expected logger names (" + expNames.size() + "):");
for (int i = 0; i < expNames.size(); i++) {
out.println(" expNames[" + i + "] = " + expNames.elementAt(i));
}
}
if (retNames.size() == 0) {
out.println("# there are NO returned logger names");
} else {
out.println("# returned logger names (" + retNames.size() + "):");
for (int i = 0; i < retNames.size(); i++) {
out.println(" retNames[" + i + "] = " + retNames.elementAt(i));
}
}
}
}