db85090553
Co-authored-by: Sean Mullan <mullan@openjdk.org> Co-authored-by: Alan Bateman <alanb@openjdk.org> Co-authored-by: Weijun Wang <weijun@openjdk.org> Co-authored-by: Aleksei Efimov <aefimov@openjdk.org> Co-authored-by: Brian Burkhalter <bpb@openjdk.org> Co-authored-by: Daniel Fuchs <dfuchs@openjdk.org> Co-authored-by: Harshitha Onkar <honkar@openjdk.org> Co-authored-by: Joe Wang <joehw@openjdk.org> Co-authored-by: Jorn Vernee <jvernee@openjdk.org> Co-authored-by: Justin Lu <jlu@openjdk.org> Co-authored-by: Kevin Walls <kevinw@openjdk.org> Co-authored-by: Lance Andersen <lancea@openjdk.org> Co-authored-by: Naoto Sato <naoto@openjdk.org> Co-authored-by: Roger Riggs <rriggs@openjdk.org> Co-authored-by: Brent Christian <bchristi@openjdk.org> Co-authored-by: Stuart Marks <smarks@openjdk.org> Co-authored-by: Ian Graves <igraves@openjdk.org> Co-authored-by: Phil Race <prr@openjdk.org> Co-authored-by: Erik Gahlin <egahlin@openjdk.org> Co-authored-by: Jaikiran Pai <jpai@openjdk.org> Reviewed-by: kevinw, aivanov, rriggs, lancea, coffeys, dfuchs, ihse, erikj, cjplummer, coleenp, naoto, mchung, prr, weijun, joehw, azvegint, psadhukhan, bchristi, sundar, attila
289 lines
12 KiB
Java
289 lines
12 KiB
Java
/*
|
|
* Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
|
|
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
|
*
|
|
* This code is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 only, as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This code is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* version 2 for more details (a copy is included in the LICENSE file that
|
|
* accompanied this code).
|
|
*
|
|
* You should have received a copy of the GNU General Public License version
|
|
* 2 along with this work; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*
|
|
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
|
* or visit www.oracle.com if you need additional information or have any
|
|
* questions.
|
|
*/
|
|
|
|
/*
|
|
* @test
|
|
* @summary Tests for FileServerHandler with SecurityManager
|
|
* @library /test/lib
|
|
* @build jdk.test.lib.net.URIBuilder
|
|
* @run main/othervm -ea RootDirPermissionsTest true
|
|
* @run main/othervm -ea RootDirPermissionsTest false
|
|
*/
|
|
|
|
import java.io.IOException;
|
|
import java.net.InetAddress;
|
|
import java.net.InetSocketAddress;
|
|
import java.net.URI;
|
|
import java.net.http.HttpClient;
|
|
import java.net.http.HttpRequest;
|
|
import java.net.http.HttpResponse.BodyHandlers;
|
|
import java.nio.file.Files;
|
|
import java.nio.file.Path;
|
|
import java.nio.file.attribute.AclEntry;
|
|
import java.nio.file.attribute.AclEntryPermission;
|
|
import java.nio.file.attribute.AclEntryType;
|
|
import java.nio.file.attribute.AclFileAttributeView;
|
|
import java.nio.file.attribute.PosixFilePermission;
|
|
import java.nio.file.attribute.UserPrincipal;
|
|
import java.time.ZoneId;
|
|
import java.time.format.DateTimeFormatter;
|
|
import java.util.ArrayList;
|
|
import java.util.HashSet;
|
|
import java.util.List;
|
|
import java.util.Set;
|
|
import java.util.logging.ConsoleHandler;
|
|
import java.util.logging.Level;
|
|
import java.util.logging.Logger;
|
|
import com.sun.net.httpserver.HttpServer;
|
|
import com.sun.net.httpserver.SimpleFileServer;
|
|
import com.sun.net.httpserver.SimpleFileServer.OutputLevel;
|
|
import jdk.test.lib.net.URIBuilder;
|
|
import jdk.test.lib.util.FileUtils;
|
|
import static java.net.http.HttpClient.Builder.NO_PROXY;
|
|
import static java.nio.charset.StandardCharsets.UTF_8;
|
|
import static java.nio.file.StandardOpenOption.CREATE;
|
|
|
|
/**
|
|
* Tests file permission checks during the creation of a FileServerHandler.
|
|
*
|
|
* A FileServerHandler can only be created if its root directory
|
|
* is readable. The test consists of 2 runs:
|
|
* 1) RootDir is readable
|
|
* 2) RootDir is NOT readable
|
|
* 2) reuses the test directory created in the previous run, revoking
|
|
* read access.
|
|
* */
|
|
public class RootDirPermissionsTest {
|
|
|
|
static final Path CWD = Path.of(".").toAbsolutePath().normalize();
|
|
static final Path TEST_DIR = CWD.resolve("RootDir");
|
|
static final InetSocketAddress LOOPBACK_ADDR =
|
|
new InetSocketAddress(InetAddress.getLoopbackAddress(), 0);
|
|
|
|
static final boolean ENABLE_LOGGING = true;
|
|
static final Logger LOGGER = Logger.getLogger("com.sun.net.httpserver");
|
|
|
|
static boolean readPermitted;
|
|
static String lastModifiedDir;
|
|
static String lastModifiedFile;
|
|
|
|
static Set<PosixFilePermission> posixPermissions;
|
|
static List<AclEntry> acls;
|
|
|
|
public static void main(String[] args) throws Exception {
|
|
setupLogging();
|
|
readPermitted = Boolean.parseBoolean(args[0]);
|
|
if (readPermitted) {
|
|
createTestDir();
|
|
testDirectoryGET();
|
|
testFileGET();
|
|
} else {
|
|
revokePermissions();
|
|
try {
|
|
testCreateHandler();
|
|
} finally {
|
|
restorePermissions();
|
|
}
|
|
}
|
|
}
|
|
|
|
private static void revokePermissions() throws IOException {
|
|
if (!Files.isReadable(TEST_DIR)) {
|
|
// good nothing to do:
|
|
System.out.println("File is already not readable: nothing to do");
|
|
return;
|
|
}
|
|
System.out.println("FileSystem: " + Files.getFileStore(TEST_DIR).type());
|
|
if (Files.getFileStore(TEST_DIR).supportsFileAttributeView("posix")) {
|
|
System.out.println("Revoking owner's read access in POSIX permissions for " + TEST_DIR);
|
|
posixPermissions = Files.getPosixFilePermissions(TEST_DIR);
|
|
Set<PosixFilePermission> newPerms = new HashSet<>(posixPermissions);
|
|
newPerms.remove(PosixFilePermission.OWNER_READ);
|
|
newPerms.remove(PosixFilePermission.OWNER_EXECUTE);
|
|
Files.setPosixFilePermissions(TEST_DIR, newPerms);
|
|
} else if (Files.getFileStore(TEST_DIR).supportsFileAttributeView("acl")) {
|
|
System.out.println("Revoking owner's read access in ACLs for " + TEST_DIR);
|
|
AclFileAttributeView view = Files.getFileAttributeView(TEST_DIR, AclFileAttributeView.class);
|
|
acls = view.getAcl();
|
|
List<AclEntry> entries = new ArrayList<>();
|
|
UserPrincipal owner = view.getOwner();
|
|
// Deny owner
|
|
entries.add(AclEntry.newBuilder().setType(AclEntryType.DENY)
|
|
.setPrincipal(owner).setPermissions(AclEntryPermission.READ_DATA,
|
|
AclEntryPermission.READ_ATTRIBUTES, AclEntryPermission.READ_NAMED_ATTRS,
|
|
AclEntryPermission.EXECUTE)
|
|
.build());
|
|
// Revoke read data and execute
|
|
for (AclEntry entry : acls) {
|
|
Set<AclEntryPermission> perms =
|
|
new HashSet<>(entry.permissions());
|
|
if (entry.type() == AclEntryType.ALLOW) {
|
|
System.out.println("Revoking read access: " + entry);
|
|
perms.remove(AclEntryPermission.READ_DATA);
|
|
perms.remove(AclEntryPermission.LIST_DIRECTORY);
|
|
perms.remove(AclEntryPermission.READ_ATTRIBUTES);
|
|
perms.remove(AclEntryPermission.READ_NAMED_ATTRS);
|
|
perms.remove(AclEntryPermission.EXECUTE);
|
|
entries.add(AclEntry.newBuilder(entry).setPermissions(perms).build());
|
|
}
|
|
}
|
|
view.setAcl(entries);
|
|
System.out.println("ACLs: " + view.getAcl());
|
|
try {
|
|
System.out.println("File is readable: " + Files.isReadable(TEST_DIR));
|
|
Thread.sleep(50);
|
|
} catch (InterruptedException x) {}
|
|
// The above does not always work, skip the test if we can't make TEST_DIR
|
|
// read-only.
|
|
if (Files.isReadable(TEST_DIR)) {
|
|
throw new jtreg.SkippedException("Can't make directory read-only");
|
|
}
|
|
} else {
|
|
throw new RuntimeException("Required attribute view not supported");
|
|
}
|
|
System.out.println("File is readable: " + Files.isReadable(TEST_DIR));
|
|
}
|
|
|
|
private static void restorePermissions() throws IOException {
|
|
if (Files.getFileStore(TEST_DIR).supportsFileAttributeView("posix")) {
|
|
if (posixPermissions != null) {
|
|
System.out.println("Restoring original POSIX permissions");
|
|
Files.setPosixFilePermissions(TEST_DIR, posixPermissions);
|
|
}
|
|
} else if (Files.getFileStore(TEST_DIR).supportsFileAttributeView("acl")) {
|
|
if (acls != null) {
|
|
System.out.println("Restoring original ACLs");
|
|
AclFileAttributeView view = Files.getFileAttributeView(TEST_DIR, AclFileAttributeView.class);
|
|
view.setAcl(acls);
|
|
}
|
|
} else {
|
|
throw new RuntimeException("Required attribute view not supported");
|
|
}
|
|
}
|
|
|
|
private static void setupLogging() {
|
|
if (ENABLE_LOGGING) {
|
|
ConsoleHandler ch = new ConsoleHandler();
|
|
LOGGER.setLevel(Level.ALL);
|
|
ch.setLevel(Level.ALL);
|
|
LOGGER.addHandler(ch);
|
|
}
|
|
}
|
|
|
|
private static void createTestDir() throws IOException {
|
|
if (Files.exists(TEST_DIR)) {
|
|
FileUtils.deleteFileTreeWithRetry(TEST_DIR);
|
|
}
|
|
Files.createDirectories(TEST_DIR);
|
|
var file = Files.writeString(TEST_DIR.resolve("aFile.txt"), "some text", CREATE);
|
|
lastModifiedDir = getLastModified(TEST_DIR);
|
|
lastModifiedFile = getLastModified(file);
|
|
}
|
|
|
|
private static void testDirectoryGET() throws Exception {
|
|
var expectedBody = openHTML + """
|
|
<h1>Directory listing for /</h1>
|
|
<ul>
|
|
<li><a href="aFile.txt">aFile.txt</a></li>
|
|
</ul>
|
|
""" + closeHTML;
|
|
var expectedLength = Integer.toString(expectedBody.getBytes(UTF_8).length);
|
|
var server = SimpleFileServer.createFileServer(LOOPBACK_ADDR, TEST_DIR, OutputLevel.VERBOSE);
|
|
|
|
server.start();
|
|
try {
|
|
var client = HttpClient.newBuilder().proxy(NO_PROXY).build();
|
|
var request = HttpRequest.newBuilder(uri(server, "")).build();
|
|
var response = client.send(request, BodyHandlers.ofString());
|
|
assert response.statusCode() == 200;
|
|
assert response.body().equals(expectedBody);
|
|
assert response.headers().firstValue("content-type").get().equals("text/html; charset=UTF-8");
|
|
assert response.headers().firstValue("content-length").get().equals(expectedLength);
|
|
assert response.headers().firstValue("last-modified").get().equals(lastModifiedDir);
|
|
} finally {
|
|
server.stop(0);
|
|
}
|
|
}
|
|
|
|
private static void testFileGET() throws Exception {
|
|
var expectedBody = "some text";
|
|
var expectedLength = Integer.toString(expectedBody.getBytes(UTF_8).length);
|
|
var server = SimpleFileServer.createFileServer(LOOPBACK_ADDR, TEST_DIR, OutputLevel.VERBOSE);
|
|
|
|
server.start();
|
|
try {
|
|
var client = HttpClient.newBuilder().proxy(NO_PROXY).build();
|
|
var request = HttpRequest.newBuilder(uri(server, "aFile.txt")).build();
|
|
var response = client.send(request, BodyHandlers.ofString());
|
|
assert response.statusCode() == 200;
|
|
assert response.body().equals("some text");
|
|
assert response.headers().firstValue("content-type").get().equals("text/plain");
|
|
assert response.headers().firstValue("content-length").get().equals(expectedLength);
|
|
assert response.headers().firstValue("last-modified").get().equals(lastModifiedFile);
|
|
} finally {
|
|
server.stop(0);
|
|
}
|
|
}
|
|
|
|
@SuppressWarnings("removal")
|
|
private static void testCreateHandler(){
|
|
try {
|
|
SimpleFileServer.createFileServer(LOOPBACK_ADDR, TEST_DIR, OutputLevel.NONE);
|
|
throw new RuntimeException("Handler creation expected to fail");
|
|
} catch (IllegalArgumentException expected) { }
|
|
|
|
try {
|
|
SimpleFileServer.createFileHandler(TEST_DIR);
|
|
throw new RuntimeException("Handler creation expected to fail");
|
|
} catch (IllegalArgumentException expected) { }
|
|
}
|
|
|
|
static final String openHTML = """
|
|
<!DOCTYPE html>
|
|
<html>
|
|
<head>
|
|
<meta charset="utf-8"/>
|
|
</head>
|
|
<body>
|
|
""";
|
|
|
|
static final String closeHTML = """
|
|
</body>
|
|
</html>
|
|
""";
|
|
|
|
static URI uri(HttpServer server, String path) {
|
|
return URIBuilder.newBuilder()
|
|
.host("localhost")
|
|
.port(server.getAddress().getPort())
|
|
.scheme("http")
|
|
.path("/" + path)
|
|
.buildUnchecked();
|
|
}
|
|
|
|
static String getLastModified(Path path) throws IOException {
|
|
return Files.getLastModifiedTime(path).toInstant().atZone(ZoneId.of("GMT"))
|
|
.format(DateTimeFormatter.RFC_1123_DATE_TIME);
|
|
}
|
|
}
|