Aleksei Voitylov e47803a84f 8266310: deadlock between System.loadLibrary and JNI FindClass loading another class
Reviewed-by: dholmes, plevart, chegar, mchung
2021-07-06 11:15:10 +00:00

161 lines
5.6 KiB
Java

/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2021, BELLSOFT. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* LoadLibraryUnload class calls ClassLoader.loadedLibrary from multiple threads
*/
/*
* @test
* @bug 8266310
* @summary Loads a native library from multiple class loaders and multiple
* threads. This creates a race for loading the library. The winner
* loads the library in two threads. All threads except two would fail
* with UnsatisfiedLinkError when the class being loaded is already
* loaded in a different class loader that won the race. The test
* checks that the loaded class is GC'ed, that means the class loader
* is GC'ed and the native library is unloaded.
* @library /test/lib
* @build LoadLibraryUnload p.Class1
* @run main/othervm/native -Xcheck:jni LoadLibraryUnload
*/
import jdk.test.lib.Asserts;
import jdk.test.lib.util.ForceGC;
import java.lang.*;
import java.lang.reflect.*;
import java.lang.ref.WeakReference;
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.List;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import p.Class1;
public class LoadLibraryUnload {
private static class TestLoader extends URLClassLoader {
public TestLoader() throws Exception {
super(new URL[] { Path.of(System.getProperty("test.classes")).toUri().toURL() });
}
@Override
public Class<?> loadClass(String name) throws ClassNotFoundException {
synchronized (getClassLoadingLock(name)) {
Class<?> clazz = findLoadedClass(name);
if (clazz == null) {
try {
clazz = findClass(name);
} catch (ClassNotFoundException ignore) {
}
if (clazz == null) {
clazz = super.loadClass(name);
}
}
return clazz;
}
}
}
private static class LoadLibraryFromClass implements Runnable {
Object object;
Method method;
public LoadLibraryFromClass(Class<?> fromClass) {
try {
this.object = fromClass.newInstance();
this.method = fromClass.getDeclaredMethod("loadLibrary");
} catch (ReflectiveOperationException roe) {
throw new RuntimeException(roe);
}
}
@Override
public void run() {
try {
method.invoke(object);
} catch (ReflectiveOperationException roe) {
throw new RuntimeException(roe);
}
}
}
public static void main(String[] args) throws Exception {
Class<?> clazz = null;
List<Thread> threads = new ArrayList<>();
for (int i = 0 ; i < 5 ; i++) {
// 5 loaders and 10 threads in total.
// winner loads the library in 2 threads
clazz = new TestLoader().loadClass("p.Class1");
threads.add(new Thread(new LoadLibraryFromClass(clazz)));
threads.add(new Thread(new LoadLibraryFromClass(clazz)));
}
final Set<Throwable> exceptions = ConcurrentHashMap.newKeySet();
threads.forEach( t -> {
t.setUncaughtExceptionHandler((th, ex) -> {
// collect the root cause of each failure
Throwable rootCause = ex;
while((ex = ex.getCause()) != null) {
rootCause = ex;
}
exceptions.add(rootCause);
});
t.start();
});
// wait for all threads to finish
for (Thread t : threads) {
t.join();
}
// expect all errors to be UnsatisfiedLinkError
boolean allAreUnsatisfiedLinkError = exceptions
.stream()
.map(e -> e instanceof UnsatisfiedLinkError)
.reduce(true, (i, a) -> i && a);
// expect exactly 8 errors
Asserts.assertTrue(exceptions.size() == 8,
"Expected to see 8 failing threads");
Asserts.assertTrue(allAreUnsatisfiedLinkError,
"All errors have to be UnsatisfiedLinkError");
WeakReference<Class<?>> wClass = new WeakReference<>(clazz);
// release strong refs
clazz = null;
threads = null;
exceptions.clear();
ForceGC gc = new ForceGC();
if (!gc.await(() -> wClass.refersTo(null))) {
throw new RuntimeException("Class1 hasn't been GC'ed");
}
}
}