stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation"

Browse Source 
8293564: serviceability/tmtools/jstat/GcTest01.java fails with "Error in the percent calculation"

Reviewed-by: sspitsyn, lmesnik, dcubed
This commit is contained in:
Kevin Walls 2022-09-17 09:55:51 +00:00
parent 01e7b88199
commit cfd44bb2cd
2 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/hotspot/jtreg/ProblemList-Xcomp.txt
View File

@ -37,5 +37,4 @@ serviceability/sa/TestJhsdbJstackMixed.java 8248675 linux-aarch64
serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java 8288430 generic-all serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java 8288430 generic-all
serviceability/tmtools/jstat/GcNewTest.java 8293218 linux-x64,macosx-x64
gc/cslocker/TestCSLocker.java 8293289 linux-x64,macosx-x64 gc/cslocker/TestCSLocker.java 8293289 linux-x64,macosx-x64

31
test/hotspot/jtreg/serviceability/tmtools/jstat/utils/GcProvoker.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -58,17 +58,34 @@ public class GcProvoker{
* This method provokes a GC * This method provokes a GC
*/ */
public void provokeGc() { public void provokeGc() {
float targetFraction = 0;
// Read sizes of eden and overall heap, to find eden size as a fraction of heap.
// Recognise if heap is changing size, and retry (heap is expected to initially shrink).
for (int i = 0; i < 3; i++) { for (int i = 0; i < 3; i++) {
// One retry is expected occasionally. More "should not happen":
if (i == 2) {
throw new RuntimeException("Cannot calculate targetFraction. Heap size not stable.");
}
long heapSize0 = Pools.getHeapCommittedSize();
long edenSize = Pools.getEdenCommittedSize(); long edenSize = Pools.getEdenCommittedSize();
long heapSize = Pools.getHeapCommittedSize(); long heapSize = Pools.getHeapCommittedSize();
float targetPercent = ((float) edenSize) / (heapSize); if (heapSize < heapSize0) {
if ((targetPercent < 0) || (targetPercent > 1.0)) { System.out.println("provokeGc: Heap shrinking, retry. eden: " + edenSize + ", heap0: " + heapSize0 + ", heap: " + heapSize);
throw new RuntimeException("Error in the percent calculation" + " (eden size: " + edenSize + ", heap size: " + heapSize + ", calculated eden percent: " + targetPercent + ")"); System.gc();
continue;
} }
allocateHeap(targetPercent); targetFraction = ((float) edenSize) / (heapSize);
allocateHeap(targetPercent); if ((targetFraction < 0) || (targetFraction > 1.0)) {
System.gc(); throw new RuntimeException("Error in fraction calculation" + " (eden size: " + edenSize + ", heap size: " + heapSize
+ ", calculated eden fraction: " + targetFraction + ")");
}
break; // We have found eden as a fraction of heap.
} }
// Previously these allocations and GC call were in a loop.
// That appears unnecesary as the goal is simply to cause a GC:
allocateHeap(targetFraction);
allocateHeap(targetFraction);
System.gc();
} }
public GcProvoker() { public GcProvoker() {