Commit Graph

2631 Commits

Author SHA1 Message Date
Jan Lahoda
5905e8f494 8039466: Tests failing in langtools repository
Fixing tests broken by JDK-8038455.

Reviewed-by: jjg
2014-04-08 23:33:50 +02:00
Jan Lahoda
e5c8101894 8038455: Use single Context for all rounds of annotation processing
One set of javac services, as well as created ClassSymbols, is reused for all rounds of processing now.

Reviewed-by: jjg, jfranck, darcy, vromero
2014-04-08 14:06:11 +02:00
Paul Govereau
8e6660eb56 8023945: javac wrongly allows a subclass of an anonymous class
Reviewed-by: jjg
2014-04-04 19:13:53 -04:00
Kumar Srinivasan
73d4a30ede 8039231: [javadoc] test failure caused by javax.crypto fix
Reviewed-by: jjg
2014-04-04 18:36:16 -07:00
Kumar Srinivasan
def40f4158 8037881: javax.crypto is not listed in the compact* profiles javadoc
Reviewed-by: jjg
2014-04-03 12:04:58 -07:00
David Katleman
cf7bfef898 Added tag jdk9-b07 for changeset a70a71ac79f3 2014-04-02 22:00:13 -07:00
Bhavesh Patel
d642f92759 8032066: Serialized form has broken links to non private inner classes of package private
Reviewed-by: jjg
2014-04-01 23:58:04 -07:00
Paul Govereau
e231918e58 8034933: Update documentation for Types.directSupertypes to clarify behavior
Reviewed-by: darcy
2014-04-01 23:52:10 -07:00
Ivan Gerasimov
befb7157c9 8034044: Class.getModifiers() returns "static" for anonymous classes
Javac sets ACC_STATIC bit for anonymous classes which contradicts the JLS

Reviewed-by: jfranck
2014-04-02 10:05:16 +04:00
Lana Steuck
b683f35613 Merge 2014-04-01 17:25:39 -07:00
Alexander Zuev
d9d9742c75 8031425: Two langtools/javac tests fail by timeout on Windows
Reviewed-by: jjg, vromero
2014-04-01 10:00:43 -07:00
Jan Lahoda
e339370175 8035890: jdk8 javac -source 7 compiles test case it should not
Ensuring source level checks are performed in two additional cases related to type annotations, adding specialized error message for annotations after method type parameters.

Reviewed-by: jfranck, jjg
2014-03-31 21:27:25 +02:00
Bhavesh Patel
e08ccd0e48 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present
Reviewed-by: ksrini
2014-03-29 11:06:33 -07:00
Eric McCorkle
fb9c998b1d 8035768: Move TypeAnnotationPosition from Attribute.Compound to Attribute.TypeCompound
Move position field into Compound, making Compound into a kind of "proto-annotation", representing the situation before we know what an Annotation's kink is

Reviewed-by: jjg
2014-03-27 18:41:28 -04:00
David Katleman
4ba8c0364b Added tag jdk9-b06 for changeset 3d574309a737 2014-03-27 11:38:37 -07:00
Jonathan Gibbons
77ad0945a6 8035104: reorder class file attributes in javap listing
Reviewed-by: ksrini
2014-03-26 17:50:33 -07:00
Alexander Zuev
3eb793cd06 8035956: javac, incomplete error message
Reviewed-by: vromero
2014-03-26 10:47:30 -07:00
Joel Borggrén-Franck
24400e1745 8038080: annotation processors don't visit declaration parameter annotations
Co-authored-by: Liam Miller-Cushon <cushon@google.com>
Reviewed-by: darcy
2014-03-26 12:18:11 +01:00
Bhavesh Patel
da71a6dd96 8031625: javadoc problems referencing inner class constructors
Reviewed-by: jjg
2014-03-25 22:07:55 -07:00
Lana Steuck
3eb52d3931 Merge 2014-03-25 14:50:31 -07:00
Lana Steuck
0eb4fd78fa Merge 2014-03-25 12:32:12 -07:00
David Katleman
d705db594a Added tag jdk9-b05 for changeset a127d7bb1c30 2014-03-20 13:44:52 -07:00
Alexander Zuev
908ea8bebd 7118295: javac does not explicitly close -Xstdout file
Reviewed-by: ksrini, jjg
2014-03-20 15:13:26 +04:00
Paul Govereau
019025c61f 8025505: Constant folding deficiency
Provide constant folding of equality tests involving constant and null.

Reviewed-by: jjg
2014-03-19 17:39:28 -04:00
Paul Govereau
e0bc15202b 6898851: Compiling against this corrupt class file causes a stacktrace from javac
Added check for index out-of-bounds erros in ClassReader

Reviewed-by: jjg
2014-03-19 11:34:27 -04:00
Lana Steuck
9a44609844 Merge 2014-03-18 17:46:44 -07:00
Paul Govereau
03c0b0a11e 8036007: javac crashes when encountering an unresolvable interface
Reviewed-by: vromero, jlahoda
2014-03-18 22:12:46 +00:00
Dan Smith
d9e857f304 8034980: Fix @summary tag of test/tools/javac/parser/T4910483.java
Reviewed-by: vromero
2014-03-17 14:03:59 -06:00
Eric McCorkle
53e3990b7c 8037420: Silent failures in Annotate.actualEnterTypeAnnotations
Remove two silent failures

Reviewed-by: jjg
2014-03-14 15:35:13 -04:00
Vicente Romero
2564e82ad1 8034924: Incorrect inheritance of inaccessible static method
Reviewed-by: jjg, jlahoda
2014-03-13 20:13:43 +00:00
Vicente Romero
73e0ab9b7f 8034127: javac provide debug oriented toString() methods to InferenceContext and UndetVar
Reviewed-by: jjg
2014-03-13 17:36:51 +00:00
Joe Darcy
07cc98bb1a 8037120: Fix doclint warnings in javax.lang.model exception types
Reviewed-by: jjg
2014-03-11 17:52:45 -07:00
David Katleman
060f4862a7 Added tag jdk9-b04 for changeset 612191246a7d 2014-03-11 15:42:05 -07:00
Joe Darcy
e5fb7f77d6 8036842: Remove unneeded/obsolete -source/-target options in javac tests, part 2
Reviewed-by: jjg, sogoel
2014-03-07 13:30:23 -08:00
Jan Lahoda
16962804f3 8034854: outer_class_info_index of synthetic class is not zero
Auxiliary synthetic anonymous classes should not have an outer class specified in the InnerClasses attribute.

Reviewed-by: vromero, jjg, abuckley
2014-03-07 13:35:56 +01:00
Neil Toda
7aed9a60e0 8031670: Remove unneeded -source options in javadoc tests
Reviewed-by: jjg, darcy, vromero
2014-03-06 16:15:02 -08:00
Paul Govereau
af27057b26 8034091: There is no records in LineNumberTable attribute for ternary operator ?: splitted to several lines
Reviewed-by: jjg
2014-03-06 13:50:12 -05:00
Lana Steuck
b2b667ccfe Merge 2014-03-06 10:41:56 -08:00
Neil Toda
735e586b5f 8035878: javadoc tool documentation should be using {@code ..} specifier
Reviewed-by: jjg
2014-03-03 15:24:31 -08:00
Neil Toda
72641e4e7f 8035877: javadoc classes are missing @return and @param tags
Reviewed-by: jjg
2014-03-03 15:10:01 -08:00
Neil Toda
1f9569d235 8035875: remove deprecated html <font> tags from javadoc package-info.java file
Reviewed-by: jjg
2014-03-03 15:03:17 -08:00
Eric McCorkle
6b9060ac8f 8036142: Remove redundant call to annotateTypeLater with null Symbol
AnnotateTypeLater (formerly typeAnnotate) with null as the symbol was a way to force attribution of type annotations, but this is now obsolete and problematic, and a silent noop condition

Reviewed-by: jjg
2014-03-03 16:17:32 -05:00
Jan Lahoda
74250736aa 8031383: Error recovery in JavacParser could be improved
Improving error recovery in JavacParser by avoiding artificial nextToken in JavacParser.reportSyntaxError.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg, jfranck
2014-02-28 20:25:24 +01:00
Vicente Romero
c5ab176b3e 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
Reviewed-by: jjg
2014-02-28 18:27:14 +00:00
Per Bothner
25c2444601 8033287: Reduce the size of the endPosTable
Co-authored-by: Charlie Turner <chturne@gmail.com>
Reviewed-by: jjg
2014-02-27 13:57:57 -08:00
Paul Govereau
e97bf8b146 8035972: missing test file for 8034048
Reviewed-by: jjg, vromero
2014-02-27 11:47:39 -08:00
Eric McCorkle
816bfaa7bc 8035766: Execute TypeAnnotate visitor at queue flush time
Moved execution of TypeAnnotate visitor into Worker for type annotations

Reviewed-by: jjg
2014-02-27 00:29:22 -05:00
Paul Govereau
dd0e29f8b7 6533516: Warning needed for file with future time stamps
Reviewed-by: jjg, vromero
2014-02-26 18:05:02 -08:00
Paul Govereau
f6250d7784 8034048: javac crash with method references plus lambda plus var args
Reviewed-by: jjg, vromero
2014-02-26 15:38:55 -08:00
Eric McCorkle
38cc470411 8035758: Move annotation codepaths from MemberEnter.java to Annotate.java
Cosmetic code cleanup patch, moving code to the file where it ought to reside.

Reviewed-by: vromero
2014-02-25 14:06:48 -05:00
Lana Steuck
5c411f3cc6 Merge 2014-02-24 13:06:07 -08:00
Vicente Romero
c7af5cd60b 8034143: javac, subclasses of Infer.IncorporationStep should implement the accepts() method
Reviewed-by: jjg
2014-02-22 17:42:10 +00:00
David Katleman
7d41c598a4 Added tag jdk9-b03 for changeset 2740ebeb238c 2014-02-21 11:40:51 -08:00
Yuri Nesterenko
98b44a020b 6457406: javadoc doesn't handle <a href='http://...'> properly in producing index pages
Reviewed-by: jjg, bpatel, ksrini
2014-02-21 15:14:09 +04:00
Jan Lahoda
facc03d9f4 6411385: Trees.getPath does not work for constructors
Enhancing TestTrees test to ensure proper function of Trees.getPath/getTree, fixing cases where getTree did not work properly.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-02-21 10:35:19 +01:00
Lana Steuck
a6f4599cf5 Merge 2014-02-20 20:00:43 -08:00
Jonathan Gibbons
31ca5c712a 8035364: An extra space in the comments of constant pool entries
Reviewed-by: ksrini
2014-02-19 15:05:19 -08:00
Lana Steuck
fb842a624a Merge 2014-02-11 11:25:59 -08:00
David Katleman
fa155ae4bd Added tag jdk9-b02 for changeset fc0fe10fbee9 2014-02-06 13:09:40 -08:00
Erik Joelsson
961e7da0a4 8026773: Failing compilation in Corba does not fail the build
Reviewed-by: ihse, tbell
2014-02-05 11:04:04 +01:00
Eric McCorkle
3bd9bdd993 8033004: Make base TypeAnnotationPosition data immutable, create better methods for creating base TypeAnnotationPositions
First of a series of major fixes to type annotations; cleans up interface with TypeAnnotationPosition

Reviewed-by: jjg
2014-02-03 17:19:15 -05:00
Jan Lahoda
4724c454cd 8030091: Request to update error messages from javac for negative varargs test cases
Introducing a new error message for vararg parameter not being the last parameter, improving error message for unexpected character after a parameter.

Reviewed-by: jjg, sogoel
2014-02-02 12:12:01 +01:00
Jonathan Gibbons
30e9783850 8033180: An inappropriate newline symbol in the help section
Reviewed-by: ksrini
2014-01-30 17:46:25 -08:00
Eric McCorkle
ca53cc64e5 8033218: Silent failure in TypeAnnotations.resolveFrame
Change silent no-op to assertion failure when resolveFrame is called before attribution.

Reviewed-by: jfranck
2014-01-30 07:35:49 -05:00
Jonathan Gibbons
214de0eb69 8032869: remove support for legacy options in javap
Reviewed-by: ksrini
2014-01-29 14:32:27 -08:00
Eric McCorkle
77feb9302c 8032932: Add assertion to fix silent failure in Gen.getAndRemoveNonFieldTAs
Turn silent failure if type annotation position type is UNKNOWN into assertion failure.

Reviewed-by: jjg
2014-01-28 17:52:30 -05:00
Eric McCorkle
07998a6335 8032980: Silent failure in Attr.annotateType
Turn silent discard of annotations in Attr.annotateType if conversion to TypeCompound fails into an assertion failure.

Reviewed-by: jjg
2014-01-28 17:51:28 -05:00
Jonathan Gibbons
552e338377 8032819: Extra empty line between field declarations for the "-v -c" and "-v -l" combination of options
Reviewed-by: ksrini
2014-01-28 14:31:29 -08:00
Jeff Dinkins
49b3f8639b 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
2014-01-28 20:10:19 +00:00
Lana Steuck
cf5fc4c79e Merge 2014-01-28 11:22:56 -08:00
Lana Steuck
b14b1b2b12 Merge 2014-01-27 21:01:30 -08:00
Jonathan Gibbons
69a6133c78 8032814: LineNumberTable/LocalVariableTable tables duplication for the "-v -l" combination of options
Reviewed-by: ksrini
2014-01-27 17:48:47 -08:00
Jonathan Gibbons
478d2876a5 8031212: doclint incorrectly rejects some @see tags in javadoc comments
Reviewed-by: vromero
2014-01-27 16:07:32 -08:00
Eric McCorkle
1bb2245091 8032587: Change silent failure in Attr.java to assertion
Change silent failure in Attr.fromAttributes into a non-null assertion

Reviewed-by: jfranck
2014-01-24 08:47:32 -05:00
Matherey Nunez
69f2f2fad4 8027175: Existing regression tests in tl/langtools and tl/jdk need to be updated for @bug keyword
Reviewed-by: jjg, ksrini
2014-01-27 12:45:03 -08:00
Andreas Lundblad
99aae5c1fd 8028267: sun.tools.javac.util.Bits contains a main-method with test code
Removed main method from Bits and added proper unit testing.

Reviewed-by: jfranck
2014-01-24 09:39:51 +01:00
Joel Borggrén-Franck
b1bcbaeb4b 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
Reviewed-by: abuckley, jlahoda, vromero
2014-01-23 14:09:29 +01:00
Kumar Srinivasan
70eb26fc0a 8031023: [javac] LambdaToMethod is missing forceSerializedRepresentation logic and switch
Reviewed-by: jjg, rfield
2014-01-23 06:34:53 -08:00
Sonali Goel
ab6480d153 8032506: Remove commit.txt that was accidentally pushed with the changeset
Reviewed-by: jjg
2014-01-22 14:45:51 -08:00
Vicente Romero
712b922a0f 8030816: javac crashes when mixing lambdas and inner classes
Reviewed-by: jjg, jlahoda
2014-01-22 21:41:50 +00:00
Matherey Nunez
0c38c2d401 8027477: Enable repeating annotations test cases since JDK-8004912 is fixed
Reviewed-by: jjg, jfranck
2014-01-22 12:22:23 -08:00
David Katleman
41e4558068 Added tag jdk9-b01 for changeset 71073f4a867e 2014-01-21 18:17:21 -08:00
Alexander Zuev
bb0c5d0f71 Merge 2014-01-20 19:11:58 +04:00
Joe Darcy
4fa17d99b2 8031375: Revert test exclusions after fix for JDK-8030656 propagates
Reviewed-by: mduigou
2014-01-18 10:47:30 -08:00
Abhijit Saha
69a1d18d40 Merge 2014-01-16 21:46:01 -08:00
Joe Darcy
87dec1fa1a 8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1
Reviewed-by: jjg, sogoel
2014-01-16 18:00:25 -08:00
Abhijit Saha
d9ec81d45f Merge 2014-01-15 10:18:06 -08:00
Jan Lahoda
9a0f6ed18e 8028576: Incorrect RuntimeVisibleTypeAnnotations for exception parameters when not generating debuging info
The exception parameters with type annotations need to be added into the varBuffer even if not generating debug info

Reviewed-by: jjg, emc
2014-01-15 13:49:57 +01:00
Joel Borggrén-Franck
b3e2823f53 8029690: Move symbol creation from ClassReader to Symtab
Reviewed-by: jjg
2014-01-15 10:57:25 +01:00
Abhijit Saha
c575ece03d Merge 2014-01-14 08:08:32 -08:00
Bhavesh Patel
4ff2c3b94a 8026736: Enhance Javadoc pages
Reviewed-by: jjg
2014-01-13 14:50:51 -08:00
Jan Lahoda
69c52bd73b 8039079: Test tools/javac/processing/environment/round/TestElementsAnnotatedWith.java fails
Ensuring the test passes in both samevm and othervm modes.

Reviewed-by: darcy
2014-04-15 18:58:47 +02:00
Eric McCorkle
bd6695901c 8040181: Silent failure in Code.findExceptionIndex
Remove silent failure when exception index has not been set properly.

Reviewed-by: jjg
2014-04-14 18:48:29 -04:00
Jeff Dinkins
c704bce1fa 7129980: Third Party License Readme update for JDK8
Reviewed-by: lana, tbell
2014-01-13 14:44:29 -08:00
Kumar Srinivasan
f643b8cab0 8031545: [javac] refactor and cleanup JNIWriter.java
Reviewed-by: jjg
2014-02-15 16:37:19 -08:00
Kumar Srinivasan
c7480b6513 8029145: javadoc fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-02-14 17:28:07 -08:00
Andreas Lundblad
8daec20c86 8030714: The steps attribute, flow and desugar are unnecessary for implicit classes when compiling with -implicit:none
When compiling with -implicit:none, attribute, flow and desugar is skipped for better performance.

Reviewed-by: jfranck, jlahoda
2014-02-13 14:58:10 +01:00
Jan Lahoda
e20546fe2a 8033961: Formatting of -Xlint: command line help
Improving formatting of command line help for -Xlint, including a short description of each lint.

Reviewed-by: jjg
2014-02-13 13:38:48 +01:00
Dan Smith
55801d06ff 4910483: Javadoc renders the string ".*\\.pdf" as ".\*\.pdf"
Adjust timing of printing "\\" in the comment scanner

Reviewed-by: jjg
2014-02-12 12:31:30 -07:00
Jonathan Gibbons
4e86ae9988 8033930: Unnecessary new line after the StackMapTable
8033913: Incorrect indentation of StackMapTable entries

Reviewed-by: ksrini
2014-02-10 11:52:52 -08:00
Jan Lahoda
c0d767f6f1 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
When the overrides deprecated method warning is being reported, need to do that in the lint context of the method.

Reviewed-by: vromero
2014-02-07 21:43:33 +01:00
Jonathan Gibbons
29f985089a 8033581: Incorrect comment aligment
8033798: javap output has unnecessary trailing whitespace
8033726: StackMapTable does not unindent properly

Reviewed-by: ksrini
2014-02-06 18:54:13 -08:00
Christine Lu
67d15f03e0 8032526: fix the accessibility, html, syntax errors and warnings reported by doclint report in langtools
Reviewed-by: jjg
2014-02-06 16:39:19 -08:00
Jonathan Gibbons
8b3c6d6d4f 8033114: The values of non-static final fields are printed for the -constants option
Reviewed-by: ksrini
2014-02-06 15:43:23 -08:00
Jonathan Gibbons
47528ece5e 8033711: An exception is thrown if using the \"-classpath\" option with no arguments
Reviewed-by: ksrini
2014-02-06 11:01:50 -08:00
Jonathan Gibbons
5b738090bd 8033686: Internal error for zero indent
Reviewed-by: ksrini
2014-02-06 10:58:51 -08:00
Vicente Romero
edee080e4a 8030855: Default methods should be visible under source previous to 8
Reviewed-by: jjg, dlsmith
2014-02-06 18:49:01 +00:00
Alan Bateman
cf7f5c0b61 8033366: Add configure option to allow RMIConnector IIOP transport be selected compiled in or not
Reviewed-by: erikj
2014-02-06 15:49:51 +00:00
Jan Lahoda
8a2542c71f 8030049: RoundEnvironment.getElementsAnnotatedWith receives wrong elements
Match the required and actual annotations using Element equivalence rather than TypeMirror equivalence, to avoid trouble with erroneous types.

Reviewed-by: darcy
2014-01-10 19:02:54 +01:00
Andreas Lundblad
a76d1ab5a2 8028389: NullPointerException compiling annotation values that have bodies
Made sure anonymous class declarations inside class- and package-level annotations are properly entered.

Reviewed-by: jfranck
2014-01-10 12:47:15 +01:00
Jan Lahoda
e32b40185e 8029376: Full attribution of unresolvable annotations
8029161: javac crashing when processing broken annotations

Attributing values of annotation attributes regardless how broken the annotation is.

Reviewed-by: jjg, jfranck
2014-01-10 11:31:09 +01:00
Andreas Lundblad
147820083e 8006730: remove workaround tests when jtreg updated
Removed temporary workaround test-files.

Reviewed-by: jjg
2014-01-09 15:00:33 +01:00
Joe Darcy
3815f04fbc 8000962: Update JDK_MINOR_VERSION for JDK 9
Reviewed-by: jjg, ksrini
2014-01-07 15:00:23 -08:00
Joe Darcy
dd72fa55fc 8031360: Update langtools code base to use RELEASE_9
Reviewed-by: jjg
2014-01-07 13:47:49 -08:00
Joe Darcy
6fc7157058 8028543: Add SourceVersion.RELEASE_9
Reviewed-by: jjg
2014-01-07 11:43:56 -08:00
Steve Sides
4cbb43a7e3 8029230: Update copyright year to match last edit in jdk8 langtools repository for 2013
Reviewed-by: ksrini
2013-12-24 09:17:37 -08:00
Robert Field
8d4ba575b6 8030626: java.lang.VerifyError: Bad return type when lambda's body is in parentheses
Properly type convert the body of a lambda expression (forward port to JDK9 of 8029558)

Reviewed-by: vromero
2013-12-22 21:57:01 -08:00
Vicente Romero
b0f5f93cd0 8029240: Default methods not always visible under -source 7
Reviewed-by: jjg
2013-12-19 22:24:27 +00:00
Vicente Romero
a4bac02fa4 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
Reviewed-by: jjg, jfranck, sundar
2013-12-19 21:58:50 +00:00
Vicente Romero
3c77de74be 8030807: langtools should still build using jdk 7
Reviewed-by: briangoetz
2013-12-19 20:16:44 +00:00
Paul Govereau
4d793c02be 8030726: tools/javac/NoStringToLower.java fails due to enforcement no use of String.toLowerCase on non-langtools classes
Fix NoStringToLower test to only enforce ban on String.toLowerCase on langtools classes

Reviewed-by: vromero, jfranck
2013-12-19 11:38:45 -05:00
Bhavesh Patel
8ee3492363 8016549: jdk7 javadocs are hard to read
Reviewed-by: jjg
2013-12-18 19:48:47 -08:00
Brian Goetz
6b6b488756 8030244: Update langtools to use Diamond
Reviewed-by: darcy
2013-12-18 16:05:18 -05:00
Vicente Romero
6255412f38 8029721: javac crash for annotated parameter type of lambda in a field
Reviewed-by: rfield, jfranck
2013-12-18 19:22:58 +00:00
Vicente Romero
7f46fe764f 8029569: internal javac cast exception when resolving varargs ambiguity
Reviewed-by: jjg
2013-12-18 19:15:58 +00:00
Michael Fang
7d04b22371 8026741: jdk8 l10n resource file translation update 5
Reviewed-by: naoto, yhuang
2013-12-17 23:32:58 -08:00
Iris Clark
98948bb8af 8030068: Update .jcheck/conf files for JDK 9
Reviewed-by: mr
2013-12-13 09:36:24 -08:00
Iris Clark
d782fd4585 Added tag jdk9-b00 for changeset 4b89cce23b75 2013-12-12 15:27:11 -08:00
David Katleman
32f209883d Added tag jdk8-b120 for changeset 358a358062d5 2013-12-12 05:21:38 -08:00
Kumar Srinivasan
d56f2315c5 8029504: Regression: TestDocRootLink test fails on Windows
Reviewed-by: bpatel, jjg
2013-12-06 09:07:47 -08:00
Brian Goetz
dbcdc16212 8030253: Update langtools to use strings-in-switch
8030262: Update langtools to use foreach loops
8030245: Update langtools to use try-with-resources and multi-catch

Reviewed-by: darcy
2013-12-18 10:29:25 -05:00
Eric McCorkle
bedae747dc 8030687: Add .out files to fix failing tests
Forgot to hg add golden files in a previous fix

Reviewed-by: jjg
2013-12-17 19:27:49 -05:00
Paul Govereau
a183356fde 8030642: Add golden files to javac/limits
Add golden files to check output of negative compilation tests in javac/limits

Reviewed-by: jjg, emc
2013-12-17 18:15:48 -05:00
Joe Darcy
f089800ee7 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model)
Reviewed-by: jfranck
2013-12-17 10:28:36 -08:00
Jan Lahoda
0f0e04b6a0 8028235: Better error recovery for parsing 'void' as a type of the lambda parameter
Handle "void" as a primitive type in JavacParser.analyzeParens.

Reviewed-by: vromero
2013-12-17 10:58:26 +01:00
Jan Lahoda
92c25244aa 8028415: TreeMaker.Literal(Object) creates invalid JCLiterals when passed a Character
JCLiteral for char must contain an Integer, not the provided Character.

Reviewed-by: jjg
2013-12-17 10:58:21 +01:00
Jan Lahoda
8ebb81fb7a 8029800: Flags.java uses String.toLowerCase without specifying Locale
Introducing StringUtils.toLowerCase/toUpperCase independent on the default locale, converting almost all usages of String.toLowerCase/toUpperCase to use the new methods.

Reviewed-by: jjg, bpatel
2013-12-17 10:55:59 +01:00
Jan Lahoda
b06d1bfb55 8029715: test needs bugID added to @bug tag
Adding forgotten bug number

Reviewed-by: vromero
2013-12-17 10:55:58 +01:00
Joe Darcy
b2651d0972 8028545: Add -source 9 and -target 9 to javac
8000961: Change javac source and target default to 9

Reviewed-by: jjg
2013-12-16 10:15:38 -08:00
Vicente Romero
ffb2f48033 8030214: fix for JDK-8020216 breaks the build
Reviewed-by: jjg
2013-12-16 17:33:18 +00:00
Andrey Nazarov
213b16163b 8028708: TEST_BUG, Tests should pass through VM options, langtools tests
Reviewed-by: jjg, vromero
2013-12-16 15:07:13 +00:00
Vicente Romero
4d99383951 8020216: javac, compile time error isn't shown when final static field is not assigned
Reviewed-by: jjg
2013-12-16 14:32:12 +00:00
Lana Steuck
72d1a95d79 Merge 2013-12-05 10:34:49 -08:00
David Katleman
e75e2f3fb8 Added tag jdk8-b119 for changeset 7598dfa5cb4c 2013-12-04 23:11:45 -08:00
Mandy Chung
cd7a8e76a4 8029216: (jdeps) Provide a specific option to report JDK internal APIs
Reviewed-by: alanb
2013-12-04 15:39:36 -08:00
Lana Steuck
f179384b1c Merge 2013-12-03 23:10:23 -08:00
Bhavesh Patel
81ef12b24a 8025416: doclet not substituting {@docRoot} in some cases
Reviewed-by: jjg
2013-12-03 14:21:45 -08:00
Lana Steuck
f0dcaf0d7a Merge 2013-12-03 10:47:17 -08:00
Vicente Romero
a64e195ca9 8029179: javac produces a compile error for valid boolean expressions
Reviewed-by: jjg, jlahoda
2013-12-03 18:13:18 +00:00
Werner Dietl
e2d2bb9a25 8028699: Compiler crash during speculative attribution of annotated type
Moving the checkForDeclarationAnnotations check into Attr.TypeAnnotationsValidator

Reviewed-by: jjg
2013-12-03 18:50:26 +01:00
Christine Lu
7872057617 Added tag jdk8-b118 for changeset e5aaa3cef7d2 2013-11-28 08:24:36 -08:00
Jan Lahoda
51d11b5222 8027789: Access method for Outer.super.m() references indirect superclass
Internally convert the qualified super access to an equivalent of an unqualified super access inside the access method.

Reviewed-by: vromero, jjg
2013-11-26 15:33:12 +01:00
Jan Lahoda
38ef229e3f 8026374: javac accepts void as a method parameter
Changing Check.validate to reject void types.

Reviewed-by: jjg, vromero
2013-11-26 15:27:19 +01:00
Joel Borggrén-Franck
979151dfa9 8028428: strictfp allowed as annotation element modifier
Reviewed-by: jjg
2013-11-26 13:33:33 +01:00
Jonathan Gibbons
7f2246bbef 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules
Reviewed-by: darcy
2013-11-25 17:42:28 -08:00
Lana Steuck
78520efca9 Merge 2013-11-25 09:41:20 -08:00
Robert Field
14ae524304 8028739: javac generates incorrect descriptor for MethodHandle::invoke
Introduce special handling for signature polymorphic methods

Reviewed-by: jjg
2013-11-22 17:07:35 -08:00
Christine Lu
2a37cd5b6d Added tag jdk8-b117 for changeset b8a5f2e7f41a 2013-11-21 09:23:13 -08:00
Bhavesh Patel
274905a316 8027977: javadoc dies on NumberFormat/DateFormat subclass
Reviewed-by: jjg
2013-11-20 10:53:38 -08:00
Jan Lahoda
5fd77a7cef 6557966: Multiple upper bounds of the TypeVariable
Adjusting javax.lang.model javadoc regarding IntersectionType, IntersectionType.accept now calls visitIntersection for all kinds of IntersectionTypes.

Co-authored-by: Joe Darcy <joe.darcy@oracle.com>
Reviewed-by: darcy, vromero
2013-11-20 13:44:39 +01:00
Vicente Romero
f4c2201eb4 8028504: javac generates LocalVariableTable even with -g:none
Reviewed-by: jjg, jlahoda
2013-11-19 23:35:43 +00:00
Alexander Zuev
b1ae577b23 6726154: javadoc generated with incorrect version in comment
Reviewed-by: jjg, bpatel, erikj, tbell
2013-11-19 22:14:51 +04:00
Lana Steuck
15cdbd1aa0 Merge 2013-11-15 07:15:51 -08:00
Vicente Romero
e6e0508e1a 8026231: Look at 'static' flag when checking method references
Reviewed-by: jjg, dlsmith
2013-11-15 11:08:12 +00:00
Bhavesh Patel
b140c3c382 8025524: javadoc does not correctly locate constructors for nested classes
Reviewed-by: jjg
2013-11-14 13:47:38 -08:00
Vicente Romero
34a6de55b2 8026963: type annotations code crashes for code with erroneous trees
Reviewed-by: jjg, jlahoda
2013-11-14 19:28:20 +00:00
Eric McCorkle
71adca3d64 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java
Remove @ignore from test

Reviewed-by: jjg
2013-11-14 12:32:57 -05:00
Christine Lu
3ad95dda8e Added tag jdk8-b116 for changeset 1fbd33ac5531 2013-11-14 09:05:25 -08:00
Sonali Goel
b941719f94 8025113: Convert 7 tools TryWithResources tests to jtreg format
Reviewed-by: darcy, jjg
2013-11-13 16:36:08 -08:00
Joel Borggrén-Franck
f3cb828db7 8027375: javac asserts on nested erroneous annotations
Make sure JCAnnotation trees have type != null before annotation processing

Reviewed-by: jjg
2013-11-11 17:26:09 +01:00
Eric McCorkle
44f29ffde7 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
8027253: javac illegally accepts array as bound

Backing out change allowing arrays in intersection types

Reviewed-by: vromero
2013-11-11 09:47:46 -05:00
Jan Lahoda
d3eb4e0816 8027142: Invokedynamic instructions don't get line number table entries
When emitting invokedynamic instruction, write pendingStatPos, if set, into the LineNumberTable. Invokedynamic itself does not set the pendingStatPos.

Reviewed-by: jjg, jrose, ksrini, vromero
2013-11-09 15:24:38 +01:00
Lana Steuck
ab3713bd2f Merge 2013-11-08 17:39:33 -08:00
Joe Darcy
d9cc608057 8027730: Fix release-8 type visitors to support intersection types
Reviewed-by: jjg, jlahoda, sogoel
2013-11-07 20:11:56 -08:00
Christine Lu
ccd53abea1 Added tag jdk8-b115 for changeset 115e1128ce1a 2013-11-07 08:16:38 -08:00
Jan Lahoda
e9f9c31086 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests
When invoking interface default method via a superclass, use the direct superclass in the reference.

Reviewed-by: vromero, dlsmith, jjg
2013-11-06 17:48:25 +01:00
Christine Lu
12da1db3d7 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options
Reviewed-by: jjg
2013-11-04 18:51:56 -08:00
Christine Lu
14c3c8b4fb 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b
Reviewed-by: jjg
2013-11-04 18:04:34 -08:00
Christine Lu
989860b8c3 8025844: Need test to provide coverage for new DocumentationTool.Location enum
Reviewed-by: jjg
2013-11-04 17:38:38 -08:00
Magnus Ihse Bursie
9e72063042 8027566: Remove the old build system
Reviewed-by: erikj, tbell
2013-11-04 11:08:41 +01:00
Jan Lahoda
513a51e9bb 8027310: Annotation Processor crashes with NPE
JCAnnotation.attribute is null when annotation type is unavailable

Reviewed-by: jjg, jfranck
2013-11-01 21:43:27 +01:00
Vicente Romero
96d9e95176 8027660: javac crash while creating LVT entry for a local variable defined in an inner block
Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2013-11-01 19:08:56 +00:00
Lana Steuck
0de31c2237 Merge 2013-10-31 16:46:43 -07:00
Christine Lu
47d505c488 Added tag jdk8-b114 for changeset 7e53ada0d2d4 2013-10-31 12:36:36 -07:00
Brian Goetz
6dcdc5b742 8024930: Re-enable disabled bridging tests
Reviewed-by: psandoz, rfield
2013-10-30 14:12:16 -04:00
Vicente Romero
9d30f46219 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo
Reviewed-by: ksrini
2013-10-30 18:09:49 +00:00
Mandy Chung
fa729039be 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.*
Reviewed-by: alanb, dfuchs
2013-10-30 08:35:52 -07:00
Lana Steuck
14d87a0e5a Merge 2013-10-28 12:29:34 -07:00
Robert Field
e49bc26ebc 8027220: DefaultMethodsTest: Change test to match spec
Reviewed-by: ksrini
2013-10-24 16:52:27 -07:00
Bhavesh Patel
3033b82865 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags
Reviewed-by: jjg
2013-10-24 11:22:50 -07:00
Christine Lu
7217e11778 Added tag jdk8-b113 for changeset 220220c28a95 2013-10-24 09:10:52 -07:00
Eric McCorkle
e62fb20a59 8023682: Incorrect attributes emitted for anonymous class declaration
Cause javac to emit type annotations on new instruction as well as anonymous class supertype for annotated anonymous classes.

Reviewed-by: jjg, jfranck
2013-10-24 01:27:10 -04:00
Eric McCorkle
fb5a684124 8006732: support correct bytecode storage of type annotations in multicatch
Fix issue with annotations being added before attribution, which causes multicatch not to work right and several tests to fail.

Reviewed-by: jfranck, jjg
2013-10-23 23:20:32 -04:00
Jan Lahoda
017ea08922 8026936: Initialize LamdbaToMethod lazily and as required
Reviewed-by: jjg, rfield
2013-10-23 15:45:18 -07:00
David Katleman
a9467bf52b Merge 2013-10-23 08:50:36 -07:00
Jan Lahoda
14fe29f845 8026861: Wrong LineNumberTable for variable declarations in lambdas
Setting or correcting positions for many trees produced by LambdaToMethod.

Reviewed-by: vromero, rfield
2013-10-23 07:50:04 +02:00
Jan Lahoda
237d1940c6 8027191: Fix for JDK-8026861 refers to an incorrect bug number
Reverting changeset e7c8a164d7bd, so that it can be applied again with a correct bug number

Reviewed-by: jjg
2013-10-23 23:02:17 +02:00
Bhavesh Patel
80787f47a9 8026770: javadoc creates invalid HTML in profile summary pages
Reviewed-by: jjg
2013-10-23 13:54:13 -07:00
Robert Field
c9ceea7ac7 8022720: Method refeerences - private method should be accessible (nested classes)
Reviewed-by: jjg, ksrini
2013-10-23 10:28:10 -07:00
Jan Lahoda
5ea357c66e 8026508: Invokedynamic instructions don't get line number table entries
Setting or correcting positions for many trees produced by LambdaToMethod.

Reviewed-by: vromero, rfield
2013-10-23 07:50:04 +02:00
Jonathan Gibbons
806a84e4de Merge 2013-10-22 17:44:43 -07:00
Jonathan Gibbons
53d2f8ae31 8027119: Cleanup javadoc comments for taglet API
Reviewed-by: mduigou
2013-10-22 17:42:10 -07:00
Robert Field
69709943c3 8023668: Desugar serializable lambda bodies using more robust naming scheme
Lambda / bridged method-reference naming overhaul

Reviewed-by: ksrini, briangoetz
2013-10-22 16:53:21 -07:00
Tim Bell
4c2ade4cc3 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files
Reviewed-by: mduigou, mchung
2013-10-22 16:30:06 -07:00
Vicente Romero
48b6b38e52 8025290: javac implicit versus explicit lambda compilation error
Reviewed-by: jjg, dlsmith
2013-10-22 13:54:49 +01:00
Joel Borggrén-Franck
d8d3ea2057 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present
An empty container should not stop javac from looking at supertypes for inherited repeating annotations

Reviewed-by: jjg
2013-10-22 10:08:49 +02:00
Kumar Srinivasan
39fb59399a 8026758: Inefficient code in LambdaToMethod
Reviewed-by: jjg, jlahoda, rfield
2013-10-21 20:10:43 -07:00
Joel Borggrén-Franck
4a79e1cec8 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable
In AnnoConstruct.getAnnotationByType() check that the annotation sought after is inherited before looking on supertypes.

Reviewed-by: jjg
2013-10-22 03:36:44 +02:00
Joe Darcy
7b509ee987 8026984: Clarity intended use of jdk.Exported
Reviewed-by: psandoz, mr, alanb
2013-10-21 15:37:11 -07:00
Vicente Romero
43754fccbd 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change
Reviewed-by: jfranck
2013-10-21 15:55:02 +01:00
Kumar Srinivasan
24394acaea 8026931: MethodParameters tests failing on Windows
Reviewed-by: jjg, vromero
2013-10-20 12:54:17 -07:00
Werner Dietl
29582c0ec0 8026791: wrong type_path encoded for method_return on an inner class constructor
Reviewed-by: jjg
2013-10-20 12:46:12 -07:00
Werner Dietl
84cadf2e45 8025109: Better encapsulation for AnnotatedType
Reviewed-by: jjg
2013-10-20 12:01:43 -07:00
Vicente Romero
027b935c1b 8024809: javac, some lambda programs are rejected by flow analysis
Reviewed-by: jjg, dlsmith
2013-10-19 17:43:09 +01:00
Bhavesh Patel
cee70e2272 8026567: Use meaningful style names for strong and italic styles
Reviewed-by: jjg
2013-10-18 16:34:42 -07:00
Jonathan Gibbons
cf30c20337 8026749: Missing LV table in lambda bodies
Reviewed-by: vromero, jlahoda
2013-10-18 15:03:34 -07:00
Joe Darcy
f8e08a9965 8026838: Fix new doclint issues in javax.annotation.processing
Reviewed-by: jjg
2013-10-17 19:10:19 -07:00
Lana Steuck
1761325728 Merge 2013-10-17 16:13:39 -07:00
Mandy Chung
1285dee32b 8015912: jdeps support to output in dot file format
8026255: Switch jdeps to follow traditional Java option style

Reviewed-by: alanb
2013-10-17 13:19:48 -07:00
Christine Lu
28cd7f48ee Added tag jdk8-b112 for changeset 96faa2507e3a 2013-10-17 09:41:12 -07:00
Matherey Nunez
c57660ca19 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest
Reviewed-by: jjg, jfranck
2013-10-17 13:50:00 +02:00
Matherey Nunez
7c6e4696ab 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final
Reviewed-by: jjg, jfranck
2013-10-17 13:27:36 +02:00
Eric McCorkle
b8aff04aa0 8026286: Improper locking of annotation queues causes assertion failures
8026063: Calls to annotate.flush() cause incorrect type annotations to be generated

Fix locking in ClassReader.java

Reviewed-by: jfranck
2013-10-16 16:33:04 -04:00
David Katleman
6c2816e717 Merge 2013-10-16 12:05:07 -07:00
Jonathan Gibbons
ef68cc1fc1 8026704: Build failure with --enable-debug
Reviewed-by: ksrini
2013-10-16 10:47:21 -07:00
Werner Dietl
e5c34a89eb 8026564: import changes from type-annotations forest
Co-authored-by: Steve Sides <steve.sides@oracle.com>
Reviewed-by: jjg
2013-10-15 15:57:13 -07:00
Jan Lahoda
912fc38c65 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing
A mostly automated rename Annotate.Annotator->Annotate.Worker and enterAnnotation->run.

Reviewed-by: emc, jjg
2013-10-15 22:15:35 +02:00
Chris Hegarty
f5392a9718 Merge 2013-10-15 21:12:33 +01:00
Vicente Romero
1868655b89 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
Reviewed-by: jjg
2013-10-15 21:02:21 +01:00
Chris Hegarty
0fd34f307d Merge 2013-10-15 20:47:55 +01:00
Vicente Romero
53cc43916a 8025816: javac crash with method reference with a type variable as the site
Reviewed-by: jjg
2013-10-15 19:36:45 +01:00
Bhavesh Patel
99e02c21cd 8026370: javadoc creates empty <span class="italic"></span>
Reviewed-by: jjg
2013-10-15 11:20:27 -07:00
Jan Lahoda
52d83865b8 8026180: com.sun.source.tree.NewArrayTree refers to com.sun.tools.javac.util.List
Correcting import in NewArrayTree, adding test protecting againts improper types in API signatures

Reviewed-by: jjg
2013-10-15 16:23:18 +02:00
Chris Hegarty
95866e7e4f Merge 2013-10-15 14:17:11 +01:00
Jonathan Gibbons
0837163643 8025998: Missing LV table in lambda bodies
Reviewed-by: vromero
2013-10-14 23:07:43 -07:00
Jonathan Gibbons
31b34ce39c 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail
Reviewed-by: darcy
2013-10-14 22:34:37 -07:00
Jonathan Gibbons
fc85ec65d8 8026371: "tidy" issues in langtools/src/**/*.html files
Reviewed-by: darcy
2013-10-14 16:28:44 -07:00
Jan Lahoda
da21af58f4 8014016: javac is too late detecting invalid annotation usage
Adding new queue to Annotate for validation tasks, performing annotation validation during enter

Reviewed-by: jjg, emc, jfranck
2013-10-14 22:11:09 +02:00
Jonathan Gibbons
09523f2583 8026368: doclint does not report empty tags when tag closed implicitly
Reviewed-by: darcy
2013-10-14 12:38:09 -07:00
Chris Hegarty
0eadafa765 Merge 2013-10-11 19:05:18 +01:00
Jan Lahoda
958096d69b 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type
Reviewed-by: darcy, jfranck, jjg
2013-10-11 15:49:15 +02:00
Lana Steuck
7f8a6a5898 Merge 2013-10-11 03:09:42 -07:00
Robert Field
a8e63b82f1 8012557: Implement lambda methods on interfaces as private
8016320: Method reference in subinterface of type I.super::foo produces exception at runtime

Now that the VM supports interface instance private methods, lambda methods and lambda bridges are always private. Access is now through invokespecial.

Reviewed-by: vromero, jlahoda
2013-10-10 23:26:56 -07:00
Lana Steuck
aa4594456d Merge 2013-10-10 20:57:27 -07:00
Jonathan Gibbons
a29d963e53 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java
Reviewed-by: darcy
2013-10-10 17:13:32 -07:00
Eric McCorkle
a78344ba67 8008762: Type annotation on inner class in anonymous class show up as regular type annotations
8015257: type annotation with TYPE_USE and FIELD attributed differently if repeated
8013409: test failures for type annotations

Fixes to address some problems in type annotations

Reviewed-by: jfranck, jjg
2013-10-10 20:12:08 -04:00
Lana Steuck
fb3c32d988 Merge 2013-10-10 13:41:08 -07:00
Eric McCorkle
ad8c918fb1 8019461: Clean up javac diagnostics
7196553: Review error messages for repeating annotations

Changes to the diagnostic messages to improve clarity and JLS coherence

Reviewed-by: jjg
2013-10-10 13:55:41 -04:00
Bhavesh Patel
a7125b5d2e 8025633: Fix javadoc to generate valid anchor names
Reviewed-by: jjg
2013-10-10 10:51:15 -07:00
Christine Lu
67a4e0fd30 Added tag jdk8-b111 for changeset 9c619baa6191 2013-10-10 10:09:28 -07:00
Magnus Ihse Bursie
a706cda2ed 8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
2013-10-10 14:58:04 +02:00
Andreas Lundblad
3e4c0741c4 8021237: clean up JavacAnnotatedConstruct
Refactored the static helper methods in JavacAnnoConstructs into ordinary methods and put them in a common superclass (AnnoConstruct) of Symbol and Type.

Reviewed-by: jjg, vromero, jfranck
2013-10-10 08:51:55 +02:00
Jan Lahoda
5ec0ba7c47 8025087: Annotation processing api returns default modifier for interface static method
ClassReader must not set Flags.DEFAULT for interface static methods

Reviewed-by: vromero, jjg
2013-10-09 13:09:31 +02:00
Jan Lahoda
7de3ec870d 8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...)
Should not generate non-public $assertionsDisabled field into interfaces

Reviewed-by: jjg, vromero
2013-10-09 13:06:49 +02:00
Lana Steuck
33306e57d3 Merge 2013-10-08 14:59:46 -07:00
Andreas Lundblad
f6875dad27 8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Fixed precedence and associativity issues with pretty printing of JCConditional expressions.

Co-authored-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: jfranck
2013-10-08 15:33:28 +02:00
Joe Darcy
640945b6f3 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer
Reviewed-by: jjg
2013-10-07 16:51:56 -07:00
Steve Sides
03c9c56f88 8005542: jtreg test OverrideBridge.java contains @ignore
Reviewed-by: jjg
2013-10-04 16:23:05 -07:00
Kumar Srinivasan
74d2e71e10 8003537: javap use internal class name when printing bound of type variable
Reviewed-by: jjg
2013-10-04 16:08:18 -07:00
Jonathan Gibbons
bb2e47a5f4 8025970: Spurious characters in JavaCompiler
Reviewed-by: ksrini
2013-10-04 15:24:42 -07:00
Jonathan Gibbons
6995b57041 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode
Reviewed-by: darcy
2013-10-04 14:46:46 -07:00
Jonathan Gibbons
be225c4b49 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor
Reviewed-by: darcy
2013-10-04 13:59:13 -07:00
Bhavesh Patel
b10f820519 8024756: method grouping tabs are not selectable
Reviewed-by: jjg
2013-10-04 13:41:13 -07:00
Bhavesh Patel
7ad9444ac1 8008164: Invisible table captions in javadoc-generated html
Reviewed-by: jjg
2013-10-04 13:32:30 -07:00
Joe Darcy
e18872a5a9 8025913: Rename jdk.Supported to jdk.Exported
Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg
2013-10-04 10:00:28 -07:00
Alexander Zuev
bb40243d1a 7096170: should remove unused support for enabling javac logging
Reviewed-by: jjg
2013-10-04 19:38:55 +04:00
Jan Lahoda
dd031ed38f 8025118: Annotation processing api returns default modifier for interface without default methods
TypeElement.getModifiers() should not contain Modifier.DEFAULT

Reviewed-by: darcy, jjg
2013-10-04 08:29:54 +02:00
Chris Hegarty
85829db5d3 Merge 2013-10-03 19:28:07 +01:00
David Katleman
31995e22ba Added tag jdk8-b110 for changeset f5f4ff5ce376 2013-10-02 13:26:54 -07:00
Vicente Romero
696179bbda 8023679: Improve error message for '_' used as a lambda parameter name
Reviewed-by: jjg, dlsmith
2013-10-02 17:04:51 +01:00
Eric McCorkle
d9502c856a 8021339: Compile-time error during casting array to intersection
Add ability to have arrays in intersection types.

Reviewed-by: jjg, vromero
2013-10-01 17:41:57 -04:00
Alexander Zuev
2f3d9d1376 7118749: NPE in CreateSymbols caused by bad diagnostic
Reviewed-by: jjg
2013-10-01 17:03:31 +04:00
Eric McCorkle
d03ac9784a 8025413: NPE in Type.java due to recent change
IsCompound throws a NPE for noType and other types.  Made it return a reasonable result instead.

Reviewed-by: jjg, vromero
2013-09-28 13:46:14 -04:00
Lana Steuck
cb1bbba5c8 Merge 2013-09-27 18:38:29 -07:00
Kumar Srinivasan
b43acfee98 8015073: c.s.t.javac.api.JavacTool.getTask() - more informative exception
Reviewed-by: jjg
2013-09-27 16:05:56 -07:00
Robert Field
9a6f8e8463 8025548: langtools test tools/javac/lambda/methodReference/BridgeMethod.java incorrectly assumes no other methods generated in lambda class
Reviewed-by: vromero
2013-09-27 13:06:38 -07:00
Mike Duigou
e3e8d44bd7 8024842: Define ABS_TEST_OUTPUT_DIR via TEST_OUTPUT_DIR
Reviewed-by: ihse, erikj, vromero
2013-09-27 11:34:32 -07:00
Sonali Goel
475b209cf7 8025537: Convert 2 javac/enumdeclarations tests in jtreg for regression ws
Reviewed-by: jjg
2013-09-27 10:39:52 -07:00
Alexander Zuev
e0f4378a6c 6978886: javadoc shows stacktrace after print error resulting from disk full
Reviewed-by: jjg
2013-09-27 21:20:01 +04:00
Jan Lahoda
6c9b134b12 8022765: Compiler crashes with exception on wrong usage of an annotation
Error recovery for incorrect annotation attribute values - ensure the values are always attributed appropriately

Reviewed-by: jfranck, jjg
2013-09-27 17:28:31 +02:00
Vicente Romero
cae732b133 8024497: crash returning this-referencing lambda from default method
Reviewed-by: jjg, rfield
2013-09-27 10:24:56 +01:00
Lana Steuck
87d0ea84c1 Merge 2013-09-26 17:23:00 -07:00
Sonali Goel
e60e01be01 8011738: Write test to check for bootstrap attributes for lambda expressions in class file
Reviewed-by: mcimadamore
2013-09-26 15:04:15 -07:00
Vicente Romero
f5a3e39f94 8025139: javac patch for using bootstrap compiler for debugging is not working properly
Reviewed-by: jjg
2013-09-26 19:06:09 +01:00
Jan Lahoda
26b536e23d 8025491: Javac regression test tools/javac/T8003967/DetectMutableStaticFields.java failing
Making HtmlTree.NONENCODING_CHARS final

Reviewed-by: jjg
2013-09-26 20:07:43 +02:00
Christine Lu
58d873f65a Added tag jdk8-b109 for changeset 70dd6db0a869 2013-09-26 10:43:55 -07:00
Bhavesh Patel
a949e946ab 8004825: javadoc crash DocletAbortException
Reviewed-by: jjg
2013-09-25 22:26:42 -07:00
Jonathan Gibbons
fd9a09c390 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java
Reviewed-by: bpatel
2013-09-25 14:04:24 -07:00
Michael Fang
33c36e737b Merge 2013-09-25 14:02:16 -07:00
Tim Bell
2578c3a839 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week
Reviewed-by: ksrini, katleman
2013-09-25 12:24:13 -07:00
Jonathan Gibbons
9692733c7a 8025407: TypeAnnotations does not use Context
Reviewed-by: jfranck
2013-09-25 11:07:05 -07:00
Michael Fang
ad5dc502a5 Merge 2013-09-25 07:36:37 -07:00
Bhavesh Patel
2233312946 8016328: Regression : Javadoc i18n regression caused by fix for 8012375
Reviewed-by: jjg
2013-09-24 16:12:06 -07:00
Michael Fang
7dac5a00c3 Merge 2013-09-24 14:35:24 -07:00
Michael Fang
072f43e117 8025215: jdk8 l10n resource file translation update 4
Reviewed-by: naoto, yhuang
2013-09-24 14:20:33 -07:00
Jonathan Gibbons
48d1808d53 8002154: [doclint] doclint should check for issues which are errors in javadoc
Reviewed-by: bpatel
2013-09-24 13:48:12 -07:00
Jonathan Gibbons
e762b2997d 8025272: doclint needs to check for valid usage of @value tag
Reviewed-by: bpatel
2013-09-24 11:46:25 -07:00
Jonathan Gibbons
026c5d7620 8025246: [doclint] doclint is showing error on anchor already defined when it's not
Reviewed-by: bpatel
2013-09-24 10:51:28 -07:00
Jonathan Gibbons
14ceb05e0e 8025050: Doclint doesn't recognize <dfn> tag
Reviewed-by: bpatel
2013-09-24 10:48:11 -07:00
Eric McCorkle
c101eca6bb 6499673: Assertion check for TypeVariable.getUpperBound() fails
Fix TypeVariable.getUpperBound to return results as specified

Reviewed-by: jjg
2013-09-23 15:37:59 -04:00
Alexander Zuev
e815841576 4881267: improve diagnostic for "instanceof T" for type parameter T
Reviewed-by: vromero, jjg
2013-09-23 18:29:27 +04:00
Alexander Zuev
eacd2bcb72 7154966: CRs found to be in Fixed state with no test and no noreg- keyword
Reviewed-by: ksrini
2013-09-23 17:27:38 +04:00
Andreas Lundblad
48774216f2 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
Static factory method ListBuffer.lb removed. Replaced by constructor calls.

Reviewed-by: jfranck, jjg
2013-09-23 10:42:38 +02:00
Andreas Lundblad
a2a38c6b65 8024988: javac, LVT test harness should generate tests .class files in the scratch folder
Set the CLASS_OUTPUT location to the scratch directory. Changed the argument to checkClassFile accordingly.

Reviewed-by: jjg, vromero
2013-09-23 10:10:07 +02:00
Lana Steuck
186556ad21 Merge 2013-09-22 20:20:38 -07:00
Vicente Romero
70e873ec73 8024696: Missing null check in bound method reference capture
Reviewed-by: jjg, briangoetz
2013-09-22 12:53:03 +01:00
Lana Steuck
e432d5256a Merge 2013-09-20 19:16:55 -07:00
Jan Lahoda
9f6d1df747 8023835: TreeMaker.QualIdent() too leafy
Reviewed-by: jjg
2013-09-20 16:33:35 +02:00
Werner Dietl
8b909ba558 8025110: TreeCopier does not correctly copy LabeledStatementTree
Reviewed-by: jjg
2013-09-19 19:18:37 -07:00
Vicente Romero
e3d450e3d3 8024437: Inferring the exception thrown: sometimes fails to compile
Reviewed-by: jjg
2013-09-19 20:57:37 +01:00
Christine Lu
cb06edc1bf Added tag jdk8-b108 for changeset 669e1adcbf50 2013-09-19 09:37:26 -07:00
Fredrik Öhrström
5db62ec900 8024609: sjavac assertion fails during call to BuildState.collectArtifacts
Reviewed-by: jjg
2013-09-19 08:26:26 -07:00
Jan Lahoda
1c9e7a8edc 8022567: Javac Should Generate Warnings For Raw Array Type
Reviewed-by: jjg
2013-09-19 17:05:08 +02:00
Alexander Zuev
ca51d27ee3 8017248: Compiler Diacritics Issue
Reviewed-by: naoto
2013-09-19 17:05:32 +04:00
Bhavesh Patel
2be05076f8 8024096: some javadoc tests may contain false positive results
Reviewed-by: jjg
2013-09-18 22:47:06 -07:00
Bhavesh Patel
484e378a9d 8015249: javadoc fails to document static final fields in annotation types
Reviewed-by: jjg
2013-09-18 17:13:26 -07:00
Andreas Lundblad
775822bed7 8024127: javac, Code_attribute.exception_table_langth should be Code_attribute.exception_table_length
Exception_table_langth renamed to exception_table_length

Reviewed-by: jfranck, jjg
2013-09-18 14:39:27 +02:00
Jonathan Gibbons
7cc012b008 8024538: -Xdoclint + -Xprefer:source + incremental compilation == FAIL
Reviewed-by: darcy
2013-09-17 14:17:13 -07:00
Lana Steuck
8ba6b5e2f1 Merge 2013-09-17 08:21:11 -07:00
Jan Lahoda
315696de00 8021112: Spurious unchecked warning reported by javac
6480588: No way to suppress deprecation warnings when implementing deprecated interface

Fixing DeferredLintHandler configuration, so lint warnings are reported with correct @SuppressWarnings settings

Reviewed-by: jjg, vromero
2013-09-16 14:13:44 +02:00
Chris Hegarty
db6134b0fa Merge 2013-09-14 20:46:37 +01:00
Vicente Romero
86baa378e4 7047734: javac, the LVT is not generated correctly in several scenarios
Reviewed-by: jjg, mcimadamore
2013-09-14 19:04:47 +01:00
Vicente Romero
0a312ba2ce 8024207: javac crash in Flow.AssignAnalyzer.visitIdent
Reviewed-by: jjg
2013-09-14 15:23:21 +01:00
Vicente Romero
204f4422ba 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: jjg
2013-09-12 22:40:29 +01:00
Eric McCorkle
914b1751c4 8013846: javac fails to reject semantically equivalent generic method declarations
Cause javac to consider intersection types with the same elements to be equal regardless of order.

Reviewed-by: jjg, vromero
2013-09-12 14:52:28 -04:00
Christine Lu
2de4350911 Added tag jdk8-b107 for changeset bd69808a67e1 2013-09-12 11:09:20 -07:00
Bhavesh Patel
a357688f61 8015496: Information that package is deprecated is missing in profiles view
Reviewed-by: jjg
2013-09-11 14:50:11 -07:00
Eric McCorkle
1b72835883 8024510: lib/combo/tools/javac/combo/TemplateTest.java fails
Edit regex in Template to allow "MAJOR." pattern.

Reviewed-by: briangoetz
2013-09-11 08:30:58 -04:00
Maurizio Cimadamore
de5e0f4b27 8024414: javac, should facilitate the use of the bootstrap compiler for debugging
Reviewed-by: jjg
2013-09-10 16:47:40 +01:00
Andreas Lundblad
fae7d60062 8005222: Fixed bugs should have tests with bugid in @bug tag
Reviewed-by: jfranck, jjg
2013-09-10 13:47:51 +02:00
Jan Lahoda
a9e5e17bd2 8019521: Enhanced rethrow disabled in lambdas
Fixing effectively final detection inside lambdas, small cleanup related to thrown types detection in lambdas

Reviewed-by: mcimadamore, jjg
2013-09-09 23:13:45 +02:00
Jonathan Gibbons
810c76f567 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java
Reviewed-by: darcy
2013-09-09 17:36:23 -07:00
Brian Goetz
b03e5fc290 8015322: Javac template test framework
Putback of the javac template test framework from the Lambda repository

Reviewed-by: jjg
2013-09-09 17:11:55 -04:00
Eric McCorkle
5b76a0d216 8022322: Reject default and static methods in annotation
Causes javac to reject static and default method declarations inside an annotation

Reviewed-by: jjg
2013-09-09 16:26:55 -04:00
Vicente Romero
1704a9454c 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests
Reviewed-by: jjg, jfranck
2013-09-09 16:32:08 +01:00
Andreas Lundblad
5df75e001d 8022260: Rename javac.code.Annotations to javac.code.SymbolMetadata
Reviewed-by: jfranck, jjg
2013-09-09 09:58:20 +02:00
Vicente Romero
a3b1359af5 8024398: javac, compiler crashes with try with empty body
Reviewed-by: jjg
2013-09-08 11:54:21 +01:00
Lana Steuck
8e78895234 Merge 2013-09-06 17:10:02 -07:00
Jonathan Gibbons
f607953eb8 8024434: problem running javadoc tests in samevm mode on Windows
Reviewed-by: darcy
2013-09-06 15:31:59 -07:00
Lana Steuck
f8f8a3aa45 Merge 2013-09-06 14:20:49 -07:00
Chris Hegarty
0983a5be41 Merge 2013-09-06 10:05:08 +01:00
Vicente Romero
26758f0ffd 8024039: javac, previous solution for JDK-8022186 was incorrect
Reviewed-by: jjg
2013-09-06 09:53:24 +01:00
Bhavesh Patel
9c6d420370 8023608: method grouping tabs folding issue
Reviewed-by: jjg
2013-09-05 16:35:47 -07:00
Christine Lu
16c7de0027 Added tag jdk8-b106 for changeset fa7b69611589 2013-09-05 02:46:21 -07:00
Andreas Lundblad
4bf1e0d989 8023974: Drop 'implements Completer' and 'implements SourceCompleter' from ClassReader resp. JavaCompiler
Reviewed-by: jjg, jfranck
2013-09-05 11:27:27 +02:00
Jonathan Gibbons
7da0f59aec 8024288: javadoc generated-by comment should always be present
Reviewed-by: bpatel
2013-09-04 14:44:05 -07:00
Vicente Romero
d28e08b529 8008275: javac.Main should be @Supported
Reviewed-by: jjg
2013-09-04 11:53:09 +01:00
Maurizio Cimadamore
4cc7a55aab 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
Reviewed-by: jjg, vromero
2013-09-04 00:01:05 +01:00
Vicente Romero
cab6b226ff 8023545: Misleading error message when using diamond operator with private constructor
Reviewed-by: jjg
2013-09-03 23:41:37 +01:00
Maurizio Cimadamore
06caeea3d6 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
Reviewed-by: jjg, vromero
2013-09-03 23:31:33 +01:00