stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,978 Commits 2 Branches 0 Tags 1.2 GiB
11da417a28
Commit Graph

1542 Commits

Author SHA1 Message Date
Srikanth Adayapalam
5de84c2836 8043741: VerifyError due to missing checkcast 
Proto-type is not set correctly for NULLCHK synthetic trees

Reviewed-by: mcimadamore
 2015-01-09 15:49:42 +00:00
Srikanth Adayapalam
0eb55d78b6 8066871: java.lang.VerifyError: Bad local variable type - local final String 
BaseType() erroneously called on MethodResultInfo causes lack of constant type info

Reviewed-by: jlahoda, mcimadamore
 2015-01-09 15:48:09 +00:00
Sonali Goel
274f997aee 8058373: Group 10a: golden files for tests in tools/javac dir 
Reviewed-by: jjg, darcy
 2015-01-08 22:01:20 -08:00
Maurizio Cimadamore
56a33e4541 8058542: Devise scheme for better diagnostic creation 
Add support for generating (at build-time) an enum-like class containing all javac diagnostics, which allows for safe diagnostic creation.

Reviewed-by: jlahoda, jjg, vromero, erikj, jfranck
 2015-01-08 14:43:05 +00:00
Joe Darcy
5cb7065612 8068639: Make certain annotation classfile warnings opt-in 
Reviewed-by: jjg
 2015-01-07 17:06:47 -08:00
Jonathan Gibbons
e6ea1f0ff8 8059977: StandardJavaFileManager should support java.nio.file.Path 
Reviewed-by: jlahoda
 2015-01-06 14:51:10 -08:00
Maurizio Cimadamore
75b2a03bf9 8067883: Javac misses some opportunities for diagnostic simplification 
Javac always report full inference diagnostic, even when message does not mention inference variables.

Reviewed-by: jlahoda
 2015-01-06 15:46:41 +00:00
Vicente Romero
f6ed87ed5a 8064857: javac generates LVT entry with length 0 for local variable 
Reviewed-by: mcimadamore, jjg
 2015-01-05 17:35:48 -08:00
Sonali Goel
11b1d2cdad 8054689: Split large SJavac.java test source into multiple files 
Reviewed-by: jjg, jfranck
 2014-12-24 11:17:51 -08:00
Maurizio Cimadamore
c269c9451b 8066974: Compiler doesn't infer method's generic type information in lambda body 
Add loghic to avoid post-inference triggers on temporarty AST types

Reviewed-by: jlahoda, vromero
 2014-12-18 13:21:44 +00:00
Maurizio Cimadamore
41070244c9 8067792: Javac crashes in finder mode with nested implicit lambdas 
Revert tree changes occurred in Attr before running the analyzer

Reviewed-by: jlahoda
 2014-12-17 16:47:56 +00:00
Jan Lahoda
627ce960f5 8067422: Lambda method names are unnecessarily unstable 
Lambda method numbers are now assigned per class for non-serializable lambdas.

Reviewed-by: mcimadamore, rfield
 2014-12-17 12:49:57 +01:00
Maurizio Cimadamore
eb3798a14a 8067663: Add bugId to tests that have been modified as part of JDK-8064365 
Add missing bug id to modified tests

Reviewed-by: jlahoda
 2014-12-16 13:44:22 +00:00
Maurizio Cimadamore
3076062240 8064365: Better support for finder capabilities in target-typing context 
Add new framework to allow for easy creation of finder-like capabilities.

Reviewed-by: jjg, jlahoda
 2014-12-12 18:07:24 +00:00
Andrei Eremeev
282c943241 8065360: Implement a test that checks possibilty of class members to be imported 
Reviewed-by: jlahoda, anazarov
 2014-12-10 21:45:39 +02:00
Maurizio Cimadamore
a800908e25 8067001: DetectMutableStaticFields fails after modular images push 
Ignore JRTIndex.sharedInstance

Reviewed-by: jlahoda
 2014-12-09 16:09:07 +00:00
Andrei Eremeev
400505a1f2 8066961: NegativeCyclicDependencyTest.java fails on Windows 
Normalizing line endings to '\n'.

Reviewed-by: jlahoda
 2014-12-09 11:45:38 +01:00
Andrei Eremeev
ea81e1bc1f 8064794: Implement negative tests for cyclic dependencies in import statements 
Reviewed-by: jlahoda, anazarov
 2014-12-09 01:06:11 +02:00
Jan Lahoda
cf476e9302 8066902: JavacParserTest fails on Windows 
Normalizing line endings to '\n'.

Reviewed-by: jjg, ksrini
 2014-12-08 21:26:04 +01:00
Jan Lahoda
59b3453845 8061549: Disallow _ as a one-character identifier 
Underscore is no longer a one-charater identifier with -source 9

Reviewed-by: mcimadamore, jjg
 2014-12-08 18:02:07 +01:00
Jan Lahoda
113babff27 8065753: javac crashing on a html-like file 
Avoiding special-case in error recovery for bad token on position 0.

Reviewed-by: jjg
 2014-12-08 11:50:19 +01:00
Jonathan Gibbons
78fd11386c 8066737: langtools/test/tools/javac/processing/6348193/T6348193.java fails 
Reviewed-by: darcy
 2014-12-04 19:09:29 -08:00
Chris Hegarty
189df3ac57 Merge 2014-12-03 19:28:40 +00:00
Chris Hegarty
8bc2b3ff3a 8049367: Modular Run-Time Images 
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Bradford Wetmore <bradford.wetmore@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: James Laskey <james.laskey@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jlahoda, ksrini
 2014-12-03 14:25:46 +00:00
Jan Lahoda
d739446063 7101822: Compiling depends on order of imports 
7177813: Static import to local nested class fails

MemberEnter overhaul - TypeEnter is split out of MemberEnter; the TypeEnter consists of several Phases which ensure actions are done in the correct order.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jfranck, aeremeev
 2014-12-03 13:46:12 +01:00
Maurizio Cimadamore
02df6a4564 8065986: Compiler fails to NullPointerException when calling super with Object<>() 
Missing POLY kind selector on recursive constructor calls with poly arguments

Reviewed-by: vromero
 2014-11-28 11:45:56 +00:00
Robert Field
634c33938c 8058112: Invalid BootstrapMethod for constructor/method reference 
Bridge method references with functional interface method parameters of intersection type

Reviewed-by: vromero, dlsmith
 2014-11-24 14:52:46 -08:00
Jan Lahoda
26298f1124 8032211: Don't issue deprecation warnings on import statements 
6598104: javac should not warn about imports of deprecated classes

Suppressing the deprecation warnings when importing a deprecated element (deprecations in import qualifier will be produced).

Reviewed-by: darcy, jjg, mcimadamore
 2014-11-24 16:02:35 +01:00
Eric McCorkle
590188542e 8065132: Parameter annotations not updated when synthetic parameters are prepended 
Cause javac to add synthetic parameters to Runtime[In]VisibleParameterAnnotations attributes

Reviewed-by: jjg, jfranck
 2014-11-21 16:36:39 -05:00
Jonathan Gibbons
bdf693fcc5 8061876: replace java.io.File with java.nio.file.Path (again) 
Reviewed-by: ksrini, jlahoda
 2014-11-21 10:38:43 -08:00
Joel Borggrén-Franck
8bf55955df 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass 
Reviewed-by: jlahoda, vromero
 2014-11-21 12:36:21 +01:00
Jonathan Gibbons
56e39629eb 8065054: Some tests have junk before the legal header 
Reviewed-by: darcy
 2014-11-20 14:23:31 -08:00
Vicente Romero
60113dc1ba 8063052: Inference chokes on wildcard derived from method reference 
Reviewed-by: mcimadamore
 2014-11-20 14:05:39 -08:00
Jonathan Gibbons
6bfd41fed8 8058445: Javac throws exception when displaying info 
Reviewed-by: vromero, jfranck
 2014-11-20 11:00:29 -08:00
Vicente Romero
418c9789d6 8059921: Missing compile error in Java 8 mode for Interface.super.field access 
Reviewed-by: mcimadamore, jlahoda
 2014-11-20 09:43:13 -08:00
Jan Lahoda
a2b0a2413e 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources 
Allowing final variables as operands to try-with-resources; also reviewed by Sergei Pikalev.

Reviewed-by: darcy, mcimadamore, vromero
 2014-11-19 13:46:04 +01:00
Maurizio Cimadamore
5bb86103a9 8064803: Javac erroneously uses instantiated signatures when merging abstract most-specific methods 
Wrong method type used in AmbiguousError.mergeAbstracts

Reviewed-by: jlahoda
 2014-11-17 23:41:56 +00:00
Jan Lahoda
e158f32141 8062747: Compiler error when anonymous class uses method with parametrized exception 
When inferring lambda's thrown types, avoid tracking variables that are not under the lambda to avoid crashes.

Reviewed-by: vromero
 2014-11-14 11:58:28 +01:00
Jan Lahoda
b136af5563 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes 
When calling dupUnshared on a shared scope, make sure the result does not contain Symbols that don't belong to the scope that is being dupUnshared.

Reviewed-by: mcimadamore
 2014-11-12 19:05:17 +01:00
Andrei Eremeev
9130b22f3f 8042931: Implement classfile tests for EnclosingMethod attribute 
Reviewed-by: jjg, shurailine, anazarov
 2014-11-12 15:16:35 +02:00
Maurizio Cimadamore
ed9c1bb743 8064464: regression with type inference of conditional expression 
Bad classification of conditional leads to spurious error

Reviewed-by: jlahoda
 2014-11-12 12:41:32 +00:00
Joel Borggrén-Franck
991885e85d 8060448: ArrayIndexOutOfBoundsException with annotation processing printout of empty line 
Reviewed-by: jlahoda
 2014-10-24 10:08:51 +02:00
Jonathan Gibbons
de2b97f133 8063145: ToolBox should support extracting classes from a JavaFileManager/Location 
Reviewed-by: ksrini
 2014-11-07 14:51:35 -08:00
Eric McCorkle
ab1b9a9cf1 8029012: parameter_index for type annotation not updated after outer.this added 
Fix javac's handling of type annotations when synthetic parameters are added

Reviewed-by: jjg, mcimadamore
 2014-11-07 07:54:35 -05:00
Eric McCorkle
aca235b121 8062245: Test executes incorrect class 
Fix issue with test executing incorrect class, and trivial test failure linked to different subclasses of CharSequance.

Reviewed-by: jjg
 2014-11-06 17:39:57 -05:00
Maurizio Cimadamore
87d664f4f0 8062977: Inference: NullPointerException during bound incorporation 
Bogus Types.asSuper call on array type symbol

Reviewed-by: vromero
 2014-11-06 14:33:22 +00:00
Maurizio Cimadamore
ded3a562b9 6987475: Order of declarations affects whether abstract method considered overridden 
Types.implementation erroneously returns first matching method in hierarchy.

Reviewed-by: vromero
 2014-11-06 14:31:56 +00:00
Jonathan Gibbons
c4f3406133 8063074: test/tools/javac/plugin/showType/Test.java fails on Windows 
Reviewed-by: ksrini
 2014-11-05 19:48:42 -08:00
Jonathan Gibbons
a75d2dbd39 8062676: Tests which leak lots of file managers should be fixed (group 2) 
Reviewed-by: darcy
 2014-11-05 19:12:45 -08:00
Jonathan Gibbons
b96daffd2e 8063039: incorrect message reference or broken message file 
Reviewed-by: ksrini
 2014-11-05 19:09:09 -08:00
Eric McCorkle
0acac5a3d5 8035259: javac, incorrect shadowing of classes vs type parameters 
Cause javac to look at type variables first when resolving names in an extends/implements list

Reviewed-by: mcimadamore, jlahoda
 2014-11-05 08:37:04 -05:00
Sonali Goel
4ca3a232d1 8062314: Update tools/javac/plugin/showtype/Test.java to use ToolBox.java 
Reviewed-by: jjg
 2014-11-04 13:21:25 -08:00
Andreas Lundblad
4a3d559ffb 8062740: Since changeset 2686:030080f03e4f test/tools/sjavac/DependencyCollection.java does no longer compile 
Added throws IOException to main method.

Reviewed-by: jjg
 2014-11-04 09:04:13 +01:00
Sonali Goel
35b29e7662 8062336: Revert tools/javap/T6729471.java to original test code 
Reviewed-by: jjg
 2014-10-30 15:21:42 -07:00
Jonathan Gibbons
342df9829a 8062514: Update ToolTester tests to close file manager 
Reviewed-by: darcy
 2014-10-29 19:07:34 -07:00
Jonathan Gibbons
8bd23f1681 8062348: langtools tests should close file manager (group 1) 
Reviewed-by: darcy
 2014-10-29 17:25:23 -07:00
Liam Miller-Cushon
08336b39dd 8059453: javac crashes with -Xjcov and union types 
Reviewed-by: jlahoda, vromero
 2014-09-25 14:38:29 -07:00
Sonali Goel
0bfa3c5036 8059423: Replace references for rt.jar by temp.jar 
Reviewed-by: jjg
 2014-10-27 10:43:09 -07:00
Joel Borggrén-Franck
0149333fb8 8054448: (ann) Cannot reference field of inner class in an anonymous class 
Reviewed-by: jlahoda, mcimadamore
 2014-10-24 08:34:51 +02:00
Maurizio Cimadamore
535317c6f8 8061778: Wrong LineNumberTable for default constructors 
Synthetic empty blocks generated by Lower are erroneously picked up by Gen

Reviewed-by: jjg
 2014-10-24 10:54:04 +01:00
Vicente Romero
96941c8951 8057800: Method reference with generic type creates NPE when compiling 
Reviewed-by: mcimadamore, dlsmith
 2014-10-23 10:42:44 -07:00
Jonathan Gibbons
5074c6ed36 8061723: 8060056 breaks tests on Windows 
Reviewed-by: darcy
 2014-10-21 17:50:13 -07:00
Jonathan Gibbons
0e0e189bf6 8060056: replace java.io.File with java.nio.file.Path 
Reviewed-by: ksrini, jlahoda
 2014-10-21 13:08:20 -07:00
Eric McCorkle
8244cae54a 8054457: Refactor Symbol kinds from small ints to an enum 
Replace bitmap logic in symbol.kind and pkind with an enum-based API

Reviewed-by: mcimadamore, jjg
 2014-10-21 09:01:51 -04:00
Jonathan Gibbons
cf1a634000 8040131: Implement classfile test for LineNumberTable attribute 
Reviewed-by: jjg, shurailine
 2014-10-16 14:31:37 -07:00
Maurizio Cimadamore
2756ed20d7 8058511: StackOverflowError at com.sun.tools.javac.code.Types.lub 
Lub crashes when handling typevar with array bound

Reviewed-by: vromero, dlsmith
 2014-10-14 12:01:05 +01:00
Maurizio Cimadamore
8f96799dd5 8058199: Code generation problem with javac skipping a checkcast instruction 
TransTypes sometimes ignores inferred signatures when emitting synthetic casts

Reviewed-by: vromero
 2014-10-14 12:00:39 +01:00
Paul Govereau
8cc03657e9 8060249: Backout fix for JDK-8058243 
Reviewed-by: vromero
 2014-10-13 17:09:12 -04:00
Paul Govereau
ef05cafd6b 8060234: Fix push for JDK-8058243 
Reviewed-by: jjg, vromero
 2014-10-13 12:12:06 -04:00
Jan Lahoda
1eb03e49bf 8054956: Javac reports wrong error offset for unknown identifier of annotation element/value pair 
When reporting an error about unresolvable annotation attribute, use the position of the explicit left-hand-side of the assignment if available, otherwise use the position of the right-hand-side.

Reviewed-by: jfranck
 2014-10-13 17:22:47 +02:00
Sonali Goel
a7b8ca6209 8058410: Group 10b: golden files for tests in tools/javac dir 
Reviewed-by: jjg
 2014-10-10 14:41:50 -07:00
Jan Lahoda
e95348b58e 8057652: Request to improve error messages for labeled declarations 
Parse labeled statements as block statements to improve error recovery for labeled declarations; related cleanup.

Reviewed-by: jjg
 2014-10-09 10:08:52 +02:00
Andreas Lundblad
0545e4b847 8059349: Public API scanning should be implemented in the form of a TaskListener 
Replaces JavaCompilerWithDeps with a TaskListener.

Reviewed-by: jfranck
 2014-10-07 21:21:42 +02:00
Andreas Lundblad
96074068b8 8056258: Analysis of public API does not take super classes into account 
8048609: simplify sjavac dependence on javac dependency gathering

Replaces Attr-/ResolveWithDeps with TaskListeners

Reviewed-by: jfranck, ohrstrom
 2014-10-07 21:15:10 +02:00
Robert Field
e55ca9fc58 8056051: int[]::clone causes "java.lang.NoClassDefFoundError: Array" 
Reviewed-by: mcimadamore, vromero
 2014-10-04 10:13:11 -07:00
Sonali Goel
1f9a38f175 8055783: Group 9e: golden files for tests in tools/javac dir 
Reviewed-by: jjg, mcimadamore
 2014-10-01 14:15:40 -07:00
Vicente Romero
97309123c1 8058708: java.lang.AssertionError compiling source code 
Reviewed-by: jjg
 2014-09-25 17:09:23 -07:00
Neil Toda
9fbf466c3f 8050117: add to javac test Versions.java tests that show correct operation for source/target options pre 1.9 
Reviewed-by: jjg
 2014-09-25 13:54:45 -07:00
Eric McCorkle
b4401ebed9 8048614: Add TypeMetadata to contain type annotations and other type information 
Implement general framework for metadata on types

Reviewed-by: mcimadamore
 2014-09-22 17:09:33 -04:00
Jan Lahoda
c30ea9e1d2 8057794: Compiler Error when obtaining .class property 
Ensuring a non-null type and sym for illegal T.class to prevent downstream errors.

Reviewed-by: mcimadamore
 2014-09-22 14:55:14 +02:00
Sonali Goel
2700003cdb 8058755: Update tools/javadoc/6227454 to add head tag 
Reviewed-by: jjg
 2014-09-19 13:54:34 -07:00
Maurizio Cimadamore
ae97aeb0d9 8055963: Inference failure with nested invocation 
Revise heuristics to force eager instantiation of return inference vars

Reviewed-by: vromero
 2014-09-15 12:43:35 +01:00
Sonali Goel
79efb2b9d8 8055080: Group 9d: golden files for tests in tools/javac dir 
Reviewed-by: jjg, mcimadamore, jlahoda
 2014-09-12 17:05:18 -07:00
Paul Govereau
d65d28d993 8054210: NullPointerException when compiling specific code 
Reviewed-by: vromero, jlahoda
 2014-09-09 12:16:25 -04:00
Paul Govereau
a37e9881b2 8055500: fix for 8030046 is incorrect 
Reviewed-by: jjg, ksrini
 2014-09-09 11:55:47 -04:00
Jan Lahoda
2beda23cf8 8057753: Test langtools/test/tools/javac/NoClass.java is failing when run together with langtools/test/tools/javac/DuplicateImport.java 
Removing javac/NoClass test, as it is superseded by javac/importChecks/InvalidImportsNoClasses.java

Reviewed-by: jfranck
 2014-09-08 15:51:29 +02:00
Maurizio Cimadamore
a9061c2918 8055514: Wrong, confusing error when non-static varargs referenced in static context 
Improved heuristics in MethodResolutionPhase.mergeResults()

Reviewed-by: vromero
 2014-09-08 14:16:33 +01:00
Joel Borggrén-Franck
053a9d56cd 8056021: checkin for JDK-8027262 breaks Checker Framework 
Reviewed-by: jjg, mcimadamore
 2014-09-08 13:11:28 +02:00
Jan Lahoda
f211cac0cd 8056984: Exception in compiler: java.lang.AssertionError: isSubClass T 
Must use type variable's captured bound as a method receiver, instead of the type variable itself, while checking if deferred attribution is needed.

Reviewed-by: mcimadamore, vromero
 2014-09-08 10:50:59 +02:00
Jan Lahoda
49469c49d0 8056014: Type inference may be skipped for a complex receiver generic method in a parameter position 
When checking if deferred attribution is needed for a chain of methods, stop on any method that returns any type variable, as the rest of analysis cannot use the correct type.

Reviewed-by: mcimadamore, vromero
 2014-09-08 10:48:18 +02:00
Sonali Goel
f064e2b028 8055079: Group 9c: golden files for tests in tools/javac dir 
Reviewed-by: jjg
 2014-09-05 16:51:39 -07:00
Sonali Goel
170f8549b4 8055075: Group 9b: golden files for tests in tools/javac dir 
Reviewed-by: jjg
 2014-09-05 16:43:00 -07:00
Sonali Goel
15420bd193 8055996: Remove @ignore from tools/javac/T6725036.java 
Reviewed-by: jjg
 2014-09-04 16:52:40 -07:00
Jan Lahoda
6cac1178ba 8047675: tools/javac/defaultMethods/Assertions.java fails if run with -enableassertions (-ea) 
Using ToolBox to start new Java processes, to avoid passing default VM options to the newly started process.

Reviewed-by: jjg
 2014-09-04 08:49:20 +02:00
Jan Lahoda
83abeb739b 8054563: Update RunCodingRules.java for source code reorg 
Tests RunCodingRules and MessageInfo fixed to work in the new source code structure.

Reviewed-by: jjg
 2014-09-04 08:48:29 +02:00
Jonathan Gibbons
f0b4f3d282 8038414: Constant pool's strings are not escaped properly 
Reviewed-by: jjg, mcimadamore, ksrini
 2014-09-03 14:19:39 -07:00
Jonathan Gibbons
3b029e1995 8034861: Incorrect format and indentation of InnerClasses section 
Reviewed-by: jjg, ksrini, mcimadamore, lagergren
 2014-09-03 14:06:25 -07:00
Alexander Zuev
f4e40eeff6 8044597: Request to update tools/javap/T4501661.java to add test for package option 
Reviewed-by: jjg
 2014-09-03 19:22:16 +04:00
Sonali Goel
f4dc4013f0 8055074: Group 9a: golden files for tests in tools/javac dir 
Reviewed-by: jjg
 2014-08-29 00:42:42 -07:00
Sonali Goel
e2312f606b 8049126: golden files for annotations test in tools/java dir 
Reviewed-by: jjg
 2014-08-28 23:42:16 -07:00
Joe Darcy
d66c4567ee 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed 
Reviewed-by: ksrini
 2014-08-28 11:29:34 -07:00
Andreas Lundblad
43eb10bcb8 8054500: Refactor sjavac Main class into ClientMain and ServerMain 
Restructured Main into ClientMain and ServerMain

Reviewed-by: jfranck
 2014-08-28 17:38:40 +02:00
Jonathan Gibbons
08e122f2cb 8044859: javac duplicates option processing when using Compiler API 
Reviewed-by: mcimadamore, vromero, jlahoda
 2014-08-22 16:28:16 -07:00
Kumar Srinivasan
9867d883ad 8055501: [javac] ignore test/tools/javac/Paths/AbsolutePathTest.java 
Reviewed-by: jjg
 2014-08-19 15:34:01 -07:00
Chris Hegarty
2d81f9c851 Merge 2014-08-18 10:59:44 +01:00
Chris Hegarty
2b80c4715f 8054834: Modular Source Code 
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Reviewed-by: alanb, chegar, ihse, mduigou
 2014-08-17 15:52:32 +01:00
Paul Govereau
7cb1497762 8054556: javac should report the error for default usage as the primary error 
Reviewed-by: jjg
 2014-08-15 11:02:14 -04:00
Jonathan Gibbons
1cf35244f6 8055076: fix test failures in classfile tests 
Reviewed-by: darcy
 2014-08-13 15:47:58 -07:00
Eric McCorkle
52b5861793 Merge 2014-08-13 21:58:29 +00:00
Jonathan Gibbons
33e6564a6b 8050429: Update/cleanup ToolBox 
Reviewed-by: vromero
 2014-08-13 13:20:31 -07:00
Andreas Lundblad
ce4c456820 8048457: Sjavac should not use portfiles, sockets, etc if background=false 
8044131: Restructure client / server protocol code

Changes protocol code to use Object input/output streams. Avoids spawning server if background=false. Refactors idleness checks, pooling and port file monitoring.

Reviewed-by: jjg, jfranck
 2014-08-13 14:44:59 +02:00
Sonali Goel
14e6aa6b9e 8049130: Group 8d - golden files for annotations test in tools/java dir 
Reviewed-by: jjg
 2014-08-12 17:48:30 -07:00
Sonali Goel
32b768c531 8049129: Group 8c - golden files for annotations test in tools/java dir 
Reviewed-by: jjg
 2014-08-12 17:39:56 -07:00
Sonali Goel
40f4caa8d0 8049127: Group 8b - golden files for annotations test in tools/java dir 
Reviewed-by: jjg
 2014-08-12 17:31:31 -07:00
Sonali Goel
bf789b2a48 8054964: Add a test for invalid package annotations 
Reviewed-by: jjg
 2014-08-12 16:41:05 -07:00
Andrei Eremeev
8740c99fbd 8042251: Implement classfile tests for InnerClasses attribute 
Reviewed-by: jjg, anazarov, shurailine
 2014-08-12 13:24:40 +04:00
Fredrik Öhrström
c110d6437f 8054465: Add --permit-artifact=bar to sjavac 
Add --permit-artifact=bar to white-list files that have been written to the destination directory and that sjavac should not delete.

Reviewed-by: jjg, alundblad
 2014-08-09 00:56:29 +02:00
Fredrik Öhrström
c8256e4d27 8054474: Add --state-dir=bar to sjavac 
Add --state-dir=bar to sjavac to control where sjavac stores the javac_state file.

Reviewed-by: jjg, alundblad
 2014-08-08 21:26:23 +02:00
Fredrik Öhrström
ce6154a2fa 8054461: Add @file support to sjavac 
Add @file support to sjavac commandline.

Reviewed-by: jjg, alundblad
 2014-08-08 20:47:24 +02:00
Jan Lahoda
66ea31ef63 8043643: Add an crules analyzer avoiding string concatenation in messages of Assert checks 
Generalizing the crules infrastructure, adding a new analyzer to check String concatenation in Assert calls.

Reviewed-by: jjg, vromero
 2014-08-01 11:09:40 -07:00
Alexander Zuev
5284120119 8047072: javap OOM on fuzzed classfile 
Reviewed-by: jjg
 2014-07-30 20:31:39 +04:00
Maurizio Cimadamore
560c7c91fe 8051958: Cannot assign a value to final variable in lambda 
Remove Attr.owner and refactor code for detecting forward field references

Reviewed-by: vromero
 2014-07-29 15:31:57 -07:00
Andrey Nazarov
0f64892089 8050979: Provide javadoc for "framework" classes in langtools tests 
Reviewed-by: jjg
 2014-07-24 15:12:48 -07:00
Andrey Nazarov
0308bdc9d1 8050319: LocalVariableTestBase has unexpected dependency on LocalVariableTableTest 
Reviewed-by: jjg, ksrini
 2014-07-23 09:19:23 -07:00
Sonali Goel
a047a4f1ec 8048837: .out files for generics tests in tools/javac dir - part 3 
Reviewed-by: jjg
 2014-07-17 11:22:47 -07:00
Sonali Goel
5324b04fde 8048836: .out files for generics tests in tools/javac dir 
Reviewed-by: jjg
 2014-07-17 11:14:39 -07:00
Mandy Chung
acacb0481e 8050804: (jdeps) Recommend supported API to replace use of JDK internal API 
Reviewed-by: dfuchs
 2014-07-17 10:17:58 -07:00
Sonali Goel
541591d644 8048833: .out files for generics tests in tools/javac dir 
Reviewed-by: jjg
 2014-07-17 09:56:07 -07:00
Joe Darcy
dee421ed14 8050430: Provided new utility visitors supporting SourceVersion.RELEASE_9 
Reviewed-by: jjg
 2014-07-17 09:47:25 -07:00
Vicente Romero
aa91971a3c 8051004: javac, incorrect bug id in tests for JDK-8050386 
Reviewed-by: mcimadamore
 2014-07-17 10:55:50 -04:00
Vicente Romero
3e002a08e6 8050386: javac, follow-up of fix for JDK-8049305 
Reviewed-by: mcimadamore
 2014-07-16 10:47:56 -04:00
Vicente Romero
6edca1025f 8050283: fix for JDK-8049305 should be removed 
Reviewed-by: jjg
 2014-07-14 16:59:25 -04:00
Jonathan Gibbons
6ec02aa50b 8046824: class SJavacTestUtil and *Wrapper are redundant and should be removed 
Reviewed-by: ksrini
 2014-07-14 11:46:31 -07:00
Vicente Romero
1e87b47b2a 8049305: Verification error due to a bad stackmap frame generated by javac 
Reviewed-by: mcimadamore
 2014-07-14 13:36:30 -04:00
Jan Lahoda
603d592a91 8049948: Restore NonDirectSuper.java test 
Reviewed-by: jjg
 2014-07-14 12:03:08 +02:00
Jan Lahoda
eb1f1c05ed 8048805: Request to investigate and update lexer error recovery in javac 
8046620: Further investigation needed for few error messages for negative unicode tests in langtools regression ws
8048803: javac should report complete character code in the error messages

Improving error reporting and recovery in the lexer

Co-authored-by: Sonali Goel <sonali.goel@oracle.com>
Reviewed-by: jjg, mcimadamore
 2014-07-14 12:02:58 +02:00
Jonathan Gibbons
92884a5338 8050106: JavaCompiler relies on inappropriate result from comparison 
Reviewed-by: darcy
 2014-07-12 07:32:28 -07:00
Jonathan Gibbons
84e4fca0c8 8048806: Javadoc errors out on some valid HTML tags 
Reviewed-by: bpatel
 2014-07-11 18:51:32 -07:00
Neil Toda
f7234f052c 8030610: replace test/tools/javac/versions/check.sh 
Reviewed-by: jjg
 2014-07-10 16:03:45 -07:00
Neil Toda
b4b2f994ca 8011044: Remove support for 1.5 and earlier source and target options 
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: darcy, jjg
 2014-07-10 13:57:27 -07:00
Vicente Romero
5916a0adfa 8033483: Should ignore nested lambda bodies during overload resolution 
Reviewed-by: mcimadamore, dlsmith
 2014-07-09 10:49:32 -04:00
Jan Lahoda
0067b70725 8031569: Refactor javac scope implementation to enable lazy imports 
Introducing an internal API for Scope; rewriting ImportScopes to extend CompoundScopes.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jjg, jfranck
 2014-07-09 16:32:05 +02:00
Mandy Chung
c2f98fba15 8029548: (jdeps) use @jdk.Exported to determine supported vs JDK internal API 
8031092: jdeps does not recognize --help option
8048063: (jdeps) Add filtering capability

Reviewed-by: alanb, dfuchs
 2014-07-08 18:26:34 -07:00
Maurizio Cimadamore
15cfa4aac9 8043926: javac, code valid in 7 is not compiling for 8 
Type-containment doesn't handle inference variables correctly

Reviewed-by: vromero, dlsmith
 2014-07-08 15:42:04 +01:00
Jan Lahoda
3c5b32658b 8042239: javac: TreeMaker.Type(Type t) does not handle UnionClassType 
Enhancing TreeMaker.Type(Type t) with support for UnionClassType and IntersectionClassType.

Co-authored-by: Robert Field <robert.field@oracle.com>
Reviewed-by: vromero, rfield
 2014-07-08 15:13:16 +02:00
Sonali Goel
5437ec7e74 8044080: .out files for unicode, implicitThis and importChecks tests in tools/javac dir 
Reviewed-by: jjg
 2014-07-07 13:39:31 -07:00
Sonali Goel
9c09973b5a 8049491: Remove three auxilary files in tools/javac/enum dir 
Reviewed-by: jjg
 2014-07-07 12:55:00 -07:00
Sonali Goel
3ecb57ccc0 8046618: .out files for enum tests in tools/javac/dir 
Reviewed-by: jjg
 2014-07-07 12:44:20 -07:00
Sonali Goel
0718a280b0 8046635: .out files for enum tests in tools/javac/dir 
Reviewed-by: jjg
 2014-07-07 12:36:45 -07:00
Vicente Romero
72d5723212 8049075: javac, wildcards and generic vararg method invocation not accepted 
Reviewed-by: mcimadamore
 2014-07-04 16:34:44 +01:00
Jonathan Gibbons
12b653bb02 8042261: Implement classfile tests for Deprecated attribute 
Reviewed-by: jjg, anazarov, shurailine
 2014-07-04 10:52:22 +01:00
Sonali Goel
50e8d8b28d 8049284: Missing bug id in test/tools/javac/varargs/warning/Warn* 
Reviewed-by: darcy
 2014-07-03 15:48:23 -07:00
Sonali Goel
2caa264885 8046770: .out files for assert, boxing, and overload tests in tools/javac dir 
Reviewed-by: jjg
 2014-07-02 14:27:10 -07:00
Sonali Goel
9343037434 8044864: .out files for enum tests in tools/javac dir - part 1 
Reviewed-by: jjg
 2014-07-02 13:29:58 -07:00
Sonali Goel
8244fe0c5c 8044236: create .out files for DefiniteAssignment tests in tools/javac dir 
Reviewed-by: jjg, vromero
 2014-07-02 12:04:04 -07:00
Jan Lahoda
670eff1ee6 6707032: Division by zero warning not suppressed properly in some cases 
Delay reporting of the division by zero warning until annotations are resolved, so that @SuppressWarnings works correctly.

Reviewed-by: vromero
 2014-06-30 17:08:06 +02:00
Andreas Lundblad
8baafcf7ef 8048594: The sjavac client/server protocol should be hidden behind an interface 
Reviewed-by: jfranck
 2014-06-17 14:01:27 +02:00
Vicente Romero
ce0935812b 8047719: Incorrect LVT in switch statement 
Reviewed-by: jjg, jlahoda
 2014-06-27 20:32:12 +01:00
Sonali Goel
2f5e083cee 8048293: update tools/javadoc/6227454 to have missing <head> tag 
Reviewed-by: jjg, bpatel
 2014-06-26 16:39:14 -07:00
Jonathan Gibbons
47c543e53b 8007307: DPrinter: support the DocTree API 
Reviewed-by: mcimadamore
 2014-06-26 11:45:51 -07:00
Jonathan Gibbons
bd97e7d5ec 8047183: JDK build fails with sjavac enabled 
Reviewed-by: mcimadamore
 2014-06-26 11:31:59 -07:00
Paul Govereau
5b1596bc25 8042345: getDocComment fails for doc comments on PackageElement found in package-info.java 
Reviewed-by: jjg
 2014-06-26 13:48:58 -04:00
Robert Field
30f70a0e1d 8048121: javac complex method references: revamp and simplify 
8038776: VerifyError when running successfully compiled java class

Add tests missing from the push of 8037404

Reviewed-by: dlsmith, vromero
 2014-06-25 11:22:27 -07:00
Joe Darcy
b963c0bc59 7196160: Project Coin: allow @SafeVarargs on private methods 
Reviewed-by: jjg
 2014-06-24 10:51:00 -07:00
Robert Field
802429b65f 8037404: javac NPE or VerifyError for code with constructor reference of inner class 
8047341: lambda reference to inner class in base class causes LambdaConversionException
8044748: JVM cannot access constructor though ::new reference although can call it directly
8044737: Lambda: NPE while obtaining method reference through lambda expression

Revamp and simplify handling of complex method references

Reviewed-by: dlsmith, vromero
 2014-06-24 00:43:46 -07:00
Sonali Goel
ae6f87cc24 8047300: update tools/javadoc/6227454 test for missing <DOCTYPE> tags 
Reviewed-by: jjg, ksrini
 2014-06-20 13:26:24 -07:00
Vicente Romero
1ff4245739 8044546: Crash on faulty reduce/lambda 
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, dlsmith
 2014-06-20 20:36:54 +01:00
Robert Field
5fad815dec 8046060: Different results of floating point multiplication for lambda code block 
Propogate strictfp into lambda body

Reviewed-by: vromero, jlahoda
 2014-06-20 10:56:47 -07:00
Dan Smith
fe46aeabb0 8047407: Add test for JDK-8037385 
Reviewed-by: mcimadamore
 2014-06-20 11:42:16 -06:00
Dan Smith
06b8a7ac80 8034147: javac crashes with a NullPointerException during bounds checking 
Types.supertype should return Type.noType rather than null

Reviewed-by: vromero, mcimadamore
 2014-06-20 10:56:31 -06:00
Vicente Romero
d7c001dd04 8042759: Lambda returning implicitly-typed lambdas considered pertinent to applicability 
Reviewed-by: mcimadamore
 2014-06-19 23:52:33 +01:00
Jan Lahoda
9d852a54ef 8041648: do while loop that misses ending semicolon has wrong end position 
Ensure the end positions are meaningful even if statement's semicolon is missing.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
 2014-06-19 22:06:29 +02:00
Vicente Romero
5b199f3cb8 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface 
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
 2014-06-19 15:39:37 +01:00
Jan Lahoda
e6b9e34ebe 8046916: Type parameter annotations don't work with multiple type parameters 
When reading type variable's annotations out of the owner's type annotations, use the type variable's index in owner to exclude annotations belonging to other type variables.

Reviewed-by: jfranck, emc
 2014-06-18 10:44:16 +02:00
Vicente Romero
e4773094de 8036953: Fix timing of varargs access check, per JDK-8016205 
Reviewed-by: mcimadamore, dlsmith
 2014-06-17 17:33:01 +01:00
Paul Govereau
f2e2245e7b 8038975: Access control in enhanced for 
Reviewed-by: vromero, jlahoda
 2014-06-17 11:11:59 -04:00
Jonathan Gibbons
2613fffb87 8046369: sjavac should not use javac internal API for starting javac 
Reviewed-by: jfranck, alundblad, ohrstrom
 2014-06-16 11:30:31 -07:00
Andreas Lundblad
77fa3101ec 8042830: A recently added Xprefer test fails on Windows 
Test now accepts both / and \ as file separator.

Reviewed-by: mcimadamore
 2014-06-12 14:29:09 +02:00
Eric McCorkle
29e8b83b48 8043484: DPrinter does not compile 
Make DPrinter compile

Reviewed-by: jjg
 2014-06-12 11:32:23 -04:00
Paul Govereau
577b60e711 8027886: javac allows illegal receiver parameters 
8029042: Receiver parameter not supported on local class constructor

Reviewed-by: jfranck, jlahoda
 2014-06-11 12:49:10 -04:00
Dan Smith
3ea78c679c 8015101: Covariance of return type implied by upper bounding on type parameter is ignored 
Capture intersection supertypes before comparing their members

Reviewed-by: vromero
 2014-06-10 15:25:01 -06:00
Dan Smith
6e1ae5955e 8037385: constant pool errors with -target 1.7 and static default methods 
Add error check for static interface methods invoked from -source 7

Reviewed-by: vromero, mcimadamore
 2014-06-10 12:41:39 -06:00
Maurizio Cimadamore
dab523a752 8043725: javac fails with StackOverflowException 
Loose type comparison test should be protected against infinite recursion with fbounds

Reviewed-by: vromero
 2014-06-09 12:54:02 +01:00
Jan Lahoda
d71f75ae86 8033414: javac Plugin to receive notification (before and) after the compilation 
Introducing TaskEvent.Kind.COMPILATION, sending this event before and after compilation.

Co-authored-by: Joel Borggren-Franck <joel.franck@oracle.com>
Reviewed-by: jjg, jfranck
 2014-06-09 10:17:16 +02:00
Jonathan Gibbons
15853aca13 7026941: 199: path options ignored when reusing filemanager across tasks 
Reviewed-by: jlahoda, jfranck
 2014-06-08 15:02:34 -07:00
Andrei Eremeev
8aa391d4c9 8042451: Write tests for all possible kinds of type annotation 
Add new tests for type annotations to improve case coverage

Reviewed-by: jjg, emc, abuckley
 2014-06-06 16:08:46 -04:00
Eric McCorkle
8ff3cbd414 8027262: Determine location for type annotations earlier in compiler pipeline 
8027261: Single codepath for attaching annotations to symbols
8027258: Permit a single source annotation to generate multiple bytecode annotations
8027182: Incorrect annotation attributes for type annotations on constructor type parameters
8044010: TypeAnnotation attribute is not generated for repeatable annotation in type argument
8044009: TypeAnnotation attribute is not generated for repeatable annotation in nested types
8043974: TypeAnnotation attribute is not generated for repeatable annotation in lambda
8043669: Few of the ANNOT tests in JCK9 test suite fail with an AssertionError for exception_index
8042060: Type parameter annotations don't work with multiple type parameters
8037348: RuntimeInvisibleAnnotations should not be generated for type annotation on anonymous innerclass creation

Initial rearchitecting of type annotations frontend pipeline

Reviewed-by: jjg, jfranck, mcimadamore, jlahoda, wmdietl
 2014-06-06 16:00:59 -04:00
Jonathan Gibbons
a9bd96c90c 8046067: test/tools/javac/api/6410643/T6410643.java is broken 
Reviewed-by: darcy, ksrini
 2014-06-05 13:22:37 -07:00
Sonali Goel
887f81a738 8044072: Group 2: create .out files for OverrideChecks tests in tools/javac dir 
Reviewed-by: jjg
 2014-06-05 10:57:10 -07:00
Sonali Goel
d15c9840ed 8044064: Group 1: create .out files for cast and capture negative tests in tools/javac dir 
Reviewed-by: jjg
 2014-06-05 10:44:38 -07:00
Maurizio Cimadamore
cd68d10b6f 8043893: Inference doesn't report error on incompatible upper bounds 
Failure on type-equality check during incorporation doesn't trigger inference error

Reviewed-by: vromero
 2014-06-05 12:21:38 +01:00
Vicente Romero
09250abb84 8041713: Type inference of non-existent method references crashes the compiler 
Reviewed-by: mcimadamore
 2014-06-04 20:01:13 +01:00
Vicente Romero
45c3929ecb 8044487: Fix for 8042785 causes regression tests to fail with java.lang.VerifyError 
Reviewed-by: jjg, ksrini
 2014-06-02 22:36:40 +01:00
Vicente Romero
8447e4cf46 8042785: javac, bridge methods are not getting the flags from the original method 
Reviewed-by: jjg, jlahoda
 2014-05-30 18:21:05 +01:00
Jan Lahoda
2f910049e8 8031967: For some sources compiler compiles for ever 
Avoid creating DeferredTypes for method calls with method calls as receivers if the site can be determined reliably

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, vromero
 2014-05-30 12:54:16 +02:00
Vicente Romero
92e2e96714 8037937: javac: AssertionError during LVT generation, wrong variable ranges 
Reviewed-by: mcimadamore
 2014-05-29 15:28:01 +01:00
Stephane Epardaud
e0f4450825 8037934: Javac generates invalid signatures for local types 
Reviewed-by: vromero, rfield
 2014-05-28 21:47:30 +01:00
Dan Smith
2b4c40d39b 8044050: Move misplaced inference tests to test/tools/javac/generics/inference 
Reviewed-by: vromero
 2014-05-27 16:39:05 -06:00
Paul Govereau
0b1c40b161 8042741: Java 8 compiler throws NullPointerException depending location in source file 
Reviewed-by: vromero, jlahoda
 2014-05-27 22:26:53 +01:00
Paul Govereau
649331e00f 8041704: wrong error message when mixing lambda expression and inner class 
Reviewed-by: vromero
 2014-05-27 18:57:44 +01:00