Commit Graph

1723 Commits

Author SHA1 Message Date
Mandy Chung
5035f5b1d4 8068937: jdeps shows "not found" if target class has no reference other than its own package
Reviewed-by: alanb
2015-01-27 19:50:41 -08:00
Sonali Goel
a67e9f2d36 8068463: Group 10c: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2015-01-27 15:11:57 -08:00
Jan Lahoda
edc2052f33 8069254: Warning issued despite @SafeVarargs annotation on constructor
The Symbol created for diamond inference does not have annotations attached - need to look for @SafeVarargs on the underlying constructor's Symbol.

Reviewed-by: mcimadamore
2015-01-23 15:14:53 +01:00
Srikanth Adayapalam
25c0dd9958 8071310: Tests missing for checkin for JDK-8046977
Reviewed-by: jlahoda
2015-01-22 09:50:03 +01:00
Joel Borggrén-Franck
4b78cb3eb7 8070507: LambdaLambdaSerialized can fail in -agentvm mode
Reviewed-by: mcimadamore
2015-01-21 19:02:20 +01:00
Jan Lahoda
8944d18416 8069094: SuppressWarnings(\"deprecation\") not respected on default clause on annotation declarations
Properly deferring warnings that are reported during entering of annotation's default value.

Reviewed-by: mcimadamore
2015-01-20 12:00:25 +01:00
Srikanth Adayapalam
671f90ddc7 8052070: javac crashes when there are duplicated type parameters
Avoid eager completion of ClassSymbol while type parameters are being processed.

Reviewed-by: jlahoda, mcimadamore
2015-01-20 09:51:17 +01:00
Robert Field
6c9d4861a9 8068488: Facilitate extension of the javac parser -- missing modifier
Reviewed-by: jjg
2015-01-16 20:03:30 -08:00
Jan Lahoda
56c4de876e 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
Making sure enum's abstractness is resolved before writing InnerClasses entry about it.

Reviewed-by: mcimadamore
2015-01-16 14:47:25 +01:00
Maurizio Cimadamore
82db21e08d 8068995: Cleanup method reference lookup code
Simplify method reference code lookup and generate better/more uniform diagnostics

Reviewed-by: vromero
2015-01-15 13:58:11 +00:00
Jan Lahoda
1b90760ef4 8066843: Messager.printMessage cannot print multiple errors for same source position
Using a DiagnosticFlag to mark diagnostics that should be always printed even if multiple of them have the same source position.

Reviewed-by: darcy, jjg, mcimadamore
2015-01-13 19:13:42 +01:00
Srikanth Adayapalam
2b3c75aa36 8027888: javac wrongly allows annotations in array-typed class literals
Compiler incorrectly accepts type annotations on array-typed class literals.

Reviewed-by: jlahoda, jfranck
2015-01-13 10:36:41 +01:00
Srikanth Adayapalam
5cb253a2e9 8068254: Method reference uses wrong qualifying type
Generated code fails with IllegalAccessError due to compiler's mishandling of packageprivate classes in method reference expressions.

Reviewed-by: rfield, mcimadamore
2015-01-13 10:32:19 +01:00
Srikanth Adayapalam
33a3e1add3 8037546: javac -parameters does not emit parameter names for lambda expressions
MethodParameters attribute is missing for synthetic methods encoding lambda expressions.

Reviewed-by: rfield, mcimadamore
2015-01-13 10:25:24 +01:00
Srikanth Adayapalam
1be81e358c 8062358: ClassCastException in TransTypes.visitApply
Incorrect handling of subtype relations involving lower bounded wildcard causes ClassCastException

Reviewed-by: vromero, dlsmith
2015-01-13 10:17:25 +01:00
Jonathan Gibbons
01520ed2aa 8068759: ConstFoldTest fails on Windows
Reviewed-by: ksrini
2015-01-09 18:03:01 -08:00
Srikanth Adayapalam
4eb573aa81 8067914: Redundant type cast nodes in AST (follow up from JDK-8043741)
Workaround for redundant (but harmless) synthetic cast generated in TransTypes

Reviewed-by: mcimadamore
2015-01-09 15:51:20 +00:00
Srikanth Adayapalam
7e499fd15b 8067429: java.lang.VerifyError: Inconsistent stackmap frames at branch target
Bitset for alive variables contains info about variables out of range

Reviewed-by: mcimadamore
2015-01-09 15:50:22 +00:00
Srikanth Adayapalam
5de84c2836 8043741: VerifyError due to missing checkcast
Proto-type is not set correctly for NULLCHK synthetic trees

Reviewed-by: mcimadamore
2015-01-09 15:49:42 +00:00
Srikanth Adayapalam
0eb55d78b6 8066871: java.lang.VerifyError: Bad local variable type - local final String
BaseType() erroneously called on MethodResultInfo causes lack of constant type info

Reviewed-by: jlahoda, mcimadamore
2015-01-09 15:48:09 +00:00
Sonali Goel
274f997aee 8058373: Group 10a: golden files for tests in tools/javac dir
Reviewed-by: jjg, darcy
2015-01-08 22:01:20 -08:00
Maurizio Cimadamore
56a33e4541 8058542: Devise scheme for better diagnostic creation
Add support for generating (at build-time) an enum-like class containing all javac diagnostics, which allows for safe diagnostic creation.

Reviewed-by: jlahoda, jjg, vromero, erikj, jfranck
2015-01-08 14:43:05 +00:00
Joe Darcy
5cb7065612 8068639: Make certain annotation classfile warnings opt-in
Reviewed-by: jjg
2015-01-07 17:06:47 -08:00
Jonathan Gibbons
e6ea1f0ff8 8059977: StandardJavaFileManager should support java.nio.file.Path
Reviewed-by: jlahoda
2015-01-06 14:51:10 -08:00
Maurizio Cimadamore
75b2a03bf9 8067883: Javac misses some opportunities for diagnostic simplification
Javac always report full inference diagnostic, even when message does not mention inference variables.

Reviewed-by: jlahoda
2015-01-06 15:46:41 +00:00
Vicente Romero
f6ed87ed5a 8064857: javac generates LVT entry with length 0 for local variable
Reviewed-by: mcimadamore, jjg
2015-01-05 17:35:48 -08:00
Sonali Goel
11b1d2cdad 8054689: Split large SJavac.java test source into multiple files
Reviewed-by: jjg, jfranck
2014-12-24 11:17:51 -08:00
Maurizio Cimadamore
c269c9451b 8066974: Compiler doesn't infer method's generic type information in lambda body
Add loghic to avoid post-inference triggers on temporarty AST types

Reviewed-by: jlahoda, vromero
2014-12-18 13:21:44 +00:00
Maurizio Cimadamore
41070244c9 8067792: Javac crashes in finder mode with nested implicit lambdas
Revert tree changes occurred in Attr before running the analyzer

Reviewed-by: jlahoda
2014-12-17 16:47:56 +00:00
Jan Lahoda
627ce960f5 8067422: Lambda method names are unnecessarily unstable
Lambda method numbers are now assigned per class for non-serializable lambdas.

Reviewed-by: mcimadamore, rfield
2014-12-17 12:49:57 +01:00
Maurizio Cimadamore
eb3798a14a 8067663: Add bugId to tests that have been modified as part of JDK-8064365
Add missing bug id to modified tests

Reviewed-by: jlahoda
2014-12-16 13:44:22 +00:00
Maurizio Cimadamore
3076062240 8064365: Better support for finder capabilities in target-typing context
Add new framework to allow for easy creation of finder-like capabilities.

Reviewed-by: jjg, jlahoda
2014-12-12 18:07:24 +00:00
Jonathan Gibbons
0900c1f2e0 8066808: langtools/test/Makefile should not use OS-specific jtreg binary
Reviewed-by: mcimadamore
2014-12-11 18:23:17 -08:00
Jonathan Gibbons
827f52c966 8066807: langtools/test/Makefile should use -agentvm not -samevm
Reviewed-by: mcimadamore
2014-12-11 18:20:00 -08:00
Andrei Eremeev
282c943241 8065360: Implement a test that checks possibilty of class members to be imported
Reviewed-by: jlahoda, anazarov
2014-12-10 21:45:39 +02:00
Maurizio Cimadamore
a800908e25 8067001: DetectMutableStaticFields fails after modular images push
Ignore JRTIndex.sharedInstance

Reviewed-by: jlahoda
2014-12-09 16:09:07 +00:00
Andrei Eremeev
400505a1f2 8066961: NegativeCyclicDependencyTest.java fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jlahoda
2014-12-09 11:45:38 +01:00
Andrei Eremeev
ea81e1bc1f 8064794: Implement negative tests for cyclic dependencies in import statements
Reviewed-by: jlahoda, anazarov
2014-12-09 01:06:11 +02:00
Jan Lahoda
cf476e9302 8066902: JavacParserTest fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jjg, ksrini
2014-12-08 21:26:04 +01:00
Jan Lahoda
59b3453845 8061549: Disallow _ as a one-character identifier
Underscore is no longer a one-charater identifier with -source 9

Reviewed-by: mcimadamore, jjg
2014-12-08 18:02:07 +01:00
Jan Lahoda
113babff27 8065753: javac crashing on a html-like file
Avoiding special-case in error recovery for bad token on position 0.

Reviewed-by: jjg
2014-12-08 11:50:19 +01:00
Jonathan Gibbons
78fd11386c 8066737: langtools/test/tools/javac/processing/6348193/T6348193.java fails
Reviewed-by: darcy
2014-12-04 19:09:29 -08:00
Chris Hegarty
189df3ac57 Merge 2014-12-03 19:28:40 +00:00
Chris Hegarty
8bc2b3ff3a 8049367: Modular Run-Time Images
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Bradford Wetmore <bradford.wetmore@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: James Laskey <james.laskey@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jlahoda, ksrini
2014-12-03 14:25:46 +00:00
Jan Lahoda
d739446063 7101822: Compiling depends on order of imports
7177813: Static import to local nested class fails

MemberEnter overhaul - TypeEnter is split out of MemberEnter; the TypeEnter consists of several Phases which ensure actions are done in the correct order.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jfranck, aeremeev
2014-12-03 13:46:12 +01:00
Maurizio Cimadamore
02df6a4564 8065986: Compiler fails to NullPointerException when calling super with Object<>()
Missing POLY kind selector on recursive constructor calls with poly arguments

Reviewed-by: vromero
2014-11-28 11:45:56 +00:00
Robert Field
634c33938c 8058112: Invalid BootstrapMethod for constructor/method reference
Bridge method references with functional interface method parameters of intersection type

Reviewed-by: vromero, dlsmith
2014-11-24 14:52:46 -08:00
Jan Lahoda
26298f1124 8032211: Don't issue deprecation warnings on import statements
6598104: javac should not warn about imports of deprecated classes

Suppressing the deprecation warnings when importing a deprecated element (deprecations in import qualifier will be produced).

Reviewed-by: darcy, jjg, mcimadamore
2014-11-24 16:02:35 +01:00
Eric McCorkle
590188542e 8065132: Parameter annotations not updated when synthetic parameters are prepended
Cause javac to add synthetic parameters to Runtime[In]VisibleParameterAnnotations attributes

Reviewed-by: jjg, jfranck
2014-11-21 16:36:39 -05:00
Jonathan Gibbons
bdf693fcc5 8061876: replace java.io.File with java.nio.file.Path (again)
Reviewed-by: ksrini, jlahoda
2014-11-21 10:38:43 -08:00
Joel Borggrén-Franck
8bf55955df 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
Reviewed-by: jlahoda, vromero
2014-11-21 12:36:21 +01:00
Jonathan Gibbons
56e39629eb 8065054: Some tests have junk before the legal header
Reviewed-by: darcy
2014-11-20 14:23:31 -08:00
Vicente Romero
60113dc1ba 8063052: Inference chokes on wildcard derived from method reference
Reviewed-by: mcimadamore
2014-11-20 14:05:39 -08:00
Jonathan Gibbons
6bfd41fed8 8058445: Javac throws exception when displaying info
Reviewed-by: vromero, jfranck
2014-11-20 11:00:29 -08:00
Vicente Romero
418c9789d6 8059921: Missing compile error in Java 8 mode for Interface.super.field access
Reviewed-by: mcimadamore, jlahoda
2014-11-20 09:43:13 -08:00
Jan Lahoda
a2b0a2413e 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
Allowing final variables as operands to try-with-resources; also reviewed by Sergei Pikalev.

Reviewed-by: darcy, mcimadamore, vromero
2014-11-19 13:46:04 +01:00
Maurizio Cimadamore
5bb86103a9 8064803: Javac erroneously uses instantiated signatures when merging abstract most-specific methods
Wrong method type used in AmbiguousError.mergeAbstracts

Reviewed-by: jlahoda
2014-11-17 23:41:56 +00:00
Jan Lahoda
e158f32141 8062747: Compiler error when anonymous class uses method with parametrized exception
When inferring lambda's thrown types, avoid tracking variables that are not under the lambda to avoid crashes.

Reviewed-by: vromero
2014-11-14 11:58:28 +01:00
Jan Lahoda
b136af5563 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
When calling dupUnshared on a shared scope, make sure the result does not contain Symbols that don't belong to the scope that is being dupUnshared.

Reviewed-by: mcimadamore
2014-11-12 19:05:17 +01:00
Andrei Eremeev
9130b22f3f 8042931: Implement classfile tests for EnclosingMethod attribute
Reviewed-by: jjg, shurailine, anazarov
2014-11-12 15:16:35 +02:00
Maurizio Cimadamore
ed9c1bb743 8064464: regression with type inference of conditional expression
Bad classification of conditional leads to spurious error

Reviewed-by: jlahoda
2014-11-12 12:41:32 +00:00
Joel Borggrén-Franck
991885e85d 8060448: ArrayIndexOutOfBoundsException with annotation processing printout of empty line
Reviewed-by: jlahoda
2014-10-24 10:08:51 +02:00
Jonathan Gibbons
de2b97f133 8063145: ToolBox should support extracting classes from a JavaFileManager/Location
Reviewed-by: ksrini
2014-11-07 14:51:35 -08:00
Eric McCorkle
ab1b9a9cf1 8029012: parameter_index for type annotation not updated after outer.this added
Fix javac's handling of type annotations when synthetic parameters are added

Reviewed-by: jjg, mcimadamore
2014-11-07 07:54:35 -05:00
Eric McCorkle
aca235b121 8062245: Test executes incorrect class
Fix issue with test executing incorrect class, and trivial test failure linked to different subclasses of CharSequance.

Reviewed-by: jjg
2014-11-06 17:39:57 -05:00
Maurizio Cimadamore
87d664f4f0 8062977: Inference: NullPointerException during bound incorporation
Bogus Types.asSuper call on array type symbol

Reviewed-by: vromero
2014-11-06 14:33:22 +00:00
Maurizio Cimadamore
ded3a562b9 6987475: Order of declarations affects whether abstract method considered overridden
Types.implementation erroneously returns first matching method in hierarchy.

Reviewed-by: vromero
2014-11-06 14:31:56 +00:00
Jonathan Gibbons
c4f3406133 8063074: test/tools/javac/plugin/showType/Test.java fails on Windows
Reviewed-by: ksrini
2014-11-05 19:48:42 -08:00
Jonathan Gibbons
a75d2dbd39 8062676: Tests which leak lots of file managers should be fixed (group 2)
Reviewed-by: darcy
2014-11-05 19:12:45 -08:00
Jonathan Gibbons
b96daffd2e 8063039: incorrect message reference or broken message file
Reviewed-by: ksrini
2014-11-05 19:09:09 -08:00
Eric McCorkle
0acac5a3d5 8035259: javac, incorrect shadowing of classes vs type parameters
Cause javac to look at type variables first when resolving names in an extends/implements list

Reviewed-by: mcimadamore, jlahoda
2014-11-05 08:37:04 -05:00
Sonali Goel
4ca3a232d1 8062314: Update tools/javac/plugin/showtype/Test.java to use ToolBox.java
Reviewed-by: jjg
2014-11-04 13:21:25 -08:00
Andreas Lundblad
4a3d559ffb 8062740: Since changeset 2686:030080f03e4f test/tools/sjavac/DependencyCollection.java does no longer compile
Added throws IOException to main method.

Reviewed-by: jjg
2014-11-04 09:04:13 +01:00
Dan Smith
44213132ab 8062449: Update langtools/test/Makefile to use JCK 9
Updated to JCK 9 and improved use of variables to control the invocation

Reviewed-by: jjg, erikj
2014-10-31 17:23:21 -06:00
Kumar Srinivasan
60b8135982 8061305: Javadoc crashes when method name ends with "Property"
Reviewed-by: jjg
2014-10-31 07:02:56 -07:00
Sonali Goel
35b29e7662 8062336: Revert tools/javap/T6729471.java to original test code
Reviewed-by: jjg
2014-10-30 15:21:42 -07:00
Jonathan Gibbons
342df9829a 8062514: Update ToolTester tests to close file manager
Reviewed-by: darcy
2014-10-29 19:07:34 -07:00
Jonathan Gibbons
8bd23f1681 8062348: langtools tests should close file manager (group 1)
Reviewed-by: darcy
2014-10-29 17:25:23 -07:00
Liam Miller-Cushon
08336b39dd 8059453: javac crashes with -Xjcov and union types
Reviewed-by: jlahoda, vromero
2014-09-25 14:38:29 -07:00
Sonali Goel
0bfa3c5036 8059423: Replace references for rt.jar by temp.jar
Reviewed-by: jjg
2014-10-27 10:43:09 -07:00
Joel Borggrén-Franck
0149333fb8 8054448: (ann) Cannot reference field of inner class in an anonymous class
Reviewed-by: jlahoda, mcimadamore
2014-10-24 08:34:51 +02:00
Maurizio Cimadamore
535317c6f8 8061778: Wrong LineNumberTable for default constructors
Synthetic empty blocks generated by Lower are erroneously picked up by Gen

Reviewed-by: jjg
2014-10-24 10:54:04 +01:00
Vicente Romero
96941c8951 8057800: Method reference with generic type creates NPE when compiling
Reviewed-by: mcimadamore, dlsmith
2014-10-23 10:42:44 -07:00
Jonathan Gibbons
5074c6ed36 8061723: 8060056 breaks tests on Windows
Reviewed-by: darcy
2014-10-21 17:50:13 -07:00
Jonathan Gibbons
0e0e189bf6 8060056: replace java.io.File with java.nio.file.Path
Reviewed-by: ksrini, jlahoda
2014-10-21 13:08:20 -07:00
Eric McCorkle
8244cae54a 8054457: Refactor Symbol kinds from small ints to an enum
Replace bitmap logic in symbol.kind and pkind with an enum-based API

Reviewed-by: mcimadamore, jjg
2014-10-21 09:01:51 -04:00
Jonathan Gibbons
cf1a634000 8040131: Implement classfile test for LineNumberTable attribute
Reviewed-by: jjg, shurailine
2014-10-16 14:31:37 -07:00
Maurizio Cimadamore
2756ed20d7 8058511: StackOverflowError at com.sun.tools.javac.code.Types.lub
Lub crashes when handling typevar with array bound

Reviewed-by: vromero, dlsmith
2014-10-14 12:01:05 +01:00
Maurizio Cimadamore
8f96799dd5 8058199: Code generation problem with javac skipping a checkcast instruction
TransTypes sometimes ignores inferred signatures when emitting synthetic casts

Reviewed-by: vromero
2014-10-14 12:00:39 +01:00
Paul Govereau
8cc03657e9 8060249: Backout fix for JDK-8058243
Reviewed-by: vromero
2014-10-13 17:09:12 -04:00
Paul Govereau
ef05cafd6b 8060234: Fix push for JDK-8058243
Reviewed-by: jjg, vromero
2014-10-13 12:12:06 -04:00
Jan Lahoda
1eb03e49bf 8054956: Javac reports wrong error offset for unknown identifier of annotation element/value pair
When reporting an error about unresolvable annotation attribute, use the position of the explicit left-hand-side of the assignment if available, otherwise use the position of the right-hand-side.

Reviewed-by: jfranck
2014-10-13 17:22:47 +02:00
Sonali Goel
a7b8ca6209 8058410: Group 10b: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-10-10 14:41:50 -07:00
Jan Lahoda
e95348b58e 8057652: Request to improve error messages for labeled declarations
Parse labeled statements as block statements to improve error recovery for labeled declarations; related cleanup.

Reviewed-by: jjg
2014-10-09 10:08:52 +02:00
Andreas Lundblad
0545e4b847 8059349: Public API scanning should be implemented in the form of a TaskListener
Replaces JavaCompilerWithDeps with a TaskListener.

Reviewed-by: jfranck
2014-10-07 21:21:42 +02:00
Andreas Lundblad
96074068b8 8056258: Analysis of public API does not take super classes into account
8048609: simplify sjavac dependence on javac dependency gathering

Replaces Attr-/ResolveWithDeps with TaskListeners

Reviewed-by: jfranck, ohrstrom
2014-10-07 21:15:10 +02:00
Robert Field
e55ca9fc58 8056051: int[]::clone causes "java.lang.NoClassDefFoundError: Array"
Reviewed-by: mcimadamore, vromero
2014-10-04 10:13:11 -07:00
Sonali Goel
1f9a38f175 8055783: Group 9e: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2014-10-01 14:15:40 -07:00
Bhavesh Patel
3fad9f6677 8048351: tidy errors for attribute href, name for langtools javadoc tests needs investigation
Reviewed-by: jjg
2014-09-26 13:51:43 -07:00
Vicente Romero
97309123c1 8058708: java.lang.AssertionError compiling source code
Reviewed-by: jjg
2014-09-25 17:09:23 -07:00
Neil Toda
9fbf466c3f 8050117: add to javac test Versions.java tests that show correct operation for source/target options pre 1.9
Reviewed-by: jjg
2014-09-25 13:54:45 -07:00
Eric McCorkle
b4401ebed9 8048614: Add TypeMetadata to contain type annotations and other type information
Implement general framework for metadata on types

Reviewed-by: mcimadamore
2014-09-22 17:09:33 -04:00
Jan Lahoda
c30ea9e1d2 8057794: Compiler Error when obtaining .class property
Ensuring a non-null type and sym for illegal T.class to prevent downstream errors.

Reviewed-by: mcimadamore
2014-09-22 14:55:14 +02:00
Sonali Goel
2700003cdb 8058755: Update tools/javadoc/6227454 to add head tag
Reviewed-by: jjg
2014-09-19 13:54:34 -07:00
Bhavesh Patel
b02c07123c 8047745: Javadoc should include encoding information in generated html files
Reviewed-by: jjg, ksrini
2014-09-18 00:50:48 -07:00
Bhavesh Patel
99ec33372d 8043698: <title> tag not getting generated in package-summary pages for un-named packages
Reviewed-by: jjg, ksrini
2014-09-17 23:52:19 -07:00
Maurizio Cimadamore
ae97aeb0d9 8055963: Inference failure with nested invocation
Revise heuristics to force eager instantiation of return inference vars

Reviewed-by: vromero
2014-09-15 12:43:35 +01:00
Sonali Goel
79efb2b9d8 8055080: Group 9d: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore, jlahoda
2014-09-12 17:05:18 -07:00
Paul Govereau
d65d28d993 8054210: NullPointerException when compiling specific code
Reviewed-by: vromero, jlahoda
2014-09-09 12:16:25 -04:00
Paul Govereau
a37e9881b2 8055500: fix for 8030046 is incorrect
Reviewed-by: jjg, ksrini
2014-09-09 11:55:47 -04:00
Jan Lahoda
2beda23cf8 8057753: Test langtools/test/tools/javac/NoClass.java is failing when run together with langtools/test/tools/javac/DuplicateImport.java
Removing javac/NoClass test, as it is superseded by javac/importChecks/InvalidImportsNoClasses.java

Reviewed-by: jfranck
2014-09-08 15:51:29 +02:00
Maurizio Cimadamore
a9061c2918 8055514: Wrong, confusing error when non-static varargs referenced in static context
Improved heuristics in MethodResolutionPhase.mergeResults()

Reviewed-by: vromero
2014-09-08 14:16:33 +01:00
Joel Borggrén-Franck
053a9d56cd 8056021: checkin for JDK-8027262 breaks Checker Framework
Reviewed-by: jjg, mcimadamore
2014-09-08 13:11:28 +02:00
Jan Lahoda
f211cac0cd 8056984: Exception in compiler: java.lang.AssertionError: isSubClass T
Must use type variable's captured bound as a method receiver, instead of the type variable itself, while checking if deferred attribution is needed.

Reviewed-by: mcimadamore, vromero
2014-09-08 10:50:59 +02:00
Jan Lahoda
49469c49d0 8056014: Type inference may be skipped for a complex receiver generic method in a parameter position
When checking if deferred attribution is needed for a chain of methods, stop on any method that returns any type variable, as the rest of analysis cannot use the correct type.

Reviewed-by: mcimadamore, vromero
2014-09-08 10:48:18 +02:00
Sonali Goel
f064e2b028 8055079: Group 9c: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-09-05 16:51:39 -07:00
Sonali Goel
170f8549b4 8055075: Group 9b: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-09-05 16:43:00 -07:00
Sonali Goel
15420bd193 8055996: Remove @ignore from tools/javac/T6725036.java
Reviewed-by: jjg
2014-09-04 16:52:40 -07:00
Jan Lahoda
6cac1178ba 8047675: tools/javac/defaultMethods/Assertions.java fails if run with -enableassertions (-ea)
Using ToolBox to start new Java processes, to avoid passing default VM options to the newly started process.

Reviewed-by: jjg
2014-09-04 08:49:20 +02:00
Jan Lahoda
83abeb739b 8054563: Update RunCodingRules.java for source code reorg
Tests RunCodingRules and MessageInfo fixed to work in the new source code structure.

Reviewed-by: jjg
2014-09-04 08:48:29 +02:00
Jonathan Gibbons
f0b4f3d282 8038414: Constant pool's strings are not escaped properly
Reviewed-by: jjg, mcimadamore, ksrini
2014-09-03 14:19:39 -07:00
Jonathan Gibbons
3b029e1995 8034861: Incorrect format and indentation of InnerClasses section
Reviewed-by: jjg, ksrini, mcimadamore, lagergren
2014-09-03 14:06:25 -07:00
Alexander Zuev
f4e40eeff6 8044597: Request to update tools/javap/T4501661.java to add test for package option
Reviewed-by: jjg
2014-09-03 19:22:16 +04:00
Sonali Goel
b8919f9429 8056288: Missing bug id in test/com/sun/javadoc/testOrdering/TestOrdering.java
Reviewed-by: ksrini
2014-08-29 14:08:49 -07:00
Sonali Goel
f4dc4013f0 8055074: Group 9a: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-08-29 00:42:42 -07:00
Sonali Goel
e2312f606b 8049126: golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-28 23:42:16 -07:00
Joe Darcy
d66c4567ee 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed
Reviewed-by: ksrini
2014-08-28 11:29:34 -07:00
Andreas Lundblad
43eb10bcb8 8054500: Refactor sjavac Main class into ClientMain and ServerMain
Restructured Main into ClientMain and ServerMain

Reviewed-by: jfranck
2014-08-28 17:38:40 +02:00
Kumar Srinivasan
5f800435e3 8050031: [javadoc] class-use pages have duplicates and missing entries
Reviewed-by: jjg
2014-08-27 06:56:29 -07:00
Jonathan Gibbons
08e122f2cb 8044859: javac duplicates option processing when using Compiler API
Reviewed-by: mcimadamore, vromero, jlahoda
2014-08-22 16:28:16 -07:00
Kumar Srinivasan
9867d883ad 8055501: [javac] ignore test/tools/javac/Paths/AbsolutePathTest.java
Reviewed-by: jjg
2014-08-19 15:34:01 -07:00
Chris Hegarty
2d81f9c851 Merge 2014-08-18 10:59:44 +01:00
Chris Hegarty
2b80c4715f 8054834: Modular Source Code
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Reviewed-by: alanb, chegar, ihse, mduigou
2014-08-17 15:52:32 +01:00
Paul Govereau
7cb1497762 8054556: javac should report the error for default usage as the primary error
Reviewed-by: jjg
2014-08-15 11:02:14 -04:00
Jonathan Gibbons
1cf35244f6 8055076: fix test failures in classfile tests
Reviewed-by: darcy
2014-08-13 15:47:58 -07:00
Eric McCorkle
52b5861793 Merge 2014-08-13 21:58:29 +00:00
Jonathan Gibbons
33e6564a6b 8050429: Update/cleanup ToolBox
Reviewed-by: vromero
2014-08-13 13:20:31 -07:00
Andreas Lundblad
ce4c456820 8048457: Sjavac should not use portfiles, sockets, etc if background=false
8044131: Restructure client / server protocol code

Changes protocol code to use Object input/output streams. Avoids spawning server if background=false. Refactors idleness checks, pooling and port file monitoring.

Reviewed-by: jjg, jfranck
2014-08-13 14:44:59 +02:00
Sonali Goel
14e6aa6b9e 8049130: Group 8d - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:48:30 -07:00
Sonali Goel
32b768c531 8049129: Group 8c - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:39:56 -07:00
Sonali Goel
40f4caa8d0 8049127: Group 8b - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:31:31 -07:00
Sonali Goel
bf789b2a48 8054964: Add a test for invalid package annotations
Reviewed-by: jjg
2014-08-12 16:41:05 -07:00
Andrei Eremeev
8740c99fbd 8042251: Implement classfile tests for InnerClasses attribute
Reviewed-by: jjg, anazarov, shurailine
2014-08-12 13:24:40 +04:00
Kumar Srinivasan
714d7c813a 8054044: [javadoc] javadoc tester must print out the javadoc run arguments
Reviewed-by: jjg, sogoel
2014-08-11 10:16:55 -07:00
Fredrik Öhrström
c110d6437f 8054465: Add --permit-artifact=bar to sjavac
Add --permit-artifact=bar to white-list files that have been written to the destination directory and that sjavac should not delete.

Reviewed-by: jjg, alundblad
2014-08-09 00:56:29 +02:00
Fredrik Öhrström
c8256e4d27 8054474: Add --state-dir=bar to sjavac
Add --state-dir=bar to sjavac to control where sjavac stores the javac_state file.

Reviewed-by: jjg, alundblad
2014-08-08 21:26:23 +02:00
Fredrik Öhrström
ce6154a2fa 8054461: Add @file support to sjavac
Add @file support to sjavac commandline.

Reviewed-by: jjg, alundblad
2014-08-08 20:47:24 +02:00
Jan Lahoda
66ea31ef63 8043643: Add an crules analyzer avoiding string concatenation in messages of Assert checks
Generalizing the crules infrastructure, adding a new analyzer to check String concatenation in Assert calls.

Reviewed-by: jjg, vromero
2014-08-01 11:09:40 -07:00
Alexander Zuev
5284120119 8047072: javap OOM on fuzzed classfile
Reviewed-by: jjg
2014-07-30 20:31:39 +04:00
Maurizio Cimadamore
560c7c91fe 8051958: Cannot assign a value to final variable in lambda
Remove Attr.owner and refactor code for detecting forward field references

Reviewed-by: vromero
2014-07-29 15:31:57 -07:00
Andrey Nazarov
0f64892089 8050979: Provide javadoc for "framework" classes in langtools tests
Reviewed-by: jjg
2014-07-24 15:12:48 -07:00
Andrey Nazarov
0308bdc9d1 8050319: LocalVariableTestBase has unexpected dependency on LocalVariableTableTest
Reviewed-by: jjg, ksrini
2014-07-23 09:19:23 -07:00
Sonali Goel
248c1db2be 8050954: update DocRootSlash test for tidy error: empty <p>
Reviewed-by: ksrini, bpatel
2014-07-17 16:46:29 -07:00
Sonali Goel
a047a4f1ec 8048837: .out files for generics tests in tools/javac dir - part 3
Reviewed-by: jjg
2014-07-17 11:22:47 -07:00
Sonali Goel
5324b04fde 8048836: .out files for generics tests in tools/javac dir
Reviewed-by: jjg
2014-07-17 11:14:39 -07:00
Mandy Chung
acacb0481e 8050804: (jdeps) Recommend supported API to replace use of JDK internal API
Reviewed-by: dfuchs
2014-07-17 10:17:58 -07:00
Sonali Goel
541591d644 8048833: .out files for generics tests in tools/javac dir
Reviewed-by: jjg
2014-07-17 09:56:07 -07:00
Joe Darcy
dee421ed14 8050430: Provided new utility visitors supporting SourceVersion.RELEASE_9
Reviewed-by: jjg
2014-07-17 09:47:25 -07:00
Vicente Romero
aa91971a3c 8051004: javac, incorrect bug id in tests for JDK-8050386
Reviewed-by: mcimadamore
2014-07-17 10:55:50 -04:00
Vicente Romero
3e002a08e6 8050386: javac, follow-up of fix for JDK-8049305
Reviewed-by: mcimadamore
2014-07-16 10:47:56 -04:00
Vicente Romero
6edca1025f 8050283: fix for JDK-8049305 should be removed
Reviewed-by: jjg
2014-07-14 16:59:25 -04:00
Jonathan Gibbons
6ec02aa50b 8046824: class SJavacTestUtil and *Wrapper are redundant and should be removed
Reviewed-by: ksrini
2014-07-14 11:46:31 -07:00
Vicente Romero
1e87b47b2a 8049305: Verification error due to a bad stackmap frame generated by javac
Reviewed-by: mcimadamore
2014-07-14 13:36:30 -04:00
Jan Lahoda
603d592a91 8049948: Restore NonDirectSuper.java test
Reviewed-by: jjg
2014-07-14 12:03:08 +02:00
Jan Lahoda
eb1f1c05ed 8048805: Request to investigate and update lexer error recovery in javac
8046620: Further investigation needed for few error messages for negative unicode tests in langtools regression ws
8048803: javac should report complete character code in the error messages

Improving error reporting and recovery in the lexer

Co-authored-by: Sonali Goel <sonali.goel@oracle.com>
Reviewed-by: jjg, mcimadamore
2014-07-14 12:02:58 +02:00
Kumar Srinivasan
0752cdda93 8039028: [javadoc] refactor the usage of Util.java
Reviewed-by: jjg
2014-06-15 08:41:57 -07:00
Jonathan Gibbons
92884a5338 8050106: JavaCompiler relies on inappropriate result from comparison
Reviewed-by: darcy
2014-07-12 07:32:28 -07:00
Jonathan Gibbons
84e4fca0c8 8048806: Javadoc errors out on some valid HTML tags
Reviewed-by: bpatel
2014-07-11 18:51:32 -07:00
Kumar Srinivasan
c626683b26 8049396: [javadoc] add more class-use test cases
Reviewed-by: jjg
2014-07-11 06:52:04 -07:00
Kumar Srinivasan
4fa698fe42 8049393: [javadoc] parameters are not sorted correctly
Reviewed-by: jjg
2014-06-29 17:13:55 -07:00
Neil Toda
f7234f052c 8030610: replace test/tools/javac/versions/check.sh
Reviewed-by: jjg
2014-07-10 16:03:45 -07:00
Neil Toda
b4b2f994ca 8011044: Remove support for 1.5 and earlier source and target options
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: darcy, jjg
2014-07-10 13:57:27 -07:00
Vicente Romero
5916a0adfa 8033483: Should ignore nested lambda bodies during overload resolution
Reviewed-by: mcimadamore, dlsmith
2014-07-09 10:49:32 -04:00
Jan Lahoda
0067b70725 8031569: Refactor javac scope implementation to enable lazy imports
Introducing an internal API for Scope; rewriting ImportScopes to extend CompoundScopes.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jjg, jfranck
2014-07-09 16:32:05 +02:00
Mandy Chung
c2f98fba15 8029548: (jdeps) use @jdk.Exported to determine supported vs JDK internal API
8031092: jdeps does not recognize --help option
8048063: (jdeps) Add filtering capability

Reviewed-by: alanb, dfuchs
2014-07-08 18:26:34 -07:00
Maurizio Cimadamore
15cfa4aac9 8043926: javac, code valid in 7 is not compiling for 8
Type-containment doesn't handle inference variables correctly

Reviewed-by: vromero, dlsmith
2014-07-08 15:42:04 +01:00
Jan Lahoda
3c5b32658b 8042239: javac: TreeMaker.Type(Type t) does not handle UnionClassType
Enhancing TreeMaker.Type(Type t) with support for UnionClassType and IntersectionClassType.

Co-authored-by: Robert Field <robert.field@oracle.com>
Reviewed-by: vromero, rfield
2014-07-08 15:13:16 +02:00
Sonali Goel
5437ec7e74 8044080: .out files for unicode, implicitThis and importChecks tests in tools/javac dir
Reviewed-by: jjg
2014-07-07 13:39:31 -07:00
Sonali Goel
9c09973b5a 8049491: Remove three auxilary files in tools/javac/enum dir
Reviewed-by: jjg
2014-07-07 12:55:00 -07:00
Sonali Goel
3ecb57ccc0 8046618: .out files for enum tests in tools/javac/dir
Reviewed-by: jjg
2014-07-07 12:44:20 -07:00
Sonali Goel
0718a280b0 8046635: .out files for enum tests in tools/javac/dir
Reviewed-by: jjg
2014-07-07 12:36:45 -07:00
Vicente Romero
72d5723212 8049075: javac, wildcards and generic vararg method invocation not accepted
Reviewed-by: mcimadamore
2014-07-04 16:34:44 +01:00
Jonathan Gibbons
12b653bb02 8042261: Implement classfile tests for Deprecated attribute
Reviewed-by: jjg, anazarov, shurailine
2014-07-04 10:52:22 +01:00
Sonali Goel
50e8d8b28d 8049284: Missing bug id in test/tools/javac/varargs/warning/Warn*
Reviewed-by: darcy
2014-07-03 15:48:23 -07:00
Sonali Goel
2caa264885 8046770: .out files for assert, boxing, and overload tests in tools/javac dir
Reviewed-by: jjg
2014-07-02 14:27:10 -07:00
Sonali Goel
9343037434 8044864: .out files for enum tests in tools/javac dir - part 1
Reviewed-by: jjg
2014-07-02 13:29:58 -07:00
Sonali Goel
8244fe0c5c 8044236: create .out files for DefiniteAssignment tests in tools/javac dir
Reviewed-by: jjg, vromero
2014-07-02 12:04:04 -07:00
Jan Lahoda
670eff1ee6 6707032: Division by zero warning not suppressed properly in some cases
Delay reporting of the division by zero warning until annotations are resolved, so that @SuppressWarnings works correctly.

Reviewed-by: vromero
2014-06-30 17:08:06 +02:00
Kumar Srinivasan
729fe3ec72 8047162: [javadoc] index files are non deterministic
Reviewed-by: jjg
2014-06-27 17:54:54 -07:00
Andreas Lundblad
8baafcf7ef 8048594: The sjavac client/server protocol should be hidden behind an interface
Reviewed-by: jfranck
2014-06-17 14:01:27 +02:00
Vicente Romero
ce0935812b 8047719: Incorrect LVT in switch statement
Reviewed-by: jjg, jlahoda
2014-06-27 20:32:12 +01:00
Sonali Goel
2f5e083cee 8048293: update tools/javadoc/6227454 to have missing <head> tag
Reviewed-by: jjg, bpatel
2014-06-26 16:39:14 -07:00
Sonali Goel
3e316a3372 8047316: update javadoc tests to fix tidy warning for incorrect html comment
Reviewed-by: jjg, ksrini
2014-06-26 16:07:07 -07:00
Sonali Goel
bbc0df83f4 8048168: update 2 javadoc tests to add summary attribute for table tag
Reviewed-by: jjg, ksrini
2014-06-26 15:47:52 -07:00
Sonali Goel
8828870971 8047744: update 2 javadoc tests for nested emphasis <code>
Reviewed-by: jjg, ksrini
2014-06-26 15:41:05 -07:00
Sonali Goel
41005acef2 8047743: update com/sun/javadoc/testHref for unrecognized <action>
Reviewed-by: jjg, ksrini
2014-06-26 15:30:21 -07:00
Sonali Goel
7470fabe6f 8047303: update com/sun/javadoc/DocRootSlash/DocRootSlash for unexpected </a>
Reviewed-by: jjg, ksrini
2014-06-26 15:21:44 -07:00
Jonathan Gibbons
47c543e53b 8007307: DPrinter: support the DocTree API
Reviewed-by: mcimadamore
2014-06-26 11:45:51 -07:00
Jonathan Gibbons
bd97e7d5ec 8047183: JDK build fails with sjavac enabled
Reviewed-by: mcimadamore
2014-06-26 11:31:59 -07:00
Paul Govereau
5b1596bc25 8042345: getDocComment fails for doc comments on PackageElement found in package-info.java
Reviewed-by: jjg
2014-06-26 13:48:58 -04:00