Commit Graph

1899 Commits

Author SHA1 Message Date
Srikanth Adayapalam
4815781a4a 8081271: NPE while compiling a program with erroneous use of constructor reference expressions
Missing enclosing instance error should not be swallowed when attributing constructor reference expressions.

Reviewed-by: mcimadamore, vromero
2015-05-29 09:15:42 +05:30
Vicente Romero
c44a1b3184 8081417: test CheckEBCDICLocaleTest.java is failing intermittently
Reviewed-by: darcy
2015-05-28 12:08:54 -07:00
Mandy Chung
ab120497cf 8074432: Move jdeps and javap to jdk.jdeps module
Reviewed-by: jjg, alanb, erikj
2015-05-27 13:25:18 -07:00
Srikanth Adayapalam
385f5d800a 8080726: Redundant error message on private abstract interface method with body
Reviewed-by: mcimadamore
2015-05-27 11:27:42 +05:30
Mandy Chung
81ae8feaed 8074431: Remove native2ascii tool
Reviewed-by: erikj, alanb, okutsu, mfang, naoto
2015-05-22 16:44:49 -07:00
Daniel Fuchs
e39d4f074f 8080608: Missing archive name from jdeps -v -e output if no dependency on other JAR
Reviewed-by: mchung
2015-05-22 13:05:26 +02:00
Jonathan Gibbons
9ac1ce305e 8080897: tests broken in bad merge
Reviewed-by: darcy
2015-05-21 13:47:05 -07:00
Alexander Kulyakhtin
b6262441ad 8076543: Add @modules as needed to the langtools tests
Reviewed-by: jjg, shurailine
2015-05-21 11:41:04 -07:00
Jan Lahoda
9264fe218f 8080572: langtools/test/tools/javac/generics/T5011073.java failing
Test/tools/javac/generics/InterfaceCast1.java defines a top-level Set, moving it to a separate directory to avoid clashes.

Reviewed-by: mcimadamore
2015-05-18 14:48:41 +02:00
Srikanth Adayapalam
72744bb5fa 8079613: Deeply chained expressions + several overloads + unnecessary inference result in excessive compile times
Eliminate compile time performance bottlneck due to mischaracterization of standalone expressions as being poly expressions.

Reviewed-by: mcimadamore, jlahoda
2015-05-11 13:28:14 +05:30
Jan Lahoda
1867d1a236 8080338: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle
8080339: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle
8080340: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle

Fixing incorrect file headers; also reviewed by kevin.l.brown@oracle.com

Reviewed-by: vromero
2015-05-18 09:27:09 +02:00
Sonali Goel
945f55124f 8075166: Group 14d: golden files for tests in tools/javac/generics/wildcards dir
Reviewed-by: jjg
2015-05-15 18:03:51 -07:00
Sonali Goel
4676493261 8080539: Remove few test files that did not get removed with the patch
Reviewed-by: jjg
2015-05-15 17:47:03 -07:00
Sonali Goel
e16a945d3c 8074514: Group 13d: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg
2015-05-15 17:43:21 -07:00
Sonali Goel
8f711841fa 8075165: Group 14c: golden files for tests in tools/javac/generics/wildcards dir
Reviewed-by: jjg, vromero
2015-05-15 17:12:58 -07:00
Sonali Goel
395f1173a9 8075164: Group 14b: golden files for tests in tools/javac/generics/wildcards dir
Reviewed-by: jjg, vromero
2015-05-15 16:59:34 -07:00
Sonali Goel
f6428eb2bb 8074425: Group 13b: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg, darcy, mcimadamore
2015-05-15 16:53:42 -07:00
Sonali Goel
1ebb022e1c 8075163: Group 14a: golden files for tests in tools/javac/generics/wildcards dir
Reviewed-by: jjg, vromero
2015-05-15 16:18:16 -07:00
Sonali Goel
491703889c 8074417: Group 13a: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg, mcimadamore
2015-05-15 09:53:08 -07:00
Sonali Goel
11d7b1e161 8074502: Group 13c: golden files for tests in tools/javac/generics dir
Reviewed-by: jjg, mcimadamore
2015-05-15 09:30:55 -07:00
Jan Lahoda
e21c57f2ab 8076104: Key collisions in ZipFileIndexFileObject content cache lead to wrong content
Equals&hashCode of ZipFileObject and ZipFileIndexFileObject need to be based on full entry path, not only the file name.

Reviewed-by: jjg
2015-05-15 11:41:04 +02:00
Sonali Goel
d0acf99cf6 8074408: Group 12: golden files for tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:56:14 -07:00
Sonali Goel
6b7d074037 8074387: Group 11: golden files for coin tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:36:32 -07:00
Sonali Goel
190ba196a0 8068465: Group 10e: golden files for tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:28:43 -07:00
Sonali Goel
64622d5d74 8068464: Group 10d: golden files for tests in tools/javac dir
Reviewed-by: jjg
2015-05-15 01:09:51 -07:00
Srikanth Adayapalam
e57ef90dd9 8078473: javac diamond finder crashes when used to build java.base module
Reviewed-by: mcimadamore
2015-04-27 17:36:20 +05:30
Srikanth Adayapalam
f2ee4e4240 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables
Reviewed-by: mcimadamore
2015-04-25 15:59:54 +05:30
Jonathan Gibbons
6bed31f1c5 8079191: remove remaining references to "cp -p" from langtools/test
Reviewed-by: vromero
2015-04-30 17:35:03 -07:00
Andreas Lundblad
bd17f06ead 8044196: Incorrect applying of repeatable annotations with incompatible target to type parameter
Additional applicability checks added.

Reviewed-by: jlahoda
2015-04-30 12:21:50 +02:00
Jonathan Gibbons
8c93ae0560 8078054: [TESTBUG] tools/javac/Paths/wcMineField.sh failed with "operation not permitted"
Reviewed-by: darcy
2015-04-29 15:05:33 -07:00
Jonathan Gibbons
74169dee6e 8078861: tools/javac/classfiles/attributes/Synthetic/PackageInfoTest.java fails on Windows
Reviewed-by: vromero
2015-04-28 18:57:51 -07:00
Andreas Lundblad
4c307784ae 8078600: Infinite loop when compiling annotations with -XDcompletionDeps
Added Completer::isTerminal and added NULL_COMPLETER.

Reviewed-by: jlahoda, mcimadamore
2015-04-28 22:25:36 +02:00
Andrei Eremeev
153dc079bb 8044537: Implement classfile tests for Synthetic attribute
Reviewed-by: jjg, shurailine, anazarov
2015-04-28 11:08:25 +03:00
Jan Lahoda
b97b136530 8077605: Initializing static fields causes unbounded recursion in javac
Improving detection of potential constant variable initializers; preventing infinite recursion on exception during Attr.visitLambda.

Reviewed-by: mcimadamore, vromero
2015-04-27 16:31:29 +02:00
Vicente Romero
4693c79e67 8078433: javac, some tests are failing after JDK-8078024 because of golden files mismatch
Reviewed-by: darcy
2015-04-22 11:39:06 -07:00
Vicente Romero
8c8261cbad 8078024: javac, several incorporation steps are silently failing when an error should be reported
Reviewed-by: mcimadamore
2015-04-22 09:44:15 -07:00
Andreas Lundblad
b3ddbe8cf4 8078389: Add test for -Xdoclint + -XDcompletionDeps
Test to make sure doclint and completionDeps do not interfere.

Reviewed-by: jlahoda
2015-04-22 16:11:38 +02:00
Andreas Lundblad
fc379b3042 8068737: ArrayType prints element type post order
Rewrote ArrayType.toString

Reviewed-by: jlahoda, ksrini
2015-04-21 12:10:26 +02:00
Andrei Eremeev
56c8f87b08 8042947: Implement classfile tests for AnnotationDefault attribute
Reviewed-by: jjg, shurailine, anazarov
2015-04-20 12:45:41 +03:00
Andreas Lundblad
868bdb35b2 8043984: Confusing (incorrect) error message on repeatable annotations
Adjusted error mesage for repeating annotations

Reviewed-by: jfranck, dlsmith
2015-04-17 12:37:11 +02:00
Andreas Lundblad
e17a42c26a 8073534: Confusing / incorrect error message regarding annotations on non-declarations
Adjusted error message for annotations on non-declarations.

Reviewed-by: jlahoda, dlsmith
2015-04-17 11:52:10 +02:00
Dan Smith
336a125aa0 8075520: Varargs access check mishandles capture variables
8077786: Check varargs access against inferred signature

Reviewed-by: vromero
2015-04-16 17:20:20 -06:00
Bhavesh Patel
9c427df72e 8072945: Javadoc should generate valid and compliant HTML5 output
Reviewed-by: jjg, ksrini
2015-04-13 18:05:23 -07:00
Joel Borggren-Franck
7d3885b239 8031744: Annotations on many Language Model elements are not returned
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: jfranck, mcimadamore, emc, jlahoda, jjg
2015-04-07 11:04:29 -07:00
Jonathan Gibbons
465e4dca9a 8076420: Consolidate javac file handling in javac.file package
Reviewed-by: jlahoda
2015-04-02 15:56:07 -07:00
Andrey Nazarov
15d5184652 8075752: jdk.compiler dependency can be eliminated in MethodReferenceNullCheckTest.java
Reviewed-by: jjg
2015-03-30 16:38:59 +01:00
Andrey Nazarov
9c48863bb1 8075610: java.desktop module dependency can be eliminated in tools/javac/generics/inference/5073060/GenericsAndPackages.java
Reviewed-by: jjg
2015-03-26 17:39:04 +01:00
Srikanth Adayapalam
68593842f8 7040592: Gen.java: fix code for handling 'null' literal when expected type is array
Eliminate needless checkcast when null is assigned to a multi-dimensional array typedobject

Reviewed-by: mcimadamore
2015-03-23 09:48:37 +05:30
Srikanth Adayapalam
8afd89977c 8062373: Project Coin: diamond and anonymous classes
Allow diamond inference in combination with anonymous class instance creation

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, vromero
2015-03-30 17:09:14 +05:30
Bhavesh Patel
8b611ba470 8076026: DocTree should parse hyphenated attributes correctly
Reviewed-by: jjg, ksrini
2015-03-28 10:18:27 -07:00
Vicente Romero
38527cecd5 8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
Reviewed-by: mcimadamore
2015-03-27 10:11:21 -07:00
Jan Lahoda
31a45d5c86 8054220: Debugger doesn't show variables *outside* lambda
8058227: Debugger has no access to outer variables inside Lambda

Put local variables captured by lambda into the lambda method's LocalVariableTable.

Reviewed-by: mcimadamore, rfield
2015-03-26 11:34:50 +01:00
Andrei Eremeev
22d4785f1d 8049238: Implement classfile tests for Signature attribute
Reviewed-by: jjg, shurailine, anazarov
2015-03-25 10:29:14 +03:00
Maurizio Cimadamore
24c51e1e1b 8048838: type inference performance regression
Reduce redundant bounds before attempting to do pairwise lub computation during bound incorporation.

Reviewed-by: vromero
2015-03-19 11:40:47 +00:00
Maurizio Cimadamore
c03dd06d9a 8074381: java.lang.AssertionError during compiling
Add extra functional interface check to prevent crash during code generation

Reviewed-by: vromero
2015-03-19 11:39:36 +00:00
Srikanth Adayapalam
f1f1f0f7e1 8074148: Attr.visitBinary flags error at wrong position
Reviewed-by: vromero
2015-03-13 10:25:46 +05:30
Srikanth Adayapalam
c4ebb7f3c0 8071847: java.lang.NullPointerException at com.sun.tools.javac.code.Types.elemtype(Types.java:1870)
Class file reader should recover from malformed class files that contain methods incorrectly flagged as variable arity methods.

Reviewed-by: jlahoda
2015-03-13 13:15:24 +05:30
Srikanth Adayapalam
60841ee270 8050021: Improper "duplicate case label" error
Reviewed-by: jlahoda
2015-03-12 10:24:07 +05:30
Bhavesh Patel
6b21a5a5ff 8074521: Generate iframe instead of frame and frameset for index.html page
Reviewed-by: jjg, ksrini
2015-03-11 23:53:38 -07:00
Bhavesh Patel
7b6148280a 8072461: Table's field width in "Use" page generated by javadoc with '-s' is unbalanced
Reviewed-by: jjg
2015-03-11 21:57:59 -07:00
Jan Lahoda
fad1792bc4 8071851: Provide filtering of doclint checking based on packages
Introducing -Xdoclint/package:<packages> doclint option to enable/disable checking of specified packages.

Reviewed-by: jjg, darcy
2015-03-11 22:24:05 +01:00
Maurizio Cimadamore
a981871194 8074306: NULLCHK is emitted as Object.getClass
8074501: Javac fix for 8073432 is missing right test BugIDs

Correct test bugIds

Reviewed-by: jjg
2015-03-06 10:30:44 +00:00
Aleksey Shipilev
89cc77c8cb 8073432: Object.getClass() throws stackless NPE, due to C2 intrinsic
Javac should generate NPE checks using Objects.requireNonNull if -target >= 7

Reviewed-by: jlahoda
2015-03-05 15:03:07 +00:00
Srikanth Adayapalam
105275fb87 8071453: Allow interface methods to be private
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
2015-03-02 10:41:08 +05:30
Maurizio Cimadamore
7b2bf7805a 8073842: Invalid method reference when referencing a method on a wildcard type
Method rteference lookup logic doesn't skip type-variables as required by javac.

Reviewed-by: jlahoda
2015-02-27 18:20:33 +00:00
Jan Lahoda
681758e0fa 8067886: Inaccessible nested classes can be incorrectly imported
Check type accessibility at the point of import when importing the type using type-import-on-demand.

Reviewed-by: mcimadamore, jfranck
2015-02-24 16:11:59 +01:00
Maurizio Cimadamore
110a99f0dd 8071291: Compiler crashes trying to cast UnionType to IntersectionClassType
Compiler tests for .isCompound but then cast to a more specific Type subclass, resulting in CCE

Reviewed-by: vromero, jlahoda
2015-02-23 13:02:37 +00:00
Dan Smith
13490088bf 8039214: Inference should not map capture variables to their upper bounds
Update to Types.containsType; related adjustment to most-specific test

Reviewed-by: mcimadamore, vromero
2015-02-20 17:05:13 -07:00
Jan Lahoda
0a57971dd9 8067445: New modular image-based file manager skips boot classes
Taking "sun.boot.class.path" system property into account when constructing bootclasspath for modular images.

Reviewed-by: jjg, mcimadamore
2015-02-17 15:39:05 +01:00
Srikanth Adayapalam
31b752c691 8073201: Incorrect @bug annotation in checkin for JDK-8069545
Reviewed-by: mcimadamore
2015-02-16 19:14:18 +05:30
Maurizio Cimadamore
b91b333053 8071241: Investigate alternate strategy for type-checking operators
Separat operator lookup logic from overload resolution.

Reviewed-by: jjg, jlahoda, sadayapalam
2015-02-16 12:24:25 +00:00
Eric McCorkle
b014a7728f 8066725: javac produces classfiles it cannot read
Revert behavioral changes from 8029012 and 8065132

Reviewed-by: jfranck
2015-02-13 17:00:45 -05:00
Srikanth Adayapalam
cb2a21c5a5 8069545: javac shouldn't check nested stuck lambdas during overload resolution
Nested lambdas should not be considered while overload resolution is in progress

Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: mcimadamore
2015-02-12 10:16:19 +05:30
Maurizio Cimadamore
dbe88a2ef1 8072445: tools/javac/lambda/MethodReference55.java fails across platforms
Remove copyright from test header

Reviewed-by: jlahoda
2015-02-05 18:51:09 +00:00
Srikanth Adayapalam
74f6de6859 8069265: ClassCastException when compiled with JDK 9b08+, JDK8 compiles OK
Alternate fix for 8015499 to eliminate extra checkcast (by working around a limitation in Types#asSuper) without the side effect that results in 8069265

Reviewed-by: mcimadamore, jjg
2015-02-02 18:52:16 +05:30
Sonali Goel
b523cb6aaa 8071629: Write new test to test -j switch
Reviewed-by: jjg
2015-01-30 14:59:47 -08:00
Mandy Chung
5035f5b1d4 8068937: jdeps shows "not found" if target class has no reference other than its own package
Reviewed-by: alanb
2015-01-27 19:50:41 -08:00
Sonali Goel
a67e9f2d36 8068463: Group 10c: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2015-01-27 15:11:57 -08:00
Jan Lahoda
edc2052f33 8069254: Warning issued despite @SafeVarargs annotation on constructor
The Symbol created for diamond inference does not have annotations attached - need to look for @SafeVarargs on the underlying constructor's Symbol.

Reviewed-by: mcimadamore
2015-01-23 15:14:53 +01:00
Srikanth Adayapalam
25c0dd9958 8071310: Tests missing for checkin for JDK-8046977
Reviewed-by: jlahoda
2015-01-22 09:50:03 +01:00
Joel Borggrén-Franck
4b78cb3eb7 8070507: LambdaLambdaSerialized can fail in -agentvm mode
Reviewed-by: mcimadamore
2015-01-21 19:02:20 +01:00
Jan Lahoda
8944d18416 8069094: SuppressWarnings(\"deprecation\") not respected on default clause on annotation declarations
Properly deferring warnings that are reported during entering of annotation's default value.

Reviewed-by: mcimadamore
2015-01-20 12:00:25 +01:00
Srikanth Adayapalam
671f90ddc7 8052070: javac crashes when there are duplicated type parameters
Avoid eager completion of ClassSymbol while type parameters are being processed.

Reviewed-by: jlahoda, mcimadamore
2015-01-20 09:51:17 +01:00
Robert Field
6c9d4861a9 8068488: Facilitate extension of the javac parser -- missing modifier
Reviewed-by: jjg
2015-01-16 20:03:30 -08:00
Jan Lahoda
56c4de876e 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
Making sure enum's abstractness is resolved before writing InnerClasses entry about it.

Reviewed-by: mcimadamore
2015-01-16 14:47:25 +01:00
Maurizio Cimadamore
82db21e08d 8068995: Cleanup method reference lookup code
Simplify method reference code lookup and generate better/more uniform diagnostics

Reviewed-by: vromero
2015-01-15 13:58:11 +00:00
Jan Lahoda
1b90760ef4 8066843: Messager.printMessage cannot print multiple errors for same source position
Using a DiagnosticFlag to mark diagnostics that should be always printed even if multiple of them have the same source position.

Reviewed-by: darcy, jjg, mcimadamore
2015-01-13 19:13:42 +01:00
Srikanth Adayapalam
2b3c75aa36 8027888: javac wrongly allows annotations in array-typed class literals
Compiler incorrectly accepts type annotations on array-typed class literals.

Reviewed-by: jlahoda, jfranck
2015-01-13 10:36:41 +01:00
Srikanth Adayapalam
5cb253a2e9 8068254: Method reference uses wrong qualifying type
Generated code fails with IllegalAccessError due to compiler's mishandling of packageprivate classes in method reference expressions.

Reviewed-by: rfield, mcimadamore
2015-01-13 10:32:19 +01:00
Srikanth Adayapalam
33a3e1add3 8037546: javac -parameters does not emit parameter names for lambda expressions
MethodParameters attribute is missing for synthetic methods encoding lambda expressions.

Reviewed-by: rfield, mcimadamore
2015-01-13 10:25:24 +01:00
Srikanth Adayapalam
1be81e358c 8062358: ClassCastException in TransTypes.visitApply
Incorrect handling of subtype relations involving lower bounded wildcard causes ClassCastException

Reviewed-by: vromero, dlsmith
2015-01-13 10:17:25 +01:00
Jonathan Gibbons
01520ed2aa 8068759: ConstFoldTest fails on Windows
Reviewed-by: ksrini
2015-01-09 18:03:01 -08:00
Srikanth Adayapalam
4eb573aa81 8067914: Redundant type cast nodes in AST (follow up from JDK-8043741)
Workaround for redundant (but harmless) synthetic cast generated in TransTypes

Reviewed-by: mcimadamore
2015-01-09 15:51:20 +00:00
Srikanth Adayapalam
7e499fd15b 8067429: java.lang.VerifyError: Inconsistent stackmap frames at branch target
Bitset for alive variables contains info about variables out of range

Reviewed-by: mcimadamore
2015-01-09 15:50:22 +00:00
Srikanth Adayapalam
5de84c2836 8043741: VerifyError due to missing checkcast
Proto-type is not set correctly for NULLCHK synthetic trees

Reviewed-by: mcimadamore
2015-01-09 15:49:42 +00:00
Srikanth Adayapalam
0eb55d78b6 8066871: java.lang.VerifyError: Bad local variable type - local final String
BaseType() erroneously called on MethodResultInfo causes lack of constant type info

Reviewed-by: jlahoda, mcimadamore
2015-01-09 15:48:09 +00:00
Sonali Goel
274f997aee 8058373: Group 10a: golden files for tests in tools/javac dir
Reviewed-by: jjg, darcy
2015-01-08 22:01:20 -08:00
Maurizio Cimadamore
56a33e4541 8058542: Devise scheme for better diagnostic creation
Add support for generating (at build-time) an enum-like class containing all javac diagnostics, which allows for safe diagnostic creation.

Reviewed-by: jlahoda, jjg, vromero, erikj, jfranck
2015-01-08 14:43:05 +00:00
Joe Darcy
5cb7065612 8068639: Make certain annotation classfile warnings opt-in
Reviewed-by: jjg
2015-01-07 17:06:47 -08:00
Jonathan Gibbons
e6ea1f0ff8 8059977: StandardJavaFileManager should support java.nio.file.Path
Reviewed-by: jlahoda
2015-01-06 14:51:10 -08:00
Maurizio Cimadamore
75b2a03bf9 8067883: Javac misses some opportunities for diagnostic simplification
Javac always report full inference diagnostic, even when message does not mention inference variables.

Reviewed-by: jlahoda
2015-01-06 15:46:41 +00:00
Vicente Romero
f6ed87ed5a 8064857: javac generates LVT entry with length 0 for local variable
Reviewed-by: mcimadamore, jjg
2015-01-05 17:35:48 -08:00
Sonali Goel
11b1d2cdad 8054689: Split large SJavac.java test source into multiple files
Reviewed-by: jjg, jfranck
2014-12-24 11:17:51 -08:00
Maurizio Cimadamore
c269c9451b 8066974: Compiler doesn't infer method's generic type information in lambda body
Add loghic to avoid post-inference triggers on temporarty AST types

Reviewed-by: jlahoda, vromero
2014-12-18 13:21:44 +00:00
Maurizio Cimadamore
41070244c9 8067792: Javac crashes in finder mode with nested implicit lambdas
Revert tree changes occurred in Attr before running the analyzer

Reviewed-by: jlahoda
2014-12-17 16:47:56 +00:00
Jan Lahoda
627ce960f5 8067422: Lambda method names are unnecessarily unstable
Lambda method numbers are now assigned per class for non-serializable lambdas.

Reviewed-by: mcimadamore, rfield
2014-12-17 12:49:57 +01:00
Maurizio Cimadamore
eb3798a14a 8067663: Add bugId to tests that have been modified as part of JDK-8064365
Add missing bug id to modified tests

Reviewed-by: jlahoda
2014-12-16 13:44:22 +00:00
Maurizio Cimadamore
3076062240 8064365: Better support for finder capabilities in target-typing context
Add new framework to allow for easy creation of finder-like capabilities.

Reviewed-by: jjg, jlahoda
2014-12-12 18:07:24 +00:00
Jonathan Gibbons
0900c1f2e0 8066808: langtools/test/Makefile should not use OS-specific jtreg binary
Reviewed-by: mcimadamore
2014-12-11 18:23:17 -08:00
Jonathan Gibbons
827f52c966 8066807: langtools/test/Makefile should use -agentvm not -samevm
Reviewed-by: mcimadamore
2014-12-11 18:20:00 -08:00
Andrei Eremeev
282c943241 8065360: Implement a test that checks possibilty of class members to be imported
Reviewed-by: jlahoda, anazarov
2014-12-10 21:45:39 +02:00
Maurizio Cimadamore
a800908e25 8067001: DetectMutableStaticFields fails after modular images push
Ignore JRTIndex.sharedInstance

Reviewed-by: jlahoda
2014-12-09 16:09:07 +00:00
Andrei Eremeev
400505a1f2 8066961: NegativeCyclicDependencyTest.java fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jlahoda
2014-12-09 11:45:38 +01:00
Andrei Eremeev
ea81e1bc1f 8064794: Implement negative tests for cyclic dependencies in import statements
Reviewed-by: jlahoda, anazarov
2014-12-09 01:06:11 +02:00
Jan Lahoda
cf476e9302 8066902: JavacParserTest fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jjg, ksrini
2014-12-08 21:26:04 +01:00
Jan Lahoda
59b3453845 8061549: Disallow _ as a one-character identifier
Underscore is no longer a one-charater identifier with -source 9

Reviewed-by: mcimadamore, jjg
2014-12-08 18:02:07 +01:00
Jan Lahoda
113babff27 8065753: javac crashing on a html-like file
Avoiding special-case in error recovery for bad token on position 0.

Reviewed-by: jjg
2014-12-08 11:50:19 +01:00
Jonathan Gibbons
78fd11386c 8066737: langtools/test/tools/javac/processing/6348193/T6348193.java fails
Reviewed-by: darcy
2014-12-04 19:09:29 -08:00
Chris Hegarty
189df3ac57 Merge 2014-12-03 19:28:40 +00:00
Chris Hegarty
8bc2b3ff3a 8049367: Modular Run-Time Images
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Bradford Wetmore <bradford.wetmore@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: James Laskey <james.laskey@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jlahoda, ksrini
2014-12-03 14:25:46 +00:00
Jan Lahoda
d739446063 7101822: Compiling depends on order of imports
7177813: Static import to local nested class fails

MemberEnter overhaul - TypeEnter is split out of MemberEnter; the TypeEnter consists of several Phases which ensure actions are done in the correct order.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jfranck, aeremeev
2014-12-03 13:46:12 +01:00
Maurizio Cimadamore
02df6a4564 8065986: Compiler fails to NullPointerException when calling super with Object<>()
Missing POLY kind selector on recursive constructor calls with poly arguments

Reviewed-by: vromero
2014-11-28 11:45:56 +00:00
Robert Field
634c33938c 8058112: Invalid BootstrapMethod for constructor/method reference
Bridge method references with functional interface method parameters of intersection type

Reviewed-by: vromero, dlsmith
2014-11-24 14:52:46 -08:00
Jan Lahoda
26298f1124 8032211: Don't issue deprecation warnings on import statements
6598104: javac should not warn about imports of deprecated classes

Suppressing the deprecation warnings when importing a deprecated element (deprecations in import qualifier will be produced).

Reviewed-by: darcy, jjg, mcimadamore
2014-11-24 16:02:35 +01:00
Eric McCorkle
590188542e 8065132: Parameter annotations not updated when synthetic parameters are prepended
Cause javac to add synthetic parameters to Runtime[In]VisibleParameterAnnotations attributes

Reviewed-by: jjg, jfranck
2014-11-21 16:36:39 -05:00
Jonathan Gibbons
bdf693fcc5 8061876: replace java.io.File with java.nio.file.Path (again)
Reviewed-by: ksrini, jlahoda
2014-11-21 10:38:43 -08:00
Joel Borggrén-Franck
8bf55955df 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
Reviewed-by: jlahoda, vromero
2014-11-21 12:36:21 +01:00
Jonathan Gibbons
56e39629eb 8065054: Some tests have junk before the legal header
Reviewed-by: darcy
2014-11-20 14:23:31 -08:00
Vicente Romero
60113dc1ba 8063052: Inference chokes on wildcard derived from method reference
Reviewed-by: mcimadamore
2014-11-20 14:05:39 -08:00
Jonathan Gibbons
6bfd41fed8 8058445: Javac throws exception when displaying info
Reviewed-by: vromero, jfranck
2014-11-20 11:00:29 -08:00
Vicente Romero
418c9789d6 8059921: Missing compile error in Java 8 mode for Interface.super.field access
Reviewed-by: mcimadamore, jlahoda
2014-11-20 09:43:13 -08:00
Jan Lahoda
a2b0a2413e 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
Allowing final variables as operands to try-with-resources; also reviewed by Sergei Pikalev.

Reviewed-by: darcy, mcimadamore, vromero
2014-11-19 13:46:04 +01:00
Maurizio Cimadamore
5bb86103a9 8064803: Javac erroneously uses instantiated signatures when merging abstract most-specific methods
Wrong method type used in AmbiguousError.mergeAbstracts

Reviewed-by: jlahoda
2014-11-17 23:41:56 +00:00
Jan Lahoda
e158f32141 8062747: Compiler error when anonymous class uses method with parametrized exception
When inferring lambda's thrown types, avoid tracking variables that are not under the lambda to avoid crashes.

Reviewed-by: vromero
2014-11-14 11:58:28 +01:00
Jan Lahoda
b136af5563 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
When calling dupUnshared on a shared scope, make sure the result does not contain Symbols that don't belong to the scope that is being dupUnshared.

Reviewed-by: mcimadamore
2014-11-12 19:05:17 +01:00
Andrei Eremeev
9130b22f3f 8042931: Implement classfile tests for EnclosingMethod attribute
Reviewed-by: jjg, shurailine, anazarov
2014-11-12 15:16:35 +02:00
Maurizio Cimadamore
ed9c1bb743 8064464: regression with type inference of conditional expression
Bad classification of conditional leads to spurious error

Reviewed-by: jlahoda
2014-11-12 12:41:32 +00:00
Joel Borggrén-Franck
991885e85d 8060448: ArrayIndexOutOfBoundsException with annotation processing printout of empty line
Reviewed-by: jlahoda
2014-10-24 10:08:51 +02:00
Jonathan Gibbons
de2b97f133 8063145: ToolBox should support extracting classes from a JavaFileManager/Location
Reviewed-by: ksrini
2014-11-07 14:51:35 -08:00
Eric McCorkle
ab1b9a9cf1 8029012: parameter_index for type annotation not updated after outer.this added
Fix javac's handling of type annotations when synthetic parameters are added

Reviewed-by: jjg, mcimadamore
2014-11-07 07:54:35 -05:00
Eric McCorkle
aca235b121 8062245: Test executes incorrect class
Fix issue with test executing incorrect class, and trivial test failure linked to different subclasses of CharSequance.

Reviewed-by: jjg
2014-11-06 17:39:57 -05:00
Maurizio Cimadamore
87d664f4f0 8062977: Inference: NullPointerException during bound incorporation
Bogus Types.asSuper call on array type symbol

Reviewed-by: vromero
2014-11-06 14:33:22 +00:00
Maurizio Cimadamore
ded3a562b9 6987475: Order of declarations affects whether abstract method considered overridden
Types.implementation erroneously returns first matching method in hierarchy.

Reviewed-by: vromero
2014-11-06 14:31:56 +00:00
Jonathan Gibbons
c4f3406133 8063074: test/tools/javac/plugin/showType/Test.java fails on Windows
Reviewed-by: ksrini
2014-11-05 19:48:42 -08:00
Jonathan Gibbons
a75d2dbd39 8062676: Tests which leak lots of file managers should be fixed (group 2)
Reviewed-by: darcy
2014-11-05 19:12:45 -08:00
Jonathan Gibbons
b96daffd2e 8063039: incorrect message reference or broken message file
Reviewed-by: ksrini
2014-11-05 19:09:09 -08:00
Eric McCorkle
0acac5a3d5 8035259: javac, incorrect shadowing of classes vs type parameters
Cause javac to look at type variables first when resolving names in an extends/implements list

Reviewed-by: mcimadamore, jlahoda
2014-11-05 08:37:04 -05:00
Sonali Goel
4ca3a232d1 8062314: Update tools/javac/plugin/showtype/Test.java to use ToolBox.java
Reviewed-by: jjg
2014-11-04 13:21:25 -08:00
Andreas Lundblad
4a3d559ffb 8062740: Since changeset 2686:030080f03e4f test/tools/sjavac/DependencyCollection.java does no longer compile
Added throws IOException to main method.

Reviewed-by: jjg
2014-11-04 09:04:13 +01:00
Dan Smith
44213132ab 8062449: Update langtools/test/Makefile to use JCK 9
Updated to JCK 9 and improved use of variables to control the invocation

Reviewed-by: jjg, erikj
2014-10-31 17:23:21 -06:00
Kumar Srinivasan
60b8135982 8061305: Javadoc crashes when method name ends with "Property"
Reviewed-by: jjg
2014-10-31 07:02:56 -07:00
Sonali Goel
35b29e7662 8062336: Revert tools/javap/T6729471.java to original test code
Reviewed-by: jjg
2014-10-30 15:21:42 -07:00
Jonathan Gibbons
342df9829a 8062514: Update ToolTester tests to close file manager
Reviewed-by: darcy
2014-10-29 19:07:34 -07:00
Jonathan Gibbons
8bd23f1681 8062348: langtools tests should close file manager (group 1)
Reviewed-by: darcy
2014-10-29 17:25:23 -07:00
Liam Miller-Cushon
08336b39dd 8059453: javac crashes with -Xjcov and union types
Reviewed-by: jlahoda, vromero
2014-09-25 14:38:29 -07:00
Sonali Goel
0bfa3c5036 8059423: Replace references for rt.jar by temp.jar
Reviewed-by: jjg
2014-10-27 10:43:09 -07:00
Joel Borggrén-Franck
0149333fb8 8054448: (ann) Cannot reference field of inner class in an anonymous class
Reviewed-by: jlahoda, mcimadamore
2014-10-24 08:34:51 +02:00
Maurizio Cimadamore
535317c6f8 8061778: Wrong LineNumberTable for default constructors
Synthetic empty blocks generated by Lower are erroneously picked up by Gen

Reviewed-by: jjg
2014-10-24 10:54:04 +01:00
Vicente Romero
96941c8951 8057800: Method reference with generic type creates NPE when compiling
Reviewed-by: mcimadamore, dlsmith
2014-10-23 10:42:44 -07:00
Jonathan Gibbons
5074c6ed36 8061723: 8060056 breaks tests on Windows
Reviewed-by: darcy
2014-10-21 17:50:13 -07:00
Jonathan Gibbons
0e0e189bf6 8060056: replace java.io.File with java.nio.file.Path
Reviewed-by: ksrini, jlahoda
2014-10-21 13:08:20 -07:00
Eric McCorkle
8244cae54a 8054457: Refactor Symbol kinds from small ints to an enum
Replace bitmap logic in symbol.kind and pkind with an enum-based API

Reviewed-by: mcimadamore, jjg
2014-10-21 09:01:51 -04:00
Jonathan Gibbons
cf1a634000 8040131: Implement classfile test for LineNumberTable attribute
Reviewed-by: jjg, shurailine
2014-10-16 14:31:37 -07:00
Maurizio Cimadamore
2756ed20d7 8058511: StackOverflowError at com.sun.tools.javac.code.Types.lub
Lub crashes when handling typevar with array bound

Reviewed-by: vromero, dlsmith
2014-10-14 12:01:05 +01:00
Maurizio Cimadamore
8f96799dd5 8058199: Code generation problem with javac skipping a checkcast instruction
TransTypes sometimes ignores inferred signatures when emitting synthetic casts

Reviewed-by: vromero
2014-10-14 12:00:39 +01:00
Paul Govereau
8cc03657e9 8060249: Backout fix for JDK-8058243
Reviewed-by: vromero
2014-10-13 17:09:12 -04:00
Paul Govereau
ef05cafd6b 8060234: Fix push for JDK-8058243
Reviewed-by: jjg, vromero
2014-10-13 12:12:06 -04:00
Jan Lahoda
1eb03e49bf 8054956: Javac reports wrong error offset for unknown identifier of annotation element/value pair
When reporting an error about unresolvable annotation attribute, use the position of the explicit left-hand-side of the assignment if available, otherwise use the position of the right-hand-side.

Reviewed-by: jfranck
2014-10-13 17:22:47 +02:00
Sonali Goel
a7b8ca6209 8058410: Group 10b: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-10-10 14:41:50 -07:00
Jan Lahoda
e95348b58e 8057652: Request to improve error messages for labeled declarations
Parse labeled statements as block statements to improve error recovery for labeled declarations; related cleanup.

Reviewed-by: jjg
2014-10-09 10:08:52 +02:00
Andreas Lundblad
0545e4b847 8059349: Public API scanning should be implemented in the form of a TaskListener
Replaces JavaCompilerWithDeps with a TaskListener.

Reviewed-by: jfranck
2014-10-07 21:21:42 +02:00
Andreas Lundblad
96074068b8 8056258: Analysis of public API does not take super classes into account
8048609: simplify sjavac dependence on javac dependency gathering

Replaces Attr-/ResolveWithDeps with TaskListeners

Reviewed-by: jfranck, ohrstrom
2014-10-07 21:15:10 +02:00
Robert Field
e55ca9fc58 8056051: int[]::clone causes "java.lang.NoClassDefFoundError: Array"
Reviewed-by: mcimadamore, vromero
2014-10-04 10:13:11 -07:00
Sonali Goel
1f9a38f175 8055783: Group 9e: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2014-10-01 14:15:40 -07:00
Bhavesh Patel
3fad9f6677 8048351: tidy errors for attribute href, name for langtools javadoc tests needs investigation
Reviewed-by: jjg
2014-09-26 13:51:43 -07:00
Vicente Romero
97309123c1 8058708: java.lang.AssertionError compiling source code
Reviewed-by: jjg
2014-09-25 17:09:23 -07:00
Neil Toda
9fbf466c3f 8050117: add to javac test Versions.java tests that show correct operation for source/target options pre 1.9
Reviewed-by: jjg
2014-09-25 13:54:45 -07:00
Eric McCorkle
b4401ebed9 8048614: Add TypeMetadata to contain type annotations and other type information
Implement general framework for metadata on types

Reviewed-by: mcimadamore
2014-09-22 17:09:33 -04:00
Jan Lahoda
c30ea9e1d2 8057794: Compiler Error when obtaining .class property
Ensuring a non-null type and sym for illegal T.class to prevent downstream errors.

Reviewed-by: mcimadamore
2014-09-22 14:55:14 +02:00
Sonali Goel
2700003cdb 8058755: Update tools/javadoc/6227454 to add head tag
Reviewed-by: jjg
2014-09-19 13:54:34 -07:00
Bhavesh Patel
b02c07123c 8047745: Javadoc should include encoding information in generated html files
Reviewed-by: jjg, ksrini
2014-09-18 00:50:48 -07:00
Bhavesh Patel
99ec33372d 8043698: <title> tag not getting generated in package-summary pages for un-named packages
Reviewed-by: jjg, ksrini
2014-09-17 23:52:19 -07:00
Maurizio Cimadamore
ae97aeb0d9 8055963: Inference failure with nested invocation
Revise heuristics to force eager instantiation of return inference vars

Reviewed-by: vromero
2014-09-15 12:43:35 +01:00
Sonali Goel
79efb2b9d8 8055080: Group 9d: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore, jlahoda
2014-09-12 17:05:18 -07:00
Paul Govereau
d65d28d993 8054210: NullPointerException when compiling specific code
Reviewed-by: vromero, jlahoda
2014-09-09 12:16:25 -04:00
Paul Govereau
a37e9881b2 8055500: fix for 8030046 is incorrect
Reviewed-by: jjg, ksrini
2014-09-09 11:55:47 -04:00
Jan Lahoda
2beda23cf8 8057753: Test langtools/test/tools/javac/NoClass.java is failing when run together with langtools/test/tools/javac/DuplicateImport.java
Removing javac/NoClass test, as it is superseded by javac/importChecks/InvalidImportsNoClasses.java

Reviewed-by: jfranck
2014-09-08 15:51:29 +02:00
Maurizio Cimadamore
a9061c2918 8055514: Wrong, confusing error when non-static varargs referenced in static context
Improved heuristics in MethodResolutionPhase.mergeResults()

Reviewed-by: vromero
2014-09-08 14:16:33 +01:00
Joel Borggrén-Franck
053a9d56cd 8056021: checkin for JDK-8027262 breaks Checker Framework
Reviewed-by: jjg, mcimadamore
2014-09-08 13:11:28 +02:00
Jan Lahoda
f211cac0cd 8056984: Exception in compiler: java.lang.AssertionError: isSubClass T
Must use type variable's captured bound as a method receiver, instead of the type variable itself, while checking if deferred attribution is needed.

Reviewed-by: mcimadamore, vromero
2014-09-08 10:50:59 +02:00
Jan Lahoda
49469c49d0 8056014: Type inference may be skipped for a complex receiver generic method in a parameter position
When checking if deferred attribution is needed for a chain of methods, stop on any method that returns any type variable, as the rest of analysis cannot use the correct type.

Reviewed-by: mcimadamore, vromero
2014-09-08 10:48:18 +02:00
Sonali Goel
f064e2b028 8055079: Group 9c: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-09-05 16:51:39 -07:00
Sonali Goel
170f8549b4 8055075: Group 9b: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-09-05 16:43:00 -07:00
Sonali Goel
15420bd193 8055996: Remove @ignore from tools/javac/T6725036.java
Reviewed-by: jjg
2014-09-04 16:52:40 -07:00
Jan Lahoda
6cac1178ba 8047675: tools/javac/defaultMethods/Assertions.java fails if run with -enableassertions (-ea)
Using ToolBox to start new Java processes, to avoid passing default VM options to the newly started process.

Reviewed-by: jjg
2014-09-04 08:49:20 +02:00
Jan Lahoda
83abeb739b 8054563: Update RunCodingRules.java for source code reorg
Tests RunCodingRules and MessageInfo fixed to work in the new source code structure.

Reviewed-by: jjg
2014-09-04 08:48:29 +02:00
Jonathan Gibbons
f0b4f3d282 8038414: Constant pool's strings are not escaped properly
Reviewed-by: jjg, mcimadamore, ksrini
2014-09-03 14:19:39 -07:00
Jonathan Gibbons
3b029e1995 8034861: Incorrect format and indentation of InnerClasses section
Reviewed-by: jjg, ksrini, mcimadamore, lagergren
2014-09-03 14:06:25 -07:00
Alexander Zuev
f4e40eeff6 8044597: Request to update tools/javap/T4501661.java to add test for package option
Reviewed-by: jjg
2014-09-03 19:22:16 +04:00
Sonali Goel
b8919f9429 8056288: Missing bug id in test/com/sun/javadoc/testOrdering/TestOrdering.java
Reviewed-by: ksrini
2014-08-29 14:08:49 -07:00
Sonali Goel
f4dc4013f0 8055074: Group 9a: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-08-29 00:42:42 -07:00
Sonali Goel
e2312f606b 8049126: golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-28 23:42:16 -07:00
Joe Darcy
d66c4567ee 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed
Reviewed-by: ksrini
2014-08-28 11:29:34 -07:00
Andreas Lundblad
43eb10bcb8 8054500: Refactor sjavac Main class into ClientMain and ServerMain
Restructured Main into ClientMain and ServerMain

Reviewed-by: jfranck
2014-08-28 17:38:40 +02:00
Kumar Srinivasan
5f800435e3 8050031: [javadoc] class-use pages have duplicates and missing entries
Reviewed-by: jjg
2014-08-27 06:56:29 -07:00
Jonathan Gibbons
08e122f2cb 8044859: javac duplicates option processing when using Compiler API
Reviewed-by: mcimadamore, vromero, jlahoda
2014-08-22 16:28:16 -07:00
Kumar Srinivasan
9867d883ad 8055501: [javac] ignore test/tools/javac/Paths/AbsolutePathTest.java
Reviewed-by: jjg
2014-08-19 15:34:01 -07:00
Chris Hegarty
2d81f9c851 Merge 2014-08-18 10:59:44 +01:00
Chris Hegarty
2b80c4715f 8054834: Modular Source Code
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Reviewed-by: alanb, chegar, ihse, mduigou
2014-08-17 15:52:32 +01:00
Paul Govereau
7cb1497762 8054556: javac should report the error for default usage as the primary error
Reviewed-by: jjg
2014-08-15 11:02:14 -04:00
Jonathan Gibbons
1cf35244f6 8055076: fix test failures in classfile tests
Reviewed-by: darcy
2014-08-13 15:47:58 -07:00
Eric McCorkle
52b5861793 Merge 2014-08-13 21:58:29 +00:00
Jonathan Gibbons
33e6564a6b 8050429: Update/cleanup ToolBox
Reviewed-by: vromero
2014-08-13 13:20:31 -07:00
Andreas Lundblad
ce4c456820 8048457: Sjavac should not use portfiles, sockets, etc if background=false
8044131: Restructure client / server protocol code

Changes protocol code to use Object input/output streams. Avoids spawning server if background=false. Refactors idleness checks, pooling and port file monitoring.

Reviewed-by: jjg, jfranck
2014-08-13 14:44:59 +02:00
Sonali Goel
14e6aa6b9e 8049130: Group 8d - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:48:30 -07:00
Sonali Goel
32b768c531 8049129: Group 8c - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:39:56 -07:00
Sonali Goel
40f4caa8d0 8049127: Group 8b - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:31:31 -07:00
Sonali Goel
bf789b2a48 8054964: Add a test for invalid package annotations
Reviewed-by: jjg
2014-08-12 16:41:05 -07:00
Andrei Eremeev
8740c99fbd 8042251: Implement classfile tests for InnerClasses attribute
Reviewed-by: jjg, anazarov, shurailine
2014-08-12 13:24:40 +04:00
Kumar Srinivasan
714d7c813a 8054044: [javadoc] javadoc tester must print out the javadoc run arguments
Reviewed-by: jjg, sogoel
2014-08-11 10:16:55 -07:00
Fredrik Öhrström
c110d6437f 8054465: Add --permit-artifact=bar to sjavac
Add --permit-artifact=bar to white-list files that have been written to the destination directory and that sjavac should not delete.

Reviewed-by: jjg, alundblad
2014-08-09 00:56:29 +02:00
Fredrik Öhrström
c8256e4d27 8054474: Add --state-dir=bar to sjavac
Add --state-dir=bar to sjavac to control where sjavac stores the javac_state file.

Reviewed-by: jjg, alundblad
2014-08-08 21:26:23 +02:00
Fredrik Öhrström
ce6154a2fa 8054461: Add @file support to sjavac
Add @file support to sjavac commandline.

Reviewed-by: jjg, alundblad
2014-08-08 20:47:24 +02:00
Jan Lahoda
66ea31ef63 8043643: Add an crules analyzer avoiding string concatenation in messages of Assert checks
Generalizing the crules infrastructure, adding a new analyzer to check String concatenation in Assert calls.

Reviewed-by: jjg, vromero
2014-08-01 11:09:40 -07:00
Alexander Zuev
5284120119 8047072: javap OOM on fuzzed classfile
Reviewed-by: jjg
2014-07-30 20:31:39 +04:00
Maurizio Cimadamore
560c7c91fe 8051958: Cannot assign a value to final variable in lambda
Remove Attr.owner and refactor code for detecting forward field references

Reviewed-by: vromero
2014-07-29 15:31:57 -07:00
Andrey Nazarov
0f64892089 8050979: Provide javadoc for "framework" classes in langtools tests
Reviewed-by: jjg
2014-07-24 15:12:48 -07:00
Andrey Nazarov
0308bdc9d1 8050319: LocalVariableTestBase has unexpected dependency on LocalVariableTableTest
Reviewed-by: jjg, ksrini
2014-07-23 09:19:23 -07:00
Sonali Goel
248c1db2be 8050954: update DocRootSlash test for tidy error: empty <p>
Reviewed-by: ksrini, bpatel
2014-07-17 16:46:29 -07:00
Sonali Goel
a047a4f1ec 8048837: .out files for generics tests in tools/javac dir - part 3
Reviewed-by: jjg
2014-07-17 11:22:47 -07:00
Sonali Goel
5324b04fde 8048836: .out files for generics tests in tools/javac dir
Reviewed-by: jjg
2014-07-17 11:14:39 -07:00
Mandy Chung
acacb0481e 8050804: (jdeps) Recommend supported API to replace use of JDK internal API
Reviewed-by: dfuchs
2014-07-17 10:17:58 -07:00
Sonali Goel
541591d644 8048833: .out files for generics tests in tools/javac dir
Reviewed-by: jjg
2014-07-17 09:56:07 -07:00
Joe Darcy
dee421ed14 8050430: Provided new utility visitors supporting SourceVersion.RELEASE_9
Reviewed-by: jjg
2014-07-17 09:47:25 -07:00
Vicente Romero
aa91971a3c 8051004: javac, incorrect bug id in tests for JDK-8050386
Reviewed-by: mcimadamore
2014-07-17 10:55:50 -04:00
Vicente Romero
3e002a08e6 8050386: javac, follow-up of fix for JDK-8049305
Reviewed-by: mcimadamore
2014-07-16 10:47:56 -04:00
Vicente Romero
6edca1025f 8050283: fix for JDK-8049305 should be removed
Reviewed-by: jjg
2014-07-14 16:59:25 -04:00
Jonathan Gibbons
6ec02aa50b 8046824: class SJavacTestUtil and *Wrapper are redundant and should be removed
Reviewed-by: ksrini
2014-07-14 11:46:31 -07:00
Vicente Romero
1e87b47b2a 8049305: Verification error due to a bad stackmap frame generated by javac
Reviewed-by: mcimadamore
2014-07-14 13:36:30 -04:00
Jan Lahoda
603d592a91 8049948: Restore NonDirectSuper.java test
Reviewed-by: jjg
2014-07-14 12:03:08 +02:00
Jan Lahoda
eb1f1c05ed 8048805: Request to investigate and update lexer error recovery in javac
8046620: Further investigation needed for few error messages for negative unicode tests in langtools regression ws
8048803: javac should report complete character code in the error messages

Improving error reporting and recovery in the lexer

Co-authored-by: Sonali Goel <sonali.goel@oracle.com>
Reviewed-by: jjg, mcimadamore
2014-07-14 12:02:58 +02:00
Kumar Srinivasan
0752cdda93 8039028: [javadoc] refactor the usage of Util.java
Reviewed-by: jjg
2014-06-15 08:41:57 -07:00
Jonathan Gibbons
92884a5338 8050106: JavaCompiler relies on inappropriate result from comparison
Reviewed-by: darcy
2014-07-12 07:32:28 -07:00
Jonathan Gibbons
84e4fca0c8 8048806: Javadoc errors out on some valid HTML tags
Reviewed-by: bpatel
2014-07-11 18:51:32 -07:00
Kumar Srinivasan
c626683b26 8049396: [javadoc] add more class-use test cases
Reviewed-by: jjg
2014-07-11 06:52:04 -07:00
Kumar Srinivasan
4fa698fe42 8049393: [javadoc] parameters are not sorted correctly
Reviewed-by: jjg
2014-06-29 17:13:55 -07:00
Neil Toda
f7234f052c 8030610: replace test/tools/javac/versions/check.sh
Reviewed-by: jjg
2014-07-10 16:03:45 -07:00
Neil Toda
b4b2f994ca 8011044: Remove support for 1.5 and earlier source and target options
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: darcy, jjg
2014-07-10 13:57:27 -07:00
Vicente Romero
5916a0adfa 8033483: Should ignore nested lambda bodies during overload resolution
Reviewed-by: mcimadamore, dlsmith
2014-07-09 10:49:32 -04:00
Jan Lahoda
0067b70725 8031569: Refactor javac scope implementation to enable lazy imports
Introducing an internal API for Scope; rewriting ImportScopes to extend CompoundScopes.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jjg, jfranck
2014-07-09 16:32:05 +02:00
Mandy Chung
c2f98fba15 8029548: (jdeps) use @jdk.Exported to determine supported vs JDK internal API
8031092: jdeps does not recognize --help option
8048063: (jdeps) Add filtering capability

Reviewed-by: alanb, dfuchs
2014-07-08 18:26:34 -07:00
Maurizio Cimadamore
15cfa4aac9 8043926: javac, code valid in 7 is not compiling for 8
Type-containment doesn't handle inference variables correctly

Reviewed-by: vromero, dlsmith
2014-07-08 15:42:04 +01:00
Jan Lahoda
3c5b32658b 8042239: javac: TreeMaker.Type(Type t) does not handle UnionClassType
Enhancing TreeMaker.Type(Type t) with support for UnionClassType and IntersectionClassType.

Co-authored-by: Robert Field <robert.field@oracle.com>
Reviewed-by: vromero, rfield
2014-07-08 15:13:16 +02:00
Sonali Goel
5437ec7e74 8044080: .out files for unicode, implicitThis and importChecks tests in tools/javac dir
Reviewed-by: jjg
2014-07-07 13:39:31 -07:00
Sonali Goel
9c09973b5a 8049491: Remove three auxilary files in tools/javac/enum dir
Reviewed-by: jjg
2014-07-07 12:55:00 -07:00
Sonali Goel
3ecb57ccc0 8046618: .out files for enum tests in tools/javac/dir
Reviewed-by: jjg
2014-07-07 12:44:20 -07:00
Sonali Goel
0718a280b0 8046635: .out files for enum tests in tools/javac/dir
Reviewed-by: jjg
2014-07-07 12:36:45 -07:00
Vicente Romero
72d5723212 8049075: javac, wildcards and generic vararg method invocation not accepted
Reviewed-by: mcimadamore
2014-07-04 16:34:44 +01:00
Jonathan Gibbons
12b653bb02 8042261: Implement classfile tests for Deprecated attribute
Reviewed-by: jjg, anazarov, shurailine
2014-07-04 10:52:22 +01:00
Sonali Goel
50e8d8b28d 8049284: Missing bug id in test/tools/javac/varargs/warning/Warn*
Reviewed-by: darcy
2014-07-03 15:48:23 -07:00
Sonali Goel
2caa264885 8046770: .out files for assert, boxing, and overload tests in tools/javac dir
Reviewed-by: jjg
2014-07-02 14:27:10 -07:00
Sonali Goel
9343037434 8044864: .out files for enum tests in tools/javac dir - part 1
Reviewed-by: jjg
2014-07-02 13:29:58 -07:00
Sonali Goel
8244fe0c5c 8044236: create .out files for DefiniteAssignment tests in tools/javac dir
Reviewed-by: jjg, vromero
2014-07-02 12:04:04 -07:00
Jan Lahoda
670eff1ee6 6707032: Division by zero warning not suppressed properly in some cases
Delay reporting of the division by zero warning until annotations are resolved, so that @SuppressWarnings works correctly.

Reviewed-by: vromero
2014-06-30 17:08:06 +02:00
Kumar Srinivasan
729fe3ec72 8047162: [javadoc] index files are non deterministic
Reviewed-by: jjg
2014-06-27 17:54:54 -07:00
Andreas Lundblad
8baafcf7ef 8048594: The sjavac client/server protocol should be hidden behind an interface
Reviewed-by: jfranck
2014-06-17 14:01:27 +02:00
Vicente Romero
ce0935812b 8047719: Incorrect LVT in switch statement
Reviewed-by: jjg, jlahoda
2014-06-27 20:32:12 +01:00
Sonali Goel
2f5e083cee 8048293: update tools/javadoc/6227454 to have missing <head> tag
Reviewed-by: jjg, bpatel
2014-06-26 16:39:14 -07:00
Sonali Goel
3e316a3372 8047316: update javadoc tests to fix tidy warning for incorrect html comment
Reviewed-by: jjg, ksrini
2014-06-26 16:07:07 -07:00
Sonali Goel
bbc0df83f4 8048168: update 2 javadoc tests to add summary attribute for table tag
Reviewed-by: jjg, ksrini
2014-06-26 15:47:52 -07:00
Sonali Goel
8828870971 8047744: update 2 javadoc tests for nested emphasis <code>
Reviewed-by: jjg, ksrini
2014-06-26 15:41:05 -07:00
Sonali Goel
41005acef2 8047743: update com/sun/javadoc/testHref for unrecognized <action>
Reviewed-by: jjg, ksrini
2014-06-26 15:30:21 -07:00
Sonali Goel
7470fabe6f 8047303: update com/sun/javadoc/DocRootSlash/DocRootSlash for unexpected </a>
Reviewed-by: jjg, ksrini
2014-06-26 15:21:44 -07:00
Jonathan Gibbons
47c543e53b 8007307: DPrinter: support the DocTree API
Reviewed-by: mcimadamore
2014-06-26 11:45:51 -07:00
Jonathan Gibbons
bd97e7d5ec 8047183: JDK build fails with sjavac enabled
Reviewed-by: mcimadamore
2014-06-26 11:31:59 -07:00
Paul Govereau
5b1596bc25 8042345: getDocComment fails for doc comments on PackageElement found in package-info.java
Reviewed-by: jjg
2014-06-26 13:48:58 -04:00
Robert Field
30f70a0e1d 8048121: javac complex method references: revamp and simplify
8038776: VerifyError when running successfully compiled java class

Add tests missing from the push of 8037404

Reviewed-by: dlsmith, vromero
2014-06-25 11:22:27 -07:00
Kumar Srinivasan
7aa3c59051 8047157: [javadoc] fixup tests for determinism and add classes uses
Reviewed-by: jjg
2014-06-24 15:15:22 -07:00
Joe Darcy
b963c0bc59 7196160: Project Coin: allow @SafeVarargs on private methods
Reviewed-by: jjg
2014-06-24 10:51:00 -07:00
Robert Field
802429b65f 8037404: javac NPE or VerifyError for code with constructor reference of inner class
8047341: lambda reference to inner class in base class causes LambdaConversionException
8044748: JVM cannot access constructor though ::new reference although can call it directly
8044737: Lambda: NPE while obtaining method reference through lambda expression

Revamp and simplify handling of complex method references

Reviewed-by: dlsmith, vromero
2014-06-24 00:43:46 -07:00
Sonali Goel
ae6f87cc24 8047300: update tools/javadoc/6227454 test for missing <DOCTYPE> tags
Reviewed-by: jjg, ksrini
2014-06-20 13:26:24 -07:00
Vicente Romero
1ff4245739 8044546: Crash on faulty reduce/lambda
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, dlsmith
2014-06-20 20:36:54 +01:00
Robert Field
5fad815dec 8046060: Different results of floating point multiplication for lambda code block
Propogate strictfp into lambda body

Reviewed-by: vromero, jlahoda
2014-06-20 10:56:47 -07:00
Dan Smith
fe46aeabb0 8047407: Add test for JDK-8037385
Reviewed-by: mcimadamore
2014-06-20 11:42:16 -06:00
Dan Smith
06b8a7ac80 8034147: javac crashes with a NullPointerException during bounds checking
Types.supertype should return Type.noType rather than null

Reviewed-by: vromero, mcimadamore
2014-06-20 10:56:31 -06:00
Vicente Romero
d7c001dd04 8042759: Lambda returning implicitly-typed lambdas considered pertinent to applicability
Reviewed-by: mcimadamore
2014-06-19 23:52:33 +01:00
Jan Lahoda
9d852a54ef 8041648: do while loop that misses ending semicolon has wrong end position
Ensure the end positions are meaningful even if statement's semicolon is missing.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-06-19 22:06:29 +02:00
Vicente Romero
5b199f3cb8 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
2014-06-19 15:39:37 +01:00
Sonali Goel
17f9ae5713 8046071: update three javadoc tests for empty <p> tag
Reviewed-by: jjg, ksrini
2014-06-18 14:58:16 -07:00
Jan Lahoda
e6b9e34ebe 8046916: Type parameter annotations don't work with multiple type parameters
When reading type variable's annotations out of the owner's type annotations, use the type variable's index in owner to exclude annotations belonging to other type variables.

Reviewed-by: jfranck, emc
2014-06-18 10:44:16 +02:00
Vicente Romero
e4773094de 8036953: Fix timing of varargs access check, per JDK-8016205
Reviewed-by: mcimadamore, dlsmith
2014-06-17 17:33:01 +01:00
Paul Govereau
f2e2245e7b 8038975: Access control in enhanced for
Reviewed-by: vromero, jlahoda
2014-06-17 11:11:59 -04:00
Jonathan Gibbons
2613fffb87 8046369: sjavac should not use javac internal API for starting javac
Reviewed-by: jfranck, alundblad, ohrstrom
2014-06-16 11:30:31 -07:00
Andreas Lundblad
77fa3101ec 8042830: A recently added Xprefer test fails on Windows
Test now accepts both / and \ as file separator.

Reviewed-by: mcimadamore
2014-06-12 14:29:09 +02:00
Kumar Srinivasan
b18841ffa0 8042829: [javadoc] index-file output is not sorted correctly
8043062: JDK 9 platform and compiler upgrade failed on Solaris-sparcv9 with Javadoc.gmk:360: recipe for target docs/api/index.html

Reviewed-by: erikj, jjg
2014-05-22 12:16:53 -07:00
Eric McCorkle
29e8b83b48 8043484: DPrinter does not compile
Make DPrinter compile

Reviewed-by: jjg
2014-06-12 11:32:23 -04:00
Paul Govereau
577b60e711 8027886: javac allows illegal receiver parameters
8029042: Receiver parameter not supported on local class constructor

Reviewed-by: jfranck, jlahoda
2014-06-11 12:49:10 -04:00
Dan Smith
3ea78c679c 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
Capture intersection supertypes before comparing their members

Reviewed-by: vromero
2014-06-10 15:25:01 -06:00
Dan Smith
6e1ae5955e 8037385: constant pool errors with -target 1.7 and static default methods
Add error check for static interface methods invoked from -source 7

Reviewed-by: vromero, mcimadamore
2014-06-10 12:41:39 -06:00
Maurizio Cimadamore
dab523a752 8043725: javac fails with StackOverflowException
Loose type comparison test should be protected against infinite recursion with fbounds

Reviewed-by: vromero
2014-06-09 12:54:02 +01:00