Commit Graph

62327 Commits

Author SHA1 Message Date
Roberto Castañeda Lozano
4e8338eb13 8255763: C2: OSR miscompilation caused by invalid memory instruction placement
Disable GCM hoisting of memory-writing nodes for irreducible CFGs. This prevents
GCM from wrongly "hoisting" stores into descendants of their original loop. Such
an "inverted hoisting" can happen due to CFGLoop::compute_freq()'s inaccurate
estimation of frequencies for irreducible CFGs.

Extend CFG verification code by checking that memory-writing nodes are placed in
either their original loop or an ancestor.

Add tests for the reducible and irreducible cases. The former was already
handled correctly before the change (the frequency estimation model prevents
"inverted hoisting" for reducible CFGs), and is just added for coverage.

This change addresses the specific miscompilation issue in a conservative way,
for simplicity and safety. Future work includes investigating if only the
illegal blocks can be discarded as candidates for GCM hoisting, and refining
frequency estimation for irreducible CFGs.

Reviewed-by: kvn, chagedorn
2020-12-21 13:04:24 +00:00
Roman Kennke
2525f39d35 8258714: Shenandoah: Process references before evacuation during degen
Reviewed-by: shade
2020-12-21 12:42:34 +00:00
Brent Christian
e680ebeb2f 8258007: Add instrumentation to NativeLibraryTest
Reviewed-by: mchung, naoto
2020-12-19 00:17:02 +00:00
Jonathan Gibbons
c04c7e1f10 8258002: Update "type" terminology in generated docs
Reviewed-by: hannesw
2020-12-18 18:34:25 +00:00
Hannes Wallnöfer
45bd3b9ec0 8223607: --override-methods=summary ignores some signature changes
Reviewed-by: jjg
2020-12-18 15:46:25 +00:00
Jie Fu
59ae054873 8258687: Build broken on Windows after fix for JDK-8258134
Reviewed-by: thartmann
2020-12-18 14:13:01 +00:00
Joel Borggrén-Franck
1cc98bde67 8256693: getAnnotatedReceiverType parameterizes types too eagerly
Reviewed-by: vromero
2020-12-18 13:34:36 +00:00
Richard Reingruber
1ce2e94f5f 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
Reviewed-by: mdoerr, lucy
2020-12-18 13:16:09 +00:00
Jie Fu
45a150b8dc 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines
Reviewed-by: kvn, thartmann
2020-12-18 12:50:19 +00:00
Stefan Johansson
38593a4f2a 8257974: Regression 21% in DaCapo-lusearch-large after JDK-8236926
Reviewed-by: ayang, redestad, tschatzl
2020-12-18 08:14:58 +00:00
Sergey Bylokhov
7afb01dce9 8258373: Update the text handling in the JPasswordField
Reviewed-by: kizune, prr, psadhukhan
2020-12-18 06:26:16 +00:00
Stuart Marks
cbc3feeb89 8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812
Reviewed-by: naoto
2020-12-18 00:36:33 +00:00
Nils Eliasson
7320e051ea 8258647: TestCharVect2 is very slow
Reviewed-by: vlivanov, kvn
2020-12-17 22:43:00 +00:00
Rajan Halade
9fdfc6dfc6 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
8258630: Add expiry exception for QuoVadis root certificate

Backport-of: 666e6c4033
2020-12-17 22:14:25 +00:00
Jonathan Gibbons
30ca0a5d4b 8247994: Localize javadoc search
Reviewed-by: hannesw, ihse
2020-12-17 18:34:27 +00:00
Vicente Romero
47c180da43 8258515: javac should issue an error if an annotation is nested in a local class or interface
Reviewed-by: jjg
2020-12-17 18:08:35 +00:00
Nils Eliasson
cb5a6b1a7d 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
Reviewed-by: vlivanov, thartmann, kvn
2020-12-17 17:50:53 +00:00
Alexey Semenyuk
61cbf0fffe 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
Reviewed-by: almatvee, herrick
2020-12-17 15:33:03 +00:00
Markus Grönlund
7aac4dc175 8257621: JFR StringPool misses cached items across consecutive recordings
Reviewed-by: egahlin
2020-12-17 14:34:44 +00:00
Kim Barrett
61390d8e45 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
Reviewed-by: sjohanss, tschatzl
2020-12-17 14:18:00 +00:00
Julia Boes
952dc70402 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
Reviewed-by: darcy
2020-12-17 11:32:58 +00:00
Christian Hagedorn
04a1e5b75b 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions
Reviewed-by: thartmann, kvn, dcubed
2020-12-17 08:09:19 +00:00
Guoxiong Li
41f312eb64 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation
Reviewed-by: jfranck, vromero
2020-12-17 08:06:35 +00:00
Jonathan Gibbons
ce0ab2dd84 8258338: Support deprecated records
Reviewed-by: hannesw
2020-12-16 22:26:57 +00:00
Jonathan Gibbons
6b4b676550 8241353: NPE in ToolProvider.getSystemJavaCompiler
Reviewed-by: vromero
2020-12-16 22:21:54 +00:00
Anton Litvinov
87644a2bb7 8255880: UI of Swing components is not redrawn after their internal state changed
Reviewed-by: prr
Backport-of: e8c40bafa5
2020-12-16 19:48:07 +00:00
Julia Boes
72dfba8053 8257637: Update usage of "type" terminology in java.lang.annotation
Reviewed-by: darcy
2020-12-16 10:46:39 +00:00
Calvin Cheung
b5a3a5b621 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
Reviewed-by: redestad, coleenp
2020-12-16 02:37:29 +00:00
Weijun Wang
b97fe6c410 8258419: RSA cipher buffer cleanup
Reviewed-by: valeriep
2020-12-15 22:49:35 +00:00
Tom Rodriguez
1f556d22ca 8258380: [JVMCI] don't clear InstalledCode reference when unloading JVMCI nmethods
Reviewed-by: kvn, eosterlund
2020-12-15 21:31:00 +00:00
Pankaj Bansal
e7aa5fe602 8258427: Problem List some tests related to FileDialog for MacOS
Reviewed-by: prr, serb
2020-12-15 21:28:50 +00:00
Joe Darcy
e9113517d4 8258140: Update @jls tags in java.base for renamed/renumbered sections
Reviewed-by: psandoz
2020-12-15 16:48:31 +00:00
Christian Hagedorn
ce36aeaac3 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
Reviewed-by: kvn, thartmann
2020-12-15 15:14:34 +00:00
Markus Grönlund
fa1cbb47aa 8258404: Restore stacktrace reuse after 8258094
Reviewed-by: egahlin
2020-12-15 14:48:57 +00:00
Maurizio Cimadamore
7ff9c85639 8258242: Type profile pollution occurs when memory segments of different kinds are used
Reviewed-by: vlivanov, redestad
2020-12-15 13:50:40 +00:00
Richard Reingruber
09e8675f56 8255381: com/sun/jdi/EATests.java should not suspend graal threads
Reviewed-by: cjplummer, mdoerr, sspitsyn
2020-12-15 08:38:58 +00:00
Markus Grönlund
afc44414d5 8258094: AIX build fails after 8257602
Reviewed-by: rrich, stuefe, egahlin
2020-12-14 11:36:01 +00:00
Hannes Wallnöfer
164c8a6e18 8258092: Link to early access platform documentation in TestHtmlTableTags.java
Reviewed-by: jjg
2020-12-14 08:08:57 +00:00
Martin Buchholz
43dc3f7992 8254350: CompletableFuture.get may swallow InterruptedException
Reviewed-by: alanb, dl
2020-12-13 19:17:36 +00:00
Aleksey Shipilev
6d79ec87fb 8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
Reviewed-by: iignatyev, kvn
2020-12-12 06:09:57 +00:00
Mandy Chung
2001da3dd4 8257596: Clarify trusted final fields for record classes
Reviewed-by: hseigel, chegar, psandoz
2020-12-11 22:44:48 +00:00
Vladimir Ivanov
b1afed7501 8257919: [JVMCI] profiling info didn't change after reprofile
Reviewed-by: kvn, redestad
2020-12-11 21:50:49 +00:00
Vicente Romero
b7ac32d6ee 8257598: Clarify what component values are used in Record::equals
Reviewed-by: darcy, chegar
2020-12-11 19:16:34 +00:00
Joe Darcy
a280182956 8258060: Update @jls tags for renamed/renumbered sections
Reviewed-by: jjg, abuckley
2020-12-11 18:38:45 +00:00
Thomas Schatzl
bacf22b907 8256641: CDS VM operations do not lock the heap
Reviewed-by: kbarrett, iklam
2020-12-11 18:14:37 +00:00
Yudi Zheng
58dca9253d 8257910: [JVMCI] Set exception_seen accordingly in the runtime.
Reviewed-by: kvn
2020-12-10 22:43:37 +00:00
Markus Grönlund
e90d0d1da4 8258065: ProblemList JfrGTestAdaptiveSampling
Reviewed-by: iignatyev
2020-12-10 22:25:23 +00:00
Doug Simon
fa77008f19 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes
Reviewed-by: kvn
Backport-of: d163c6fe2e
2020-12-10 21:18:35 +00:00
Maurizio Cimadamore
37043b0557 8257837: Performance regression in heap byte buffer views
Reviewed-by: chegar, roland
2020-12-10 15:32:36 +00:00
Magnus Ihse Bursie
0890620c94 8258005: JDK build fails with incorrect fixpath script
Co-authored-by: Mikael Vidstedt <mikael@openjdk.org>
Reviewed-by: erikj
2020-12-10 14:54:40 +00:00