Commit Graph

1382 Commits

Author SHA1 Message Date
Neil Toda
735e586b5f 8035878: javadoc tool documentation should be using {@code ..} specifier
Reviewed-by: jjg
2014-03-03 15:24:31 -08:00
Neil Toda
72641e4e7f 8035877: javadoc classes are missing @return and @param tags
Reviewed-by: jjg
2014-03-03 15:10:01 -08:00
Neil Toda
1f9569d235 8035875: remove deprecated html <font> tags from javadoc package-info.java file
Reviewed-by: jjg
2014-03-03 15:03:17 -08:00
Eric McCorkle
6b9060ac8f 8036142: Remove redundant call to annotateTypeLater with null Symbol
AnnotateTypeLater (formerly typeAnnotate) with null as the symbol was a way to force attribution of type annotations, but this is now obsolete and problematic, and a silent noop condition

Reviewed-by: jjg
2014-03-03 16:17:32 -05:00
Jan Lahoda
74250736aa 8031383: Error recovery in JavacParser could be improved
Improving error recovery in JavacParser by avoiding artificial nextToken in JavacParser.reportSyntaxError.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg, jfranck
2014-02-28 20:25:24 +01:00
Vicente Romero
c5ab176b3e 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
Reviewed-by: jjg
2014-02-28 18:27:14 +00:00
Per Bothner
25c2444601 8033287: Reduce the size of the endPosTable
Co-authored-by: Charlie Turner <chturne@gmail.com>
Reviewed-by: jjg
2014-02-27 13:57:57 -08:00
Eric McCorkle
816bfaa7bc 8035766: Execute TypeAnnotate visitor at queue flush time
Moved execution of TypeAnnotate visitor into Worker for type annotations

Reviewed-by: jjg
2014-02-27 00:29:22 -05:00
Paul Govereau
dd0e29f8b7 6533516: Warning needed for file with future time stamps
Reviewed-by: jjg, vromero
2014-02-26 18:05:02 -08:00
Paul Govereau
f6250d7784 8034048: javac crash with method references plus lambda plus var args
Reviewed-by: jjg, vromero
2014-02-26 15:38:55 -08:00
Eric McCorkle
38cc470411 8035758: Move annotation codepaths from MemberEnter.java to Annotate.java
Cosmetic code cleanup patch, moving code to the file where it ought to reside.

Reviewed-by: vromero
2014-02-25 14:06:48 -05:00
Vicente Romero
c7af5cd60b 8034143: javac, subclasses of Infer.IncorporationStep should implement the accepts() method
Reviewed-by: jjg
2014-02-22 17:42:10 +00:00
Yuri Nesterenko
98b44a020b 6457406: javadoc doesn't handle <a href='http://...'> properly in producing index pages
Reviewed-by: jjg, bpatel, ksrini
2014-02-21 15:14:09 +04:00
Jan Lahoda
facc03d9f4 6411385: Trees.getPath does not work for constructors
Enhancing TestTrees test to ensure proper function of Trees.getPath/getTree, fixing cases where getTree did not work properly.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-02-21 10:35:19 +01:00
Jonathan Gibbons
31ca5c712a 8035364: An extra space in the comments of constant pool entries
Reviewed-by: ksrini
2014-02-19 15:05:19 -08:00
Kumar Srinivasan
f643b8cab0 8031545: [javac] refactor and cleanup JNIWriter.java
Reviewed-by: jjg
2014-02-15 16:37:19 -08:00
Kumar Srinivasan
c7480b6513 8029145: javadoc fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-02-14 17:28:07 -08:00
Andreas Lundblad
8daec20c86 8030714: The steps attribute, flow and desugar are unnecessary for implicit classes when compiling with -implicit:none
When compiling with -implicit:none, attribute, flow and desugar is skipped for better performance.

Reviewed-by: jfranck, jlahoda
2014-02-13 14:58:10 +01:00
Jan Lahoda
e20546fe2a 8033961: Formatting of -Xlint: command line help
Improving formatting of command line help for -Xlint, including a short description of each lint.

Reviewed-by: jjg
2014-02-13 13:38:48 +01:00
Dan Smith
55801d06ff 4910483: Javadoc renders the string ".*\\.pdf" as ".\*\.pdf"
Adjust timing of printing "\\" in the comment scanner

Reviewed-by: jjg
2014-02-12 12:31:30 -07:00
Jonathan Gibbons
4e86ae9988 8033930: Unnecessary new line after the StackMapTable
8033913: Incorrect indentation of StackMapTable entries

Reviewed-by: ksrini
2014-02-10 11:52:52 -08:00
Jan Lahoda
c0d767f6f1 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
When the overrides deprecated method warning is being reported, need to do that in the lint context of the method.

Reviewed-by: vromero
2014-02-07 21:43:33 +01:00
Jonathan Gibbons
29f985089a 8033581: Incorrect comment aligment
8033798: javap output has unnecessary trailing whitespace
8033726: StackMapTable does not unindent properly

Reviewed-by: ksrini
2014-02-06 18:54:13 -08:00
Christine Lu
67d15f03e0 8032526: fix the accessibility, html, syntax errors and warnings reported by doclint report in langtools
Reviewed-by: jjg
2014-02-06 16:39:19 -08:00
Jonathan Gibbons
8b3c6d6d4f 8033114: The values of non-static final fields are printed for the -constants option
Reviewed-by: ksrini
2014-02-06 15:43:23 -08:00
Jonathan Gibbons
47528ece5e 8033711: An exception is thrown if using the \"-classpath\" option with no arguments
Reviewed-by: ksrini
2014-02-06 11:01:50 -08:00
Jonathan Gibbons
5b738090bd 8033686: Internal error for zero indent
Reviewed-by: ksrini
2014-02-06 10:58:51 -08:00
Vicente Romero
edee080e4a 8030855: Default methods should be visible under source previous to 8
Reviewed-by: jjg, dlsmith
2014-02-06 18:49:01 +00:00
Eric McCorkle
3bd9bdd993 8033004: Make base TypeAnnotationPosition data immutable, create better methods for creating base TypeAnnotationPositions
First of a series of major fixes to type annotations; cleans up interface with TypeAnnotationPosition

Reviewed-by: jjg
2014-02-03 17:19:15 -05:00
Jan Lahoda
4724c454cd 8030091: Request to update error messages from javac for negative varargs test cases
Introducing a new error message for vararg parameter not being the last parameter, improving error message for unexpected character after a parameter.

Reviewed-by: jjg, sogoel
2014-02-02 12:12:01 +01:00
Jonathan Gibbons
30e9783850 8033180: An inappropriate newline symbol in the help section
Reviewed-by: ksrini
2014-01-30 17:46:25 -08:00
Eric McCorkle
ca53cc64e5 8033218: Silent failure in TypeAnnotations.resolveFrame
Change silent no-op to assertion failure when resolveFrame is called before attribution.

Reviewed-by: jfranck
2014-01-30 07:35:49 -05:00
Jonathan Gibbons
214de0eb69 8032869: remove support for legacy options in javap
Reviewed-by: ksrini
2014-01-29 14:32:27 -08:00
Eric McCorkle
77feb9302c 8032932: Add assertion to fix silent failure in Gen.getAndRemoveNonFieldTAs
Turn silent failure if type annotation position type is UNKNOWN into assertion failure.

Reviewed-by: jjg
2014-01-28 17:52:30 -05:00
Eric McCorkle
07998a6335 8032980: Silent failure in Attr.annotateType
Turn silent discard of annotations in Attr.annotateType if conversion to TypeCompound fails into an assertion failure.

Reviewed-by: jjg
2014-01-28 17:51:28 -05:00
Jonathan Gibbons
552e338377 8032819: Extra empty line between field declarations for the "-v -c" and "-v -l" combination of options
Reviewed-by: ksrini
2014-01-28 14:31:29 -08:00
Jonathan Gibbons
69a6133c78 8032814: LineNumberTable/LocalVariableTable tables duplication for the "-v -l" combination of options
Reviewed-by: ksrini
2014-01-27 17:48:47 -08:00
Jonathan Gibbons
478d2876a5 8031212: doclint incorrectly rejects some @see tags in javadoc comments
Reviewed-by: vromero
2014-01-27 16:07:32 -08:00
Eric McCorkle
1bb2245091 8032587: Change silent failure in Attr.java to assertion
Change silent failure in Attr.fromAttributes into a non-null assertion

Reviewed-by: jfranck
2014-01-24 08:47:32 -05:00
Andreas Lundblad
99aae5c1fd 8028267: sun.tools.javac.util.Bits contains a main-method with test code
Removed main method from Bits and added proper unit testing.

Reviewed-by: jfranck
2014-01-24 09:39:51 +01:00
Joel Borggrén-Franck
b1bcbaeb4b 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
Reviewed-by: abuckley, jlahoda, vromero
2014-01-23 14:09:29 +01:00
Kumar Srinivasan
70eb26fc0a 8031023: [javac] LambdaToMethod is missing forceSerializedRepresentation logic and switch
Reviewed-by: jjg, rfield
2014-01-23 06:34:53 -08:00
Vicente Romero
712b922a0f 8030816: javac crashes when mixing lambdas and inner classes
Reviewed-by: jjg, jlahoda
2014-01-22 21:41:50 +00:00
Abhijit Saha
d9ec81d45f Merge 2014-01-15 10:18:06 -08:00
Jan Lahoda
9a0f6ed18e 8028576: Incorrect RuntimeVisibleTypeAnnotations for exception parameters when not generating debuging info
The exception parameters with type annotations need to be added into the varBuffer even if not generating debug info

Reviewed-by: jjg, emc
2014-01-15 13:49:57 +01:00
Joel Borggrén-Franck
b3e2823f53 8029690: Move symbol creation from ClassReader to Symtab
Reviewed-by: jjg
2014-01-15 10:57:25 +01:00
Abhijit Saha
c575ece03d Merge 2014-01-14 08:08:32 -08:00
Jan Lahoda
8a2542c71f 8030049: RoundEnvironment.getElementsAnnotatedWith receives wrong elements
Match the required and actual annotations using Element equivalence rather than TypeMirror equivalence, to avoid trouble with erroneous types.

Reviewed-by: darcy
2014-01-10 19:02:54 +01:00
Andreas Lundblad
a76d1ab5a2 8028389: NullPointerException compiling annotation values that have bodies
Made sure anonymous class declarations inside class- and package-level annotations are properly entered.

Reviewed-by: jfranck
2014-01-10 12:47:15 +01:00
Jan Lahoda
e32b40185e 8029376: Full attribution of unresolvable annotations
8029161: javac crashing when processing broken annotations

Attributing values of annotation attributes regardless how broken the annotation is.

Reviewed-by: jjg, jfranck
2014-01-10 11:31:09 +01:00