Commit Graph

2666 Commits

Author SHA1 Message Date
Lana Steuck
dfedac648b Merge 2014-06-18 10:54:24 -07:00
Lana Steuck
b2a5eb6f28 Merge 2014-06-18 10:09:04 -07:00
Maurizio Cimadamore
f8e80ec392 8043253: Slow javac compile times in JDK 8
Enable on-demand diagnostic source position completion

Reviewed-by: jjg, vromero
2014-06-18 13:51:50 +01:00
Jan Lahoda
e6b9e34ebe 8046916: Type parameter annotations don't work with multiple type parameters
When reading type variable's annotations out of the owner's type annotations, use the type variable's index in owner to exclude annotations belonging to other type variables.

Reviewed-by: jfranck, emc
2014-06-18 10:44:16 +02:00
Vicente Romero
e4773094de 8036953: Fix timing of varargs access check, per JDK-8016205
Reviewed-by: mcimadamore, dlsmith
2014-06-17 17:33:01 +01:00
Paul Govereau
f2e2245e7b 8038975: Access control in enhanced for
Reviewed-by: vromero, jlahoda
2014-06-17 11:11:59 -04:00
Andreas Lundblad
8baafcf7ef 8048594: The sjavac client/server protocol should be hidden behind an interface
Reviewed-by: jfranck
2014-06-17 14:01:27 +02:00
Vicente Romero
ce0935812b 8047719: Incorrect LVT in switch statement
Reviewed-by: jjg, jlahoda
2014-06-27 20:32:12 +01:00
Sonali Goel
2f5e083cee 8048293: update tools/javadoc/6227454 to have missing <head> tag
Reviewed-by: jjg, bpatel
2014-06-26 16:39:14 -07:00
Sonali Goel
3e316a3372 8047316: update javadoc tests to fix tidy warning for incorrect html comment
Reviewed-by: jjg, ksrini
2014-06-26 16:07:07 -07:00
Sonali Goel
bbc0df83f4 8048168: update 2 javadoc tests to add summary attribute for table tag
Reviewed-by: jjg, ksrini
2014-06-26 15:47:52 -07:00
Sonali Goel
8828870971 8047744: update 2 javadoc tests for nested emphasis <code>
Reviewed-by: jjg, ksrini
2014-06-26 15:41:05 -07:00
Sonali Goel
41005acef2 8047743: update com/sun/javadoc/testHref for unrecognized <action>
Reviewed-by: jjg, ksrini
2014-06-26 15:30:21 -07:00
Sonali Goel
7470fabe6f 8047303: update com/sun/javadoc/DocRootSlash/DocRootSlash for unexpected </a>
Reviewed-by: jjg, ksrini
2014-06-26 15:21:44 -07:00
Jonathan Gibbons
47c543e53b 8007307: DPrinter: support the DocTree API
Reviewed-by: mcimadamore
2014-06-26 11:45:51 -07:00
Jonathan Gibbons
bd97e7d5ec 8047183: JDK build fails with sjavac enabled
Reviewed-by: mcimadamore
2014-06-26 11:31:59 -07:00
Paul Govereau
5b1596bc25 8042345: getDocComment fails for doc comments on PackageElement found in package-info.java
Reviewed-by: jjg
2014-06-26 13:48:58 -04:00
Jonathan Gibbons
101aaaa468 8048162: Restrict catch type from Throwable to ReflectiveOperationException
Reviewed-by: darcy
2014-06-25 19:15:53 -07:00
Jonathan Gibbons
a86ace6297 8046614: Fill in missing doc comments
Reviewed-by: darcy
2014-06-25 19:04:52 -07:00
Jonathan Gibbons
25618fc470 8046613: Fill in missing doc comments
Reviewed-by: darcy
2014-06-25 17:58:37 -07:00
Robert Field
30f70a0e1d 8048121: javac complex method references: revamp and simplify
8038776: VerifyError when running successfully compiled java class

Add tests missing from the push of 8037404

Reviewed-by: dlsmith, vromero
2014-06-25 11:22:27 -07:00
Kumar Srinivasan
7aa3c59051 8047157: [javadoc] fixup tests for determinism and add classes uses
Reviewed-by: jjg
2014-06-24 15:15:22 -07:00
Joe Darcy
b963c0bc59 7196160: Project Coin: allow @SafeVarargs on private methods
Reviewed-by: jjg
2014-06-24 10:51:00 -07:00
Maurizio Cimadamore
29297396ab 8046451: Add basic IntelliJ support for langtools
Add new ant target 'idea' to create IntelliJ langtools project

Reviewed-by: jjg
2014-06-24 16:04:46 +01:00
Robert Field
802429b65f 8037404: javac NPE or VerifyError for code with constructor reference of inner class
8047341: lambda reference to inner class in base class causes LambdaConversionException
8044748: JVM cannot access constructor though ::new reference although can call it directly
8044737: Lambda: NPE while obtaining method reference through lambda expression

Revamp and simplify handling of complex method references

Reviewed-by: dlsmith, vromero
2014-06-24 00:43:46 -07:00
Jonathan Gibbons
2613fffb87 8046369: sjavac should not use javac internal API for starting javac
Reviewed-by: jfranck, alundblad, ohrstrom
2014-06-16 11:30:31 -07:00
David Katleman
26e17df2bf Added tag jdk9-b18 for changeset d38c730b86c1 2014-06-13 11:21:39 -07:00
Lana Steuck
e380f5fa69 Merge 2014-06-12 15:37:29 -07:00
David Katleman
d382f3a577 Added tag jdk9-b17 for changeset abd9a49d0b9c 2014-06-12 10:32:42 -07:00
Eric McCorkle
29e8b83b48 8043484: DPrinter does not compile
Make DPrinter compile

Reviewed-by: jjg
2014-06-12 11:32:23 -04:00
Andreas Lundblad
77fa3101ec 8042830: A recently added Xprefer test fails on Windows
Test now accepts both / and \ as file separator.

Reviewed-by: mcimadamore
2014-06-12 14:29:09 +02:00
Paul Govereau
577b60e711 8027886: javac allows illegal receiver parameters
8029042: Receiver parameter not supported on local class constructor

Reviewed-by: jfranck, jlahoda
2014-06-11 12:49:10 -04:00
Dan Smith
3ea78c679c 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
Capture intersection supertypes before comparing their members

Reviewed-by: vromero
2014-06-10 15:25:01 -06:00
Dan Smith
6e1ae5955e 8037385: constant pool errors with -target 1.7 and static default methods
Add error check for static interface methods invoked from -source 7

Reviewed-by: vromero, mcimadamore
2014-06-10 12:41:39 -06:00
Eric McCorkle
07f1246919 8046296: java/util/concurrent/BlockingQueue/PollMemoryLeak.java fails in nightly on all platform due to compiler issue
Alter logic to choose type of type annotation position for a variable declaration

Reviewed-by: jjg
2014-06-09 15:46:44 -04:00
Maurizio Cimadamore
dab523a752 8043725: javac fails with StackOverflowException
Loose type comparison test should be protected against infinite recursion with fbounds

Reviewed-by: vromero
2014-06-09 12:54:02 +01:00
Jan Lahoda
d71f75ae86 8033414: javac Plugin to receive notification (before and) after the compilation
Introducing TaskEvent.Kind.COMPILATION, sending this event before and after compilation.

Co-authored-by: Joel Borggren-Franck <joel.franck@oracle.com>
Reviewed-by: jjg, jfranck
2014-06-09 10:17:16 +02:00
Jonathan Gibbons
15853aca13 7026941: 199: path options ignored when reusing filemanager across tasks
Reviewed-by: jlahoda, jfranck
2014-06-08 15:02:34 -07:00
Andrei Eremeev
8aa391d4c9 8042451: Write tests for all possible kinds of type annotation
Add new tests for type annotations to improve case coverage

Reviewed-by: jjg, emc, abuckley
2014-06-06 16:08:46 -04:00
Eric McCorkle
8ff3cbd414 8027262: Determine location for type annotations earlier in compiler pipeline
8027261: Single codepath for attaching annotations to symbols
8027258: Permit a single source annotation to generate multiple bytecode annotations
8027182: Incorrect annotation attributes for type annotations on constructor type parameters
8044010: TypeAnnotation attribute is not generated for repeatable annotation in type argument
8044009: TypeAnnotation attribute is not generated for repeatable annotation in nested types
8043974: TypeAnnotation attribute is not generated for repeatable annotation in lambda
8043669: Few of the ANNOT tests in JCK9 test suite fail with an AssertionError for exception_index
8042060: Type parameter annotations don't work with multiple type parameters
8037348: RuntimeInvisibleAnnotations should not be generated for type annotation on anonymous innerclass creation

Initial rearchitecting of type annotations frontend pipeline

Reviewed-by: jjg, jfranck, mcimadamore, jlahoda, wmdietl
2014-06-06 16:00:59 -04:00
Lana Steuck
f533c23f2a Merge 2014-06-05 19:38:17 -07:00
Jonathan Gibbons
a9bd96c90c 8046067: test/tools/javac/api/6410643/T6410643.java is broken
Reviewed-by: darcy, ksrini
2014-06-05 13:22:37 -07:00
Sonali Goel
887f81a738 8044072: Group 2: create .out files for OverrideChecks tests in tools/javac dir
Reviewed-by: jjg
2014-06-05 10:57:10 -07:00
Sonali Goel
d15c9840ed 8044064: Group 1: create .out files for cast and capture negative tests in tools/javac dir
Reviewed-by: jjg
2014-06-05 10:44:38 -07:00
Maurizio Cimadamore
cd68d10b6f 8043893: Inference doesn't report error on incompatible upper bounds
Failure on type-equality check during incorporation doesn't trigger inference error

Reviewed-by: vromero
2014-06-05 12:21:38 +01:00
David Katleman
0a28ae7c64 Added tag jdk9-b16 for changeset f75464f610f6 2014-06-04 20:20:42 -07:00
Vicente Romero
09250abb84 8041713: Type inference of non-existent method references crashes the compiler
Reviewed-by: mcimadamore
2014-06-04 20:01:13 +01:00
Vicente Romero
45c3929ecb 8044487: Fix for 8042785 causes regression tests to fail with java.lang.VerifyError
Reviewed-by: jjg, ksrini
2014-06-02 22:36:40 +01:00
Vicente Romero
8447e4cf46 8042785: javac, bridge methods are not getting the flags from the original method
Reviewed-by: jjg, jlahoda
2014-05-30 18:21:05 +01:00
Lana Steuck
a7ab489c5a Merge 2014-05-30 09:25:52 -07:00
Jan Lahoda
2f910049e8 8031967: For some sources compiler compiles for ever
Avoid creating DeferredTypes for method calls with method calls as receivers if the site can be determined reliably

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, vromero
2014-05-30 12:54:16 +02:00
David Katleman
1834c52c4d Added tag jdk9-b15 for changeset dbec02c24c7a 2014-05-29 22:32:18 -07:00
Vicente Romero
92e2e96714 8037937: javac: AssertionError during LVT generation, wrong variable ranges
Reviewed-by: mcimadamore
2014-05-29 15:28:01 +01:00
Stephane Epardaud
e0f4450825 8037934: Javac generates invalid signatures for local types
Reviewed-by: vromero, rfield
2014-05-28 21:47:30 +01:00
Dan Smith
2b4c40d39b 8044050: Move misplaced inference tests to test/tools/javac/generics/inference
Reviewed-by: vromero
2014-05-27 16:39:05 -06:00
Dan Smith
849ed753e2 8042338: Refactor Types.upperBound to treat wildcards and variables separately
Reviewed-by: vromero
2014-05-27 16:32:56 -06:00
Paul Govereau
773e460c33 7177211: SharedNameTable.create and .dispose are not used
Reviewed-by: jjg
2014-05-27 14:23:55 -04:00
Paul Govereau
0b1c40b161 8042741: Java 8 compiler throws NullPointerException depending location in source file
Reviewed-by: vromero, jlahoda
2014-05-27 22:26:53 +01:00
Paul Govereau
649331e00f 8041704: wrong error message when mixing lambda expression and inner class
Reviewed-by: vromero
2014-05-27 18:57:44 +01:00
Sonali Goel
378c3fe62f 8043336: Missing bug id in test/tools/javac/lambda/TargetType23.java
Reviewed-by: jjg, vromero, dlsmith
2014-05-22 15:42:10 -07:00
Lana Steuck
293d514c13 Merge 2014-05-22 14:39:05 -07:00
David Katleman
5d455cb482 Added tag jdk9-b14 for changeset 076ae2d12410 2014-05-22 12:54:10 -07:00
Kumar Srinivasan
b18841ffa0 8042829: [javadoc] index-file output is not sorted correctly
8043062: JDK 9 platform and compiler upgrade failed on Solaris-sparcv9 with Javadoc.gmk:360: recipe for target docs/api/index.html

Reviewed-by: erikj, jjg
2014-05-22 12:16:53 -07:00
Neil Toda
ac4c2fe57a 8042406: javac.jvm.ClassReader.readClassFile() is using Target to verify valid major versions
Reviewed-by: jjg
2014-05-20 15:50:17 -07:00
Paul Govereau
c212c43f70 8015927: Class reference duplicates in constant pool
Reviewed-by: jjg
2014-05-16 17:08:42 -04:00
Jonathan Gibbons
31e6340f54 8041422: Split javac ClassReader into ClassReader+ClassFinder
Reviewed-by: jfranck
2014-05-18 19:59:10 -07:00
Jan Lahoda
911a9fcf97 8043186: javac test langtools/tools/javac/util/StringUtilsTest.java fails
The result of String.toLowerCase.indexOf does not always point at the start of the given string in the non-lowercased text.

Reviewed-by: jjg, bpatel
2014-05-16 10:52:07 +02:00
Lana Steuck
f1eb2bc57f Merge 2014-05-15 10:40:27 -07:00
David Katleman
0fa48738ed Added tag jdk9-b13 for changeset 069586f14799 2014-05-15 10:26:01 -07:00
Dan Smith
5efa462340 8042882: Support verbosity options in langtools testing
8032441: langtools/test/Makefile breaks when JT_JAVA set to a JDK 9 build

Reviewed-by: mduigou
2014-05-13 15:34:13 -06:00
Dan Smith
9798cbad4c 8034223: Most-specific should not have any special treatment for boxed vs. unboxed types
Rewrite most-specific logic to conform to JLS 8 15.12.2.5

Reviewed-by: vromero
2014-05-13 15:29:09 -06:00
Andrey Nazarov
23759a15dd 8042771: Missing bug id in test/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java
Reviewed-by: jjg
2014-05-12 17:09:26 +01:00
Eric McCorkle
10fb266571 8035763: Error parsing binary type annotations data in javac
Fix accidental reversal of read order from a previous change

Reviewed-by: jjg
2014-05-09 22:27:07 -04:00
Jonathan Gibbons
3b2a17f08f 8042886: Test langtools/test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java fails on Windows
Reviewed-by: darcy
2014-05-09 18:50:12 -07:00
Vicente Romero
9cf78d324c 8028503: javac, for method references a primitive type can be added as a bound
Reviewed-by: jjg, dlsmith
2014-05-10 01:24:35 +01:00
Vicente Romero
c374047d36 8037379: fix for JDK-8029569 doesn't cover all possible cases
Reviewed-by: jjg
2014-05-10 00:46:47 +01:00
Jonathan Gibbons
caa2209663 8038730: Clean up the way JavadocTester is invoked, and checks for errors
Reviewed-by: ksrini, sogoel, bpatel
2014-05-09 15:37:12 -07:00
Jan Lahoda
756eae6492 8042867: Missing license header for langtools/make/netbeans/langtools/nbproject/project.properties
Reviewed-by: ksrini
2014-05-09 23:31:05 +02:00
Dan Smith
f799e8d6fc 8042656: Inference produces spurious error for intersection type bounds check
Fix subtyping for intersections involving capture variables

Reviewed-by: vromero
2014-05-09 14:56:59 -06:00
Eric McCorkle
1ad5b0eee1 8040327: Eliminate AnnotatedType
Replace AnnotatedType with type annotations being stored in the Type class as metadata

Reviewed-by: jjg, jfranck, wmdietl, jlahoda
2014-05-09 09:28:47 -04:00
Jonathan Gibbons
47876fcddb 8042839: XPreferTest fails on Windows
Reviewed-by: vromero
2014-05-09 08:52:57 -07:00
Lana Steuck
c3dc5c472c Merge 2014-05-08 15:28:38 -07:00
Kumar Srinivasan
1f1c8d7506 8042601: Javadoc sort fails
Reviewed-by: jjg
2014-05-08 08:23:44 -07:00
Jan Lahoda
5b6afc8503 8041663: Sensitive dependence on location of nested interface
Adding a method among ambiguous candidates only if it is more specific than some of the existing candidates.

Reviewed-by: dlsmith, vromero
2014-05-09 12:55:58 +02:00
Jan Lahoda
23ba7e22d2 8040822: Duplicated notifications can be sent to TaskListener
The analyze finished event must only be sent on the first call to JavaCompiler.flow for a given class.

Reviewed-by: jjg
2014-05-09 09:36:35 +02:00
David Katleman
62e455cc8e Added tag jdk9-b12 for changeset 61f3b005022e 2014-05-08 01:05:31 -07:00
Andreas Lundblad
b2d433dcfc 8028196: Javac allows timestamps inside rt.jar to affect compilation when using -sourcepath
Added -XXuserPathsFirst to allow user classes to take precedence over boot classes

Reviewed-by: jjg
2014-05-07 17:29:42 +02:00
Kumar Srinivasan
15ebe0dcbf 8042654: [javadoc] revert the default methods list.sort to Collections.sort
Reviewed-by: jfranck, jjg
2014-05-07 15:54:16 -07:00
Fredrik Öhrström
ad489d2ce3 8042441: sjavac does not track dependencies
Add support for tracking fully qualified references.

Reviewed-by: jjg
2014-05-08 00:22:31 +02:00
Fredrik Öhrström
cb6df44f8e 8042699: sjavac does not track dependencies
Using / in some places and . in other places break package comparisons. The fix standardizes on dots.

Reviewed-by: jjg
2014-05-07 23:55:41 +02:00
Andrey Nazarov
2c6668c63d 8040129: Implement classfile tests for SourceFile attribute
Reviewed-by: shurailine, jjg
2014-05-07 14:22:14 -07:00
Dan Smith
282ee77f73 8033718: Inference ignores capture variable as upper bound
Split Types.lowerBound into two methods; fix bugs in inference handling of capture variables.

Reviewed-by: vromero
2014-05-06 15:46:09 -06:00
Jonathan Gibbons
7e2e9759d5 8042358: some tests have placeholder bugid 1234567
Reviewed-by: mduigou
2014-05-02 16:41:10 -07:00
Paul Govereau
6ec0c32eff 8033437: javac, inconsistent generic types behaviour when compiling together vs. separate
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: jjg
2014-05-02 22:35:23 +01:00
Lana Steuck
5e30be8573 Merge 2014-05-01 14:21:15 -07:00
David Katleman
f45fe402ee Added tag jdk9-b11 for changeset ae887a48401a 2014-05-01 12:52:13 -07:00
Vicente Romero
71a85db2be 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
Reviewed-by: dlsmith, jjg
2014-05-01 20:36:11 +01:00
Robert Field
89be14bfe5 8029852: Bad code generated (VerifyError) when lambda instantiates enclosing local class and has captured variables
8029725: Lambda reference to containing local class causes javac infinite recursion

Reviewed-by: vromero, jlahoda, dlsmith
2014-04-30 23:02:14 -07:00
Robert Field
e8adfd1234 8036942: javac generates incorrect exception table for multi-catch statements inside a lambda
Union type info lost and also union type is not processed by TreeMaker.Type -- address by using existing tree, thus by-passing such issues.

Reviewed-by: vromero, jlahoda
2014-04-30 18:19:23 -07:00
Andrey Nazarov
230b553e37 8040097: Implement classfile tests for LocalVariableTable and LocalVariableTypeTable attribute
Reviewed-by: jjg, shurailine, emc
2014-04-30 13:48:37 -07:00
Lana Steuck
3ddefc8337 Merge 2014-04-24 16:04:44 -07:00
David Katleman
6494ff9ca2 Added tag jdk9-b10 for changeset 16ec7c58cdea 2014-04-24 12:21:18 -07:00
Jan Lahoda
3fb6775539 8041695: Update the NetBeans build script and metadata
Various improvements to the NetBeans project for langtools, adding formatting/import setting for langtools.

Reviewed-by: ksrini
2014-04-24 13:32:21 +02:00
Jan Lahoda
6b335c8d1a 8039250: Test tools/javac/classfiles/InnerClasses/SyntheticClasses.java fails
The test should only analyze classfiles.

Reviewed-by: vromero
2014-04-23 11:28:09 +02:00
Jonathan Gibbons
3acf463dc4 8040903: Clean up use of BUG_ID in javadoc tests
Reviewed-by: ksrini
2014-04-22 17:57:40 -07:00
Jonathan Gibbons
187dbd343c 8041253: Avoid redundant synonyms of NO_TEST
Reviewed-by: ksrini
2014-04-22 17:41:11 -07:00
Paul Govereau
0a5665b53a 8041521: JDK-8034245 breaks a bootcycle build
Reviewed-by: jjg
2014-04-22 15:59:33 -07:00
Paul Govereau
9783b65028 8034245: Refactor TopLevel tree node
Added JCPackageDecl to JCTree to store package-level information.

Reviewed-by: jjg, jlahoda
2014-04-22 17:07:54 -04:00
Paul Govereau
b349726850 8038023: Compiler crash ClassCastException
Add additional checks on results of ClassReader.readPool

Reviewed-by: vromero
2014-04-22 19:52:15 +01:00
Andreas Lundblad
06f651942c 8035063: Option handling in sjavac needs to be rewritten
Option handling code rewritten. Exclusion / inclusion patterns changed from package to directories.

Reviewed-by: jjg, jfranck
2014-04-22 16:51:10 +02:00
Paul Govereau
f77173467d 8030046: javac incorrectly handles absolute paths in manifest classpath
Reviewed-by: jjg, vromero
2014-04-21 17:57:47 -04:00
Vicente Romero
a50db59b59 8029718: Should always use lambda body structure to disambiguate overload resolution
Reviewed-by: dlsmith, jjg, jlahoda
2014-04-21 22:51:49 +01:00
Jonathan Gibbons
04e1109b69 8041150: Avoid silly use of static methods in JavadocTester
Reviewed-by: ksrini
2014-04-18 17:25:43 -07:00
Jonathan Gibbons
a2d155dfa9 8040908: javadoc test TestDocEncoding should use -notimestamp
Reviewed-by: ksrini
2014-04-18 17:23:36 -07:00
Vicente Romero
a310cda727 8029002: javac should take multiple upper bounds into account in incorporation
Reviewed-by: dlsmith, jjg
2014-04-18 17:50:30 +01:00
Kumar Srinivasan
4c16861cc4 8038583: [javadoc] Refactor uses of arrays to Collections
Reviewed-by: jjg
2014-04-18 08:44:53 -07:00
Kumar Srinivasan
296a39b117 8039410: [javadoc] fix class-use items to be deterministic and index ordering
Reviewed-by: jjg
2014-04-18 08:35:59 -07:00
Vicente Romero
0996901f29 8029102: Enhance compiler warnings for Lambda
Reviewed-by: briangoetz, jjg, jlahoda, ahgross
2014-04-28 14:48:51 +01:00
Paul Govereau
218ce31908 8039026: Definitely unassigned field can be accessed
Reviewed-by: vromero, jlahoda
2014-04-25 22:00:58 +01:00
Jonathan Gibbons
6c24c7e153 8040904: Ensure javadoc tests do not overwrite results within tests
Reviewed-by: ksrini
2014-04-25 13:08:41 -07:00
Jan Lahoda
e505238d2a 8038788: javac behaves incorrectly for annotations after method type parameters in some cases
Reviewed-by: jjg, emc
2014-04-18 11:53:34 +02:00
Lana Steuck
f33dec2ebb Merge 2014-04-17 15:23:23 -07:00
David Katleman
688864a6ea Added tag jdk9-b09 for changeset 16bad6bc066b 2014-04-17 10:14:07 -07:00
Eric McCorkle
bd42246eaa 8040319: Clean up type annotation exception index generating code in Code.java
Remove bad code from exception index generation for type annotations and make type_index final

Reviewed-by: jjg, vromero
2014-04-17 12:17:02 -04:00
Kumar Srinivasan
9b4ae823ef 8038976: javadoc requires a trailing / for links where java 7's javadoc didn't
Reviewed-by: jjg
2014-04-16 19:21:59 -07:00
Kumar Srinivasan
7a7a57bb88 8037484: [javadoc] fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-04-16 18:15:48 -07:00
Kumar Srinivasan
7a4a5803fc 8039251: Test tools/javadoc/6964914/TestStdDoclet.java fails
Reviewed-by: jjg
2014-04-16 18:36:43 -07:00
Neil Toda
81730320bd 8031649: Clean up javadoc tests
Reviewed-by: jjg
2014-04-16 16:17:09 -07:00
Robert Field
360461f136 8038420: Lambda returning post-increment generates wrong code
Reviewed-by: vromero, jlahoda
2014-04-15 15:55:24 -07:00
Robert Field
300fbf0889 8037935: Javac -- final local String var referenced in binary/unary op in lambda produces code that does not verify
Remove over-zealous Attr optimization breaking lambdas

Reviewed-by: jjg, vromero
2014-04-15 15:52:52 -07:00
David Katleman
919fd1dbac Added tag jdk9-b08 for changeset 06ab27895804 2014-04-15 12:14:29 -07:00
Eric McCorkle
b343919526 8038263: Refactor annotation handling after actualEnterAnnotations
Move all repeating annotations code into Annotate, rework annotations pipeline into a more completer-like design, eliminate a cast from enterAnnotations/enterTypeAnnotations

Reviewed-by: jjg, jfranck
2014-04-03 20:28:23 -04:00
Lana Steuck
16c2ee6450 Merge 2014-04-09 17:18:22 -07:00
Paul Govereau
c654c5a23e 8015499: javac, Gen is generating extra checkcast instructions in some corner cases
Reviewed-by: vromero, jjg
2014-04-09 17:41:27 +01:00
Lana Steuck
4b1de2f99c Merge 2014-04-09 09:20:35 -07:00
Jan Lahoda
5905e8f494 8039466: Tests failing in langtools repository
Fixing tests broken by JDK-8038455.

Reviewed-by: jjg
2014-04-08 23:33:50 +02:00
Jan Lahoda
e5c8101894 8038455: Use single Context for all rounds of annotation processing
One set of javac services, as well as created ClassSymbols, is reused for all rounds of processing now.

Reviewed-by: jjg, jfranck, darcy, vromero
2014-04-08 14:06:11 +02:00
Paul Govereau
8e6660eb56 8023945: javac wrongly allows a subclass of an anonymous class
Reviewed-by: jjg
2014-04-04 19:13:53 -04:00
Kumar Srinivasan
73d4a30ede 8039231: [javadoc] test failure caused by javax.crypto fix
Reviewed-by: jjg
2014-04-04 18:36:16 -07:00
Kumar Srinivasan
def40f4158 8037881: javax.crypto is not listed in the compact* profiles javadoc
Reviewed-by: jjg
2014-04-03 12:04:58 -07:00
David Katleman
cf7bfef898 Added tag jdk9-b07 for changeset a70a71ac79f3 2014-04-02 22:00:13 -07:00
Bhavesh Patel
d642f92759 8032066: Serialized form has broken links to non private inner classes of package private
Reviewed-by: jjg
2014-04-01 23:58:04 -07:00
Paul Govereau
e231918e58 8034933: Update documentation for Types.directSupertypes to clarify behavior
Reviewed-by: darcy
2014-04-01 23:52:10 -07:00
Ivan Gerasimov
befb7157c9 8034044: Class.getModifiers() returns "static" for anonymous classes
Javac sets ACC_STATIC bit for anonymous classes which contradicts the JLS

Reviewed-by: jfranck
2014-04-02 10:05:16 +04:00
Lana Steuck
b683f35613 Merge 2014-04-01 17:25:39 -07:00
Alexander Zuev
d9d9742c75 8031425: Two langtools/javac tests fail by timeout on Windows
Reviewed-by: jjg, vromero
2014-04-01 10:00:43 -07:00
Jan Lahoda
e339370175 8035890: jdk8 javac -source 7 compiles test case it should not
Ensuring source level checks are performed in two additional cases related to type annotations, adding specialized error message for annotations after method type parameters.

Reviewed-by: jfranck, jjg
2014-03-31 21:27:25 +02:00
Bhavesh Patel
e08ccd0e48 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present
Reviewed-by: ksrini
2014-03-29 11:06:33 -07:00
Eric McCorkle
fb9c998b1d 8035768: Move TypeAnnotationPosition from Attribute.Compound to Attribute.TypeCompound
Move position field into Compound, making Compound into a kind of "proto-annotation", representing the situation before we know what an Annotation's kink is

Reviewed-by: jjg
2014-03-27 18:41:28 -04:00
David Katleman
4ba8c0364b Added tag jdk9-b06 for changeset 3d574309a737 2014-03-27 11:38:37 -07:00
Jonathan Gibbons
77ad0945a6 8035104: reorder class file attributes in javap listing
Reviewed-by: ksrini
2014-03-26 17:50:33 -07:00
Alexander Zuev
3eb793cd06 8035956: javac, incomplete error message
Reviewed-by: vromero
2014-03-26 10:47:30 -07:00
Joel Borggrén-Franck
24400e1745 8038080: annotation processors don't visit declaration parameter annotations
Co-authored-by: Liam Miller-Cushon <cushon@google.com>
Reviewed-by: darcy
2014-03-26 12:18:11 +01:00
Bhavesh Patel
da71a6dd96 8031625: javadoc problems referencing inner class constructors
Reviewed-by: jjg
2014-03-25 22:07:55 -07:00
Lana Steuck
3eb52d3931 Merge 2014-03-25 14:50:31 -07:00
Lana Steuck
0eb4fd78fa Merge 2014-03-25 12:32:12 -07:00
David Katleman
d705db594a Added tag jdk9-b05 for changeset a127d7bb1c30 2014-03-20 13:44:52 -07:00
Alexander Zuev
908ea8bebd 7118295: javac does not explicitly close -Xstdout file
Reviewed-by: ksrini, jjg
2014-03-20 15:13:26 +04:00
Paul Govereau
019025c61f 8025505: Constant folding deficiency
Provide constant folding of equality tests involving constant and null.

Reviewed-by: jjg
2014-03-19 17:39:28 -04:00
Paul Govereau
e0bc15202b 6898851: Compiling against this corrupt class file causes a stacktrace from javac
Added check for index out-of-bounds erros in ClassReader

Reviewed-by: jjg
2014-03-19 11:34:27 -04:00
Lana Steuck
9a44609844 Merge 2014-03-18 17:46:44 -07:00
Paul Govereau
03c0b0a11e 8036007: javac crashes when encountering an unresolvable interface
Reviewed-by: vromero, jlahoda
2014-03-18 22:12:46 +00:00
Dan Smith
d9e857f304 8034980: Fix @summary tag of test/tools/javac/parser/T4910483.java
Reviewed-by: vromero
2014-03-17 14:03:59 -06:00
Eric McCorkle
53e3990b7c 8037420: Silent failures in Annotate.actualEnterTypeAnnotations
Remove two silent failures

Reviewed-by: jjg
2014-03-14 15:35:13 -04:00
Vicente Romero
2564e82ad1 8034924: Incorrect inheritance of inaccessible static method
Reviewed-by: jjg, jlahoda
2014-03-13 20:13:43 +00:00
Vicente Romero
73e0ab9b7f 8034127: javac provide debug oriented toString() methods to InferenceContext and UndetVar
Reviewed-by: jjg
2014-03-13 17:36:51 +00:00
Joe Darcy
07cc98bb1a 8037120: Fix doclint warnings in javax.lang.model exception types
Reviewed-by: jjg
2014-03-11 17:52:45 -07:00
David Katleman
060f4862a7 Added tag jdk9-b04 for changeset 612191246a7d 2014-03-11 15:42:05 -07:00
Joe Darcy
e5fb7f77d6 8036842: Remove unneeded/obsolete -source/-target options in javac tests, part 2
Reviewed-by: jjg, sogoel
2014-03-07 13:30:23 -08:00
Jan Lahoda
16962804f3 8034854: outer_class_info_index of synthetic class is not zero
Auxiliary synthetic anonymous classes should not have an outer class specified in the InnerClasses attribute.

Reviewed-by: vromero, jjg, abuckley
2014-03-07 13:35:56 +01:00
Neil Toda
7aed9a60e0 8031670: Remove unneeded -source options in javadoc tests
Reviewed-by: jjg, darcy, vromero
2014-03-06 16:15:02 -08:00
Paul Govereau
af27057b26 8034091: There is no records in LineNumberTable attribute for ternary operator ?: splitted to several lines
Reviewed-by: jjg
2014-03-06 13:50:12 -05:00
Lana Steuck
b2b667ccfe Merge 2014-03-06 10:41:56 -08:00
Neil Toda
735e586b5f 8035878: javadoc tool documentation should be using {@code ..} specifier
Reviewed-by: jjg
2014-03-03 15:24:31 -08:00
Neil Toda
72641e4e7f 8035877: javadoc classes are missing @return and @param tags
Reviewed-by: jjg
2014-03-03 15:10:01 -08:00
Neil Toda
1f9569d235 8035875: remove deprecated html <font> tags from javadoc package-info.java file
Reviewed-by: jjg
2014-03-03 15:03:17 -08:00
Eric McCorkle
6b9060ac8f 8036142: Remove redundant call to annotateTypeLater with null Symbol
AnnotateTypeLater (formerly typeAnnotate) with null as the symbol was a way to force attribution of type annotations, but this is now obsolete and problematic, and a silent noop condition

Reviewed-by: jjg
2014-03-03 16:17:32 -05:00
Jan Lahoda
74250736aa 8031383: Error recovery in JavacParser could be improved
Improving error recovery in JavacParser by avoiding artificial nextToken in JavacParser.reportSyntaxError.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg, jfranck
2014-02-28 20:25:24 +01:00
Vicente Romero
c5ab176b3e 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
Reviewed-by: jjg
2014-02-28 18:27:14 +00:00
Per Bothner
25c2444601 8033287: Reduce the size of the endPosTable
Co-authored-by: Charlie Turner <chturne@gmail.com>
Reviewed-by: jjg
2014-02-27 13:57:57 -08:00
Paul Govereau
e97bf8b146 8035972: missing test file for 8034048
Reviewed-by: jjg, vromero
2014-02-27 11:47:39 -08:00
Eric McCorkle
816bfaa7bc 8035766: Execute TypeAnnotate visitor at queue flush time
Moved execution of TypeAnnotate visitor into Worker for type annotations

Reviewed-by: jjg
2014-02-27 00:29:22 -05:00
Paul Govereau
dd0e29f8b7 6533516: Warning needed for file with future time stamps
Reviewed-by: jjg, vromero
2014-02-26 18:05:02 -08:00
Paul Govereau
f6250d7784 8034048: javac crash with method references plus lambda plus var args
Reviewed-by: jjg, vromero
2014-02-26 15:38:55 -08:00
Eric McCorkle
38cc470411 8035758: Move annotation codepaths from MemberEnter.java to Annotate.java
Cosmetic code cleanup patch, moving code to the file where it ought to reside.

Reviewed-by: vromero
2014-02-25 14:06:48 -05:00
Lana Steuck
5c411f3cc6 Merge 2014-02-24 13:06:07 -08:00
Vicente Romero
c7af5cd60b 8034143: javac, subclasses of Infer.IncorporationStep should implement the accepts() method
Reviewed-by: jjg
2014-02-22 17:42:10 +00:00
David Katleman
7d41c598a4 Added tag jdk9-b03 for changeset 2740ebeb238c 2014-02-21 11:40:51 -08:00
Yuri Nesterenko
98b44a020b 6457406: javadoc doesn't handle <a href='http://...'> properly in producing index pages
Reviewed-by: jjg, bpatel, ksrini
2014-02-21 15:14:09 +04:00
Jan Lahoda
facc03d9f4 6411385: Trees.getPath does not work for constructors
Enhancing TestTrees test to ensure proper function of Trees.getPath/getTree, fixing cases where getTree did not work properly.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-02-21 10:35:19 +01:00
Lana Steuck
a6f4599cf5 Merge 2014-02-20 20:00:43 -08:00
Jonathan Gibbons
31ca5c712a 8035364: An extra space in the comments of constant pool entries
Reviewed-by: ksrini
2014-02-19 15:05:19 -08:00
Lana Steuck
fb842a624a Merge 2014-02-11 11:25:59 -08:00
David Katleman
fa155ae4bd Added tag jdk9-b02 for changeset fc0fe10fbee9 2014-02-06 13:09:40 -08:00
Erik Joelsson
961e7da0a4 8026773: Failing compilation in Corba does not fail the build
Reviewed-by: ihse, tbell
2014-02-05 11:04:04 +01:00
Eric McCorkle
3bd9bdd993 8033004: Make base TypeAnnotationPosition data immutable, create better methods for creating base TypeAnnotationPositions
First of a series of major fixes to type annotations; cleans up interface with TypeAnnotationPosition

Reviewed-by: jjg
2014-02-03 17:19:15 -05:00
Jan Lahoda
4724c454cd 8030091: Request to update error messages from javac for negative varargs test cases
Introducing a new error message for vararg parameter not being the last parameter, improving error message for unexpected character after a parameter.

Reviewed-by: jjg, sogoel
2014-02-02 12:12:01 +01:00
Jonathan Gibbons
30e9783850 8033180: An inappropriate newline symbol in the help section
Reviewed-by: ksrini
2014-01-30 17:46:25 -08:00
Eric McCorkle
ca53cc64e5 8033218: Silent failure in TypeAnnotations.resolveFrame
Change silent no-op to assertion failure when resolveFrame is called before attribution.

Reviewed-by: jfranck
2014-01-30 07:35:49 -05:00
Jonathan Gibbons
214de0eb69 8032869: remove support for legacy options in javap
Reviewed-by: ksrini
2014-01-29 14:32:27 -08:00
Eric McCorkle
77feb9302c 8032932: Add assertion to fix silent failure in Gen.getAndRemoveNonFieldTAs
Turn silent failure if type annotation position type is UNKNOWN into assertion failure.

Reviewed-by: jjg
2014-01-28 17:52:30 -05:00
Eric McCorkle
07998a6335 8032980: Silent failure in Attr.annotateType
Turn silent discard of annotations in Attr.annotateType if conversion to TypeCompound fails into an assertion failure.

Reviewed-by: jjg
2014-01-28 17:51:28 -05:00
Jonathan Gibbons
552e338377 8032819: Extra empty line between field declarations for the "-v -c" and "-v -l" combination of options
Reviewed-by: ksrini
2014-01-28 14:31:29 -08:00
Jeff Dinkins
49b3f8639b 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
2014-01-28 20:10:19 +00:00
Lana Steuck
cf5fc4c79e Merge 2014-01-28 11:22:56 -08:00
Lana Steuck
b14b1b2b12 Merge 2014-01-27 21:01:30 -08:00
Jonathan Gibbons
69a6133c78 8032814: LineNumberTable/LocalVariableTable tables duplication for the "-v -l" combination of options
Reviewed-by: ksrini
2014-01-27 17:48:47 -08:00
Jonathan Gibbons
478d2876a5 8031212: doclint incorrectly rejects some @see tags in javadoc comments
Reviewed-by: vromero
2014-01-27 16:07:32 -08:00
Eric McCorkle
1bb2245091 8032587: Change silent failure in Attr.java to assertion
Change silent failure in Attr.fromAttributes into a non-null assertion

Reviewed-by: jfranck
2014-01-24 08:47:32 -05:00
Matherey Nunez
69f2f2fad4 8027175: Existing regression tests in tl/langtools and tl/jdk need to be updated for @bug keyword
Reviewed-by: jjg, ksrini
2014-01-27 12:45:03 -08:00
Andreas Lundblad
99aae5c1fd 8028267: sun.tools.javac.util.Bits contains a main-method with test code
Removed main method from Bits and added proper unit testing.

Reviewed-by: jfranck
2014-01-24 09:39:51 +01:00
Joel Borggrén-Franck
b1bcbaeb4b 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
Reviewed-by: abuckley, jlahoda, vromero
2014-01-23 14:09:29 +01:00
Kumar Srinivasan
70eb26fc0a 8031023: [javac] LambdaToMethod is missing forceSerializedRepresentation logic and switch
Reviewed-by: jjg, rfield
2014-01-23 06:34:53 -08:00
Sonali Goel
ab6480d153 8032506: Remove commit.txt that was accidentally pushed with the changeset
Reviewed-by: jjg
2014-01-22 14:45:51 -08:00
Vicente Romero
712b922a0f 8030816: javac crashes when mixing lambdas and inner classes
Reviewed-by: jjg, jlahoda
2014-01-22 21:41:50 +00:00
Matherey Nunez
0c38c2d401 8027477: Enable repeating annotations test cases since JDK-8004912 is fixed
Reviewed-by: jjg, jfranck
2014-01-22 12:22:23 -08:00
David Katleman
41e4558068 Added tag jdk9-b01 for changeset 71073f4a867e 2014-01-21 18:17:21 -08:00
Alexander Zuev
bb0c5d0f71 Merge 2014-01-20 19:11:58 +04:00
Joe Darcy
4fa17d99b2 8031375: Revert test exclusions after fix for JDK-8030656 propagates
Reviewed-by: mduigou
2014-01-18 10:47:30 -08:00
Abhijit Saha
69a1d18d40 Merge 2014-01-16 21:46:01 -08:00
Joe Darcy
87dec1fa1a 8031745: Remove unneeded/obsolete -source/-target options in javac tests, part 1
Reviewed-by: jjg, sogoel
2014-01-16 18:00:25 -08:00
Abhijit Saha
d9ec81d45f Merge 2014-01-15 10:18:06 -08:00
Jan Lahoda
9a0f6ed18e 8028576: Incorrect RuntimeVisibleTypeAnnotations for exception parameters when not generating debuging info
The exception parameters with type annotations need to be added into the varBuffer even if not generating debug info

Reviewed-by: jjg, emc
2014-01-15 13:49:57 +01:00
Joel Borggrén-Franck
b3e2823f53 8029690: Move symbol creation from ClassReader to Symtab
Reviewed-by: jjg
2014-01-15 10:57:25 +01:00
Abhijit Saha
c575ece03d Merge 2014-01-14 08:08:32 -08:00
Bhavesh Patel
4ff2c3b94a 8026736: Enhance Javadoc pages
Reviewed-by: jjg
2014-01-13 14:50:51 -08:00
Jan Lahoda
69c52bd73b 8039079: Test tools/javac/processing/environment/round/TestElementsAnnotatedWith.java fails
Ensuring the test passes in both samevm and othervm modes.

Reviewed-by: darcy
2014-04-15 18:58:47 +02:00
Eric McCorkle
bd6695901c 8040181: Silent failure in Code.findExceptionIndex
Remove silent failure when exception index has not been set properly.

Reviewed-by: jjg
2014-04-14 18:48:29 -04:00
Jeff Dinkins
c704bce1fa 7129980: Third Party License Readme update for JDK8
Reviewed-by: lana, tbell
2014-01-13 14:44:29 -08:00
Kumar Srinivasan
f643b8cab0 8031545: [javac] refactor and cleanup JNIWriter.java
Reviewed-by: jjg
2014-02-15 16:37:19 -08:00
Kumar Srinivasan
c7480b6513 8029145: javadoc fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-02-14 17:28:07 -08:00
Andreas Lundblad
8daec20c86 8030714: The steps attribute, flow and desugar are unnecessary for implicit classes when compiling with -implicit:none
When compiling with -implicit:none, attribute, flow and desugar is skipped for better performance.

Reviewed-by: jfranck, jlahoda
2014-02-13 14:58:10 +01:00
Jan Lahoda
e20546fe2a 8033961: Formatting of -Xlint: command line help
Improving formatting of command line help for -Xlint, including a short description of each lint.

Reviewed-by: jjg
2014-02-13 13:38:48 +01:00
Dan Smith
55801d06ff 4910483: Javadoc renders the string ".*\\.pdf" as ".\*\.pdf"
Adjust timing of printing "\\" in the comment scanner

Reviewed-by: jjg
2014-02-12 12:31:30 -07:00
Jonathan Gibbons
4e86ae9988 8033930: Unnecessary new line after the StackMapTable
8033913: Incorrect indentation of StackMapTable entries

Reviewed-by: ksrini
2014-02-10 11:52:52 -08:00
Jan Lahoda
c0d767f6f1 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
When the overrides deprecated method warning is being reported, need to do that in the lint context of the method.

Reviewed-by: vromero
2014-02-07 21:43:33 +01:00
Jonathan Gibbons
29f985089a 8033581: Incorrect comment aligment
8033798: javap output has unnecessary trailing whitespace
8033726: StackMapTable does not unindent properly

Reviewed-by: ksrini
2014-02-06 18:54:13 -08:00
Christine Lu
67d15f03e0 8032526: fix the accessibility, html, syntax errors and warnings reported by doclint report in langtools
Reviewed-by: jjg
2014-02-06 16:39:19 -08:00
Jonathan Gibbons
8b3c6d6d4f 8033114: The values of non-static final fields are printed for the -constants option
Reviewed-by: ksrini
2014-02-06 15:43:23 -08:00
Jonathan Gibbons
47528ece5e 8033711: An exception is thrown if using the \"-classpath\" option with no arguments
Reviewed-by: ksrini
2014-02-06 11:01:50 -08:00
Jonathan Gibbons
5b738090bd 8033686: Internal error for zero indent
Reviewed-by: ksrini
2014-02-06 10:58:51 -08:00
Vicente Romero
edee080e4a 8030855: Default methods should be visible under source previous to 8
Reviewed-by: jjg, dlsmith
2014-02-06 18:49:01 +00:00
Alan Bateman
cf7f5c0b61 8033366: Add configure option to allow RMIConnector IIOP transport be selected compiled in or not
Reviewed-by: erikj
2014-02-06 15:49:51 +00:00
Jan Lahoda
8a2542c71f 8030049: RoundEnvironment.getElementsAnnotatedWith receives wrong elements
Match the required and actual annotations using Element equivalence rather than TypeMirror equivalence, to avoid trouble with erroneous types.

Reviewed-by: darcy
2014-01-10 19:02:54 +01:00
Andreas Lundblad
a76d1ab5a2 8028389: NullPointerException compiling annotation values that have bodies
Made sure anonymous class declarations inside class- and package-level annotations are properly entered.

Reviewed-by: jfranck
2014-01-10 12:47:15 +01:00
Jan Lahoda
e32b40185e 8029376: Full attribution of unresolvable annotations
8029161: javac crashing when processing broken annotations

Attributing values of annotation attributes regardless how broken the annotation is.

Reviewed-by: jjg, jfranck
2014-01-10 11:31:09 +01:00
Andreas Lundblad
147820083e 8006730: remove workaround tests when jtreg updated
Removed temporary workaround test-files.

Reviewed-by: jjg
2014-01-09 15:00:33 +01:00
Joe Darcy
3815f04fbc 8000962: Update JDK_MINOR_VERSION for JDK 9
Reviewed-by: jjg, ksrini
2014-01-07 15:00:23 -08:00
Joe Darcy
dd72fa55fc 8031360: Update langtools code base to use RELEASE_9
Reviewed-by: jjg
2014-01-07 13:47:49 -08:00
Joe Darcy
6fc7157058 8028543: Add SourceVersion.RELEASE_9
Reviewed-by: jjg
2014-01-07 11:43:56 -08:00