Commit Graph

3210 Commits

Author SHA1 Message Date
Srikanth Adayapalam
1be81e358c 8062358: ClassCastException in TransTypes.visitApply
Incorrect handling of subtype relations involving lower bounded wildcard causes ClassCastException

Reviewed-by: vromero, dlsmith
2015-01-13 10:17:25 +01:00
Lana Steuck
d02d97a197 Merge 2015-01-12 12:23:34 -08:00
Joe Darcy
b5b236c2de 8006469: Cleanup reflective access of java.lang.annotation.Repeatable
Reviewed-by: jfranck
2015-01-12 09:19:06 -08:00
Jonathan Gibbons
01520ed2aa 8068759: ConstFoldTest fails on Windows
Reviewed-by: ksrini
2015-01-09 18:03:01 -08:00
Srikanth Adayapalam
4eb573aa81 8067914: Redundant type cast nodes in AST (follow up from JDK-8043741)
Workaround for redundant (but harmless) synthetic cast generated in TransTypes

Reviewed-by: mcimadamore
2015-01-09 15:51:20 +00:00
Srikanth Adayapalam
7e499fd15b 8067429: java.lang.VerifyError: Inconsistent stackmap frames at branch target
Bitset for alive variables contains info about variables out of range

Reviewed-by: mcimadamore
2015-01-09 15:50:22 +00:00
Srikanth Adayapalam
5de84c2836 8043741: VerifyError due to missing checkcast
Proto-type is not set correctly for NULLCHK synthetic trees

Reviewed-by: mcimadamore
2015-01-09 15:49:42 +00:00
Srikanth Adayapalam
0eb55d78b6 8066871: java.lang.VerifyError: Bad local variable type - local final String
BaseType() erroneously called on MethodResultInfo causes lack of constant type info

Reviewed-by: jlahoda, mcimadamore
2015-01-09 15:48:09 +00:00
Sonali Goel
274f997aee 8058373: Group 10a: golden files for tests in tools/javac dir
Reviewed-by: jjg, darcy
2015-01-08 22:01:20 -08:00
David Katleman
db04fe4518 Added tag jdk9-b45 for changeset 439ddf7e360f 2015-01-08 12:08:32 -08:00
Maurizio Cimadamore
56a33e4541 8058542: Devise scheme for better diagnostic creation
Add support for generating (at build-time) an enum-like class containing all javac diagnostics, which allows for safe diagnostic creation.

Reviewed-by: jlahoda, jjg, vromero, erikj, jfranck
2015-01-08 14:43:05 +00:00
Joe Darcy
5cb7065612 8068639: Make certain annotation classfile warnings opt-in
Reviewed-by: jjg
2015-01-07 17:06:47 -08:00
Jonathan Gibbons
e6ea1f0ff8 8059977: StandardJavaFileManager should support java.nio.file.Path
Reviewed-by: jlahoda
2015-01-06 14:51:10 -08:00
Maurizio Cimadamore
75b2a03bf9 8067883: Javac misses some opportunities for diagnostic simplification
Javac always report full inference diagnostic, even when message does not mention inference variables.

Reviewed-by: jlahoda
2015-01-06 15:46:41 +00:00
Vicente Romero
f6ed87ed5a 8064857: javac generates LVT entry with length 0 for local variable
Reviewed-by: mcimadamore, jjg
2015-01-05 17:35:48 -08:00
Lana Steuck
ec6ff5dd1c Merge 2014-12-30 13:19:41 -08:00
David Katleman
e3fda43a86 Added tag jdk9-b44 for changeset 518c958a4dfa 2014-12-30 09:44:22 -08:00
Lana Steuck
7da3e924e0 Merge 2014-12-25 19:44:49 -08:00
Sonali Goel
11b1d2cdad 8054689: Split large SJavac.java test source into multiple files
Reviewed-by: jjg, jfranck
2014-12-24 11:17:51 -08:00
Lana Steuck
7f05a39aac Merge 2014-12-23 13:58:01 -08:00
Joel Borggrén-Franck
9196ed684d 8061472: String.format in DeferredAttr.DeferredTypeMap constructor leads to excessive object creation
Reviewed-by: mcimadamore, vromero
2014-12-19 21:07:53 +01:00
Lana Steuck
8edd68a854 Added tag jdk9-b43 for changeset 592c5d3be509 2014-12-18 19:57:56 -08:00
Maurizio Cimadamore
c269c9451b 8066974: Compiler doesn't infer method's generic type information in lambda body
Add loghic to avoid post-inference triggers on temporarty AST types

Reviewed-by: jlahoda, vromero
2014-12-18 13:21:44 +00:00
Robert Field
f4ab205b3f 8067384: Facilitate extension of the javac parser
Reviewed-by: jjg
2014-12-17 12:48:04 -08:00
Maurizio Cimadamore
41070244c9 8067792: Javac crashes in finder mode with nested implicit lambdas
Revert tree changes occurred in Attr before running the analyzer

Reviewed-by: jlahoda
2014-12-17 16:47:56 +00:00
Jan Lahoda
627ce960f5 8067422: Lambda method names are unnecessarily unstable
Lambda method numbers are now assigned per class for non-serializable lambdas.

Reviewed-by: mcimadamore, rfield
2014-12-17 12:49:57 +01:00
Maurizio Cimadamore
eb3798a14a 8067663: Add bugId to tests that have been modified as part of JDK-8064365
Add missing bug id to modified tests

Reviewed-by: jlahoda
2014-12-16 13:44:22 +00:00
Mandy Chung
7167a27a1f 8067360: verify-modules target was dropped in jdk9 b41
Reviewed-by: alanb, erikj
2014-12-15 10:29:54 -08:00
Maurizio Cimadamore
3076062240 8064365: Better support for finder capabilities in target-typing context
Add new framework to allow for easy creation of finder-like capabilities.

Reviewed-by: jjg, jlahoda
2014-12-12 18:07:24 +00:00
Jonathan Gibbons
0900c1f2e0 8066808: langtools/test/Makefile should not use OS-specific jtreg binary
Reviewed-by: mcimadamore
2014-12-11 18:23:17 -08:00
Jonathan Gibbons
827f52c966 8066807: langtools/test/Makefile should use -agentvm not -samevm
Reviewed-by: mcimadamore
2014-12-11 18:20:00 -08:00
Lana Steuck
3db9cfa542 Merge 2014-12-11 12:26:42 -08:00
David Katleman
e2239dc2bb Added tag jdk9-b42 for changeset a48998a1fc72 2014-12-11 11:44:07 -08:00
Andrei Eremeev
282c943241 8065360: Implement a test that checks possibilty of class members to be imported
Reviewed-by: jlahoda, anazarov
2014-12-10 21:45:39 +02:00
Maurizio Cimadamore
da41cfd9f1 8067006: Tweak IntelliJ langtools project to show jtreg report directory
Jtreg test output directory should be allowed to flow into IntelliJ's output

Reviewed-by: jlahoda
2014-12-09 17:40:02 +00:00
Maurizio Cimadamore
a800908e25 8067001: DetectMutableStaticFields fails after modular images push
Ignore JRTIndex.sharedInstance

Reviewed-by: jlahoda
2014-12-09 16:09:07 +00:00
Andrei Eremeev
400505a1f2 8066961: NegativeCyclicDependencyTest.java fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jlahoda
2014-12-09 11:45:38 +01:00
Andrei Eremeev
ea81e1bc1f 8064794: Implement negative tests for cyclic dependencies in import statements
Reviewed-by: jlahoda, anazarov
2014-12-09 01:06:11 +02:00
Jan Lahoda
cf476e9302 8066902: JavacParserTest fails on Windows
Normalizing line endings to '\n'.

Reviewed-by: jjg, ksrini
2014-12-08 21:26:04 +01:00
Jan Lahoda
59b3453845 8061549: Disallow _ as a one-character identifier
Underscore is no longer a one-charater identifier with -source 9

Reviewed-by: mcimadamore, jjg
2014-12-08 18:02:07 +01:00
Maurizio Cimadamore
fb05a03095 8066889: IntelliJ langtools launcher ought to be Windows friendly
Fixup file and path separators in project setup stage.

Reviewed-by: jlahoda
2014-12-08 16:30:43 +00:00
Jan Lahoda
113babff27 8065753: javac crashing on a html-like file
Avoiding special-case in error recovery for bad token on position 0.

Reviewed-by: jjg
2014-12-08 11:50:19 +01:00
Jonathan Gibbons
78fd11386c 8066737: langtools/test/tools/javac/processing/6348193/T6348193.java fails
Reviewed-by: darcy
2014-12-04 19:09:29 -08:00
Lana Steuck
47757481e4 Merge 2014-12-04 15:22:53 -08:00
Alan Bateman
de3548c4b9 8066731: javac does not work on exploded image
Reviewed-by: jjg, mchung
2014-12-04 14:57:40 -08:00
David Katleman
712feea533 Added tag jdk9-b41 for changeset d1a63c99cdd5 2014-12-04 12:58:21 -08:00
Chris Hegarty
189df3ac57 Merge 2014-12-03 19:28:40 +00:00
Chris Hegarty
8bc2b3ff3a 8049367: Modular Run-Time Images
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Bradford Wetmore <bradford.wetmore@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: James Laskey <james.laskey@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Co-authored-by: Sundararajan Athijegannathan <sundararajan.athijegannathan@oracle.com>
Reviewed-by: jlahoda, ksrini
2014-12-03 14:25:46 +00:00
Jan Lahoda
d739446063 7101822: Compiling depends on order of imports
7177813: Static import to local nested class fails

MemberEnter overhaul - TypeEnter is split out of MemberEnter; the TypeEnter consists of several Phases which ensure actions are done in the correct order.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jfranck, aeremeev
2014-12-03 13:46:12 +01:00
Maurizio Cimadamore
02df6a4564 8065986: Compiler fails to NullPointerException when calling super with Object<>()
Missing POLY kind selector on recursive constructor calls with poly arguments

Reviewed-by: vromero
2014-11-28 11:45:56 +00:00
Robert Field
634c33938c 8058112: Invalid BootstrapMethod for constructor/method reference
Bridge method references with functional interface method parameters of intersection type

Reviewed-by: vromero, dlsmith
2014-11-24 14:52:46 -08:00
Jan Lahoda
26298f1124 8032211: Don't issue deprecation warnings on import statements
6598104: javac should not warn about imports of deprecated classes

Suppressing the deprecation warnings when importing a deprecated element (deprecations in import qualifier will be produced).

Reviewed-by: darcy, jjg, mcimadamore
2014-11-24 16:02:35 +01:00
Eric McCorkle
590188542e 8065132: Parameter annotations not updated when synthetic parameters are prepended
Cause javac to add synthetic parameters to Runtime[In]VisibleParameterAnnotations attributes

Reviewed-by: jjg, jfranck
2014-11-21 16:36:39 -05:00
Jonathan Gibbons
bdf693fcc5 8061876: replace java.io.File with java.nio.file.Path (again)
Reviewed-by: ksrini, jlahoda
2014-11-21 10:38:43 -08:00
Joel Borggrén-Franck
8bf55955df 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
Reviewed-by: jlahoda, vromero
2014-11-21 12:36:21 +01:00
Jonathan Gibbons
56e39629eb 8065054: Some tests have junk before the legal header
Reviewed-by: darcy
2014-11-20 14:23:31 -08:00
Vicente Romero
60113dc1ba 8063052: Inference chokes on wildcard derived from method reference
Reviewed-by: mcimadamore
2014-11-20 14:05:39 -08:00
Lana Steuck
fc8789b7ed Merge 2014-11-20 11:17:17 -08:00
Jonathan Gibbons
6bfd41fed8 8058445: Javac throws exception when displaying info
Reviewed-by: vromero, jfranck
2014-11-20 11:00:29 -08:00
Lana Steuck
7845653e68 Merge 2014-11-20 10:58:31 -08:00
Vicente Romero
418c9789d6 8059921: Missing compile error in Java 8 mode for Interface.super.field access
Reviewed-by: mcimadamore, jlahoda
2014-11-20 09:43:13 -08:00
Jan Lahoda
a2b0a2413e 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
Allowing final variables as operands to try-with-resources; also reviewed by Sergei Pikalev.

Reviewed-by: darcy, mcimadamore, vromero
2014-11-19 13:46:04 +01:00
David Katleman
f141ae6666 Added tag jdk9-b40 for changeset 5152f73fa93b 2014-11-18 15:25:18 -08:00
Michael Fang
9d6d069c22 8055798: Japanese translation for a warning from javac looks incorrect
Reviewed-by: peytoia
2014-11-17 23:11:05 -08:00
Maurizio Cimadamore
5bb86103a9 8064803: Javac erroneously uses instantiated signatures when merging abstract most-specific methods
Wrong method type used in AmbiguousError.mergeAbstracts

Reviewed-by: jlahoda
2014-11-17 23:41:56 +00:00
Jan Lahoda
e158f32141 8062747: Compiler error when anonymous class uses method with parametrized exception
When inferring lambda's thrown types, avoid tracking variables that are not under the lambda to avoid crashes.

Reviewed-by: vromero
2014-11-14 11:58:28 +01:00
Lana Steuck
fe30b6862a Merge 2014-11-13 09:39:52 -08:00
Andreas Lundblad
e404341a88 8059591: Give TaskListener methods empty default implementations
Added empty default implementations for TaskListener methods.

Reviewed-by: jfranck, ohrstrom
2014-11-13 14:49:02 +01:00
David Katleman
30d62171d4 Added tag jdk9-b39 for changeset b2343bf3a5d8 2014-11-12 20:32:27 -08:00
Jan Lahoda
b136af5563 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
When calling dupUnshared on a shared scope, make sure the result does not contain Symbols that don't belong to the scope that is being dupUnshared.

Reviewed-by: mcimadamore
2014-11-12 19:05:17 +01:00
Andrei Eremeev
9130b22f3f 8042931: Implement classfile tests for EnclosingMethod attribute
Reviewed-by: jjg, shurailine, anazarov
2014-11-12 15:16:35 +02:00
Maurizio Cimadamore
ed9c1bb743 8064464: regression with type inference of conditional expression
Bad classification of conditional leads to spurious error

Reviewed-by: jlahoda
2014-11-12 12:41:32 +00:00
Andreas Lundblad
732c7c5e28 8062737: Sjavac creates unnecessarily many SjavacClient/PooledSjavac/SjavacImpl instances
Moved sjavac initialization out of loop body.

Reviewed-by: jfranck, ohrstrom
2014-11-10 20:29:58 +01:00
Lana Steuck
6b9913f667 Merge 2014-11-06 15:13:39 -08:00
David Katleman
30c5d4c4e8 Added tag jdk9-b38 for changeset babdaa819add 2014-11-06 10:11:40 -08:00
Maurizio Cimadamore
87d664f4f0 8062977: Inference: NullPointerException during bound incorporation
Bogus Types.asSuper call on array type symbol

Reviewed-by: vromero
2014-11-06 14:33:22 +00:00
Maurizio Cimadamore
ded3a562b9 6987475: Order of declarations affects whether abstract method considered overridden
Types.implementation erroneously returns first matching method in hierarchy.

Reviewed-by: vromero
2014-11-06 14:31:56 +00:00
Jonathan Gibbons
c4f3406133 8063074: test/tools/javac/plugin/showType/Test.java fails on Windows
Reviewed-by: ksrini
2014-11-05 19:48:42 -08:00
Jonathan Gibbons
a75d2dbd39 8062676: Tests which leak lots of file managers should be fixed (group 2)
Reviewed-by: darcy
2014-11-05 19:12:45 -08:00
Jonathan Gibbons
b96daffd2e 8063039: incorrect message reference or broken message file
Reviewed-by: ksrini
2014-11-05 19:09:09 -08:00
Eric McCorkle
0acac5a3d5 8035259: javac, incorrect shadowing of classes vs type parameters
Cause javac to look at type variables first when resolving names in an extends/implements list

Reviewed-by: mcimadamore, jlahoda
2014-11-05 08:37:04 -05:00
Sonali Goel
4ca3a232d1 8062314: Update tools/javac/plugin/showtype/Test.java to use ToolBox.java
Reviewed-by: jjg
2014-11-04 13:21:25 -08:00
Andreas Lundblad
4a3d559ffb 8062740: Since changeset 2686:030080f03e4f test/tools/sjavac/DependencyCollection.java does no longer compile
Added throws IOException to main method.

Reviewed-by: jjg
2014-11-04 09:04:13 +01:00
Andreas Lundblad
78ab98e8fa 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
Refactoring of the sjavac background fork code.

Reviewed-by: jfranck, ohrstrom
2014-11-03 10:20:34 +01:00
Dan Smith
44213132ab 8062449: Update langtools/test/Makefile to use JCK 9
Updated to JCK 9 and improved use of variables to control the invocation

Reviewed-by: jjg, erikj
2014-10-31 17:23:21 -06:00
Kumar Srinivasan
60b8135982 8061305: Javadoc crashes when method name ends with "Property"
Reviewed-by: jjg
2014-10-31 07:02:56 -07:00
Jonathan Gibbons
10d96d7aec 8062593: remove debug print statements
Reviewed-by: vromero
2014-10-30 17:31:22 -07:00
Jonathan Gibbons
ee2e529d22 8062579: JavacTask, DocumentationTask impls should close file manager when possible
Reviewed-by: ksrini
2014-10-30 16:08:43 -07:00
Sonali Goel
35b29e7662 8062336: Revert tools/javap/T6729471.java to original test code
Reviewed-by: jjg
2014-10-30 15:21:42 -07:00
Lana Steuck
c7ec9afee6 Merge 2014-10-30 13:55:51 -07:00
David Katleman
e9d3130f3d Added tag jdk9-b37 for changeset f3f667e5870c 2014-10-30 08:35:04 -07:00
Jonathan Gibbons
342df9829a 8062514: Update ToolTester tests to close file manager
Reviewed-by: darcy
2014-10-29 19:07:34 -07:00
Jonathan Gibbons
4ce27b2f9e 8062504: javadoc Start does not close file managers that it opens
Reviewed-by: ksrini
2014-10-29 18:01:22 -07:00
Jonathan Gibbons
8bd23f1681 8062348: langtools tests should close file manager (group 1)
Reviewed-by: darcy
2014-10-29 17:25:23 -07:00
Richard Warburton
b587478f7c 8062376: Suppress cast warnings when using NIO buffers
Reviewed-by: psandoz, jfranck
2014-10-29 12:09:17 +01:00
Sonali Goel
0bfa3c5036 8059423: Replace references for rt.jar by temp.jar
Reviewed-by: jjg
2014-10-27 10:43:09 -07:00
Andreas Lundblad
d3be5ae723 8060715: There is a small race condition in IdleResetSjavac
Synchronizes on method level instead of variable access level.

Reviewed-by: jfranck
2014-10-27 14:55:47 +01:00
Jan Lahoda
70e627d95d 8061323: JavadocTokenizer repeatedly compiles pattern to check for deprecation
Keeping the "@deprecated" Pattern in a static field.

Reviewed-by: mcimadamore
2014-10-24 20:07:08 +02:00
Joel Borggrén-Franck
991885e85d 8060448: ArrayIndexOutOfBoundsException with annotation processing printout of empty line
Reviewed-by: jlahoda
2014-10-24 10:08:51 +02:00
Maurizio Cimadamore
1de8cf1b7f 8064367: Fix IntelliJ langtools support to use new dev build
Update ant hooks in langtools IntelliJ project

Reviewed-by: jlahoda
2014-11-08 22:00:31 +00:00
Jonathan Gibbons
de2b97f133 8063145: ToolBox should support extracting classes from a JavaFileManager/Location
Reviewed-by: ksrini
2014-11-07 14:51:35 -08:00
Jan Lahoda
3f3f44af47 8058489: More adjustments of langtools/make/build.xml to modularized layout
Re-structuring the langtools/make/build.xml to reflect the modular layout, cleanup of the build script

Reviewed-by: jjg, mcimadamore, ksrini
2014-11-07 18:22:36 +01:00
Eric McCorkle
ab1b9a9cf1 8029012: parameter_index for type annotation not updated after outer.this added
Fix javac's handling of type annotations when synthetic parameters are added

Reviewed-by: jjg, mcimadamore
2014-11-07 07:54:35 -05:00
Eric McCorkle
aca235b121 8062245: Test executes incorrect class
Fix issue with test executing incorrect class, and trivial test failure linked to different subclasses of CharSequance.

Reviewed-by: jjg
2014-11-06 17:39:57 -05:00
Joel Borggrén-Franck
0149333fb8 8054448: (ann) Cannot reference field of inner class in an anonymous class
Reviewed-by: jlahoda, mcimadamore
2014-10-24 08:34:51 +02:00
Maurizio Cimadamore
535317c6f8 8061778: Wrong LineNumberTable for default constructors
Synthetic empty blocks generated by Lower are erroneously picked up by Gen

Reviewed-by: jjg
2014-10-24 10:54:04 +01:00
Lana Steuck
e163976e11 Merge 2014-10-23 13:43:56 -07:00
David Katleman
a2809ad3eb Added tag jdk9-b36 for changeset d1480cb49283 2014-10-23 11:19:28 -07:00
Vicente Romero
96941c8951 8057800: Method reference with generic type creates NPE when compiling
Reviewed-by: mcimadamore, dlsmith
2014-10-23 10:42:44 -07:00
Vicente Romero
503cf15f62 8059710: javac, the same approach used in fix for JDK-8058708 should be applied to Code.closeAliveRanges
Reviewed-by: jjg
2014-10-23 10:40:02 -07:00
Jonathan Gibbons
5074c6ed36 8061723: 8060056 breaks tests on Windows
Reviewed-by: darcy
2014-10-21 17:50:13 -07:00
Jonathan Gibbons
0e0e189bf6 8060056: replace java.io.File with java.nio.file.Path
Reviewed-by: ksrini, jlahoda
2014-10-21 13:08:20 -07:00
Eric McCorkle
8244cae54a 8054457: Refactor Symbol kinds from small ints to an enum
Replace bitmap logic in symbol.kind and pkind with an enum-based API

Reviewed-by: mcimadamore, jjg
2014-10-21 09:01:51 -04:00
Lana Steuck
fc6e1fedd3 Merge 2014-10-16 14:55:17 -07:00
Jonathan Gibbons
cf1a634000 8040131: Implement classfile test for LineNumberTable attribute
Reviewed-by: jjg, shurailine
2014-10-16 14:31:37 -07:00
Lana Steuck
6e571834a4 Merge 2014-10-16 14:15:23 -07:00
David Katleman
a1a5ed97f2 Added tag jdk9-b35 for changeset 906669fe9f2d 2014-10-16 12:02:08 -07:00
Maurizio Cimadamore
2756ed20d7 8058511: StackOverflowError at com.sun.tools.javac.code.Types.lub
Lub crashes when handling typevar with array bound

Reviewed-by: vromero, dlsmith
2014-10-14 12:01:05 +01:00
Maurizio Cimadamore
8f96799dd5 8058199: Code generation problem with javac skipping a checkcast instruction
TransTypes sometimes ignores inferred signatures when emitting synthetic casts

Reviewed-by: vromero
2014-10-14 12:00:39 +01:00
Paul Govereau
8cc03657e9 8060249: Backout fix for JDK-8058243
Reviewed-by: vromero
2014-10-13 17:09:12 -04:00
Paul Govereau
ef05cafd6b 8060234: Fix push for JDK-8058243
Reviewed-by: jjg, vromero
2014-10-13 12:12:06 -04:00
Jan Lahoda
1eb03e49bf 8054956: Javac reports wrong error offset for unknown identifier of annotation element/value pair
When reporting an error about unresolvable annotation attribute, use the position of the explicit left-hand-side of the assignment if available, otherwise use the position of the right-hand-side.

Reviewed-by: jfranck
2014-10-13 17:22:47 +02:00
Paul Govereau
f3201874bc 8058243: Reduce size of bytecode for large switch statements
Reviewed-by: jjg, vromero
2014-10-13 11:21:51 -04:00
Sonali Goel
a7b8ca6209 8058410: Group 10b: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-10-10 14:41:50 -07:00
Jonathan Gibbons
4f08e490bb 8060043: Rename Locations.Path to Locations.SearchPath
Reviewed-by: ksrini
2014-10-09 19:14:30 -07:00
Lana Steuck
0a0955f7fc Merge 2014-10-09 12:17:46 -07:00
David Katleman
f430fd6995 Added tag jdk9-b34 for changeset adc83124cc10 2014-10-09 11:24:21 -07:00
Jan Lahoda
e95348b58e 8057652: Request to improve error messages for labeled declarations
Parse labeled statements as block statements to improve error recovery for labeled declarations; related cleanup.

Reviewed-by: jjg
2014-10-09 10:08:52 +02:00
Andreas Lundblad
0545e4b847 8059349: Public API scanning should be implemented in the form of a TaskListener
Replaces JavaCompilerWithDeps with a TaskListener.

Reviewed-by: jfranck
2014-10-07 21:21:42 +02:00
Andreas Lundblad
96074068b8 8056258: Analysis of public API does not take super classes into account
8048609: simplify sjavac dependence on javac dependency gathering

Replaces Attr-/ResolveWithDeps with TaskListeners

Reviewed-by: jfranck, ohrstrom
2014-10-07 21:15:10 +02:00
Robert Field
e55ca9fc58 8056051: int[]::clone causes "java.lang.NoClassDefFoundError: Array"
Reviewed-by: mcimadamore, vromero
2014-10-04 10:13:11 -07:00
Lana Steuck
97f636e1e0 Merge 2014-10-03 12:11:32 -07:00
Lana Steuck
e57f07df2c Added tag jdk9-b33 for changeset 6be305e56bcb 2014-10-03 11:07:15 -07:00
Sonali Goel
1f9a38f175 8055783: Group 9e: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore
2014-10-01 14:15:40 -07:00
Bhavesh Patel
3fad9f6677 8048351: tidy errors for attribute href, name for langtools javadoc tests needs investigation
Reviewed-by: jjg
2014-09-26 13:51:43 -07:00
Vicente Romero
97309123c1 8058708: java.lang.AssertionError compiling source code
Reviewed-by: jjg
2014-09-25 17:09:23 -07:00
Lana Steuck
187e5e2014 Merge 2014-09-25 16:21:30 -07:00
Liam Miller-Cushon
08336b39dd 8059453: javac crashes with -Xjcov and union types
Reviewed-by: jlahoda, vromero
2014-09-25 14:38:29 -07:00
Neil Toda
9fbf466c3f 8050117: add to javac test Versions.java tests that show correct operation for source/target options pre 1.9
Reviewed-by: jjg
2014-09-25 13:54:45 -07:00
David Katleman
65623bce6d Added tag jdk9-b32 for changeset c005611e8f69 2014-09-25 12:40:30 -07:00
Eric McCorkle
b4401ebed9 8048614: Add TypeMetadata to contain type annotations and other type information
Implement general framework for metadata on types

Reviewed-by: mcimadamore
2014-09-22 17:09:33 -04:00
Jan Lahoda
c30ea9e1d2 8057794: Compiler Error when obtaining .class property
Ensuring a non-null type and sym for illegal T.class to prevent downstream errors.

Reviewed-by: mcimadamore
2014-09-22 14:55:14 +02:00
Sonali Goel
2700003cdb 8058755: Update tools/javadoc/6227454 to add head tag
Reviewed-by: jjg
2014-09-19 13:54:34 -07:00
Lana Steuck
ea3bc6a6cd Merge 2014-09-18 13:27:02 -07:00
Bhavesh Patel
b02c07123c 8047745: Javadoc should include encoding information in generated html files
Reviewed-by: jjg, ksrini
2014-09-18 00:50:48 -07:00
Bhavesh Patel
99ec33372d 8043698: <title> tag not getting generated in package-summary pages for un-named packages
Reviewed-by: jjg, ksrini
2014-09-17 23:52:19 -07:00
David Katleman
caab6b308c Added tag jdk9-b31 for changeset 34aa137c3d5f 2014-09-17 22:56:11 -07:00
Maurizio Cimadamore
ae97aeb0d9 8055963: Inference failure with nested invocation
Revise heuristics to force eager instantiation of return inference vars

Reviewed-by: vromero
2014-09-15 12:43:35 +01:00
Sonali Goel
79efb2b9d8 8055080: Group 9d: golden files for tests in tools/javac dir
Reviewed-by: jjg, mcimadamore, jlahoda
2014-09-12 17:05:18 -07:00
Lana Steuck
fcdbd856ff Merge 2014-09-11 14:29:01 -07:00
Bradford Wetmore
95f194a17f 8058180: .hgignore should be updated with webrev in all repos
Reviewed-by: jrose, katleman, jjg
2014-09-11 12:18:01 -07:00
David Katleman
e084155def Added tag jdk9-b30 for changeset 290847867ded 2014-09-11 09:09:00 -07:00
Lana Steuck
e3fe6d0c95 Merge 2014-09-10 19:38:20 -07:00
Vicente Romero
8f9e586968 8042347: javac, Gen.LVTAssignAnalyzer should be refactored, it shouldn't be a static class
Reviewed-by: mcimadamore, jjg, jlahoda
2014-09-09 10:43:06 -07:00
Paul Govereau
d65d28d993 8054210: NullPointerException when compiling specific code
Reviewed-by: vromero, jlahoda
2014-09-09 12:16:25 -04:00
Paul Govereau
a37e9881b2 8055500: fix for 8030046 is incorrect
Reviewed-by: jjg, ksrini
2014-09-09 11:55:47 -04:00
Jan Lahoda
2beda23cf8 8057753: Test langtools/test/tools/javac/NoClass.java is failing when run together with langtools/test/tools/javac/DuplicateImport.java
Removing javac/NoClass test, as it is superseded by javac/importChecks/InvalidImportsNoClasses.java

Reviewed-by: jfranck
2014-09-08 15:51:29 +02:00
Maurizio Cimadamore
a9061c2918 8055514: Wrong, confusing error when non-static varargs referenced in static context
Improved heuristics in MethodResolutionPhase.mergeResults()

Reviewed-by: vromero
2014-09-08 14:16:33 +01:00
Joel Borggrén-Franck
053a9d56cd 8056021: checkin for JDK-8027262 breaks Checker Framework
Reviewed-by: jjg, mcimadamore
2014-09-08 13:11:28 +02:00
Jan Lahoda
f211cac0cd 8056984: Exception in compiler: java.lang.AssertionError: isSubClass T
Must use type variable's captured bound as a method receiver, instead of the type variable itself, while checking if deferred attribution is needed.

Reviewed-by: mcimadamore, vromero
2014-09-08 10:50:59 +02:00
Jan Lahoda
49469c49d0 8056014: Type inference may be skipped for a complex receiver generic method in a parameter position
When checking if deferred attribution is needed for a chain of methods, stop on any method that returns any type variable, as the rest of analysis cannot use the correct type.

Reviewed-by: mcimadamore, vromero
2014-09-08 10:48:18 +02:00
Sonali Goel
f064e2b028 8055079: Group 9c: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-09-05 16:51:39 -07:00
Sonali Goel
170f8549b4 8055075: Group 9b: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-09-05 16:43:00 -07:00
Sonali Goel
15420bd193 8055996: Remove @ignore from tools/javac/T6725036.java
Reviewed-by: jjg
2014-09-04 16:52:40 -07:00
Lana Steuck
dc1b9c542f Merge 2014-09-04 14:45:48 -07:00
David Katleman
b931b38fd0 Added tag jdk9-b29 for changeset 639910c83675 2014-09-04 13:26:40 -07:00
Jan Lahoda
6cac1178ba 8047675: tools/javac/defaultMethods/Assertions.java fails if run with -enableassertions (-ea)
Using ToolBox to start new Java processes, to avoid passing default VM options to the newly started process.

Reviewed-by: jjg
2014-09-04 08:49:20 +02:00
Jan Lahoda
83abeb739b 8054563: Update RunCodingRules.java for source code reorg
Tests RunCodingRules and MessageInfo fixed to work in the new source code structure.

Reviewed-by: jjg
2014-09-04 08:48:29 +02:00
Jonathan Gibbons
f0b4f3d282 8038414: Constant pool's strings are not escaped properly
Reviewed-by: jjg, mcimadamore, ksrini
2014-09-03 14:19:39 -07:00
Jonathan Gibbons
3b029e1995 8034861: Incorrect format and indentation of InnerClasses section
Reviewed-by: jjg, ksrini, mcimadamore, lagergren
2014-09-03 14:06:25 -07:00
Alexander Zuev
f4e40eeff6 8044597: Request to update tools/javap/T4501661.java to add test for package option
Reviewed-by: jjg
2014-09-03 19:22:16 +04:00
Maurizio Cimadamore
ef0951db68 8057005: IntelliJ should allow import for nested classes
Minor tweaks to langtools intellij project

Reviewed-by: jfranck
2014-09-01 17:41:01 +01:00
Sonali Goel
b8919f9429 8056288: Missing bug id in test/com/sun/javadoc/testOrdering/TestOrdering.java
Reviewed-by: ksrini
2014-08-29 14:08:49 -07:00
Lana Steuck
458e8af18d Merge 2014-08-29 11:57:50 -07:00
David Katleman
5ca16bd5d8 Added tag jdk9-b28 for changeset 6ce251a87137 2014-08-29 11:30:58 -07:00
Mandy Chung
b82e9ddea4 8055856: checkdeps build target doesn't work for cross-compilation builds
8056113: [build] tools.jar missing modules.xml

Reviewed-by: ihse, erikj
2014-08-29 10:46:33 -07:00
Andreas Lundblad
baa94f7823 8056252: Incremental build fails on Windows
Changed from '/' to File.separatorChar

Reviewed-by: jfranck
2014-08-29 14:58:35 +02:00
Sonali Goel
f4dc4013f0 8055074: Group 9a: golden files for tests in tools/javac dir
Reviewed-by: jjg
2014-08-29 00:42:42 -07:00
Sonali Goel
e2312f606b 8049126: golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-28 23:42:16 -07:00
Lana Steuck
09bd1b2855 Merge 2014-08-28 14:53:49 -07:00
Joe Darcy
d66c4567ee 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed
Reviewed-by: ksrini
2014-08-28 11:29:34 -07:00
Andreas Lundblad
43eb10bcb8 8054500: Refactor sjavac Main class into ClientMain and ServerMain
Restructured Main into ClientMain and ServerMain

Reviewed-by: jfranck
2014-08-28 17:38:40 +02:00
Kumar Srinivasan
5f800435e3 8050031: [javadoc] class-use pages have duplicates and missing entries
Reviewed-by: jjg
2014-08-27 06:56:29 -07:00
Kumar Srinivasan
6abfd1ee2d 8054925: [javadoc] refactor the Doclet start method
Reviewed-by: jjg
2014-08-26 08:12:42 -07:00
Kumar Srinivasan
d81bd9fdcf 8038732: [javadoc] NetBeans IDE target does not build doclets
Reviewed-by: jjg, jlahoda
2014-08-27 06:25:17 -07:00
Maurizio Cimadamore
be04e8778b 8056075: Add support for dumping inference dependency graphs
Add option '-XDdumpInferenceGraphTo=<folder>' to dump inference internal dependency graphs

Reviewed-by: jjg, jlahoda
2014-08-27 11:41:03 +01:00
Jan Lahoda
c9406c88c4 8056061: Mark implementations of public interfaces with an annotation
Adding @DefinedBy annotation to mark methods that implement public API methods; annotating the methods; adding a coding rules analyzer to enforce all such methods are annotated.

Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Reviewed-by: jjg, mcimadamore, jfranck
2014-08-27 07:44:00 +02:00
Maurizio Cimadamore
afd18d4cd4 8056055: IntelliJ source paths broken after modularization of langtools
Add 'share/classes' prefix to all src roots

Reviewed-by: jfranck
2014-08-26 12:45:28 +01:00
Jonathan Gibbons
08e122f2cb 8044859: javac duplicates option processing when using Compiler API
Reviewed-by: mcimadamore, vromero, jlahoda
2014-08-22 16:28:16 -07:00
Erik Joelsson
e187fdb46d 8055767: Sjavac is leaking servers
Reviewed-by: alundblad, jfranck
2014-08-22 12:25:01 +02:00
David Katleman
e35f9a77f0 Added tag jdk9-b27 for changeset 83c19f00452c 2014-08-21 14:16:28 -07:00
Kumar Srinivasan
9867d883ad 8055501: [javac] ignore test/tools/javac/Paths/AbsolutePathTest.java
Reviewed-by: jjg
2014-08-19 15:34:01 -07:00
Maurizio Cimadamore
d1c2d9e6bd 8055390: IntelliJ langtools project should reflect modular source tree
Adjust langtools.iml to point to the new source trees

Reviewed-by: jfranck
2014-08-19 12:13:43 +01:00
Chris Hegarty
2d81f9c851 Merge 2014-08-18 10:59:44 +01:00
Chris Hegarty
2b80c4715f 8054834: Modular Source Code
Co-authored-by: Alan Bateman <alan.bateman@oracle.com>
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Mark Reinhold <mark.reinhold@oracle.com>
Co-authored-by: Paul Sandoz <paul.sandoz@oracle.com>
Reviewed-by: alanb, chegar, ihse, mduigou
2014-08-17 15:52:32 +01:00
Paul Govereau
7cb1497762 8054556: javac should report the error for default usage as the primary error
Reviewed-by: jjg
2014-08-15 11:02:14 -04:00
Andreas Lundblad
b9781a6764 8055039: Sjavac does not print compilation errors to the console
Sjavac (client) now prints the result of the compilation on stdout/stderr.

Reviewed-by: jfranck
2014-08-14 14:17:17 +02:00
Andreas Lundblad
0683c8dbb0 8054215: Use com.sun.tools.javac.util.Assert instead of 'assert'
Replaced assert keyword with methods from com.sun.tools.javac.util.Assert

Reviewed-by: jfranck
2014-08-14 13:05:49 +02:00
Jonathan Gibbons
1cf35244f6 8055076: fix test failures in classfile tests
Reviewed-by: darcy
2014-08-13 15:47:58 -07:00
Eric McCorkle
52b5861793 Merge 2014-08-13 21:58:29 +00:00
Jonathan Gibbons
33e6564a6b 8050429: Update/cleanup ToolBox
Reviewed-by: vromero
2014-08-13 13:20:31 -07:00
Eric McCorkle
14fcc1d07d 8055054: Remove visitWildcard visitor method from erasure visitor
Remove suspicious visitor method that should not be present

Reviewed-by: mcimadamore
2014-08-13 14:25:46 -04:00
Andreas Lundblad
ce4c456820 8048457: Sjavac should not use portfiles, sockets, etc if background=false
8044131: Restructure client / server protocol code

Changes protocol code to use Object input/output streams. Avoids spawning server if background=false. Refactors idleness checks, pooling and port file monitoring.

Reviewed-by: jjg, jfranck
2014-08-13 14:44:59 +02:00
Sonali Goel
14e6aa6b9e 8049130: Group 8d - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:48:30 -07:00
Sonali Goel
32b768c531 8049129: Group 8c - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:39:56 -07:00
Sonali Goel
40f4caa8d0 8049127: Group 8b - golden files for annotations test in tools/java dir
Reviewed-by: jjg
2014-08-12 17:31:31 -07:00
Sonali Goel
bf789b2a48 8054964: Add a test for invalid package annotations
Reviewed-by: jjg
2014-08-12 16:41:05 -07:00
Andrei Eremeev
8740c99fbd 8042251: Implement classfile tests for InnerClasses attribute
Reviewed-by: jjg, anazarov, shurailine
2014-08-12 13:24:40 +04:00
Lana Steuck
e9745f7d6a Merge 2014-08-11 11:28:08 -07:00
Kumar Srinivasan
714d7c813a 8054044: [javadoc] javadoc tester must print out the javadoc run arguments
Reviewed-by: jjg, sogoel
2014-08-11 10:16:55 -07:00
Lana Steuck
acf7f27a07 Merge 2014-08-11 10:05:15 -07:00
Lana Steuck
4e543f382a Added tag jdk9-b26 for changeset 5cc16d71dc7a 2014-08-10 19:39:06 -07:00
Lana Steuck
e238dea6b3 Added tag jdk9-b26 for changeset 196b7a50a266 2014-08-09 21:27:42 -07:00
Fredrik Öhrström
c110d6437f 8054465: Add --permit-artifact=bar to sjavac
Add --permit-artifact=bar to white-list files that have been written to the destination directory and that sjavac should not delete.

Reviewed-by: jjg, alundblad
2014-08-09 00:56:29 +02:00
Fredrik Öhrström
c8256e4d27 8054474: Add --state-dir=bar to sjavac
Add --state-dir=bar to sjavac to control where sjavac stores the javac_state file.

Reviewed-by: jjg, alundblad
2014-08-08 21:26:23 +02:00
Fredrik Öhrström
ce6154a2fa 8054461: Add @file support to sjavac
Add @file support to sjavac commandline.

Reviewed-by: jjg, alundblad
2014-08-08 20:47:24 +02:00
Lana Steuck
b4338fe75c Merge 2014-08-04 15:33:22 -07:00
Tim Bell
06f3de9ab1 Added tag jdk9-b25 for changeset 85d68faca425 2014-08-01 14:09:22 -07:00
Jan Lahoda
66ea31ef63 8043643: Add an crules analyzer avoiding string concatenation in messages of Assert checks
Generalizing the crules infrastructure, adding a new analyzer to check String concatenation in Assert calls.

Reviewed-by: jjg, vromero
2014-08-01 11:09:40 -07:00
Lana Steuck
d4ac511615 Merge 2014-07-30 11:49:49 -07:00
Alexander Zuev
5284120119 8047072: javap OOM on fuzzed classfile
Reviewed-by: jjg
2014-07-30 20:31:39 +04:00
Maurizio Cimadamore
560c7c91fe 8051958: Cannot assign a value to final variable in lambda
Remove Attr.owner and refactor code for detecting forward field references

Reviewed-by: vromero
2014-07-29 15:31:57 -07:00
Tim Bell
b8d8e19278 Added tag jdk9-b24 for changeset 263f68539584 2014-07-25 15:38:12 -07:00
Andrey Nazarov
0f64892089 8050979: Provide javadoc for "framework" classes in langtools tests
Reviewed-by: jjg
2014-07-24 15:12:48 -07:00
Maurizio Cimadamore
5ef8c4ff63 8048890: Add option to keep track of symbol completion dependencies
Generate dot file with representation of javac on-demand symbol completion dependencies

Reviewed-by: jjg, jlahoda
2014-07-24 13:11:03 +01:00
Andrey Nazarov
0308bdc9d1 8050319: LocalVariableTestBase has unexpected dependency on LocalVariableTableTest
Reviewed-by: jjg, ksrini
2014-07-23 09:19:23 -07:00
Lana Steuck
f1494fb7d9 Merge 2014-07-22 11:54:22 -07:00
Maurizio Cimadamore
f26f50470b 8049234: Add support for running/debugging bootstrap tools in IntelliJ
Add support for bootstrap tools; overhaul ant logger

Reviewed-by: vromero
2014-07-22 17:47:45 +01:00
Joe Darcy
5d208391e8 8051482: Fix deprecation warnings in javax.lang.model.util
Reviewed-by: ksrini
2014-07-21 16:21:43 -07:00
Lana Steuck
49902de279 Merge 2014-07-18 08:25:38 -07:00
Sonali Goel
248c1db2be 8050954: update DocRootSlash test for tidy error: empty <p>
Reviewed-by: ksrini, bpatel
2014-07-17 16:46:29 -07:00
Sonali Goel
a047a4f1ec 8048837: .out files for generics tests in tools/javac dir - part 3
Reviewed-by: jjg
2014-07-17 11:22:47 -07:00
Sonali Goel
5324b04fde 8048836: .out files for generics tests in tools/javac dir
Reviewed-by: jjg
2014-07-17 11:14:39 -07:00
Mandy Chung
acacb0481e 8050804: (jdeps) Recommend supported API to replace use of JDK internal API
Reviewed-by: dfuchs
2014-07-17 10:17:58 -07:00
Sonali Goel
541591d644 8048833: .out files for generics tests in tools/javac dir
Reviewed-by: jjg
2014-07-17 09:56:07 -07:00
David Katleman
e3876789ad Added tag jdk9-b23 for changeset 376a52c9540c 2014-07-17 09:50:45 -07:00
Joe Darcy
dee421ed14 8050430: Provided new utility visitors supporting SourceVersion.RELEASE_9
Reviewed-by: jjg
2014-07-17 09:47:25 -07:00
Vicente Romero
aa91971a3c 8051004: javac, incorrect bug id in tests for JDK-8050386
Reviewed-by: mcimadamore
2014-07-17 10:55:50 -04:00
Vicente Romero
3e002a08e6 8050386: javac, follow-up of fix for JDK-8049305
Reviewed-by: mcimadamore
2014-07-16 10:47:56 -04:00
Jonathan Gibbons
53ec459b89 8050805: Add a target to langtools/make/build.xml to generate docs for test library classes
Reviewed-by: ksrini
2014-07-15 18:17:31 -07:00
Jonathan Gibbons
444268ece3 8050408: A few new Java src files for sjavac are missing copyright notices
Reviewed-by: mduigou
2014-07-14 17:25:53 -07:00
Vicente Romero
6edca1025f 8050283: fix for JDK-8049305 should be removed
Reviewed-by: jjg
2014-07-14 16:59:25 -04:00
Jonathan Gibbons
6ec02aa50b 8046824: class SJavacTestUtil and *Wrapper are redundant and should be removed
Reviewed-by: ksrini
2014-07-14 11:46:31 -07:00
Vicente Romero
1e87b47b2a 8049305: Verification error due to a bad stackmap frame generated by javac
Reviewed-by: mcimadamore
2014-07-14 13:36:30 -04:00
Jan Lahoda
603d592a91 8049948: Restore NonDirectSuper.java test
Reviewed-by: jjg
2014-07-14 12:03:08 +02:00
Jan Lahoda
eb1f1c05ed 8048805: Request to investigate and update lexer error recovery in javac
8046620: Further investigation needed for few error messages for negative unicode tests in langtools regression ws
8048803: javac should report complete character code in the error messages

Improving error reporting and recovery in the lexer

Co-authored-by: Sonali Goel <sonali.goel@oracle.com>
Reviewed-by: jjg, mcimadamore
2014-07-14 12:02:58 +02:00
Kumar Srinivasan
0752cdda93 8039028: [javadoc] refactor the usage of Util.java
Reviewed-by: jjg
2014-06-15 08:41:57 -07:00
Jonathan Gibbons
92884a5338 8050106: JavaCompiler relies on inappropriate result from comparison
Reviewed-by: darcy
2014-07-12 07:32:28 -07:00
Jonathan Gibbons
84e4fca0c8 8048806: Javadoc errors out on some valid HTML tags
Reviewed-by: bpatel
2014-07-11 18:51:32 -07:00
Joe Darcy
0dd95d497b 8050086: jdk.Exported is missing @return
Reviewed-by: jjg
2014-07-11 13:57:32 -07:00
Kumar Srinivasan
c626683b26 8049396: [javadoc] add more class-use test cases
Reviewed-by: jjg
2014-07-11 06:52:04 -07:00
Kumar Srinivasan
4fa698fe42 8049393: [javadoc] parameters are not sorted correctly
Reviewed-by: jjg
2014-06-29 17:13:55 -07:00
Neil Toda
f7234f052c 8030610: replace test/tools/javac/versions/check.sh
Reviewed-by: jjg
2014-07-10 16:03:45 -07:00
Lana Steuck
592a889772 Merge 2014-07-10 14:06:04 -07:00
Neil Toda
b4b2f994ca 8011044: Remove support for 1.5 and earlier source and target options
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: darcy, jjg
2014-07-10 13:57:27 -07:00
Lana Steuck
47c06db65a Merge 2014-07-10 12:39:26 -07:00
David Katleman
de072ba28f Added tag jdk9-b22 for changeset cf09dddb6caf 2014-07-10 12:13:35 -07:00
Lana Steuck
3126c7f1d1 Merge 2014-07-09 10:42:13 -07:00
Vicente Romero
5916a0adfa 8033483: Should ignore nested lambda bodies during overload resolution
Reviewed-by: mcimadamore, dlsmith
2014-07-09 10:49:32 -04:00
Jan Lahoda
0067b70725 8031569: Refactor javac scope implementation to enable lazy imports
Introducing an internal API for Scope; rewriting ImportScopes to extend CompoundScopes.

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, jjg, jfranck
2014-07-09 16:32:05 +02:00
Mandy Chung
c2f98fba15 8029548: (jdeps) use @jdk.Exported to determine supported vs JDK internal API
8031092: jdeps does not recognize --help option
8048063: (jdeps) Add filtering capability

Reviewed-by: alanb, dfuchs
2014-07-08 18:26:34 -07:00
Maurizio Cimadamore
15cfa4aac9 8043926: javac, code valid in 7 is not compiling for 8
Type-containment doesn't handle inference variables correctly

Reviewed-by: vromero, dlsmith
2014-07-08 15:42:04 +01:00
Jan Lahoda
3c5b32658b 8042239: javac: TreeMaker.Type(Type t) does not handle UnionClassType
Enhancing TreeMaker.Type(Type t) with support for UnionClassType and IntersectionClassType.

Co-authored-by: Robert Field <robert.field@oracle.com>
Reviewed-by: vromero, rfield
2014-07-08 15:13:16 +02:00
Sonali Goel
5437ec7e74 8044080: .out files for unicode, implicitThis and importChecks tests in tools/javac dir
Reviewed-by: jjg
2014-07-07 13:39:31 -07:00
Sonali Goel
9c09973b5a 8049491: Remove three auxilary files in tools/javac/enum dir
Reviewed-by: jjg
2014-07-07 12:55:00 -07:00
Sonali Goel
3ecb57ccc0 8046618: .out files for enum tests in tools/javac/dir
Reviewed-by: jjg
2014-07-07 12:44:20 -07:00
Sonali Goel
0718a280b0 8046635: .out files for enum tests in tools/javac/dir
Reviewed-by: jjg
2014-07-07 12:36:45 -07:00
Vicente Romero
72d5723212 8049075: javac, wildcards and generic vararg method invocation not accepted
Reviewed-by: mcimadamore
2014-07-04 16:34:44 +01:00
Jonathan Gibbons
12b653bb02 8042261: Implement classfile tests for Deprecated attribute
Reviewed-by: jjg, anazarov, shurailine
2014-07-04 10:52:22 +01:00
Sonali Goel
50e8d8b28d 8049284: Missing bug id in test/tools/javac/varargs/warning/Warn*
Reviewed-by: darcy
2014-07-03 15:48:23 -07:00
David Katleman
e15373ff09 Added tag jdk9-b21 for changeset 021089de7317 2014-07-03 11:37:54 -07:00
Sonali Goel
2caa264885 8046770: .out files for assert, boxing, and overload tests in tools/javac dir
Reviewed-by: jjg
2014-07-02 14:27:10 -07:00
Sonali Goel
9343037434 8044864: .out files for enum tests in tools/javac dir - part 1
Reviewed-by: jjg
2014-07-02 13:29:58 -07:00
Sonali Goel
8244fe0c5c 8044236: create .out files for DefiniteAssignment tests in tools/javac dir
Reviewed-by: jjg, vromero
2014-07-02 12:04:04 -07:00
Lana Steuck
afd134e028 Merge 2014-07-01 14:28:22 -07:00
Brian Goetz
76c473d81f 8032188: Remove dead code in TransTypes
Reviewed-by: darcy
2014-07-01 15:54:25 -04:00
Phil Race
ccffd661f8 Merge 2014-07-01 10:21:41 -07:00
Maurizio Cimadamore
9baf436fd6 8048905: More tweaking with langtools intellij support
Add support for 'jtreg.home' property; fix code width to be 80; disable import optimizations

Reviewed-by: vromero
2014-07-01 17:23:46 +01:00
Jan Lahoda
670eff1ee6 6707032: Division by zero warning not suppressed properly in some cases
Delay reporting of the division by zero warning until annotations are resolved, so that @SuppressWarnings works correctly.

Reviewed-by: vromero
2014-06-30 17:08:06 +02:00
Kumar Srinivasan
729fe3ec72 8047162: [javadoc] index files are non deterministic
Reviewed-by: jjg
2014-06-27 17:54:54 -07:00
David Katleman
3bfe90c1b1 Added tag jdk9-b20 for changeset d77065991eb8 2014-06-26 12:51:49 -07:00
David Dehaven
1207c0efa1 Merge 2014-06-23 13:06:08 -07:00
Mandy Chung
399ef93b31 8044063: Remove com.sun.java.browser.* from jdk repo
Reviewed-by: darcy, alanb
2014-06-20 13:36:10 -07:00
Sonali Goel
ae6f87cc24 8047300: update tools/javadoc/6227454 test for missing <DOCTYPE> tags
Reviewed-by: jjg, ksrini
2014-06-20 13:26:24 -07:00
Vicente Romero
1ff4245739 8044546: Crash on faulty reduce/lambda
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, dlsmith
2014-06-20 20:36:54 +01:00
Robert Field
5fad815dec 8046060: Different results of floating point multiplication for lambda code block
Propogate strictfp into lambda body

Reviewed-by: vromero, jlahoda
2014-06-20 10:56:47 -07:00
Dan Smith
fe46aeabb0 8047407: Add test for JDK-8037385
Reviewed-by: mcimadamore
2014-06-20 11:42:16 -06:00
Lana Steuck
0d37c9cee1 Merge 2014-06-20 10:15:13 -07:00
Dan Smith
06b8a7ac80 8034147: javac crashes with a NullPointerException during bounds checking
Types.supertype should return Type.noType rather than null

Reviewed-by: vromero, mcimadamore
2014-06-20 10:56:31 -06:00
Vicente Romero
d7c001dd04 8042759: Lambda returning implicitly-typed lambdas considered pertinent to applicability
Reviewed-by: mcimadamore
2014-06-19 23:52:33 +01:00
Jan Lahoda
9d852a54ef 8041648: do while loop that misses ending semicolon has wrong end position
Ensure the end positions are meaningful even if statement's semicolon is missing.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-06-19 22:06:29 +02:00
David Katleman
c8e4d3e53a Added tag jdk9-b19 for changeset 26e23230009a 2014-06-19 11:22:49 -07:00
Vicente Romero
5b199f3cb8 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore
2014-06-19 15:39:37 +01:00
Sonali Goel
17f9ae5713 8046071: update three javadoc tests for empty <p> tag
Reviewed-by: jjg, ksrini
2014-06-18 14:58:16 -07:00
Lana Steuck
dfedac648b Merge 2014-06-18 10:54:24 -07:00
Lana Steuck
b2a5eb6f28 Merge 2014-06-18 10:09:04 -07:00
Maurizio Cimadamore
f8e80ec392 8043253: Slow javac compile times in JDK 8
Enable on-demand diagnostic source position completion

Reviewed-by: jjg, vromero
2014-06-18 13:51:50 +01:00
Jan Lahoda
e6b9e34ebe 8046916: Type parameter annotations don't work with multiple type parameters
When reading type variable's annotations out of the owner's type annotations, use the type variable's index in owner to exclude annotations belonging to other type variables.

Reviewed-by: jfranck, emc
2014-06-18 10:44:16 +02:00
Vicente Romero
e4773094de 8036953: Fix timing of varargs access check, per JDK-8016205
Reviewed-by: mcimadamore, dlsmith
2014-06-17 17:33:01 +01:00
Paul Govereau
f2e2245e7b 8038975: Access control in enhanced for
Reviewed-by: vromero, jlahoda
2014-06-17 11:11:59 -04:00
Andreas Lundblad
8baafcf7ef 8048594: The sjavac client/server protocol should be hidden behind an interface
Reviewed-by: jfranck
2014-06-17 14:01:27 +02:00
Vicente Romero
ce0935812b 8047719: Incorrect LVT in switch statement
Reviewed-by: jjg, jlahoda
2014-06-27 20:32:12 +01:00
Sonali Goel
2f5e083cee 8048293: update tools/javadoc/6227454 to have missing <head> tag
Reviewed-by: jjg, bpatel
2014-06-26 16:39:14 -07:00
Sonali Goel
3e316a3372 8047316: update javadoc tests to fix tidy warning for incorrect html comment
Reviewed-by: jjg, ksrini
2014-06-26 16:07:07 -07:00
Sonali Goel
bbc0df83f4 8048168: update 2 javadoc tests to add summary attribute for table tag
Reviewed-by: jjg, ksrini
2014-06-26 15:47:52 -07:00
Sonali Goel
8828870971 8047744: update 2 javadoc tests for nested emphasis <code>
Reviewed-by: jjg, ksrini
2014-06-26 15:41:05 -07:00
Sonali Goel
41005acef2 8047743: update com/sun/javadoc/testHref for unrecognized <action>
Reviewed-by: jjg, ksrini
2014-06-26 15:30:21 -07:00
Sonali Goel
7470fabe6f 8047303: update com/sun/javadoc/DocRootSlash/DocRootSlash for unexpected </a>
Reviewed-by: jjg, ksrini
2014-06-26 15:21:44 -07:00
Jonathan Gibbons
47c543e53b 8007307: DPrinter: support the DocTree API
Reviewed-by: mcimadamore
2014-06-26 11:45:51 -07:00
Jonathan Gibbons
bd97e7d5ec 8047183: JDK build fails with sjavac enabled
Reviewed-by: mcimadamore
2014-06-26 11:31:59 -07:00
Paul Govereau
5b1596bc25 8042345: getDocComment fails for doc comments on PackageElement found in package-info.java
Reviewed-by: jjg
2014-06-26 13:48:58 -04:00
Jonathan Gibbons
101aaaa468 8048162: Restrict catch type from Throwable to ReflectiveOperationException
Reviewed-by: darcy
2014-06-25 19:15:53 -07:00
Jonathan Gibbons
a86ace6297 8046614: Fill in missing doc comments
Reviewed-by: darcy
2014-06-25 19:04:52 -07:00
Jonathan Gibbons
25618fc470 8046613: Fill in missing doc comments
Reviewed-by: darcy
2014-06-25 17:58:37 -07:00
Robert Field
30f70a0e1d 8048121: javac complex method references: revamp and simplify
8038776: VerifyError when running successfully compiled java class

Add tests missing from the push of 8037404

Reviewed-by: dlsmith, vromero
2014-06-25 11:22:27 -07:00
Kumar Srinivasan
7aa3c59051 8047157: [javadoc] fixup tests for determinism and add classes uses
Reviewed-by: jjg
2014-06-24 15:15:22 -07:00
Joe Darcy
b963c0bc59 7196160: Project Coin: allow @SafeVarargs on private methods
Reviewed-by: jjg
2014-06-24 10:51:00 -07:00
Maurizio Cimadamore
29297396ab 8046451: Add basic IntelliJ support for langtools
Add new ant target 'idea' to create IntelliJ langtools project

Reviewed-by: jjg
2014-06-24 16:04:46 +01:00
Robert Field
802429b65f 8037404: javac NPE or VerifyError for code with constructor reference of inner class
8047341: lambda reference to inner class in base class causes LambdaConversionException
8044748: JVM cannot access constructor though ::new reference although can call it directly
8044737: Lambda: NPE while obtaining method reference through lambda expression

Revamp and simplify handling of complex method references

Reviewed-by: dlsmith, vromero
2014-06-24 00:43:46 -07:00
Jonathan Gibbons
2613fffb87 8046369: sjavac should not use javac internal API for starting javac
Reviewed-by: jfranck, alundblad, ohrstrom
2014-06-16 11:30:31 -07:00
David Katleman
26e17df2bf Added tag jdk9-b18 for changeset d38c730b86c1 2014-06-13 11:21:39 -07:00
Lana Steuck
e380f5fa69 Merge 2014-06-12 15:37:29 -07:00
David Katleman
d382f3a577 Added tag jdk9-b17 for changeset abd9a49d0b9c 2014-06-12 10:32:42 -07:00
Eric McCorkle
29e8b83b48 8043484: DPrinter does not compile
Make DPrinter compile

Reviewed-by: jjg
2014-06-12 11:32:23 -04:00
Andreas Lundblad
77fa3101ec 8042830: A recently added Xprefer test fails on Windows
Test now accepts both / and \ as file separator.

Reviewed-by: mcimadamore
2014-06-12 14:29:09 +02:00
Paul Govereau
577b60e711 8027886: javac allows illegal receiver parameters
8029042: Receiver parameter not supported on local class constructor

Reviewed-by: jfranck, jlahoda
2014-06-11 12:49:10 -04:00
Dan Smith
3ea78c679c 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
Capture intersection supertypes before comparing their members

Reviewed-by: vromero
2014-06-10 15:25:01 -06:00
Dan Smith
6e1ae5955e 8037385: constant pool errors with -target 1.7 and static default methods
Add error check for static interface methods invoked from -source 7

Reviewed-by: vromero, mcimadamore
2014-06-10 12:41:39 -06:00
Eric McCorkle
07f1246919 8046296: java/util/concurrent/BlockingQueue/PollMemoryLeak.java fails in nightly on all platform due to compiler issue
Alter logic to choose type of type annotation position for a variable declaration

Reviewed-by: jjg
2014-06-09 15:46:44 -04:00
Maurizio Cimadamore
dab523a752 8043725: javac fails with StackOverflowException
Loose type comparison test should be protected against infinite recursion with fbounds

Reviewed-by: vromero
2014-06-09 12:54:02 +01:00
Jan Lahoda
d71f75ae86 8033414: javac Plugin to receive notification (before and) after the compilation
Introducing TaskEvent.Kind.COMPILATION, sending this event before and after compilation.

Co-authored-by: Joel Borggren-Franck <joel.franck@oracle.com>
Reviewed-by: jjg, jfranck
2014-06-09 10:17:16 +02:00
Jonathan Gibbons
15853aca13 7026941: 199: path options ignored when reusing filemanager across tasks
Reviewed-by: jlahoda, jfranck
2014-06-08 15:02:34 -07:00
Andrei Eremeev
8aa391d4c9 8042451: Write tests for all possible kinds of type annotation
Add new tests for type annotations to improve case coverage

Reviewed-by: jjg, emc, abuckley
2014-06-06 16:08:46 -04:00
Eric McCorkle
8ff3cbd414 8027262: Determine location for type annotations earlier in compiler pipeline
8027261: Single codepath for attaching annotations to symbols
8027258: Permit a single source annotation to generate multiple bytecode annotations
8027182: Incorrect annotation attributes for type annotations on constructor type parameters
8044010: TypeAnnotation attribute is not generated for repeatable annotation in type argument
8044009: TypeAnnotation attribute is not generated for repeatable annotation in nested types
8043974: TypeAnnotation attribute is not generated for repeatable annotation in lambda
8043669: Few of the ANNOT tests in JCK9 test suite fail with an AssertionError for exception_index
8042060: Type parameter annotations don't work with multiple type parameters
8037348: RuntimeInvisibleAnnotations should not be generated for type annotation on anonymous innerclass creation

Initial rearchitecting of type annotations frontend pipeline

Reviewed-by: jjg, jfranck, mcimadamore, jlahoda, wmdietl
2014-06-06 16:00:59 -04:00
Lana Steuck
f533c23f2a Merge 2014-06-05 19:38:17 -07:00
Jonathan Gibbons
a9bd96c90c 8046067: test/tools/javac/api/6410643/T6410643.java is broken
Reviewed-by: darcy, ksrini
2014-06-05 13:22:37 -07:00
Sonali Goel
887f81a738 8044072: Group 2: create .out files for OverrideChecks tests in tools/javac dir
Reviewed-by: jjg
2014-06-05 10:57:10 -07:00
Sonali Goel
d15c9840ed 8044064: Group 1: create .out files for cast and capture negative tests in tools/javac dir
Reviewed-by: jjg
2014-06-05 10:44:38 -07:00
Maurizio Cimadamore
cd68d10b6f 8043893: Inference doesn't report error on incompatible upper bounds
Failure on type-equality check during incorporation doesn't trigger inference error

Reviewed-by: vromero
2014-06-05 12:21:38 +01:00
David Katleman
0a28ae7c64 Added tag jdk9-b16 for changeset f75464f610f6 2014-06-04 20:20:42 -07:00
Vicente Romero
09250abb84 8041713: Type inference of non-existent method references crashes the compiler
Reviewed-by: mcimadamore
2014-06-04 20:01:13 +01:00
Vicente Romero
45c3929ecb 8044487: Fix for 8042785 causes regression tests to fail with java.lang.VerifyError
Reviewed-by: jjg, ksrini
2014-06-02 22:36:40 +01:00
Vicente Romero
8447e4cf46 8042785: javac, bridge methods are not getting the flags from the original method
Reviewed-by: jjg, jlahoda
2014-05-30 18:21:05 +01:00
Lana Steuck
a7ab489c5a Merge 2014-05-30 09:25:52 -07:00
Jan Lahoda
2f910049e8 8031967: For some sources compiler compiles for ever
Avoid creating DeferredTypes for method calls with method calls as receivers if the site can be determined reliably

Co-authored-by: Maurizio Cimadamore <maurizio.cimadamore@oracle.com>
Reviewed-by: mcimadamore, vromero
2014-05-30 12:54:16 +02:00
David Katleman
1834c52c4d Added tag jdk9-b15 for changeset dbec02c24c7a 2014-05-29 22:32:18 -07:00
Vicente Romero
92e2e96714 8037937: javac: AssertionError during LVT generation, wrong variable ranges
Reviewed-by: mcimadamore
2014-05-29 15:28:01 +01:00
Stephane Epardaud
e0f4450825 8037934: Javac generates invalid signatures for local types
Reviewed-by: vromero, rfield
2014-05-28 21:47:30 +01:00
Dan Smith
2b4c40d39b 8044050: Move misplaced inference tests to test/tools/javac/generics/inference
Reviewed-by: vromero
2014-05-27 16:39:05 -06:00
Dan Smith
849ed753e2 8042338: Refactor Types.upperBound to treat wildcards and variables separately
Reviewed-by: vromero
2014-05-27 16:32:56 -06:00
Paul Govereau
773e460c33 7177211: SharedNameTable.create and .dispose are not used
Reviewed-by: jjg
2014-05-27 14:23:55 -04:00
Paul Govereau
0b1c40b161 8042741: Java 8 compiler throws NullPointerException depending location in source file
Reviewed-by: vromero, jlahoda
2014-05-27 22:26:53 +01:00
Paul Govereau
649331e00f 8041704: wrong error message when mixing lambda expression and inner class
Reviewed-by: vromero
2014-05-27 18:57:44 +01:00
Sonali Goel
378c3fe62f 8043336: Missing bug id in test/tools/javac/lambda/TargetType23.java
Reviewed-by: jjg, vromero, dlsmith
2014-05-22 15:42:10 -07:00
Lana Steuck
293d514c13 Merge 2014-05-22 14:39:05 -07:00
David Katleman
5d455cb482 Added tag jdk9-b14 for changeset 076ae2d12410 2014-05-22 12:54:10 -07:00
Kumar Srinivasan
b18841ffa0 8042829: [javadoc] index-file output is not sorted correctly
8043062: JDK 9 platform and compiler upgrade failed on Solaris-sparcv9 with Javadoc.gmk:360: recipe for target docs/api/index.html

Reviewed-by: erikj, jjg
2014-05-22 12:16:53 -07:00
Neil Toda
ac4c2fe57a 8042406: javac.jvm.ClassReader.readClassFile() is using Target to verify valid major versions
Reviewed-by: jjg
2014-05-20 15:50:17 -07:00
Paul Govereau
c212c43f70 8015927: Class reference duplicates in constant pool
Reviewed-by: jjg
2014-05-16 17:08:42 -04:00
Jonathan Gibbons
31e6340f54 8041422: Split javac ClassReader into ClassReader+ClassFinder
Reviewed-by: jfranck
2014-05-18 19:59:10 -07:00
Jan Lahoda
911a9fcf97 8043186: javac test langtools/tools/javac/util/StringUtilsTest.java fails
The result of String.toLowerCase.indexOf does not always point at the start of the given string in the non-lowercased text.

Reviewed-by: jjg, bpatel
2014-05-16 10:52:07 +02:00
Lana Steuck
f1eb2bc57f Merge 2014-05-15 10:40:27 -07:00
David Katleman
0fa48738ed Added tag jdk9-b13 for changeset 069586f14799 2014-05-15 10:26:01 -07:00
Dan Smith
5efa462340 8042882: Support verbosity options in langtools testing
8032441: langtools/test/Makefile breaks when JT_JAVA set to a JDK 9 build

Reviewed-by: mduigou
2014-05-13 15:34:13 -06:00
Dan Smith
9798cbad4c 8034223: Most-specific should not have any special treatment for boxed vs. unboxed types
Rewrite most-specific logic to conform to JLS 8 15.12.2.5

Reviewed-by: vromero
2014-05-13 15:29:09 -06:00
Andrey Nazarov
23759a15dd 8042771: Missing bug id in test/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java
Reviewed-by: jjg
2014-05-12 17:09:26 +01:00
Eric McCorkle
10fb266571 8035763: Error parsing binary type annotations data in javac
Fix accidental reversal of read order from a previous change

Reviewed-by: jjg
2014-05-09 22:27:07 -04:00
Jonathan Gibbons
3b2a17f08f 8042886: Test langtools/test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java fails on Windows
Reviewed-by: darcy
2014-05-09 18:50:12 -07:00
Vicente Romero
9cf78d324c 8028503: javac, for method references a primitive type can be added as a bound
Reviewed-by: jjg, dlsmith
2014-05-10 01:24:35 +01:00
Vicente Romero
c374047d36 8037379: fix for JDK-8029569 doesn't cover all possible cases
Reviewed-by: jjg
2014-05-10 00:46:47 +01:00
Jonathan Gibbons
caa2209663 8038730: Clean up the way JavadocTester is invoked, and checks for errors
Reviewed-by: ksrini, sogoel, bpatel
2014-05-09 15:37:12 -07:00
Jan Lahoda
756eae6492 8042867: Missing license header for langtools/make/netbeans/langtools/nbproject/project.properties
Reviewed-by: ksrini
2014-05-09 23:31:05 +02:00
Dan Smith
f799e8d6fc 8042656: Inference produces spurious error for intersection type bounds check
Fix subtyping for intersections involving capture variables

Reviewed-by: vromero
2014-05-09 14:56:59 -06:00
Eric McCorkle
1ad5b0eee1 8040327: Eliminate AnnotatedType
Replace AnnotatedType with type annotations being stored in the Type class as metadata

Reviewed-by: jjg, jfranck, wmdietl, jlahoda
2014-05-09 09:28:47 -04:00
Jonathan Gibbons
47876fcddb 8042839: XPreferTest fails on Windows
Reviewed-by: vromero
2014-05-09 08:52:57 -07:00
Lana Steuck
c3dc5c472c Merge 2014-05-08 15:28:38 -07:00
Kumar Srinivasan
1f1c8d7506 8042601: Javadoc sort fails
Reviewed-by: jjg
2014-05-08 08:23:44 -07:00
Jan Lahoda
5b6afc8503 8041663: Sensitive dependence on location of nested interface
Adding a method among ambiguous candidates only if it is more specific than some of the existing candidates.

Reviewed-by: dlsmith, vromero
2014-05-09 12:55:58 +02:00
Jan Lahoda
23ba7e22d2 8040822: Duplicated notifications can be sent to TaskListener
The analyze finished event must only be sent on the first call to JavaCompiler.flow for a given class.

Reviewed-by: jjg
2014-05-09 09:36:35 +02:00
David Katleman
62e455cc8e Added tag jdk9-b12 for changeset 61f3b005022e 2014-05-08 01:05:31 -07:00
Andreas Lundblad
b2d433dcfc 8028196: Javac allows timestamps inside rt.jar to affect compilation when using -sourcepath
Added -XXuserPathsFirst to allow user classes to take precedence over boot classes

Reviewed-by: jjg
2014-05-07 17:29:42 +02:00
Kumar Srinivasan
15ebe0dcbf 8042654: [javadoc] revert the default methods list.sort to Collections.sort
Reviewed-by: jfranck, jjg
2014-05-07 15:54:16 -07:00
Fredrik Öhrström
ad489d2ce3 8042441: sjavac does not track dependencies
Add support for tracking fully qualified references.

Reviewed-by: jjg
2014-05-08 00:22:31 +02:00
Fredrik Öhrström
cb6df44f8e 8042699: sjavac does not track dependencies
Using / in some places and . in other places break package comparisons. The fix standardizes on dots.

Reviewed-by: jjg
2014-05-07 23:55:41 +02:00
Andrey Nazarov
2c6668c63d 8040129: Implement classfile tests for SourceFile attribute
Reviewed-by: shurailine, jjg
2014-05-07 14:22:14 -07:00
Dan Smith
282ee77f73 8033718: Inference ignores capture variable as upper bound
Split Types.lowerBound into two methods; fix bugs in inference handling of capture variables.

Reviewed-by: vromero
2014-05-06 15:46:09 -06:00
Jonathan Gibbons
7e2e9759d5 8042358: some tests have placeholder bugid 1234567
Reviewed-by: mduigou
2014-05-02 16:41:10 -07:00
Paul Govereau
6ec0c32eff 8033437: javac, inconsistent generic types behaviour when compiling together vs. separate
Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: jjg
2014-05-02 22:35:23 +01:00
Lana Steuck
5e30be8573 Merge 2014-05-01 14:21:15 -07:00
David Katleman
f45fe402ee Added tag jdk9-b11 for changeset ae887a48401a 2014-05-01 12:52:13 -07:00
Vicente Romero
71a85db2be 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
Reviewed-by: dlsmith, jjg
2014-05-01 20:36:11 +01:00
Robert Field
89be14bfe5 8029852: Bad code generated (VerifyError) when lambda instantiates enclosing local class and has captured variables
8029725: Lambda reference to containing local class causes javac infinite recursion

Reviewed-by: vromero, jlahoda, dlsmith
2014-04-30 23:02:14 -07:00
Robert Field
e8adfd1234 8036942: javac generates incorrect exception table for multi-catch statements inside a lambda
Union type info lost and also union type is not processed by TreeMaker.Type -- address by using existing tree, thus by-passing such issues.

Reviewed-by: vromero, jlahoda
2014-04-30 18:19:23 -07:00
Andrey Nazarov
230b553e37 8040097: Implement classfile tests for LocalVariableTable and LocalVariableTypeTable attribute
Reviewed-by: jjg, shurailine, emc
2014-04-30 13:48:37 -07:00
Lana Steuck
3ddefc8337 Merge 2014-04-24 16:04:44 -07:00
David Katleman
6494ff9ca2 Added tag jdk9-b10 for changeset 16ec7c58cdea 2014-04-24 12:21:18 -07:00
Jan Lahoda
3fb6775539 8041695: Update the NetBeans build script and metadata
Various improvements to the NetBeans project for langtools, adding formatting/import setting for langtools.

Reviewed-by: ksrini
2014-04-24 13:32:21 +02:00
Jan Lahoda
6b335c8d1a 8039250: Test tools/javac/classfiles/InnerClasses/SyntheticClasses.java fails
The test should only analyze classfiles.

Reviewed-by: vromero
2014-04-23 11:28:09 +02:00
Jonathan Gibbons
3acf463dc4 8040903: Clean up use of BUG_ID in javadoc tests
Reviewed-by: ksrini
2014-04-22 17:57:40 -07:00
Jonathan Gibbons
187dbd343c 8041253: Avoid redundant synonyms of NO_TEST
Reviewed-by: ksrini
2014-04-22 17:41:11 -07:00
Paul Govereau
0a5665b53a 8041521: JDK-8034245 breaks a bootcycle build
Reviewed-by: jjg
2014-04-22 15:59:33 -07:00
Paul Govereau
9783b65028 8034245: Refactor TopLevel tree node
Added JCPackageDecl to JCTree to store package-level information.

Reviewed-by: jjg, jlahoda
2014-04-22 17:07:54 -04:00
Paul Govereau
b349726850 8038023: Compiler crash ClassCastException
Add additional checks on results of ClassReader.readPool

Reviewed-by: vromero
2014-04-22 19:52:15 +01:00
Andreas Lundblad
06f651942c 8035063: Option handling in sjavac needs to be rewritten
Option handling code rewritten. Exclusion / inclusion patterns changed from package to directories.

Reviewed-by: jjg, jfranck
2014-04-22 16:51:10 +02:00
Paul Govereau
f77173467d 8030046: javac incorrectly handles absolute paths in manifest classpath
Reviewed-by: jjg, vromero
2014-04-21 17:57:47 -04:00
Vicente Romero
a50db59b59 8029718: Should always use lambda body structure to disambiguate overload resolution
Reviewed-by: dlsmith, jjg, jlahoda
2014-04-21 22:51:49 +01:00
Jonathan Gibbons
04e1109b69 8041150: Avoid silly use of static methods in JavadocTester
Reviewed-by: ksrini
2014-04-18 17:25:43 -07:00
Jonathan Gibbons
a2d155dfa9 8040908: javadoc test TestDocEncoding should use -notimestamp
Reviewed-by: ksrini
2014-04-18 17:23:36 -07:00
Vicente Romero
a310cda727 8029002: javac should take multiple upper bounds into account in incorporation
Reviewed-by: dlsmith, jjg
2014-04-18 17:50:30 +01:00
Kumar Srinivasan
4c16861cc4 8038583: [javadoc] Refactor uses of arrays to Collections
Reviewed-by: jjg
2014-04-18 08:44:53 -07:00
Kumar Srinivasan
296a39b117 8039410: [javadoc] fix class-use items to be deterministic and index ordering
Reviewed-by: jjg
2014-04-18 08:35:59 -07:00
Vicente Romero
0996901f29 8029102: Enhance compiler warnings for Lambda
Reviewed-by: briangoetz, jjg, jlahoda, ahgross
2014-04-28 14:48:51 +01:00
Paul Govereau
218ce31908 8039026: Definitely unassigned field can be accessed
Reviewed-by: vromero, jlahoda
2014-04-25 22:00:58 +01:00
Jonathan Gibbons
6c24c7e153 8040904: Ensure javadoc tests do not overwrite results within tests
Reviewed-by: ksrini
2014-04-25 13:08:41 -07:00
Jan Lahoda
e505238d2a 8038788: javac behaves incorrectly for annotations after method type parameters in some cases
Reviewed-by: jjg, emc
2014-04-18 11:53:34 +02:00
Lana Steuck
f33dec2ebb Merge 2014-04-17 15:23:23 -07:00
David Katleman
688864a6ea Added tag jdk9-b09 for changeset 16bad6bc066b 2014-04-17 10:14:07 -07:00
Eric McCorkle
bd42246eaa 8040319: Clean up type annotation exception index generating code in Code.java
Remove bad code from exception index generation for type annotations and make type_index final

Reviewed-by: jjg, vromero
2014-04-17 12:17:02 -04:00
Kumar Srinivasan
9b4ae823ef 8038976: javadoc requires a trailing / for links where java 7's javadoc didn't
Reviewed-by: jjg
2014-04-16 19:21:59 -07:00
Kumar Srinivasan
7a7a57bb88 8037484: [javadoc] fails with java.lang.IllegalStateException: endPosTable already set
Reviewed-by: jjg
2014-04-16 18:15:48 -07:00
Kumar Srinivasan
7a4a5803fc 8039251: Test tools/javadoc/6964914/TestStdDoclet.java fails
Reviewed-by: jjg
2014-04-16 18:36:43 -07:00
Neil Toda
81730320bd 8031649: Clean up javadoc tests
Reviewed-by: jjg
2014-04-16 16:17:09 -07:00
Robert Field
360461f136 8038420: Lambda returning post-increment generates wrong code
Reviewed-by: vromero, jlahoda
2014-04-15 15:55:24 -07:00
Robert Field
300fbf0889 8037935: Javac -- final local String var referenced in binary/unary op in lambda produces code that does not verify
Remove over-zealous Attr optimization breaking lambdas

Reviewed-by: jjg, vromero
2014-04-15 15:52:52 -07:00
David Katleman
919fd1dbac Added tag jdk9-b08 for changeset 06ab27895804 2014-04-15 12:14:29 -07:00
Eric McCorkle
b343919526 8038263: Refactor annotation handling after actualEnterAnnotations
Move all repeating annotations code into Annotate, rework annotations pipeline into a more completer-like design, eliminate a cast from enterAnnotations/enterTypeAnnotations

Reviewed-by: jjg, jfranck
2014-04-03 20:28:23 -04:00
Lana Steuck
16c2ee6450 Merge 2014-04-09 17:18:22 -07:00
Paul Govereau
c654c5a23e 8015499: javac, Gen is generating extra checkcast instructions in some corner cases
Reviewed-by: vromero, jjg
2014-04-09 17:41:27 +01:00
Lana Steuck
4b1de2f99c Merge 2014-04-09 09:20:35 -07:00
Jan Lahoda
5905e8f494 8039466: Tests failing in langtools repository
Fixing tests broken by JDK-8038455.

Reviewed-by: jjg
2014-04-08 23:33:50 +02:00
Jan Lahoda
e5c8101894 8038455: Use single Context for all rounds of annotation processing
One set of javac services, as well as created ClassSymbols, is reused for all rounds of processing now.

Reviewed-by: jjg, jfranck, darcy, vromero
2014-04-08 14:06:11 +02:00
Paul Govereau
8e6660eb56 8023945: javac wrongly allows a subclass of an anonymous class
Reviewed-by: jjg
2014-04-04 19:13:53 -04:00
Kumar Srinivasan
73d4a30ede 8039231: [javadoc] test failure caused by javax.crypto fix
Reviewed-by: jjg
2014-04-04 18:36:16 -07:00
Kumar Srinivasan
def40f4158 8037881: javax.crypto is not listed in the compact* profiles javadoc
Reviewed-by: jjg
2014-04-03 12:04:58 -07:00
David Katleman
cf7bfef898 Added tag jdk9-b07 for changeset a70a71ac79f3 2014-04-02 22:00:13 -07:00
Bhavesh Patel
d642f92759 8032066: Serialized form has broken links to non private inner classes of package private
Reviewed-by: jjg
2014-04-01 23:58:04 -07:00
Paul Govereau
e231918e58 8034933: Update documentation for Types.directSupertypes to clarify behavior
Reviewed-by: darcy
2014-04-01 23:52:10 -07:00
Ivan Gerasimov
befb7157c9 8034044: Class.getModifiers() returns "static" for anonymous classes
Javac sets ACC_STATIC bit for anonymous classes which contradicts the JLS

Reviewed-by: jfranck
2014-04-02 10:05:16 +04:00
Lana Steuck
b683f35613 Merge 2014-04-01 17:25:39 -07:00
Alexander Zuev
d9d9742c75 8031425: Two langtools/javac tests fail by timeout on Windows
Reviewed-by: jjg, vromero
2014-04-01 10:00:43 -07:00
Jan Lahoda
e339370175 8035890: jdk8 javac -source 7 compiles test case it should not
Ensuring source level checks are performed in two additional cases related to type annotations, adding specialized error message for annotations after method type parameters.

Reviewed-by: jfranck, jjg
2014-03-31 21:27:25 +02:00
Bhavesh Patel
e08ccd0e48 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present
Reviewed-by: ksrini
2014-03-29 11:06:33 -07:00
Eric McCorkle
fb9c998b1d 8035768: Move TypeAnnotationPosition from Attribute.Compound to Attribute.TypeCompound
Move position field into Compound, making Compound into a kind of "proto-annotation", representing the situation before we know what an Annotation's kink is

Reviewed-by: jjg
2014-03-27 18:41:28 -04:00
David Katleman
4ba8c0364b Added tag jdk9-b06 for changeset 3d574309a737 2014-03-27 11:38:37 -07:00
Jonathan Gibbons
77ad0945a6 8035104: reorder class file attributes in javap listing
Reviewed-by: ksrini
2014-03-26 17:50:33 -07:00
Alexander Zuev
3eb793cd06 8035956: javac, incomplete error message
Reviewed-by: vromero
2014-03-26 10:47:30 -07:00
Joel Borggrén-Franck
24400e1745 8038080: annotation processors don't visit declaration parameter annotations
Co-authored-by: Liam Miller-Cushon <cushon@google.com>
Reviewed-by: darcy
2014-03-26 12:18:11 +01:00
Bhavesh Patel
da71a6dd96 8031625: javadoc problems referencing inner class constructors
Reviewed-by: jjg
2014-03-25 22:07:55 -07:00
Lana Steuck
3eb52d3931 Merge 2014-03-25 14:50:31 -07:00
Lana Steuck
0eb4fd78fa Merge 2014-03-25 12:32:12 -07:00
David Katleman
d705db594a Added tag jdk9-b05 for changeset a127d7bb1c30 2014-03-20 13:44:52 -07:00
Alexander Zuev
908ea8bebd 7118295: javac does not explicitly close -Xstdout file
Reviewed-by: ksrini, jjg
2014-03-20 15:13:26 +04:00
Paul Govereau
019025c61f 8025505: Constant folding deficiency
Provide constant folding of equality tests involving constant and null.

Reviewed-by: jjg
2014-03-19 17:39:28 -04:00
Paul Govereau
e0bc15202b 6898851: Compiling against this corrupt class file causes a stacktrace from javac
Added check for index out-of-bounds erros in ClassReader

Reviewed-by: jjg
2014-03-19 11:34:27 -04:00
Lana Steuck
9a44609844 Merge 2014-03-18 17:46:44 -07:00
Paul Govereau
03c0b0a11e 8036007: javac crashes when encountering an unresolvable interface
Reviewed-by: vromero, jlahoda
2014-03-18 22:12:46 +00:00
Dan Smith
d9e857f304 8034980: Fix @summary tag of test/tools/javac/parser/T4910483.java
Reviewed-by: vromero
2014-03-17 14:03:59 -06:00
Eric McCorkle
53e3990b7c 8037420: Silent failures in Annotate.actualEnterTypeAnnotations
Remove two silent failures

Reviewed-by: jjg
2014-03-14 15:35:13 -04:00
Vicente Romero
2564e82ad1 8034924: Incorrect inheritance of inaccessible static method
Reviewed-by: jjg, jlahoda
2014-03-13 20:13:43 +00:00
Vicente Romero
73e0ab9b7f 8034127: javac provide debug oriented toString() methods to InferenceContext and UndetVar
Reviewed-by: jjg
2014-03-13 17:36:51 +00:00
Joe Darcy
07cc98bb1a 8037120: Fix doclint warnings in javax.lang.model exception types
Reviewed-by: jjg
2014-03-11 17:52:45 -07:00
David Katleman
060f4862a7 Added tag jdk9-b04 for changeset 612191246a7d 2014-03-11 15:42:05 -07:00
Joe Darcy
e5fb7f77d6 8036842: Remove unneeded/obsolete -source/-target options in javac tests, part 2
Reviewed-by: jjg, sogoel
2014-03-07 13:30:23 -08:00
Jan Lahoda
16962804f3 8034854: outer_class_info_index of synthetic class is not zero
Auxiliary synthetic anonymous classes should not have an outer class specified in the InnerClasses attribute.

Reviewed-by: vromero, jjg, abuckley
2014-03-07 13:35:56 +01:00
Neil Toda
7aed9a60e0 8031670: Remove unneeded -source options in javadoc tests
Reviewed-by: jjg, darcy, vromero
2014-03-06 16:15:02 -08:00
Paul Govereau
af27057b26 8034091: There is no records in LineNumberTable attribute for ternary operator ?: splitted to several lines
Reviewed-by: jjg
2014-03-06 13:50:12 -05:00
Lana Steuck
b2b667ccfe Merge 2014-03-06 10:41:56 -08:00
Neil Toda
735e586b5f 8035878: javadoc tool documentation should be using {@code ..} specifier
Reviewed-by: jjg
2014-03-03 15:24:31 -08:00
Neil Toda
72641e4e7f 8035877: javadoc classes are missing @return and @param tags
Reviewed-by: jjg
2014-03-03 15:10:01 -08:00
Neil Toda
1f9569d235 8035875: remove deprecated html <font> tags from javadoc package-info.java file
Reviewed-by: jjg
2014-03-03 15:03:17 -08:00
Eric McCorkle
6b9060ac8f 8036142: Remove redundant call to annotateTypeLater with null Symbol
AnnotateTypeLater (formerly typeAnnotate) with null as the symbol was a way to force attribution of type annotations, but this is now obsolete and problematic, and a silent noop condition

Reviewed-by: jjg
2014-03-03 16:17:32 -05:00
Jan Lahoda
74250736aa 8031383: Error recovery in JavacParser could be improved
Improving error recovery in JavacParser by avoiding artificial nextToken in JavacParser.reportSyntaxError.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg, jfranck
2014-02-28 20:25:24 +01:00
Vicente Romero
c5ab176b3e 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
Reviewed-by: jjg
2014-02-28 18:27:14 +00:00
Per Bothner
25c2444601 8033287: Reduce the size of the endPosTable
Co-authored-by: Charlie Turner <chturne@gmail.com>
Reviewed-by: jjg
2014-02-27 13:57:57 -08:00
Paul Govereau
e97bf8b146 8035972: missing test file for 8034048
Reviewed-by: jjg, vromero
2014-02-27 11:47:39 -08:00
Eric McCorkle
816bfaa7bc 8035766: Execute TypeAnnotate visitor at queue flush time
Moved execution of TypeAnnotate visitor into Worker for type annotations

Reviewed-by: jjg
2014-02-27 00:29:22 -05:00
Paul Govereau
dd0e29f8b7 6533516: Warning needed for file with future time stamps
Reviewed-by: jjg, vromero
2014-02-26 18:05:02 -08:00
Paul Govereau
f6250d7784 8034048: javac crash with method references plus lambda plus var args
Reviewed-by: jjg, vromero
2014-02-26 15:38:55 -08:00
Eric McCorkle
38cc470411 8035758: Move annotation codepaths from MemberEnter.java to Annotate.java
Cosmetic code cleanup patch, moving code to the file where it ought to reside.

Reviewed-by: vromero
2014-02-25 14:06:48 -05:00
Lana Steuck
5c411f3cc6 Merge 2014-02-24 13:06:07 -08:00
Vicente Romero
c7af5cd60b 8034143: javac, subclasses of Infer.IncorporationStep should implement the accepts() method
Reviewed-by: jjg
2014-02-22 17:42:10 +00:00
David Katleman
7d41c598a4 Added tag jdk9-b03 for changeset 2740ebeb238c 2014-02-21 11:40:51 -08:00
Yuri Nesterenko
98b44a020b 6457406: javadoc doesn't handle <a href='http://...'> properly in producing index pages
Reviewed-by: jjg, bpatel, ksrini
2014-02-21 15:14:09 +04:00
Jan Lahoda
facc03d9f4 6411385: Trees.getPath does not work for constructors
Enhancing TestTrees test to ensure proper function of Trees.getPath/getTree, fixing cases where getTree did not work properly.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: jjg
2014-02-21 10:35:19 +01:00
Lana Steuck
a6f4599cf5 Merge 2014-02-20 20:00:43 -08:00
Jonathan Gibbons
31ca5c712a 8035364: An extra space in the comments of constant pool entries
Reviewed-by: ksrini
2014-02-19 15:05:19 -08:00
Lana Steuck
fb842a624a Merge 2014-02-11 11:25:59 -08:00
David Katleman
fa155ae4bd Added tag jdk9-b02 for changeset fc0fe10fbee9 2014-02-06 13:09:40 -08:00
Erik Joelsson
961e7da0a4 8026773: Failing compilation in Corba does not fail the build
Reviewed-by: ihse, tbell
2014-02-05 11:04:04 +01:00
Eric McCorkle
3bd9bdd993 8033004: Make base TypeAnnotationPosition data immutable, create better methods for creating base TypeAnnotationPositions
First of a series of major fixes to type annotations; cleans up interface with TypeAnnotationPosition

Reviewed-by: jjg
2014-02-03 17:19:15 -05:00
Jan Lahoda
4724c454cd 8030091: Request to update error messages from javac for negative varargs test cases
Introducing a new error message for vararg parameter not being the last parameter, improving error message for unexpected character after a parameter.

Reviewed-by: jjg, sogoel
2014-02-02 12:12:01 +01:00
Jonathan Gibbons
30e9783850 8033180: An inappropriate newline symbol in the help section
Reviewed-by: ksrini
2014-01-30 17:46:25 -08:00
Eric McCorkle
ca53cc64e5 8033218: Silent failure in TypeAnnotations.resolveFrame
Change silent no-op to assertion failure when resolveFrame is called before attribution.

Reviewed-by: jfranck
2014-01-30 07:35:49 -05:00
Jonathan Gibbons
214de0eb69 8032869: remove support for legacy options in javap
Reviewed-by: ksrini
2014-01-29 14:32:27 -08:00
Eric McCorkle
77feb9302c 8032932: Add assertion to fix silent failure in Gen.getAndRemoveNonFieldTAs
Turn silent failure if type annotation position type is UNKNOWN into assertion failure.

Reviewed-by: jjg
2014-01-28 17:52:30 -05:00
Eric McCorkle
07998a6335 8032980: Silent failure in Attr.annotateType
Turn silent discard of annotations in Attr.annotateType if conversion to TypeCompound fails into an assertion failure.

Reviewed-by: jjg
2014-01-28 17:51:28 -05:00
Jonathan Gibbons
552e338377 8032819: Extra empty line between field declarations for the "-v -c" and "-v -l" combination of options
Reviewed-by: ksrini
2014-01-28 14:31:29 -08:00
Jeff Dinkins
49b3f8639b 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8
Reviewed-by: lana
2014-01-28 20:10:19 +00:00
Lana Steuck
cf5fc4c79e Merge 2014-01-28 11:22:56 -08:00
Lana Steuck
b14b1b2b12 Merge 2014-01-27 21:01:30 -08:00