Commit Graph

685 Commits

Author SHA1 Message Date
Tim Prinzing
652b5f8546 8276674: Malformed Javadoc inline tags in JDK source
Reviewed-by: jjg, rriggs, prappo, bchristi
2021-12-02 20:47:29 +00:00
Liam Miller-Cushon
4f15be2cd4 8277965: Enclosing instance optimization affects serialization
Reviewed-by: darcy
2021-12-02 19:17:09 +00:00
Adam Sotona
8d9cb2efe6 8278078: Cannot reference super before supertype constructor has been called
Reviewed-by: mcimadamore
2021-12-02 15:29:26 +00:00
Adam Sotona
951247c8cb 8235876: Misleading warning message in java source-file mode
Reviewed-by: vromero
2021-11-24 17:03:53 +00:00
Christian Stein
663e33de13 8272728: javac ignores any -J option in @argfiles silently
Reviewed-by: jjg
2021-11-24 16:50:25 +00:00
Jan Lahoda
d085c2b8a7 8273328: Compiler implementation for Pattern Matching for switch (Second Preview)
Reviewed-by: vromero, mcimadamore
2021-11-24 10:07:49 +00:00
Liam Miller-Cushon
ea85e01a4c 8271623: Omit enclosing instance fields from inner classes that don't use it
Reviewed-by: vromero, jlahoda
2021-11-23 18:14:47 +00:00
Vicente Romero
7b67a49f83 8261847: performance of java.lang.Record::toString should be improved
Reviewed-by: jlaskey, redestad
2021-11-23 15:23:23 +00:00
Joe Darcy
4ff43010bb 8224922: Access JavaFileObject from Element(s)
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: jjg
2021-11-21 20:42:37 +00:00
Jan Lahoda
2f20b0d8da 8273039: JShell crashes when naming variable or method "abstract" or "strictfp"
Reviewed-by: vromero
2021-11-19 07:49:58 +00:00
Sergey Bylokhov
29e552c03a 8272358: Some tests may fail when executed with other locales than the US
Reviewed-by: aivanov
2021-11-17 22:21:38 +00:00
Jan Lahoda
0c2d00bff7 8275097: Wrong span of the 'default' tag
Reviewed-by: vromero
2021-11-08 13:21:40 +00:00
Guoxiong Li
2b02b6f513 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
Reviewed-by: vromero
2021-11-03 01:57:52 +00:00
Joe Darcy
48f3fcab51 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
Reviewed-by: jjg
2021-10-28 22:11:03 +00:00
Joe Darcy
6a466fe7ae 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields
8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type

Reviewed-by: erikj, sspitsyn, jlahoda, vromero, rriggs, smarks
2021-10-21 21:11:01 +00:00
Vicente Romero
fd10f1996e 8275302: unexpected compiler error: cast, intersection types and sealed
Reviewed-by: jlahoda
2021-10-19 16:46:14 +00:00
Jan Lahoda
b870468bdc 8274347: Passing a *nested* switch expression as a parameter causes an NPE during compile
Reviewed-by: vromero
2021-10-11 12:38:08 +00:00
Joe Darcy
c391e59ea6 8274244: ReportOnImportedModuleAnnotation.java fails on rerun
Reviewed-by: jjg
2021-10-05 17:31:57 +00:00
Jan Lahoda
a5080effc7 8272564: Incorrect attribution of method invocations of Object methods on interfaces
Reviewed-by: jlaskey, mcimadamore, vromero
2021-10-05 10:17:24 +00:00
Jonathan Gibbons
0ca094bc5f 8273244: Improve diagnostic output related to ErroneousTree
Reviewed-by: prappo
2021-10-04 16:59:30 +00:00
Adam Sotona
139a8334cb 8268869: java in source-file mode suggests javac-only Xlint flags
Reviewed-by: jjg
2021-10-04 15:48:09 +00:00
Jan Lahoda
292d7bb1d5 8274363: Transitively sealed classes not considered exhaustive in switches
Reviewed-by: vromero
2021-10-01 08:54:18 +00:00
Jan Lahoda
1887028408 8269113: Javac throws when compiling switch (null)
Co-authored-by: Guoxiong Li <gli@openjdk.org>
Reviewed-by: vromero
2021-10-01 08:53:04 +00:00
Jan Lahoda
ba7d550c6e 8270139: jshell InternalError crash for import of @Repeatable followed by unresolved ref
Reviewed-by: vromero
2021-09-22 12:52:31 +00:00
Pavel Rappo
0fc47e99d2 8266666: Implementation for snippets
Co-authored-by: Jonathan Gibbons <jjg@openjdk.org>
Co-authored-by: Hannes Wallnöfer <hannesw@openjdk.org>
Reviewed-by: jjg
2021-09-21 15:53:35 +00:00
Jan Lahoda
699865f76c 8259039: Passing different version to --release flag than javac version output warning
Reviewed-by: jjg
2021-09-20 13:43:14 +00:00
Guoxiong Li
e07ab82ee5 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
Reviewed-by: vromero
2021-09-17 05:34:25 +00:00
Guoxiong Li
fe89dd3b0d 8271254: javac generates unreachable code when using empty semicolon statement
Reviewed-by: vromero
2021-09-14 14:46:21 +00:00
Jan Lahoda
b0d04976bd 8273584: TypeElement.getSuperclass crashes for a record TypeElement when j.l.Record is not available
Reviewed-by: vromero
2021-09-13 09:24:06 +00:00
Vicente Romero
dd1209e4ae 8268885: duplicate checkcast when destination type is not first type of intersection type
Reviewed-by: jlahoda
2021-09-09 18:36:17 +00:00
Aleksey Shipilev
267c61a16a 8273361: InfoOptsTest is failing in tier1
Reviewed-by: jpai, ihse, jlahoda
2021-09-08 16:36:31 +00:00
Vicente Romero
ff4018bc86 8268148: unchecked warnings handle ? and ? extends Object differently
Reviewed-by: jlahoda
2021-09-03 15:20:23 +00:00
Vicente Romero
8c37909274 8273234: extended 'for' with expression of type tvar causes the compiler to crash
Reviewed-by: jlahoda
2021-09-03 13:11:27 +00:00
Guoxiong Li
d05494f98b 8266239: Some duplicated javac command-line options have repeated effect
Reviewed-by: vromero
2021-09-03 09:33:17 +00:00
Jan Lahoda
93eec9a103 8272776: NullPointerException not reported
Reviewed-by: vromero
2021-09-03 09:31:54 +00:00
Jan Lahoda
7b023a3f60 8273257: jshell doesn't compile a sealed hierarchy with a sealed interface and a non-sealed leaf
Reviewed-by: vromero
2021-09-03 09:30:56 +00:00
Jan Lahoda
f17ee0c5c7 8273263: Incorrect recovery attribution of record component type when j.l.Record is unavailable
Reviewed-by: vromero
2021-09-03 09:29:45 +00:00
Joe Darcy
2f01a6f8b6 8273157: Add convenience methods to Messager
Reviewed-by: jjg
2021-09-01 20:28:05 +00:00
Vicente Romero
75d987a0dd 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Vicente Romero <vromero@openjdk.org>
Reviewed-by: jlahoda
2021-08-31 15:40:17 +00:00
Guoxiong Li
a9188f237e 8268894: forged ASTs can provoke an AIOOBE at com.sun.tools.javac.jvm.ClassWriter::writePosition
Reviewed-by: vromero
2021-08-29 07:26:08 +00:00
Vicente Romero
14623cde3a 8270835: regression after JDK-8261006
Reviewed-by: jlahoda
2021-08-17 20:47:36 +00:00
Jonathan Gibbons
ae45592d33 8272374: doclint should report missing "body" comments
Reviewed-by: kcr, hannesw
2021-08-16 20:48:25 +00:00
Jonathan Gibbons
ec8d3badc8 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
Reviewed-by: darcy
2021-08-11 18:03:40 +00:00
Jan Lahoda
3215dbc8b8 8271928: ErroneousTree with start position -1
Reviewed-by: jlaskey, vromero
2021-08-11 08:54:20 +00:00
Joe Darcy
57ae9fbe77 8140442: Add getOutermostTypeElement to javax.lang.model utility class
Reviewed-by: jlahoda
2021-08-10 16:49:49 +00:00
Joe Darcy
7fc99cf9b6 8225488: Examine ExecutableType.getReceiverType behavior when source receiver parameter is absent
Reviewed-by: jjg
2021-08-09 18:33:34 +00:00
Liam Miller-Cushon
60c11fef00 8261088: Repeatable annotations without @Target cannot have containers that target module declarations
Reviewed-by: jfranck
2021-07-28 18:21:19 +00:00
Jesper Wilhelmsson
eb6da88817 Merge 2021-07-27 00:57:58 +00:00
Jim Laskey
b76a83888b 8269150: UnicodeReader not translating \u005c\\u005d to \\]
Reviewed-by: jjg, jlahoda, darcy
2021-07-26 18:04:28 +00:00
Daniel D. Daugherty
9b93d816c1 8271161: [BACKOUT] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
Reviewed-by: iignatyev
2021-07-22 21:15:20 +00:00
Jonathan Gibbons
c1c404896c 8249634: doclint should report implicit constructor as missing javadoc comments
Reviewed-by: hannesw
2021-07-22 18:52:19 +00:00
Vicente Romero
c962e6ec0b 8261006: 'super' qualified method references cannot occur in a static context
Reviewed-by: sadayapalam
2021-07-15 15:33:23 +00:00
Thejasvi Voniadka
04b73bc4e0 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
Reviewed-by: darcy
2021-07-15 04:52:38 +00:00
Jesper Wilhelmsson
ec975c6a05 Merge 2021-07-10 01:23:18 +00:00
Jan Lahoda
1196b35684 8270151: IncompatibleClassChangeError on empty pattern switch statement case
Reviewed-by: mcimadamore
2021-07-09 11:03:40 +00:00
Jan Lahoda
885f7b1141 8269146: Missing unreported constraints on pattern and other case label combination
8269301: Switch statement with a pattern, constant and default label elements crash javac

Reviewed-by: mcimadamore
2021-07-09 08:03:56 +00:00
Jesper Wilhelmsson
dfd6b2be7d Merge 2021-07-08 23:21:00 +00:00
Guoxiong Li
9e75f922b1 8269738: AssertionError when combining pattern matching and function closure
Reviewed-by: jlahoda, vromero
2021-07-08 14:15:07 +00:00
Jan Lahoda
fa08cc62df 8268766: Desugaring of pattern matching enum switch should be improved
Reviewed-by: mcimadamore, psandoz
2021-07-08 11:56:53 +00:00
Jan Lahoda
4f70759175 8270006: Switches with 'case null:' should be exhaustive
Reviewed-by: vromero
2021-07-08 08:03:09 +00:00
Jesper Wilhelmsson
270fbcb3f5 Merge 2021-07-08 00:55:53 +00:00
Jan Lahoda
7fcd5ca025 8266036: class file for sun.misc.Contended not found
8258421: (jdeprscan) tools/jdeprscan/tests/jdk/jdeprscan/TestRelease.java failed with "error: cannot access jdk.internal.ValueBased"

Reviewed-by: darcy
2021-07-07 09:49:53 +00:00
Jan Lahoda
820f2900d8 8268859: jshell throws exception while parsing illegal "case true"
Reviewed-by: mcimadamore
2021-07-07 07:26:41 +00:00
Jan Lahoda
815e4af35d 8269802: javac fails to compile nested pattern matching switches
8269808: javac generates class with invalid stack map

Reviewed-by: mcimadamore
2021-07-07 06:24:58 +00:00
Jesper Wilhelmsson
b0e186792e Merge 2021-07-02 01:07:50 +00:00
Vicente Romero
de61328d30 8225559: assertion error at TransTypes.visitApply
Reviewed-by: sadayapalam, jlahoda
2021-07-01 16:18:12 +00:00
Jan Lahoda
a8385feb30 8269354: javac crashes when processing parenthesized pattern in instanceof
Reviewed-by: vromero
2021-07-01 10:10:03 +00:00
Jesper Wilhelmsson
9def3b068e Merge 2021-07-01 01:01:34 +00:00
Liam Miller-Cushon
4930ae96d8 8268592: JDK-8262891 causes an NPE in Lint.augment
Reviewed-by: vromero
2021-07-01 00:16:23 +00:00
Jan Lahoda
4ee400ae43 8268320: Better error recovery for broken patterns in switch
Reviewed-by: vromero
2021-06-30 09:47:22 +00:00
Jan Lahoda
c3c918928c 8269141: Switch statement containing pattern case label element gets in the loop during execution
Reviewed-by: vromero
2021-06-30 08:45:12 +00:00
Jesper Wilhelmsson
a29953d805 Merge 2021-06-27 23:51:05 +00:00
Jan Lahoda
4eb321298a 8268871: Adjust javac to updated exhaustiveness specification
Reviewed-by: vromero
2021-06-25 09:52:06 +00:00
Guoxiong Li
7ab12856c4 8267610: NPE at at jdk.compiler/com.sun.tools.javac.jvm.Code.emitop
8268748: Javac generates uncorrect bytecodes when using nested pattern variables

Reviewed-by: jlahoda, vromero
2021-06-24 23:07:43 +00:00
Vicente Romero
7e96318a1f 8254571: Erroneous generic type inference in a lambda expression with a checked exception
Reviewed-by: jlahoda, mcimadamore
2021-06-23 17:13:09 +00:00
Jan Lahoda
bf70620745 8268961: Parenthesized pattern with guards does not work
8268896: Parenthesized pattern is not guarded by source level check

Reviewed-by: vromero
2021-06-23 10:16:42 +00:00
Joel Borggrén-Franck
0b8a0e2b58 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
Reviewed-by: vromero
2021-06-21 08:39:35 +00:00
Jesper Wilhelmsson
e0f6f70d3f Merge 2021-06-15 22:45:28 +00:00
Jan Lahoda
35d867df1f 8268663: Crash when guards contain boolean expression
Reviewed-by: vromero
2021-06-15 09:04:35 +00:00
Guoxiong Li
bca914b29e 8268670: yield statements doesn't allow ~ or ! unary operators in expression
Reviewed-by: vromero, jlahoda
2021-06-14 19:02:23 +00:00
Jan Lahoda
abe20c188c 8268333: javac crashes when pattern matching switch contains default case which is not last
Reviewed-by: vromero
2021-06-14 14:25:32 +00:00
Joe Darcy
b018c450e5 8267630: Start of release updates for JDK 18
8267632: Add source 18 and target 18 to javac
8267631: Add SourceVersion.RELEASE_18

Reviewed-by: iris, erikj, dholmes
2021-06-10 16:22:14 +00:00
Vicente Romero
bb3d226a4e 8238213: Method resolution should stop on static error
Reviewed-by: jlahoda
2021-06-09 15:56:55 +00:00
Joel Borggrén-Franck
2717fcb134 8232948: javac -h should mangle the overload argument signature
Reviewed-by: jjg
2021-06-08 10:51:19 +00:00
Vicente Romero
4f9d6b7d68 8267465: remove superfluous preview related annotations and test options
Reviewed-by: jlahoda
2021-06-07 13:57:15 +00:00
Jan Lahoda
908aca29ca 8262891: Compiler implementation for Pattern Matching for switch (Preview)
Co-authored-by: Brian Goetz <briangoetz@openjdk.org>
Co-authored-by: Mandy Chung <mchung@openjdk.org>
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: mcimadamore, forax, godin, psandoz, mchung
2021-06-07 07:01:30 +00:00
Guoxiong Li
b7ac705dd6 8263642: javac emits duplicate checkcast for first bound of intersection type in cast
Reviewed-by: vromero
2021-06-02 17:17:31 +00:00
Jan Lahoda
19450b9951 8266281: Assign Symbols to the package selector expression
Reviewed-by: vromero
2021-06-02 11:16:10 +00:00
Jan Lahoda
9247630a0d 8265270: Type.getEnclosingType() may fail with CompletionFailure
Reviewed-by: vromero
2021-06-02 09:53:31 +00:00
Joe Darcy
0ae4ceb413 8244146: javac changes for JEP 306
8266399: Core libs update for JEP 306

Reviewed-by: sadayapalam, bpb, naoto
2021-06-01 21:59:39 +00:00
Guoxiong Li
10a6f5d637 8230623: Extract command-line help for -Xlint sub-options to new --help-lint
Reviewed-by: jjg
2021-05-27 14:04:56 +00:00
Pavel Rappo
4343997a1a 8267708: Remove references to com.sun.tools.javadoc.**
This commit changes BaseOptions.java to fix the NoStringToLower test that failed after jdk.javadoc has been added to the list of package prefixes that NoStringToLower scans.

Reviewed-by: jjg
2021-05-26 11:27:15 +00:00
Jan Lahoda
f632254943 8267221: jshell feedback is incorrect when creating method with array varargs parameter
Reviewed-by: vromero
2021-05-26 11:12:22 +00:00
Weijun Wang
640a2afda3 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager
Co-authored-by: Lance Andersen <lancea@openjdk.org>
Co-authored-by: Weijun Wang <weijun@openjdk.org>
Reviewed-by: dholmes, alanb, dfuchs, mchung, mullan, prr
2021-05-24 16:55:55 +00:00
Vicente Romero
f5562f1214 8258535: jvm.ClassReader should set the accessor to the corresponding record component
Reviewed-by: jfranck
2021-05-24 14:50:22 +00:00
Jan Lahoda
ec8a8097c3 8267119: switch expressions lack support for deferred type-checking
Reviewed-by: mcimadamore
2021-05-21 14:09:42 +00:00
Vicente Romero
81f39ed3e0 8261205: AssertionError: Cannot add metadata to an intersection type
Reviewed-by: mcimadamore
2021-05-20 17:53:00 +00:00
Vicente Romero
0fa9223f34 8260517: implement Sealed Classes as a standard feature in Java
Co-authored-by: Harold Seigel <hseigel@openjdk.org>
Co-authored-by: Vicente Romero <vromero@openjdk.org>
Reviewed-by: dholmes, mcimadamore, jlahoda
2021-05-20 09:11:08 +00:00
Hannes Wallnöfer
66ab6d86d1 8264181: javadoc tool Incorrect error message about malformed link
Reviewed-by: prappo
2021-05-19 17:17:50 +00:00
Guoxiong Li
e858dd6197 8267361: JavaTokenizer reads octal numbers mistakenly
Reviewed-by: jlaskey
2021-05-19 12:50:54 +00:00