Commit Graph

617 Commits

Author SHA1 Message Date
Maurizio Cimadamore
02daeca60e 7034019: ClassCastException in javac with conjunction types
Resolve.mostSpecific doesn't handle case of raw override

Reviewed-by: dlsmith
2011-04-12 20:58:06 -07:00
Maurizio Cimadamore
c46387423a 7034511: Loophole in typesafety
Type-variable substutution takes upper bound of replaced captured type-variable

Reviewed-by: dlsmith
2011-04-12 20:56:16 -07:00
Michael Fang
5e01475e7b Merge 2011-04-11 16:31:22 -07:00
Michael Fang
4220a85daf 7034940: message drop 2 translation integration
Reviewed-by: yhuang
2011-04-08 15:25:47 -07:00
Kelly O'Hair
b49579c56c 7033660: Update copyright year to 2011 on any files changed in 2011
Reviewed-by: dholmes
2011-04-06 20:33:44 -07:00
Joe Darcy
777c93481f 7033809: Rename "disjunctive" to "union" in javax.lang.model
Reviewed-by: mcimadamore, jjg
2011-04-06 19:30:57 -07:00
Alan Bateman
243b526b99 Merge 2011-04-04 19:36:26 +01:00
Bhavesh Patel
0069129f00 7010344: Some of the html files do not have element <a> in right context
Reviewed-by: jjg
2011-04-04 10:14:23 -07:00
Alan Bateman
39b8c8c057 7029979: (fs) Path.toRealPath(boolean) should be toRealPath(LinkOption...)
Reviewed-by: mcimadamore, jjg
2011-04-04 18:10:38 +01:00
Kumar Srinivasan
e3d10322c1 7028405: (javac) remove unused JSR-292 code
Reviewed-by: jrose, mcimadamore
2011-04-03 17:00:50 -07:00
Maurizio Cimadamore
be712a0152 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource
Missing name check before calling MethodSymbol.overrides causes wrong warnings to be issued

Reviewed-by: jjg
2011-04-01 12:30:13 +01:00
Jonathan Gibbons
cd57e9960f 7031005: javap prints "extends java.lang.Object"
Reviewed-by: mcimadamore
2011-03-30 18:32:16 -07:00
Jonathan Gibbons
ce0e6ca247 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build
Reviewed-by: darcy, mcimadamore
2011-03-30 18:18:11 -07:00
Maurizio Cimadamore
acf788aa1f 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
Javac should warn about use/declaration of AutoCloseable subclasses that can throw InterruptedException

Reviewed-by: jjg
2011-03-29 16:41:18 +01:00
Maurizio Cimadamore
bd9526ecbe 7030150: Type inference for generic instance creation failed for formal type parameter
Problem when explicit generic constructor type-arguments are used in conjunction with diamond

Reviewed-by: jjg
2011-03-29 16:40:51 +01:00
Maurizio Cimadamore
bc3a1c60ef 7030606: Project-coin: multi-catch types should be pairwise disjoint
Bring javac in sync with latest Project Coin EDR

Reviewed-by: jjg
2011-03-29 16:40:31 +01:00
Maurizio Cimadamore
0a0b5a7a8a 7030687: Diamond: compiler accepts erroneous code where diamond is used with non-generic inner class
Diamond accepts non-parameterized member inner classes with parameterized outer because of a bad check

Reviewed-by: jjg
2011-03-29 16:40:07 +01:00
Bhavesh Patel
d5fd66ab02 7001086: NLS: un-used resources should be removed from standard.properties and improper concatenation
Reviewed-by: jjg
2011-03-25 15:17:52 -07:00
Jonathan Gibbons
f36dc58a6f 6437138: JSR 199: Compiler doesn't diagnose crash in user code
6482554: uncaught exception from annotation processor not reported through JavaCompiler.CompilationTask.call

Reviewed-by: mcimadamore
2011-03-25 07:58:53 -07:00
Jonathan Gibbons
7be50d11b1 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies
Reviewed-by: mcimadamore
2011-03-24 16:14:30 -07:00
Bhavesh Patel
987d5902c1 7010342: End tag for element P is not open for few html files generated using new javadoc
Reviewed-by: jjg
2011-03-23 14:40:18 -07:00
Bhavesh Patel
881add500f 7025314: NLS: translatability violation on standard.properties
Reviewed-by: jjg
2011-03-22 18:32:41 -07:00
Lana Steuck
04eb684afe Merge 2011-03-18 11:00:10 -07:00
Jonathan Gibbons
cc992b27bf 6930508: Passing nested class names on javac command line interfere with subsequent name -> class lookup
Reviewed-by: darcy
2011-03-16 17:21:52 -07:00
Maurizio Cimadamore
eb4e1b86cd 6558548: The compiler needs to be aligned with clarified specification of throws
Javac should issue unconditional warnings when 'dead' catch clauses are detected

Reviewed-by: jjg
2011-03-16 11:12:26 +00:00
Kelly O'Hair
5c67341d93 Merge 2011-03-15 15:32:21 -07:00
Bhavesh Patel
73407fb7a1 4743537: Help doesn't say what "All Classes" and other links really mean
Reviewed-by: jjg
2011-03-15 14:19:00 -07:00
Jonathan Gibbons
a4b1b99eb0 6988079: Errors reported via Messager.printMessage(ERROR,"error message") are not tallied correctly
Reviewed-by: darcy
2011-03-15 11:48:55 -07:00
Jonathan Gibbons
13d31713dc 6993311: annotations on packages are not validated
Reviewed-by: mcimadamore
2011-03-15 11:04:56 -07:00
Jonathan Gibbons
8f64aeabe2 7026509: Cannot use JavaCompiler to create multiple CompilationTasks for partial compilations
Reviewed-by: mcimadamore
2011-03-14 11:48:41 -07:00
Jonathan Gibbons
593927cf2d 7010608: the string 'error' should appear in error messages
Reviewed-by: mcimadamore
2011-03-14 11:42:15 -07:00
Jonathan Gibbons
c2e4376861 7026414: Types.asElement() returns null for ErrorType
Reviewed-by: darcy
2011-03-14 11:33:33 -07:00
Bhavesh Patel
91cd6261bc 7006178: findbugs high priority issues in new javadoc
Reviewed-by: jjg
2011-03-11 15:39:51 -08:00
Joe Darcy
c6006bc605 7026868: Apply specification changes fro 6505047
Reviewed-by: jjg
2011-03-11 14:07:11 -08:00
Bhavesh Patel
4f26bca4de 6776656: Incorrect number in 'generated' help-doc.html
Reviewed-by: jjg
2011-03-10 14:37:52 -08:00
Michael Fang
1215af2a23 7025324: NLS: t13y fix for 7022005 [ja,zh_CN] javadoc, part of navigation bar in generated html are not translated
Reviewed-by: yhuang, ogino, jennyh
2011-03-08 23:43:09 -08:00
Kumar Srinivasan
aa60df6782 7021927: javac: regression in performance
Reviewed-by: jjg
2011-03-07 17:39:42 -08:00
Jonathan Gibbons
f71b78ced3 6980021: javac should document @file command line option
Reviewed-by: mcimadamore
2011-03-07 13:45:06 -08:00
Maurizio Cimadamore
409b9b8d25 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR)

Reviewed-by: jjg
2011-03-07 14:31:50 +00:00
Jan Lahoda
ddaf77107d 7024568: Very long method resolution causing OOM error
Resolve.findMethod scans same receiver type more than once in certain inheritance graphs

Reviewed-by: jjg
2011-03-07 14:11:48 +00:00
Jonathan Gibbons
9365637c4a 6964914: javadoc does not output number of warnings using user written doclet
Reviewed-by: bpatel
2011-03-04 19:59:04 -08:00
Jonathan Gibbons
75c64565c4 6227454: package.html and overview.html may not be read fully
Reviewed-by: bpatel
2011-03-04 19:56:02 -08:00
Jonathan Gibbons
42bc55bf32 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup
Reviewed-by: bpatel
2011-03-04 19:53:03 -08:00
Jonathan Gibbons
cc52e2d413 6966736: javac verbose output is inconsistent
Reviewed-by: mcimadamore
2011-03-04 11:33:37 -08:00
Maurizio Cimadamore
f416cac815 7022054: Invalid compiler error on covariant overriding methods with the same erasure
Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6

Reviewed-by: jjg
2011-03-03 17:34:58 +00:00
Maurizio Cimadamore
291f04e8c0 7023703: Valid code doesn't compile
Leftovers cause problems when analyzing loops in Flow.java

Reviewed-by: jjg
2011-03-03 17:32:35 +00:00
Maurizio Cimadamore
df9296f567 7023233: False positive for -Xlint:try with nested try with resources blocks
Wrong lint warning issued about unused resource when nested try-with-resource blocks are found

Reviewed-by: jjg
2011-03-03 09:43:24 +00:00
Jonathan Gibbons
f78030e4f1 6639645: Modeling type implementing missing interfaces
Reviewed-by: darcy, mcimadamore
2011-03-02 21:13:55 -08:00
Jonathan Gibbons
ed6677cbba 6986892: confusing warning given after errors in annotation processing
Reviewed-by: darcy
2011-03-02 21:06:17 -08:00
Jonathan Gibbons
6c7b14a762 6986895: compiler gives misleading message for no input files
Reviewed-by: darcy
2011-03-02 14:03:38 -08:00
Maurizio Cimadamore
45e06252b7 6541876: "Enclosing Instance" error new in 1.6
Unqualified 'this' should not be selected in a qualified super() call in a default constructor

Reviewed-by: jjg
2011-03-02 10:56:39 +00:00
Jonathan Gibbons
5fd6eeaa54 7021183: 269: assertion failure getting enclosing element of an undefined name
Reviewed-by: mcimadamore
2011-03-01 12:00:06 -08:00
Jonathan Gibbons
36ed816102 7022711: compiler crash in try-with-resources
Reviewed-by: mcimadamore
2011-02-28 13:42:24 -08:00
Jonathan Gibbons
148841e5e1 7022741: warning counts are wrong after anno processing
Reviewed-by: mcimadamore
2011-02-28 13:37:48 -08:00
Jonathan Gibbons
56d963bdf6 7022337: repeated warnings about bootclasspath not set
Reviewed-by: mcimadamore
2011-02-28 12:19:18 -08:00
Maurizio Cimadamore
1683dd4109 7015715: lub gets stuck on type with complex supertype
Lub should not scan supertypes unnecessarily

Reviewed-by: jjg, dlsmith
2011-02-28 11:50:56 +00:00
Maurizio Cimadamore
32216fc797 7015430: Incorrect thrown type determined for unchecked invocations
Thrown types do not get updated after 15.12.2.8, and do not get erased as per 15.12.2.6

Reviewed-by: jjg, dlsmith
2011-02-28 11:48:53 +00:00
Jonathan Gibbons
a51962066d 7021650: fix Context issues
Reviewed-by: mcimadamore
2011-02-25 12:09:33 -08:00
Lana Steuck
b6bfe0166b Merge 2011-02-23 10:34:45 -08:00
Maurizio Cimadamore
1ae687fbd2 7020657: Javac rejects a fairly common idiom with raw override and interfaces
Name clash should not be reported if subinterface/implementing class resolves the clash by defining common overrider

Reviewed-by: jjg
2011-02-23 14:16:12 +00:00
Lana Steuck
f042640a89 Merge 2011-02-21 14:35:12 -08:00
Joe Darcy
dc728d5d5a 7020047: Project Coin: generate null-check around try-with-resources close call
Reviewed-by: jjg
2011-02-18 15:55:20 -08:00
Kumar Srinivasan
3b676c4925 7018859: javac turn off the Zip optimization by default
Reviewed-by: jjg
2011-02-18 08:12:06 -08:00
Maurizio Cimadamore
7d8c3e9460 7020043: Project Coin: diamond allowed on non-generic type
Diamond oerator should be disallowed on non-generic class types (i.e. String)

Reviewed-by: jjg
2011-02-18 12:28:49 +00:00
Dan Smith
f1181c706c 6990136: Cleanup use of Type.clone()
Introduced factory methods in class Types which can be used rather than clone().

Reviewed-by: jjg, mcimadamore
2011-02-16 10:27:00 -08:00
Kelly O'Hair
3388e7fb44 Merge 2011-02-15 12:34:33 -08:00
Maurizio Cimadamore
dd20e6fdd7 7017104: improve error reporting for uncaught/undeclared exceptions from try-with-resources
Twr should generate better error message when uncaught exceptions are thrown by implicit call of close() method

Reviewed-by: jjg
2011-02-15 11:51:04 +00:00
Maurizio Cimadamore
77f10a1c5f 7017664: Add listeners infrastracture to javac scopes
Add listeners to javac scopes, added CompoundScope and correct invalidation logic for ImplementationCache

Reviewed-by: jjg
2011-02-15 11:49:46 +00:00
Michael Fang
200f78309b Merge 2011-02-11 22:58:59 -08:00
Michael Fang
c800d6ea46 7017734: jdk7 message drop 1 translation integration
Reviewed-by: ogino, yhuang
2011-02-10 16:51:53 -08:00
Jonathan Gibbons
caf0257075 6485027: javac incorrectly handles relative paths in manifest classpath
Reviewed-by: mcimadamore
2011-02-10 15:05:33 -08:00
Jonathan Gibbons
1406a86c7d 7018098: CacheFSInfo persists too long
Reviewed-by: mcimadamore
2011-02-10 14:24:26 -08:00
Daniel Smith
76468b0bcf 7018447: langtools launcher template fails if tools run from their own directory
Reviewed-by: jjg
2011-02-09 18:26:08 -08:00
Jonathan Gibbons
c9335a55e1 7010792: remove bad debugging method from javac
Reviewed-by: mcimadamore
2011-02-09 14:10:52 -08:00
Peter B. Kessler
fef1c1e816 7017675: typo in JavacParser for allowUnderscoresInLiterals
Reviewed-by: dlsmith
2011-02-07 11:42:12 -08:00
Maurizio Cimadamore
dfec6e2301 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123
Override clash algorithm is not implemented correctly

Reviewed-by: jjg
2011-02-07 18:10:13 +00:00
Maurizio Cimadamore
3c0d8e8275 7017414: before the move of JSR 292 to package java.lang.invoke, javac must recognize the new package
Added support for future 292 package (support for old location 'java.dyn' will be removed in followup changeset)

Reviewed-by: jjg
2011-02-07 18:09:46 +00:00
Maurizio Cimadamore
f4daf3d7bf 7014715: javac returns different error code for certain failure(s)
Javac silently crashes when emitting certain kinds of resolution diagnostics

Reviewed-by: jjg
2011-02-03 09:38:19 +00:00
Maurizio Cimadamore
536bd08692 6969184: poor error recovery after symbol not found
Generic type-well formedness check should ignore erroneous symbols

Reviewed-by: jjg
2011-02-03 09:37:28 +00:00
Maurizio Cimadamore
6ded62c828 5017953: spurious cascaded diagnostics when name not found
When an operator is applied to one or more erroneous operands, spurious diagnostics are generated

Reviewed-by: jjg
2011-02-03 09:36:28 +00:00
Maurizio Cimadamore
79d1b7b1e1 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
Lint warnings generated during MemberEnter might ignore @SuppressWarnings annotations

Reviewed-by: jjg
2011-02-03 09:35:21 +00:00
Joe Darcy
9be3c0f789 6961571: Update visitors to support ARM's ElementKind.RESOURCE_VARIABLE
Reviewed-by: jjg
2011-02-01 10:11:05 -08:00
Joe Darcy
ba98ee427f 7014734: Project Coin: Allow optional trailing semicolon to terminate resources list in try-with-resources
Reviewed-by: jjg
2011-01-31 19:06:32 -08:00
Joe Darcy
8f9c072c89 7015530: Reiterate API specializations in javax.lang.model.elment subinterfaces
Reviewed-by: jjg
2011-01-28 16:54:18 -08:00
Alan Bateman
434b2147c7 Merge 2011-01-28 12:36:34 +00:00
Maurizio Cimadamore
15959fbf11 6838943: inference: javac is not handling type-variable substitution properly
Free type-variables are being replaced with type-variables bound to forall type leading to unsoundness

Reviewed-by: jjg, dlsmith
2011-01-28 12:06:21 +00:00
Maurizio Cimadamore
1e776bc78a 6313164: javac generates code that fails byte code verification for the varargs feature
Method applicability check should fail if formal varargs element type is not accessible

Reviewed-by: jjg
2011-01-28 12:03:49 +00:00
Maurizio Cimadamore
6647b73cc8 6910550: javac 1.5.0_17 fails with incorrect error message
Multiple clashing members declared in same class should be added to the class' scope in order to avoid downstream spurious diagnostics

Reviewed-by: jjg
2011-01-28 12:01:07 +00:00
Alan Bateman
68c23b7878 7006126: (fs) Updates to file system API (1/2011)
Reviewed-by: jjg
2011-01-28 09:25:20 +00:00
Jonathan Gibbons
de3bde6688 7013272: Automatically generate info about how compiler resource keys are used
Reviewed-by: mcimadamore
2011-01-26 13:45:25 -08:00
Jonathan Gibbons
a184b53cec 6554097: "final" confuses @SuppressWarnings
Reviewed-by: mcimadamore
2011-01-26 11:20:19 -08:00
Joe Darcy
ec50779b72 7013420: Project Coin: remove general expression support from try-with-resources statement
Reviewed-by: mcimadamore, jjg
2011-01-25 17:02:56 -08:00
Jonathan Gibbons
bcf09ec04f 6988106: javac report 'java.lang.IllegalMonitorStateException'
Reviewed-by: ksrini
2011-01-24 16:38:56 -08:00
Jonathan Gibbons
1d1fd8962d 6963934: JCCompilationUnit.getImports does not report all imports
Reviewed-by: mcimadamore
2011-01-24 16:17:33 -08:00
Maurizio Cimadamore
6bd5b48ca7 7013865: varargs: javac crashes during overload resolution with generic varargs
Fixed regression with varargs overload resolution that leads javac to crash

Reviewed-by: jjg
2011-01-24 15:45:41 +00:00
Maurizio Cimadamore
96d0749bfc 6569633: Varargs: parser error when varargs element type is an array
Explicit error message when old-style array syntax is mixed with varargs

Reviewed-by: jjg
2011-01-24 15:45:24 +00:00
Maurizio Cimadamore
13ecf26ded 6510286: Wording of javac error for inner classes
'inner classes cannot have static declarations' message needs to be reworked

Reviewed-by: jjg
2011-01-24 15:45:06 +00:00
Maurizio Cimadamore
b77effad6c 6968793: issues with diagnostics
Several diagnostic improvements

Reviewed-by: jjg
2011-01-24 15:44:51 +00:00
Maurizio Cimadamore
df54c56a04 6943278: spurious error message for inference and type-variable with erroneous bound
Type-inference should ignore erroneous bounds

Reviewed-by: jjg
2011-01-24 15:44:15 +00:00
Kumar Srinivasan
41aff425b6 6982999: tools must support -target 7 bytecodes
Reviewed-by: jjg, jrose
2011-01-18 08:37:05 -08:00