stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
14,983 Commits 2 Branches 0 Tags 1.2 GiB
ca5da47efc
Commit Graph

599 Commits

Author SHA1 Message Date
Jonathan Gibbons
654ae83d8e 7074416: Regression: JSR199: javac doesn't unwrap clientcodewrapper objects 
Reviewed-by: mcimadamore
 2011-08-31 15:39:00 -07:00
Maurizio Cimadamore
67f3781cb1 7079713: javac hangs when compiling a class that references a cyclically inherited class 
Types.membersClosure needs to handle pathological cases of cyclic inheritance

Reviewed-by: jjg, jjh
 2011-08-31 16:15:19 +01:00
Maurizio Cimadamore
68039c2904 7085024: internal error; cannot instantiate Foo 
Types.isConvertible does not handle erroneous types correctly

Reviewed-by: jjg
 2011-08-31 16:11:28 +01:00
Jonathan Gibbons
4cd6c8c31e 7074189: some javac tests fail with latest jtreg 4.1 b03 
Reviewed-by: darcy
 2011-08-05 15:57:59 -07:00
Joe Darcy
dba9612ad9 7071246: Enclosing string literal in parenthesis in switch-case crashes javac 
Reviewed-by: mcimadamore
 2011-08-04 11:15:37 -07:00
Kumar Srinivasan
53abe0d254 7068902: (javac) allow enabling or disabling of String folding 
Contributed by netbeans team, modified to suit by the langtools team.

Reviewed-by: jjg, mcimadamore
 2011-07-27 11:53:17 -07:00
Maurizio Cimadamore
5c209a7d2d 7057297: Project Coin: diamond erroneously accepts in array initializer expressions 
Diamond in array initializer expressions should be rejected

Reviewed-by: jjg
 2011-07-27 19:01:33 +01:00
Maurizio Cimadamore
02802c9449 7046778: Project Coin: problem with diamond and member inner classes 
Diamond inference generates spurious error messages when target type is a member inner class

Reviewed-by: jjg
 2011-07-27 19:01:08 +01:00
Maurizio Cimadamore
af30a2dbf3 7062745: Regression: difference in overload resolution when two methods are maximally specific 
Fix most specific when two methods are maximally specific and only one has non-raw return type

Reviewed-by: jjg, dlsmith
 2011-07-27 19:00:53 +01:00
David Schlosnagle
5f2157a8bc 7061125: Proposed javac argument processing performance improvement 
Reviewed-by: jjg, dlsmith, mcimadamore, forax
 2011-07-07 13:29:31 -07:00
Joe Darcy
01ee832f44 7025809: Provided new utility visitors supporting SourceVersion.RELEASE_8 
Reviewed-by: jjg, mcimadamore
 2011-07-05 16:37:24 -07:00
Jonathan Gibbons
00fd0bdcfd 7060926: Attr.PostAttrAnalyzer misses a case 
Reviewed-by: mcimadamore
 2011-06-30 12:00:53 -07:00
Joe Darcy
faf515b31f 6575445: Update annotation processor to only use java.util.ServiceLoader 
Reviewed-by: jjg
 2011-06-24 13:52:14 -07:00
Lana Steuck
2eb3bc1633 Merge 2011-06-22 23:26:00 -07:00
Joe Darcy
55d52a83a8 6449184: Provide JavacProcessingEnvironment.getWriter 
Reviewed-by: jjg
 2011-06-22 17:07:02 -07:00
Joe Darcy
fe7f869e78 7052122: Update JDK_MINOR_VERSION for JDK 8 
Reviewed-by: mr, katleman
 2011-06-13 12:17:14 -07:00
Jim Holmlund
089c11bb9b 7052782: Two langtools regression tests fail due to fix for 7034977 which removed the invokeGeneric method 
Change the tests to call invoke instead of invokeGeneric

Reviewed-by: jrose, mcimadamore
 2011-06-09 09:13:50 -07:00
Lana Steuck
e9d626d5ec Merge 2011-06-02 13:38:55 -07:00
Joe Darcy
42cb36b770 7025784: Add SourceVersion.RELEASE_8 
7025786: Add -source 8 and -target 8 to javac
7025789: Change javac source and target default to 8

Reviewed-by: jjg
 2011-06-01 23:56:31 -07:00
Jonathan Gibbons
8df816992b 7042623: Regression: javac silently crash when attributing non-existent annotation 
Reviewed-by: mcimadamore
 2011-06-01 11:25:50 -07:00
David Katleman
f1744917be 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles 
Reviewed-by: ohair, trims
 2011-05-25 13:32:10 -07:00
Maurizio Cimadamore
fa196116c7 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface 
Types.implementation forces unnecessary symbol completion on superinterfaces of a given type

Reviewed-by: jjg
 2011-05-23 11:55:55 +01:00
Maurizio Cimadamore
1ee0f8da66 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor 
Attributing a constructor call does not clean up the compiler's attribution context

Reviewed-by: jjg
 2011-05-16 09:38:04 +01:00
Maurizio Cimadamore
568387fe02 7041730: Regression: compiler accepts invalid cast from int to Byte 
Implementation of cast conversion rules between primitive and boxed types is too liberal

Reviewed-by: jjg
 2011-05-11 13:12:11 +02:00
Maurizio Cimadamore
d3d252186b 7042566: Regression: new ambiguity between varargs method 
Erroneous ambiguity error when choosing most specific varargs method

Reviewed-by: jjg
 2011-05-11 13:10:57 +02:00
Maurizio Cimadamore
fbecf91f80 7040883: Compilation error: "length in Array is defined in an inaccessible class or interface" 
Fix of 7034511 (now backed out) is causing spurious accessibility errors

Reviewed-by: jjg
 2011-05-02 12:05:41 +01:00
Maurizio Cimadamore
fcbd7a77c4 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments 
Diamond should be disallowed in cases where explicit generic constructor parameters are specified

Reviewed-by: jjg
 2011-04-30 11:57:46 +01:00
Maurizio Cimadamore
ea2c9e0af0 6550655: com.sun.tools.javac.code.Symbol$CompletionFailure 
Accessing a non-existing enum constant from an annotation whose class is available results in an internal error

Reviewed-by: jjg
 2011-04-29 16:06:28 +01:00
Maurizio Cimadamore
7fb85c5cef 7034495: Javac asserts on usage of wildcards in bounds 
Problem with intersection types and wildcards causing javac to crash

Reviewed-by: jjg
 2011-04-29 16:05:56 +01:00
Maurizio Cimadamore
e7081dbf6a 7039937: Improved catch analysis fails to handle a common idiom in the libraries 
Disable generation of 'unreachable catch' warnings for catch statements catching Exception/Throwable

Reviewed-by: jjg
 2011-04-29 16:05:29 +01:00
Maurizio Cimadamore
f7618cbf97 7040104: javac NPE on Object a[]; Object o = (a=null)[0]; 
When a null literal is found on top of stack, if expected type is 1-dimension array no checkcast is emitted

Reviewed-by: jjg
 2011-04-29 16:05:02 +01:00
Jonathan Gibbons
e29746adb0 7029150: Project Coin: present union types from the tree API through to javax.lang.model 
Reviewed-by: mcimadamore
 2011-04-28 15:05:36 -07:00
Joe Darcy
90c0a645c2 7039822: Project Coin: add explicit tests for the lub of an exception parameter 
Reviewed-by: mcimadamore, jjg
 2011-04-27 17:03:24 -07:00
Jonathan Gibbons
59b6650614 7038363: cast from object to primitive should be for source >= 1.7 
Reviewed-by: mcimadamore
 2011-04-25 15:56:09 -07:00
Jonathan Gibbons
94164d4b45 7039019: test cannot run standalone 
Reviewed-by: dlsmith
 2011-04-25 15:50:30 -07:00
Maurizio Cimadamore
95e14306e7 7036906: Scope: CompoundScope.getElements() doesn't pass scope filter to subscopes 
CompoundScope.getElements() is not filtering elements according to the ScopeFilter argument

Reviewed-by: jjg
 2011-04-19 13:57:25 +01:00
Lana Steuck
a498249cfa Merge 2011-04-17 16:23:22 -07:00
Kelly O'Hair
39cd646f25 Merge 2011-04-13 16:57:22 -07:00
Maurizio Cimadamore
02daeca60e 7034019: ClassCastException in javac with conjunction types 
Resolve.mostSpecific doesn't handle case of raw override

Reviewed-by: dlsmith
 2011-04-12 20:58:06 -07:00
Maurizio Cimadamore
c46387423a 7034511: Loophole in typesafety 
Type-variable substutution takes upper bound of replaced captured type-variable

Reviewed-by: dlsmith
 2011-04-12 20:56:16 -07:00
Kelly O'Hair
b49579c56c 7033660: Update copyright year to 2011 on any files changed in 2011 
Reviewed-by: dholmes
 2011-04-06 20:33:44 -07:00
Kumar Srinivasan
e3d10322c1 7028405: (javac) remove unused JSR-292 code 
Reviewed-by: jrose, mcimadamore
 2011-04-03 17:00:50 -07:00
Maurizio Cimadamore
be712a0152 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource 
Missing name check before calling MethodSymbol.overrides causes wrong warnings to be issued

Reviewed-by: jjg
 2011-04-01 12:30:13 +01:00
Jonathan Gibbons
ce0e6ca247 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build 
Reviewed-by: darcy, mcimadamore
 2011-03-30 18:18:11 -07:00
Maurizio Cimadamore
acf788aa1f 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException 
Javac should warn about use/declaration of AutoCloseable subclasses that can throw InterruptedException

Reviewed-by: jjg
 2011-03-29 16:41:18 +01:00
Maurizio Cimadamore
bd9526ecbe 7030150: Type inference for generic instance creation failed for formal type parameter 
Problem when explicit generic constructor type-arguments are used in conjunction with diamond

Reviewed-by: jjg
 2011-03-29 16:40:51 +01:00
Maurizio Cimadamore
bc3a1c60ef 7030606: Project-coin: multi-catch types should be pairwise disjoint 
Bring javac in sync with latest Project Coin EDR

Reviewed-by: jjg
 2011-03-29 16:40:31 +01:00
Maurizio Cimadamore
0a0b5a7a8a 7030687: Diamond: compiler accepts erroneous code where diamond is used with non-generic inner class 
Diamond accepts non-parameterized member inner classes with parameterized outer because of a bad check

Reviewed-by: jjg
 2011-03-29 16:40:07 +01:00
Jonathan Gibbons
f36dc58a6f 6437138: JSR 199: Compiler doesn't diagnose crash in user code 
6482554: uncaught exception from annotation processor not reported through JavaCompiler.CompilationTask.call

Reviewed-by: mcimadamore
 2011-03-25 07:58:53 -07:00
Jonathan Gibbons
7be50d11b1 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies 
Reviewed-by: mcimadamore
 2011-03-24 16:14:30 -07:00
Jonathan Gibbons
cc992b27bf 6930508: Passing nested class names on javac command line interfere with subsequent name -> class lookup 
Reviewed-by: darcy
 2011-03-16 17:21:52 -07:00
Kumar Srinivasan
733707ac37 7026359: (langtools) fix big jar test 
Reviewed-by: jjg
 2011-03-16 09:41:30 -07:00
Maurizio Cimadamore
eb4e1b86cd 6558548: The compiler needs to be aligned with clarified specification of throws 
Javac should issue unconditional warnings when 'dead' catch clauses are detected

Reviewed-by: jjg
 2011-03-16 11:12:26 +00:00
Jonathan Gibbons
a4b1b99eb0 6988079: Errors reported via Messager.printMessage(ERROR,"error message") are not tallied correctly 
Reviewed-by: darcy
 2011-03-15 11:48:55 -07:00
Jonathan Gibbons
d52a948474 6987384: -XprintProcessorRoundsInfo message printed with different timing than previous 
Reviewed-by: darcy
 2011-03-15 11:41:21 -07:00
Jonathan Gibbons
13d31713dc 6993311: annotations on packages are not validated 
Reviewed-by: mcimadamore
 2011-03-15 11:04:56 -07:00
Jonathan Gibbons
8f64aeabe2 7026509: Cannot use JavaCompiler to create multiple CompilationTasks for partial compilations 
Reviewed-by: mcimadamore
 2011-03-14 11:48:41 -07:00
Jonathan Gibbons
593927cf2d 7010608: the string 'error' should appear in error messages 
Reviewed-by: mcimadamore
 2011-03-14 11:42:15 -07:00
Jonathan Gibbons
c2e4376861 7026414: Types.asElement() returns null for ErrorType 
Reviewed-by: darcy
 2011-03-14 11:33:33 -07:00
Maurizio Cimadamore
bb05a1437c 7025988: Test test/tools/javac/file/zip/T6836682.java takes too long to complete 
Added @ignore tag to temporarily disable the test

Reviewed-by: jjg
 2011-03-09 16:47:39 +00:00
Kumar Srinivasan
aa60df6782 7021927: javac: regression in performance 
Reviewed-by: jjg
 2011-03-07 17:39:42 -08:00
Jonathan Gibbons
f71b78ced3 6980021: javac should document @file command line option 
Reviewed-by: mcimadamore
 2011-03-07 13:45:06 -08:00
Maurizio Cimadamore
409b9b8d25 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes 
Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR)

Reviewed-by: jjg
 2011-03-07 14:31:50 +00:00
Jan Lahoda
ddaf77107d 7024568: Very long method resolution causing OOM error 
Resolve.findMethod scans same receiver type more than once in certain inheritance graphs

Reviewed-by: jjg
 2011-03-07 14:11:48 +00:00
Maurizio Cimadamore
7b3d32182e 7024212: TestWarnErrorCount fails 
TestWarnErrorCount should be executed with -Xlint:all,-path to avoid spurious failures

Reviewed-by: jjg
 2011-03-03 18:05:52 +00:00
Maurizio Cimadamore
f416cac815 7022054: Invalid compiler error on covariant overriding methods with the same erasure 
Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6

Reviewed-by: jjg
 2011-03-03 17:34:58 +00:00
Maurizio Cimadamore
291f04e8c0 7023703: Valid code doesn't compile 
Leftovers cause problems when analyzing loops in Flow.java

Reviewed-by: jjg
 2011-03-03 17:32:35 +00:00
Maurizio Cimadamore
df9296f567 7023233: False positive for -Xlint:try with nested try with resources blocks 
Wrong lint warning issued about unused resource when nested try-with-resource blocks are found

Reviewed-by: jjg
 2011-03-03 09:43:24 +00:00
Jonathan Gibbons
f78030e4f1 6639645: Modeling type implementing missing interfaces 
Reviewed-by: darcy, mcimadamore
 2011-03-02 21:13:55 -08:00
Jonathan Gibbons
ed6677cbba 6986892: confusing warning given after errors in annotation processing 
Reviewed-by: darcy
 2011-03-02 21:06:17 -08:00
Jonathan Gibbons
6c7b14a762 6986895: compiler gives misleading message for no input files 
Reviewed-by: darcy
 2011-03-02 14:03:38 -08:00
Maurizio Cimadamore
45e06252b7 6541876: "Enclosing Instance" error new in 1.6 
Unqualified 'this' should not be selected in a qualified super() call in a default constructor

Reviewed-by: jjg
 2011-03-02 10:56:39 +00:00
Jonathan Gibbons
5fd6eeaa54 7021183: 269: assertion failure getting enclosing element of an undefined name 
Reviewed-by: mcimadamore
 2011-03-01 12:00:06 -08:00
Jonathan Gibbons
36ed816102 7022711: compiler crash in try-with-resources 
Reviewed-by: mcimadamore
 2011-02-28 13:42:24 -08:00
Jonathan Gibbons
148841e5e1 7022741: warning counts are wrong after anno processing 
Reviewed-by: mcimadamore
 2011-02-28 13:37:48 -08:00
Jonathan Gibbons
56d963bdf6 7022337: repeated warnings about bootclasspath not set 
Reviewed-by: mcimadamore
 2011-02-28 12:19:18 -08:00
Maurizio Cimadamore
1683dd4109 7015715: lub gets stuck on type with complex supertype 
Lub should not scan supertypes unnecessarily

Reviewed-by: jjg, dlsmith
 2011-02-28 11:50:56 +00:00
Maurizio Cimadamore
32216fc797 7015430: Incorrect thrown type determined for unchecked invocations 
Thrown types do not get updated after 15.12.2.8, and do not get erased as per 15.12.2.6

Reviewed-by: jjg, dlsmith
 2011-02-28 11:48:53 +00:00
Jonathan Gibbons
78ebde094c 7022310: test/tools/javac/diags/Example: args added twice 
Reviewed-by: mcimadamore
 2011-02-25 12:19:00 -08:00
Jonathan Gibbons
a51962066d 7021650: fix Context issues 
Reviewed-by: mcimadamore
 2011-02-25 12:09:33 -08:00
Jim Holmlund
6d172a6a63 7018753: tools/javac/varargs/warning/Warn5.java times out on slow machines 
Use a single file manager for all JavacTasks

Reviewed-by: jjg, mcimadamore
 2011-02-24 08:40:49 -08:00
Maurizio Cimadamore
7186448cfe 7019631: issues in test headers in b130 
Fix to test headers not containing correct bug ID

Reviewed-by: jjg
 2011-02-23 14:17:08 +00:00
Maurizio Cimadamore
1ae687fbd2 7020657: Javac rejects a fairly common idiom with raw override and interfaces 
Name clash should not be reported if subinterface/implementing class resolves the clash by defining common overrider

Reviewed-by: jjg
 2011-02-23 14:16:12 +00:00
Joe Darcy
dc728d5d5a 7020047: Project Coin: generate null-check around try-with-resources close call 
Reviewed-by: jjg
 2011-02-18 15:55:20 -08:00
Maurizio Cimadamore
0f41147166 7020626: diamond: add diagnostic test for diamond and non-generic classes 
Fix failure in regression test CheckExamples

Reviewed-by: jjg
 2011-02-18 16:17:44 +00:00
Kumar Srinivasan
3b676c4925 7018859: javac turn off the Zip optimization by default 
Reviewed-by: jjg
 2011-02-18 08:12:06 -08:00
Maurizio Cimadamore
7d8c3e9460 7020043: Project Coin: diamond allowed on non-generic type 
Diamond oerator should be disallowed on non-generic class types (i.e. String)

Reviewed-by: jjg
 2011-02-18 12:28:49 +00:00
Maurizio Cimadamore
dd20e6fdd7 7017104: improve error reporting for uncaught/undeclared exceptions from try-with-resources 
Twr should generate better error message when uncaught exceptions are thrown by implicit call of close() method

Reviewed-by: jjg
 2011-02-15 11:51:04 +00:00
Maurizio Cimadamore
77f10a1c5f 7017664: Add listeners infrastracture to javac scopes 
Add listeners to javac scopes, added CompoundScope and correct invalidation logic for ImplementationCache

Reviewed-by: jjg
 2011-02-15 11:49:46 +00:00
Kelly O'Hair
511e9c3dcb 7008433: Minor copyright changes 
Reviewed-by: jjg
 2011-02-14 14:27:47 -08:00
Jonathan Gibbons
710ec9f95d 6505047: javax.lang.model.element.Element.getEnclosingElement() doesn't return null for type parameter 
Reviewed-by: darcy
 2011-02-11 17:10:26 -08:00
Jonathan Gibbons
caf0257075 6485027: javac incorrectly handles relative paths in manifest classpath 
Reviewed-by: mcimadamore
 2011-02-10 15:05:33 -08:00
Jonathan Gibbons
1406a86c7d 7018098: CacheFSInfo persists too long 
Reviewed-by: mcimadamore
 2011-02-10 14:24:26 -08:00
Jonathan Gibbons
a71eecc4f7 7016750: tools/javac/nio/CompileTest failing in nightly test 
Reviewed-by: mcimadamore
 2011-02-09 14:04:53 -08:00
Maurizio Cimadamore
dfec6e2301 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123 
Override clash algorithm is not implemented correctly

Reviewed-by: jjg
 2011-02-07 18:10:13 +00:00
Maurizio Cimadamore
f4daf3d7bf 7014715: javac returns different error code for certain failure(s) 
Javac silently crashes when emitting certain kinds of resolution diagnostics

Reviewed-by: jjg
 2011-02-03 09:38:19 +00:00
Maurizio Cimadamore
536bd08692 6969184: poor error recovery after symbol not found 
Generic type-well formedness check should ignore erroneous symbols

Reviewed-by: jjg
 2011-02-03 09:37:28 +00:00
Maurizio Cimadamore
6ded62c828 5017953: spurious cascaded diagnostics when name not found 
When an operator is applied to one or more erroneous operands, spurious diagnostics are generated

Reviewed-by: jjg
 2011-02-03 09:36:28 +00:00
Maurizio Cimadamore
79d1b7b1e1 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable 
Lint warnings generated during MemberEnter might ignore @SuppressWarnings annotations

Reviewed-by: jjg
 2011-02-03 09:35:21 +00:00
Joe Darcy
9be3c0f789 6961571: Update visitors to support ARM's ElementKind.RESOURCE_VARIABLE 
Reviewed-by: jjg
 2011-02-01 10:11:05 -08:00
Joe Darcy
ba98ee427f 7014734: Project Coin: Allow optional trailing semicolon to terminate resources list in try-with-resources 
Reviewed-by: jjg
 2011-01-31 19:06:32 -08:00
Alan Bateman
434b2147c7 Merge 2011-01-28 12:36:34 +00:00
Maurizio Cimadamore
15959fbf11 6838943: inference: javac is not handling type-variable substitution properly 
Free type-variables are being replaced with type-variables bound to forall type leading to unsoundness

Reviewed-by: jjg, dlsmith
 2011-01-28 12:06:21 +00:00
Maurizio Cimadamore
1e776bc78a 6313164: javac generates code that fails byte code verification for the varargs feature 
Method applicability check should fail if formal varargs element type is not accessible

Reviewed-by: jjg
 2011-01-28 12:03:49 +00:00
Maurizio Cimadamore
6647b73cc8 6910550: javac 1.5.0_17 fails with incorrect error message 
Multiple clashing members declared in same class should be added to the class' scope in order to avoid downstream spurious diagnostics

Reviewed-by: jjg
 2011-01-28 12:01:07 +00:00
Alan Bateman
68c23b7878 7006126: (fs) Updates to file system API (1/2011) 
Reviewed-by: jjg
 2011-01-28 09:25:20 +00:00
Jim Holmlund
50d526442a 7015482: jtreg test tools/javac/diags/MessageInfo.java fails when test/ dir is not in langtools repo 
Don't fail if the needed file isn't present, if running under jtreg.

Reviewed-by: jjg
 2011-01-28 00:09:38 -08:00
Jonathan Gibbons
de3bde6688 7013272: Automatically generate info about how compiler resource keys are used 
Reviewed-by: mcimadamore
 2011-01-26 13:45:25 -08:00
Jonathan Gibbons
a184b53cec 6554097: "final" confuses @SuppressWarnings 
Reviewed-by: mcimadamore
 2011-01-26 11:20:19 -08:00
Joe Darcy
ec50779b72 7013420: Project Coin: remove general expression support from try-with-resources statement 
Reviewed-by: mcimadamore, jjg
 2011-01-25 17:02:56 -08:00
Jonathan Gibbons
bcf09ec04f 6988106: javac report 'java.lang.IllegalMonitorStateException' 
Reviewed-by: ksrini
 2011-01-24 16:38:56 -08:00
Jonathan Gibbons
1ab227adc4 6581775: Fix the white space problem in javac shell tests 
Reviewed-by: mcimadamore
 2011-01-24 16:34:25 -08:00
Jonathan Gibbons
1d1fd8962d 6963934: JCCompilationUnit.getImports does not report all imports 
Reviewed-by: mcimadamore
 2011-01-24 16:17:33 -08:00
Maurizio Cimadamore
6bd5b48ca7 7013865: varargs: javac crashes during overload resolution with generic varargs 
Fixed regression with varargs overload resolution that leads javac to crash

Reviewed-by: jjg
 2011-01-24 15:45:41 +00:00
Maurizio Cimadamore
96d0749bfc 6569633: Varargs: parser error when varargs element type is an array 
Explicit error message when old-style array syntax is mixed with varargs

Reviewed-by: jjg
 2011-01-24 15:45:24 +00:00
Maurizio Cimadamore
13ecf26ded 6510286: Wording of javac error for inner classes 
'inner classes cannot have static declarations' message needs to be reworked

Reviewed-by: jjg
 2011-01-24 15:45:06 +00:00
Maurizio Cimadamore
b77effad6c 6968793: issues with diagnostics 
Several diagnostic improvements

Reviewed-by: jjg
 2011-01-24 15:44:51 +00:00
Maurizio Cimadamore
df54c56a04 6943278: spurious error message for inference and type-variable with erroneous bound 
Type-inference should ignore erroneous bounds

Reviewed-by: jjg
 2011-01-24 15:44:15 +00:00
Jonathan Gibbons
9a6afb10e4 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris) 
Reviewed-by: mcimadamore
 2011-01-14 11:45:19 -08:00
Maurizio Cimadamore
0dae258b02 6949040: java.dyn package must be compiled with -target 7 or better 
Issue error (rather than warning) when @PolymorphicSignature is found and target < 7

Reviewed-by: jjg
 2011-01-14 09:46:44 +00:00
Maurizio Cimadamore
ede9924b4e 7007432: Test generic types well-formedness 
Add a new kind of check (well-formedness of generic type w.r.t. declared bounds) in the type-harness

Reviewed-by: jjg
 2011-01-14 09:45:52 +00:00
Maurizio Cimadamore
7d90979693 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls 
Special syntax to denote indy return type through type parameters should be removed (and cast shall be used instead)

Reviewed-by: jjg, jrose
 2011-01-14 09:45:04 +00:00
Jonathan Gibbons
e66871ae10 6430241: Hard to disable symbol file feature through API 
Reviewed-by: mcimadamore
 2011-01-13 11:48:10 -08:00
Jonathan Gibbons
12f8b2493e 6993305: starting position of a method without modifiers and with type parameters is incorrect 
Reviewed-by: mcimadamore
 2011-01-11 08:05:28 -08:00
Jonathan Gibbons
43e78a8d44 6992999: fully remove JSR 308 from langtools 
Reviewed-by: mcimadamore
 2011-01-10 14:57:59 -08:00
Maurizio Cimadamore
21c037bb9b 7010194: several langtools regression failures after JSR 292 changes (b123) 
Some regression tests rely on unsupported JSR 292 features

Reviewed-by: jjg
 2011-01-05 09:59:01 +00:00
Lana Steuck
34c5f24321 Merge 2011-01-04 17:10:35 -08:00
Kelly O'Hair
84b5875f26 6962318: Update copyright year 
Reviewed-by: xdono
 2010-12-28 15:54:52 -08:00
Jim Holmlund
4157467833 6982992: Tests CheckAttributedTree.java, JavacTreeScannerTest.java, and SourceTreeeScannerTest.java timeout 
Hoist some invariant code out of a loop

Reviewed-by: ksrini
 2010-12-23 12:29:21 -08:00
Kumar Srinivasan
5032fcd7b5 6567415: Neverending loop in ClassReader 
Reviewed-by: jjg
 2010-12-18 09:38:39 -08:00
Jonathan Gibbons
facb1c1b6d 7006564: NPE in javac running test/tools/javac/nio/compileTest/CompileTest.java 
Reviewed-by: mcimadamore, alanb
 2010-12-15 06:39:51 -08:00
Jonathan Gibbons
cfe2f7eb5d 6999891: DefaultFileManager incorrect 
Reviewed-by: darcy
 2010-12-14 14:17:20 -08:00
Maurizio Cimadamore
6ef5228632 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings 
Reviewed-by: jjg, darcy
 2010-12-13 15:11:00 -08:00
Maurizio Cimadamore
ecb30ce139 7006109: Add test library to simplify the task of writing automated type-system tests 
Types.java needs to be more stress-tested

Reviewed-by: jjg
 2010-12-13 14:56:50 +00:00
Jonathan Gibbons
1ce40f31dd 6504896: TreeMaker.Literal(Object) does not support Booleans 
Reviewed-by: mcimadamore
 2010-12-10 07:38:28 -08:00
Maurizio Cimadamore
450d85b95a 6199075: Unambiguous varargs method calls flagged as ambiguous 
Javac does not implement overload resolution w.r.t. varargs methods as described in the JLS

Reviewed-by: jjg
 2010-12-10 15:24:17 +00:00
Maurizio Cimadamore
ba8f15cef1 7005671: Regression: compiler accepts invalid cast from X[] to primitive array 
Regression in type conversion after 292 changes

Reviewed-by: jjg
 2010-12-10 15:23:42 +00:00
Jonathan Gibbons
cc42fec255 6985202: no access to doc comments from Tree API 
Reviewed-by: mcimadamore
 2010-12-09 08:48:08 -08:00
Jonathan Gibbons
3244279bb2 4917091: javac rejects array over 128 in length 
Reviewed-by: mcimadamore
 2010-12-09 08:24:42 -08:00
Maurizio Cimadamore
d2e437cb96 7005371: Multicatch: assertion error while generating LocalVariableTypeTable attribute 
Compiler crashes with assertion error if '-g' option is passed and source contains multicatch

Reviewed-by: jjg
 2010-12-09 15:50:57 +00:00
Maurizio Cimadamore
929d3fd3f5 6476118: compiler bug causes runtime ClassCastException for generics overloading 
Compiler allows bridge methods to override unrelated method

Reviewed-by: jjg
 2010-12-09 15:50:34 +00:00
Maurizio Cimadamore
e8d1ae243d 7005095: Cast: compile reject sensible cast from final class to interface 
A previous fix to cast conversion has made the compiler too strict w.r.t. final cast

Reviewed-by: jjg
 2010-12-09 15:50:10 +00:00
Jonathan Gibbons
8e9c506c6c 6999210: javac should be able to warn of anomalous conditions in classfiles 
Reviewed-by: mcimadamore, darcy
 2010-12-07 14:13:25 -08:00
Maurizio Cimadamore
5cdc149cc1 5088429: varargs overloading problem 
Compiler implementation for overload resolution w/ varargs method does not match JLS

Reviewed-by: jjg
 2010-12-06 11:51:02 +00:00
Maurizio Cimadamore
47f6d8a95e 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list 
Attribution should check each component of a disjunctive type separately, rather than checking the corresponding lub()

Reviewed-by: jjg
 2010-12-06 11:50:37 +00:00
Maurizio Cimadamore
63f05334a6 7003744: Compiler error concerning final variables 
Flow analysis does not cleanup init/uninint bit masks after for-loop

Reviewed-by: jjg
 2010-12-06 11:49:00 +00:00
Maurizio Cimadamore
8644a0bc46 7002837: Diamond: javac generates diamond inference errors when in 'finder' mode 
Javac should disable error messages when analyzing instance creation expression in 'diamond finder' mode

Reviewed-by: jjg
 2010-12-03 16:32:31 +00:00
Maurizio Cimadamore
7613f7a72c 6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass 
Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in Lower

Reviewed-by: jjg
 2010-12-03 16:31:23 +00:00
Per Bothner
e07cc985e8 7004029: intermittent failures compiling pack200 
Remove "bogus" entries from star-import scopes

Reviewed-by: mcimadamore
 2010-12-02 16:37:23 -08:00
Jonathan Gibbons
be8a607fef 6900037: javac should warn if earlier -source is used and bootclasspath not set 
Reviewed-by: darcy
 2010-11-29 14:15:36 -08:00
Maurizio Cimadamore
3e65664acf 6995200: JDK 7 compiler crashes when type-variable is inferred from expected primitive type 
15.12.2.8 should use boxing when expected type in assignment context is a primitive type

Reviewed-by: jjg
 2010-11-23 11:08:43 +00:00
Jonathan Gibbons
bdc7e81168 6999438: remove support for exotic identifiers from JDK 7 
Reviewed-by: mcimadamore
 2010-11-18 16:13:11 -08:00
Maurizio Cimadamore
80fdc078e7 6999635: Multicatch: crash while compiling simple code with a multicatch parameter 
Missing erasure when computing stackmaps leads to assertion error

Reviewed-by: darcy
 2010-11-15 14:41:21 +00:00
Maurizio Cimadamore
3a681162e4 6985719: Alike methods in interfaces (Inheritance and Overriding) 
Javac should report error when interface inherits unrelated method with same erasure

Reviewed-by: jjg
 2010-11-15 13:50:53 +00:00
Joe Darcy
f9f932a9f3 6991528: Support making Throwable.suppressedExceptions immutable 
Reviewed-by: mcimadamore
 2010-11-14 07:16:46 -08:00
Maurizio Cimadamore
64789c2491 6970016: Clean up ARM/try-with-resources implementation 
Changed Xlint option name from -Xlint:arm to -Xlint:try

Reviewed-by: jjg
 2010-11-12 12:34:18 +00:00
Maurizio Cimadamore
bb03754fd1 6999067: cast for invokeExact call gets redundant cast to <type> warnings 
Xlint:cast should not report cast used in order to specify target type in polymorphic signature calls

Reviewed-by: jjg
 2010-11-12 12:33:52 +00:00
Maurizio Cimadamore
8f61f3fcff 6598108: com.sun.source.util.Trees.isAccessible incorrect 
JavacTrees' version of isAccessible should take into account enclosing class accessibility

Reviewed-by: jjg
 2010-11-12 12:32:43 +00:00
Maurizio Cimadamore
83fb083bfa 6996914: Diamond inference: problem when accessing protected constructor 
Special resolution scheme for diamond inference needs to open up protected constructors in anon inner class creation

Reviewed-by: jjg
 2010-11-10 12:37:25 +00:00
Jonathan Gibbons
1546b42862 6997958: test tools/javac/api/T6412669.java fails in PIT 
Reviewed-by: darcy
 2010-11-09 17:49:24 -08:00
Per Bothner
aa4bee613c 6998063: new Scope impl to fix Scope performance issues 
Reviewed-by: jjg
 2010-11-06 13:53:48 -07:00
Maurizio Cimadamore
e202a05c38 6714835: Safe cast is rejected (with warning) by javac 
Rules for unchecked cast conversion do not take into account type-containment

Reviewed-by: jjg
 2010-11-04 12:58:29 +00:00
Maurizio Cimadamore
d4d5f60edc 6993963: Project Coin: Use precise exception analysis for effectively final catch parameters 
More precise rethrow analysis should be extended to effectively-final exception parameters. Multicatch parameters should be made implicitly final.

Reviewed-by: jjg, darcy
 2010-11-04 12:57:48 +00:00
Maurizio Cimadamore
9b7bc21bb0 6939780: add a warning to detect diamond sites 
Added hidden compiler flag '-XDfindDiamond' to detect 'diamondifiable' sites

Reviewed-by: jjg
 2010-11-02 12:01:35 +00:00
Maurizio Cimadamore
ac9f97939f 6996415: Override bridges causes compiler-generated code to end up with synthetic infinite loop 
Temporarily disable fix for override bridges (6337171)

Reviewed-by: jjg
 2010-11-02 12:00:54 +00:00
Jonathan Gibbons
49e996e3c1 6994946: option to specify only syntax errors as unrecoverable 
Reviewed-by: darcy, mcimadamore
 2010-10-28 18:58:43 -07:00
Jonathan Gibbons
35cc8afcf9 6993301: catch parameters do not have correct kind (i.e. ElementKind.EXCEPTION_PARAMETER) 
Reviewed-by: mcimadamore
 2010-10-22 14:04:33 -07:00
Jonathan Gibbons
bf00a77f2d 6987760: remove 308 support from JDK7 
Reviewed-by: darcy, mcimadamore
 2010-10-19 15:02:48 -07:00
Maurizio Cimadamore
4e9ee94a4d 6991980: polymorphic signature calls don't share the same CP entries 
Wrong use of attr env in Infer.java prevents sharing of CP entries for PS calls

Reviewed-by: darcy, jrose
 2010-10-18 19:14:36 +01:00
Jonathan Gibbons
b4b4ed03ec 6908476: test/tools/javac/T6705935.java fails if non-zip files found on platform class path 
Reviewed-by: darcy
 2010-10-12 14:47:51 -07:00
Jonathan Gibbons
3f57abb0ba 6988407: javac crashes running processor on errant code; it used to print error message 
Reviewed-by: darcy
 2010-10-12 13:15:46 -07:00
Jonathan Gibbons
1da6aa89d2 6990379: two examples fail under CheckExamples on Windows 
Reviewed-by: darcy
 2010-10-07 15:26:32 -07:00
Jonathan Gibbons
5967ec228d 6988836: A new JavacElements is created for each round of annotation processing 
Reviewed-by: darcy
 2010-10-05 11:34:43 -07:00
Joe Darcy
4231c49495 6983738: Use a JavacTestingAbstractProcessor 
Reviewed-by: jjg
 2010-09-29 23:27:57 -07:00
Jonathan Gibbons
ef791d4adb 6502392: Invalid relative names for Filer.createResource and Filer.getResource 
Reviewed-by: darcy
 2010-09-29 14:01:37 -07:00
Athijegannathan Sundararajan
55a531c45f 6967842: Element not returned from tree API for ARM resource variables 
Reviewed-by: jjg, darcy
 2010-09-28 22:46:36 +05:30
Jonathan Gibbons
95a1a60964 6986246: Trees object is round-specific 
Reviewed-by: darcy
 2010-09-27 17:28:49 -07:00
Jonathan Gibbons
2730836d77 6877202: Elements.getDocComment() is not getting JavaDocComments 
6861094: javac -Xprint <file> does not print comments
6985205: access to tree positions and doc comments may be lost across annotation processing rounds

Reviewed-by: darcy
 2010-09-27 14:20:39 -07:00
Lana Steuck
78db31beb6 Merge 2010-09-25 12:02:32 -07:00
Athijegannathan Sundararajan
28c94557eb 6587674: NoClassdefFound when anonymously extending a class 
Reviewed-by: jjg, mcimadamore
 2010-09-22 20:53:34 +05:30
Maurizio Cimadamore
05fb73163c 6863465: javac doesn't detect circular subclass dependencies via qualified names 
Class inheritance circularity check should look at trees, not just symbols

Reviewed-by: jjg
 2010-09-18 14:24:09 -07:00
Maurizio Cimadamore
cd3371e702 5088624: cannot find symbol message should be more intelligent 
Resolve.java should keep track of all candidates found during a method resolution sweep to generate more meaningful diagnostics

Reviewed-by: jjg
 2010-09-18 09:56:23 -07:00
Lana Steuck
dc37688eb9 Merge 2010-09-16 11:20:36 -07:00
Jonathan Gibbons
e0caf9f660 6985115: tests create too much output 
Reviewed-by: mcimadamore
 2010-09-16 09:57:37 -07:00
Jonathan Gibbons
1144807f1f 6985181: Annotations lost from classfile 
Reviewed-by: mcimadamore
 2010-09-16 09:56:25 -07:00
Kelly O'Hair
fd65dbfc50 6982137: Rebranding pass 2 - missed copyright changes 
Reviewed-by: mbykov
 2010-09-09 16:29:40 -07:00
Jonathan Gibbons
949983f6b0 6983239: TreeScanner does not scan default value for method 
Reviewed-by: mcimadamore
 2010-09-09 13:31:28 -07:00
Athijegannathan Sundararajan
a5aa8a0943 6900149: IllegalStateException when compiling same files and DiagnosticListener is set 
Reviewed-by: jjg
 2010-09-09 09:42:45 +05:30
Maurizio Cimadamore
4da9c57770 6970584: Flow.java should be more error-friendly 
Added a post-attribution visitor that fixup uninitialized types/symbol in AST after erroneous attribution

Reviewed-by: jjg
 2010-09-07 17:33:43 +01:00
Maurizio Cimadamore
c1ac5e8862 6981185: com.sun.tools.model.JavacTypes.contains() calls Type.contains instead of Types.containsType 
Wrong implementation is causing trivial containment tests to fail unexpectedly (when such tests are executed using compiler API)

Reviewed-by: jjg
 2010-09-07 17:32:52 +01:00
John Rose
cd74d63c12 6979327: method handle invocation should use casts instead of type parameters to specify return type 
Infer return type for polymorphic signature calls according to updated JSR 292 draft

Reviewed-by: jjg
 2010-09-07 17:32:27 +01:00
Maurizio Cimadamore
73825fc885 6337171: javac should create bridge methods when type variable bounds restricted 
Javac should add synthetic overrides for inherited abstract methods in order to preserve binary compatibility

Reviewed-by: jjg
 2010-09-07 17:31:54 +01:00
Jonathan Gibbons
c09fe5cafb 6930507: Symbols for anonymous and local classes made too late for use by java tree API 
Reviewed-by: mcimadamore
 2010-09-06 12:55:09 -07:00
Athijegannathan Sundararajan
977ad1ae6a 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7 
Reviewed-by: jjg
 2010-09-03 12:36:43 +05:30
Athijegannathan Sundararajan
60cf6eb1de 6458823: Messager messages on TypeParamterElements to not include position information 
Reviewed-by: jjg
 2010-09-03 11:25:43 +05:30
Jonathan Gibbons
753b8d0fea 6921495: spurious semicolons in class def cause empty NOPOS blocks 
Reviewed-by: mcimadamore
 2010-09-02 18:26:21 -07:00
Athijegannathan Sundararajan
183a7b7797 6458749: TypeParameterElement.getEnclosedElements throws NPE within javac 
Reviewed-by: jjg
 2010-09-02 23:10:05 +05:30
John R Rose
ca3dbff3f8 6979683: inconsistent interaction of reference cast with box/unbox conversions leaves out a useful case 
Allow casts which narrow and then unbox.

Reviewed-by: mcimadamore
 2010-09-01 03:19:16 -07:00
Jonathan Gibbons
0930f81131 6403465: javac should defer diagnostics until it can be determined they are persistent 
Reviewed-by: mcimadamore, darcy
 2010-08-30 18:03:35 -07:00
Jonathan Gibbons
e96eb944c2 6980707: Reduce use of IOException in JavaCompiler 
Reviewed-by: darcy
 2010-08-27 17:59:08 -07:00