removed ThreadCounter from TypeUnifyTask

src/main/java/de/dhbwstuttgart/core/JavaTXCompiler.java

@@ -89,8 +89,8 @@ public class JavaTXCompiler {
 	}
     public JavaTXCompiler(List<File> sources, List<File> contextPath) throws IOException, ClassNotFoundException {
     	//statistics = new FileWriter(new File(System.getProperty("user.dir") + "/" + sources.get(0).getName() + "_"+ new Timestamp(System.currentTimeMillis())));
-		statistics = new OutputStreamWriter(new NullOutputStream());
-    	statistics.write("test");
+    	statistics = new OutputStreamWriter(new NullOutputStream());
+		statistics.write("test");
         if(contextPath == null || contextPath.isEmpty()){
         	//When no contextPaths are given, the working directory is the sources root
 			contextPath = Lists.newArrayList(new File(System.getProperty("user.dir")));

src/main/java/de/dhbwstuttgart/typeinference/unify/RuleSet.java

@@ -9,7 +9,6 @@ import java.util.Optional;
 import java.util.Queue;
 import java.util.Set;
 import java.util.Stack;
-import java.util.concurrent.ForkJoinPool;
 import java.util.function.Function;
 import java.util.stream.Collectors;
 
@@ -45,14 +44,14 @@ import org.apache.commons.io.output.NullOutputStream;
  */
 public class RuleSet implements IRuleSet{
 	
-	WriterActiveObject logFile;
+	Writer logFile;
 	
 	public RuleSet() {
 		super();
-		logFile = new WriterActiveObject(new OutputStreamWriter(new NullOutputStream()), ForkJoinPool.commonPool());
+		logFile = new OutputStreamWriter(new NullOutputStream());
 	}
 	
-	RuleSet(WriterActiveObject logFile) {
+	RuleSet(Writer logFile) {
 		this.logFile = logFile;
 	}
 	
@@ -868,8 +867,14 @@ public class RuleSet implements IRuleSet{
         								   UnifyType r = x.getRhsType();
         								   if (r instanceof PlaceholderType) { ((PlaceholderType)r).disableWildcardtable(); }
 								     } );
-		logFile.write("FUNgreater: " + pair + "\n");
-		logFile.write("FUNred: " + result + "\n");
+		try {
+			logFile.write("FUNgreater: " + pair + "\n");
+				logFile.write("FUNred: " + result + "\n");
+				logFile.flush();
+			}
+		catch (IOException e) {
+			System.out.println("logFile-Error");
+		}
 		return Optional.of(result);
 	}
 	
@@ -912,10 +917,14 @@ public class RuleSet implements IRuleSet{
 									   UnifyType r = x.getRhsType();
 									   if (r instanceof PlaceholderType) { ((PlaceholderType)r).disableWildcardtable(); }
 									 } );
-
-		logFile.write("FUNgreater: " + pair + "\n");
-		logFile.write("FUNgreater: " + result + "\n");
-
+		try {
+			logFile.write("FUNgreater: " + pair + "\n");
+			logFile.write("FUNgreater: " + result + "\n");
+			logFile.flush();
+		}
+	catch (IOException e) {
+		System.out.println("lofFile-Error");
+	}
 		return Optional.of(result);
 	}
 
@@ -958,9 +967,14 @@ public class RuleSet implements IRuleSet{
 		   							   UnifyType r = x.getRhsType();
 		   							   if (r instanceof PlaceholderType) { ((PlaceholderType)r).disableWildcardtable(); }
 									 } );
-
-		logFile.write("FUNgreater: " + pair + "\n");
-		logFile.write("FUNsmaller: " + result + "\n");
+		try {
+			logFile.write("FUNgreater: " + pair + "\n");
+			logFile.write("FUNsmaller: " + result + "\n");
+			logFile.flush();
+		}
+	catch (IOException e) {
+		System.out.println("lofFile-Error");
+	}
 		return Optional.of(result);
 	}
 

src/main/java/de/dhbwstuttgart/typeinference/unify/TypeUnify.java

@@ -1,13 +1,19 @@
 package de.dhbwstuttgart.typeinference.unify;
 
+import java.io.FileWriter;
 import java.io.IOException;
 import java.io.Writer;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Set;
 import java.util.concurrent.ForkJoinPool;
 
+import de.dhbwstuttgart.core.JavaTXCompiler;
 import de.dhbwstuttgart.typeinference.constraints.Constraint;
+import de.dhbwstuttgart.typeinference.constraints.ConstraintSet;
+import de.dhbwstuttgart.typeinference.constraints.Pair;
 import de.dhbwstuttgart.typeinference.unify.interfaces.IFiniteClosure;
+import de.dhbwstuttgart.typeinference.unify.model.FiniteClosure;
 import de.dhbwstuttgart.typeinference.unify.model.UnifyPair;
 
 public class TypeUnify {
@@ -24,8 +30,8 @@ public class TypeUnify {
 	 * @return
 	 */
 	public Set<Set<UnifyPair>> unify(Set<UnifyPair> undConstrains, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, Writer logFile, Boolean log, UnifyResultModel ret, UnifyTaskModel usedTasks) {
-		ForkJoinPool pool = new ForkJoinPool(Runtime.getRuntime().availableProcessors(), ForkJoinPool.defaultForkJoinWorkerThreadFactory, null, true);
-		TypeUnifyTask unifyTask = new TypeUnifyTask(undConstrains, oderConstraints, fc, true, new WriterActiveObject(logFile, pool), log, 0, ret, usedTasks, pool);
+		TypeUnifyTask unifyTask = new TypeUnifyTask(undConstrains, oderConstraints, fc, true, logFile, log, 0, ret, usedTasks);
+		ForkJoinPool pool = new ForkJoinPool();
 		pool.invoke(unifyTask);
 		Set<Set<UnifyPair>> res =  unifyTask.join();
 		try {
@@ -50,8 +56,8 @@ public class TypeUnify {
 	 * @return
 	 */
 	public UnifyResultModel unifyAsync(Set<UnifyPair> undConstrains, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, Writer logFile, Boolean log, UnifyResultModel ret, UnifyTaskModel usedTasks) {
-		ForkJoinPool pool = new ForkJoinPool(Runtime.getRuntime().availableProcessors(), ForkJoinPool.defaultForkJoinWorkerThreadFactory, null, true);
-		TypeUnifyTask unifyTask = new TypeUnifyTask(undConstrains, oderConstraints, fc, true, new WriterActiveObject(logFile, pool), log, 0, ret, usedTasks, pool);
+		TypeUnifyTask unifyTask = new TypeUnifyTask(undConstrains, oderConstraints, fc, true, logFile, log, 0, ret, usedTasks);
+		ForkJoinPool pool = new ForkJoinPool();
 		pool.invoke(unifyTask);
 		return ret;
 	}
@@ -68,17 +74,16 @@ public class TypeUnify {
 	 * @return
 	 */
 	public UnifyResultModel unifyParallel(Set<UnifyPair> undConstrains, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, Writer logFile, Boolean log, UnifyResultModel ret, UnifyTaskModel usedTasks) {
-		ForkJoinPool pool = new ForkJoinPool(Runtime.getRuntime().availableProcessors(), ForkJoinPool.defaultForkJoinWorkerThreadFactory, null, true);
 		TypeUnifyTask unifyTask = //new TypeUnifyTask(undConstrains, oderConstraints, fc, true, logFile, log, 0, ret, usedTasks);
-				new TypeUnifyTask(undConstrains, oderConstraints, fc, true, new WriterActiveObject(logFile, pool), log, 0, ret, usedTasks, pool, statistics);
-
+				new TypeUnifyTask(undConstrains, oderConstraints, fc, true, logFile, log, 0, ret, usedTasks, statistics);
+		ForkJoinPool pool = new ForkJoinPool();
 		pool.invoke(unifyTask);
 		Set<Set<UnifyPair>> res =  unifyTask.join();
 		try {
 			logFile.write("\nnoShortendElements: " + unifyTask.noShortendElements +"\n");
 			logFile.flush();
-			unifyTask.statisticsFile.write("Backtracking: " + unifyTask.noBacktracking);
-			unifyTask.statisticsFile.write("\nLoops: " + unifyTask.noLoop);
+			unifyTask.statistics.write("Backtracking: " + unifyTask.noBacktracking);
+			unifyTask.statistics.write("\nLoops: " + unifyTask.noLoop);
 		}
 		catch (IOException e) {
 			System.err.println("no log-File");
@@ -105,8 +110,8 @@ public class TypeUnify {
 	 * @return
 	 */
 	public Set<Set<UnifyPair>> unifyOderConstraints(Set<UnifyPair> undConstrains, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, Writer logFile, Boolean log, UnifyResultModel ret, UnifyTaskModel usedTasks) {
-		TypeUnifyTask unifyTask = new TypeUnifyTask(undConstrains, oderConstraints, fc, false, new WriterActiveObject(logFile, ForkJoinPool.commonPool()), log, 0, ret, usedTasks, ForkJoinPool.commonPool());
-		unifyTask.statisticsFile = statistics;
+		TypeUnifyTask unifyTask = new TypeUnifyTask(undConstrains, oderConstraints, fc, false, logFile, log, 0, ret, usedTasks);
+		unifyTask.statistics = statistics;
 		Set<Set<UnifyPair>> res = unifyTask.compute();
 		try {
 			logFile.write("\nnoShortendElements: " + unifyTask.noShortendElements +"\n");

src/main/java/de/dhbwstuttgart/typeinference/unify/TypeUnify2Task.java

@@ -7,7 +7,6 @@ import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
-import java.util.concurrent.ForkJoinPool;
 
 import de.dhbwstuttgart.typeinference.constraints.Constraint;
 import de.dhbwstuttgart.typeinference.constraints.ConstraintSet;
@@ -21,17 +20,17 @@ public class TypeUnify2Task extends TypeUnifyTask {
        Set<UnifyPair> methodSignatureConstraintUebergabe;
 
        //statistics
-       TypeUnify2Task(Set<Set<UnifyPair>> setToFlatten, Set<UnifyPair> eq,
-                      List<Set<Constraint<UnifyPair>>> oderConstraints,
-                      Set<UnifyPair> nextSetElement,
-                      IFiniteClosure fc, boolean parallel, WriterActiveObject logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks,
-                      Set<UnifyPair> methodSignatureConstraintUebergabe, ForkJoinPool pool, Writer statistics) {
-    	   this(setToFlatten, eq, oderConstraints, nextSetElement, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, methodSignatureConstraintUebergabe, pool );
+       TypeUnify2Task(Set<Set<UnifyPair>> setToFlatten, Set<UnifyPair> eq, 
+    		   List<Set<Constraint<UnifyPair>>> oderConstraints, 
+    		   Set<UnifyPair> nextSetElement, 
+    		   IFiniteClosure fc, boolean parallel, Writer logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks, 
+    		   Set<UnifyPair> methodSignatureConstraintUebergabe, Writer statistics) {
+    	   this(setToFlatten, eq, oderConstraints, nextSetElement, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, methodSignatureConstraintUebergabe );
     	   
        }
        
-       public TypeUnify2Task(Set<Set<UnifyPair>> setToFlatten, Set<UnifyPair> eq, List<Set<Constraint<UnifyPair>>> oderConstraints, Set<UnifyPair> nextSetElement, IFiniteClosure fc, boolean parallel, WriterActiveObject logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks, Set<UnifyPair> methodSignatureConstraintUebergabe, ForkJoinPool pool) {
-               super(eq, oderConstraints, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, pool);
+       public TypeUnify2Task(Set<Set<UnifyPair>> setToFlatten, Set<UnifyPair> eq, List<Set<Constraint<UnifyPair>>> oderConstraints, Set<UnifyPair> nextSetElement, IFiniteClosure fc, boolean parallel, Writer logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks, Set<UnifyPair> methodSignatureConstraintUebergabe) {
+               super(eq, oderConstraints, fc, parallel, logFile, log, rekTiefe, urm, usedTasks);
                this.setToFlatten = setToFlatten;
                this.nextSetElement = nextSetElement;
                this.methodSignatureConstraintUebergabe = methodSignatureConstraintUebergabe;
@@ -65,10 +64,13 @@ public class TypeUnify2Task extends TypeUnifyTask {
        	}
        
        public void closeLogFile() {
-           if(parallel){
-               logFile.close();
-           }else{
-               logFile.closeNonThreaded();
-           }
+
+           try {
+				logFile.close();
+			}
+			catch (IOException ioE) {
+				System.err.println("no log-File" + thNo);
+			}
+           
        }
 }

src/main/java/de/dhbwstuttgart/typeinference/unify/TypeUnifyTask.java

@@ -18,12 +18,17 @@ import java.util.concurrent.RecursiveTask;
 import java.util.function.BiFunction;
 import java.util.function.BinaryOperator;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import org.apache.commons.io.output.NullOutputStream;
 
+import de.dhbwstuttgart.core.JavaTXCompiler;
 import de.dhbwstuttgart.exceptions.TypeinferenceException;
 import de.dhbwstuttgart.parser.NullToken;
+import de.dhbwstuttgart.syntaxtree.factory.UnifyTypeFactory;
 import de.dhbwstuttgart.typeinference.constraints.Constraint;
+import de.dhbwstuttgart.typeinference.constraints.ConstraintSet;
+import de.dhbwstuttgart.typeinference.result.ResultSet;
 import de.dhbwstuttgart.typeinference.unify.interfaces.IFiniteClosure;
 import de.dhbwstuttgart.typeinference.unify.interfaces.IMatch;
 import de.dhbwstuttgart.typeinference.unify.interfaces.IRuleSet;
@@ -43,7 +48,7 @@ import de.dhbwstuttgart.typeinference.unify.model.UnifyType;
 import de.dhbwstuttgart.typeinference.unify.model.WildcardType;
 import de.dhbwstuttgart.util.Pair;
 import de.dhbwstuttgart.typeinference.unify.model.OrderingUnifyPair;
-import org.apache.commons.io.output.NullWriter;
+import de.dhbwstuttgart.core.JavaTXCompiler;
 
 import java.io.File;
 import java.io.FileWriter;
@@ -51,6 +56,9 @@ import java.io.IOException;
 import java.io.OutputStreamWriter;
 import java.io.Writer;
 
+import com.google.common.collect.Ordering;
+import org.apache.commons.io.output.NullWriter;
+
 
 /**
  * Implementation of the type unification algorithm
@@ -72,15 +80,13 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 	 * Fuer die Threads
 	 */
 	UnifyResultModel urm;
-	protected static int noOfThread = 0;
 	private static int totalnoOfThread = 0;
 	int thNo;
 	protected boolean one = false;
-	Integer MaxNoOfThreads = 128;
 
 	public static final String rootDirectory = System.getProperty("user.dir")+"/test/logFiles/";
-	protected WriterActiveObject logFile;
-	protected ForkJoinPool pool;
+	Writer logFile;
+
 	/**
 	 * The implementation of setOps that will be used during the unification
 	 */
@@ -129,7 +135,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 	
 	volatile UnifyTaskModel usedTasks;
 	
-	static Writer statisticsFile = new NullWriter();
+	static Writer statistics;
 	
 	public TypeUnifyTask() { 
 		rules = new RuleSet();
@@ -150,11 +156,15 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 	*/
 	
 	//statistics
-	public TypeUnifyTask(Set<UnifyPair> eq, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, boolean parallel, WriterActiveObject logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks, ForkJoinPool pool, Writer statisticsFile) {
-		this(eq,oderConstraints,  fc,  parallel,  logFile,  log,  rekTiefe,  urm,  usedTasks, pool);
-		this.statisticsFile = statisticsFile;
+	public TypeUnifyTask(Set<UnifyPair> eq, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, boolean parallel, Writer logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks, Writer statistics) {
+		this(eq,oderConstraints,  fc,  parallel,  logFile,  log,  rekTiefe,  urm,  usedTasks);
+		this.statistics = statistics;
 	}
-	public TypeUnifyTask(Set<UnifyPair> eq, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, boolean parallel, WriterActiveObject logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks, ForkJoinPool pool) {
+	public TypeUnifyTask(Set<UnifyPair> eq, List<Set<Constraint<UnifyPair>>> oderConstraints, IFiniteClosure fc, boolean parallel, Writer logFile, Boolean log, int rekTiefe, UnifyResultModel urm, UnifyTaskModel usedTasks) {
+		synchronized (this) {
+            if(statistics==null){
+                statistics = new NullWriter();
+            }
 			this.eq = eq;
 			//this.oderConstraints = oderConstraints.stream().map(x -> x.stream().map(y -> new HashSet<>(y)).collect(Collectors.toSet(HashSet::new))).collect(Collectors.toList(ArrayList::new));
 			this.oderConstraintsField = oderConstraints; /*.stream().map(x -> {
@@ -173,19 +183,15 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 			this.parallel = parallel;
 			this.logFile = logFile;
 			this.log = log;
-			this.pool = pool;
-			
-			noOfThread++; 
+
 			totalnoOfThread++;
 			//writeLog("thNo1 " + thNo);
 			thNo = totalnoOfThread;
 			writeLog("thNo2 " + thNo);
 			try {
-				if(log){
-					this.logFile = new WriterActiveObject(new FileWriter(new File(System.getProperty("user.dir") + "/logFiles/" + "Thread_"+thNo)), pool);
-				}else{
-					this.logFile = new WriterActiveObject(new OutputStreamWriter(new NullOutputStream()), pool);
-				}
+				this.logFile = log ? new FileWriter(new File(System.getProperty("user.dir") + "/logFiles/" + "Thread_"+thNo))
+			                       : new OutputStreamWriter(new NullOutputStream());
+				logFile.write("");
 			}
 			catch (IOException e) { 
 				System.err.println("log-File nicht vorhanden");
@@ -209,6 +215,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 			this.urm = urm;
 			this.usedTasks = usedTasks;
 			this.usedTasks.add(this);
+		}
 	}
 	
 	/**
@@ -265,14 +272,12 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				.filter(x -> x.size()>1)
 				.collect(Collectors.toCollection(ArrayList::new));
 		Set<Set<UnifyPair>> res = unify(neweq, remainingOderconstraints, fc, parallel, rekTiefeField, new HashSet<>());
-		noOfThread--;
-
-		if(parallel){
+		try {
 			logFile.close();
-		}else{
-			logFile.closeNonThreaded();
 		}
-
+		catch (IOException ioE) {
+			System.err.println("no log-File");
+		}
 		if (isUndefinedPairSetSet(res)) { 
 			//fuer debug-Zwecke
 			ArrayList al = res.stream().map(x -> x.stream().collect(Collectors.toCollection(ArrayList::new)))
@@ -382,8 +387,8 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 		
 		eq0.forEach(x -> x.disableCondWildcards());
 		
-		writeLog(nOfUnify.toString() + " Unifikation nach applyTypeUnificationRules: " + eq.toString() + "\n"
-				+ nOfUnify.toString() + " Oderconstraints nach applyTypeUnificationRules: " + oderConstraints.toString());
+		writeLog(nOfUnify.toString() + " Unifikation nach applyTypeUnificationRules: " + eq.toString());
+        writeLog(nOfUnify.toString() + " Oderconstraints nach applyTypeUnificationRules: " + oderConstraints.toString());
 
 		/*
 		 * Step 2 and 3: Create a subset eq1s of pairs where both sides are TPH and eq2s of the other pairs
@@ -442,8 +447,8 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 		if(!undefinedPairs.isEmpty()) {
 			noUndefPair++;
 			for (UnifyPair up : undefinedPairs) {
-				writeLog(noUndefPair.toString() + " UndefinedPairs; " + up + "\n"
-					+ "BasePair; " + up.getBasePair());
+				writeLog(noUndefPair.toString() + " UndefinedPairs; " + up);
+				writeLog("BasePair; " + up.getBasePair());
 			}
 			Set<Set<UnifyPair>> error = new HashSet<>();
 			undefinedPairs = undefinedPairs.stream().map(x -> { x.setUndefinedPair(); return x;}).collect(Collectors.toCollection(HashSet::new));
@@ -810,8 +815,8 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 			 */
 			List<Set<UnifyPair>> nextSetasListOderConstraints = new ArrayList<>();
 			
-			writeLog("nextSet: " + nextSet.toString() + "\n"
-				+ "nextSetasList: " + nextSetasList.toString());
+			writeLog("nextSet: " + nextSet.toString());
+			writeLog("nextSetasList: " + nextSetasList.toString());
 			
 			/* staistics Nextvar an Hand Varianzbestimmung auskommentieren Anfang 
 			if (variance == 1) {
@@ -921,7 +926,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 			/* Wenn parallel gearbeitet wird, wird je nach Varianz ein neuer Thread
 			 * gestartet, der parallel weiterarbeitet.
 			 */
-			if(parallel && (variance == 1) && noOfThread <= MaxNoOfThreads) {
+			if(parallel && (variance == 1)) {
 				Set<TypeUnify2Task> forks = new HashSet<>();
 				Set<UnifyPair> newEqOrig = new HashSet<>(eq);
 				Set<Set<UnifyPair>> newElemsOrig = new HashSet<>(elems);
@@ -929,7 +934,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				newElemsOrig.add(a);
 				
 				/* FORK ANFANG */
-				TypeUnify2Task forkOrig = new TypeUnify2Task(newElemsOrig, newEqOrig, newOderConstraintsOrig, a, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, methodSignatureConstraint, this.pool);
+				TypeUnify2Task forkOrig = new TypeUnify2Task(newElemsOrig, newEqOrig, newOderConstraintsOrig, a, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, methodSignatureConstraint);
 				//forks.add(forkOrig);
 				synchronized(usedTasks) {
 					if (this.myIsCancelled()) {
@@ -938,15 +943,16 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 					forkOrig.fork();
 				}
 				/* FORK ENDE */
-
-				writeLog("a in " + variance + " "+ a + "\n" +
-				"nextSetasListRest: " + nextSetasListRest.toString());
-
+				
+				synchronized (this) {
+					writeLog("a in " + variance + " "+ a);
+					writeLog("nextSetasListRest: " + nextSetasListRest.toString());
+				}
 				while (!nextSetasList.isEmpty()) {
 					Set<UnifyPair> nSaL = nextSetasList.remove(0);
-					//nextSetasList.remove(nSaL);
-					writeLog("1 RM" + nSaL.toString());
-
+					synchronized (this) { //nextSetasList.remove(nSaL);
+						writeLog("1 RM" + nSaL.toString());
+					}
 					
 					if (!oderConstraint) {
 						
@@ -966,7 +972,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 					Set<Set<UnifyPair>> newElems = new HashSet<>(elems);
 					List<Set<Constraint<UnifyPair>>> newOderConstraints = new ArrayList<>(oderConstraints);
 					newElems.add(nSaL);
-					TypeUnify2Task fork = new TypeUnify2Task(newElems, newEq, newOderConstraints, nSaL, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint), this.pool);
+					TypeUnify2Task fork = new TypeUnify2Task(newElems, newEq, newOderConstraints, nSaL, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint));
 					forks.add(fork);
 					synchronized(usedTasks) {
 						if (this.myIsCancelled()) {
@@ -978,48 +984,49 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				//res = unify2(newElemsOrig, newEqOrig, newOderConstraintsOrig, fc, parallel, rekTiefe);
 				
 				/* FORK ANFANG */
-
-				writeLog("wait "+ forkOrig.thNo);
-				noOfThread--;
-				res = forkOrig.join();
-				synchronized (usedTasks) {
-					if (this.myIsCancelled()) {
-						return new HashSet<>();
-					}
-				}
-				//noOfThread++;
-				forkOrig.writeLog("final Orig 1");
-				forkOrig.closeLogFile();
-				//Set<Set<UnifyPair>> fork_res = forkOrig.join();
-				writeLog("JoinOrig " + new Integer(forkOrig.thNo).toString());
-				//noOfThread--; an das Ende von compute verschoben
-				//add_res.add(fork_res);
-				/* FORK ENDE */
-				
-				forks.forEach(x -> writeLog("wait: " + x.thNo));
-				for(TypeUnify2Task fork : forks) {
-					noOfThread--;
-					Set<Set<UnifyPair>> fork_res = fork.join();
+				synchronized (this) {
+					writeLog("wait "+ forkOrig.thNo);
+					res = forkOrig.join();
 					synchronized (usedTasks) {
 						if (this.myIsCancelled()) {
 							return new HashSet<>();
 						}
 					}
 					//noOfThread++;
-					//noOfThread--; an das Ende von compute verschoben
-					writeLog("Join " + new Integer(fork.thNo).toString() + "\n" +
-					"fork_res: " + fork_res.toString() + "\n" +
-					new Boolean((isUndefinedPairSetSet(fork_res))).toString());
-					add_res.add(fork_res);
-					if (!isUndefinedPairSetSet(fork_res)) {
-						aParDef.add(fork.getNextSetElement());
-					}
-					fork.writeLog("final 1");
-					fork.closeLogFile();
+					forkOrig.writeLog("final Orig 1");
+					forkOrig.closeLogFile();
+					//Set<Set<UnifyPair>> fork_res = forkOrig.join();
+					writeLog("JoinOrig " + new Integer(forkOrig.thNo).toString());
+					//noOfThread--; an das Ende von compute verschoben 
+					//add_res.add(fork_res);
+				};
+				/* FORK ENDE */
+				
+				forks.forEach(x -> writeLog("wait: " + x.thNo));
+				for(TypeUnify2Task fork : forks) {
+					synchronized (this) {
+						Set<Set<UnifyPair>> fork_res = fork.join();
+						synchronized (usedTasks) {
+							if (this.myIsCancelled()) {
+								return new HashSet<>();
+							}
+						}
+						//noOfThread++;
+						writeLog("Join " + new Integer(fork.thNo).toString());
+						//noOfThread--; an das Ende von compute verschoben
+						writeLog("fork_res: " + fork_res.toString());
+						writeLog(new Boolean((isUndefinedPairSetSet(fork_res))).toString());
+						add_res.add(fork_res);
+						if (!isUndefinedPairSetSet(fork_res)) {
+							aParDef.add(fork.getNextSetElement());
+						}
+						fork.writeLog("final 1");
+						fork.closeLogFile();
+					};
 				}
 				//noOfThread++;
 			} else {
-			if(parallel && (variance == -1) && noOfThread <= MaxNoOfThreads) {
+			if(parallel && (variance == -1)) {
 				Set<TypeUnify2Task> forks = new HashSet<>();
 				Set<UnifyPair> newEqOrig = new HashSet<>(eq);
 				Set<Set<UnifyPair>> newElemsOrig = new HashSet<>(elems);
@@ -1027,7 +1034,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				newElemsOrig.add(a);
 				
 				/* FORK ANFANG */
-				TypeUnify2Task forkOrig = new TypeUnify2Task(newElemsOrig, newEqOrig, newOderConstraintsOrig, a, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint), this.pool);
+				TypeUnify2Task forkOrig = new TypeUnify2Task(newElemsOrig, newEqOrig, newOderConstraintsOrig, a, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint));
 				//forks.add(forkOrig);
 				synchronized(usedTasks) {
 					if (this.myIsCancelled()) {
@@ -1037,14 +1044,15 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				}
 				/* FORK ENDE */
 				
-
-				writeLog("a in " + variance + " "+ a + "\n" +
-						"nextSetasListRest: " + nextSetasListRest.toString());
-
+				synchronized (this) {
+					writeLog("a in " + variance + " "+ a);
+					writeLog("nextSetasListRest: " + nextSetasListRest.toString());
+				}
 				while (!nextSetasList.isEmpty()) {
 					Set<UnifyPair> nSaL = nextSetasList.remove(0);
-					//nextSetasList.remove(nSaL);
-					writeLog("-1 RM" + nSaL.toString());
+					synchronized (this) { //nextSetasList.remove(nSaL);
+						writeLog("-1 RM" + nSaL.toString());
+					}
 					
 					if (!oderConstraint) {
 						/* statistics sameEq wird nicht betrachtet ANGFANG
@@ -1063,7 +1071,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 					Set<Set<UnifyPair>> newElems = new HashSet<>(elems);
 					List<Set<Constraint<UnifyPair>>> newOderConstraints = new ArrayList<>(oderConstraints);
 					newElems.add(nSaL);
-					TypeUnify2Task fork = new TypeUnify2Task(newElems, newEq, newOderConstraints, nSaL, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint), this.pool);
+					TypeUnify2Task fork = new TypeUnify2Task(newElems, newEq, newOderConstraints, nSaL, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint));
 					forks.add(fork);
 					synchronized(usedTasks) {
 						if (this.myIsCancelled()) {
@@ -1075,48 +1083,49 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				//res = unify2(newElemsOrig, newEqOrig, newOderConstraintsOrig, fc, parallel, rekTiefe);
 				
 				/* FORK ANFANG */
-				writeLog("wait "+ forkOrig.thNo);
-				noOfThread--;
-				res = forkOrig.join();
-				synchronized (usedTasks) {
-					if (this.myIsCancelled()) {
-						return new HashSet<>();
-					}
-				}
-				//noOfThread++;
-				forkOrig.writeLog("final Orig -1");
-				forkOrig.closeLogFile();
-				//Set<Set<UnifyPair>> fork_res = forkOrig.join();
-				writeLog("JoinOrig " + new Integer(forkOrig.thNo).toString());
-				//noOfThread--; an das Ende von compute verschoben
-				//add_res.add(fork_res);
-				/* FORK ENDE */
-				
-				forks.forEach(x -> writeLog("wait: " + x.thNo));
-				for(TypeUnify2Task fork : forks) {
-					noOfThread--;
-					Set<Set<UnifyPair>> fork_res = fork.join();
+				synchronized (this) {
+					writeLog("wait "+ forkOrig.thNo);
+					res = forkOrig.join();
 					synchronized (usedTasks) {
 						if (this.myIsCancelled()) {
 							return new HashSet<>();
 						}
 					}
 					//noOfThread++;
-					writeLog("Join " + new Integer(fork.thNo).toString());
-					//noOfThread--; an das Ende von compute verschoben
-					writeLog("fork_res: " + fork_res.toString());
-					writeLog(new Boolean((isUndefinedPairSetSet(fork_res))).toString());
-					add_res.add(fork_res);
-					if (!isUndefinedPairSetSet(fork_res)) {
-						aParDef.add(fork.getNextSetElement());
-					}
-					fork.writeLog("final -1");
-					fork.closeLogFile();
+					forkOrig.writeLog("final Orig -1");
+					forkOrig.closeLogFile();
+					//Set<Set<UnifyPair>> fork_res = forkOrig.join();
+					writeLog("JoinOrig " + new Integer(forkOrig.thNo).toString());
+					//noOfThread--; an das Ende von compute verschoben 
+					//add_res.add(fork_res);
 				};
-
+				/* FORK ENDE */
+				
+				forks.forEach(x -> writeLog("wait: " + x.thNo));
+				for(TypeUnify2Task fork : forks) {
+					synchronized (this) {
+						Set<Set<UnifyPair>> fork_res = fork.join();
+						synchronized (usedTasks) {
+							if (this.myIsCancelled()) {
+								return new HashSet<>();
+							}
+						}
+						//noOfThread++;
+						writeLog("Join " + new Integer(fork.thNo).toString());
+						//noOfThread--; an das Ende von compute verschoben 
+						writeLog("fork_res: " + fork_res.toString());
+						writeLog(new Boolean((isUndefinedPairSetSet(fork_res))).toString());
+						add_res.add(fork_res);
+						if (!isUndefinedPairSetSet(fork_res)) {
+							aParDef.add(fork.getNextSetElement());
+						}
+						fork.writeLog("final -1");
+						fork.closeLogFile();
+					};
+				}
 				//noOfThread++;
 		    } else {
-		    if(parallel && (variance == 2) && noOfThread <= MaxNoOfThreads) {
+		    if(parallel && (variance == 2)) {
 		    	writeLog("var2einstieg");
 		    	Set<TypeUnify2Task> forks = new HashSet<>();
 		    	Set<UnifyPair> newEqOrig = new HashSet<>(eq);
@@ -1125,7 +1134,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 		    	newElemsOrig.add(a);
 				
 				/* FORK ANFANG */
-		    	TypeUnify2Task forkOrig = new TypeUnify2Task(newElemsOrig, newEqOrig, newOderConstraintsOrig, a, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint), this.pool);
+		    	TypeUnify2Task forkOrig = new TypeUnify2Task(newElemsOrig, newEqOrig, newOderConstraintsOrig, a, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, new HashSet<>(methodSignatureConstraint));
 		    	//forks.add(forkOrig);
 		    	synchronized(usedTasks) {
 					if (this.myIsCancelled()) {
@@ -1134,10 +1143,11 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 					forkOrig.fork();
 		    	}
 		    	/* FORK ENDE */
-
-				writeLog("a in " + variance + " "+ a + "\n" +
-					"nextSetasListRest: " + nextSetasListRest.toString());
-
+		    	
+		    	synchronized (this) {
+					writeLog("a in " + variance + " "+ a);
+					writeLog("nextSetasListRest: " + nextSetasListRest.toString());
+				}
 		    	while (!nextSetasList.isEmpty()) {
 		    		Set<UnifyPair> nSaL = nextSetasList.remove(0);
 		    		//nextSetasList.remove(nSaL); //PL einkommentiert 20-02-03
@@ -1145,7 +1155,7 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 		    		Set<Set<UnifyPair>> newElems = new HashSet<>(elems);
 		    		List<Set<Constraint<UnifyPair>>> newOderConstraints = new ArrayList<>(oderConstraints);
 		    		newElems.add(nSaL);
-		    		TypeUnify2Task fork = new TypeUnify2Task(newElems, newEq, newOderConstraints, nSaL, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, methodSignatureConstraint, this.pool);
+		    		TypeUnify2Task fork = new TypeUnify2Task(newElems, newEq, newOderConstraints, nSaL, fc, parallel, logFile, log, rekTiefe, urm, usedTasks, methodSignatureConstraint);
 		    		forks.add(fork);
 		    		synchronized(usedTasks) {
 						if (this.myIsCancelled()) {
@@ -1157,39 +1167,39 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 		    	//res = unify2(newElemsOrig, newEqOrig, newOderConstraintsOrig, fc, parallel, rekTiefe);
 		    	
 		    	/* FORK ANFANG */
-
-				writeLog("wait "+ forkOrig.thNo);
-				noOfThread--;
-				res = forkOrig.join();
-				synchronized (usedTasks) {
-					if (this.myIsCancelled()) {
-						return new HashSet<>();
-					}
-				}
-				//noOfThread++;
-				forkOrig.writeLog("final Orig 2");
-				forkOrig.closeLogFile();
-				//Set<Set<UnifyPair>> fork_res = forkOrig.join();
-				writeLog("JoinOrig " + new Integer(forkOrig.thNo).toString());
-				//noOfThread--; an das Ende von compute verschoben
-				//add_res.add(fork_res); //vermutlich falsch
-
-				/* FORK ENDE */
-		    	forks.forEach(x -> writeLog("wait: " + x.thNo));
-		    	for(TypeUnify2Task fork : forks) {
-					noOfThread--;
-					Set<Set<UnifyPair>> fork_res = fork.join();
+		    	synchronized (this) {
+		    		writeLog("wait "+ forkOrig.thNo);
+					res = forkOrig.join();
 					synchronized (usedTasks) {
 						if (this.myIsCancelled()) {
 							return new HashSet<>();
 						}
 					}
 					//noOfThread++;
-					writeLog("Join " + new Integer(fork.thNo).toString());
-					//noOfThread--; an das Ende von compute verschoben
-					add_res.add(fork_res);
-					fork.writeLog("final 2");
-					fork.closeLogFile();
+					forkOrig.writeLog("final Orig 2");
+					forkOrig.closeLogFile();
+					//Set<Set<UnifyPair>> fork_res = forkOrig.join();
+					writeLog("JoinOrig " + new Integer(forkOrig.thNo).toString());
+					//noOfThread--; an das Ende von compute verschoben 
+					//add_res.add(fork_res); //vermutlich falsch
+				};
+				/* FORK ENDE */
+		    	forks.forEach(x -> writeLog("wait: " + x.thNo));
+		    	for(TypeUnify2Task fork : forks) {
+		    		synchronized (this) {
+						Set<Set<UnifyPair>> fork_res = fork.join();
+						synchronized (usedTasks) {
+							if (this.myIsCancelled()) {
+								return new HashSet<>();
+							}
+						}
+						//noOfThread++;
+						writeLog("Join " + new Integer(fork.thNo).toString());
+						//noOfThread--; an das Ende von compute verschoben 
+						add_res.add(fork_res);
+						fork.writeLog("final 2");
+						fork.closeLogFile();
+					};
 				} 
 		    	//noOfThread++;	
 		    } else {//parallel = false oder MaxNoOfThreads ist erreicht, sequentiell weiterarbeiten
@@ -1518,15 +1528,15 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 				//NOCH NICHT korrekt PL 2018-10-12
 				//nextSetasList = nextSetasList.stream().filter(y -> couldBecorrect(reducedUndefResSubstGroundedBasePair, y))
 				//			.collect(Collectors.toCollection(ArrayList::new));
-				writeLog("res (undef): " + res.toString() + "\n" +
-				"abhSubst: " + abhSubst.toString() + "\n" +
-				"a2: " + rekTiefe + " " + a.toString() + "\n" +
-				"Durchschnitt: " + durchschnitt.toString() + "\n" +
-				"nextSet: " + nextSet.toString() + "\n" +
-				"nextSetasList: " + nextSetasList.toString() + "\n" +
-				"Number first erased Elements (undef): " + (len - nofstred) + "\n" +
-				"Number second erased Elements (undef): " + (nofstred- nextSetasList.size()) + "\n" +
-				"Number erased Elements (undef): " + (len - nextSetasList.size()));
+				writeLog("res (undef): " + res.toString());
+				writeLog("abhSubst: " + abhSubst.toString());
+				writeLog("a2: " + rekTiefe + " " + a.toString());
+				writeLog("Durchschnitt: " + durchschnitt.toString());
+				writeLog("nextSet: " + nextSet.toString());
+				writeLog("nextSetasList: " + nextSetasList.toString());
+				writeLog("Number first erased Elements (undef): " + (len - nofstred));
+				writeLog("Number second erased Elements (undef): " + (nofstred- nextSetasList.size()));
+				writeLog("Number erased Elements (undef): " + (len - nextSetasList.size()));
 				noAllErasedElements = noAllErasedElements + (len - nextSetasList.size());
 				writeLog("Number of all erased Elements (undef): " + noAllErasedElements.toString());
 				noBacktracking++;
@@ -1986,10 +1996,10 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 			}
 		}
 		
-		writeLog("eq2s: " + eq2s.toString() + "\n" +
-		"eq2sAsListFst: " + eq2sAsListFst.toString() + "\n" +
-		"eq2sAsListSnd: " + eq2sAsListSnd.toString() + "\n" +
-		"eq2sAsListBack: " + eq2sAsListBack.toString());
+		writeLog("eq2s: " + eq2s.toString());
+		writeLog("eq2sAsListFst: " + eq2sAsListFst.toString());
+		writeLog("eq2sAsListSnd: " + eq2sAsListSnd.toString());
+		writeLog("eq2sAsListBack: " + eq2sAsListBack.toString());
 		
 		eq2sAsList.addAll(eq2sAsListFst);
 		eq2sAsList.addAll(eq2sAsListSnd);
@@ -2594,33 +2604,33 @@ public class TypeUnifyTask extends RecursiveTask<Set<Set<UnifyPair>>>  {
 	}
 	
 	void writeLog(String str) {
+		synchronized ( this ) { 
 		if (log && finalresult) {
-			if(parallel){
-				logFile.write("Thread no.:" + thNo + "\n"
-						+ "noOfThread:" + noOfThread + "\n"
-						+ "parallel:" + parallel + "\n"
-						+ str+"\n\n"
-				);
-			}else{
-				logFile.writeNonThreaded("Thread no.:" + thNo + "\n"
-						+ "noOfThread:" + noOfThread + "\n"
-						+ "parallel:" + parallel + "\n"
-						+ str+"\n\n"
-				);
+			try {
+				logFile.write("Thread no.:" + thNo + "\n");
+				logFile.write("parallel:" + parallel + "\n");
+				logFile.write(str+"\n\n");
+				logFile.flush();
+			
 			}
-		}
+			catch (IOException e) { 
+				System.err.println("kein LogFile");
+			}
+			}
+	}
 	}
 	
 	void writeStatistics(String str) {
 		if (finalresult) {
+		synchronized ( this ) { 
 			try {
-				statisticsFile.write("Thread No. " + thNo + ": " + str + "\n");
-				statisticsFile.flush();
+				statistics.write("Thread No. " + thNo + ": " + str + "\n");
+				statistics.flush();
 			
 			}
 			catch (IOException e) { 
 				System.err.println("kein StatisticsFile");
 			}
-	}
+	}}
 	}
 }

src/main/java/de/dhbwstuttgart/typeinference/unify/WriterActiveObject.java

@@ -1,53 +0,0 @@
-package de.dhbwstuttgart.typeinference.unify;
-
-import java.io.IOException;
-import java.io.Writer;
-import java.util.concurrent.ForkJoinPool;
-
-public class WriterActiveObject {
-    private Writer writer;
-    private ForkJoinPool pool;
-
-    public WriterActiveObject(Writer writer, ForkJoinPool pool){
-        this.writer = writer;
-        this.pool = pool;
-    }
-
-    public void close(){
-        pool.execute(()->{
-            try {
-                writer.close();
-            } catch (IOException e) {
-                System.out.println(e.getMessage());
-            }
-        });
-    }
-
-    public void write(String message){
-        pool.execute(()->{
-            try {
-                writer.write(message);
-                writer.flush();
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            }
-        });
-    }
-
-    public void writeNonThreaded(String message){
-        try {
-            writer.write(message);
-            writer.flush();
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
-    }
-
-    public void closeNonThreaded(){
-        try {
-            writer.close();
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
-    }
-}

src/test/java/typeinference/UnifyTest.java

@@ -1,13 +1,8 @@
 package typeinference;
 
-import com.google.common.base.Optional;
 import de.dhbwstuttgart.bytecode.genericsGeneratorTypes.GenericGenratorResultForSourceFile;
 import de.dhbwstuttgart.core.JavaTXCompiler;
-import de.dhbwstuttgart.parser.scope.JavaClassName;
-import de.dhbwstuttgart.syntaxtree.ClassOrInterface;
-import de.dhbwstuttgart.syntaxtree.Constructor;
 import de.dhbwstuttgart.syntaxtree.SourceFile;
-import de.dhbwstuttgart.syntaxtree.factory.UnifyTypeFactory;
 import de.dhbwstuttgart.syntaxtree.visual.ASTPrinter;
 import de.dhbwstuttgart.syntaxtree.visual.ASTTypePrinter;
 import de.dhbwstuttgart.typedeployment.TypeInsert;
@@ -95,7 +90,7 @@ public class UnifyTest {
         IFiniteClosure finiteClosure = new FiniteClosure(constraints, new NullWriter());
 
         TypeUnify unifyAlgo = new TypeUnify();
-        ConstraintSet< Pair> cons = new ConstraintSet<>();
+        ConstraintSet<Pair> cons = new ConstraintSet<>();
         UnifyResultModel urm = new UnifyResultModel(cons, finiteClosure);
         UnifyTaskModel tasks = new UnifyTaskModel();
         Set<Set<UnifyPair>> solution = unifyAlgo.unify(undConstraints, oderConstraints, finiteClosure, new NullWriter(), false, urm, tasks);