Commit Graph

284 Commits

Author SHA1 Message Date
Dmitry Samersoff
4d6a0655f9 7133122: SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not
Replace PT_LOAD segment with library segment when necessary

Reviewed-by: dholmes, sla
2013-09-22 18:49:09 +04:00
Niclas Adlertz
afef481831 Merge 2013-09-19 18:01:39 +02:00
Christian Thalinger
4fa99b3fc5 8024760: add more types, fields and constants to VMStructs
Reviewed-by: kvn, coleenp
2013-09-13 16:55:44 -07:00
Stefan Johansson
86624d96d7 8024176: [macosx] gc/metaspace/ClassMetaspaceSizeInJmapHeap.java failed since jdk8b105, hs25b47
The code for reading compressed klass pointers in the sa-agent on Mac used readCompOopAddress instead of readCompKlassAddress, this is wrong but has been hidden because compressed oops and compressed klasses has used the same base address in the past.

Reviewed-by: sla, jmasa
2013-09-11 08:57:02 +02:00
Vladimir Kozlov
1a700c9216 Merge 2013-09-05 11:04:39 -07:00
Jiangli Zhou
033640bd2c 8023477: Invalid CP index when reading ConstantPool
Need to check for 0 case for InstanceKlass::_generic_signature_index.

Reviewed-by: sspitsyn, sla
2013-08-26 13:32:14 -04:00
Erik Helin
30f059b5fc 8015107: NPG: Use consistent naming for metaspace concepts
Reviewed-by: coleenp, mgerdin, hseigel
2013-08-12 17:37:02 +02:00
Vladimir Kozlov
1619c53530 Merge 2013-08-16 16:23:01 -07:00
Dmitry Samersoff
68198af05c 8019396: SA-JDI OSThread class initialization throws an exception
Method sun.jvm.hotspot.runtime.OSThread.initialize throws a sun.jvm.hotspot.types.WrongTypeException

Reviewed-by: dholmes, mgerdin
2013-08-06 14:28:48 +04:00
Kevin Walls
655fbf4cb1 8021444: SA: ClassDump.run() should not ignore existing ClassFilter
Reviewed-by: minqi, poonam
2013-08-05 10:27:31 +01:00
Yunda
65d83871e2 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__"
Reviewed-by: sla, sundar, kmo
2013-07-23 14:32:37 +02:00
Jiangli Zhou
9fab0cfa1b Merge 2013-08-20 00:48:55 -07:00
Jiangli Zhou
553b498f51 8021948: Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool indexes
Change InstanceKlass::_source_file_name and _generic_signature to u2 fields.

Reviewed-by: coleenp, iklam
2013-08-19 14:59:54 -04:00
Kevin Walls
a40e2a9236 8022655: ClassDump ignored jarStream setting
Reviewed-by: minqi, sla
2013-08-19 14:28:58 +01:00
Rickard Bäckman
cd450988cc Merge 2013-08-09 18:05:00 +02:00
Niclas Adlertz
bfe8385fa9 8022284: Hide internal data structure in PhaseCFG
Hide private node to block mapping using public interface

Reviewed-by: kvn, roland
2013-08-07 17:56:19 +02:00
Vladimir Kozlov
ed85bb1853 Merge 2013-07-19 13:32:53 -07:00
Vladimir Kozlov
493c485dc3 Merge 2013-07-11 12:56:29 -07:00
Jiangli Zhou
b454ece6d7 7133260: AllocationProfiler uses space in metadata and doesn't seem to do anything useful
Remove -Xaprof and Klass::_alloc_count & ArrayKlass::_alloc_size.

Reviewed-by: stefank, coleenp
2013-07-03 17:26:59 -04:00
Vladimir Kozlov
b390a2d8e3 Merge 2013-06-21 15:56:24 -07:00
Goetz Lindenmaier
0522ce7a17 8016586: PPC64 (part 3): basic changes for PPC64
Added #includes needed for ppc64 port. Renamed _MODEL_ppc to _MODEL_ppc_32 and renamed corresponding old _ppc files to _ppc_32.

Reviewed-by: dholmes, kvn
2013-06-20 16:30:44 -07:00
Kevin Walls
08377de5ab 8010278: SA: provide mechanism for using an alternative SA debugger back-end
Reviewed-by: sla, dsamersoff
2013-06-26 00:01:20 +01:00
Coleen Phillimore
6ed8c8fcea 8003421: NPG: Move oops out of InstanceKlass into mirror
Inject protection_domain, signers, init_lock into java_lang_Class

Reviewed-by: stefank, dholmes, sla
2013-05-22 14:37:49 -04:00
Kevin Walls
aa8c580561 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException
Reviewed-by: sla, poonam
2013-05-16 12:40:27 +01:00
Staffan Larsen
7a1ccbc48a 8013591: compiler/ciReplay/TestSA.sh fails in nightly
Reviewed-by: coleenp, rbackman, dholmes
2013-05-08 15:37:18 +02:00
Staffan Larsen
edf88d3db7 8005038: remove crufty '_g' support from SA
Reviewed-by: coleenp, mgronlun, rbackman
2013-05-07 14:33:09 +02:00
Vladimir Kozlov
43fbbe98b7 Merge 2013-05-02 18:50:05 -07:00
Mikael Gerdin
67b238b12d Merge 2013-05-02 19:28:59 +02:00
Staffan Larsen
e8848553b1 8013364: SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause
Reviewed-by: coleenp, rbackman
2013-04-30 21:47:02 +02:00
Erik Helin
10be07bb9d 8008541: Remove old code in HotSpot that supported the jmap -permstat functionality
Reviewed-by: sla, brutisso
2013-04-30 16:36:24 +02:00
Staffan Larsen
60a56c2f06 8013466: SA crashes when attaching to a process on OS X
Reviewed-by: coleenp, rbackman, minqi
2013-04-30 10:53:58 +02:00
Igor Ignatyev
0a434e425b 8011675: adding compilation level to replay data
Reviewed-by: kvn, vlivanov
2013-04-25 11:09:24 -07:00
Jiangli Zhou
56370657b9 8010862: The Method counter fields used for profiling can be allocated lazily
Allocate the method's profiling related metadata until they are needed.

Reviewed-by: coleenp, roland
2013-04-09 17:17:41 -04:00
Peter Allwin
388d803077 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM
Reviewed-by: sspitsyn, zgu
2013-03-28 15:39:52 +01:00
Morris Meyer
8d607b2446 Merge 2013-03-21 21:48:56 -07:00
Yunda
3630c6a127 8009457: SA: A small fix on "scanoops" command in CLHSDB
Reviewed-by: sla, coleenp, kmo
2013-03-19 13:44:26 +01:00
Yunda
4fdb8216ac 8009456: SA: typeToVtbl of BasicTypeDataBase should not be static
Reviewed-by: coleenp, sla
2013-03-19 13:41:05 +01:00
Krystal Mo
d824b431de Merge 2013-03-16 21:44:52 -07:00
Yunda
f27f7d4c57 8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again
Add a missing change from JDK-7054512 so that Oop.iterateFields() works with UseCompressedKlassPointers

Reviewed-by: coleenp, roland
2013-03-15 22:07:42 -07:00
Yumin Qi
be1b5fc17e 8003348: SA can not read core file on OS
Macosx uses Mach-O file format for binary files, not ELF format. Currently SA works on core files on other platforms, t his change enables SA work on core file generated on Darwin.

Reviewed-by: sla, sspitsyn
2013-03-14 00:33:08 -07:00
Daniel D. Daugherty
f73c8f1408 Merge 2013-03-08 17:14:22 -08:00
Morris Meyer
6723fac299 Merge 2013-03-07 14:46:20 -08:00
Staffan Larsen
112317dbe3 8009287: [parfait] Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c
Reviewed-by: dholmes, kvn, mikael, morris
2013-03-05 08:50:59 +01:00
Daniel D. Daugherty
af6002665d Merge 2013-03-01 15:59:10 -08:00
Morris Meyer
4dd999e1ee 8008327: [parfait] Unitialized variable in hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m
Fix unitialized variable and return value.

Reviewed-by: kvn
2013-03-01 14:26:34 -08:00
Bengt Rutisson
02472faab5 Merge 2013-02-28 09:01:08 +01:00
Kevin Walls
37cdc7b1f8 7178741: SA: jstack -m produce UnalignedAddressException in output (Linux)
Reviewed-by: poonam, sla
2013-02-27 22:40:14 +00:00
Kevin Walls
13505fc4e5 8008807: SA: jstack crash when target has mismatched bitness (Linux)
Reviewed-by: rbackman, sla, poonam
2013-02-27 14:02:26 +00:00
Coleen Phillimore
b8b9434a9f 8000797: NPG: is_pseudo_string_at() doesn't work
Zero Symbol* for constant pool strings to indicate pseudo_strings (objects that aren't strings).  Clean up JVM_CONSTANT_Object and unused flags.

Reviewed-by: sspitsyn, jrose
2013-02-22 08:36:42 -05:00
Staffan Larsen
3e1c15cc0a 7165259: Remove BugSpot
Reviewed-by: coleenp, mgronlun
2013-02-22 10:03:02 +01:00
Staffan Larsen
5265514689 8007901: SA: Don't read flag values as constants
Reviewed-by: dholmes, mikael
2013-02-18 10:43:07 +01:00
Staffan Larsen
19f22d8bbc 8008102: SA on OS X does not stop the attached process
Reviewed-by: dholmes, rbackman
2013-02-15 08:54:12 +01:00
Staffan Larsen
bf91374f3f 8004840: Jstack seems to output unnecessary information in 7u9
Reviewed-by: dholmes, coleenp, sspitsyn, rbackman
2013-02-14 13:08:15 +01:00
Rickard Bäckman
05d4ff0383 8008088: SA can hang the VM
Reviewed-by: mgronlun, sla, dholmes
2013-02-13 09:46:19 +01:00
Coleen Phillimore
faea95b8d3 8007320: NPG: move method annotations
Allocate method annotations and attach to ConstMethod if present

Reviewed-by: dcubed, jiangli, sspitsyn, iklam
2013-02-11 14:06:22 -05:00
Serguei Spitsyn
6ff685b4c8 Merge 2013-02-08 09:14:06 -08:00
Staffan Larsen
e563c0ecf4 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67)
Do not rely on mach thread port names to identify threads from SA

Reviewed-by: dholmes, minqi, rbackman
2013-02-08 12:48:24 +01:00
Bengt Rutisson
8cf98587f7 Merge 2013-02-08 10:08:40 +01:00
Vladimir Ivanov
268a4d605c Merge 2013-02-07 12:23:51 -08:00
Erik Helin
919ef8e0df 8004924: NPG: jmap -heap output should contain ClassMetaspaceSize value
Reviewed-by: stefank, mgerdin
2013-02-06 07:48:02 +01:00
Erik Helin
2a4bf8ddd8 8008536: Add HotSpot support for printing class loader statistics for JMap
Reviewed-by: sla, brutisso
2013-02-20 16:41:23 +01:00
Yumin Qi
b543c19bac 8000973: SA on windows thread inspection is broken
After bug 7161732, On Windows SA could not find correct address of thread_id of OSThread since _thread_id moved to end of the class . The presupposition of the address is following thread handle no longer stands. Fix by adding thread_id field to OSThread and getting the  address directly from OSThread.

Reviewed-by: nloodin, sspitsyn
2013-01-31 17:43:01 -08:00
Jon Masamitsu
e13466742d Merge 2013-02-04 12:51:25 -08:00
Stefan Karlsson
e8860a177b 8004710: NPG: jmap could throw sun.jvm.hotspot.types.WrongTypeException after PermGen removal
When calculating live object regions, make sure that the alignment reserve, at the end of a TLAB, is excluded.

Reviewed-by: jmasa, brutisso
2013-01-29 10:51:33 +01:00
Morris Meyer
7d8f623180 6518907: cleanup IA64 specific code in Hotspot
Removed unused IA64 specific code

Reviewed-by: twisti, kvn, dholmes
2013-01-25 16:50:33 -08:00
Yunda
19303cc71d 8005278: Serviceability Agent: jmap -heap and jstack -m fail
BinaryTreeDictionary is typedef'ed as AFLBinaryTreeDictionary in vmStructs and in SA we still use old name for that. FreeList now is a template based class which is not reflect in SA type library. When SA does calculation of heap for CMS, the former will cause failure to retrieve BinaryTreeDictionary  sine the rename. The later will fail wherever it is used in SA.

Reviewed-by: dholmes, sla, coleenp
2013-01-24 23:30:45 -08:00
Staffan Larsen
c3d91fec59 Merge 2013-01-18 14:15:51 +01:00
Karen Kinnear
4ce43bafa5 Merge 2013-01-16 18:23:37 -05:00
Aleksey Shipilev
07e2e8803a 8006403: Regression: jstack failed due to the FieldInfo regression in SA
Reviewed-by: sla, dholmes
2013-01-16 16:30:04 +01:00
Aleksey Shipilev
0614ed6542 8003985: Support @Contended Annotation - JEP 142
HotSpot changes to support @Contended annotation.

Reviewed-by: coleenp, kvn, jrose
2013-01-14 15:17:47 +01:00
David Katleman
5dc630b150 8004982: JDK8 source with GPL header errors
Reviewed-by: ohair
2012-12-20 16:24:51 -08:00
Jiangli Zhou
511a9d8982 8004076: Move _max_locals and _size_of_parameters to ConstMethod for better sharing
Move _max_locals and _size_of_parameters to ConstMethod for better sharing.

Reviewed-by: coleenp, minqi, jrose
2012-12-11 12:41:31 -05:00
Jiangli Zhou
10f71a3f72 8003848: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod
Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod.

Reviewed-by: bdelsart, sspitsyn, coleenp
2012-11-27 17:03:56 -05:00
Yumin Qi
f712e12f98 6830717: replay of compilations would help with debugging
When java process crashed in compiler thread, repeat the compilation process will help finding root cause. This is done with using SA dump application class data and replay data from core dump, then use debug version of jvm to recompile the problematic java method.

Reviewed-by: kvn, twisti, sspitsyn
2012-11-12 14:03:53 -08:00
Harold Seigel
7fee66f152 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
Change types of above methods and field to InstanceKlass and remove unneeded casts from the source files.

Reviewed-by: dholmes, coleenp, zgu
2012-11-06 15:09:37 -05:00
Yumin Qi
f214e4cef3 8001055: Bytes.swap should follow big endian
This is a mistake change in 6879063 about Bytes.swap. Java byte code order always follows big endian, but in that change, assume they follow native platform order that is not right.

Reviewed-by: coleenp, sspitsyn, dholmes
2012-10-19 08:58:14 -07:00
Yumin Qi
3d8142d5fd 8000818: SA constant pool need to reference to reference map after permgen removal
After permgen removal, constant pool changed to put _ldc and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer calculated via constant pool cache.

Reviewed-by: coleenp, sspitsyn, dholmes
2012-10-19 08:56:57 -07:00
Vladimir Kozlov
5f132a5ec3 Merge 2012-10-12 09:22:52 -07:00
Mikael Vidstedt
769dd50182 7197424: update copyright year to match last edit in jdk8 hotspot repository
Update copyright year to 2012 for relevant files

Reviewed-by: dholmes, coleenp
2012-10-09 10:09:34 -07:00
Roland Westrelin
61eb5a0549 7054512: Compress class pointers after perm gen removal
Support of compress class pointers in the compilers.

Reviewed-by: kvn, twisti
2012-10-09 10:11:38 +02:00
Yumin Qi
b2cf8c4cb0 8000332: SA ClassDump throws exception after permgen removal
In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset.

Reviewed-by: coleenp, sspitsyn
2012-10-08 16:48:52 -07:00
Coleen Phillimore
28047d6a0f 8000213: NPG: Should have renamed arrayKlass and typeArrayKlass
Capitalize these metadata types (and objArrayKlass)

Reviewed-by: stefank, twisti, kvn
2012-09-29 06:40:00 -04:00
Dmitry Samersoff
47a8760b93 Merge 2012-09-27 20:22:57 +04:00
Yumin Qi
22544e7a7c 6879063: SA should use hsdis for disassembly
We should in SA to use hsdis for it like the JVM does to replace the current java based disassembler.

Reviewed-by: twisti, jrose, sla
2012-09-24 12:44:00 -07:00
Bill Pittore
8e0655095b 7195372: Wrong copyright in new files
Fixed copyrights

Reviewed-by: dholmes
2012-09-19 17:22:49 -04:00
Coleen Phillimore
12b9a4edbb 7195833: NPG: Rename instanceClassLoaderKlass, instanceRefKlass and instanceMirrorKlass
Simple renaming to be consistent with instanceKlass->InstanceKlass renaming

Reviewed-by: stefank, jmasa
2012-09-07 12:04:16 -04:00
Jon Masamitsu
5c58d27aac 6964458: Reimplement class meta-data storage to use native memory
Remove PermGen, allocate meta-data in metaspace linked to class loaders, rewrite GC walking, rewrite and rename metadata to be C++ classes

Co-authored-by: Stefan Karlsson <stefan.karlsson@oracle.com>
Co-authored-by: Mikael Gerdin <mikael.gerdin@oracle.com>
Co-authored-by: Tom Rodriguez <tom.rodriguez@oracle.com>
Reviewed-by: jmasa, stefank, never, coleenp, kvn, brutisso, mgerdin, dholmes, jrose, twisti, roland
2012-09-01 13:25:18 -04:00
Bill Pittore
58a50b25eb 7154641: Servicability agent should work on platforms other than x86, sparc
Added capability to load support classes for other cpus

Reviewed-by: coleenp, bobv, sla
2012-08-30 11:20:01 -04:00
Christian Thalinger
12901d0e5b 7023639: JSR 292 method handle invocation needs a fast path for compiled code
6984705: JSR 292 method handle creation should not go through JNI

Remove assembly code for JDK 7 chained method handles

Co-authored-by: John Rose <john.r.rose@oracle.com>
Co-authored-by: Michael Haupt <michael.haupt@oracle.com>
Reviewed-by: jrose, twisti, kvn, mhaupt
2012-07-24 10:51:00 -07:00
Jiangli Zhou
7b82f72ba9 Merge 2012-07-13 20:14:27 -04:00
Frederic Parain
13c689d9c3 6294277: java -Xdebug crashes on SourceDebugExtension attribute larger than 64K
Reviewed-by: sspitsyn, dholmes, coleenp, kamg
2012-07-09 01:28:37 -07:00
Bertrand Delsart
37d969c6ab Merge 2012-07-02 04:19:22 -04:00
Zhengyu Gu
a39b17624a 6995781: Native Memory Tracking (Phase 1)
7151532: DCmd for hotspot native memory tracking

Implementation of native memory tracking phase 1, which tracks VM native memory usage, and related DCmd

Reviewed-by: acorn, coleenp, fparain
2012-06-28 17:03:16 -04:00
Jiangli Zhou
56df3bd48d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table
Change constMethodOop::_exception_table to optionally inlined u2 table.

Reviewed-by: bdelsart, coleenp, kamg
2012-06-26 19:08:44 -04:00
Yumin Qi
e742ae2157 7177128: SA cannot get correct system properties after 7126277
Bug fix of 7126277 changed hashing algorithm and also changed key as final field, this led SA unable to set correct value for key. Solution by reading key/value and insert them into the new table.

Reviewed-by: dholmes, mikael
2012-06-22 15:39:16 -07:00
Yumin Qi
f4fdc03167 7175133: jinfo failed to get system properties after 6924259
String offset and count fields as fix of 6924259 were removed, and become optional. SA still use offset and count fields to read String contents and failed. Fix if they exist, use them other then use value field only to read, this keeps consistent with the changes in 6924259.

Reviewed-by: dholmes, mikael
2012-06-22 15:35:30 -07:00
Staffan Larsen
cafacdf6dc Merge 2012-06-18 11:33:17 +02:00
Poonam Bajaj
4254270688 6310967: SA: jstack -m produce failures in output
While looking for the sender frame check that the frame pointer should not be less than the stack pointer.

Reviewed-by: dholmes, sla
2012-06-14 02:12:46 -07:00
Jiangli Zhou
2b4b058265 7172967: Eliminate constMethod's _method backpointer to methodOop
Eliminate constMethod's _method backpointer to methodOop, and move the _constant field from methodOop to constMethod.

Reviewed-by: roland, bdelsart, kamg
2012-06-06 14:33:43 -04:00
Joseph Provino
b6db24abd6 Merge 2012-05-26 08:49:05 -04:00