stan/jdk-24
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,805 Commits 2 Branches 0 Tags 1.2 GiB
26949087c0
Commit Graph

794 Commits

Author SHA1 Message Date
Andrei Pangin
31eeaafbcf Merge 2009-02-26 14:25:55 -08:00
Xiomara Jayasena
6f9ccbbe7f Added tag jdk7-b49 for changeset 2fb28c2f14c0 2009-02-26 10:57:13 -08:00
Erik Trimble
954e8082f6 Merge 2009-02-25 23:16:22 -08:00
Erik Trimble
44091d390c Merge 2009-02-25 22:55:54 -08:00
Tom Rodriguez
f7098831dd 6807963: need tool to make sense of LogCompilaton output 
Reviewed-by: kvn
 2009-02-25 14:36:27 -08:00
Tom Rodriguez
a82243d887 6805427: adlc compiler may generate incorrect machnode emission code 
Reviewed-by: kvn, twisti
 2009-02-25 10:53:14 -08:00
Jon Masamitsu
6b78cf8b99 Merge 2009-02-24 22:51:00 -08:00
Jon Masamitsu
b051a23591 6806226: Signed integer overflow in growable array code causes JVM crash 
Workaround the overflow by doing the intermediate calculations in an unsigned variable.

Reviewed-by: ysr, jcoomes
 2009-02-24 22:12:24 -08:00
Antonios Printezis
f883e6fde8 6804746: G1: guarantee(variance() > -1.0,"variance should be >= 0") (due to evacuation failure) 
Under certain circumstances (evacuation failure) the pause time is not communicated to the policy and, as a result, the pause time field is not initialized properly.

Reviewed-by: jmasa
 2009-02-24 15:50:23 -05:00
Vladimir Kozlov
decdeea77d Merge 2009-02-24 09:53:20 -08:00
Vladimir Kozlov
b07ac51bf3 6791572: assert("duplicating node that's already been matched") 
Mark inputs for an address expression as shared if there are other uses besides address expressions.

Reviewed-by: never
 2009-02-23 16:03:19 -08:00
Christian Thalinger
0723dab28b 6808589: Merge vm_version_x86_{32,64}.{cpp,hpp} 
There is very much duplicated code in vm_version_x86_{32,64}.{cpp,hpp}.  Refactoring these would help maintainability.

Reviewed-by: kvn, never
 2009-02-23 12:02:30 -08:00
Andrei Pangin
6acc244444 Merge 2009-02-22 17:21:13 -08:00
Andrei Pangin
85a47f34c6 Merge 2009-02-22 17:11:56 -08:00
Y. Srinivas Ramakrishna
7efb6ac73a Merge 2009-02-20 11:12:26 -08:00
Vladimir Kozlov
dc3008a513 6802499: EA: assert(false,"unknown node on this path") 
Add missing checks for SCMemProj node in Escape analysis code.

Reviewed-by: never
 2009-02-19 17:38:53 -08:00
Xiomara Jayasena
f5594e9e8d Added tag jdk7-b48 for changeset 1da7c5c8156d 2009-02-19 14:08:00 -08:00
Ivan P Krylov
6aec7d2ea9 6806046: Hotspot build error when compiled from Visual Studio 
Define HOTSPOT_LIB_ARCH in the preprocessor flags of the generated projects

Reviewed-by: kamg, xlu
 2009-02-19 04:54:22 -05:00
Erik Trimble
473e5b6e54 6807345: Bump HS15 build number to 02 
Update the HS15 Build number to 02

Reviewed-by: jcoomes
 2009-02-18 18:20:02 -08:00
Erik Trimble
0a2c842e50 Merge 2009-02-18 18:14:18 -08:00
Vladimir Kozlov
73e8e582ba 6807084: AutoBox elimination is broken with compressed oops 
Add checks for DecodeN nodes into AutoBox elimination code.

Reviewed-by: never
 2009-02-18 13:53:42 -08:00
Jon Masamitsu
f1847266b7 6786346: intermittent Internal Error (src/share/vm/memory/cardTableModRefBS.cpp:226) 
Two assertions were incorrectly composed.

Reviewed-by: tonyp
 2009-02-17 15:35:58 -08:00
Vladimir Kozlov
681eb89b31 Merge 2009-02-17 14:30:24 -08:00
Christian Thalinger
f72a09355f 6805950: Typos in andL_rReg_imm instructions in x86_64.ad 
There are two typos in andL_rReg_imm instructions in x86_64.ad.

Reviewed-by: kvn
 2009-02-17 11:19:31 +01:00
Christian Thalinger
dd25f39709 6805724: ModLNode::Ideal() generates functionally incorrect graph when divisor is any (2^k-1) constant 
C2, ModLNode::Ideal() generates functionally incorrect graph when divisor is any (2^k-1) constant.

Reviewed-by: rasbold
 2009-02-16 07:19:26 -08:00
Andrei Pangin
b4e9e47b74 Merge 2009-02-15 20:09:02 -08:00
Christian Thalinger
a2ed00b650 6800154: Add comments to long_by_long_mulhi() for better understandability 
This patch adds a comment pointing to the Hacker's Delight version of the algorithm plus a verbatim copy of it.  Furthermore it adds inline comments.

Reviewed-by: kvn, jrose
 2009-02-13 09:09:35 -08:00
Xiomara Jayasena
0982a57615 Added tag jdk7-b47 for changeset e3f44a955240 2009-02-12 14:00:38 -08:00
Erik Trimble
46194466cf Merge 2009-02-10 20:33:36 -08:00
Andrey Petrusenko
a7da5440dd 6700941: G1: allocation spec missing for some G1 classes 
Reviewed-by: tonyp
 2009-02-10 18:39:09 +03:00
John Coomes
b3e23ac700 Merge 2009-02-09 13:47:26 -08:00
Y. Srinivas Ramakrishna
0badccf962 6800586: -XX:+PrintGCDateStamps is using mt-unsafe localtime function 
Replaced localtime() with localtime_r() on Solaris and Linux.

Reviewed-by: apetrusenko, dholmes, jmasa
 2009-02-09 12:26:05 -08:00
Andrey Petrusenko
4be1a50ed3 6802413: G1: G1FixedSurvivorSpaceSize should be converted into regions in calculate_survivors_policy() 
Reviewed-by: tonyp, jmasa
 2009-02-09 17:33:06 +03:00
Jon Masamitsu
3b5d6a04dd 6690928: Use spinning in combination with yields for workstealing termination 
Substitute a spin loop for most calls to yield() to reduce the stress on the system.

Reviewed-by: tonyp
 2009-02-08 13:18:01 -08:00
Vladimir Kozlov
2f2589d2dc 6791852: assert(b->_nodes[insidx] == n,"got insidx set incorrectly") 
Move the CreateEx up before each round of IFG construction

Reviewed-by: never, phh
 2009-02-06 13:31:03 -08:00
Xiomara Jayasena
f7ccda2b14 Added tag jdk7-b46 for changeset be9d0d46381d 2009-02-05 16:07:33 -08:00
Vladimir Kozlov
94a461f4cb 6799693: Server compiler leads to data corruption when expression throws an Exception 
Use merged memory state for an allocation's slow path.

Reviewed-by: never
 2009-02-05 14:43:58 -08:00
Andrey Petrusenko
61181babf1 6484959: G1: introduce survivor spaces 
6797754: G1: combined bugfix

Implemented a policy to control G1 survivor space parameters.

Reviewed-by: tonyp, iveresov
 2009-02-06 01:38:50 +03:00
Vladimir Kozlov
72b75d1adf 6788376: allow to ignore unrecognized VM options 
Add new product flag -XX:+IgnoreUnrecognizedVMOptions

Reviewed-by: ysr, xlu
 2009-02-05 13:38:52 -08:00
Tom Rodriguez
275a0bfb42 6793828: G1: invariant: queues are empty when activated 
Reviewed-by: jrose, kvn
 2009-02-05 11:42:10 -08:00
Tom Rodriguez
67f20d82c9 6442502: assert(bits,"Use TypePtr for NULL") on linux-x86 
Reviewed-by: kvn
 2009-02-04 23:17:38 -08:00
Y. Srinivas Ramakrishna
61c259aeb5 Merge 2009-02-04 15:42:52 -08:00
Tom Rodriguez
a70da64c72 6798785: Crash in OopFlow::build_oop_map: incorrect comparison of 64bit pointers 
Reviewed-by: phh, kvn
 2009-02-04 11:44:57 -08:00
Tom Rodriguez
c46f747070 6782260: Memory leak in CodeBuffer::create_patch_overflow 
Reviewed-by: phh, kvn
 2009-02-03 18:05:19 -08:00
Christian Thalinger
17d35f31a2 6799452: HotSpot tests Makefile should take care of ALT_SLASH_JAVA 
The HotSpot tests Makefile has a hardcoded SLASH_JAVA which makes it difficult to run the tests on non-Sun build machines which do not have a /java infrastructure.

Reviewed-by: kamg
 2009-02-03 08:10:28 -08:00
Christian Thalinger
ecbdf3bb83 6795362: 32bit server compiler leads to wrong results on solaris-x86 
The C2 compiler leads to wrong results on solaris-i486 (32-bit) for a testcase given in the CR.

Reviewed-by: never, rasbold
 2009-02-03 01:39:12 -08:00
Kelly O'Hair
09010fe0a7 6799141: Build with --hash-style=both so that binaries can work on SuSE 10 
Reviewed-by: tbell
 2009-01-31 17:19:42 -08:00
Jon Masamitsu
39b23ff0a0 6792421: assert(_bitMap->isMarked(addr+size-1),inconsistent Printezis mark) 
The CMS concurrent precleaning and concurrent marking phases should work around classes that are undergoing redefinition.

Reviewed-by: ysr, tonyp
 2009-01-31 00:15:00 -08:00
Erik Trimble
50d5d6cd86 Merge 2009-01-30 15:28:00 -08:00
Y. Srinivas Ramakrishna
d981bd442b 6787254: Work queue capacity can be increased substantially on some platforms 
Increased the default and maximum size of the CMS marking stack and the size of the parallel workers' work queues in 64-bit mode. The latter was accomplished by an increase in the width of the Taskqueue's Age struct and its Tag field in 64-bit mode.

Reviewed-by: jmasa, tonyp
 2009-01-30 14:17:52 -08:00
Y. Srinivas Ramakrishna
34b247f068 Merge 2009-01-29 21:25:42 -08:00
Xiomara Jayasena
49f97d10c8 Added tag jdk7-b45 for changeset 6b84304c8b89 2009-01-29 13:20:56 -08:00
Igor Veresov
da292a7197 6783381: NUMA allocator: don't pretouch eden space with UseNUMA 
Moved pretouching to MutableSpace. Also MutableSpace now turns on page interleaving for the region it covers.

Reviewed-by: jmasa, jcoomes
 2009-01-27 18:13:59 -08:00
Y. Srinivas Ramakrishna
f031c45430 6786503: Overflow list performance can be improved 
Avoid overflow list walk in CMS & ParNew when it is unnecessary. Fix a couple of correctness issues, including a C-heap leak, in ParNew at the intersection of promotion failure, work queue overflow and object array chunking. Add stress testing option and related assertion checking.

Reviewed-by: jmasa
 2009-01-26 12:47:21 -08:00
Xiaobin Lu
5ee6e7f6ed 6795913: A few remaining wrong casts need to be fixed for building hotspot successfully on Mac OS 
Use NULL_WORD in the places where intptr_t is expected due to incompatible types between intptr_t & int32_t

Reviewed-by: phh, coleenp, never
 2009-01-26 12:07:54 -08:00
Christian Thalinger
3b8452da93 6796746: rename LoadC (char) opcode class to LoadUS (unsigned short) 
Renaming LoadC to LoadUS would round up the planned introduction of LoadUB and LoadUI.

Reviewed-by: phh, kvn
 2009-01-26 16:22:12 +01:00
Coleen Phillimore
91dd5dcbe4 Merge 2009-01-23 10:41:28 -05:00
Xiomara Jayasena
9933a50bf3 Added tag jdk7-b44 for changeset ec694d49c4be 2009-01-22 14:42:01 -08:00
John Coomes
8109aa4a16 Merge 2009-01-21 13:40:10 -08:00
Vladimir Kozlov
ae8aa00398 6794939: assert(_base == OopPtr,"subclass must override cast_to_ptr_type") 
Fix the assert in TypeKlassPtr::cast_to_ptr_type().

Reviewed-by: never
 2009-01-21 11:18:38 -08:00
Paul Hohensee
73aaa40e09 6792705: Add JAR file to bootclasspath when using AggressiveOpts 
During argument processing, add alt-rt.jar to the bootclasspath between bootclasspath/p and default elements.

Reviewed-by: xlu, coleenp
 2009-01-21 11:14:19 -05:00
Vladimir Kozlov
a23ea7296a 6790209: server VM fails with assert(will_link,"_new: typeflow responsibility") 
Add missing code for reflection class loader in SystemDictionary::find().

Reviewed-by: never, jrose
 2009-01-16 11:23:10 -08:00
Antonios Printezis
5d486c3a66 6484956: G1: improve evacuation pause efficiency 
A bunch of performance optimizations to decrease GC pause times in G1.

Reviewed-by: apetrusenko, jmasa, iveresov
 2009-01-16 13:02:20 -05:00
Swamy Venkataramanappa
3cc490850d Merge 2009-01-15 13:30:09 -08:00
Xiomara Jayasena
58317112cf Added tag jdk7-b43 for changeset a0e6196f0e90 2009-01-15 11:46:26 -08:00
Coleen Phillimore
455ba2dcdf Merge 2009-01-15 12:44:03 -05:00
Swamy Venkataramanappa
b15aadf61d 6786948: SA on core file fails on solaris-amd64 if vm started with -XX:+StartAttachListener 
Reviewed-by: jjh, dcubed
 2009-01-14 19:45:01 -08:00
Coleen Phillimore
f79090efe7 6793825: Missing include dependancies for GCC without predefined headers 
With predefined headers off for gcc, some .inline.hpp files aren't included to make definition visible for inline functions

Reviewed-by: jcoomes, xlu
 2009-01-14 20:14:19 -05:00
John Coomes
2ba0d5b055 Merge 2009-01-14 14:12:55 -08:00
Tom Rodriguez
532cc3cef8 6788347: C2Compiler crash 6u7 
Reviewed-by: kvn
 2009-01-14 14:12:00 -08:00
Xiaobin Lu
74a472983b 6792301: StackAlignmentInBytes not honored for compiled native methods 
Fixed the stack misalignment when generate_native_wrapper is called.

Reviewed-by: never, kamg, kvn, phh
 2009-01-13 17:39:03 -08:00
Xiaobin Lu
8187896320 Merge 2009-01-13 14:49:07 -08:00
Tom Rodriguez
d9a391aad9 Merge 2009-01-13 14:02:19 -08:00
Xiaobin Lu
31acc39bf9 Merge 2009-01-13 12:14:38 -08:00
Xiaobin Lu
aae30d753f 6791815: Fix for 6471657 can cause deadlock on non-Solaris platforms when initializing direct buffer support 
Place the state transition inside the loop so that the VMThread could proceed for safepoint

Reviewed-by: dholmes, never, acorn
 2009-01-13 12:08:43 -08:00
Tom Rodriguez
a3d528cc30 6791132: bad control in autobox split code 
Reviewed-by: kvn
 2009-01-13 11:43:20 -08:00
Coleen Phillimore
a1442ea7ff 6791168: Fix invalid code in bytecodeInterpreter that can cause gcc ICE 
Fix compilation errors from latest gcc in CC_INTERP including offending missing void* cast.

Reviewed-by: xlu
 2009-01-13 14:41:44 -05:00
Vladimir Kozlov
78f5dc395e 6784930: server jvm fails with assert(!n->is_SpillCopy(),"") 
Set minimum block frequency MIN_BLOCK_FREQUENCY 1.e-35f.

Reviewed-by: never, rasbold
 2009-01-13 11:10:00 -08:00
Jon Masamitsu
c2ff9781c7 6692899: CMS: many vm.parallel_class_loading tests fail with assert "missing Printezis mark" 
The CMS concurrent precleaning and concurrent marking phases should work around classes that are undergoing redefinition.

Reviewed-by: ysr, dcubed
 2009-01-11 16:58:24 -08:00
Coleen Phillimore
76f79d82ad Merge 2009-01-09 14:39:07 -05:00
Karen Kinnear
9bf4545843 6791656: nsk defclass0 asserts handles.hpp 
Reviewed-by: phh, xlu
 2009-01-08 16:27:28 -05:00
Vladimir Kozlov
1ff1bdc3e6 6790182: matcher.cpp:1375: assert(false,"bad AD file") 
Add a match rule for regD_low in regD definition.

Reviewed-by: never
 2009-01-07 11:23:28 -08:00
Vladimir Kozlov
49ee6acaa2 6782232: assert("CreateEx must be first instruction in block" ) 
Add the missing check for CreateEx. Add new notproduct flag VerifyRegisterAllocator.

Reviewed-by: never
 2009-01-07 11:04:45 -08:00
Tom Rodriguez
956dc037db Merge 2009-01-06 16:10:11 -08:00
Jon Masamitsu
3474623106 6689653: JMapPerm fails with UseConcMarkSweepIncGC and compressed oops off 
Added safe_object_iterate() for use by JMapPerm.

Reviewed-by: tonyp
 2009-01-06 07:05:05 -08:00
Karen Kinnear
315de68fc0 4670071: loadClassInternal is too restrictive 
VM support for deadlock fix. Library fix in 4735126. See API proposal.

Reviewed-by: dholmes, blacklion
 2009-01-05 13:44:03 -05:00
Xiaobin Lu
f05b009ce8 6781583: Hotspot build fails on linux 64 bit platform with gcc 4.3.2 
Fixed the wrong cast between types since more restrictions are imposed by gcc 4.3.2

Reviewed-by: jcoomes, acorn, phh, never
 2008-12-24 19:13:53 -08:00
Xiaobin Lu
1362b9fd1d 6787106: Hotspot 32 bit build fails on platforms having different definitions for intptr_t & int32_t 
Avoid casting between int32_t and intptr_t specifically for MasmAssembler::movptr in 32 bit platforms.

Reviewed-by: jrose, kvn
 2008-12-24 13:06:09 -08:00
Erik Trimble
1880943a7f 6788797: Fork HS14 to HS15 - renumber Major and build numbers of JVM 
Fork Hotspot 15 - redo verisoning numbers

Reviewed-by: jcoomes
 2008-12-23 19:28:18 -08:00
Coleen Phillimore
d80f5c0265 4997835: RFE: crash dump will only be created when running w/ -XX:+ShowMessageBoxOnError 
Using UseOSErrorReporting will provide both an hs_err file and a crash dump or debug launch and works better.

Reviewed-by: xlu, acorn, poonam
 2008-12-23 06:16:53 -08:00
Lillian Angel
1ad664c0c9 6778662: fixes 64-bits libraries directory search paths on linux 
Fixes 64-bits libraries directory search paths.

Reviewed-by: never
 2008-12-22 16:53:34 -08:00
Gary Benson
347b8afe5b 6778657: Casts in SharedRuntime::f2i, f2l, d2i and d2l rely on undefined C++ behaviour 
Replaces SharedRuntime::f2i et al with versions that should work

Reviewed-by: never
 2008-12-22 15:43:02 -08:00
Erik Trimble
b5743bd6e9 6787832: Bump Hotspot build number to 08 
Update the HS14 build number to 08

Reviewed-by: jcoomes
 2008-12-20 09:59:01 -08:00
Erik Trimble
ac1f463988 Merge 2008-12-20 09:58:36 -08:00
Erik Trimble
efd43c045a Merge 2008-12-20 09:57:03 -08:00
Xiaobin Lu
34c4172bfe Merge 2008-12-20 00:45:18 -08:00
Xiaobin Lu
74d9cf0fb8 6784100: getTimeNanos - CAS reduction 
Get rid of the CAS loop in getTimeNanos to reduce coherence traffic on Solaris.

Reviewed-by: acorn, kvn, ysr
 2008-12-19 14:40:28 -08:00
Jon Masamitsu
91caa3b23f Merge 2008-12-19 12:15:34 -08:00
Xiomara Jayasena
22a73d8b7d Added tag jdk7-b42 for changeset a0dd9009e992 2008-12-18 21:34:02 -08:00
Poonam Bajaj
0f5687c1eb 6786340: hs14b09a pit: a lot of tests failed in "-server -Xcomp" on solaris-amd64 using fastdebug bits 
Fixes the nsk-jdi PIT failures introduced by fix for 6739363

Reviewed-by: kvn, coleenp
 2008-12-18 17:28:41 -08:00
Vladimir Kozlov
dc2957bef6 Merge 2008-12-18 13:59:59 -08:00
Vladimir Kozlov
744c80add4 6787050: assert(n->in(0) == 0L,"no control") with UseCompressedOops on sparcv9 
Relax the assert for Sparc.

Reviewed-by: never
 2008-12-18 11:26:22 -08:00
John Coomes
f3c34ce9b6 6786188: par compact - "SplitALot" stress mode should fill to_space 
Reviewed-by: jmasa, tonyp
 2008-12-18 10:54:01 -08:00
John Coomes
f90394b6fb 6784849: par compact - can fail when to_space is non-empty 
Reviewed-by: jmasa, tonyp
 2008-12-18 10:53:35 -08:00
John Coomes
a88e734cac 6786195: many nsk.monitoring tests fail with -server -Xcomp 
Remove Universe::_fillerArrayKlassObj and associated code

Reviewed-by: jmasa, tonyp
 2008-12-18 01:27:04 -08:00
Vladimir Kozlov
4d2c491b2b Merge 2008-12-17 14:09:39 -08:00
Vladimir Kozlov
29488f1216 6782820: Server VM fails with "unhandled implicit exception in compiled code" 
Restore the code which sets a control edge for a klass load node.

Reviewed-by: never
 2008-12-16 12:23:39 -08:00
Xiomara Jayasena
99f0eac1a2 6785258: Update copyright year 
Update copyright for files that have been modified starting July 2008 to Dec 2008

Reviewed-by: katleman, ohair, tbell
 2008-12-15 16:55:11 -08:00
Swamy Venkataramanappa
06e37c03fb 6653214: MemoryPoolMXBean.setUsageThreshold() does not support large heap sizes 
Reviewed-by: ysr, mchung
 2008-12-15 13:58:57 -08:00
Tom Rodriguez
baa4663714 6758234: if (k cond (a ? : b: c)) returns reversed answer if k is constant and b and c are longs 
Reviewed-by: kvn, jrose
 2008-12-12 19:55:26 -08:00
Tom Rodriguez
40a81c63b8 6757316: load_constant() produces a wrong long constant, with high a low words swapped 
Reviewed-by: rasbold, jrose, kvn
 2008-12-12 19:54:46 -08:00
Tom Rodriguez
552c37000d 6767587: missing call to make_not_entrant after deoptimizing for patching volatiles 
Reviewed-by: rasbold, kvn
 2008-12-12 19:53:25 -08:00
Jon Masamitsu
31308ae8e4 Merge 2008-12-12 15:37:46 -08:00
Lev Serebryakov
0d7bfcafab Merge 2008-12-12 10:19:39 -08:00
Vladimir Kozlov
6483f9c7f8 Merge 2008-12-11 17:20:10 -08:00
John Coomes
8fc946854c 6765954: par compact - stress mode for splitting young gen spaces 
Reviewed-by: jmasa
 2008-12-11 12:05:21 -08:00
John Coomes
7a9585170d 6765745: par compact - allow young gen spaces to be split 
Reviewed-by: jmasa
 2008-12-11 12:05:14 -08:00
John Coomes
000b184507 6578152: fill_region_with_object has usability and safety issues 
Reviewed-by: apetrusenko, ysr
 2008-12-11 12:05:08 -08:00
Lev Serebryakov
92ea783f35 6639341: sometimes contended-exit event comes after contended-entered on another thread 
DTrace probe "contended-exit" should be fired before unparking object, or context could be lost. Probe firing was moved to proper place.

Reviewed-by: coleenp, kamg
 2008-12-11 03:22:04 -08:00
Y. Srinivas Ramakrishna
26f6b1692a 6782457: CMS: Livelock in CompactibleFreeListSpace::block_size() 
6736295: SIGSEGV in product jvm, assertion "these are the only valid states during a mark sweep" in fastdebug

Restructured the code in the perm gen allocation retry loop so as to avoid "safepoint-blocking" on locks, in this case the Heap_lock, while holding uninitialized allocated heap storage.

Reviewed-by: apetrusenko, iveresov, jcoomes, jmasa, poonam
 2008-12-10 23:46:10 -08:00
Coleen Phillimore
e0d2bfab81 6727377: VM stack guard pages on Windows should PAGE_READWRITE not PAGE_EXECUTE_READWRITE 
Make reguard_stack change access to RW, not execute and use os::protect_memory with the new parameter when change needed to X.

Reviewed-by: acorn, jcoomes
 2008-12-10 15:14:29 -08:00
John R Rose
67464baa7a 6771309: debugging AD files is difficult without #line directives in generated code 
More and better #line and #define directives in the generated code; ADLC itself accepts #line directives

Reviewed-by: never, kvn
 2008-12-09 12:41:26 -08:00
Coleen Phillimore
36f5b8dd54 6689685: Hotspot crash error message should include libraries version 
Print out JDK/JRE version that hotspot knows about.

Reviewed-by: kamg, blacklion, acorn, alanb
 2008-12-09 09:55:39 -05:00
John R Rose
e50f766540 6779339: turn off LinkWellKnownClasses by default pending further testing 
Temporarily turn off LinkWellKnownClasses optimization

Reviewed-by: never, kvn
 2008-12-08 17:15:02 -08:00
Coleen Phillimore
c07de94ae3 6773838: There is no calling stack for Compiler thread in hs_err file on x86 
On solaris, the inline assembly wasn't being processed.  Added volatile to il file fixed it.

Reviewed-by: phh, kvn
 2008-12-08 15:50:55 -05:00
Erik Trimble
ec343fa4bc 6781742: Bump HS14 build number to 09 
Update Hotspot 14 build number to b09

Reviewed-by: jcoomes
 2008-12-05 15:45:24 -08:00
Erik Trimble
349adae76a Merge 2008-12-05 15:32:59 -08:00
Lev Serebryakov
1d59997abe Merge 2008-12-05 15:06:37 -05:00
Poonam Bajaj
9330807714 Merge 2008-12-04 17:48:02 -08:00
Poonam Bajaj
eddda26255 6739363: Xcheck jni doesn't check native function arguments 
Fix adds support for verifying arguments with -Xcheck:jni.

Reviewed-by: coleenp
 2008-12-04 17:29:56 -08:00
Jon Masamitsu
dd80e77a74 Merge 2008-12-04 13:21:16 -08:00
Xiomara Jayasena
868fd3b043 Added tag jdk7-b41 for changeset 49f1a8464e11 2008-12-04 11:10:13 -08:00
Jon Masamitsu
7231a4ca3b Merge 2008-12-04 09:04:46 -08:00
Vladimir Kozlov
d9c6682945 Merge 2008-12-04 08:55:34 -08:00
Jon Masamitsu
0320ba0b9e Merge 2008-12-03 14:44:48 -08:00
Igor Veresov
af509dd90d 6779436: NUMA allocator: libnuma expects certain size of the buffer in numa_node_to_cpus() 
In os::Linux::rebuild_cpu_to_node_map() fix the size of the CPU bitmap. Fixed arithmetic in MutableNUMASpace::adaptive_chunk_size() that could cause overflows and underflows of the chunk_size variable.

Reviewed-by: apetrusenko
 2008-12-03 14:18:57 -08:00
Vladimir Kozlov
f2f18a01e5 6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now") 
Create new "eliminated" BoxLock node for monitor debug info when corresponding locks are eliminated.

Reviewed-by: never
 2008-12-03 13:41:37 -08:00
Y. Srinivas Ramakrishna
16aa57cb4b 6778647: snap(), snap_policy() should be renamed setup(), setup_policy() 
Renamed Reference{Policy,Pocessor} methods from snap{,_policy}() to setup{,_policy}()

Reviewed-by: apetrusenko
 2008-12-01 23:25:24 -08:00
Poonam Bajaj
569029da79 6743339: Enable building sa-jdi.jar and sawindbg.dll on Windows with hotspot build 
These changes enable the SA binaries build with hotspot build on Windows

Reviewed-by: swamyv
 2008-11-27 18:19:23 -08:00
Igor Veresov
ed99040266 Merge 2008-11-26 09:24:57 -08:00
Tom Rodriguez
2bba3afabc 6756768: C1 generates invalid code 
Reviewed-by: kvn, jrose
 2008-11-25 13:14:07 -08:00
Keith McGuigan
180875046c Merge 2008-11-25 15:59:23 -05:00
Coleen Phillimore
f58e193de0 6474243: suspicious jvmti code that uses oop unsafely across GC point 
Oop stored in unsafely in Lscratch noticed by visual inspection will not be updated by GC.

Reviewed-by: kamg, never, kvn
 2008-11-24 14:45:47 -05:00
Y. Srinivas Ramakrishna
6c53645a84 6774607: SIGSEGV or (!is_null(v),"oop value can never be zero") assertion when running with CMS and COOPs 
Use the more permissive set_klass_or_null() and klass_or_null() interfaces in ParNew's workqueue overflow code that manipulates the klass-word.

Reviewed-by: coleenp
 2008-11-24 09:53:31 -08:00
Xiaobin Lu
85138023c1 6554406: Change switch UseVMInterruptibleIO default to false (sol) 
The default value of UseVMInterruptibleIO is changed to false for JDK 7, but the default isn't changed for JDK 6 and earlier.

Reviewed-by: never, acorn, dholmes, kamg, alanb
 2008-11-22 00:16:09 -08:00
Erik Trimble
de0532a7ec 6775176: Bump HS14 build number to 08 
Update the Hotspot build number to 08

Reviewed-by: jcoomes
 2008-11-21 16:11:18 -08:00
Erik Trimble
658a01dd3f Merge 2008-11-21 16:11:03 -08:00
Keith McGuigan
e64aa947c4 Merge 2008-11-21 15:10:14 -05:00
Coleen Phillimore
50a5499c50 6676175: BigApps crash JVM Client VM (build 10.0-b22, mixed mode, sharing) with SIGSEGV (0xb) 
Add test for biased locking epoch before walking own thread stack in case of rare race

Reviewed-by: phh, never
 2008-11-21 08:09:11 -08:00
Y. Srinivas Ramakrishna
7d7cf3f8af 6684579: SoftReference processing can be made more efficient 
For current soft-ref clearing policies, we can decide at marking time if a soft-reference will definitely not be cleared, postponing the decision of whether it will definitely be cleared to the final reference processing phase. This can be especially beneficial in the case of concurrent collectors where the marking is usually concurrent but reference processing is usually not.

Reviewed-by: jmasa
 2008-11-20 16:56:09 -08:00
Y. Srinivas Ramakrishna
db6bef2c70 6722113: CMS: Incorrect overflow handling during precleaning of Reference lists 
When we encounter marking stack overflow during precleaning of Reference lists, we were using the overflow list mechanism, which can cause problems on account of mutating the mark word of the header because of conflicts with mutator accesses and updates of that field. Instead we should use the usual mechanism for overflow handling in concurrent phases, namely dirtying of the card on which the overflowed object lies. Since precleaning effectively does a form of discovered list processing, albeit with discovery enabled, we needed to adjust some code to be correct in the face of interleaved processing and discovery.

Reviewed-by: apetrusenko, jcoomes
 2008-11-20 12:27:41 -08:00
Xiomara Jayasena
c60ef2ef3b Added tag jdk7-b40 for changeset d9cee294e5e4 2008-11-20 11:39:38 -08:00
Igor Veresov
28b2c4aeaf Merge 2008-11-19 14:20:51 -08:00
Vladimir Kozlov
2f7409dee4 Merge 2008-11-19 09:09:31 -08:00
Jon Masamitsu
a2078f04e8 6771742: Remove duplicate files from G1 merge 
Remove duplicate files and add includeDB_gc_g1 file in windows Makefile

Reviewed-by: jcoomes, ysr
 2008-11-18 14:52:33 -08:00
Vladimir Kozlov
43051c98f3 6773078: UseCompressedOops: assert(kid == 0L || s->_leaf->in(0) == 0L,"internal operands have no control") 
Don't set the control edge of a klass load node.

Reviewed-by: never
 2008-11-18 14:47:36 -08:00
Vladimir Kozlov
893d1c4148 6766316: assert(!nocreate,"Cannot build a phi for a block already parsed.") 
Don't use the invariant local information if there are irreducible loops.

Reviewed-by: never
 2008-11-18 12:40:28 -08:00
Vladimir Kozlov
f2c8d25c73 6772413: code cleanup 
Removed lines in adm64.make with interpret.o and moved few constant strings from header files.

Reviewed-by: never
 2008-11-18 12:31:53 -08:00
Erik Trimble
a7d5fce367 6771977: Bump HS14 build number to 07 
Update the Hotspot build number to 07

Reviewed-by: jcoomes
 2008-11-14 19:26:03 -08:00
Erik Trimble
bc9a3dae9e Merge 2008-11-14 19:23:49 -08:00
Igor Veresov
cbf1c89d60 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint 
6660573: G1: BigApps Failure : guarantee(satb_mq_set.completed_buffers_num() == 0,"invariant")

When exiting a mutator thread is removed from the thread list before it has a chance to flush its SATB and barrier queues. If GC happens at this moment the objects that are refererred from these queues can be moved, which will case a crash. The fix is simply to flush the buffers before removing a thread from the list.

Reviewed-by: jcoomes, tonyp
 2008-11-14 14:23:05 -08:00
Vladimir Kozlov
ce3f3dd8d3 6767659: Conversion from i486 to x86 missed some entries in makefiles 
Fixed missed entries.

Reviewed-by: never
 2008-11-13 14:50:04 -08:00
John R Rose
4e2c4fb4bd 6770949: minor tweaks before 6655638 
Minor cleanups & tuning of array.hpp, debug.cpp, growableArray.hpp, hashtable.cpp

Reviewed-by: kvn
 2008-11-12 23:26:45 -08:00
John R Rose
849e0ffb04 6653858: dynamic languages need to be able to load anonymous classes 
Low-level privileged sun.misc.Unsafe.defineAnonymousClass

Reviewed-by: kvn
 2008-11-12 22:33:26 -08:00
Vladimir Kozlov
015a08b3e8 6769748: Fix solaris makefiles for the case when "CC -V" produces several lines 
Fix solaris makefiles for 5.10 compilers

Reviewed-by: jcoomes
 2008-11-12 11:01:31 -08:00
Keith McGuigan
8db365aa80 Merge 2008-11-12 11:23:13 -05:00
Tom Rodriguez
f2143c7bee Merge 2008-11-12 05:42:59 -08:00
Tom Rodriguez
1716627be0 6758445: loop heads that are exception entry points can crash during count_edges/mark_loops 
Reviewed-by: kvn, jrose
 2008-11-11 23:03:35 -08:00
Tim Bell
12fd79632c 6764892: VS2008 changes required to compile hotspot sources 
Minor changes required to build using the Visual Studio 2008 compiler

Reviewed-by: kvn, ohair
 2008-11-11 22:01:08 -08:00
Tom Rodriguez
6cea928f70 Merge 2008-11-07 13:55:14 -08:00
John Coomes
98685a4d93 6769128: failure to run generateJvmOffsets is ignored 
Reviewed-by: xlu
 2008-11-07 12:52:16 -08:00
John Coomes
6fe817326c 6718879: cannot build on solaris nevada 
Reviewed-by: xlu
 2008-11-11 22:21:13 -08:00
Vladimir Kozlov
7aae40a95f 6462850: generate biased locking code in C2 ideal graph 
Inline biased locking code in C2 ideal graph during macro nodes expansion

Reviewed-by: never
 2008-11-07 09:29:38 -08:00
Coleen Phillimore
0cecb67ae7 6760773: UseCompressedOops is broken with UseParNewGC 
Sparc code for gen_subtype_check was doing an ld for a compressed oop with the sign bit set so not comparing, leading to a ClassCastException.

Reviewed-by: phh, never, acorn, kvn, xlu
 2008-11-07 11:03:32 -05:00
Tom Rodriguez
2c3b8ec969 6761594: framesize rounding code rounds using wrong units leading to slightly oversized frames 
Reviewed-by: rasbold, kvn
 2008-11-06 20:00:03 -08:00
Chuck Rasbold
0e63b7609a 6743900: frequency based block layout 
Post-register allocation pass that drives block layout by edge frequencies

Reviewed-by: never, kvn
 2008-11-06 14:59:10 -08:00
Xiomara Jayasena
ec8b80fefc Added tag jdk7-b39 for changeset c483fc7ff658 2008-11-06 12:10:20 -08:00
Xiaobin Lu
8eb2e02296 Merge 2008-10-31 10:34:20 -07:00
Tom Rodriguez
7bcfb5965d 6764622: IdealGraphVisualizer fixes 
Reviewed-by: rasbold, jrose
 2008-10-30 17:08:48 -07:00
Keith McGuigan
7de6d649be 6756528: Bytecodes::special_length_at reads past end of code buffer 
Add end-of-buffer indicator for paths used by the verifier

Reviewed-by: acorn, coleenp
 2008-10-30 15:48:59 -04:00
Erik Trimble
740031d711 Merge 2008-10-29 19:22:09 -07:00
Erik Trimble
ecbe1aeb4e Merge 2008-10-29 19:18:54 -07:00
John Coomes
401e04572a 6765804: GC "dead ratios" should be unsigned 
Reviewed-by: ysr, tonyp
 2008-10-29 06:30:02 -07:00
Tom Rodriguez
8537533873 6649622: HotSpot Biased locking needs tuning on latest CPUs 
Reviewed-by: rasbold, kvn, kamg
 2008-10-28 18:02:09 -07:00
Tom Rodriguez
429a95440a 6754519: don't emit flag fixup for NaN when condition being tested doesn't need it 
Reviewed-by: kvn, rasbold
 2008-10-28 09:31:30 -07:00
Xiomara Jayasena
3ae2c2ca54 Added tag jdk7-b38 for changeset 2db019fa6029 2008-10-23 10:13:01 -07:00
Xiaobin Lu
107bbcc8f4 Merge 2008-10-22 20:47:00 -07:00
Karen Kinnear
4fa4c137a2 Merge 2008-10-22 15:07:23 -04:00
Karen Kinnear
347534f43b 6761092: jvm crashes when CDS is enabled 
CDS hardcoded max c++ virtual method table increased

Reviewed-by: coleenp, xlu, jmasa
 2008-10-22 14:48:08 -04:00
Tom Rodriguez
f3a403d0d4 6762004: 6532536 fix contains changes in os_solaris.cpp which were pushed by mistake 
Reviewed-by: kvn
 2008-10-21 11:23:52 -07:00
Tom Rodriguez
bc7e37f4df Merge 2008-10-21 11:21:45 -07:00
Xiaobin Lu
fa8846d054 Merge 2008-10-17 15:18:02 -07:00
Daniel D. Daugherty
f60d27c8f6 Merge 2008-10-16 11:07:39 -07:00
Erik Trimble
4b983d3b39 Merge 2008-10-15 18:51:04 -07:00
Erik Trimble
1c5962a62c Merge 2008-10-15 18:49:57 -07:00
Mandy Chung
e5e6ca9d62 6306922: Dump dump created by +HeapDumpOnOutOfMemoryError should include stack traces for stack roots 
Include stack traces of all threads in the heap dump

Reviewed-by: alanb
 2008-10-14 15:16:38 -07:00
Vladimir Kozlov
55925534ec 6532536: Optimize arraycopy stubs for Intel cpus 
Use SSE2 movdqu in arraycopy stubs on newest Intel's cpus

Reviewed-by: rasbold
 2008-10-14 15:10:26 -07:00
Coleen Phillimore
d1aacc7cdf 6700107: java/lang/Class/forName/TooManyDimensions.java crashes with SIGSEGV in c2 compiler with fastdebug 
ObjArrayKlass::compute_modifier_flags was unnecessarily recursive

Reviewed-by: kamg
 2008-10-14 10:15:33 -04:00
Chuck Rasbold
0dac6431d2 6717150: improper constant folding of subnormal strictfp multiplications and divides 
Suppress constant folding of double divides and multiplications on ia32

Reviewed-by: never
 2008-10-14 06:58:58 -07:00
Igor Veresov
bc9f364917 6758633: G1: SEGV with GCOld on Linux 
Avoid growth of a GrowableArray backend of HeapRegionSeq.

Reviewed-by: tonyp, jcoomes
 2008-10-13 21:41:42 -07:00
Chuck Rasbold
e585263735 6752257: Use NOT instead of XOR -1 on x86 
Add match rule for xor -1

Reviewed-by: never, kvn
 2008-10-10 09:47:56 -07:00
Xiomara Jayasena
8f0558c530 Added tag jdk7-b37 for changeset 5eb97f366a6a 2008-10-09 11:13:12 -07:00
Antonios Printezis
04b0ebb9c1 Merge 2008-10-09 12:06:22 -04:00
Kumar Srinivasan
3a72f5c241 6755845: JVM_FindClassFromBoot triggers assertions 
Fixes assertions caused by one jvm_entry calling another, solved by refactoring code and modified gamma test.

Reviewed-by: dholmes, xlu
 2008-10-08 08:10:51 -07:00
Erik Trimble
50964694fe Merge 2008-10-07 11:01:35 -07:00
Igor Veresov
d80199b403 6753547: NUMA allocator: Invalid chunk size computation during adaptive resizing 
The per-lgrp chuck size can be incorrectly computed (causing an assertion failure) because of the non-associativity of the floating point operations. The fix is to rearrange the operations.

Reviewed-by: ysr
 2008-10-06 20:59:16 -07:00
Tom Rodriguez
7633aaa177 Merge 2008-10-06 13:11:32 -07:00
Xiaobin Lu
fe28b4f768 6673124: Runtime.availableProcessors / os::active_processor_count wrong if unused processor sets exist 
Reviewed-by: acorn, dholmes
 2008-10-06 11:39:34 -07:00
Antonios Printezis
6f5e28aca1 6752248: G1: introduce parallel heap verification 
Introduce parallel heap verification in G1.

Reviewed-by: jcoomes, apetrusenko
 2008-10-06 13:16:35 -04:00
Tom Rodriguez
043fde10e5 6743188: incomplete fix for 6700047 C2 failed in idom_no_update 
Reviewed-by: rasbold, kvn
 2008-10-03 13:58:20 -07:00
Xiomara Jayasena
76df5ec473 6754988: Update copyright year 
Update for files that have been modified starting July 2008

Reviewed-by: ohair, tbell
 2008-10-02 19:58:19 -07:00
Erik Trimble
b089627fe8 6755406: minor mistakes in copyright notices 
Mismatch in some header copyrights from standard templates

Reviewed-by: jcoomes
 2008-10-02 14:11:33 -07:00
Jon Masamitsu
6c19542a36 6660681: Incrementally reserve pages on win server 2003 for better large page affinity 
For windows server 2003 added option to reserve large pages individually.

Reviewed-by: alanb, jcoomes, tonyp, apetrusenko
 2008-10-02 12:01:08 -07:00
Vladimir Kozlov
adce6fc49a 6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop 
Fix loop's probability. Add optimizations to avoid spilling. Change InlineSmallCode to product flag.

Reviewed-by: never
 2008-10-02 08:37:44 -07:00
Daniel D. Daugherty
7eacf5061e Merge 2008-10-02 06:54:46 -07:00
Karen Kinnear
5b60edebb8 Merge 2008-10-01 20:15:03 -04:00
Erik Trimble
bd1d9eea88 Merge 2008-10-01 16:57:40 -07:00
Erik Trimble
59f2891c07 6754998: Update Hotspot version for hs14 b06 
Bump Hotspot build number to 06

Reviewed-by: jcoomes
 2008-10-01 16:57:19 -07:00
Antonios Printezis
c8006a68d5 Merge 2008-10-01 15:05:06 -04:00
Chuck Rasbold
453d1a42b0 Merge 2008-09-30 15:53:55 -07:00
John Coomes
e98b7ce059 6729594: par compact - remove unused block table implementation 
Reviewed-by: tonyp, jmasa, apetrusenko
 2008-09-30 13:15:27 -07:00
John Coomes
f2851186bb 6725697: par compact - rename class ChunkData to RegionData 
Reviewed-by: iveresov, tonyp
 2008-09-30 12:20:22 -07:00
Tom Rodriguez
d40b6daac9 6753795: HotSpot crash in strlen() when JVMTI is used 
Test for null instead of strlen

Reviewed-by: rasbold
 2008-09-30 11:56:01 -07:00
John Coomes
2e52e9dff2 6716466: par compact - remove VerifyParallelOldWithMarkSweep code 
Reviewed-by: jmasa
 2008-09-30 11:49:31 -07:00
Karen Kinnear
056f3ea7aa Merge 2008-09-30 12:24:27 -04:00
Igor Veresov
4204f82a1a 6740923: NUMA allocator: Ensure the progress of adaptive chunk resizing 
Treat a chuck where the allocation has failed as fully used.

Reviewed-by: ysr
 2008-09-27 00:33:13 -07:00
Coleen Phillimore
32addb490d 6719149: Wrong "java/lang/String should not be loaded yet" assertion in fastdebug bits with UseStringCache 
Assertion is invalid because java.lang.String may be initialized just before this assertion.

Reviewed-by: phh
 2008-09-26 13:33:15 -04:00
Xiomara Jayasena
20563e146d Added tag jdk7-b36 for changeset c347afc55218 2008-09-25 12:53:55 -07:00
Volker Simonis
ac161a1e17 6744783: HotSpot segfaults if given -XX options with an empty string argument 
Reviewed-by: kamg, kvn
 2008-09-25 12:50:51 -07:00
Chuck Rasbold
42be28cece 6750588: assert(lrg._area >= 0,"negative spill area") running NSK stmp0101 test 
Handle NaN costs more carefully

Reviewed-by: kvn, never
 2008-09-24 15:56:36 -07:00
Andrey Petrusenko
fe4cab6eeb Merge 2008-09-24 15:34:06 -04:00
Vladimir Kozlov
b15796424e 6747051: Improve code and implicit null check generation for compressed oops 
Push DecodeN node below the Null check to the non-null path to use the mach node without 0 test.

Reviewed-by: rasbold, never
 2008-09-23 12:29:06 -07:00
Antonios Printezis
c03ab32ab5 6742641: G1: NullPointerException during GCOld 
An update buffer is not processed correctly, which causes roots into the collection set not to be scanned and, hence, for the heap to be corrupted. The cause is that an object is accessed after it has been explicitly deleted, which causes a race.

Reviewed-by: jcoomes, ysr
 2008-09-22 09:56:49 -04:00
Erik Trimble
0dc0bf82b2 6749707: Update build number for HS14 B05 
Bump the build number for hs14 b05

Reviewed-by: jcoomes
 2008-09-17 18:11:40 -07:00
Erik Trimble
ff12384283 Merge 2008-09-17 18:02:38 -07:00
Tom Rodriguez
4b1e242299 6384206: Phis which are later unneeded are impairing our ability to inline based on static types 
Reviewed-by: rasbold, jrose
 2008-09-17 12:59:52 -07:00
Andrey Petrusenko
1d67e1d25c Merge 2008-09-17 19:59:35 +04:00
Chuck Rasbold
eee15b163e 6711100: 64bit fastdebug server vm crashes with assert(_base == Int,"Not an Int") 
Insert CastII nodes to narrow type of load_array_length() node

Reviewed-by: never, kvn
 2008-09-17 08:29:17 -07:00
Andrey Petrusenko
b6aabd98fc Merge 2008-09-17 16:49:18 +04:00
Chuck Rasbold
2cd5cbcaca Merge 2008-09-15 09:58:26 -07:00
Daniel D. Daugherty
c8a7806d4f Merge 2008-09-12 07:04:34 -07:00
Xiomara Jayasena
3477036199 Added tag jdk7-b35 for changeset cd4deb70bf5e 2008-09-11 11:25:43 -07:00
Kelly O'Hair
68141df565 6745363: Add ability to run packtest to hotspot/test/makefile 
Reviewed-by: ksrini
 2008-09-11 11:04:55 -07:00
Karen Kinnear
da33a7de28 Merge 2008-09-11 09:02:02 -04:00
Vladimir Kozlov
9812da470c 6746907: Improve implicit null check generation 
Add missing implicit null check cases.

Reviewed-by: never
 2008-09-10 20:44:47 -07:00
Vladimir Kozlov
659ca734bb 6706829: Compressed Oops: add debug info for narrow oops 
Add support for narrow oops in debug info to avoid decoding.

Reviewed-by: rasbold, never
 2008-09-10 18:23:32 -07:00
Vladimir Kozlov
63c98ed888 6746892: Register Allocator does not process a data phi with one unique input correctly 
Always look for the existing phi for a processed live_range.

Reviewed-by: rasbold
 2008-09-10 14:29:32 -07:00
Karen Kinnear
de1b872a4e Merge 2008-09-10 12:31:26 -04:00
Chuck Rasbold
647d4a829d Merge 2008-09-10 06:15:02 -07:00
Tom Rodriguez
ae1dc3db15 6746320: Hotspot regression test for 6512111 fails in -Xmixed mode 
Reviewed-by: kvn
 2008-09-09 12:56:51 -07:00