Commit Graph

1177 Commits

Author SHA1 Message Date
Jonathan Gibbons
454f9f9fd0 8225748: Use SHA-256 for javap classfile checksum
Reviewed-by: mchung
2019-06-18 11:52:57 -07:00
Jesper Wilhelmsson
dc82364e05 Merge 2019-06-18 22:48:27 +02:00
Joe Darcy
51cf24fcc0 8222369: ExecutableElement.getReceiverType returns null instead of NOTYPE
Reviewed-by: jjg
2019-06-13 16:39:20 -07:00
Joe Darcy
aeedfd44b0 8164819: Make javac's toString() on annotation objects consistent with core reflection
Reviewed-by: jjg, coleenp
2019-06-13 11:50:45 -07:00
Jan Lahoda
1dd6e7a3eb 8226522: No compilation error reported when yield is used in incorrect context
Reviewed-by: mcimadamore
2019-07-02 09:14:51 +02:00
Hannes Wallnöfer
3353016bbc 8225671: Support HTML 5 character references in javadoc
Reviewed-by: jjg
2019-06-12 23:21:24 +02:00
Jan Lahoda
d9407ce428 8220018: javac crash when compiling try-catch-finally inside switch expression
Correcting handling of finally that yields from a switch expression.

Reviewed-by: mcimadamore, jlahoda
2019-06-12 13:49:43 +02:00
Joe Darcy
4750064828 8214546: Start of release updates for JDK 14
8214547: Add SourceVersion.RELEASE_14
8214548: Add source 14 and target 14 to javac
8214549: Bump maximum recognized class file version to 58 for JDK 14

Reviewed-by: jjg, mikael, erikj, jlahoda, dholmes
2019-06-11 16:45:20 -07:00
Jan Lahoda
b34b2d993c 8223305: Compiler support for Switch Expressions
Reviewed-by: mcimadamore, vromero
2019-06-10 05:09:52 +02:00
Jim Laskey
08e1ece107 8223967: Implement Text Blocks (Preview) in the Java compiler
Reviewed-by: vromero, jlahoda, abuckley
2019-06-06 12:24:44 -03:00
Vicente Romero
43114a091a 8225386: test for JDK-8216261 fails in Windows
Reviewed-by: jjg
2019-06-05 21:50:29 -04:00
Vicente Romero
d69bc696f2 8223942: Missing methods in ClientCodeWrapper$WrappedJavaFileManager
Reviewed-by: jjg
2019-06-05 17:01:43 -04:00
Vicente Romero
16a0533eac 8216261: Javap ignores default modifier on interfaces
Reviewed-by: jjg, darcy
2019-06-05 16:01:50 -04:00
Jonathan Gibbons
45f6ff3894 8223805: DocCommentParser should allow for <main> and </main>
Reviewed-by: hannesw
2019-06-04 11:29:29 -07:00
Joe Darcy
bcd13b790f 8224687: Add clarifying overrides of Element.asType to more specific subinterfaces
Reviewed-by: jjg
2019-05-30 16:21:08 -07:00
Athijegannathan Sundararajan
90fb4990ed 8224946: jrtfs URI to Path and Path to URI conversions are wrong
Reviewed-by: alanb
2019-05-30 17:30:33 +05:30
Jim Laskey
4e83c1c4dc 8224908: Revert: 8216553: JrtFileSystemProvider getPath(URI) omits /modules element from file path
Reviewed-by: darcy, kbarrett
2019-05-28 16:51:28 -03:00
Athijegannathan Sundararajan
0c724506b8 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path
Reviewed-by: alanb, jlaskey
2019-05-28 19:30:30 +05:30
Jan Lahoda
0112514fde 8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH
Allow --add-modules ALL-MODULE-PATH when compiling in the context of an automatic module.

Reviewed-by: jjg
2019-05-24 12:25:18 +02:00
Joe Darcy
4dd6b687ef 8224177: Harden annotation processing framework to irregular behavior from processors
Reviewed-by: jjg
2019-05-23 18:47:24 -07:00
Jan Lahoda
08193be19c 8224031: Cannot parse switch expressions after type cast
Correctly categorize parentheses followed by the switch keyword as cast.

Reviewed-by: mcimadamore
2019-05-16 16:42:14 +02:00
Jan Lahoda
b32a840e53 8222169: java.lang.AssertionError switch expression in ternary operator - ?
Ensure the stack size recoded at the begining of the let expression is the correct one.

Co-authored-by: Vicente Romero <vicente.romero@oracle.com>
Reviewed-by: vromero
2019-05-16 10:52:36 +02:00
Vicente Romero
23278fea38 8215470: Bad EnclosingMethod attribute on classes declared in lambdas
Reviewed-by: mcimadamore
2019-05-14 11:28:44 -04:00
Vicente Romero
40155b14cd 8222251: preflow visitor is not visiting lambda expressions
Reviewed-by: mcimadamore
2019-05-09 10:04:33 -04:00
Vicente Romero
c98fb7d64b 8222949: add condy support to javac's pool API
Reviewed-by: mcimadamore
2019-05-08 10:10:54 -04:00
Lance Andersen
5a4cef05d6 8218875: Add new FileSystems.newFileSystem methods
Reviewed-by: rriggs, alanb, clanger, dfuchs
2019-05-02 17:08:03 -04:00
Joe Darcy
75471b411d 8146726: Improve AbstractProcessor to issue warnings for repeated information
Reviewed-by: jjg, smarks, serb, igerasim
2019-05-01 16:47:26 -07:00
Steve Groeger
7c55d53d66 8218152: [javac] fails and exits with no error if a bad annotation processor provided
Handle exceptions thrown while loading annotation processors.

Reviewed-by: jlahoda
2019-04-30 10:39:22 +02:00
Maurizio Cimadamore
7b7f9a6fd3 8222289: Overhaul logic for reading/writing constant pool entries
Rewrite of Pool,ClassReader,ClassWriter to use shared pool helper components

Reviewed-by: vromero
2019-04-17 15:37:20 +01:00
Joe Darcy
4a9f7612be 8222430: Add tests for ElementKind predicates
Reviewed-by: jjg
2019-04-15 16:05:46 -07:00
Joe Darcy
7d29dd2172 8222378: Provide mechanism to query preview feature status for annotation processors
Reviewed-by: jjg
2019-04-15 15:44:42 -07:00
Martin Doerr
f2369e9748 8220625: tools/javac/classreader/8171132/BadConstantValue.java failed with "did not see expected error"
Reviewed-by: clanger
2019-04-15 10:16:04 +02:00
Jan Lahoda
28dd6d8496 8217047: Provide a way to inject missing parameter names
Adding a way to provide parameter names that are missing in the classfiles.

Reviewed-by: darcy, jjg
2019-04-11 17:55:18 +02:00
Jan Lahoda
ae5972a204 8215407: javac should reject class files with bad EnclosingMethod attributes
Reject classfiles with broken EnclosingMethod attribute.

Reviewed-by: jjg
2019-04-11 14:49:04 +02:00
Vicente Romero
2468ac91ee 8222035: minimal inference context optimization is forcing resolution with incomplete constraints
Reviewed-by: mcimadamore, cushon
2019-04-10 17:15:53 -04:00
Ron Shapiro
b6cdfa908f 8221118: Avoid eagerly creating JCDiagnostic for CompletionFailures
Reviewed-by: jjg, mcimadamore, forax
2019-03-29 07:38:34 -07:00
Liam Miller-Cushon
b0f6b1086a 8220632: Suggest recompiling with a larger value of -Xmaxerrs/-Xmaxwarns if diagnostics were suppressed
Reviewed-by: jjg
2019-03-26 16:09:33 -07:00
Jan Lahoda
4969d23b89 8221413: javac does not recognize variable assigned in switch expression as DA
Fixing definite assignment in presence of implicit throws clause in switch expressions over enums.

Reviewed-by: vromero
2019-03-28 10:32:05 +01:00
Liam Miller-Cushon
31f64932c3 8220687: Add StandardJavaFileManager.getJavaFileObjectsFromPaths overload
Reviewed-by: jjg
2019-03-26 15:00:02 -07:00
Christoph Langer
1a48fa0fb7 8200286: (testbug) MOptionTest test fails with java.lang.AssertionError: Classfiles too old!
Reviewed-by: stuefe, jjg
2019-03-22 08:56:30 +01:00
Jonathan Gibbons
d3242724c9 8220379: Fix doclint handling of headings
Reviewed-by: erikj, jlahoda
2019-03-14 11:39:00 -07:00
Liam Miller-Cushon
0720686823 8193277: SimpleFileObject inconsistency between getName and getShortName
Reviewed-by: jjg
2019-03-05 12:01:04 -08:00
Liam Miller-Cushon
ab3f5e3e15 8220634: SymLinkArchiveTest should handle not being able to create symlinks
Reviewed-by: jjg
2019-03-13 17:26:21 -07:00
Jan Lahoda
76c916516c 8217868: Crash for overlap between source path and patch module path
When analyzing implicit files, do not look for containing module, but rather use the already known one.

Reviewed-by: jjg
2019-03-04 10:19:35 +01:00
Christoph Langer
8bec32b02f 8219915: [TESTBUG] Fix test langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java in Standalone mode
Reviewed-by: jlahoda
2019-03-01 10:15:04 +00:00
Priya Lakshmi Muthuswamy
151e628a8e 8215584: Remove support for the "old" doclet API in com/sun/javadoc
Reviewed-by: jjg, hannesw
2019-02-22 11:10:55 +05:30
Joe Darcy
bf2d27c5a4 8219254: Update explicit uses of latest source/target in langtools tests to a property
8219256: Update javac diags tests to use properties

Co-authored-by: Jonathan Gibbons <jonathan.gibbons@oracle.com>
Reviewed-by: jjg, jlahoda, darcy, iignatyev
2019-02-21 10:29:16 -08:00
Harold Seigel
dd7e50dc01 8214719: Deprecate -Xverify:none option
Deprecate -Xverify:none and -noverify and remove them from tests

Reviewed-by: dholmes, mikael
2019-02-20 13:21:36 -05:00
Jan Lahoda
68d32a9a8a 8217381: Incovenient errors reported when annotation processor generates source file and errors in the same round
When an annotation processor reports and error, defer reporting recoverable errors from the erroneous round to the last round, to avoid reporting errors that were resolved in the erroneous round.

Reviewed-by: jjg
2019-02-15 12:09:53 +01:00
Srinivas Dama
37169f4bbc 8201544: Improve javac command line parsing and error reporting
Modified exception into an error message for invalid filenames on windows

Reviewed-by: vromero, jjg
2019-02-14 21:52:39 +05:30
Bernard Blaser
777ad9080e 8193367: Annotated type variable bounds crash javac
Reviewed-by: mcimadamore, vromero
2019-01-26 15:50:59 +01:00
Jonathan Gibbons
6326bf224e 8217395: Update langtools shell tests to use ${EXE_SUFFIX}
Reviewed-by: darcy
2019-01-18 12:41:11 -08:00
Bernard Blaser
454cbfacaa 8214345: infinite recursion while checking super class
Reviewed-by: vromero
2019-01-18 13:49:45 -05:00
Vicente Romero
ae0cb515d6 8215482: check for cycles in type variables can provoke NPE
Reviewed-by: mcimadamore
2019-01-14 12:24:25 -05:00
Joe Darcy
5ad47c58a3 8208371: Provided supported mechanims to create a ModuleElement for an unnamed module
Reviewed-by: jjg
2019-01-11 09:57:15 -08:00
Joe Darcy
f68fd6a1c2 8216404: Elements.getPackageOf should handle modules
Reviewed-by: jlahoda
2019-01-10 10:34:30 -08:00
Jesper Wilhelmsson
67a5fc2529 Merge 2019-01-09 22:59:49 +01:00
Jim Laskey
11b29c8de1 8215681: Remove compiler support for Raw String Literals from JDK 12
Reviewed-by: mcimadamore, jlahoda, sundar
2019-01-09 11:13:00 -04:00
Srinivas Dama
ead8577920 8208184: IllegalArgumentException while invoking code completion on netbeans IDE
Set Log.useSource and fix the issue in Modules.java when broken module is encountered

Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2018-12-24 12:18:40 +05:30
Vicente Romero
f398c3dcd2 8215625: javax/sql/testng/util/xxxxx.java tests compilation failed after JDK-8207224
Reviewed-by: mcimadamore
2018-12-19 14:02:19 -05:00
Vicente Romero
8b6b63b38b 8207224: Javac compiles source code despite illegal use of unchecked conversions
Reviewed-by: mcimadamore, darcy
2018-12-18 16:22:46 -05:00
Alan Bateman
888057a89f 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny
Reviewed-by: redestad, mchung, jjg
2018-12-18 10:26:15 +00:00
Joe Darcy
b5f0eec3d8 8205626: Start of release updates for JDK 13
8205393: Add SourceVersion.RELEASE_13
8205394: Add source 13 and target 13 to javac
8205645: Bump maximum recognized class file version to 57 for JDK 13
8214825: Update preview language features for start of JDK 13

Reviewed-by: erikj, alanb, mchung, mcimadamore, dholmes, smarks, jjg
2018-12-13 19:06:11 +01:00
Priya Lakshmi Muthuswamy
9d967e70fc 8214468: jQuery UI upgrade from 1.11.4 to 1.12.1
Reviewed-by: hannesw
2018-12-12 13:01:29 +05:30
Srinivas Dama
2f34c5ac6a 8208184: IllegalArgumentException while invoking code completion on netbeans IDE
Set Log.useSource and fix the issue in Modules.java when broken module is encountered

Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com>
Reviewed-by: jjg
2019-01-03 11:21:11 +05:30
Jan Lahoda
655c5d7f35 8214114: Switch expressions with try-catch statements
When switch expression contains try-catch, move the stack values into locals before the executing the switch expression, and back when it is done.

Reviewed-by: mcimadamore, vromero
2018-12-11 09:10:24 +01:00
Harold Seigel
5a23b59ca0 8215015: [TESTBUG] remove unneeded -Xfuture option from tests
Remove the option from the tests

Reviewed-by: lfoltan, coleenp
2018-12-10 13:24:17 -05:00
Vicente Romero
9846588b31 8210031: implementation for JVM Constants API
Co-authored-by: Brian Goetz <brian.goetz@oracle.com>
Reviewed-by: jrose, mcimadamore, darcy, mchung, rriggs, dholmes, forax
2018-12-09 12:36:24 -05:00
Hannes Wallnöfer
c0099a8a0d 8214571: -Xdoclint of array serialField gives "error: array type not allowed here"
Reviewed-by: jjg, sundar
2018-12-06 12:34:28 +01:00
Liam Miller-Cushon
7f365fffbd 8214902: Pretty-printing marker annotations add unnecessary parenthesis
Reviewed-by: jjg
2018-12-05 11:31:20 -08:00
Vicente Romero
a4d8574130 8213703: LambdaConversionException: Invalid receiver type not a subtype of implementation type interface
Reviewed-by: mcimadamore
2018-12-05 09:34:01 -05:00
Jan Lahoda
504dfa5de0 8214529: Exception while using Anonymous class in switch expression
Clearing breakResult when creating methodEnv.

Reviewed-by: mcimadamore
2018-12-03 14:25:00 +01:00
Jan Lahoda
835c863ba8 8214031: Assertion error in value break statement with conditional operator in switch expression
Correcting handling of boolean-valued switch expressions when true/false; generating them directly rather than desugaring in Lower.

Reviewed-by: mcimadamore
2018-12-03 10:37:36 +01:00
Srikanth Adayapalam
10d83827bc 8206325: AssertionError in TypeSymbol.getAnnotationTypeMetadata
Reviewed-by: mcimadamore
2018-11-30 10:37:48 +05:30
Liam Miller-Cushon
bddbbd85f9 8214026: Canonicalized archive paths appearing in diagnostics
Reviewed-by: vromero
2018-11-19 15:01:59 -08:00
Vicente Romero
10da56f017 8203277: preflow visitor used during lambda attribution shouldn't visit class definitions inside the lambda body
Reviewed-by: mcimadamore
2018-11-27 11:07:44 -05:00
Jan Lahoda
06b1502892 8214113: Switch expressions may have constant type and may be skipped during write
Switch expressions should not be compile-time constants.

Reviewed-by: mcimadamore
2018-11-26 09:24:08 +01:00
Mandy Chung
b2604123d3 8214223: tools/jdeps/listdeps/ListModuleDeps.java failed due to missing Lib2 file
Reviewed-by: lancea, alanb
2018-11-22 10:15:32 -08:00
Hannes Wallnöfer
c047c5cfcf 8200432: javadoc fails with ClassCastException on {@link byte[]}
Reviewed-by: jjg, sundar
2018-11-22 15:38:20 +01:00
Mandy Chung
0126fdbef0 8213909: jdeps --print-module-deps should report missing dependences
8168869: jdeps: localized messages don't use proper line breaks

Reviewed-by: sundar
2018-11-21 22:34:01 -08:00
Mandy Chung
9d7509e647 8211051: jdeps usage of --dot-output doesn't provide valid output for modular jar
Reviewed-by: sundar
2018-11-21 22:33:33 -08:00
Jan Lahoda
60b32f222f 8212982: Rule cases in switch expression accepted even if complete normally
Ensure an error is reported if switch expression does not correctly produce a value.

Reviewed-by: mcimadamore
2018-11-21 15:22:57 +01:00
Liam Miller-Cushon
4a235517f9 8213908: AssertionError in DeferredAttr at setOverloadKind
Reviewed-by: mcimadamore
2018-11-19 09:57:41 -08:00
Srinivas Dama
e4f60a8489 8210742: compound var declaration type is not uniform for all variables
Make implicit type for all variables in compound declaration as null for which type inference happens at later phase

Reviewed-by: mcimadamore
2018-11-20 21:59:07 +05:30
Liam Miller-Cushon
4cdf0c4c1d 8214071: Broken msg.bug diagnostics when using the compiler API
Reviewed-by: jjg
2018-11-19 10:47:38 -08:00
Jan Lahoda
c963d543d2 8209055: c.s.t.javac.code.DeferredCompletionFailureHandler seems to use WeakHashMap incorrectly
Do not keep speculative Symbols in DeferredCompletionFailureHandler.

Reviewed-by: jjg, vromero
2018-11-12 09:35:23 +00:00
Priya Lakshmi Muthuswamy
50dc5ef396 5076751: System properties documentation needed in javadocs
Reviewed-by: jjg
2018-11-12 13:31:41 +05:30
Vicente Romero
0ec4944be7 8211450: UndetVar::dup is not copying the kind field to the duplicated instance
Reviewed-by: mcimadamore
2018-11-08 18:23:52 -05:00
Vicente Romero
7d4e8d0e26 8210197: javac can't tell during speculative attribution if a diamond expression is creating an anonymous inner class or not
Reviewed-by: mcimadamore
2018-11-08 10:36:06 -05:00
Jan Lahoda
fdb010502b 8213103: RoundEnvironment.getElementsAnnotatedWith(Class) crashes with -source 8
Correct handling of missing annotation with -source 8.

Reviewed-by: darcy, jjg, vromero
2018-11-05 10:31:47 +01:00
Jonathan Gibbons
72bfdd96f1 8213265: fix missing newlines at end of files
Reviewed-by: darcy
2018-11-01 15:11:08 -07:00
Jonathan Gibbons
73fa99ae86 8213263: fix legal headers in test/langtools
Reviewed-by: darcy
2018-11-01 14:32:55 -07:00
Vicente Romero
d0696b538a 8213100: fix test OptionSmokeTest before removing it from the problem list
Reviewed-by: jlahoda
2018-10-29 17:09:44 -04:00
Liam Miller-Cushon
d9095c4a72 8198945: Invalid RuntimeVisibleTypeAnnotations for annotation on anonymous class type parameter
Reviewed-by: wmdietl, abuckley, martin
2018-09-17 11:09:43 -07:00
Joe Darcy
34397c4914 8212718: Refactor some annotation processor tests to better use collections
Reviewed-by: jlaskey, vromero
2018-10-23 10:32:39 -07:00
Vicente Romero
1ed6b88a99 8209407: VerifyError is thrown for inner class with lambda
Reviewed-by: mcimadamore
2018-10-08 06:52:41 -07:00
Vicente Romero
609d90e98a 8210789: langtools/tools/javac/T8152616.java missing @modules
Reviewed-by: jjg
2018-10-04 10:19:01 -07:00
Vicente Romero
2589e9733e 8211148: var in implicit lambdas shouldn't be accepted for source < 11
Reviewed-by: mcimadamore
2018-10-04 08:37:08 -07:00
Jim Laskey
c30dffb388 8211080: RawStringLiteralLangAPI.java test times out by default
Reviewed-by: jjg
2018-09-27 15:47:33 -03:00
Jan Lahoda
17c3d1c333 8211102: Crash with -XDfind=lambda and -source 7
Disabling analyzers that cannot run in the given source level; lambdas in standalone positions should have erroneous type rather than the recovery type; avoiding crash in Flow for broken code.

Reviewed-by: mcimadamore
2018-09-27 10:24:12 +02:00
Jonathan Gibbons
db6295f8a2 8209963: source file mode for JVM should provide a hook to locate the source file
Reviewed-by: darcy
2018-09-26 16:23:31 -07:00
Jonathan Gibbons
065fdac559 8210555: create --source --target synonyms for -source -target
Reviewed-by: hannesw
2018-09-26 15:14:17 -07:00
Jonathan Gibbons
25ca76b4f9 8211180: SourceLauncherTest.java fails in JDK12 CI on Win*
Reviewed-by: mchung, darcy
2018-09-26 14:54:38 -07:00
Jonathan Gibbons
cad60d14a6 8210274: Source Launcher should work with a security manager
Reviewed-by: mchung, alanb
2018-09-26 11:41:08 -07:00
Liam Miller-Cushon
9c60728a28 8211138: Missing Flag enum constants
Reviewed-by: mcimadamore, vromero
2018-09-25 21:33:51 -07:00
Jonathan Gibbons
59fd35292e 8210839: Improve interaction between source launcher and classpath
Reviewed-by: alanb, mchung
2018-09-25 10:30:32 -07:00
Jonathan Gibbons
8edf8e2b03 8210275: Source Launcher should fail if --source is used without a source file
Reviewed-by: mchung, alanb, mcimadamore
2018-09-21 15:38:43 -07:00
Jan Lahoda
3f43390b8b 8209058: Cannot find annotation method 'value()' in type 'Profile+Annotation'
Correct detection of the Profile+Annotation synthetic annotation for classes that are not from the java.base module.

Reviewed-by: jjg
2018-09-21 12:29:46 +02:00
Jan Lahoda
c1033edca8 8209865: Incorrect 'multiple elements' notes with Elements#getTypeElement and --release
Changing ct.sym to be module-path oriented, rather than class-path oriented.

Reviewed-by: jjg
2018-09-21 12:29:31 +02:00
Vicente Romero
29fec64583 8209022: Missing checkcast when casting to type parameter bounded by intersection type
Reviewed-by: mcimadamore
2018-09-20 12:49:58 -07:00
Jan Lahoda
52ba129b0a 8207954: Data for --release 11
Adding support for --release 11

Reviewed-by: erikj, ihse, jjg
2018-09-19 10:50:25 +02:00
Jan Lahoda
ee0ac147a2 8193561: Cyclic hierarchy causes a NullPointerException when setting DEFAULT flag
When marking interface as having default methods, use .owner as it is always defined.

Reviewed-by: mcimadamore
2018-09-17 11:49:20 +02:00
Bernard Blaser
8ef50b1dc3 8183548: Comma-expressions shouldn't use any temporary variable
Uses enhanced let-expressions allowing multiple statements

Reviewed-by: vromero
2018-09-15 22:16:16 +02:00
Liam Miller-Cushon
8b3c1810d2 8193037: package-info annotations are not reported when annotation processing is enabled
Reviewed-by: jjg
2018-09-13 15:29:44 -07:00
Jim Laskey
734a258afb 8210674: Need to add examples for use of javac properties introduced by Raw String Literals
Reviewed-by: vromero, jjg
2018-09-13 14:15:27 -03:00
Liam Miller-Cushon
7afa8e42b6 8210483: AssertionError in DeferredAttr at setOverloadKind caused by JDK-8203679
Reviewed-by: mcimadamore, vromero
2018-09-10 16:59:41 -07:00
Vicente Romero
cf26c4cc5c 8207160: ClassReader::adjustMethodParams can potentially return null if the args list is empty
Reviewed-by: mcimadamore, cushon
2018-09-12 16:28:06 -07:00
Jim Laskey
d2b04cb964 8210671: CheckExamples.java fail after Raw String Literals checkin
Reviewed-by: vromero, darcy
2018-09-12 17:14:08 -03:00
Jim Laskey
2065ebd890 8206981: Compiler support for Raw String Literals
Reviewed-by: mcimadamore, briangoetz, abuckley, jjg, vromero, jlahoda
2018-09-12 14:19:36 -03:00
Mandy Chung
cfb0662ff6 8210502: jdeps does not handle properly on analyzing a mixture of MR JARs and non-MR JARs
Reviewed-by: alanb
2018-09-10 12:48:57 -07:00
Maurizio Cimadamore
c0d51dc514 8210495: compiler crashes because of illegal signature in otherwise legal code
Disable strict verification of compiler signatures when they do not affect generated bytecode

Reviewed-by: vromero
2018-09-07 15:56:21 +01:00
Jonathan Gibbons
84cf73f2a5 8210009: Source Launcher classloader should support getResource and getResourceAsStream
Reviewed-by: mchung, plevart
2018-09-06 16:15:32 -07:00
Vicente Romero
d0f7d4e374 8210435: don't add local variable spots if they are DCE'ed by the compiler
Reviewed-by: mcimadamore
2018-09-06 05:44:47 -07:00
Jonathan Gibbons
c8d641d148 8208608: Update --module-source-path to allow explicit source paths for specific modules
Reviewed-by: jlahoda
2018-08-31 14:54:42 -07:00
Jan Lahoda
b3b644438e 8206986: Compiler support for Switch Expressions (Preview)
8207405: Compiler Tree API support for Switch Expressions (Preview)

Support for switch expression, switch with rules and multiple constants for cases.

Reviewed-by: jjg, mcimadamore, vromero
2018-08-29 09:36:17 +02:00
Vicente Romero
b2ebbe6460 8209173: javac fails with completion exception while reporting an error
Reviewed-by: mcimadamore
2018-08-24 13:30:56 -07:00
Vicente Romero
efa05e1c62 8207320: Wrong type order for intersection lambdas with multiple abstract methods
Reviewed-by: mcimadamore
2018-08-15 13:39:32 -07:00
Jonathan Gibbons
f0e9643542 8208227: tools/jdeps/DotFileTest.java fails on Win-X64
Reviewed-by: darcy
2018-07-25 17:26:35 -07:00
Joe Darcy
ac5685e827 8190886: package-info handling in RoundEnvironment.getElementsAnnotatedWith
Reviewed-by: vromero, jlahoda
2018-07-25 12:32:59 -07:00
Vicente Romero
8e61321b6c 8205493: OptionSmokeTest.java uses hard-coded release values
Reviewed-by: darcy
2018-07-20 14:48:41 -07:00
Joe Darcy
fafd1b7536 8193462: Fix Filer handling of package-info initial elements
Reviewed-by: vromero
2018-07-18 00:23:06 -07:00
Joe Darcy
19c364592c 8193214: Incorrect annotations.without.processors warnings with JDK 9
Reviewed-by: vromero
2018-07-18 00:16:37 -07:00
Vicente Romero
898e0f8607 8206874: Evaluate LoadClassFromJava6CreatedJarTest.java after dropping -source 6
Reviewed-by: darcy
2018-07-19 15:13:10 -07:00
Phil Race
28e828130d Merge 2018-07-19 10:17:22 -07:00
Jan Lahoda
66025558bb 8207229: Trees.getScope crashes for broken lambda
8207230: Trees.getScope runs Analyzers

Reviewed-by: vromero
2018-07-17 14:28:56 +02:00
Joe Darcy
a376d5dab4 8207248: Reduce incidence of compiler.warn.source.no.bootclasspath in javac tests
Reviewed-by: vromero
2018-07-16 21:53:49 -07:00
Jan Lahoda
fe80e55647 8189747: JDK9 javax.lang.model.util.Elements#getTypeElement regressed 1000x in performance
Caching the results of Elements.getTypeElement/getPackageElement

Reviewed-by: darcy
2018-07-16 12:35:25 +02:00
Joe Darcy
90518f0635 8028563: Remove javac support for 6/1.6 source and target values
Reviewed-by: jjg, erikj, henryjen
2018-07-12 14:13:15 -07:00
Joe Darcy
e18f343141 8207055: Make javac -help output for -source and -target more informative
Reviewed-by: jjg
2018-07-11 16:12:18 -07:00
Jesper Wilhelmsson
dafb3af62d Merge 2018-07-11 21:41:43 +02:00
Joe Darcy
03597d010c 8206439: Remove javac -source/-target 6 from langtools regression tests
Reviewed-by: mcimadamore
2018-07-06 10:28:56 -07:00
Joe Darcy
da22bf8a17 8206114: Refactor langtools/tools/javac/classfiles/ClassVersionChecker.java
Reviewed-by: jjg
2018-07-03 16:14:46 -07:00
Joe Darcy
28e2dea71d 8206085: Refactor langtools/tools/javac/versions/Versions.java
Reviewed-by: jjg, forax, plevart, mcimadamore
2018-07-03 15:59:09 -07:00
Liam Miller-Cushon
1fc1f68c3d 8204630: Generating an anonymous class with Filer#createClassFile causes an NPE in JavacProcessingEnvironment
Reviewed-by: jlahoda
2018-07-06 12:10:43 -07:00
Jan Lahoda
eaf0364068 8205418: Assorted improvements to source code model
Improving tree positions, better error recovery, fixing Trees.getScope for possibly erroneous lambdas.

Reviewed-by: jjg, mcimadamore, vromero
2018-06-29 10:41:10 +02:00
Joe Darcy
69191fc4cc 8206083: Make tools/javac/api/T6265137.java robust to JDK version changes
Reviewed-by: jjg
2018-06-28 17:49:13 -07:00
Jonathan Gibbons
3ae58c7fdc 8202959: Rearrange the top and bottom navigation bar in the javadoc generated pages
Co-authored-by: Bhavesh Patel <bhavesh.x.patel@oracle.com>
Reviewed-by: darcy, jjg
2018-06-28 15:46:27 -07:00
Joe Darcy
e56162b43d 8205615: Start of release updates for JDK 12
8205621: Increment JDK version for JDK 12
8193292: Add SourceVersion.RELEASE_12
8193290: Add source 12 and target 12 to javac
8205619: Bump maximum recognized class file version to 56 for JDK 12

Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Co-authored-by: Mikael Vidstedt <mikael.vidstedt@oracle.com>
Reviewed-by: alanb, smarks, jjg, mr, erikj, psandoz, dholmes
2018-06-27 21:01:12 -07:00
Jan Lahoda
152488eeee 8205913: Inconsistent source code model
Ensuring variable declarations have non-null modifiers and names.

Reviewed-by: mcimadamore
2018-06-28 10:05:43 +02:00
Jan Lahoda
2183a72fe3 8195986: Incorrect javac -h output with annotation processing and missing classes
When clearing out symbols for a new annotation processing round, preserve types when possible.

Reviewed-by: vromero
2018-06-28 10:05:39 +02:00
Stuart Marks
3e7196c114 8205455: jdeprscan issues annotation processor warning regarding RELEASE_10
Reviewed-by: jjg
2018-06-25 18:49:30 -07:00
Jonathan Gibbons
e2064980ff 8205563: modules/AnnotationProcessing.java failed testGenerateSingleModule
Reviewed-by: darcy
2018-07-02 17:54:36 -07:00
Jan Lahoda
af4bf0927b 8203814: javac --release=8 \"cannot find symbol\" for NashornException.getEcmaError()
Updating ct.sym data for jdk.scripting.nashorn to JDK8u102 version of the API.

Reviewed-by: hannesw
2018-06-25 12:44:52 +02:00
David Holmes
95bf19563b 8010319: Implementation of JEP 181: Nest-Based Access Control
Co-authored-by: Alex Buckley <alex.buckley@oracle.com>
Co-authored-by: Maurizio Mimadamore <maurizio.mimadamore@oracle.com>
Co-authored-by: Mandy Chung <mandy.chung@oracle.com>
Co-authored-by: Tobias Hartmann <tobias.hartmann@oracle.com>
Co-authored-by: Vlaidmir Ivanov <vladimir.x.ivanov@oracle.com>
Co-authored-by: Karen Kinnear <karen.kinnear@oracle.com>
Co-authored-by: Vladimir Kozlov <vladimir.kozlov@oracle.com>
Co-authored-by: John Rose <john.r.rose@oracle.com>
Co-authored-by: Daniel Smith <daniel.smith@oracle.com>
Co-authored-by: Serguei Spitsyn <serguei.spitsyn@oracle.com>
Co-authored-by: Kumar Srinivasan <kumardotsrinivasan@gmail.com>
Co-authored-by: Boris Ulasevich <boris.ulasevich@bell-sw.com>
Reviewed-by: alanb, psandoz, mchung, coleenp, acorn, mcimadamore, forax, jlahoda, sspitsyn, abuckley
2018-06-23 01:32:41 -04:00
Jan Lahoda
51c3a9d4d1 8195077: [Testbug] tools/javac/processing/model/completionfailure/NoAbortForBadClassFile.java - AccessDeniedException
Use a new working directory for each sub-test.

Reviewed-by: vromero
2018-06-22 11:26:55 +02:00
Jonathan Gibbons
820a5618c4 8205442: Avoid hard-coding --source value in SourceLauncherTest.java
Reviewed-by: darcy
2018-06-21 14:33:15 -07:00
Jonathan Gibbons
f0b244a4ac 8196425: tools/javac/modules/AnnotationProcessing.java failed
Reviewed-by: jlahoda
2018-06-21 13:29:44 -07:00
Bernard Blaser
07012c9753 8203338: Unboxing in return from lambda miscompiled to throw ClassCastException
Reviewed-by: mcimadamore, vromero
2018-06-20 10:01:49 -07:00
Maurizio Cimadamore
43248585b4 8195293: Issue more comprehensive warnings for use of \"var\" in earlier source versions
Issue warnings when 'var' used as a type name in type argument positions

Reviewed-by: jlahoda
2018-06-20 11:47:07 +01:00
Vicente Romero
58f944b75e 8205052: No compilation error thrown when no valid parameterization exists for functional interface type
Reviewed-by: mcimadamore
2018-06-19 05:22:07 -07:00
Mandy Chung
1a4997b484 8205116: jdeps --system $java.home fails with IAE
Reviewed-by: alanb, lancea
2018-06-15 13:08:32 -07:00
Priya Lakshmi Muthuswamy
0c633885f1 8204666: javadoc should be updated to use jQuery 3.3.1
Reviewed-by: sundar
2018-06-15 10:48:56 +05:30
Bernard Blaser
c97262c785 8203813: javac accepts an illegal name as a receiver parameter name
Reviewed-by: vromero
2018-06-14 05:50:21 -07:00
Jan Lahoda
5bf8a6f44b 8196618: Create API to list supported values for javac --release option
8194308: jdeprscan will need updates to deal with the removal of the Java EE modules

Generalizing tests to run over all supported --release keys; fixing jdeprscan to work with --release 11.

Reviewed-by: smarks, vromero
2018-06-14 13:16:21 +02:00
Maurizio Cimadamore
da3ff94812 8178150: Regression in logic for handling inference stuck constraints
Fix broken logic for input/output inference variable dependency

Reviewed-by: vromero, bsrbnd
2018-06-14 11:13:39 +01:00
Jan Lahoda
78b7362c97 8193302: Javac AssertionError: typeSig ERROR on usage of @Generated
Importing from an invisible package whose name is a prefix of a visible package is not allowed.

Reviewed-by: vromero
2018-06-13 12:52:21 +02:00
Liam Miller-Cushon
669c2f3951 8203679: AssertionError in DeferredAttr with parenthesized method reference
Reviewed-by: mcimadamore
2018-06-11 14:06:50 -07:00
Jan Lahoda
62a6e04db0 8204674: Inconsistent lambda parameter span
Correcting parameter spans for lambda parameters.

Reviewed-by: mcimadamore
2018-06-12 12:14:46 +02:00
Jonathan Gibbons
48d64563d2 8204588: Test failures after "Launch Single-File Source-Code Programs"
Reviewed-by: mchung
2018-06-08 15:24:51 -07:00
Maurizio Cimadamore
824b2d53ac 8204610: Compiler confused by parenthesized "this" in final fields assignments
Parenthesis are not skipped consistently in DA/DU, forward reference analysis

Reviewed-by: vromero
2018-06-08 16:33:40 +01:00
Jonathan Gibbons
fe24730ed9 8201274: Launch Single-File Source-Code Programs
Reviewed-by: mcimadamore, jlahoda, ksrini, mchung, ihse, alanb
2018-06-07 16:06:49 -07:00
Athijegannathan Sundararajan
f2a30dcb3e 8204321: javadoc tests fail after JDK-8203780
Reviewed-by: jjg
2018-06-05 23:10:54 +05:30
Jan Lahoda
8afe86a2fe 8200166: Repeating annotations refering to to-be-generated classes don't work
Reviewed-by: jjg
2018-06-05 14:55:13 +02:00
Bernard Blaser
8d24eeb394 8189335: javac exception when referencing private inner class with same name as normal class with dollar_1
Reviewed-by: vromero
2018-06-04 10:12:40 -07:00
Jan Lahoda
4dec1a457f 8198378: javac crash when checking imports and a broken class is present
Properly handling bad classfile while processing imports.

Reviewed-by: vromero
2018-06-04 12:54:13 +02:00
Jonathan Gibbons
8589446792 8196202: Javadoc should not generate frames by default
Reviewed-by: ksrini
2018-05-29 11:20:04 -07:00
Vicente Romero
539b18eba0 8203892: Target interface added as marker interface in calls to altMetafactory
Reviewed-by: mcimadamore
2018-05-29 09:12:39 -07:00
Jan Lahoda
6776b453e0 8193717: Import resolution performance regression in JDK 9
Avoiding iteration through all sub-scopes of single import scope when looking up by name by only using those that may contain the given name.

Reviewed-by: mcimadamore
2018-05-29 13:17:03 +02:00
Jan Lahoda
5635d6f937 8202832: cycle detection depends on ordering of requires directives
Ensuring cyclic dependencies among modules produce a compile-time error.

Reviewed-by: vromero
2018-05-29 10:53:55 +02:00
Srinivas Dama
080269eb20 8202178: type.getKind() for var is None instead of Error
Make sure var kind != None for instance variables without initialization

Reviewed-by: mcimadamore
2018-05-27 12:00:16 +05:30
Maurizio Cimadamore
d10e29af44 8203488: Remove error generation from TransTypes
Bridge clash errors should noty be reported in TransTypes (as they are already reported in the frontend); cleanup polysig call code.

Reviewed-by: vromero, cushon, forax
2018-05-24 11:13:42 +01:00
Jonathan Gibbons
d27d4d8df4 8202947: Fix minor issues with taglets
Reviewed-by: ksrini
2018-05-23 11:49:57 -07:00
Vicente Romero
3b38d1b418 8196048: thrown type variables should be roots in the minimum inference graph
Reviewed-by: mcimadamore
2018-05-22 09:01:44 -07:00
Jan Lahoda
c3cdecd32b 8198315: Incomplete classpath causes NPE in TransTypes
Avoid symbol completion while constructing error message.

Reviewed-by: mcimadamore
2018-05-22 12:26:17 +02:00
Maurizio Cimadamore
47d634e453 8203436: javac should fail early when emitting illegal signature attributes
Check that signature attributes do not contain non-denotable types

Reviewed-by: vromero
2018-05-22 13:37:05 +01:00
Vicente Romero
088dbd5ce8 8203486: skip type inference for non functional interface components of intersection types
Reviewed-by: mcimadamore
2018-05-21 12:27:21 -07:00
Vicente Romero
ec167413f9 8148354: Errors targeting functional interface intersection types
Reviewed-by: mcimadamore, dlsmith
2018-05-18 09:22:31 -07:00
Bernard Blaser
b416d3915e 8203398: Test test/langtools/tools/javac/options/release/ReleaseOptionCurrent.java writes into the source directory
Reviewed-by: jjg, jlahoda
2018-05-18 12:48:09 +02:00
Bhavesh Patel
7c66a1d6a2 8196201: Generate pages to list all classes and all packages in javadoc output
Reviewed-by: jjg
2018-05-17 12:59:53 -07:00
Vicente Romero
74b151103e 8194998: broken error message for subclass of interface with private method
Reviewed-by: mcimadamore
2018-05-11 10:39:04 -07:00
Vicente Romero
3b13b81625 8202597: javac is not inducing a notional interface if Object appears in an intersection type
Reviewed-by: mcimadamore
2018-05-08 17:12:54 -07:00
Jan Lahoda
81bad1fe6b 8202387: javac --release 11 not supported
Adding historical data for JDK 10; adding ability to produce the historical data incrementally.

Reviewed-by: erikj, forax, jjg
2018-05-07 10:37:46 +02:00
Jonathan Gibbons
cf20cdd06c 8194968: problem list actions for tools/javac/jvm/VerboseOutTest
Reviewed-by: vromero
2018-05-03 12:56:53 -07:00
Bernard Blaser
7dc011ccca 8202372: Diagnostic with incorrect line info generated when compiling lambda expression
Add tree position to speculative lambda tree

Reviewed-by: vromero, jlahoda
2018-05-02 15:29:55 +01:00
Joe Darcy
15ef60b350 8200478: For boxing conversion javac uses Long.valueOf which does not guarantee caching according to its javadoc
Reviewed-by: bpb
2018-04-25 22:12:06 -07:00
Bernard Blaser
fa434f6934 8202141: Unique symbols for .class
Reviewed-by: vromero, jlahoda
2018-04-25 09:45:45 -07:00
Kumar Srinivasan
3dfa260af9 8025091: VisibleMemberMap.java possible performance improvements
8198890: The standard doclet incorrectly produces wrong method signatures in certain cases

Reviewed-by: jjg
2018-04-24 11:54:03 -07:00
Vicente Romero
f69402ef44 8201281: Truncated error message with Incompatible : null
Reviewed-by: mcimadamore
2018-04-24 08:13:30 -07:00
Jan Lahoda
5333f197be 8207032: Compilation succeeds without checking readability when --add-exports used
Ensuring --add-exports are only propagated when the target module reads the exporting module.

Reviewed-by: vromero, jjg
2018-07-16 16:31:33 +02:00
Jan Lahoda
d103b59ac3 8189747: JDK9 javax.lang.model.util.Elements#getTypeElement regressed 1000x in performance
Caching the results of Elements.getTypeElement/getPackageElement

Reviewed-by: darcy
2018-07-16 12:58:49 +02:00
Vicente Romero
03a10ec7b2 8196433: use the new error diagnostic approach at javac.Main
Reviewed-by: jjg
2018-04-18 16:02:53 -04:00
Maurizio Cimadamore
85fbf32898 8201554: Disable failing tier1 test for JDK-8201498
Reviewed-by: jjg
2018-04-13 11:14:49 -07:00
Maurizio Cimadamore
19581edca2 8201498: test/langtools/tools/javac/diags/CheckExamples.java 6 errors occurred
Remove duplicate class names in diagnostic examples.

Reviewed-by: jlahoda
2018-04-13 16:23:56 +01:00
Maurizio Cimadamore
d9440e4e39 8199194: Add javac support for preview features
Add support for preview features and related command line options.

Reviewed-by: jjg
2018-04-12 13:55:20 +01:00
Jan Lahoda
594fb594ce 8189765: Improve error reporting for compiling against package not visible due to modules
When looking in other modules for an undefined Symbol, also look into the unnamed module.

Reviewed-by: mcimadamore
2018-04-12 09:23:34 +02:00
Bernard Blaser
9c570aaf85 8201440: javac should create unique DynamicMethodSymbols at LambdaToMethod
Reviewed-by: mcimadamore
2018-04-11 14:52:32 -04:00
Liam Miller-Cushon
999296bab2 8201251: The tests for JDK-8187247 should be under test/langtools
Reviewed-by: darcy
2018-04-06 08:58:22 -07:00
Vicente Romero
92ec4c52a8 8199744: Incorrect compiler message for ReceiverParameter in inner class constructor
Reviewed-by: mcimadamore
2018-04-06 09:15:09 -04:00
Liam Miller-Cushon
5acbe5ff92 8201194: Handle local variable declarations in lambda deduplication
Reviewed-by: vromero
2018-04-05 14:39:04 -07:00
Martin Buchholz
5c8c67c523 8200128: Fix some "annoations" typos
Reviewed-by: alanb
2018-04-05 09:36:01 -07:00
Vicente Romero
6a2e0a5a01 8198314: javac hidden options violate standard syntax for options
Reviewed-by: jjg
2018-04-03 23:58:52 -04:00
Maurizio Cimadamore
484ec0738e 8200355: local variable inference regression test generates classfile in test folder
LVTI harness should generate files in jtreg scratch dir

Reviewed-by: vromero
2018-03-28 14:24:17 +01:00
Maurizio Cimadamore
b7e53c1204 8200199: javac suggests to use var even when var is used
Local var analyzer should use synthetic var type position to decide if analysis is needed

Reviewed-by: jlahoda, vromero
2018-03-28 14:08:26 +01:00
Liam Miller-Cushon
debaf13f38 8200301: deduplicate lambda methods
Reviewed-by: vromero, mcimadamore
2018-03-27 13:48:16 -04:00
Jan Lahoda
5bff39c04f 8196519: Incomplete classpath causes infinite recursion in Resolve.isAccessible
ErrorType.getEnclosingType returns noType rather than self.

Reviewed-by: mcimadamore, cushon
2018-03-26 11:42:17 +02:00
Shinya Yoshida
ae2d2c8ff5 8199910: Compiler crashes with -g option and variables of intersection type inferred by var
Javac should skip non-denotable types in the LocalVariableTypeTable attribute

Reviewed-by: jlahoda
2018-03-23 16:53:54 +00:00
Jan Lahoda
01509e5b5e 8194978: Javac produces dead code for try-with-resource
For try-with-resources, using simplified distinct close code for try body and catch clause, to avoid creating multiple copies of the full finally code.

Reviewed-by: mcimadamore
2018-03-22 15:28:33 +01:00
Jan Lahoda
7b9d38622b 8198552: Multiple javac plugins do not work at the same time
Fixing handling of multiple -Xplugin, -Xdoclint: and -Xdoclint/packages: parameters.

Reviewed-by: jjg, vromero
2018-03-22 12:13:08 +01:00
Jan Lahoda
b0b8a51be1 8187950: javax.lang.model APIs throws CompletionFailure or a subtype of CompletionFailure
Catching CompletionFailures that would be thrown to API clients, and re-completing the symbols again when javac itself needs it.

Reviewed-by: cushon, jjg
2018-03-09 09:42:10 +01:00
Vicente Romero
c866d037bc 8199327: nuke var type name after a lambda has been accepted
Reviewed-by: mcimadamore
2018-03-08 10:28:46 -05:00
Bhavesh Patel
1780fdeae7 8182765: HTML5 must be the default javadoc codegen mode in the near future
Reviewed-by: jjg
2018-03-06 10:45:47 -08:00
Lance Andersen
9995861868 8197533: Move javax.transaction.xa to its own module
Reviewed-by: darcy, alanb, psandoz, ihse
2018-03-04 17:05:29 -05:00
Jonathan Gibbons
62ec6e6d1d 8186688: javax.lang.model.util.Elements.hides does not work correctly with interfaces
Reviewed-by: vromero, mcimadamore
2018-02-23 13:42:04 -08:00
Vicente Romero
25da45e26f 8198512: compiler support for local-variable syntax for lambda parameters
Reviewed-by: mcimadamore
2018-02-22 15:49:32 -05:00
Jan Lahoda
fc9a7d12a8 8198563: Test langtools/tools/javac/analyzer/AnonymousInAnonymous.java failing after JDK-8198502
Convert to lambda warning should not be provided for the tools/javac/analyzer/AnonymousInAnonymous.java test.

Reviewed-by: mcimadamore
2018-02-22 18:53:28 +01:00
Srinivas Dama
90b572b0c9 8198502: Exception at runtime due to lambda analyzer reattributes live AST
Create a deep copy of the original tree before conversion to lambda node

Reviewed-by: mcimadamore, vromero
2018-02-23 01:54:09 +05:30
Jan Lahoda
ddf6846500 8197439: Crash with -XDfind=lambda for anonymous class in anonymous class
Ensuring unresolvable anonymous classes are attributed.

Reviewed-by: mcimadamore, sadayapalam
2018-02-21 17:07:12 +01:00
Vicente Romero
4b6ab35c85 8198479: JDK build is broken by 8194892
Reviewed-by: sundar
2018-02-21 00:29:04 -05:00
Vicente Romero
2591c21c01 8194892: add compiler support for local-variable syntax for lambda parameters
Reviewed-by: mcimadamore
2018-02-20 11:45:16 -05:00
Lance Andersen
987c3a2d87 8190378: Removal of CORBA and Java EE modules
Reviewed-by: rriggs, alanb, mchung, erikj, goetz
2018-02-10 07:06:16 -05:00
Jesper Wilhelmsson
d7dd9d1027 Merge 2018-02-05 23:12:03 +01:00
Lana Steuck
845f7823de Merge 2018-02-09 02:23:34 +00:00
Jan Lahoda
d5ec9dbfb5 8194764: javac incorrectly flags deprecated for removal imports
Fixing source range for the Source.Feature.DEPRECATE_ON_IMPORT

Reviewed-by: mcimadamore
2018-02-07 16:49:24 +01:00
Srinivas Dama
6ff900807d 8152616: com.sun.tools.javac.tree.Pretty generates nested comments for enum
Fixed nested comments for enum

Reviewed-by: mcimadamore
2018-02-06 23:49:10 +05:30
Liam Miller-Cushon
24ae32f082 8190452: javac should not add MethodParameters attributes to v51 and earlier class files
Reviewed-by: vromero, jjg
2018-02-05 10:43:31 -05:00
Joe Darcy
dff176cc84 8196627: Update MultiReleaseJarAwareSJFM.java to be version agnostic
Reviewed-by: vromero
2018-02-02 10:31:05 -08:00
Joe Darcy
80f4b22956 8196623: Update JavaBaseTest.java to be version agnostic
Reviewed-by: vromero
2018-02-02 10:29:25 -08:00
Vicente Romero
5f7d996632 8196403: remove the remaining use of string keys for errors and warnings in the compiler
Reviewed-by: mcimadamore, jlahoda
2018-02-02 07:43:54 -05:00
Joe Darcy
69287b5b99 8196551: Update TestSourceVersion.java to be robust across version changes
Reviewed-by: vromero
2018-02-01 09:16:03 -08:00
Jesper Wilhelmsson
c2735a15d7 Merge 2018-02-01 02:05:35 +01:00
Liam Miller-Cushon
8641dcffca 8194268: Incorrect parameter names for synthetic methods
Reviewed-by: jlahoda, vromero
2018-01-26 11:27:53 -08:00
Liam Miller-Cushon
81a51d8c45 8179373: javac -verbose logs the class path multiple times
Reviewed-by: martin
2018-01-25 15:18:13 -08:00
Lana Steuck
8f528fba93 Merge 2018-01-18 18:58:46 +00:00
Maurizio Cimadamore
60764aee2a 8195598: Reference to overloaded method is ambiguous with 3 methods but works with 2
Pertinent to applicability bit set on argument expression even if only one method is not pertinent

Reviewed-by: vromero
2018-01-18 11:46:33 +00:00
Goetz Lindenmaier
22762d1cdc 8189102: All tools should support -?, -h and --help
Reviewed-by: kvn, jjg, weijun, alanb, rfield, ksrini
2018-01-16 08:48:34 +01:00
Lana Steuck
aad1a3592c Merge 2018-01-16 22:24:20 +00:00
Jesper Wilhelmsson
fb8bca78ee Merge 2018-01-05 22:02:20 +01:00
Maurizio Cimadamore
989b326949 8194932: no ambuguity error is emitted if classfile contains two identical methods with different return types
Add recovery logic when classfile contains two signature-equivalent methods

Reviewed-by: jlahoda, vromero
2018-01-12 16:49:58 +00:00
Jonathan Gibbons
a34fdd1809 8194893: javac -verbose prints wrong paths for output files
Reviewed-by: vromero
2018-01-11 15:06:55 -08:00
Lana Steuck
459909ddf3 Merge 2018-01-06 01:13:32 +00:00
Jonathan Gibbons
b1c9eceaf5 8191637: Interface with defaults invalid compiler warning for Serializable
Reviewed-by: vromero
2018-01-05 16:49:50 -08:00
Jonathan Gibbons
528109a976 8188649: javadoc -encoding doesn't work when using the old doclet API
Reviewed-by: ksrini
2018-01-05 12:41:28 -08:00
Jonathan Gibbons
a553dc6d76 8194069: doclint throws missing comment warnings on lines which can't even have javadoc
Reviewed-by: ksrini
2018-01-04 12:55:06 -08:00
Jonathan Gibbons
7030f25abd 8194141: Remove JDK9Wrappers
Reviewed-by: erikj, alanb
2018-01-04 10:14:50 -08:00
Lana Steuck
c8c8cd7238 Merge 2018-01-04 04:22:28 +00:00
Jonathan Gibbons
b5fa820c6e 8193125: javac should not compile a module if it requires java.base with modifiers
Reviewed-by: vromero
2018-01-03 11:10:56 -08:00
Jonathan Gibbons
8f93cb3651 8183964: Bad lexing of javadoc comments (change in parsing/rendering of backslashes in javadoc)
Reviewed-by: vromero, cushon
2018-01-02 16:07:47 -08:00
Vicente Romero
d1750de1fc 8187487: crash with classes with same binary name
Reviewed-by: jjg
2018-01-02 16:35:04 -05:00
Jonathan Gibbons
372bc7a281 8194955: Warn when default HTML version is used
Reviewed-by: ksrini, bpatel
2018-01-12 11:41:32 -08:00
Jonathan Gibbons
f811ca50b3 8181878: javadoc should support/ignore --add-opens
Reviewed-by: ksrini
2018-01-11 15:38:57 -08:00
Vicente Romero
e2f5722888 8187805: bogus RuntimeVisibleTypeAnnotations for unused local in a block
Reviewed-by: sadayapalam
2018-01-10 22:52:08 -05:00
Vicente Romero
ae186c5714 8194836: delta apply changesets for JDK-8192885 and JDK-8175883
Reviewed-by: mcimadamore
2018-01-09 22:30:20 -05:00
Joe Darcy
aa4c936f54 8189146: Have use of "var" in 9 and earlier source versions issue a warning for type declarations
Reviewed-by: mcimadamore, jjg
2018-01-16 17:27:06 -08:00
Joe Darcy
edd2c3b6ca 8187951: Update javax.lang.model.SourceVersion for "var" name
Reviewed-by: jjg, mcimadamore
2018-01-08 17:32:54 -08:00
Vicente Romero
a316ab9ef3 8187487: crash with classes with same binary name
Reviewed-by: jjg
2018-01-08 14:06:25 -05:00
Liam Miller-Cushon
3e0afd207d 8193216: Filer should warn if processors redefine symbols from the classpath or sourcepath
Reviewed-by: vromero
2017-12-21 15:58:45 -05:00
Paul Sandoz
038b5f571c 8191913: Bump classfile version number to 55
Co-authored-by: Erik Joelsson <erik.joelsson@oracle.com>
Reviewed-by: dholmes, darcy
2017-12-20 09:14:06 -08:00
Maurizio Cimadamore
ede41aa311 8057650: uniform error diagnostics for inconsistent inherited method signatures
Consolidate diagnostics for bad overrides

Reviewed-by: vromero
2017-12-20 15:33:31 +00:00
Liam Miller-Cushon
47158e4313 8007720: Names are not loaded correctly for method parameters if the parameters have annotations
8177486: Incorrect handling of mandated parameter names in MethodParameters attributes

Reviewed-by: jlahoda, vromero
2017-12-19 16:24:25 -05:00
Joe Darcy
691eb78732 8173382: Add -source 11 and -target 11 to javac
8193291: Add SourceVersion.RELEASE_11

Reviewed-by: jjg, erikj, psandoz
2017-12-18 18:51:40 -08:00
Jonathan Gibbons
5bcb718441 8178070: duplicate entries in package table
Reviewed-by: bpatel, ksrini
2017-12-13 17:27:43 -08:00
Jonathan Gibbons
be25eb7f0e 8191054: Remove the Native-Header Tool (javah)
Reviewed-by: darcy, mcimadamore, ksrini
2017-12-13 14:49:48 -08:00
Bhavesh Patel
1bf16ef2db 8164407: Add module support for -link and -linkoffline javadoc option
Reviewed-by: jjg, ksrini
2017-12-13 12:45:06 -08:00
Mandy Chung
0b0340fe0f 8193192: jdeps --generate-module-info does not look at module path
Reviewed-by: dfuchs
2017-12-12 11:31:38 -08:00
Srikanth Adayapalam
ac4e5933a6 8193142: Regression: ClassCastException: Type$ErrorType cannot be cast to Type$ArrayType
Reviewed-by: mcimadamore
2017-12-12 18:40:31 +05:30
Jan Lahoda
f9431b7d26 8189782: com.sun.tools.javac.api.JavacTool.isSupportedOption misreports number of arguments consumed
Returning the number of standalone arguments from com.sun.tools.javac.api.JavacTool.isSupportedOption.

Reviewed-by: jjg
2017-12-08 16:28:14 +01:00
Srikanth Adayapalam
18e476899c 8182401: Verification error for enclosing instance capture inside super constructor invocation
Reviewed-by: vromero
2017-12-11 06:58:14 +05:30
Kumar Srinivasan
c30bc22a0e 8034254: Don't use binary testing files broken.jar
Reviewed-by: jjg
2017-12-07 21:07:12 -08:00
Joe Darcy
62d672208a 8193191: Update JavacTestingAbstractProcessor for JDK 10
Reviewed-by: jjg
2017-12-07 11:00:32 -08:00
Vicente Romero
8c50b3e660 8192885: Compiler in JDK 10-ea+33 misses to include entry in LineNumberTable for goto instruction of foreach loop
Reviewed-by: mcimadamore
2017-12-06 13:36:34 -05:00
Chris Hegarty
a2000f8720 8179424: Remove terminally deprecated sun.reflect.Reflection.getCallerClass
Reviewed-by: alanb, dfuchs, dholmes, lancea, mchung, rriggs
2017-12-22 15:55:29 +00:00
Paul Sandoz
2c9ed8e178 8188870: Bump classfile version number to 54
Reviewed-by: alanb, dholmes, coleenp, mcimadamore
2017-11-03 10:01:08 -07:00
Maurizio Cimadamore
686d74f11e 8189749: Devise strategy for making source level checks more uniform
Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation

Reviewed-by: jjg, jlahoda
2017-12-04 17:54:49 +00:00
Jonathan Gibbons
da3e01d1ce 8034252: Fix non ASCII text file T6302184.java
Reviewed-by: ksrini
2017-12-01 16:58:11 -08:00
Kumar Srinivasan
e3c574e026 8190552: Augment the Compiler API tree with APIs to represent HTML content
Reviewed-by: jjg, jlahoda
2017-11-30 04:43:09 -08:00
Maurizio Cimadamore
3534ed0379 8191802: Upward projection result is A<? extends Number> instead of A<? super Integer>
Code in Types.TypeProjection doesn't match the latest spec text

Reviewed-by: vromero
2017-11-29 17:31:23 +00:00
Jan Lahoda
7cdac47d37 8191981: javac crash when detecting lambda candidates
Ensuring proper positions on the testing AST nodes created by Analyzer.

Reviewed-by: mcimadamore
2017-11-29 14:41:09 +01:00
Maurizio Cimadamore
93438246bc 8178427: NPE in Infer$CheckUpperBounds
Void target-type causes a crash during overload resolution

Reviewed-by: vromero
2017-11-28 18:51:55 +00:00
Jan Lahoda
9bb2c5a0b3 8133616: compiler error messages for dup single type, single static import switched
When reporting clashing imports, use the (non-)staticness of the original import to generate the error message.

Reviewed-by: mcimadamore
2017-11-27 19:29:00 +01:00
Mandy Chung
8cc39f4a10 Merge 2017-11-27 19:20:17 -08:00
Joe Darcy
14a3a70439 8191234: TypeKindVisitor needs to handle modules
Reviewed-by: jjg
2017-11-27 18:00:56 -08:00
Mandy Chung
26727aebf4 8190911: tools/jdeps/MultiReleaseJar.java failed with java.lang.IllegalThreadStateException
Reviewed-by: bpb
2017-11-27 14:41:59 -08:00
Vicente Romero
030e675ed3 8185451: Misleading 'cannot be accessed from outside package' diagnostic for inconsistent varargs override
Reviewed-by: mcimadamore
2017-11-27 13:26:31 -05:00
Vicente Romero
18f70cfdd2 8185983: Javac should reject TypeArguments on field access expression
Reviewed-by: mcimadamore
2017-11-27 10:40:42 -05:00
Maurizio Cimadamore
e196ae9be6 8191834: Assigning a void expression to a "var" crashes the compiler
Local variable type inference should give error on void initializers

Reviewed-by: sundar
2017-11-24 16:14:33 +00:00
Srikanth Adayapalam
14e7d88c9e 8191655: LambdaConversionException: Invalid receiver type interface; not a subtype of implementation type interface
Reviewed-by: mcimadamore
2017-11-22 18:07:53 +05:30
Jonathan Gibbons
3b8e460a1a 8156694: javap should render annotations in a friendly way
Reviewed-by: mcimadamore
2017-11-21 13:06:43 -08:00
Jan Lahoda
905ead0ac3 8191112: javac OutOfMemoryError caused by \"-Xlint:exports\" option
When validating type visibility, ignore transitive automatic modules dependencies.

Reviewed-by: abuckley, jjg
2017-11-21 10:26:45 +01:00
Srikanth Adayapalam
dfaa92ca05 8189659: Anonymous subtype of raw type causes VerifyError
Reviewed-by: mcimadamore
2017-11-21 13:27:12 +05:30
Priya Lakshmi Muthuswamy
acc6539ad3 8034258: Don't use binary testing class files
Reviewed-by: jjg, ksrini
2017-11-20 20:49:56 -08:00
Vicente Romero
eeb940463b 8175883: bytecode generated for the enhanced for loop may block memory garbage collecting
Reviewed-by: mcimadamore
2017-11-20 17:07:21 -05:00
Vicente Romero
cffac90ef9 8190906: tools/javac/failover/CheckAttributedTree.java failed with timeout
Reviewed-by: jjg, mcimadamore
2017-11-20 14:45:11 -05:00
Jan Lahoda
7a77a63845 8180744: Update ct.sym for JDK 10
Adding historical data and code support for --release 9.

Reviewed-by: jjg, mcimadamore
2017-11-06 14:10:39 +01:00
Jan Lahoda
5f97b69390 8139607: -release option forces StandardJavaFileManager
Merging a --release specific file manager with the user-provided one, rather than altering the user-provided one.

Reviewed-by: jjg, mcimadamore
2017-11-06 13:10:43 +01:00
Paul Sandoz
e55a05957d 8186209: Tool support for ConstantDynamic
8186046: Minimal ConstantDynamic support
8190972: Ensure that AOT/Graal filters out class files containing CONSTANT_Dynamic ahead of full AOT support

Co-authored-by: Lois Foltan <lois.foltan@oracle.com>
Co-authored-by: John Rose <john.r.rose@oracle.com>
Reviewed-by: acorn, coleenp, kvn
2017-09-08 10:46:46 -07:00
Jan Lahoda
c6be2c363a 8187681: Compiling for target 9 while also using --patch-module
Removing limitation on simultaneous use of --release and --patch-module for system modules.

Reviewed-by: mcimadamore, jjg
2017-11-02 11:16:27 +01:00
Jan Lahoda
de261554f7 8190315: Test tools/javac/tree/NoPrivateTypesExported.java failing
Constant annotation attribute values should be allowed.

Reviewed-by: vromero
2017-11-01 16:45:28 +01:00
Maurizio Cimadamore
f48f3c6552 8189838: Stack overflow when computing upward projection of an intersection type with fbounds
Bad logic for detecting loop in type-variable upper bounds

Reviewed-by: vromero
2017-10-26 18:42:40 +01:00
Jan Lahoda
a663434be7 8189796: Incorrect end position for missing statement
Recording end positions for error trees representing missing statements.

Co-authored-by: Dusan Balek <dusan.balek@oracle.com>
Reviewed-by: mcimadamore
2017-10-24 12:07:27 +02:00
Jan Lahoda
d84d8f1cc5 8188035: JavaFileManager.listLocationsForModules does not always reflect values set through StandardJavaFileManager.setLocationForModule
Prepending explictely set module locations in listLocationsForModules.

Reviewed-by: jjg
2017-10-19 10:59:02 +02:00
Mandy Chung
9ebc72545b 8189202: (jdeps) Need jdeps output format easy for jlink --add-modules to use
Reviewed-by: sundar
2017-10-17 10:32:01 -07:00
Jan Lahoda
7c3c83fb55 8181897: JDK 9 change to symlink handling affects SourceFile attributes
Using user provided path in toUri().

Reviewed-by: jjg
2017-06-26 17:00:45 +02:00
Jan Lahoda
f66b1c7a8b 8186694: JShell: speed-up compilation by reusing compiler instances
Generalizing ReusableContext and using it in JShell to speed up processing.

Reviewed-by: mcimadamore, rfield
2017-09-01 14:04:20 +02:00
Srikanth Adayapalam
b9d8d3bd9c 8184989: Incorrect class file created when passing lambda in inner class constructor and outer is subclass
Reviewed-by: mcimadamore
2017-10-16 14:30:37 +05:30
Maurizio Cimadamore
305e51848a 8169345: javac crash when local from enclosing context is captured multiple times
Captured variables imported from multiple enclosing scopes are not handled correctly

Reviewed-by: vromero
2017-10-09 13:03:18 +01:00
Jan Lahoda
a36938e082 8188225: AST could be improved in presence of var types
Adding a better start pos for vars; always adding a synthetic type tree to vars.

Reviewed-by: mcimadamore
2017-10-06 17:18:03 +02:00
Maurizio Cimadamore
9f2615c4de 8172443: Change use of tree.pos to line:col in rawDiagnostics
Generate more stable raw diagnostic position for functional expression AST diag arguments

Reviewed-by: jjg, vromero
2017-10-05 18:29:47 +01:00
Bernard Blaser
2115af4897 8063054: Incorrect raw type warning for method reference
Spurious raw types warnings generated for unbound method references

Reviewed-by: jlahoda
2017-10-05 12:19:23 +01:00
Bernard Blaser
47e2972a64 8187978: javac can show overload error messages that include non-valid candidates
Reviewed-by: mcimadamore
2017-10-02 10:04:22 -07:00
Maurizio Cimadamore
870b0834fe 8188144: regression in method reference type-checking
Method reference checking prefers unbound lookup when both searches produce same results

Reviewed-by: vromero
2017-10-02 12:29:44 +01:00
Joe Darcy
5d2a4c319a 8187982: Update SourceVersion to mention restricted keywords
Reviewed-by: mcimadamore
2017-09-27 14:23:41 -07:00
Maurizio Cimadamore
c825188cd8 8177466: Add compiler support for local variable type-inference
Add support for 'var' in implicitly typed local variable declarations

Reviewed-by: vromero, jlahoda
2017-09-26 12:52:53 +01:00
Jan Lahoda
4335a9a642 8187883: NewClassDefEnclosing.java fails on windows
Fixing whitespace normalization.

Reviewed-by: mcimadamore
2017-09-25 13:03:11 +02:00
Jan Lahoda
b45c9233a4 8044853: Attr synthesizes nullcheck tree nodes
Avoid move of JCNewClass.encl to args in front end phases.

Reviewed-by: jjg
2017-09-22 14:06:11 +02:00
Mandy Chung
21c1304c15 8187449: jdeps fails when an upgradeable module is upgraded with an automatic module
Reviewed-by: lancea, psandoz
2017-09-21 13:55:44 -07:00
Jan Lahoda
0fcaa36105 8184739: Incorrect end position of PackageTree
Fixing end position of PackageTree.

Reviewed-by: jjg
2017-09-21 17:47:34 +02:00
Erik Joelsson
3789983e89 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2017-09-12 19:03:39 +02:00