Commit Graph

1179 Commits

Author SHA1 Message Date
Aggelos Biboudis
3b0a6d2a68 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
Reviewed-by: mcimadamore, vromero
2023-09-13 15:09:01 +00:00
Joe Darcy
578ded4645 8312418: Add Elements.getEnumConstantBody
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: vromero
2023-09-08 22:06:24 +00:00
Qing Xiao
8f7e29b2cd 8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library
Reviewed-by: asotona
2023-09-07 15:37:25 +00:00
Aggelos Biboudis
81f8c57e4a 8314632: Intra-case dominance check fails in the presence of a guard
Reviewed-by: vromero
2023-09-07 12:51:37 +00:00
Jan Lahoda
726c9c977d 8315735: VerifyError when switch statement used with synchronized block
Reviewed-by: vromero
2023-09-07 11:08:55 +00:00
Pavel Rappo
a01b3fb8e9 8288660: JavaDoc should be more helpful if it doesn't recognize a tag
Reviewed-by: jjg
2023-09-06 07:51:14 +00:00
Jan Lahoda
94a74a0a45 8315534: Incorrect warnings about implicit annotation processing
Reviewed-by: darcy
2023-09-04 10:06:20 +00:00
Jan Lahoda
84425a6290 8315452: Erroneous AST missing modifiers for partial input
Reviewed-by: vromero
2023-09-04 09:14:16 +00:00
Jan Lahoda
adfc1d6cd2 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
Reviewed-by: vromero
2023-09-04 07:17:28 +00:00
Jonathan Gibbons
df5e6e5d48 8315248: AssertionError in Name.compareTo
Reviewed-by: vromero
2023-08-30 21:52:31 +00:00
Aggelos Biboudis
4331193010 8314423: Multiple patterns without unnamed variables
8314216: Case enumConstant, pattern compilation fails

Reviewed-by: jlahoda
2023-08-17 07:33:16 +00:00
Joe Darcy
c307391ab1 8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment
Reviewed-by: vromero, jjg
2023-08-09 21:17:10 +00:00
Pavel Rappo
593ba2fe47 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation
Reviewed-by: jlahoda, jjg
2023-08-09 16:08:23 +00:00
Jan Lahoda
a1115a7a39 8312204: unexpected else with statement causes compiler crash
Reviewed-by: vromero
2023-08-08 09:28:21 +00:00
Qing Xiao
380418fad0 8295058: test/langtools/tools/javac 116 test classes uses com.sun.tools.classfile library
Reviewed-by: asotona
2023-08-07 15:49:11 +00:00
Jan Lahoda
c386091734 8312984: javac may crash on a record pattern with too few components
Reviewed-by: vromero
2023-08-03 08:37:15 +00:00
Jim Laskey
bc1d2eac9a 8312821: Javac accepts char literal as template
Reviewed-by: jlahoda
2023-08-02 21:01:44 +00:00
Jim Laskey
f14245b388 8312814: Compiler crash when template processor type is a captured wildcard
Reviewed-by: jlahoda, mcimadamore, vromero
2023-08-02 00:47:20 +00:00
Qing Xiao
97b688340e 8295059: test/langtools/tools/javap 12 test classes use com.sun.tools.classfile library
Reviewed-by: asotona
2023-07-31 15:03:05 +00:00
Jan Lahoda
cc2a75e11c 8312619: Strange error message when switching over long
Reviewed-by: vromero
2023-07-26 10:35:15 +00:00
Jan Lahoda
1f81e5b19e 8312229: Crash involving yield, switch and anonymous classes
Reviewed-by: vromero
2023-07-26 09:44:50 +00:00
Joe Darcy
cb82c954e3 8312415: Expand -Xlint:serial checks to enum constants with specialized class bodies
Reviewed-by: jjg, jlahoda
2023-07-25 18:57:32 +00:00
Joe Darcy
61ab27087e 8310835: Address gaps in -Xlint:serial checks
Reviewed-by: rriggs, jjg
2023-07-20 01:10:46 +00:00
Aggelos Biboudis
1fc726a8b3 8312163: Crash in dominance check when compiling unnamed patterns
Reviewed-by: jlahoda
2023-07-18 11:41:36 +00:00
Jan Lahoda
a4412166ec 8311815: Incorrect exhaustivity computation
Reviewed-by: vromero
2023-07-17 08:19:51 +00:00
Jan Lahoda
1c9691b1f7 8312093: Incorrect javadoc comment text
Reviewed-by: jlaskey
2023-07-17 06:43:16 +00:00
Jan Lahoda
d1fa1a8686 8311825: Duplicate qualified enum constants not detected
Reviewed-by: vromero
2023-07-14 09:54:56 +00:00
Jan Lahoda
bbb7ce5137 8311038: Incorrect exhaustivity computation
Reviewed-by: vromero
2023-07-14 08:21:48 +00:00
Matthias Baesken
25cbe85d6f 8310550: Adjust references to rt.jar
Reviewed-by: erikj, clanger
2023-07-07 06:57:23 +00:00
Joe Darcy
3df36c4f10 8310061: Note if implicit annotation processing is being used
Reviewed-by: briangoetz, vromero, jjg
2023-06-28 21:00:28 +00:00
Archie Cobbs
a08352f621 8305671: javac rejects semicolons in compilation units with no imports
Reviewed-by: vromero
2023-06-26 19:05:00 +00:00
Joe Darcy
815ac6eeb3 8310907: Add missing file
Reviewed-by: jjg
2023-06-26 18:14:32 +00:00
Joe Darcy
289f218a32 8310861: Improve location reporting for javac serial lint warnings
Reviewed-by: jlahoda
2023-06-26 16:56:40 +00:00
Mandy Chung
556831d1bf 8310460: Remove jdeps -profile option
Reviewed-by: alanb
2023-06-23 17:03:02 +00:00
Jan Lahoda
01623f6a57 8310133: Effectivelly final condition not enforced in guards for binding variables from the same case
Reviewed-by: vromero
2023-06-21 09:16:12 +00:00
Jan Lahoda
a15db1a56c 8302865: Illegal bytecode for break from if with instanceof pattern matching condition
Reviewed-by: vromero
2023-06-21 09:15:48 +00:00
Jan Lahoda
4ca548fe74 8310326: Incorrect position of the synthetic unnamed class
Reviewed-by: jlaskey
2023-06-20 10:34:52 +00:00
Jan Lahoda
79069c5e74 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
Reviewed-by: jlaskey
2023-06-20 07:02:49 +00:00
Archie Cobbs
bcc4d36857 8309511: Regression test ExtraImportSemicolon.java refers to the wrong bug
Reviewed-by: vromero
2023-06-16 22:49:22 +00:00
Liam Miller-Cushon
53abba3a5a 8309499: javac fails to report compiler.err.no.java.lang with annotation processing enabled
Co-authored-by: Paula Toth <paulatoth@google.com>
Reviewed-by: vromero
2023-06-16 16:43:22 +00:00
Aggelos Biboudis
32243ef47d 8310128: Switch with unnamed patterns erroneously non-exhaustive
Reviewed-by: vromero, jlahoda
2023-06-16 07:03:28 +00:00
Pavel Rappo
3e0bbd290c 8285368: Overhaul doc-comment inheritance
6376959: Algorithm for Inheriting Method Comments seems to go not as documented
6934301: Support directed inheriting of class comments with @inheritDoc

Reviewed-by: jjg, rriggs, aivanov, smarks, martin
2023-06-15 17:47:41 +00:00
Jan Lahoda
408cadb351 8309467: Pattern dominance should be adjusted
Reviewed-by: vromero
2023-06-12 08:15:53 +00:00
Joe Darcy
7d82479096 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
Reviewed-by: jjg
2023-06-09 19:56:14 +00:00
Joe Darcy
5a706fb403 8306584: Start of release updates for JDK 22
8306585: Add SourceVersion.RELEASE_22
8306586: Add source 22 and target 22 to javac

Reviewed-by: erikj, iris, dholmes, jlahoda, alanb
2023-06-08 16:02:21 +00:00
Joe Darcy
c24b0bada2 8309503: Improve javax.lang.model tests for JEP 445
Reviewed-by: jlahoda, jjg, jlaskey
2023-06-07 17:55:47 +00:00
Hannes Wallnöfer
0a4f9ad637 8292157: Incorrect error: "block element not allowed within inline element <a>"
Reviewed-by: jjg
2023-06-06 19:33:35 +00:00
Jim Laskey
98b53c06cf 8306112: Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview)
8308613: javax.lang.model updates for JEP 445 (preview)
8308913: Update core reflection for JEP 445 (preview)

Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org>
Co-authored-by: Joe Darcy <darcy@openjdk.org>
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Jim Laskey <jlaskey@openjdk.org>
Co-authored-by: Adam Sotona <asotona@openjdk.org>
Reviewed-by: mcimadamore, vromero, darcy
2023-06-05 18:45:39 +00:00
Jan Lahoda
b6c9232b8b 8305225: A service broken error despite annotation processor generating it if directives listed
Reviewed-by: asotona
2023-06-05 06:30:44 +00:00
Jan Lahoda
05fb6c6648 8309336: Incorrect switch in enum not reported properly
Reviewed-by: vromero
2023-06-05 06:25:00 +00:00
Aggelos Biboudis
8007599756 8309093: Underscore with brackets
Reviewed-by: jlahoda
2023-06-02 06:14:57 +00:00
Aggelos Biboudis
4f3a95af2f 8309054: Parsing of erroneous patterns succeeds
Reviewed-by: jlahoda
2023-05-31 09:37:58 +00:00
Joe Darcy
cb40db052c 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
Reviewed-by: jjg
2023-05-30 21:58:50 +00:00
Christian Stein
d87713440a 8144891: ToolBox should use java.nio.file.Path internally, instead of java.io.File
Reviewed-by: jjg
2023-05-25 08:56:42 +00:00
Aggelos Biboudis
4500bb7a67 8308727: Compiler should accept final unnamed variables in try-with-resources
Reviewed-by: jlahoda
2023-05-25 08:10:02 +00:00
Guoxiong Li
a291f002cd 8288619: Unexpected parsing for @see
Reviewed-by: jjg
2023-05-25 03:25:50 +00:00
Jan Lahoda
1cfb265bef 8307814: In the case of two methods with Record Patterns, the second one contains a line number from the first method
Reviewed-by: vromero, godin
2023-05-23 11:47:00 +00:00
Aggelos Biboudis
80d7de7074 8305582: Compiler crash when compiling record patterns with var
Reviewed-by: vromero, jlahoda
2023-05-23 11:18:55 +00:00
Aggelos Biboudis
8aa50288a1 8302344: Compiler Implementation for Unnamed patterns and variables (Preview)
8307444: java.lang.AssertionError when using unnamed patterns
8307482: Compiler should accept var _ in nested patterns in switch case
8307007: Implementation for javax.lang.model for unnamed variables (Preview)
8308312: Compiler should fail when a local variable declaration does not include an Identifier and does not have an initializer
8308309: Compiler should accept mixed masked and unmasked variables in lambda parameters

Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Aggelos Biboudis <abimpoudis@openjdk.org>
Reviewed-by: vromero, darcy
2023-05-22 08:52:36 +00:00
Jan Lahoda
eaa80ad08c 8300543: Compiler Implementation for Pattern Matching for switch
8300545: Compiler Implementation for Record Patterns

Co-authored-by: Aggelos Biboudis <abimpoudis@openjdk.org>
Reviewed-by: vromero, mcimadamore
2023-05-22 04:24:06 +00:00
Joe Darcy
42ecc8a37f 8308245: Add -proc:full to describe current default annotation processing policy
Reviewed-by: vromero
2023-05-18 17:05:28 +00:00
Joe Darcy
29b8242e07 8307954: Update string template regression tests to be robust on release updates
Reviewed-by: jlaskey
2023-05-11 18:22:10 +00:00
Jim Laskey
4aa65cbeef 8285932: Implementation of JEP 430 String Templates (Preview)
Reviewed-by: mcimadamore, rriggs, darcy
2023-05-10 11:34:01 +00:00
Liam Miller-Cushon
8c106b0c8e 8303784: no-@Target annotations should be applicable to type parameter declarations
Reviewed-by: vromero
2023-05-02 18:19:03 +00:00
Jonathan Gibbons
b76f320e76 8307123: Fix deprecation warnings in DPrinter
Reviewed-by: vromero
2023-05-02 16:54:39 +00:00
Archie Cobbs
d437c61f5b 8305672: Surprising definite assignment error after JDK-8043179
Reviewed-by: kcr, vromero
2023-05-01 13:23:37 +00:00
Hannes Greule
b3dbf28bc0 8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default
Co-authored-by: Chen Liang <liach@openjdk.org>
Reviewed-by: vromero, jwaters
2023-04-30 07:34:09 +00:00
Stuart Marks
17ce0976e4 8266571: Sequenced Collections
Reviewed-by: alanb
2023-04-25 15:19:08 +00:00
Christian Stein
2471919020 8304036: Use CommandLine class from shared module
Reviewed-by: jjg, mchung
2023-04-25 04:16:58 +00:00
Archie L. Cobbs
e0620b8e05 8296420: javac has long lines in its command-line help
Reviewed-by: jjg
2023-04-13 15:08:55 +00:00
Jonathan Gibbons
022290bdbd 8305620: Missing break in DocCommentParser inlineWord()
Reviewed-by: iris
2023-04-05 14:39:51 +00:00
Jan Lahoda
2aec910ea4 8304883: Record Deconstruction causes bytecode error
Reviewed-by: vromero
2023-04-05 10:29:22 +00:00
Archie L. Cobbs
c1f5ca115d 8303623: Compiler should disallow non-standard UTF-8 string encodings
Reviewed-by: vromero
2023-03-28 16:14:37 +00:00
Archie L. Cobbs
14b970dc9e 8296656: java.lang.NoClassDefFoundError exception on running fully legitimate code
8287885: Local classes cause ClassLoader error if the type names are similar but not same

Reviewed-by: vromero
2023-03-27 21:33:01 +00:00
Jan Lahoda
138cdc9283 8304694: Runtime exception thrown when break stmt is missing
Reviewed-by: vromero
2023-03-27 15:01:45 +00:00
Archie L. Cobbs
f96aee7401 8291154: Create a non static nested class without enclosing class throws VerifyError
Reviewed-by: vromero
2023-03-24 14:13:21 +00:00
Archie L. Cobbs
ac6af6a640 7176515: ExceptionInInitializerError for an enum with multiple switch statements
8299760: ExceptionInInitializerError for an enum with multiple switch statements, follow-up

Reviewed-by: vromero
2023-03-23 21:17:47 +00:00
Archie L. Cobbs
6fa25cc134 8184444: The compiler error "variable not initialized in the default constructor" is not apt in case of static final variables
Reviewed-by: vromero
2023-03-23 16:06:47 +00:00
Archie L. Cobbs
4b8f7db6be 8027682: javac wrongly accepts semicolons in package and import decls
Reviewed-by: vromero
2023-03-23 16:04:35 +00:00
Archie L. Cobbs
c00d0885ae 8043179: Lambda expression can mutate final field
Reviewed-by: vromero
2023-03-23 15:59:51 +00:00
Jan Lahoda
63d4afbeb1 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers
Reviewed-by: vromero, darcy
2023-03-23 08:35:25 +00:00
Archie L. Cobbs
91f407d6fe 8029301: Confusing error message for array creation method reference
Reviewed-by: vromero
2023-03-22 21:00:27 +00:00
Jonathan Gibbons
80e979720a 8304433: cleanup sentence breaker code in DocTreeMaker
Reviewed-by: hannesw
2023-03-20 15:14:25 +00:00
Archie L. Cobbs
e339e183c1 7016187: javac -h could generate conflict .h for inner class and class name with '_'
Reviewed-by: vromero
2023-03-18 17:32:00 +00:00
Archie L. Cobbs
8f5bb538ab 8015831: Add lint check for calling overridable methods from a constructor
6557145: Warn about calling abstract methods in constructors

Reviewed-by: ihse, vromero, mcimadamore
2023-03-17 22:05:50 +00:00
Pavel Rappo
f81e1def8f 8303882: Refactor some iterators in jdk.compiler
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: mcimadamore
2023-03-14 18:36:46 +00:00
Archie L. Cobbs
1e3c9fd67e 8026369: javac potentially ambiguous overload warning needs an improved scheme
Reviewed-by: vromero
2023-02-28 03:33:14 +00:00
Archie L. Cobbs
55e6bb6b85 8302685: Some javac unit tests aren't reliably closing open files
Reviewed-by: darcy, vromero
2023-02-27 16:21:57 +00:00
Jan Lahoda
dc55a7fc87 8302202: Incorrect desugaring of null-allowed nested patterns
Reviewed-by: vromero
2023-02-17 12:55:47 +00:00
Vicente Romero
de80dd9c15 8296010: AssertionError in annotationTargetType
Reviewed-by: jjg
2023-02-16 19:06:26 +00:00
Archie L. Cobbs
a58fa6e73e 8302514: Misleading error generated when empty class file encountered
Reviewed-by: vromero, jwaters
2023-02-16 14:48:39 +00:00
Vicente Romero
1480d418e3 8208470: Type annotations on inner type that is an array component
Co-authored-by: Bernard Blaser <bsrbnd@openjdk.org>
Reviewed-by: jlahoda
2023-02-16 04:01:12 +00:00
Vicente Romero
ca73f7e80f 8301374: NullPointerException in MemberEnter.checkReceiver
Reviewed-by: jlahoda
2023-02-14 18:59:37 +00:00
Vicente Romero
2ef001e097 8207017: Type annotations on anonymous classes in initializer blocks not written to class file
Reviewed-by: jlahoda
2023-02-14 14:27:29 +00:00
Aggelos Biboudis
3b05a94c36 8301858: Verification error when compiling switch with record patterns
Reviewed-by: vromero
2023-02-09 16:03:34 +00:00
Jonathan Gibbons
873558ee80 8300914: Allow @ as an escape in documentation comments
Reviewed-by: prappo
2023-02-08 21:57:22 +00:00
Jonathan Gibbons
74485a3f23 8301810: Bug in doctree DocCommentTester.compress
Reviewed-by: prappo
2023-02-07 18:48:02 +00:00
Vicente Romero
a73d012c72 8295019: Cannot call a method with a parameter of a local class declared in a lambda
Reviewed-by: mcimadamore
2023-02-07 16:23:52 +00:00
Archie L. Cobbs
07fb4f9a0b 7167356: (javac) investigate failing tests in JavacParserTest
Reviewed-by: vromero
2023-02-06 20:28:08 +00:00
Jonathan Gibbons
d53ade12a8 8301813: Bad caret position in error message
Reviewed-by: iris
2023-02-06 18:41:04 +00:00
Archie L. Cobbs
8c01b6e66b 8221580: Confusing diagnostic for assigning a static final field in a constructor
Reviewed-by: vromero
2023-02-06 18:22:22 +00:00
Jan Lahoda
522fa13274 8301580: Error recovery does not clear returnResult
Reviewed-by: vromero
2023-02-06 12:25:06 +00:00
Aggelos Biboudis
7ac2079ba7 8301025: ClassCastException in switch with generic record
Reviewed-by: jlahoda
2023-02-06 12:24:21 +00:00
Jonathan Gibbons
24ff3da054 8301201: Allow \n@ inside inline tags using inlineContent
Reviewed-by: hannesw
2023-02-01 18:28:42 +00:00
Vicente Romero
6beadbbe9f 8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations
Reviewed-by: jlahoda
2023-01-31 18:20:11 +00:00
Joe Darcy
b5a4744f90 8300857: State return value for Types.asElement(NoType) explicitly
Reviewed-by: jjg
2023-01-26 02:14:07 +00:00
Jesper Wilhelmsson
81d523d382 Merge 2023-01-24 22:28:07 +00:00
Jan Lahoda
a3ed7e94a2 8300623: Lambda deserialization regression involving Enum method reference
Reviewed-by: mcimadamore, vromero
2023-01-24 06:40:06 +00:00
Jesper Wilhelmsson
fc9f8baf56 Merge 2023-01-18 23:29:12 +00:00
Jan Lahoda
c1b4212a53 8300195: Fall-through issue occurs when using record pattern in switch statements
Reviewed-by: vromero
2023-01-18 10:43:53 +00:00
Archie L. Cobbs
382fe51b6d 8163229: several regression tests have a main method that is never executed
Reviewed-by: vromero
2023-01-17 04:43:40 +00:00
Jesper Wilhelmsson
33f3bd8fad Merge 2023-01-11 21:50:42 +00:00
Jan Lahoda
636976ada8 8299849: Revert JDK-8294461: wrong effectively final determination by javac
Reviewed-by: vromero
2023-01-11 07:52:18 +00:00
Archie L. Cobbs
679e485838 8043251: Bogus javac error: required: no arguments, found: no arguments
Reviewed-by: vromero
2023-01-09 18:38:15 +00:00
Archie L. Cobbs
44be5edf5a 8219810: javac throws NullPointerException
Reviewed-by: vromero
2023-01-04 17:50:32 +00:00
Archie L. Cobbs
4c0f24ef71 8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id
Reviewed-by: vromero
2023-01-04 16:00:22 +00:00
Jonathan Gibbons
5d330f5285 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943
Reviewed-by: vromero
2022-12-19 21:09:01 +00:00
Archie L. Cobbs
40cb431fee 8298943: Missing escapes for single quote marks in compiler.properties
Reviewed-by: jjg
2022-12-19 19:48:13 +00:00
Jesper Wilhelmsson
3696711efa Merge 2022-12-16 15:48:24 +00:00
Jan Lahoda
22a6b59102 8298727: Trees.getPath may crash for unnamed package
Reviewed-by: vromero
2022-12-15 11:33:56 +00:00
Jesper Wilhelmsson
715bf70459 Merge 2022-12-09 22:00:12 +00:00
Jan Lahoda
52fffdd2c8 8298463: tools/javac/modules/EdgeCases.java fails on Windows after JDK-8297988
Reviewed-by: jjg
2022-12-09 16:41:26 +00:00
Jan Lahoda
133ad8e173 8297988: NPE in JavacTypes.getOverriddenMethods from doclint
Reviewed-by: vromero, jjg
2022-12-09 11:11:46 +00:00
Joe Darcy
175e3d3ff3 8296149: Start of release updates for JDK 21
8296150: Add SourceVersion.RELEASE_21
8296151: Add source 21 and target 21 to javac

Reviewed-by: dholmes, iris, erikj, vromero, jlahoda
2022-12-08 16:04:00 +00:00
Jan Lahoda
cf63f2e3ea 8298184: Incorrect record component type in record patterns
Reviewed-by: vromero
2022-12-07 12:03:50 +00:00
Aggelos Biboudis
1e468320dc 8297602: Compiler crash with type annotation and generic record during pattern matching
Reviewed-by: jlahoda
2022-12-06 13:00:10 +00:00
Srikanth Adayapalam
ee9ba74564 8295184: Printing messages with a RecordComponentElement does not include position
Reviewed-by: vromero
2022-12-06 04:23:40 +00:00
Jan Lahoda
2300ed458d 8291769: Translation of switch with record patterns could be improved
Reviewed-by: vromero
2022-12-05 12:04:23 +00:00
Jan Lahoda
777fb52ef5 8297974: ClassCastException in com.sun.tools.javac.comp.AttrRecover.doRecovery
Reviewed-by: vromero
2022-12-05 09:33:42 +00:00
Aggelos Biboudis
2cb64a7557 8294943: Implement record patterns in enhanced for
8296802: Parse errors when deconstructing a record using the enhanced for loop of JEP 432

Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Aggelos Biboudis <abimpoudis@openjdk.org>
Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org>
Reviewed-by: mcimadamore, vromero
2022-12-01 12:40:09 +00:00
Jan Lahoda
b60cce6f3b 8297118: Change IncompatibleClassChangeError to MatchException for exhaustive switch statements and switch expressions
Reviewed-by: vromero
2022-12-01 10:51:57 +00:00
Jan Lahoda
756dd5bb0d 8294942: Compiler implementation for Record Patterns (Second Preview)
8294945: Compiler implementation for Pattern Matching for switch (Fourth Preview)

Co-authored-by: Aggelos Biboudis <abimpoudis@openjdk.org>
Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org>
Reviewed-by: mcimadamore, vromero
2022-12-01 08:02:40 +00:00
Jan Lahoda
b52611bc36 8295401: Error recovery in module-info.java could be improved
Reviewed-by: vromero
2022-11-30 09:49:51 +00:00
Jan Lahoda
9e80cf9c37 8296390: Incremental build failed with a NPE
Reviewed-by: vromero
2022-11-30 09:47:48 +00:00
Jaikiran Pai
e10778acce 8297695: Fix typos in test/langtools files
Co-authored-by: Michael Ernst <mernst@openjdk.org>
Reviewed-by: prappo, jjg, iris
2022-11-30 00:42:40 +00:00
Bo Zhang
33587ffd35 8292625: jshell crash on "var a = a"
Reviewed-by: jlaskey, jlahoda
2022-11-29 13:57:56 +00:00
Weijun Wang
2deb318c9f 8297065: DerOutputStream operations should not throw IOExceptions
Reviewed-by: mullan, valeriep
2022-11-29 12:57:46 +00:00
Aggelos Biboudis
6c05771b9b 8295447: NullPointerException with invalid pattern matching construct in constructor call
Reviewed-by: vromero
2022-11-26 15:53:00 +00:00
Srikanth Adayapalam
544e317225 8059632: Method reference compilation uses incorrect qualifying type
Reviewed-by: mcimadamore
2022-11-21 03:02:29 +00:00
Magnus Ihse Bursie
4527dc67be 8297041: Remove the last remnants of sjavac
Reviewed-by: cstein, erikj, jjg
2022-11-17 09:20:22 +00:00
Joe Darcy
e2269fd2ca 8296968: Update langtools tests to use @enablePreview
Reviewed-by: sundar, jjg
2022-11-17 00:49:53 +00:00
Vicente Romero
3eb789af74 8296171: Compiler incorrectly rejects code with variadic method references
Reviewed-by: mcimadamore
2022-11-14 18:31:26 +00:00
Weijun Wang
27527b4975 8296612: CertAttrSet is useless
Reviewed-by: mullan
2022-11-10 22:23:58 +00:00
Vicente Romero
60db5f2ba2 8294020: improve errors for record declarations
Reviewed-by: jlahoda
2022-11-07 20:16:04 +00:00
Jonathan Gibbons
f8b2574ebc 8296137: diags-examples.xml is broken
Reviewed-by: iris, vromero, ihse
2022-11-07 15:58:42 +00:00
Joe Darcy
97c5a64d5c 8296287: Improve documentation for Types.directSupertypes()
Reviewed-by: jlahoda, prappo
2022-11-04 16:22:09 +00:00
Hannes Wallnöfer
5622b09565 8200337: Generalize see and link tags for user-defined anchors
Reviewed-by: jjg
2022-11-04 14:57:43 +00:00
Vicente Romero
7a85441a85 8232933: Javac inferred type does not conform to equality constraint
Reviewed-by: mcimadamore
2022-11-03 12:08:23 +00:00
Weijun Wang
da0ae5128a 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
Reviewed-by: alanb
2022-11-01 15:14:19 +00:00
Archie L. Cobbs
b8ad6cd98a 8294461: wrong effectively final determination by javac
Reviewed-by: vromero
2022-10-27 15:58:46 +00:00
Srikanth Adayapalam
4d9a1cd26f 8292159: TYPE_USE annotations on generic type arguments of record components discarded
Reviewed-by: vromero
2022-10-27 04:56:22 +00:00
Vicente Romero
6707bfbc15 8029633: Raw inner class constructor ref should not perform diamond inference
Reviewed-by: jlahoda
2022-10-20 15:43:10 +00:00
Jan Lahoda
7bc9692a51 8294670: Enhanced switch statements have an implicit default which does not complete normally
Reviewed-by: vromero
2022-10-20 15:21:26 +00:00
Vicente Romero
95dd376ba2 8291914: generated constructors are considered compact when they shouldn't
Reviewed-by: darcy, jlahoda
2022-10-20 14:58:56 +00:00
Archie L. Cobbs
9b971626f7 7039014: Confusing error message for method conflict
Reviewed-by: vromero
2022-10-20 13:58:09 +00:00
Jan Lahoda
78dc497786 8294550: Sealed check for casts isn't applied to array components
Reviewed-by: vromero
2022-10-20 13:01:12 +00:00
Magnus Ihse Bursie
d5a1521fde 8295470: Update openjdk.java.net => openjdk.org URLs in test code
Reviewed-by: michaelm, prr, darcy
2022-10-20 10:33:18 +00:00
Jan Lahoda
71aa821091 8295176: some langtools test pollutes source tree
Reviewed-by: sadayapalam, darcy, vromero
2022-10-18 07:45:23 +00:00
Srikanth Adayapalam
cf07eaeb92 8295020: javac emits incorrect code for for-each on an intersection type.
Reviewed-by: mcimadamore
2022-10-17 07:40:19 +00:00
Archie L. Cobbs
786ce1c27b 8295024: Cyclic constructor error is non-deterministic and inconsistent
Reviewed-by: vromero
2022-10-14 13:52:50 +00:00
Srikanth Adayapalam
cf84c8eaf2 8292975: javac produces code that crashes with LambdaConversionException
8269983: BootstrapMethodError with method reference and intersection type

Reviewed-by: dlsmith, vromero
2022-10-07 04:20:40 +00:00
Joe Darcy
0ec18382b7 8294869: Correct failure of RemovedJDKInternals.java after JDK-8294618
Reviewed-by: alanb, azvegint
2022-10-05 19:27:20 +00:00
Matthias Baesken
f531dae4a0 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
Reviewed-by: alanb
2022-10-05 14:41:29 +00:00
Matthias Baesken
953ce8da2c 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
Reviewed-by: mchung
2022-10-05 07:34:42 +00:00
Jonathan Gibbons
090cdfc7a2 8294726: Update URLs in minefield tests
Reviewed-by: darcy, iris
2022-10-03 20:20:53 +00:00
Jonathan Gibbons
e137f9f2f0 8293877: Rewrite MineField test
Reviewed-by: vromero, martin, darcy, jlahoda
2022-10-03 17:08:37 +00:00
Jonathan Gibbons
b88ee1ee22 6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec)
Reviewed-by: hannesw
2022-09-26 21:28:39 +00:00
Jan Lahoda
0be2b2c2f1 8292756: java.lang.AssertionError at at jdk.compiler/com.sun.tools.javac.code.Scope$ScopeImpl.leave(Scope.java:386)
Reviewed-by: vromero
2022-09-22 14:33:07 +00:00
Jan Lahoda
95ec2eaca3 8293897: Synthetic final modifier is part of the AST for a try-with-resource resource
Reviewed-by: sundar
2022-09-21 12:29:40 +00:00
Jan Lahoda
39cd1635bf 8293578: Duplicate ldc generated by javac
Reviewed-by: mcimadamore
2022-09-16 11:37:45 +00:00
Adam Sotona
aff5ff14b2 8244681: Add a warning for possibly lossy conversion in compound assignments
8293797: Release Note: Javac warns about type casts in compound assignments with possible lossy conversions

Reviewed-by: erikj, prr
2022-09-15 10:10:23 +00:00
Jan Lahoda
2a3879180e 8292755: Non-default method in interface leads to a stack overflow in JShell
Reviewed-by: vromero
2022-09-14 08:51:03 +00:00
Aggelos Biboudis
1169a15936 8291657: Javac assertion when compiling a method call with switch expression as argument
Reviewed-by: jlahoda
2022-09-14 06:48:01 +00:00
Vicente Romero
46e6e41b9a 8293051: Further refactor javac after removal of -source/-target/--release 7
Reviewed-by: darcy, mcimadamore
2022-09-08 14:36:19 +00:00
Jan Lahoda
c0ee30a25a 8293348: A false cyclic inheritance error reported
Reviewed-by: vromero
2022-09-08 14:10:06 +00:00
Jan Lahoda
26f2a978f6 8290561: Coalesce incubator-module warnings for single-file source-code programs
Reviewed-by: mcimadamore
2022-09-06 09:27:48 +00:00
Joe Darcy
3ac91b08cb 8293003: Review running time of Warn5 regression test
Reviewed-by: vromero
2022-09-02 02:53:59 +00:00
Joe Darcy
2d18dda3f2 8173605: Remove support for source and target 1.7 option in javac
Reviewed-by: vromero
2022-09-01 16:43:50 +00:00
Aggelos Biboudis
9444a081cc 8290709: Incorrect dominance error for unconditional pattern vs. null
Reviewed-by: jlahoda
2022-09-01 16:09:03 +00:00
Jan Lahoda
0c40128fec 7194212: NPE in Flow.visitIdent
Reviewed-by: vromero
2022-08-12 08:12:28 +00:00
Joe Darcy
0657acf534 8289249: Add methods to Elements for record constructors
Reviewed-by: vromero
2022-08-05 22:18:59 +00:00
Vicente Romero
3ba317167d 8285935: Spurious lint warning for static method accessed through instance qualifier
Reviewed-by: jlahoda
2022-08-04 17:57:28 +00:00
Vicente Romero
67f001186b 8260892: Compilation fails: lambda parameter not visible in body when generics involved
Reviewed-by: jlahoda
2022-08-03 19:19:34 +00:00
Joe Darcy
cc2861a993 8290901: Reduce use of -source in langtools tests
Reviewed-by: jjg
2022-07-29 17:35:22 +00:00
Aggelos Biboudis
64a1a08ff9 8289647: AssertionError during annotation processing of record related tests
Reviewed-by: vromero
2022-07-29 16:02:18 +00:00
Aggelos Biboudis
f5a7de8627 8290379: Parse error with parenthesized pattern and guard using an array
Reviewed-by: jlahoda
2022-07-19 09:03:28 +00:00
Vicente Romero
f3abb82989 8268312: Compilation error with nested generic functional interface
Reviewed-by: mcimadamore
2022-07-15 13:06:03 +00:00
Jesper Wilhelmsson
c79baaa811 Merge 2022-07-11 16:15:49 +00:00
Aggelos Biboudis
bba6be79e0 8269674: Improve testing of parenthesized patterns
Reviewed-by: jlahoda
2022-07-11 11:13:55 +00:00
Jan Lahoda
25f4b04365 8289894: A NullPointerException thrown from guard expression
Reviewed-by: vromero
2022-07-11 08:59:32 +00:00
Jonathan Gibbons
54b4576f78 8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
Reviewed-by: hannesw
2022-07-08 19:33:03 +00:00
Vicente Romero
9c86c82091 8282714: synthetic arguments are being added to the constructors of static local classes
Reviewed-by: jlahoda
2022-07-08 17:24:27 +00:00
Jesper Wilhelmsson
01b9f95c62 Merge 2022-07-08 02:07:36 +00:00
Jan Lahoda
8dd94a2c14 8289196: Pattern domination not working properly for record patterns
Reviewed-by: vromero
2022-07-07 07:54:18 +00:00
Jesper Wilhelmsson
86dc760f9e Merge 2022-06-28 22:11:23 +00:00
Jonathan Gibbons
a814293e1f 8275784: Bogus warning generated for record with compact constructor
Reviewed-by: prappo
2022-06-28 15:54:52 +00:00
Jesper Wilhelmsson
d4b040f42d Merge 2022-06-27 18:25:53 +00:00
Vicente Romero
53b37fe153 8288130: compiler error with AP and explicit record accessor
Reviewed-by: jlahoda
2022-06-24 21:42:23 +00:00
Jan Lahoda
bdf9902f75 8288120: VerifyError with JEP 405 pattern match
Reviewed-by: vromero
2022-06-24 08:13:28 +00:00
Jonathan Gibbons
53a0acee06 8286101: Support formatting in @value tag
Reviewed-by: prappo
2022-06-13 18:13:21 +00:00
Joe Darcy
edff51e5fd 8284858: Start of release updates for JDK 20
8286035: Add source 20 and target 20 to javac
8286034: Add SourceVersion.RELEASE_20

Reviewed-by: dholmes, kcr, iris, erikj, jjg, ihse
2022-06-09 16:16:49 +00:00
Magnus Ihse Bursie
f7791ad0ea 8287895: Some langtools tests fail on msys2
Reviewed-by: jjg
2022-06-08 14:04:48 +00:00
Joe Darcy
32dd1eef88 8287967: Update golden test files after JDK-8287886
Reviewed-by: dholmes
2022-06-08 01:59:50 +00:00
Jan Lahoda
2f62f15b09 8287808: javac generates illegal class file for pattern matching switch with records
Reviewed-by: sundar
2022-06-07 13:41:24 +00:00
Adam Sotona
905bcbe34e 8286571: java source launcher from a minimal jdk image containing jdk.compiler fails with --enable-preview option
Reviewed-by: jlahoda
2022-06-07 13:38:56 +00:00
Jan Lahoda
bde7a7ae03 8287236: Reorganize AST related to pattern matching for switch
Reviewed-by: mcimadamore
2022-06-07 10:31:09 +00:00
Jonathan Gibbons
deb06539b0 8287337: SnippetUtils should throw exceptions if snippets not found
Reviewed-by: hannesw
2022-06-02 23:53:23 +00:00
Raffaello Giulietti
72bcf2aa03 4511638: Double.toString(double) sometimes produces incorrect results
Reviewed-by: aturbanov, darcy, bpb
2022-06-01 21:53:54 +00:00
Jan Lahoda
171a7cdd5d 8286895: InternalError: Exception during analyze
Reviewed-by: vromero
2022-05-31 15:01:38 +00:00
Jan Lahoda
7ef6993576 8276836: Error in javac caused by switch expression without result expressions: Internal error: stack sim error
Reviewed-by: vromero
2022-05-31 11:04:50 +00:00
Pavel Rappo
3d6d7b7e73 8287338: tools/javac/api/snippets/TestJavaxToolsSnippets.java failing tier1 on all platforms
Reviewed-by: jjg
2022-05-25 19:44:12 +00:00
Jonathan Gibbons
7156f98e32 8279513: jdk/javadoc/doclet/testDocletExample/TestDocletExample.java fails after 8278795
Reviewed-by: prappo
2022-05-25 17:45:02 +00:00
Jan Lahoda
e9bddc18ab 8262889: Compiler implementation for Record Patterns
Co-authored-by: Brian Goetz <briangoetz@openjdk.org>
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Co-authored-by: Aggelos Biboudis <abimpoudis@openjdk.org>
Reviewed-by: mcimadamore, vromero
2022-05-25 11:56:24 +00:00
Alexey Ivanov
9b7e42c0f0 8284209: Replace remaining usages of 'a the' in source code
Reviewed-by: lancea, wetmore, dfuchs, iris, jjg, ihse
2022-05-24 20:08:11 +00:00
Alexey Ivanov
e0d361cea9 8284191: Replace usages of 'a the' in hotspot and java.base
Reviewed-by: lancea, wetmore, naoto, iris, kevinw, xuelei
2022-05-24 11:25:13 +00:00
Aggelos Biboudis
9473c383c6 8286057: Make javac error on a generic enum friendlier
Reviewed-by: jlahoda
2022-05-24 10:31:11 +00:00
Pavel Rappo
7c0864752a 8287099: Clean up terminology regarding doc comment descriptions.
Reviewed-by: jjg
2022-05-21 08:48:11 +00:00
Aggelos Biboudis
fd36f3730e 8286797: Guards of constant value false are not permitted
Reviewed-by: vromero
2022-05-19 16:11:24 +00:00
Jan Lahoda
c0d51d42d9 8282080: Lambda deserialization fails for Object method references on interfaces
Reviewed-by: vromero, mcimadamore
2022-05-17 13:48:45 +00:00
Aleksey Shipilev
8c977050aa 8286475: Drop --enable-preview from instanceof pattern matching related tests
Reviewed-by: darcy
2022-05-17 08:49:23 +00:00
Jan Lahoda
77dfbb4570 8178701: Compile error with switch statement on protected enum defined in parent inner class
Reviewed-by: vromero
2022-05-16 11:53:09 +00:00
Jan Lahoda
0155e4b76b 8282274: Compiler implementation for Pattern Matching for switch (Third Preview)
Co-authored-by: Brian Goetz <briangoetz@openjdk.org>
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: mcimadamore, vromero, abimpoudis
2022-05-16 07:49:26 +00:00
Jan Lahoda
e4439ca32a 8284283: javac crashes when several transitive supertypes are missing
Reviewed-by: vromero
2022-05-12 13:40:21 +00:00
Vikey Chen
7d545084f4 8283606: Tests may fail with zh locale on MacOS
Reviewed-by: iklam, rriggs
2022-05-05 00:06:24 +00:00
Liam Miller-Cushon
4d30a1e8d1 8284220: TypeMirror#toString omits enclosing class names after JDK-8281238
Reviewed-by: darcy
2022-05-04 20:25:36 +00:00
Jonathan Gibbons
28e6d805f4 8285869: Selective cleanup in doclint Checker class
Reviewed-by: iris, prappo
2022-05-04 20:23:23 +00:00
Srikanth Adayapalam
1e28fcbc5f 8155701: The compiler fails with an AssertionError: typeSig ERROR
Reviewed-by: vromero
2022-04-29 05:04:23 +00:00
Jonathan Gibbons
21b62fef33 8195589: T6587786.java failed after JDK-8189997
Reviewed-by: iris, vromero
2022-04-29 00:34:26 +00:00
Jonathan Gibbons
8190217971 8285496: DocLint does not check for missing @param tags for type parameters on classes and interfaces
Reviewed-by: darcy, iris
2022-04-29 00:32:56 +00:00
Jonathan Gibbons
3312d8c620 8285756: clean up use of bad arguments for @clean in langtools tests
Reviewed-by: darcy
2022-04-27 22:22:28 +00:00
Jonathan Gibbons
20a132d460 8284994: -Xdoclint:all returns warning for records, even when documented properly
Reviewed-by: vromero
2022-04-26 15:42:18 +00:00
Jan Lahoda
4c22a9bcf9 8282823: javac should constrain more uses of preview APIs
Reviewed-by: jlaskey, mcimadamore, vromero
2022-04-25 09:10:44 +00:00
Pavel Rappo
d6b5a63577 8284908: Refine diagnostic positions for DCErroneous
Reviewed-by: jjg
2022-04-21 08:57:16 +00:00
Jonathan Gibbons
7920e8ba42 8283714: REDO - Unexpected TypeElement in ANALYZE TaskEvent
8284030: Standard Doclet should not attempt to link to primitive types

Reviewed-by: vromero, jlahoda, prappo
2022-04-12 23:33:26 +00:00
Vicente Romero
1bd8975caf 8284361: Updating ASM to 9.3 for JDK 19
Reviewed-by: mchung
2022-04-08 17:01:15 +00:00
Naoto Sato
d6b4693c05 8283698: Refactor Locale constructors used in src/test
Reviewed-by: iris, joehw
2022-04-08 15:23:25 +00:00
Vicente Romero
36b9baa70d 8282508: Updating ASM to 9.2 for JDK 19
Reviewed-by: lancea, egahlin, mchung
2022-04-04 15:05:00 +00:00
Jaikiran Pai
ec0897ab80 8281705: SourceLauncherTest.testSystemProperty isn't being run
Reviewed-by: jjg
2022-03-31 01:09:39 +00:00
Jan Lahoda
a577656772 8282943: Unused weird key in compiler.properties
Reviewed-by: vromero
2022-03-28 14:53:14 +00:00
Jonathan Gibbons
5ca8b91898 8283713: [BACKOUT] Unexpected TypeElement in ANALYZE TaskEvent
Reviewed-by: prr
2022-03-25 23:21:08 +00:00
Jonathan Gibbons
36b36efa12 8283661: Unexpected TypeElement in ANALYZE TaskEvent
Reviewed-by: vromero, jlahoda
2022-03-25 21:16:51 +00:00
Magnus Ihse Bursie
f8878cb0cc 8257733: Move module-specific data from make to respective module
Reviewed-by: jjg, weijun, naoto, erikj, prr, alanb, mchung
2022-03-21 21:34:09 +00:00
Matteo Baccan
ccad39237a 8282657: Code cleanup: removing double semicolons at the end of lines
Reviewed-by: lancea, rriggs, ihse, prr, iris, wetmore, darcy, dholmes
2022-03-07 21:33:40 +00:00
Joe Darcy
732d891f9f 8282411: Add useful predicates to ElementKind
Reviewed-by: prappo
2022-03-01 18:48:43 +00:00
Aleksey Shipilev
86723d4892 8281507: Two javac tests have bad jtreg @clean tags
Reviewed-by: darcy
2022-02-28 07:35:19 +00:00
Jonathan Gibbons
99b8ed9dbf 8281217: Source file launch with security manager enabled fails
Reviewed-by: sundar
2022-02-23 16:49:28 +00:00
Jan Lahoda
e3365041bd 8280866: SuppressWarnings does not work properly in package-info and module-info
Reviewed-by: darcy, vromero
2022-02-18 11:04:11 +00:00
Jaikiran Pai
d4cd8dfedb 8281634: jdeps: java.lang.InternalError: Missing message: err.invalid.filters
Reviewed-by: dfuchs, naoto, mchung
2022-02-15 03:53:47 +00:00
Magnus Ihse Bursie
95f198b2b1 8274980: Improve adhoc build version strings
Reviewed-by: shade, erikj
2022-02-14 10:31:42 +00:00
Joe Darcy
6fdfe0458d 8281674: tools/javac/annotations/typeAnnotations/classfile/AnonymousExtendsTest.java fails with AssertionError
Reviewed-by: vromero
2022-02-12 01:33:41 +00:00